[PATCH] D35955: clang-format: Add preprocessor directive indentation

djasper added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:1182 +**IndentPPDirectives** (``bool``) + Indent preprocessor directives on conditionals. I think we can foresee that a bool is not going to be enough here. Make this an enum, which

[PATCH] D35743: [clang-format] Handle Structured binding declaration in C++17

djasper added a comment. Please add all the tests into unittests/Format/FormatTest.cpp instead. We use FileCheck-based tests only to verify the behavior of the clang-format binary itself. https://reviews.llvm.org/D35743 ___ cfe-commits mailing

[PATCH] D35817: Ban implicit _Complex to scalar conversions in C++

hfinkel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3068 +def err_impcast_complex_scalar : Error< + "implicit conversion discards imaginary component: %0 to %1">; def warn_impcast_float_precision : Warning< I think that,

[PATCH] D36118: Fix creating bitcasts with wrong address space

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D36118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxxabi] r309349 - [demangler] Fix some overzealous -Wreturn-type errors

On 7/31/17 11:44 AM, David Blaikie wrote: On Thu, Jul 27, 2017 at 6:35 PM Erik Pilkington via cfe-commits > wrote: Author: epilk Date: Thu Jul 27 18:35:14 2017 New Revision: 309349 URL:

[libcxxabi] r309650 - [demangler] Fix another bug found by oss-fuzz in r309340

Author: epilk Date: Mon Jul 31 19:38:41 2017 New Revision: 309650 URL: http://llvm.org/viewvc/llvm-project?rev=309650=rev Log: [demangler] Fix another bug found by oss-fuzz in r309340 Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp Modified:

[libcxxabi] r309649 - [demangler] Use _LIBCPP_UNREACHABLE()

Author: epilk Date: Mon Jul 31 19:38:40 2017 New Revision: 309649 URL: http://llvm.org/viewvc/llvm-project?rev=309649=rev Log: [demangler] Use _LIBCPP_UNREACHABLE() Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_demangle.cpp URL:

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang added a comment. @mstorsjo I see that spec2000/eon calls __getReg, _ReadStatusReg and _WriteStatusReg intrinsics for ARM64. I think I would need to implement them in llvm. Do you know where can I find a doc explaining their behavior? https://reviews.llvm.org/D36111

[PATCH] D36122: Thread Safety Analysis: fix assert_capability.

jmgao created this revision. Previously, the assert_capability attribute was completely ignored by thread safety analysis. https://reviews.llvm.org/D36122 Files: include/clang/Basic/Attr.td lib/Analysis/ThreadSafety.cpp lib/Sema/SemaDeclAttr.cpp

r309640 - Use -target instead of -arch in test case.

Author: ahatanak Date: Mon Jul 31 16:08:52 2017 New Revision: 309640 URL: http://llvm.org/viewvc/llvm-project?rev=309640=rev Log: Use -target instead of -arch in test case. Modified: cfe/trunk/test/Driver/darwin-version.c Modified: cfe/trunk/test/Driver/darwin-version.c URL:

r309636 - Silence warning -Wmissing-sysroot.

Author: ahatanak Date: Mon Jul 31 15:46:00 2017 New Revision: 309636 URL: http://llvm.org/viewvc/llvm-project?rev=309636=rev Log: Silence warning -Wmissing-sysroot. Modified: cfe/trunk/test/Driver/darwin-version.c Modified: cfe/trunk/test/Driver/darwin-version.c URL:

[PATCH] D35914: [mips] Add support -m(no-)embedded-data option

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r309635 - Re-apply r309622 with a fix for MSVC.

Author: pcc Date: Mon Jul 31 15:35:33 2017 New Revision: 309635 URL: http://llvm.org/viewvc/llvm-project?rev=309635=rev Log: Re-apply r309622 with a fix for MSVC. Patch by Vlad Tsyrklevich! Added: cfe/trunk/test/CodeGenCXX/cfi-vcall-no-trap.cpp Modified:

[PATCH] D35743: [clang-format] Handle Structured binding declaration in C++17

yawanng added a comment. Ping. https://reviews.llvm.org/D35743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

yawanng added a comment. Ping. https://reviews.llvm.org/D35372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309634: Add powerpc64 to compiler-rt build infrastructure. (authored by saugustine). Changed prior to commit: https://reviews.llvm.org/D36108?vs=109015=109017#toc Repository: rL LLVM

[PATCH] D36118: Fix creating bitcasts with wrong address space

arsenm created this revision. Herald added subscribers: Anastasia, tpr, wdng. In a future commit AMDGPU will start passing aggregates directly to more functions, triggering asserts in test/CodeGenOpenCL/addr-space-struct-arg.cl https://reviews.llvm.org/D36118 Files: lib/CodeGen/CGCall.cpp

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

saugustine added a comment. In https://reviews.llvm.org/D36108#826673, @timshen wrote: > Offline discussion discovered that __clear_cache() is not implemented for > powerpc64 (the big-endian target). I think it's correct to use the same > implementation of __clear_cache() for both endianness.

r309633 - [Driver] Make sure the deployment target is earlier than iOS 11 when

Author: ahatanak Date: Mon Jul 31 15:19:34 2017 New Revision: 309633 URL: http://llvm.org/viewvc/llvm-project?rev=309633=rev Log: [Driver] Make sure the deployment target is earlier than iOS 11 when it is inferred from -isysroot. This fixes a change that was inadvertently introduced in r309607.

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

saugustine updated this revision to Diff 109015. saugustine added a comment. - The current powerpc implementation of clear cache works for big endian. https://reviews.llvm.org/D36108 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/cmake/builtin-config-ix.cmake

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc updated this revision to Diff 108999. mibintc added a comment. This patch responds to @fedor.sergeev 's feedback from earlier today. This is a change to the test case test/Driver/stdc-predef.c in the situation that the system does not supply a version of stdc-predef.h. Fedor had

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

timshen accepted this revision. timshen added a comment. This revision is now accepted and ready to land. Offline discussion discovered that __clear_cache() is not implemented for powerpc64 (the big-endian target). I think it's correct to use the same implementation of __clear_cache() for both

RE: [PATCH] D34158: For standards compatibility, preinclude if the file is available

fedor.sergeev added inline comments. Comment at: test/Driver/stdc-predef.c:15 + /* In this test, the file stdc-predef.h is missing from the +installation */ #if _STDC_PREDEF_H + #error "stdc-predef.h should not be included" I would rather see a real check

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:49 // Memory barrier +BUILTIN(__dmb, "vUi", "nc") +BUILTIN(__dsb, "vUi", "nc") mstorsjo wrote: > mgrang wrote: > > mstorsjo wrote: > > > Shouldn't these be limited to MSVC mode

Re: [PATCH] D35783: Ignore shadowing for declarations coming from within macros.

On Mon, Jul 31, 2017 at 9:57 PM, David Blaikie wrote: > > > On Tue, Jul 25, 2017 at 1:19 AM Roman Lebedev via Phabricator via > cfe-commits wrote: >> >> lebedev.ri added a comment. >> >> How does this relate to the gcc behavior? >> I suspect not

r309626 - Move RTEMS to OSTargets.h

Author: waltl Date: Mon Jul 31 14:00:16 2017 New Revision: 309626 URL: http://llvm.org/viewvc/llvm-project?rev=309626=rev Log: Move RTEMS to OSTargets.h Differential Revision: https://reviews.llvm.org/D36106 Modified: cfe/trunk/lib/Basic/Targets/OSTargets.h

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:49 // Memory barrier +BUILTIN(__dmb, "vUi", "nc") +BUILTIN(__dsb, "vUi", "nc") mgrang wrote: > mstorsjo wrote: > > Shouldn't these be limited to MSVC mode only? Have a look at

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth updated this revision to Diff 108997. Nebiroth added a comment. Implemention of Code Hover as described in LSP definition. Removed unintentional changes to formatting. Removed file id field in Location struct. https://reviews.llvm.org/D35894 Files: clangd/ClangdLSPServer.cpp

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth added a comment. I had missed a typo in the code, should be fixed and compiling properly now. https://reviews.llvm.org/D35894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r309624 - Revert r309622, "Fix logic for generating llvm.type.test()s"

Author: pcc Date: Mon Jul 31 13:53:16 2017 New Revision: 309624 URL: http://llvm.org/viewvc/llvm-project?rev=309624=rev Log: Revert r309622, "Fix logic for generating llvm.type.test()s" Caused a bot test failure: http://bb.pgr.jp/builders/test-clang-msc-x64-on-i686-linux-RA/builds/5325 Removed:

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:49 // Memory barrier +BUILTIN(__dmb, "vUi", "nc") +BUILTIN(__dsb, "vUi", "nc") mstorsjo wrote: > Shouldn't these be limited to MSVC mode only? Have a look at > `BuiltinsARM.def`,

[PATCH] D36013: Fix logic for generating llvm.type.test()s

This revision was automatically updated to reflect the committed changes. Closed by commit rL309622: Fix logic for generating llvm.type.test()s (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D36013?vs=108702=108994#toc Repository: rL LLVM

r309622 - Fix logic for generating llvm.type.test()s

Author: pcc Date: Mon Jul 31 13:45:14 2017 New Revision: 309622 URL: http://llvm.org/viewvc/llvm-project?rev=309622=rev Log: Fix logic for generating llvm.type.test()s CodeGenFunction::EmitTypeMetadataCodeForVCall() could output an llvm.assume(llvm.type.test())when CFI was enabled, optimizing

[PATCH] D36096: [ubsan] Make the 'vptr check disabled' warning more helpful

vsk abandoned this revision. vsk added a comment. Abandoned in favor of https://reviews.llvm.org/D36112, since it turns out -fsanitize=null,vptr doesn't work for some use cases. https://reviews.llvm.org/D36096 ___ cfe-commits mailing list

[PATCH] D36112: [ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't available

vsk created this revision. In r309007, I made -fsanitize=null a hard prerequisite for -fsanitize=vptr. I did not see the need for the two checks to have separate null checking logic for the same pointer. I expected the two checks to either always be enabled together, or to be mutually

[PATCH] D36100: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL309620: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36100?vs=108971=108992#toc Repository:

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL309619: [AArch64] Don't define __LP64__ when targeting Windows (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36098?vs=108968=108991#toc Repository: rL LLVM

r309620 - [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

Author: mstorsjo Date: Mon Jul 31 13:40:59 2017 New Revision: 309620 URL: http://llvm.org/viewvc/llvm-project?rev=309620=rev Log: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well Differential Revision: https://reviews.llvm.org/D36100 Modified:

[PATCH] D36099: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL309618: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36099?vs=108969=108990#toc Repository:

r309618 - [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

Author: mstorsjo Date: Mon Jul 31 13:40:48 2017 New Revision: 309618 URL: http://llvm.org/viewvc/llvm-project?rev=309618=rev Log: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c Differential Revision: https://reviews.llvm.org/D36099 Modified:

r309619 - [AArch64] Don't define __LP64__ when targeting Windows

Author: mstorsjo Date: Mon Jul 31 13:40:53 2017 New Revision: 309619 URL: http://llvm.org/viewvc/llvm-project?rev=309619=rev Log: [AArch64] Don't define __LP64__ when targeting Windows Windows/ARM64 is a LLP64 environment, so don't set this default define. Differential Revision:

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mstorsjo added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:49 // Memory barrier +BUILTIN(__dmb, "vUi", "nc") +BUILTIN(__dsb, "vUi", "nc") Shouldn't these be limited to MSVC mode only? Have a look at `BuiltinsARM.def`, where there's

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang added a comment. Related llvm patch: https://reviews.llvm.org/D36110 https://reviews.llvm.org/D36111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb

mgrang created this revision. Herald added subscribers: kristof.beyls, javed.absar, aemerson. https://reviews.llvm.org/D36111 Files: include/clang/Basic/BuiltinsAArch64.def test/CodeGen/builtins-arm64.c Index: test/CodeGen/builtins-arm64.c

r309616 - [X86] Remove -O3 from tbm-builtins.c test file.

Author: ctopper Date: Mon Jul 31 13:21:53 2017 New Revision: 309616 URL: http://llvm.org/viewvc/llvm-project?rev=309616=rev Log: [X86] Remove -O3 from tbm-builtins.c test file. A change to InstCombine broke this test, but we generally frown on running optimizations clang tests anyway. So I've

[PATCH] D36108: Add powerpc64 to compiler-rt build infrastructure.

saugustine created this revision. Herald added subscribers: aheejin, mgorny, dberris, nemanjai. Add powerpc64 to compiler-rt build infrastructure. https://reviews.llvm.org/D36108 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/cmake/builtin-config-ix.cmake

[PATCH] D35849: [UBSan] Provide default blacklist filename for UBSan

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. This lgtm, we shouldn't defer this until https://reviews.llvm.org/D32842 is done, as that may take a while. https://reviews.llvm.org/D35849 ___

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

vsk added a comment. In https://reviews.llvm.org/D32842#826383, @shenhan wrote: > Ping? Can we make a decision on this? > I've this simple one D35849: [UBSan] Provide default blacklist filename for > UBSan which, depending on this, shall be > discarded or

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth updated this revision to Diff 108979. Nebiroth marked 19 inline comments as done. Nebiroth added a comment. Implemention of Code Hover as described in LSP definition. Removed unintentional changes to formatting. Removed file id field in Location struct. https://reviews.llvm.org/D35894

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

> On Jul 31, 2017, at 12:30 PM, Nico Weber wrote: > > On Mon, Jul 31, 2017 at 1:18 PM, Vedant Kumar > wrote: > The bot should start working again with -fsanitize=vptr,null. > > The warning can be improved. If we find

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

mstorsjo added inline comments. Comment at: lib/Basic/Targets/AArch64.cpp:466-467 + case CC_X86ThisCall: + case CC_X86FastCall: + case CC_X86VectorCall: +return CCCR_Ignore; rnk wrote: > Do they really ignore __fastcall and __vectorcall on arm64? > > I

[PATCH] D36099: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D36099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

rnk added inline comments. Comment at: lib/Basic/Targets/AArch64.cpp:466-467 + case CC_X86ThisCall: + case CC_X86FastCall: + case CC_X86VectorCall: +return CCCR_Ignore; Do they really ignore __fastcall and __vectorcall on arm64? I assume __thiscall and

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

rnk accepted this revision. rnk added a comment. lgtm https://reviews.llvm.org/D36098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36100: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D36100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36105: [AArch64] Ignore stdcall and similar on aarch64/windows

mstorsjo created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. This is similar to what's done on arm and x86_64, where these calling conventions are silently ignored, as in SVN r245076 (https://reviews.llvm.org/D12034).

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

On Mon, Jul 31, 2017 at 1:18 PM, Vedant Kumar wrote: > The bot should start working again with -fsanitize=vptr,null. > > The warning can be improved. If we find -fno-sanitize=null in the argument > list, we might say: > implicitly disabling vptr sanitizer because

[PATCH] D36101: Fix usage of right shift operator in fold expressions

Rakete created this revision. The right shift operator was not seen as a valid operator in a fold expression, which is PR32563. https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp test/CXX/expr/expr.prim/expr.prim.fold/p2.cpp Index:

[PATCH] D36100: [Attr] Make TargetWindows and TargetMicrosoftCXXABI match on aarch64 as well

mstorsjo created this revision. Herald added subscribers: kristof.beyls, rengolin, aemerson. https://reviews.llvm.org/D36100 Files: include/clang/Basic/Attr.td test/Sema/dllimport.c Index: test/Sema/dllimport.c === ---

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

mgrang accepted this revision. mgrang added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r309607 - [Driver] Allow users to silence the warning that is issued when the

Author: ahatanak Date: Mon Jul 31 12:16:40 2017 New Revision: 309607 URL: http://llvm.org/viewvc/llvm-project?rev=309607=rev Log: [Driver] Allow users to silence the warning that is issued when the deployment target is earlier than iOS 11 and the target is 32-bit. This is a follow-up to r306922.

[PATCH] D36099: [test] Fix mistagged CHECK-NOT-lines for AARCH64-DARWIN in Preprocessor/init.c

mstorsjo created this revision. Herald added subscribers: kristof.beyls, rengolin, aemerson. https://reviews.llvm.org/D36099 Files: test/Preprocessor/init.c Index: test/Preprocessor/init.c === --- test/Preprocessor/init.c +++

[PATCH] D36098: [AArch64] Don't define __LP64__ when targeting Windows

mstorsjo created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. Windows/ARM64 is a LLP64 environment, so don't set this default define. https://reviews.llvm.org/D36098 Files: lib/Basic/Targets/AArch64.cpp test/Preprocessor/init.c Index:

[PATCH] D36074: [x86][inline-asm]Allow a pack of Control Debug to be properly picked

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D36074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

On Thu, Jul 27, 2017 at 8:30 AM Dehao Chen via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > danielcdh marked an inline comment as done. > danielcdh added a comment. > > Thanks for the review! > > In https://reviews.llvm.org/D35746#822498, @chandlerc wrote: > > > LGTM with a

[PATCH] D35449: [X86] Implement __builtin_cpu_is

erichkeane added a comment. In https://reviews.llvm.org/D35449#826381, @craig.topper wrote: > @erichkeane are you ok with this code for now? I think validateCPUIs gives > you what you need at least for Sema support for target attribute. You'll > probably need to refactor the CG code to make

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

shenhan added a comment. Ping? Can we make a decision on this? I've this simple one D35849: [UBSan] Provide default blacklist filename for UBSan which, depending on this, shall be discarded or move forward. If this CL stalls, I'll seek to proceed with

[PATCH] D35449: [X86] Implement __builtin_cpu_is

craig.topper added a comment. @erichkeane are you ok with this code for now? I think validateCPUIs gives you what you need at least for Sema support for target attribute. You'll probably need to refactor the CG code to make your ifunc resolver. But I think you need to do that for the existing

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh updated this revision to Diff 108967. twoh added a comment. Update documentation. Please let me know if I need to update other documents as well. Thanks! https://reviews.llvm.org/D34796 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td

Re: [PATCH] D35783: Ignore shadowing for declarations coming from within macros.

On Tue, Jul 25, 2017 at 1:19 AM Roman Lebedev via Phabricator via cfe-commits wrote: > lebedev.ri added a comment. > > How does this relate to the gcc behavior? > I suspect not everyone would want to have this relaxed `-Wshadow` mode. > Generally I think the goal

Re: r309496 - Improve readability of CXX method overrides list

Test coverage? On Sun, Jul 30, 2017 at 5:52 AM Lenar Safin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: lll > Date: Sat Jul 29 13:42:58 2017 > New Revision: 309496 > > URL: http://llvm.org/viewvc/llvm-project?rev=309496=rev > Log: > Improve readability of CXX method overrides

Re: [libcxxabi] r309349 - [demangler] Fix some overzealous -Wreturn-type errors

On Thu, Jul 27, 2017 at 6:35 PM Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: epilk > Date: Thu Jul 27 18:35:14 2017 > New Revision: 309349 > > URL: http://llvm.org/viewvc/llvm-project?rev=309349=rev > Log: > [demangler] Fix some overzealous -Wreturn-type errors >

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

+ Nico, sorry I missed your email in the reply-all. Here's a revised version of the warning: https://reviews.llvm.org/D36096 vedant > On Jul 31, 2017, at 10:18 AM, Vedant Kumar via cfe-commits > wrote: > > The bot should start

[PATCH] D35564: Suppress -pedantic warnings about GNU extension StmtExpr in glibc's assert macro

raj.khem added a comment. There is a proposed fix for glibc's assert here https://sourceware.org/ml/libc-alpha/2017-07/msg00227.html despite that, this patch in general seems useful. https://reviews.llvm.org/D35564 ___ cfe-commits mailing list

[PATCH] D36096: [ubsan] Make the 'vptr check disabled' warning more helpful

vsk created this revision. If -fsanitize=vptr is passed without -fsanitize=null being specified, it will say: warning: implicitly disabling vptr sanitizer because null checking wasn't enabled (try specifying -fsanitize=null or -fsanitize=undefined) Otherwise if the vptr check is enabled and

[PATCH] D36072: [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL309598: [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC) (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36072?vs=108865=108954#toc Repository:

r309598 - [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC)

Author: mstorsjo Date: Mon Jul 31 11:17:38 2017 New Revision: 309598 URL: http://llvm.org/viewvc/llvm-project?rev=309598=rev Log: [Targets] Move addCygMingDefines into the arch-independent Targets.cpp (NFC) This fixes a dependency inconsistency, where addMinGWDefines in Targets.cpp (used from

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

arphaman added a comment. It might make sense to add a breakpoint at `PartialDiagnostic(unsigned DiagID, StorageAllocator )`, I'll check how that works. I reckon it should be possible to have a script that could find the name of all emitted diagnostics. Let's say we'd like to run clang with

Re: r309488 - [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

Thanks! r309588. On Mon, Jul 31, 2017 at 10:25 AM, Craig Topper wrote: > We can merge all three patches to 5.0. > > ~Craig > > On Mon, Jul 31, 2017 at 9:59 AM, Hans Wennborg wrote: >> >> Craig, Simon asked for this to be merged to 5.0 together with

[PATCH] D36083: [utils] Add a script that runs clang in LLDB and stops it when a specified diagnostic is emitted

hintonda added a comment. Cool, I'll try to play with this later today. BTW, since the call to DiagnosticsEngine::Report is delayed when using PartialDiagnostic, would it make sense to add them as well? Also, this doesn't seem to solve the initial problem of finding the Diag name in the first

Re: r309488 - [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

We can merge all three patches to 5.0. ~Craig On Mon, Jul 31, 2017 at 9:59 AM, Hans Wennborg wrote: > Craig, Simon asked for this to be merged to 5.0 together with r309382 > and r309383 for PR33830. What do you think? > > On Sat, Jul 29, 2017 at 8:33 AM, Simon Pilgrim via

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

ilya-biryukov added a comment. In https://reviews.llvm.org/D36095#826275, @bkramer wrote: > lg (it could use a test case though) Will add a test case in one of further commits. Repository: rL LLVM https://reviews.llvm.org/D36095 ___

Re: r309484 - Fix incorrect assertion condition.

Thank you! vedant > On Jul 29, 2017, at 1:18 AM, Victor Leschuk via cfe-commits > wrote: > > Author: vleschuk > Date: Sat Jul 29 01:18:38 2017 > New Revision: 309484 > > URL: http://llvm.org/viewvc/llvm-project?rev=309484=rev > Log: > Fix incorrect assertion

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

The bot should start working again with -fsanitize=vptr,null. The warning can be improved. If we find -fno-sanitize=null in the argument list, we might say: implicitly disabling vptr sanitizer because "-fno-sanitize=null" was specified Otherwise we might say: implicitly disabling vptr sanitizer

[PATCH] D34158: For standards compatibility, preinclude if the file is available

fedor.sergeev added inline comments. Comment at: test/Driver/stdc-predef.c:15 + /* In this test, the file stdc-predef.h is missing from the installation */ +#if _STDC_PREDEF_H + #error "stdc-predef.h should not be included" I would rather see a real check on

[clang-tools-extra] r309585 - [clangd] Allow to get vfs::FileSystem used inside codeComplete.

Author: ibiryukov Date: Mon Jul 31 10:09:29 2017 New Revision: 309585 URL: http://llvm.org/viewvc/llvm-project?rev=309585=rev Log: [clangd] Allow to get vfs::FileSystem used inside codeComplete. Summary: This is useful for managing lifetime of VFS-based caches. Reviewers: bkramer, krasimir

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309585: [clangd] Allow to get vfs::FileSystem used inside codeComplete. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D36095 Files:

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev added a comment. ping? https://reviews.llvm.org/D35755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309503 - PR33902: Invalidate line number cache when adding more text to existing buffer.

r309580. Thanks! On Sat, Jul 29, 2017 at 11:33 PM, Richard Smith wrote: > We should take this fix for Clang 5. > > On 29 July 2017 at 23:31, Richard Smith via cfe-commits > wrote: >> >> Author: rsmith >> Date: Sat Jul 29 23:31:29 2017 >> New

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg (it could use a test case though) https://reviews.llvm.org/D36095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35817: Ban implicit _Complex to scalar conversions in C++

t.p.northover added a comment. Ping. https://reviews.llvm.org/D35817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309488 - [X86][AVX] Ensure vector non-temporal load/store intrinsics force pointer alignment (PR33830)

Craig, Simon asked for this to be merged to 5.0 together with r309382 and r309383 for PR33830. What do you think? On Sat, Jul 29, 2017 at 8:33 AM, Simon Pilgrim via cfe-commits wrote: > Author: rksimon > Date: Sat Jul 29 08:33:34 2017 > New Revision: 309488 > > URL:

[PATCH] D36095: [clangd] Allow to get vfs::FileSystem used inside codeComplete.

ilya-biryukov created this revision. This is useful for managing lifetime of VFS-based caches. https://reviews.llvm.org/D36095 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h Index: clangd/ClangdServer.h === ---

r309575 - [OPENMP] Change the name of outer non-debug function in debug mode, NFC.

Author: abataev Date: Mon Jul 31 09:43:06 2017 New Revision: 309575 URL: http://llvm.org/viewvc/llvm-project?rev=309575=rev Log: [OPENMP] Change the name of outer non-debug function in debug mode, NFC. Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp Modified:

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

davidxl added a comment. The patch is missing documentation change. https://reviews.llvm.org/D34796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

/sub I believe Vedant asked for this to be merged to 5.0, so I'd like to merge the resolution too. On Mon, Jul 31, 2017 at 8:51 AM, Nico Weber via cfe-commits wrote: > Hi Vedant, > > after this change our ubsanvptr bot fails like so: > > clang-6.0: error: implicitly

Re: r308996 - [coroutines] Add serialization/deserialization of coroutines

Richard, Gor asked for this to be merged to 5.0. What do you think? On Tue, Jul 25, 2017 at 11:01 AM, Gor Nishanov via cfe-commits wrote: > Author: gornishanov > Date: Tue Jul 25 11:01:49 2017 > New Revision: 308996 > > URL:

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

twoh added a comment. Ping. Thanks! https://reviews.llvm.org/D34796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309007 - [ubsan] Null-check pointers in -fsanitize=vptr (PR33881)

Hi Vedant, after this change our ubsanvptr bot fails like so: clang-6.0: error: implicitly disabling vptr sanitizer because null checking wasn't enabled [-Werror,-Wauto-disable-vptr-sanitizer] The bot uses -fsanitize=vptr. I have no idea what this warning is supposed to tell me. Maybe it could

r309571 - [OpenCL] Enable subgroup extension in tests

Author: joey Date: Mon Jul 31 08:50:27 2017 New Revision: 309571 URL: http://llvm.org/viewvc/llvm-project?rev=309571=rev Log: [OpenCL] Enable subgroup extension in tests This fixes the test, so that it can be run on different hosts that may have different OpenCL extensions enabled. Modified:

  1   2   >