r311428 - Update libprotobuf-mutator revision

Author: vitalybuka Date: Mon Aug 21 22:18:28 2017 New Revision: 311428 URL: http://llvm.org/viewvc/llvm-project?rev=311428=rev Log: Update libprotobuf-mutator revision Modified: cfe/trunk/cmake/modules/ProtobufMutator.cmake Modified: cfe/trunk/cmake/modules/ProtobufMutator.cmake URL:

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb added a comment. @NoQ In https://reviews.llvm.org/D34275#847434, @NoQ wrote: > Most importantly, do you think we can enable the checker by default now? Was > this checker evaluated on any large codebase, and if so, how many true/false > positives did it find, probably compared to

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb updated this revision to Diff 112110. wangxindsb added a comment. - Fix the errors of the tests; - Add `-analyzer-output=text` to the run-line; - Change the message of the visitor's diagnostic piece. https://reviews.llvm.org/D34275 Files:

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 112103. Rakete added a comment. Rebased and friendly ping. https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expressions.cpp test/SemaCXX/new-delete-0x.cpp

r311422 - Test fix: only add shared libraries to rpath.

Author: george.karpenkov Date: Mon Aug 21 19:10:53 2017 New Revision: 311422 URL: http://llvm.org/viewvc/llvm-project?rev=311422=rev Log: Test fix: only add shared libraries to rpath. Modified: cfe/trunk/lib/Driver/ToolChains/Darwin.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

hintonda added a comment. It's just too bad llvm::cantFail() doesn't take an optional string. But the code is cleaner, so I won't comment further. https://reviews.llvm.org/D36806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36423: [libc++] Introsort based sorting function

bcraig added a comment. LGTM. You should probably get one other person to approve though. I'm hoping that @EricWF or @mclow.lists will take a look https://reviews.llvm.org/D36423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r311412 - Fixed driver tests for -fsanitize=fuzzer.

Author: george.karpenkov Date: Mon Aug 21 17:04:05 2017 New Revision: 311412 URL: http://llvm.org/viewvc/llvm-project?rev=311412=rev Log: Fixed driver tests for -fsanitize=fuzzer. Modified: cfe/trunk/test/Driver/fuzzer.c Modified: cfe/trunk/test/Driver/fuzzer.c URL:

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

Is there something we need for 5.0.0 here? On Sat, Aug 12, 2017 at 9:58 PM, Saleem Abdulrasool wrote: > Yeah, we should adjust that. Technically, it is `_Unwind_Control_Block on > ARM EHABI. However, _Unwind_Exception is aliased to that, which is why we > can use that in

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

hintonda added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:505 -assert(!Err && - "Replacements must not conflict since ranges have been merged."); -llvm::consumeError(std::move(Err)); srhines wrote: > hintonda wrote: > >

Re: r310983 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Clean merge in r311410. Thanks. On Mon, Aug 21, 2017 at 4:21 PM, Richard Smith wrote: > Yes, I'd very much like to get this into the upcoming release. > > On 21 August 2017 at 16:16, Hans Wennborg wrote: >> >> PR19668 was marked as a release blocker.

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

srhines marked an inline comment as done. srhines added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:505 -assert(!Err && - "Replacements must not conflict since ranges have been merged."); -llvm::consumeError(std::move(Err));

r311406 - Moving libFuzzer to compiler-rt: required updates to the Clang driver.

Author: george.karpenkov Date: Mon Aug 21 16:25:19 2017 New Revision: 311406 URL: http://llvm.org/viewvc/llvm-project?rev=311406=rev Log: Moving libFuzzer to compiler-rt: required updates to the Clang driver. Differential Revision: https://reviews.llvm.org/D36909 Modified:

Re: r310983 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Yes, I'd very much like to get this into the upcoming release. On 21 August 2017 at 16:16, Hans Wennborg wrote: > PR19668 was marked as a release blocker. Is this suitable for merging? > > On Tue, Aug 15, 2017 at 6:49 PM, Richard Smith via cfe-commits >

Re: r310983 - PR19668, PR23034: Fix handling of move constructors and deleted copy

PR19668 was marked as a release blocker. Is this suitable for merging? On Tue, Aug 15, 2017 at 6:49 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Tue Aug 15 18:49:53 2017 > New Revision: 310983 > > URL:

[PATCH] D36989: [clang-diff] Refactor stop-after command-line flag

jgravelle-google created this revision. Herald added subscribers: aheejin, klimek. Rename stop-after to stop-after-topdown. When building LLVM with -DLLVM_BUILD_LLVM_DYLIB=ON, stop-after collides with the stop-after already present in LLVM. This also refactors the flag to a boolean, to reflect

r311397 - [Driver][Darwin] Do not pass -munwind-table if -fno-excpetions is

Author: ahatanak Date: Mon Aug 21 15:46:46 2017 New Revision: 311397 URL: http://llvm.org/viewvc/llvm-project?rev=311397=rev Log: [Driver][Darwin] Do not pass -munwind-table if -fno-excpetions is supplied. With this change, -fno-exceptions disables unwind tables unless -funwind-tables is

[PATCH] D36853: [Parser] Correct initalizer typos before lambda capture type is deduced.

vsapsai added a comment. Thanks for review, Alex. I've requested commit access and plan to commit the change myself to make sure everything works as expected. https://reviews.llvm.org/D36853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r311391 - [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure.

Author: stl_msft Date: Mon Aug 21 15:19:33 2017 New Revision: 311391 URL: http://llvm.org/viewvc/llvm-project?rev=311391=rev Log: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure. This is a reasonably non-intrusive change, which I've verified works for

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

hintonda added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:505 -assert(!Err && - "Replacements must not conflict since ranges have been merged."); -llvm::consumeError(std::move(Err)); srhines wrote: > hintonda wrote: > > While

Re: r311182 - [analyzer] Fix modeling of constructors

Thanks! On Mon, Aug 21, 2017 at 1:28 PM, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Merged in r311378. > > Thanks, > Hans > > On Mon, Aug 21, 2017 at 1:12 PM, Anna Zaks wrote: > > I approve.Thanks Hans! > > Anna > >> On Aug 21, 2017, at 1:05 PM, Hans

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

srhines marked an inline comment as done. srhines added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:505 -assert(!Err && - "Replacements must not conflict since ranges have been merged."); -llvm::consumeError(std::move(Err));

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

hintonda added inline comments. Comment at: lib/Tooling/Core/Replacement.cpp:505 -assert(!Err && - "Replacements must not conflict since ranges have been merged."); -llvm::consumeError(std::move(Err)); While obviously correct, are you concerned

Re: r311182 - [analyzer] Fix modeling of constructors

Merged in r311378. Thanks, Hans On Mon, Aug 21, 2017 at 1:12 PM, Anna Zaks wrote: > I approve.Thanks Hans! > Anna >> On Aug 21, 2017, at 1:05 PM, Hans Wennborg wrote: >> >> I'm ok with it if Anna approves. >> >> On Mon, Aug 21, 2017 at 9:06 AM, Artem

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

srhines added a comment. Ping. https://reviews.llvm.org/D36806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r311182 - [analyzer] Fix modeling of constructors

I approve.Thanks Hans! Anna > On Aug 21, 2017, at 1:05 PM, Hans Wennborg wrote: > > I'm ok with it if Anna approves. > > On Mon, Aug 21, 2017 at 9:06 AM, Artem Dergachev wrote: >> Hello, >> >> Do we have time to merge this change into release 5.0.0?

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

hintonda added a comment. ping... https://reviews.llvm.org/D36347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r311182 - [analyzer] Fix modeling of constructors

I'm ok with it if Anna approves. On Mon, Aug 21, 2017 at 9:06 AM, Artem Dergachev wrote: > Hello, > > Do we have time to merge this change into release 5.0.0? It's an assertion > failure fix, which shows up on C++ code involving double-inheritance with > empty base classes.

[PATCH] D36872: Fixed a crash on replaying Preamble's PP conditional stack.

hans added a comment. In https://reviews.llvm.org/D36872#847416, @nik wrote: > I see this in trunk/master submitted, but not in the release_50 branch. Could > this be cherry-picked to 5.0? I've replied on the commit message thread. Thanks! Repository: rL LLVM

Re: r311330 - Fixed a crash on replaying Preamble's PP conditional stack.

Nikolai suggested this should be merged to 5.0. Richard, what do you think? On Mon, Aug 21, 2017 at 5:03 AM, Ilya Biryukov via cfe-commits wrote: > Author: ibiryukov > Date: Mon Aug 21 05:03:08 2017 > New Revision: 311330 > > URL:

[PATCH] D36954: [Sema] Update release notes with details of implicit scalar to vector conversions

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, please commit to the 5.0 branch https://reviews.llvm.org/D36954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r311365 - Enable libfuzzer on NetBSD/amd64

Author: kamil Date: Mon Aug 21 12:12:14 2017 New Revision: 311365 URL: http://llvm.org/viewvc/llvm-project?rev=311365=rev Log: Enable libfuzzer on NetBSD/amd64 Summary: Enable SanitizerKind::Fuzzer and SanitizerKind::FuzzerNoLink on x86_64. Sponsored by Reviewers: joerg, kcc, vitalybuka,

[PATCH] D35271: Fix printing policy for AST context loaded from file

vsk added a comment. In https://reviews.llvm.org/D35271#847306, @jklaehn wrote: > In https://reviews.llvm.org/D35271#809159, @vsk wrote: > > > I wonder if it's possible to do away with the calls to 'updated()'... it > > seems strange that we initialize the same preprocessor repeatedly. Is there

[PATCH] D36931: Update LLVM 5.0 release notes for ms_abi and __builtin_ms_va_list for aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rL311359: Update Clang 5.0 release notes for ms_abi and __builtin_ms_va_list for aarch64 (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36931?vs=111857=112022#toc Repository:

[PATCH] D36973: [libclang] Add support for querying cursor availability

jklaehn created this revision. jklaehn added a project: clang. This patch allows checking the availability of cursors through libclang and clang.cindex (Python). This e.g. allows to check whether a C++ member function has been marked as deleted. https://reviews.llvm.org/D36973 Files:

[PATCH] D36969: [Basic] Add a DiagnosticOr type

vsk added a comment. Would it be more convenient to extend ErrorInfo instead of creating a new diagnostic wrapper? E.g one benefit of passing around Expected's is that there's some assurance the diagnostics will be reported. Repository: rL LLVM https://reviews.llvm.org/D36969

Re: r292458 - Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection

On Fri, Aug 18, 2017 at 5:22 PM, Dehao Chen wrote: > On Fri, Aug 18, 2017 at 2:46 PM, Hans Wennborg wrote: >> >> Should we mention this in the release notes? >> >> >> Is the flag documented somewhere? > > > It's documented in the Options.td file, do you think

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood updated this revision to Diff 112018. hamzasood added a comment. - Info about a lambda's explicit template parameters is now exposed in the AST (see changes to LambdaExpr). It turns out that no extra storage was actually needed to achieve this. - Removed remnants of a previous

[PATCH] D36914: Implement CFG construction for __try / __except / __leave.

thakis updated this revision to Diff 112015. thakis edited the summary of this revision. thakis added a comment. Just use TryTerminatedBlock https://reviews.llvm.org/D36914 Files: lib/Analysis/CFG.cpp test/Sema/warn-unreachable-ms.c Index: test/Sema/warn-unreachable-ms.c

[PATCH] D36914: Implement CFG construction for __try / __except / __leave.

thakis added inline comments. Comment at: lib/Analysis/CFG.cpp:448 +BuildOpts(buildOpts), switchExclusivelyCovered(false), +switchCond(nullptr), cachedEntry(nullptr), lastLookup(nullptr) {} (this is now a no-op and only a clang-formatting of

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo

hintonda added a comment. I've submitted a patch, https://reviews.llvm.org/D36971, that moves find_first_existing_file and find_first_existing_vc_file to ADDLLVM so they can be reused here. If that patch is accepted and lands, you can then remove these versions and check to see if that solves

Re: [PATCH] D36914: Implement CFG construction for __try / __except / __leave.

On Mon, Aug 21, 2017 at 12:41 PM, Reid Kleckner via Phabricator via cfe-commits wrote: > rnk added a comment. > > > Don't add any EH edges to the CFG for SEH. In practice, > BuildOpts.AddEHEdges is always false in practice from what I can tell, and > with SEH every

[PATCH] D36949: [clang] Fix tests for Emitting Single Inline Remark

This revision was automatically updated to reflect the committed changes. Closed by commit rL311347: [clang] Fix tests for Emitting Single Inline Remark (authored by lenary). Repository: rL LLVM https://reviews.llvm.org/D36949 Files:

r311347 - [clang] Fix tests for Emitting Single Inline Remark

Author: lenary Date: Mon Aug 21 09:40:35 2017 New Revision: 311347 URL: http://llvm.org/viewvc/llvm-project?rev=311347=rev Log: [clang] Fix tests for Emitting Single Inline Remark Summary: This change depends on https://reviews.llvm.org/D36054 and should be landed at the same time. Reviewers:

[PATCH] D36914: Implement CFG construction for __try / __except / __leave.

rnk added a comment. > Don't add any EH edges to the CFG for SEH. In practice, BuildOpts.AddEHEdges > is always false in practice from what I can tell, and with SEH every single > stmt would have to get an EH edge. Since we can't mix C++ EH and SEH, do you think it would be better to reuse the

r311346 - [StaticAnalyzer] LoopUnrolling: Track a LoopStack in order to completely unroll specific loops

Author: szepet Date: Mon Aug 21 09:32:57 2017 New Revision: 311346 URL: http://llvm.org/viewvc/llvm-project?rev=311346=rev Log: [StaticAnalyzer] LoopUnrolling: Track a LoopStack in order to completely unroll specific loops The LoopExit CFG information provides the opportunity to not mark the

[PATCH] D36931: Update LLVM 5.0 release notes for ms_abi and __builtin_ms_va_list for aarch64

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D36931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36423: [libc++] Introsort based sorting function

DIVYA updated this revision to Diff 111998. DIVYA added a comment. - added test qsort_worst_uint32 in algorithm.bench.cpp https://reviews.llvm.org/D36423 Files: benchmarks/GenerateInput.hpp benchmarks/algorithms.bench.cpp include/algorithm Index: include/algorithm

r311345 - [clang-proto-fuzzer] Update README.

Author: morehouse Date: Mon Aug 21 09:18:43 2017 New Revision: 311345 URL: http://llvm.org/viewvc/llvm-project?rev=311345=rev Log: [clang-proto-fuzzer] Update README. Add instructions on how to modify the compiler invocation. Modified: cfe/trunk/tools/clang-fuzzer/README.txt Modified:

[PATCH] D35670: [StaticAnalyzer] Handle LoopExit CFGElement in the analyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL311344: [StaticAnalyzer] Handle LoopExit CFGElement in the analyzer (authored by szepet). Changed prior to commit: https://reviews.llvm.org/D35670?vs=110981=111993#toc Repository: rL LLVM

r311344 - [StaticAnalyzer] Handle LoopExit CFGElement in the analyzer

Author: szepet Date: Mon Aug 21 09:10:19 2017 New Revision: 311344 URL: http://llvm.org/viewvc/llvm-project?rev=311344=rev Log: [StaticAnalyzer] Handle LoopExit CFGElement in the analyzer This patch adds handling of the LoopExit CFGElements to the StaticAnalyzer. This is reached by introducing a

Re: r311182 - [analyzer] Fix modeling of constructors

Hello, Do we have time to merge this change into release 5.0.0? It's an assertion failure fix, which shows up on C++ code involving double-inheritance with empty base classes. Artem. On 8/18/17 9:20 PM, Alexander Shaposhnikov via cfe-commits wrote: Author: alexshap Date: Fri Aug 18

[PATCH] D36951: [OpenCL][5.0.0 Release] Release notes for OpenCL in Clang

Anastasia added inline comments. Comment at: docs/ReleaseNotes.rst:146 +- Extended Clang builtins with required ``cl_khr_subgroups`` support. +- Now interpreting empty argument function as void argument list in OpenCL code. +- Add ``intel_reqd_sub_group_size`` attribute

[PATCH] D36187: [clang-diff] Use the relative name for NamedDecls

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LG Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:371 + std::string ContextPrefix; + if (auto *Namespace = dyn_cast(Context)) +ContextPrefix =

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added a comment. Extracted `DiagnosticOr` to a separate patch at https://reviews.llvm.org/D36969. I will update this patch tomorrow. Repository: rL LLVM https://reviews.llvm.org/D36075 ___ cfe-commits mailing list

[PATCH] D36969: [Basic] Add a DiagnosticOr type

arphaman created this revision. Clang's `DiagnosticOr` type mimics the `Expected` type from LLVM. It either stores a partial diagnostic and its location or a value. I'll be using in https://reviews.llvm.org/D36075. Repository: rL LLVM https://reviews.llvm.org/D36969 Files:

[PATCH] D36949: [clang] Fix tests for Emitting Single Inline Remark

anemet accepted this revision. anemet added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

faisalv added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:1116 + if (HasExplicitTemplateParams) { +SmallVector TemplateParams; +SourceLocation LAngleLoc, RAngleLoc; hamzasood wrote: > faisalv wrote: > > hamzasood wrote: > > >

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

faisalv added inline comments. Comment at: lib/Sema/SemaLambda.cpp:858 +KnownDependent = CurScope->getTemplateParamParent() != nullptr; + } hamzasood wrote: > faisalv wrote: > > Hmm - now that you drew my attention to this ;) - I'm pretty sure this is >

r311334 - [mips] Remove checking of the redundant condition. NFC

Author: atanasyan Date: Mon Aug 21 07:08:29 2017 New Revision: 311334 URL: http://llvm.org/viewvc/llvm-project?rev=311334=rev Log: [mips] Remove checking of the redundant condition. NFC Modified: cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp Modified:

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

NoQ added a comment. Most importantly, do you think we can enable the checker by default now? Was this checker evaluated on any large codebase, and if so, how many true/false positives did it find, probably compared to the old checker? https://reviews.llvm.org/D34275

[PATCH] D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*

nik added a reviewer: erikjv. nik added a comment. Please submit as I do not have the necessary permissions. https://reviews.llvm.org/D36821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36872: Fixed a crash on replaying Preamble's PP conditional stack.

nik added a reviewer: hans. nik added a comment. I see this in trunk/master submitted, but not in the release_50 branch. Could this be cherry-picked to 5.0? Repository: rL LLVM https://reviews.llvm.org/D36872 ___ cfe-commits mailing list

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

NoQ added a comment. Tests are still not working - they pass now, but they don't actually test anything. Please make sure that tests actually work. Which means that 1. Tests pass when you run `make -j4 check-clang-analysis`; 2. Tests start failing when you change your code or expected-warning

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:1116 + if (HasExplicitTemplateParams) { +SmallVector TemplateParams; +SourceLocation LAngleLoc, RAngleLoc; faisalv wrote: > hamzasood wrote: > > faisalv wrote: > > > Why

[PATCH] D36956: [clang-format] Emit absolute splits before lines for comments

krasimir created this revision. Herald added a subscriber: klimek. This patch makes the splits emitted for the beginning of comment lines during reformatting absolute. Previously, they were relative to the start of the non-whitespace content of the line, which messes up further TailOffset

[PATCH] D36955: [libclang] Visit attributes for function and class templates

jklaehn created this revision. jklaehn added a project: clang. Previously, `VisitAttributes` was not called for function and class templates and thus their attributes were not accessible using libclang. https://reviews.llvm.org/D36955 Files: bindings/python/tests/cindex/test_cursor.py

[PATCH] D36954: [Sema] Update release notes with details of implicit scalar to vector conversions

sdardis created this revision. Add notes on this to the C language section, along with the C++ section. https://reviews.llvm.org/D36954 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst

Clang-format bug patch

To Whom It May Concern, I am writing in reference to a patch I created in response to the bug I have decided to work on. Bug comes from the official site: https://bugs.llvm.org/show_bug.cgi?id=34001 Short overview: Clang-format bug resulting in a strange behavior of control statements

[PATCH] D36951: [OpenCL][5.0.0 Release] Release notes for OpenCL in Clang

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. https://reviews.llvm.org/D36951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

faisalv added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:1116 + if (HasExplicitTemplateParams) { +SmallVector TemplateParams; +SourceLocation LAngleLoc, RAngleLoc; hamzasood wrote: > faisalv wrote: > > Why not Just use/pass

[PATCH] D36953: [libclang] Keep track of TranslationUnit instance when annotating tokens

jklaehn created this revision. jklaehn added a project: clang. Previously the `_tu` was not propagated to the returned cursor, leading to errors when calling any method on that cursor (e.g. `cursor.referenced`). https://reviews.llvm.org/D36953 Files: bindings/python/clang/cindex.py

[PATCH] D36952: [libclang] Add support for checking abstractness of records

jklaehn created this revision. jklaehn added a project: clang. This patch allows checking whether a C++ record declaration is abstract through libclang and clang.cindex (Python). https://reviews.llvm.org/D36952 Files: bindings/python/clang/cindex.py

[PATCH] D36876: [IRGen] Evaluate constant static variables referenced through member expressions

arphaman updated this revision to Diff 111956. arphaman marked an inline comment as done. arphaman added a comment. - Get rid of the `AllowSideEffects` argument. - Get rid of the old integer field evaluation code. Repository: rL LLVM https://reviews.llvm.org/D36876 Files:

[PATCH] D36876: [IRGen] Evaluate constant static variables referenced through member expressions

arphaman added inline comments. Comment at: lib/CodeGen/CGExprComplex.cpp:156 +auto Constant = tryEmitDeclRefOrMemberExprAsConstant( +ME, ME->getMemberDecl(), /*AllowSideEffects=*/true); +if (Constant) { rsmith wrote: > If we can (correctly)

[PATCH] D35271: Fix printing policy for AST context loaded from file

jklaehn added a comment. In https://reviews.llvm.org/D35271#809159, @vsk wrote: > I wonder if it's possible to do away with the calls to 'updated()'... it > seems strange that we initialize the same preprocessor repeatedly. Is there > any way to finalize an ASTInfoCollector after ReadAST

[PATCH] D36872: Fixed a crash on replaying Preamble's PP conditional stack.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311330: Fixed a crash on replaying Preamble's PP conditional stack. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D36872 Files: cfe/trunk/include/clang/Lex/Preprocessor.h

r311330 - Fixed a crash on replaying Preamble's PP conditional stack.

Author: ibiryukov Date: Mon Aug 21 05:03:08 2017 New Revision: 311330 URL: http://llvm.org/viewvc/llvm-project?rev=311330=rev Log: Fixed a crash on replaying Preamble's PP conditional stack. Summary: The crash occurs when the first token after a preamble is a macro expansion. Fixed by moving

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood marked 5 inline comments as done. hamzasood added a comment. So to clarify: NumExplicitTemplateParams should be stored in LambdaDefinitionData (with an accessor in LambdaExpr) and ExplicitTemplateParamRange (SourceRange) should be stored in LambdaExpr? That makes sense, but doesn't

[PATCH] D36951: [OpenCL][5.0.0 Release] Release notes for OpenCL in Clang

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM, except one nit. Comment at: docs/ReleaseNotes.rst:146 +- Extended Clang builtins with required ``cl_khr_subgroups`` support. +- Now interpreting empty argument

[PATCH] D36951: [OpenCL][5.0.0 Release] Release notes for OpenCL in Clang

Anastasia created this revision. Added release notes describing committed functionality for OpenCL in release 5.0. https://reviews.llvm.org/D36951 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === ---

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

faisalv added a comment. In regards to representing this in the AST - I think (based on precedence) that the number of explicit template parameters should be stored in LambdaDefinitionData - and the interface exposed through LambdaExpr (where the source information of the template parameter

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36853: [Parser] Correct initalizer typos before lambda capture type is deduced.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Thanks. You should obtain commit access if you haven't already done so (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access). I can commit this on your behalf as

[PATCH] D36821: [libclang]: Honor LIBCLANG_NOTHREADS for clang_parseTranslationUnit*

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D36821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36872: Fixed a crash on replaying Preamble's PP conditional stack.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks good to me. https://reviews.llvm.org/D36872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r311325 - [ObjC] Use consistent comment style in inline asm

Author: olista01 Date: Mon Aug 21 02:54:46 2017 New Revision: 311325 URL: http://llvm.org/viewvc/llvm-project?rev=311325=rev Log: [ObjC] Use consistent comment style in inline asm The comment markers accepted by the assembler vary between different targets, but '//' is always accepted, so we

[PATCH] D36666: [ObjC] Use consistent comment style in inline asm

This revision was automatically updated to reflect the committed changes. Closed by commit rL311325: [ObjC] Use consistent comment style in inline asm (authored by olista01). Changed prior to commit: https://reviews.llvm.org/D3?vs=110927=111942#toc Repository: rL LLVM

[PATCH] D36666: [ObjC] Use consistent comment style in inline asm

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rL LLVM https://reviews.llvm.org/D3 ___ cfe-commits mailing list

[PATCH] D36666: [ObjC] Use consistent comment style in inline asm

olista01 added reviewers: rnk, niravd, SjoerdMeijer. olista01 added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36614: [clang-format] Refine trailing comment detection

krasimir added a comment. ping https://reviews.llvm.org/D36614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36731: [ARM][AArch64] Cortex-A75 and Cortex-A55 tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL311319: [ARM][AArch64] Cortex-A75 and Cortex-A55 tests (authored by sam_parker). Changed prior to commit: https://reviews.llvm.org/D36731?vs=111664=111940#toc Repository: rL LLVM

r311319 - [ARM][AArch64] Cortex-A75 and Cortex-A55 tests

Author: sam_parker Date: Mon Aug 21 01:52:45 2017 New Revision: 311319 URL: http://llvm.org/viewvc/llvm-project?rev=311319=rev Log: [ARM][AArch64] Cortex-A75 and Cortex-A55 tests Add frontend tests for Cortex-A75 and Cortex-A55, Arm's latest big.LITTLE A-class cores. They implement the ARMv8.2-A

[PATCH] D34512: Add preliminary Cross Translation Unit support library

dkrupp added a subscriber: zaks.anna. dkrupp added a comment. The creation of this library (libCrossTU) is approved for importing function definitions. @zaks.anna, @NoQ , @klimek could you please help us reviewing the code itself? Then, when this is approved, we could progress with the review

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

ilya-biryukov added a comment. The function in `ClangdServer` seems to be getting more complicated and more complicated, mostly because of mixing up `std::string`, `StringRef`, `SmallString`. Here's a slightly revamped implementation of your function, hope you'll find it (or parts of it)

[PATCH] D36949: [clang] Fix tests for Emitting Single Inline Remark

lenary created this revision. This change depends on https://reviews.llvm.org/D36054 and should be landed at the same time. https://reviews.llvm.org/D36949 Files: test/Frontend/optimization-remark-with-hotness.c test/Frontend/optimization-remark.c Index: