[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added a comment. Ping. https://reviews.llvm.org/D35020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37131: [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric control transfer)

This revision was automatically updated to reflect the committed changes. Closed by commit rL311762: [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric… (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D37131?vs=112658=112659#toc

r311762 - [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric control transfer)

Author: gornishanov Date: Thu Aug 24 21:46:54 2017 New Revision: 311762 URL: http://llvm.org/viewvc/llvm-project?rev=311762=rev Log: [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric control transfer) Summary: If await_suspend returns a coroutine_handle, as in the

[PATCH] D37131: [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric control transfer)

GorNishanov created this revision. If await_suspend returns a coroutine_handle, as in the example below: coroutine_handle<> await_suspend(coroutine_handle<> h) { coro.promise().waiter = h; return coro; } suspensionExpression processing will resume the coroutine pointed at by that

[PATCH] D37131: [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric control transfer)

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37122: Change Diagnostic Category size error from runtime to compiletime

erichkeane updated this revision to Diff 112651. erichkeane added a comment. Removed file due to git weirdness. https://reviews.llvm.org/D37122 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/DiagnosticIDs.h lib/Basic/DiagnosticIDs.cpp Index: lib/Basic/DiagnosticIDs.cpp

r311758 - Rename diagnostic groups from CXX1z to CXX17. No functionality change.

Author: rsmith Date: Thu Aug 24 19:39:05 2017 New Revision: 311758 URL: http://llvm.org/viewvc/llvm-project?rev=311758=rev Log: Rename diagnostic groups from CXX1z to CXX17. No functionality change. Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td

r311750 - Fix up the -Wc++XX-compat warnings to properly handle C++2a.

Author: rsmith Date: Thu Aug 24 19:25:07 2017 New Revision: 311750 URL: http://llvm.org/viewvc/llvm-project?rev=311750=rev Log: Fix up the -Wc++XX-compat warnings to properly handle C++2a. Added: cfe/trunk/test/SemaCXX/cxx17-compat.cpp Modified:

Re: r311695 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

Hi Hans, This fixes a regression in ubsan's handling of lambda expressions. Seems like a reasonable candidate for Clang 5, but it is rather late in the day... On 24 August 2017 at 13:10, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Aug 24

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3851 + ->getType() + ->getPointerAddressSpace(); const unsigned ArgAddrSpace = yaxunl wrote: > rjmccall

r311746 - Fix MSVC bots which include '__attribute__((thiscall))' in pretty-printed member function types.

Author: rsmith Date: Thu Aug 24 18:55:50 2017 New Revision: 311746 URL: http://llvm.org/viewvc/llvm-project?rev=311746=rev Log: Fix MSVC bots which include '__attribute__((thiscall))' in pretty-printed member function types. We really shouldn't be including inferred calling conventions here,

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

rsmith closed this revision. rsmith added a comment. Committed as r311744. https://reviews.llvm.org/D36855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r311744 - [c++2a] P0704R1: Allow pointers to const& member functions to be called on rvalues.

Author: rsmith Date: Thu Aug 24 18:47:55 2017 New Revision: 311744 URL: http://llvm.org/viewvc/llvm-project?rev=311744=rev Log: [c++2a] P0704R1: Allow pointers to const& member functions to be called on rvalues. Patch by Blitz Rakete! Added:

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Sorry for the delay, this looks good to me. https://reviews.llvm.org/D36855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

srhines added a comment. Any other comments? https://reviews.llvm.org/D36806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36501: Add flag to request Clang is ABI-compatible with older versions of itself

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. I'm not familiar with the details of the ABI changes, but the mechanics of the code look good to me. Repository: rL LLVM https://reviews.llvm.org/D36501

[PATCH] D36720: [libc++] Prevent stale site configuration headers

smeenai added a comment. Ping. https://reviews.llvm.org/D36720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36719: [libc++] Add site config option for ABI macros

smeenai added a comment. Ping. https://reviews.llvm.org/D36719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36713: [libc++] Add a persistent way to disable availability

smeenai added a comment. Ping. https://reviews.llvm.org/D36713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

Ah, sorry I had to run off for a meeting. Yes, I was able to finally fix this. For anyone else who hits it, you can "git reset --hard" back to the CL before the initial change. Then you can "git pull" to move past the issue. Thanks for fixing this. Steve On Thu, Aug 24, 2017 at 4:35 PM, Keane,

RE: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

Alright, final update. Thanks to some fantastic help on #llvm, I believe this is fixed. Stephen: You may have to do some shenanigans to fix your local stuff, but the monorepo and another repo both seem to work. Sorry for this everyone :/ From: Stephen Hines [mailto:srhi...@google.com] Sent:

r311732 - Remove .gitattributes, add comment to lineendings.

Author: erichkeane Date: Thu Aug 24 16:25:05 2017 New Revision: 311732 URL: http://llvm.org/viewvc/llvm-project?rev=311732=rev Log: Remove .gitattributes, add comment to lineendings. Removed: cfe/trunk/test/Frontend/.gitattributes Modified:

[PATCH] D36501: Add flag to request Clang is ABI-compatible with older versions of itself

rsmith updated this revision to Diff 112634. rsmith retitled this revision from "add flag to undo ABI change in r310401" to "Add flag to request Clang is ABI-compatible with older versions of itself". rsmith edited the summary of this revision. Herald added a subscriber: srhines. Repository:

[PATCH] D37122: Change Diagnostic Category size error from runtime to compiletime

erichkeane added a comment. In https://reviews.llvm.org/D37122#852018, @rnk wrote: > In https://reviews.llvm.org/D37122#851978, @erichkeane wrote: > > > Ugg... disregard the system-header-line-directive-ms-lineendings.c issue, > > I'm going to try to figure that out > > > Yeah, I'm seeing

[PATCH] D37122: Change Diagnostic Category size error from runtime to compiletime

rnk added a comment. In https://reviews.llvm.org/D37122#851978, @erichkeane wrote: > Ugg... disregard the system-header-line-directive-ms-lineendings.c issue, I'm > going to try to figure that out Yeah, I'm seeing issues with that as well. I'm not sure what's up.

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate flag

mgrang added a comment. In https://reviews.llvm.org/D36386#851853, @dblaikie wrote: > sounds good - so long as other tests would fail if the fix this test was > testing wasn't present (on a reverse iteration enabled build) Thanks! Yes, I verified that the test

RE: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

1 more dataset, Craig has the git mirror working right, but with the public mirror… From: Stephen Hines [mailto:srhi...@google.com] Sent: Thursday, August 24, 2017 3:18 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r311683 - [Preprocessor]

r311720 - [clang] Remove unit test which uses reverse-iterate flag

Author: mgrang Date: Thu Aug 24 15:40:32 2017 New Revision: 311720 URL: http://llvm.org/viewvc/llvm-project?rev=311720=rev Log: [clang] Remove unit test which uses reverse-iterate flag Summary: This patch is in response to https://reviews.llvm.org/D35043 which removed -reverse-iterate flag.

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL311720: [clang] Remove unit test which uses reverse-iterate flag (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D36386?vs=111557=112624#toc Repository: rL LLVM

r311719 - [sanitizer-coverage] document -fsanitize-coverage=pc-table and -fsanitize-coverage=inline-8bit-counters

Author: kcc Date: Thu Aug 24 15:40:03 2017 New Revision: 311719 URL: http://llvm.org/viewvc/llvm-project?rev=311719=rev Log: [sanitizer-coverage] document -fsanitize-coverage=pc-table and -fsanitize-coverage=inline-8bit-counters Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified:

RE: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

Hi Stephen- I’m digging through this, and it seems odd. SVN seems to store it with the CRLF line endings. The Git mirror for some reason is not paying attention to the svn file attribute. However, the .gitattribute file seems to convert it to the CRLF endings (as it should be), but it seems

[PATCH] D37122: Change Diagnostic Category size error from runtime to compiletime

erichkeane added a comment. Ugg... disregard the system-header-line-directive-ms-lineendings.c issue, I'm going to try to figure that out https://reviews.llvm.org/D37122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37122: Change Diagnostic Category size error from runtime to compiletime

erichkeane created this revision. Diagnostic Categories are fairly annoying, and are only enforced by a runtime-debug-only assert. This puts in a touch more work to get this all done at compile-time with static asserts. https://reviews.llvm.org/D37122 Files:

RE: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

Can you better clarify what went wrong? I included a ‘.gitattriutes’ that matches only the new test that is supposed to keep it as CLRF From: Stephen Hines [mailto:srhi...@google.com] Sent: Thursday, August 24, 2017 3:18 PM To: Keane, Erich Cc: cfe-commits

Re: r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

This change seems to have broken the git mirrors, as I can no longer check out clang without having a merge conflict as git alters the line endings. Setting core.autocrlf to false doesn't help either. Does anyone have any idea how to fix this svn <-> git issue? Thanks, Steve On Thu, Aug 24, 2017

[PATCH] D37120: [analyzer] Fix modeling arithmetic

alexshap created this revision. Herald added a subscriber: xazax.hun. This diff attempts to fix modeling of arithmetic expressions where pointers are treated as integers (i.e. via C-style / reinterpret casts). In particular, it resolves https://bugs.llvm.org/show_bug.cgi?id=34309 Test plan: make

r311707 - Expose -mllvm -accurate-sample-profile to clang.

Author: dehao Date: Thu Aug 24 14:37:33 2017 New Revision: 311707 URL: http://llvm.org/viewvc/llvm-project?rev=311707=rev Log: Expose -mllvm -accurate-sample-profile to clang. Summary: With accurate sample profile, we can do more aggressive size optimization. For some size-critical application,

[libcxx] r311705 - [libcxx] [test] Update for C++17 feature removals.

Author: stl_msft Date: Thu Aug 24 14:24:08 2017 New Revision: 311705 URL: http://llvm.org/viewvc/llvm-project?rev=311705=rev Log: [libcxx] [test] Update for C++17 feature removals. test/std/containers/Emplaceable.h test/std/containers/NotConstructible.h test/support/counting_predicates.hpp

[PATCH] D36503: [libcxx] [test] Update for C++17 feature removals.

STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Looks good to myself. https://reviews.llvm.org/D36503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols marked 10 inline comments as done. rwols added inline comments. Comment at: clangd/ClangdUnit.cpp:321 + +// Fill in the label, detail, documentation and insertText fields of the +// CompletionItem. ilya-biryukov wrote: > Maybe split writes into

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols updated this revision to Diff 112609. rwols added a comment. [clangd] [WIP] Add support for snippet completions - Restore the sortText logic - Return CompletionItem instead of modifying a ref param - Make all helper methods const - Only set to Snippet once we encounter

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

Alexander-Shukaev added a comment. Man, I have to admit it's really a shame that I didn't find time to work on this further but I'm truly too busy these days. However, I believe the primary point why I didn't have motivation to do this is because the flaw that was pointed out actually never

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

davidxl accepted this revision. davidxl added a comment. lgtm https://reviews.llvm.org/D37091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D36501: add flag to undo ABI change in r310401

Paul: is the PS4 toolchain's ABI based on that of a particular Clang release, or is it a branch from trunk at some point? Or something else? (And which release / revision?) I am reminded that there are two parts to the ABI, the C++ part and the platform part. PS4's C++ ABI is whatever Clang

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

rsmith added a comment. Thanks, looks great. https://reviews.llvm.org/D37091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate flag

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. sounds good - so long as other tests would fail if the fix this test was testing wasn't present (on a reverse iteration enabled build) https://reviews.llvm.org/D36386

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

danielcdh updated this revision to Diff 112604. danielcdh marked an inline comment as done. danielcdh added a comment. update https://reviews.llvm.org/D37091 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cpp

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

rsmith added inline comments. Comment at: test/CodeGen/thinlto-profile-sample-accurate.c:2-4 +// RUN: %clang -O2 %s -flto=thin -fprofile-sample-accurate -c -o %t.o +// RUN: llvm-lto -thinlto -o %t %t.o +// RUN: %clang_cc1 -O2 -x ir %t.o -fthinlto-index=%t.thinlto.bc -emit-llvm

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

danielcdh updated this revision to Diff 112601. danielcdh added a comment. Herald added subscribers: eraman, mehdi_amini. Add an end-to-end test. https://reviews.llvm.org/D37091 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Please add a test that the attribute is emitted into IR. Other than that, this looks good to me. Comment at: include/clang/Driver/Options.td:645 + profile is

Re: r311589 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

Thanks for the revert; looks like there was another bug in the interaction of lambdas an UBSan 'this' sanitization that was exposed by this (the lambda static invoker calls the operator() with a null this pointer, and the sanitizer doesn't know that's actually OK). Should be fixed in r311695. On

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

danielcdh updated this revision to Diff 112597. danielcdh marked 3 inline comments as done. danielcdh added a comment. update https://reviews.llvm.org/D37091 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cpp

r311695 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' pointer

Author: rsmith Date: Thu Aug 24 13:10:33 2017 New Revision: 311695 URL: http://llvm.org/viewvc/llvm-project?rev=311695=rev Log: [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured

Re: [PATCH] D36501: add flag to undo ABI change in r310401

> On Aug 24, 2017, at 3:48 PM, Richard Smith wrote: > On 24 August 2017 at 12:24, Paul Robinson via Phabricator via cfe-commits > > wrote: > probinson added a comment. > > Locally we have a couple different

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

yaxunl marked 5 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3832 + "indirect-arg-temp"); +IRCallArgs[FirstIRArg] = CastToAllocaAddrSpace(Addr.getPointer()); rjmccall

Re: [PATCH] D36501: add flag to undo ABI change in r310401

On 24 August 2017 at 12:24, Paul Robinson via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > probinson added a comment. > > Locally we have a couple different tactics for dealing with changes that > we can't support. A more coherent approach would be great. > For example we

[PATCH] D36501: add flag to undo ABI change in r310401

probinson added a comment. Locally we have a couple different tactics for dealing with changes that we can't support. A more coherent approach would be great. For example we defined a new TargetCXXABI::Kind value that is mostly GenericItaniumABI except where it isn't. I personally did not do

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

rsmith added inline comments. Comment at: docs/ClangCommandLineReference.rst:173-180 +.. option:: -faccurate-sample-profile, -fno-accurate-sample-profile +.. program:: clang + +If the sample profile is accurate, callsites without profile samples are marked +as cold. Otherwise,

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. Aaron would likely know better than me... but could it be the spelling type should be GCC instead of GNU? https://reviews.llvm.org/D36272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r298574 - Fix issues in clang-format's AlignConsecutive modes.

This caused https://bugs.llvm.org/show_bug.cgi?id=33507 which is one of the last release blockers for 5.0.0. Can someone who's familiar with this code please take a look? On Thu, Aug 24, 2017 at 11:12 AM, Hans Wennborg wrote: > For reference, this was reviewed in

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. > Additionally, there is likely value to split the test run-line into 2, one > that specifies 64 bit Windows and one that is 64 bit Linux. The value being > that they validate two different code paths (whereas 32 is the same code > path). I added a RUN for

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Related maillist discussion is http://lists.llvm.org/pipermail/cfe-dev/2017-June/054359.html > Are we SURE the stack alignment for this type is supposed to be 16 bit as > well? I didn't see any discussion about it in the email conversation. > I have very

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

This revision was automatically updated to reflect the committed changes. Closed by commit rL311683: [Preprocessor] Correct internal token parsing of newline characters in CRLF (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D37079?vs=112581=112589#toc Repository:

r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

Author: erichkeane Date: Thu Aug 24 11:36:07 2017 New Revision: 311683 URL: http://llvm.org/viewvc/llvm-project?rev=311683=rev Log: [Preprocessor] Correct internal token parsing of newline characters in CRLF Discovered due to a goofy git setup, the test system-headerline-directive.c (and a few

[PATCH] D37115: [coroutines] Do not attempt to typo-correct when coroutine is looking for required members

GorNishanov created this revision. When SemaCoroutine looks for await_resume, it means it. No need for helpful: "Did you mean await_ready?" messages. Fixes PR33477 and a couple of FIXMEs in test/SemaCXX/coroutines.cpp https://reviews.llvm.org/D37115 Files: lib/Sema/SemaCoroutine.cpp

Re: r311589 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

I temporarily reverted the commit in r311680 to get the bots going again. -- adrian > On Aug 24, 2017, at 11:12 AM, Adrian Prantl via cfe-commits > wrote: > > It looks like this broke / found errors on the green dragon bot: > >

r311680 - Revert "[ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this'

Author: adrian Date: Thu Aug 24 11:18:24 2017 New Revision: 311680 URL: http://llvm.org/viewvc/llvm-project?rev=311680=rev Log: Revert "[ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the

[PATCH] D36075: [refactor] Initial support for refactoring action rules

alexshap added a comment. @arphaman The selection requirement is supposed to be orthogonal to AST matchers, not a replacement. It should be used when working with source selection in editors. I did mess around with moving over clang-reorder-fields using this kind of model and didn't see

[PATCH] D36501: add flag to undo ABI change in r310401

rsmith added a comment. In https://reviews.llvm.org/D36501#836257, @rjmccall wrote: > Yeah, I think having an internal C++ ABI version makes a lot more sense than > having a million different flags. Is there a reason to expose this as a knob > to users at all? I don't see any reason anyone

Re: r298574 - Fix issues in clang-format's AlignConsecutive modes.

For reference, this was reviewed in https://reviews.llvm.org/D21279 (Please always include review links in the future.) On Wed, Mar 22, 2017 at 7:51 PM, Nikola Smiljanic via cfe-commits wrote: > Author: nikola > Date: Wed Mar 22 21:51:25 2017 > New Revision: 298574 >

Re: r311589 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

It looks like this broke / found errors on the green dragon bot: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_check/4115/consoleFull#15752874848254eaf0-7326-4999-85b0-388101f2d404 TEST 'LLVM-Unit :: ADT/./ADTTests/FilterIteratorTest.FunctionPointer' FAILED

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. Are we SURE the stack alignment for this type is supposed to be 16 bit as well? I didn't see any discussion about it in the email conversation. I have very little understanding of this attribute, but I would (perhaps naiively) presume that it would be different on

[PATCH] D36564: [analyzer] Fix SimpleSValBuilder::simplifySVal

alexshap added a comment. @alexfh, thanks for letting me know, i will take a closer look at https://bugs.llvm.org/show_bug.cgi?id=34309 soon. Repository: rL LLVM https://reviews.llvm.org/D36564 ___ cfe-commits mailing list

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Erich, done. I also rerun tests and this time they are green. https://reviews.llvm.org/D36272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov updated this revision to Diff 112582. https://reviews.llvm.org/D36272 Files: include/clang/Basic/Attr.td lib/CodeGen/TargetInfo.cpp test/CodeGen/function-attributes.c Index: test/CodeGen/function-attributes.c

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D37079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

erichkeane marked 2 inline comments as done. erichkeane added a comment. Decided there were a few additional advantages to just handling \r\n, so Added them. https://reviews.llvm.org/D37079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

rnk added inline comments. Comment at: lib/Lex/Lexer.cpp:3076-3077 case '\r': +if (CurPtr[0] != Char && (CurPtr[0] == '\n' || CurPtr[0] == '\r')) + Char = getAndAdvanceChar(CurPtr, Result); // If we are inside a preprocessor directive and we see the end of line,

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

erichkeane updated this revision to Diff 112581. erichkeane added a comment. Switched to simply \r\n instead of both cases. This fixes the issue, is likely faster (important, since this is a performance critical part of code), and a smaller-hammer. https://reviews.llvm.org/D37079 Files:

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. Mind doing the diff with -U9 so I can see TargetInfo.cpp with the full context? Repository: rL LLVM https://reviews.llvm.org/D36272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r311589 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

Hi Richard, It looks like this revision is breaking the x86_64-linux-bootstrap bot . Most of the UBSan checks are failing with the attached error. Full log at:

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

erichkeane added inline comments. Comment at: lib/Lex/Lexer.cpp:3076-3077 case '\r': +if (CurPtr[0] != Char && (CurPtr[0] == '\n' || CurPtr[0] == '\r')) + Char = getAndAdvanceChar(CurPtr, Result); // If we are inside a preprocessor directive and we see the end

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

rnk added inline comments. Comment at: lib/Lex/Lexer.cpp:3076-3077 case '\r': +if (CurPtr[0] != Char && (CurPtr[0] == '\n' || CurPtr[0] == '\r')) + Char = getAndAdvanceChar(CurPtr, Result); // If we are inside a preprocessor directive and we see the end of line,

[PATCH] D37090: Implement CFG construction for __finally.

rnk added a comment. Re: jumps out of __try, I wonder if you can tie __finally into whatever the CFG does for C++ destructors. Comment at: test/Sema/warn-unreachable-ms.c:49 __try { - f(); + throw 1; } __except (1) { Nice. Would any

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

davidxl added a comment. Looks fine to me, but please wait for Richard's comment. https://reviews.llvm.org/D37091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37109: [clang-format] Emit absolute splits before lines for comments, try 2

This revision was automatically updated to reflect the committed changes. Closed by commit rL311672: [clang-format] Emit absolute splits before lines for comments, try 2 (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D37109 Files:

r311672 - [clang-format] Emit absolute splits before lines for comments, try 2

Author: krasimir Date: Thu Aug 24 09:41:10 2017 New Revision: 311672 URL: http://llvm.org/viewvc/llvm-project?rev=311672=rev Log: [clang-format] Emit absolute splits before lines for comments, try 2 Summary: This recommits https://reviews.llvm.org/D36956 with an update to the added test case to

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: lib/Tooling/Refactoring/SourceSelectionConstraints.cpp:13 + +using namespace clang; +using namespace tooling; ioeric wrote: > We are tempted to avoid `using namespace` if possible. Why? It's not in a header. `using

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringResult.h:21 +struct RefactoringResult { + enum ResultKind { +/// A set of source replacements represented using a vector of ioeric wrote: > arphaman wrote: > > ioeric

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

danielcdh updated this revision to Diff 112574. danielcdh marked 2 inline comments as done. danielcdh added a comment. updated the patch to put it into function attribute so that it works with ThinLTO https://reviews.llvm.org/D37091 Files: docs/ClangCommandLineReference.rst

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

Merged to 5.0 in r311671. On Wed, Aug 23, 2017 at 2:24 PM, Adrian Prantl via cfe-commits wrote: > Author: adrian > Date: Wed Aug 23 14:24:12 2017 > New Revision: 311601 > > URL: http://llvm.org/viewvc/llvm-project?rev=311601=rev > Log: > Fix a bug in

[PATCH] D36075: [refactor] Initial support for refactoring action rules

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h:26 +template +detail::SourceSelectionRequirement< +typename selection::detail::EvaluateSelectionChecker< arphaman wrote: > ioeric wrote: > >

[PATCH] D31370: [clang-tidy] Prototype to check for exception specification

JonasToth abandoned this revision. JonasToth added a comment. exception checking seems to end in the front end for such cases, so nothing to do here anymore. reimplement if there is need later. Repository: rL LLVM https://reviews.llvm.org/D31370

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth updated this revision to Diff 112573. JonasToth added a comment. - fix indendation in testcase https://reviews.llvm.org/D36586 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/hicpp/SignedBitwiseCheck.cpp

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth updated this revision to Diff 112572. JonasToth added a comment. - get up to date with master - added testcase for enums https://reviews.llvm.org/D36586 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/hicpp/SignedBitwiseCheck.cpp

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

This revision was automatically updated to reflect the committed changes. Closed by commit rL311669: [mips] Introducing option -mabs=[legacy/2008] (authored by petarj). Changed prior to commit: https://reviews.llvm.org/D35982?vs=112534=112571#toc Repository: rL LLVM

r311669 - [mips] Introducing option -mabs=[legacy/2008]

Author: petarj Date: Thu Aug 24 09:06:30 2017 New Revision: 311669 URL: http://llvm.org/viewvc/llvm-project?rev=311669=rev Log: [mips] Introducing option -mabs=[legacy/2008] In patch r205628 using abs.[ds] instruction is forced, as they should behave in accordance with flags Has2008 and ABS2008.

[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

ahatanak added a comment. In https://reviews.llvm.org/D36915#849622, @faisalv wrote: > I don't think this approach is entirely correct for at least the following > reasons: > > 1. in the lambda case the machinery that diagnoses capture failures should be > the machinery erroring on the lambda

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:23 + const auto SignedIntegerOperand = + expr(ignoringImpCasts(hasType(isSignedInteger(.bind("signed_operand"); + aaron.ballman wrote: > JonasToth wrote: > >

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann added a comment. I'm glad this is finally in a state to land. Thanks for the helpful reviews! https://reviews.llvm.org/D35955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >