[libclc] r312854 - integer: Add popcount implementation using ctpop intrinsic

Author: awatry Date: Fri Sep 8 19:23:54 2017 New Revision: 312854 URL: http://llvm.org/viewvc/llvm-project?rev=312854=rev Log: integer: Add popcount implementation using ctpop intrinsic Also copy/modify the unary_intrin.inc from math/ to make the intrinsic declaration somewhat reusable. Passes

r312851 - Fix ownership of the MemoryBuffer in a FrontendInputFile.

Author: rsmith Date: Fri Sep 8 18:14:04 2017 New Revision: 312851 URL: http://llvm.org/viewvc/llvm-project?rev=312851=rev Log: Fix ownership of the MemoryBuffer in a FrontendInputFile. This fixes a possible crash on certain kinds of corrupted AST file, but checking in an AST file corrupted in

r312850 - [cxx_status] Change "Clang 5" items from yellow to green now that Clang 5 has been released.

Author: rsmith Date: Fri Sep 8 18:11:04 2017 New Revision: 312850 URL: http://llvm.org/viewvc/llvm-project?rev=312850=rev Log: [cxx_status] Change "Clang 5" items from yellow to green now that Clang 5 has been released. Modified: cfe/trunk/www/cxx_dr_status.html

[PATCH] D37656: [cfi] Set function attributes for __cfi_* functions.

eugenis created this revision. Herald added subscribers: hiraditya, kristof.beyls, srhines, aemerson. Set target_cpu and target_features attributes on __cfi_check_fail and __cfi_check. Make cfi_check use Thumb encoding on ARM target. https://reviews.llvm.org/D37656 Files:

r312842 - Catch more cases with -Wenum-compare

Author: rtrieu Date: Fri Sep 8 17:25:05 2017 New Revision: 312842 URL: http://llvm.org/viewvc/llvm-project?rev=312842=rev Log: Catch more cases with -Wenum-compare Treat typedef enum as named enums instead of anonymous enums. Anonymous enums are ignored by the warning, so previously, typedef

[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

inglorion updated this revision to Diff 114465. inglorion added a comment. Of course, ApplyDebugLocation is also a perfectly legitimate way to add a debug location to nodes that are not nested inside nodes that already have a location. I updated the diff so that we do end up applying the

[libclc] r312839 - Implement vload_half{,n} and vload(half)

Author: jvesely Date: Fri Sep 8 16:59:00 2017 New Revision: 312839 URL: http://llvm.org/viewvc/llvm-project?rev=312839=rev Log: Implement vload_half{,n} and vload(half) v2: add vload(half) as well make helpers amdgpu specific (NVPTX uses different private AS numbering) use clang builtin

[libclc] r312838 - vstore: Cleanup and add vstore(half)

Author: jvesely Date: Fri Sep 8 16:58:57 2017 New Revision: 312838 URL: http://llvm.org/viewvc/llvm-project?rev=312838=rev Log: vstore: Cleanup and add vstore(half) Add missing undefs Make helpers amdgpu specific (NVPTX uses different numbering for private AS) Use clang builtins on clang >= 6

[libclc] r312837 - configure.py: Simplify compatibility sources

Author: jvesely Date: Fri Sep 8 16:58:53 2017 New Revision: 312837 URL: http://llvm.org/viewvc/llvm-project?rev=312837=rev Log: configure.py: Simplify compatibility sources Just add the SOURCE_X.Y list to the list of sources if X.Y is the current llvm version. Signed-off-by: Jan Vesely

[PATCH] D37564: Update users of llvm::sys::ExecuteAndWait etc.

vsk added a comment. Looks good to me. https://reviews.llvm.org/D37564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

Well, if they worked I wasn't going to say we needed to add tests for them, i just wanted to make sure they work before we move onto something else. In any case, lgtm On Fri, Sep 8, 2017 at 4:43 PM Bob Haarman via Phabricator < revi...@reviews.llvm.org> wrote: > inglorion updated this revision

[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

inglorion updated this revision to Diff 114463. inglorion added a comment. added examples suggested by @zturner, verified step over and step into specific behavior matches MSVC, and added tests for them https://reviews.llvm.org/D37529 Files: clang/lib/CodeGen/CGDebugInfo.cpp

r312835 - CodeGen: correct arguments for NSFastEnumeration

Author: compnerd Date: Fri Sep 8 16:41:17 2017 New Revision: 312835 URL: http://llvm.org/viewvc/llvm-project?rev=312835=rev Log: CodeGen: correct arguments for NSFastEnumeration When performing a NSFastEnumeration, the compiler synthesizes a call to `countByEnumeratingWithState:objects:count:`

[PATCH] D37470: [analyzer] Handle ObjC messages conservatively in CallDescription

vsk added a comment. Can you add a test? Repository: rL LLVM https://reviews.llvm.org/D37470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Buildbot numbers for the week of 08/27/2017 - 09/02/2017

Hello everyone, Below are some buildbot numbers for the last week of 08/27/2017 - 09/02/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

[PATCH] D37649: [Driver] Support ubsan-minimal on Darwin

vsk created this revision. Make it possible to use the minimal ubsan runtime on Darwin. https://reviews.llvm.org/D37649 Files: lib/Driver/ToolChains/Darwin.cpp test/Driver/sanitizer-ld.c Index: test/Driver/sanitizer-ld.c ===

Buildbot numbers for the week of 08/20/2017 - 08/26/2017

Hello everyone, Below are some buildbot numbers for last the week of 08/20/2017 - 08/26/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

Buildbot numbers for the week of 08/13/2017 - 08/19/2017

Hello everyone, Below are some buildbot numbers for the week of 08/13/2017 - 08/19/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 08/06/2017 - 08/12/2017

Hello everyone, Below are some buildbot numbers for the week of 08/06/2017 - 08/12/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 07/30/2017 - 08/05/2017

Hello everyone, Below are some buildbot numbers for the week of 07/30/2017 - 08/05/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 07/23/2017 - 07/29/2017

Hello everyone, Below are some buildbot numbers for the week of 07/23/2017 - 07/29/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 07/16/2017 - 07/22/2017

Hello everyone, Below are some buildbot numbers for the week of 07/16/2017 - 07/22/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[PATCH] D37647: [ubsan-minimal] Document the new runtime

vsk created this revision. https://reviews.llvm.org/D37647 Files: docs/ReleaseNotes.rst docs/UndefinedBehaviorSanitizer.rst Index: docs/UndefinedBehaviorSanitizer.rst === --- docs/UndefinedBehaviorSanitizer.rst +++

[PATCH] D37436: Initial implementation of C attributes (WG14 N2137)

aaron.ballman updated this revision to Diff 114447. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on Richard's comments and some further discussion on IRC. https://reviews.llvm.org/D37436 Files: include/clang/Basic/Attr.td

[PATCH] D37643: Add objcImplementationDecl matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D37643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37643: Add objcImplementationDecl matcher

kastiglione created this revision. Herald added a subscriber: klimek. Add the `objcImplementationDecl` matcher. See related: https://reviews.llvm.org/D30854 Tested with: ./tools/clang/unittests/ASTMatchers/ASTMatchersTests https://reviews.llvm.org/D37643 Files:

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

fjricci added inline comments. Comment at: lib/Driver/ToolChain.cpp:851 + XOpenMPTargetArg->setBaseArg(A); + A = XOpenMPTargetArg.release(); + DAL->append(A); Hahnfeld wrote: > This is a memory leak that is currently triggered in >

r312830 - Reinstall the patch "Use EmitPointerWithAlignment to get alignment information of the pointer used in atomic expr".

Author: wmi Date: Fri Sep 8 14:58:18 2017 New Revision: 312830 URL: http://llvm.org/viewvc/llvm-project?rev=312830=rev Log: Reinstall the patch "Use EmitPointerWithAlignment to get alignment information of the pointer used in atomic expr". This is to fix PR34347. EmitAtomicExpr now only uses

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Fri, Sep 8, 2017 at 5:49 PM, Hans Wennborg via cfe-commits wrote: > On Fri, Sep 8, 2017 at 2:26 PM, Friedman, Eli wrote: >> On 9/8/2017 2:18 PM, Hans Wennborg via cfe-commits wrote: >>> >>> On Fri, Sep 8, 2017 at 2:09 PM, Roman Lebedev

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Sat, Sep 9, 2017 at 12:18 AM, Hans Wennborg wrote: > On Fri, Sep 8, 2017 at 2:09 PM, Roman Lebedev wrote: >> On Fri, Sep 8, 2017 at 11:45 PM, Hans Wennborg wrote: >>> On Fri, Sep 8, 2017 at 4:48 AM, Sam McCall via cfe-commits >>>

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Fri, Sep 8, 2017 at 2:26 PM, Friedman, Eli wrote: > On 9/8/2017 2:18 PM, Hans Wennborg via cfe-commits wrote: >> >> On Fri, Sep 8, 2017 at 2:09 PM, Roman Lebedev >> wrote: >>> >>> >>> Interesting. My first thought was to explicitly specify enum

[PATCH] D37642: [pp-trace] Update skipped source ranges in tests

vsk created this revision. Herald added subscribers: kbarton, nemanjai. Depends on https://reviews.llvm.org/D36642 https://reviews.llvm.org/D37642 Files: pp-trace/PPCallbacksTracker.cpp pp-trace/PPCallbacksTracker.h test/pp-trace/pp-trace-conditional.cpp

[PATCH] D36642: [Lexer] Report more precise skipped regions (PR34166)

vsk updated this revision to Diff 114433. vsk added a comment. Herald added subscribers: kbarton, nemanjai. - Add an 'EndifLoc' parameter to the SourceRangeSkipped callback so that indexing clients can preserve their existing behavior. - I'll submit a follow-up patch which updates the pp-trace

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On 9/8/2017 2:18 PM, Hans Wennborg via cfe-commits wrote: On Fri, Sep 8, 2017 at 2:09 PM, Roman Lebedev wrote: Interesting. My first thought was to explicitly specify enum as signed: enum MediaDeviceType : signed int { MEDIA_DEVICE_TYPE_AUDIO_INPUT = 0,

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Fri, Sep 8, 2017 at 2:09 PM, Roman Lebedev wrote: > On Fri, Sep 8, 2017 at 11:45 PM, Hans Wennborg wrote: >> On Fri, Sep 8, 2017 at 4:48 AM, Sam McCall via cfe-commits >> wrote: >>> Nice fix! It catches a lot of new cases

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

efriedma added a comment. Oh, you don't want to emit them by default. :) I'm not sure what you're trying to do here... there are three possibilities: 1. The function could have an exception thrown through it, so we need an unwind table. 2. The function can't have an exception thrown through

[PATCH] D37530: [MinGW] Don't link -lmsvcrt if a different msvcrt version is to be linked

mstorsjo updated this revision to Diff 114429. mstorsjo retitled this revision from "[MinGW] Allow overriding which version of msvcrt to link to" to "[MinGW] Don't link -lmsvcrt if a different msvcrt version is to be linked". mstorsjo edited the summary of this revision. mstorsjo added a

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Fri, Sep 8, 2017 at 11:45 PM, Hans Wennborg wrote: > On Fri, Sep 8, 2017 at 4:48 AM, Sam McCall via cfe-commits > wrote: >> Nice fix! It catches a lot of new cases on our codebase, all technically >> correct so far. >> >> A couple of issues

[PATCH] D37308: Interface class with uuid base record

erichkeane added a comment. 1 more thing I missed. Comment at: lib/Sema/SemaDeclCXX.cpp:2389 + return RD->isStruct() && RD->getName() == "IUnknown" && RD->isEmpty() && + Uuid && Uuid->getGuid() =="---C000-0046"; +} This also

[PATCH] D37308: Interface class with uuid base record

erichkeane requested changes to this revision. erichkeane added inline comments. This revision now requires changes to proceed. Comment at: lib/Sema/SemaDeclCXX.cpp:2377 +/// \brief Tests if the __interface base is public. +static bool IsRecordPublicInterface(const CXXRecordDecl

[PATCH] D37308: Interface class with uuid base record

zahiraam updated this revision to Diff 114428. zahiraam added a comment. Responding to Erich 's and Aaron's reviews. Thanks. https://reviews.llvm.org/D37308 Files: lib/Sema/SemaDeclCXX.cpp test/SemaCXX/ms-uuid.cpp Index: test/SemaCXX/ms-uuid.cpp

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Fri, Sep 8, 2017 at 4:48 AM, Sam McCall via cfe-commits wrote: > Nice fix! It catches a lot of new cases on our codebase, all technically > correct so far. > > A couple of issues though: > A) Rollout - until we've completely cleaned up, we need to disable >

[PATCH] D36642: [Lexer] Report more precise skipped regions (PR34166)

vsk added inline comments. Comment at: test/Index/skipped-ranges.c:23 // RUN: env CINDEXTEST_SHOW_SKIPPED_RANGES=1 c-index-test -test-annotate-tokens=%s:1:1:16:1 %s | FileCheck %s -// CHECK: Skipping: [5:2 - 6:7] -// CHECK: Skipping: [8:2 - 12:7] -// CHECK: Skipping: [14:2 -

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

aaron.ballman added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-owning-memory.cpp:39 + return new int(42); + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: returning a 'gsl::owner<>' from a function but not declaring it; return type is 'int *' +}

[PATCH] D37572: [clang-tidy] SuspiciousEnumUsageCheck bugfix

aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-suspicious-enum-usage.cpp:122 +struct a> { + enum { ah = ad::m, + ai = ae::m, alexfh wrote: > alexfh wrote: > > aaron.ballman wrote: > > > alexfh wrote: > > > >

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

Nebiroth updated this revision to Diff 114424. Nebiroth marked 7 inline comments as done. Nebiroth added a comment. Ran clang-format on modified files. Minor refactoring. https://reviews.llvm.org/D36150 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

cameron314 added a comment. It seems there's other users of `PrecompiledPreamble` that would have to be fixed, yes. If we go with my original fix of taking into account the BOM in the preamble bounds, there's no way of reusing the PCH when the BOM appears/disappears. I still maintain this is a

[PATCH] D37101: [clangd] Add support for snippet completions

rwols updated this revision to Diff 114415. rwols added a comment. Update the description for the "-enable-snippets" option. https://reviews.llvm.org/D37101 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp

[PATCH] D36973: [libclang] Add support for querying cursor availability

jbcoe requested changes to this revision. jbcoe added inline comments. This revision now requires changes to proceed. Comment at: bindings/python/tests/cindex/test_cursor.py:399 +else: +assert False, "Could not find cursor for deleted constructor" +

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

cameron314 updated this revision to Diff 114414. cameron314 added a comment. The latest patch. I think this one should do the trick :-) https://reviews.llvm.org/D37474 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/ASTUnit.cpp unittests/Frontend/CMakeLists.txt

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-owning-memory.cpp:39 + return new int(42); + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: returning a 'gsl::owner<>' from a function but not declaring it; return type is 'int *' +}

Re: [PATCH] D37604: Disable debuginfo-tests for non-native configurations

> On Sep 8, 2017, at 11:43 AM, Adrian Prantl wrote: > > >> On Sep 8, 2017, at 10:54 AM, Paul Robinson via Phabricator >> wrote: >> >> probinson added a comment. >> >> In https://reviews.llvm.org/D37604#864187, @aprantl wrote: >> >>> This seems

[PATCH] D37436: Initial implementation of C attributes (WG14 N2137)

rsmith added a comment. Accepting this under `-std=c2x` is premature. We don't even know whether there will be such a standard yet, and this has not been voted into a working draft. But the `-f` flag form is OK. Comment at: include/clang/Driver/Options.td:607 +def

r312818 - [Coverage] Precise region termination with deferred regions (reapply)

Author: vedantk Date: Fri Sep 8 11:44:56 2017 New Revision: 312818 URL: http://llvm.org/viewvc/llvm-project?rev=312818=rev Log: [Coverage] Precise region termination with deferred regions (reapply) The current coverage implementation doesn't handle region termination very precisely. Take for

[PATCH] D33852: Enable __declspec(selectany) on linux

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:3154 + +def SelectAnyDocs : Documentation { + let Content = [{This attribute makes global symbol have a weak definition aaron.ballman wrote: > majnemer wrote: > > aaron.ballman

Re: [PATCH] D37604: Disable debuginfo-tests for non-native configurations

> On Sep 8, 2017, at 10:54 AM, Paul Robinson via Phabricator > wrote: > > probinson added a comment. > > In https://reviews.llvm.org/D37604#864187, @aprantl wrote: > >> This seems reasonable to me, thanks! >> When you commit this, could you please double-check that

r312811 - Add some documentation on how to generate the documentation.

Author: aaronballman Date: Fri Sep 8 11:40:39 2017 New Revision: 312811 URL: http://llvm.org/viewvc/llvm-project?rev=312811=rev Log: Add some documentation on how to generate the documentation. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified:

[PATCH] D37634: clang-rename: let -force handle multiple renames

vmiklos created this revision. The use case is that renaming multiple symbols in a large enough codebase is much faster if all of these can be done with a single invocation, but there will be multiple translation units where one or more symbols are not found. Old behavior was to exit

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

lebedev.ri added a comment. In https://reviews.llvm.org/D37629#865068, @lebedev.ri wrote: > And finish reducing the code by for-range-loop`ing over array + use > `std::array`. I will need to fix handling of the second edge-case (comparison with max unsigned value or with min/max for signed

r312810 - Delete empty file test/CodeGenCXX/atomic-align.cpp after the revert at rL312805.

Author: wmi Date: Fri Sep 8 11:31:21 2017 New Revision: 312810 URL: http://llvm.org/viewvc/llvm-project?rev=312810=rev Log: Delete empty file test/CodeGenCXX/atomic-align.cpp after the revert at rL312805. Removed: cfe/trunk/test/CodeGenCXX/atomic-align.cpp Removed:

r312805 - Revert rL312801 since it generated some calls from libatomic and broke some tests.

Author: wmi Date: Fri Sep 8 11:10:13 2017 New Revision: 312805 URL: http://llvm.org/viewvc/llvm-project?rev=312805=rev Log: Revert rL312801 since it generated some calls from libatomic and broke some tests. Modified: cfe/trunk/lib/CodeGen/CGAtomic.cpp

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

lebedev.ri updated this revision to Diff 114396. lebedev.ri added a comment. And finish reducing the code by for-range-loop`ing over array + use `std::array`. Repository: rL LLVM https://reviews.llvm.org/D37629 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D37604: Disable debuginfo-tests for non-native configurations

probinson added a comment. In https://reviews.llvm.org/D37604#864187, @aprantl wrote: > This seems reasonable to me, thanks! > When you commit this, could you please double-check that the tests are still > running on the green dragon builders? I'll also keep an eye on them. I was able to

[PATCH] D37572: [clang-tidy] SuspiciousEnumUsageCheck bugfix

alexfh added inline comments. Comment at: test/clang-tidy/misc-suspicious-enum-usage.cpp:122 +struct a> { + enum { ah = ad::m, + ai = ae::m, alexfh wrote: > aaron.ballman wrote: > > alexfh wrote: > > > aaron.ballman wrote: > > > > This

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

jroelofs added a comment. I'm not sure it's better than writing the if/elseif/elseif/elseif out explicitly :/ Repository: rL LLVM https://reviews.llvm.org/D37629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37572: [clang-tidy] SuspiciousEnumUsageCheck bugfix

alexfh added inline comments. Comment at: test/clang-tidy/misc-suspicious-enum-usage.cpp:122 +struct a> { + enum { ah = ad::m, + ai = ae::m, aaron.ballman wrote: > alexfh wrote: > > aaron.ballman wrote: > > > This seems like a lot of

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

cameron314 added inline comments. Comment at: lib/Frontend/ASTUnit.cpp:1014 +/// with another virtual file system. +class PCHOverlayFileSystem : public vfs::FileSystem +{ ilya-biryukov wrote: > Maybe create a combination of `InMemoryFileSystem` and

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list=<arg1, arg2, ...> to match gcc options.

choikwa updated this revision to Diff 114388. choikwa added a comment. renamed and moved Cache to SourceLocToFileNameMap in CodeGenModule https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

anemet added a comment. Please clean this up as well (don't have commented-out lines) so that it's ready to go with the LLVM patch. Comment at: lib/CodeGen/CodeGenAction.cpp:302-305 static void DiagnosticHandler(const llvm::DiagnosticInfo ,

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

lebedev.ri updated this revision to Diff 114387. lebedev.ri added a subscriber: jroelofs. lebedev.ri added a comment. Rework as per @jroelofs's suggestion to have just one `switch`/`if` cascade that operates on `BinaryOperatorKind` Repository: rL LLVM https://reviews.llvm.org/D37629 Files:

[PATCH] D37604: Disable debuginfo-tests for non-native configurations

probinson closed this revision. probinson added a comment. r312803. Forgot to put the tag in the commit message https://reviews.llvm.org/D37604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37310: [Atomic] Merge alignment information from Decl and from Type when emit atomic expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rL312801: Use EmitPointerWithAlignment to get alignment information of the pointer used… (authored by wmi). Changed prior to commit: https://reviews.llvm.org/D37310?vs=114300=114384#toc Repository: rL

r312801 - Use EmitPointerWithAlignment to get alignment information of the pointer used in atomic expr.

Author: wmi Date: Fri Sep 8 10:07:32 2017 New Revision: 312801 URL: http://llvm.org/viewvc/llvm-project?rev=312801=rev Log: Use EmitPointerWithAlignment to get alignment information of the pointer used in atomic expr. This is to fix PR34347. EmitAtomicExpr now only uses alignment information

[PATCH] D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

anemet added a comment. Only minor things at this point. This is very close now. Comment at: include/llvm/Analysis/OptimizationDiagnosticInfo.h:81 /// detected by the user. - bool allowExtraAnalysis() const { -// For now, only allow this with

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:6994 + // OpenCL v1.2 s6.5: + // The generic address space name for arguments to a function in a + // program, or local variables of a function is __private. All function yaxunl

[PATCH] D37599: Add '\n' in ClangDataCollectorsEmitter

kzhuravl added a comment. In https://reviews.llvm.org/D37599#864376, @arphaman wrote: > LGTM. Do you have commit access? Yep, committed. Thanks. Repository: rL LLVM https://reviews.llvm.org/D37599 ___ cfe-commits mailing list

r312798 - Add _Float16 as a C/C++ source language type

Author: sjoerdmeijer Date: Fri Sep 8 09:43:10 2017 New Revision: 312798 URL: http://llvm.org/viewvc/llvm-project?rev=312798=rev Log: Add _Float16 as a C/C++ source language type Pacify the windows builder; fixed the new test as on Windows some additional attributes are printed. Modified:

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list=<arg1, arg2, ...> to match gcc options.

choikwa added a comment. Forgot to hang Cache to CodeGenModule, will do that shortly https://reviews.llvm.org/D37624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list=<arg1, arg2, ...> to match gcc options.

choikwa updated this revision to Diff 114380. choikwa added a comment. addressed code review. made doc consistent with functionality. https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h

[PATCH] D37599: Add '\n' in ClangDataCollectorsEmitter

This revision was automatically updated to reflect the committed changes. Closed by commit rL312795: Add '\n' in ClangDataCollectorsEmitter (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D37599?vs=114269=114376#toc Repository: rL LLVM

r312795 - Add '\n' in ClangDataCollectorsEmitter

Author: kzhuravl Date: Fri Sep 8 09:17:16 2017 New Revision: 312795 URL: http://llvm.org/viewvc/llvm-project?rev=312795=rev Log: Add '\n' in ClangDataCollectorsEmitter Differential Revision: https://reviews.llvm.org/D37599 Modified: cfe/trunk/utils/TableGen/ClangDataCollectorsEmitter.cpp

[PATCH] D33852: Enable __declspec(selectany) on linux

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:3154 + +def SelectAnyDocs : Documentation { + let Content = [{This attribute makes global symbol have a weak definition majnemer wrote: > aaron.ballman wrote: > > Prazek wrote: >

[PATCH] D37299: [Modules] Add ability to specify module name to module file mapping in a file

boris added a comment. Ping. https://reviews.llvm.org/D37299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Fri, Sep 8, 2017 at 3:26 PM, Roman Lebedev wrote: > On Fri, Sep 8, 2017 at 2:48 PM, Sam McCall wrote: > Hi. > >> Nice fix! > Thank you! > >> It catches a lot of new cases on our codebase, all technically >> correct so far. >> >> A couple of issues

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

lebedev.ri created this revision. lebedev.ri added a project: clang. As requested by Sam McCall: > Enums (not new I guess). Typical case: if (enum < 0 || enum > MAX) > The warning strongly suggests that the enum < 0 check has no effect > (for enums with nonnegative ranges). > Clang doesn't

[PATCH] D33852: Enable __declspec(selectany) on linux

majnemer added inline comments. Comment at: include/clang/Basic/AttrDocs.td:3154 + +def SelectAnyDocs : Documentation { + let Content = [{This attribute makes global symbol have a weak definition aaron.ballman wrote: > Prazek wrote: > > aaron.ballman wrote: >

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

Nebiroth updated this revision to Diff 114371. Nebiroth marked 10 inline comments as done. Nebiroth added a comment. Ran clang-format on modified files. More minor refactoring. https://reviews.llvm.org/D37150 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D37572: [clang-tidy] SuspiciousEnumUsageCheck bugfix

aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-suspicious-enum-usage.cpp:122 +struct a> { + enum { ah = ad::m, + ai = ae::m, alexfh wrote: > aaron.ballman wrote: > > This seems like a lot of complicated code for the

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list=<arg1, arg2, ...> to match gcc options.

aaron.ballman added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:425 /// instrumented with __cyg_profile_func_* calls -bool CodeGenFunction::ShouldInstrumentFunction() { +bool CodeGenFunction::ShouldInstrumentFunction(llvm::Function *Fn) { + typedef

[PATCH] D37572: [clang-tidy] SuspiciousEnumUsageCheck bugfix

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG modulo comments. Thank you for the fix! Comment at: test/clang-tidy/misc-suspicious-enum-usage.cpp:1 -// RUN: %check_clang_tidy %s misc-suspicious-enum-usage %t --

Re: Patch bug 27628

Aaand the patch itself... -K On 9/8/2017 10:32 AM, Krzysztof Parzyszek via cfe-commits wrote: This should to to cfe-commits. Redirecting. -Krzysztof On 9/8/2017 10:25 AM, Antoni Boucher via llvm-commits wrote: Hello. I've fixed the bug 27628: https://bugs.llvm.org/show_bug.cgi?id=27628 I

[PATCH] D36327: [OpenCL] Allow targets emit optimized pipe functions for power of 2 type sizes

yaxunl abandoned this revision. yaxunl added a comment. We implemented this optimization through some target specific llvm pass. https://reviews.llvm.org/D36327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: Patch bug 27628

This should to to cfe-commits. Redirecting. -Krzysztof On 9/8/2017 10:25 AM, Antoni Boucher via llvm-commits wrote: Hello. I've fixed the bug 27628: https://bugs.llvm.org/show_bug.cgi?id=27628 I attached the patch. Thanks. ___ llvm-commits

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: lib/Sema/SemaType.cpp:6994 + // OpenCL v1.2 s6.5: + // The generic address space name for arguments to a function in a + // program, or local variables of a function is __private.

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:6994 + // OpenCL v1.2 s6.5: + // The generic address space name for arguments to a function in a + // program, or local variables of a function is __private. All function yaxunl

r312794 - Recommit "Add _Float16 as a C/C++ source language type"

Author: sjoerdmeijer Date: Fri Sep 8 08:15:00 2017 New Revision: 312794 URL: http://llvm.org/viewvc/llvm-project?rev=312794=rev Log: Recommit "Add _Float16 as a C/C++ source language type" This is a recommit of r312781; in some build configurations variable names are omitted, so changed the new

[PATCH] D37568: [AMDGPU] Allow flexible register names in inline asm constraints

yaxunl updated this revision to Diff 114367. yaxunl edited the summary of this revision. yaxunl added a comment. Allow {v[n]} and {s[n]}. Add more tests. https://reviews.llvm.org/D37568 Files: lib/Basic/Targets/AMDGPU.h test/CodeGenOpenCL/amdgcn-inline-asm.cl

[PATCH] D37572: [clang-tidy] SuspiciousEnumUsageCheck bugfix

aaron.ballman added inline comments. Comment at: clang-tidy/misc/SuspiciousEnumUsageCheck.cpp:46 + return llvm::APSInt::compareValues(E1->getInitVal(), + E2->getInitVal()) == -1; }); I would test for

[PATCH] D37140: [clang-format] Fixed one-line if statement

PriMee added a comment. Yes, would be great :) Thank you! https://reviews.llvm.org/D37140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

ilya-biryukov added a comment. In https://reviews.llvm.org/D37491#864649, @erikjv wrote: > Will this fix PR25023 and PR21144? PR25023 should be fixed by this change. It is essentially a repro of the same bug. Could we add a `c-index-test`-based

  1   2   >