[PATCH] D37308: Interface class with uuid base record

erichkeane added a comment. You seem to have had a hard time with the diff tool too... there is an extra file here that needs to be removed. Comment at: lib/Sema/SemaDeclCXX.cpp:2390 + Uuid && Uuid->getGuid() =="---C000-0046" && +

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

anemet added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:882-883 BEConsumer = Result.get(); - + VMContext->setDiagnosticHandler(llvm::make_unique( + CI.getCodeGenOpts(), Result.get())); // Enable generating macro debug info only when debug info is not

[PATCH] D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

anemet accepted this revision. anemet added a comment. This revision is now accepted and ready to land. LGTM with the nits below. Thanks! Comment at: include/llvm/IR/DiagnosticHandler.h:1 +//===- DiagnosticHandler.cpp - DiagnosticHandler class for LLVM -*- C++ -*-===// +//

[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

ahatanak updated this revision to Diff 114753. ahatanak added a comment. Address review comments. - Detect invalid references to parameters or local variables by default arguments in tryCaptureVariable. Before parsing or instantiating the default argument expression, the enclosing DeclContext

[PATCH] D37726: clang: alias -static-{libstdc++, libgcc} for LLVM variants

martell created this revision. Alias `-static-compiler-rt` and `static-libc++` to their gcc counterparts. Currently invoking `-static-libgcc` or `-static-libstdc++` will ensure only use of static libs. In future if we want to do more accurate handling with better behaviour with the linker we

[PATCH] D37723: [Driver] Fuchsia targets default to -fasynchronous-unwind-tables

This revision was automatically updated to reflect the committed changes. Closed by commit rL312989: [Driver] Fuchsia targets default to -fasynchronous-unwind-tables (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D37723?vs=114737=114746#toc Repository: rL LLVM

r312989 - [Driver] Fuchsia targets default to -fasynchronous-unwind-tables

Author: phosek Date: Mon Sep 11 18:28:37 2017 New Revision: 312989 URL: http://llvm.org/viewvc/llvm-project?rev=312989=rev Log: [Driver] Fuchsia targets default to -fasynchronous-unwind-tables This regressed for x86-64 in r307856 because it's no longer inherited from Generic_GCC. We'd never

r312986 - Fix broken links to the Itanium CXX ABI

Author: vlad.tsyrklevich Date: Mon Sep 11 17:21:17 2017 New Revision: 312986 URL: http://llvm.org/viewvc/llvm-project?rev=312986=rev Log: Fix broken links to the Itanium CXX ABI Modified: cfe/trunk/docs/ControlFlowIntegrityDesign.rst cfe/trunk/docs/Toolchain.rst

[PATCH] D37723: [Driver] Fuchsia targets default to -fasynchronous-unwind-tables

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D37723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37723: [Driver] Fuchsia targets default to -fasynchronous-unwind-tables

mcgrathr created this revision. Herald added subscribers: kristof.beyls, aemerson. This regressed for x86-64 in r307856 because it's no longer inherited from Generic_GCC. We'd never noticed that it was missing other targets (i.e. aarch64), but Fuchsia is uniform across all machines.

[PATCH] D37530: [MinGW] Don't link -lmsvcrt if a different msvcrt version is to be linked

martell accepted this revision. martell added a comment. LGMT https://reviews.llvm.org/D37530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37436: Initial implementation of C attributes (WG14 N2137)

rsmith added a comment. If this is just supposed to be an experiment to get feedback on the feature, then I don't think we should be treating it as a different attribute syntax at all. Rather, I think we just want to permit C++11 attributes to be parsed in other language modes. If/when this

[PATCH] D37663: [AST] Make RecursiveASTVisitor visit CXXOperatorCallExpr in source order

rsmith added inline comments. Comment at: include/clang/AST/RecursiveASTVisitor.h:327 + + SmallVector getStmtChildren(CXXOperatorCallExpr *CE) { +SmallVector Children(CE->children()); The copy here is more expensive than I'd like. Instead of returning a

[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rL312965: [codeview] omit debug locations for nested exprs unless column info enabled (authored by inglorion). Changed prior to commit: https://reviews.llvm.org/D37529?vs=114715=114716#toc Repository:

r312965 - [codeview] omit debug locations for nested exprs unless column info enabled

Author: inglorion Date: Mon Sep 11 15:11:57 2017 New Revision: 312965 URL: http://llvm.org/viewvc/llvm-project?rev=312965=rev Log: [codeview] omit debug locations for nested exprs unless column info enabled Summary: Microsoft Visual Studio expects debug locations to correspond to statements. We

[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

inglorion updated this revision to Diff 114715. inglorion added a comment. renamed get{Nested,}ExpressionLocationsEnabled and moved it into CodeGetModule.cpp https://reviews.llvm.org/D37529 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

rjmccall added a comment. In https://reviews.llvm.org/D33826#866170, @lebedev.ri wrote: > In https://reviews.llvm.org/D33826#866161, @JonasToth wrote: > > > There is an exception to the general rule (EXP36-C-EX2), stating that the > > result of `malloc` and friends is allowed to be casted to

Re: [libcxxabi] r308470 - Drop 'svn' suffix from version number.

Sorry, I completely missed that this affected the version string on released binaries; I was even a reviewer on r312043 :-/ For Windows release builds, the version info gets set explicitly, but not for other builds. We should have merged r312043 to 5.0.0.. perhaps it will go into 5.0.1. - Hans

[PATCH] D37649: [Driver] Support ubsan-minimal on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL312958: [Driver] Support ubsan-minimal on Darwin (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D37649?vs=114458=114704#toc Repository: rL LLVM

[PATCH] D37647: [ubsan-minimal] Document the new runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rL312957: [ubsan-minimal] Document the new runtime (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D37647?vs=114449=114703#toc Repository: rL LLVM

r312958 - [Driver] Support ubsan-minimal on Darwin

Author: vedantk Date: Mon Sep 11 14:37:06 2017 New Revision: 312958 URL: http://llvm.org/viewvc/llvm-project?rev=312958=rev Log: [Driver] Support ubsan-minimal on Darwin Make it possible to use the minimal ubsan runtime on Darwin. Differential Revision: https://reviews.llvm.org/D37649

r312957 - [ubsan-minimal] Document the new runtime

Author: vedantk Date: Mon Sep 11 14:37:05 2017 New Revision: 312957 URL: http://llvm.org/viewvc/llvm-project?rev=312957=rev Log: [ubsan-minimal] Document the new runtime Differential Revision: https://reviews.llvm.org/D37647 Modified: cfe/trunk/docs/ReleaseNotes.rst

[PATCH] D37642: [pp-trace] Update skipped source ranges in tests

vsk closed this revision. vsk added a comment. Thanks, r312948 https://reviews.llvm.org/D37642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37577: [libclang] add 'clang_getCursorTLSKind'

frutiger updated this revision to Diff 114701. frutiger added a comment. Use more specific target platform. https://reviews.llvm.org/D37577 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_tls_kind.py include/clang-c/Index.h tools/libclang/CIndex.cpp

[PATCH] D37448: Fix cast assertion on MS inline assembly with vector spills (PR34021)

RKSimon added a comment. In https://reviews.llvm.org/D37448#866700, @rnk wrote: > lgtm > > I was hoping for a test case that didn't require assertions, but this is > enough to land the fix. My mistake, I should be able to remove that as well - I'll do it as part of the commit. Thanks.

[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

rnk added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:32 #include "clang/Basic/XRayLists.h" +#include "clang/Frontend/CodeGenOptions.h" #include "llvm/ADT/DenseMap.h" majnemer wrote: > Any reason to do this? I'd just keep

[PATCH] D37577: [libclang] add 'clang_getCursorTLSKind'

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: bindings/python/tests/cindex/test_tls_kind.py:32 +__declspec(thread) int tls_declspec; +""", lang = 'cpp', flags=['-fms-extensions', '-target',

[PATCH] D36642: [Lexer] Report more precise skipped regions (PR34166)

This revision was automatically updated to reflect the committed changes. Closed by commit rL312947: [Lexer] Report more precise skipped regions (PR34166) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D36642?vs=114433=114676#toc Repository: rL LLVM

[clang-tools-extra] r312948 - [pp-trace] Update skipped source ranges in tests

Author: vedantk Date: Mon Sep 11 13:47:45 2017 New Revision: 312948 URL: http://llvm.org/viewvc/llvm-project?rev=312948=rev Log: [pp-trace] Update skipped source ranges in tests Depends on D36642 Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp

r312947 - [Lexer] Report more precise skipped regions (PR34166)

Author: vedantk Date: Mon Sep 11 13:47:42 2017 New Revision: 312947 URL: http://llvm.org/viewvc/llvm-project?rev=312947=rev Log: [Lexer] Report more precise skipped regions (PR34166) This patch teaches the preprocessor to report more precise source ranges for code that is skipped due to

[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

majnemer added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:32 #include "clang/Basic/XRayLists.h" +#include "clang/Frontend/CodeGenOptions.h" #include "llvm/ADT/DenseMap.h" Any reason to do this? I'd just keep

[PATCH] D37634: clang-rename: let -force handle multiple renames

This revision was automatically updated to reflect the committed changes. Closed by commit rL312942: clang-rename: let -force handle multiple renames (authored by vmiklos). Changed prior to commit: https://reviews.llvm.org/D37634?vs=114402=114663#toc Repository: rL LLVM

r312942 - clang-rename: let -force handle multiple renames

Author: vmiklos Date: Mon Sep 11 13:18:38 2017 New Revision: 312942 URL: http://llvm.org/viewvc/llvm-project?rev=312942=rev Log: clang-rename: let -force handle multiple renames Summary: The use case is that renaming multiple symbols in a large enough codebase is much faster if all of these can

r312941 - Driver: default to `-fno-use-cxatexit` on Windows

Author: compnerd Date: Mon Sep 11 13:18:09 2017 New Revision: 312941 URL: http://llvm.org/viewvc/llvm-project?rev=312941=rev Log: Driver: default to `-fno-use-cxatexit` on Windows This primarily impacts the Windows MSVC and Windows itanium environments. Windows MSVC does not use `__cxa_atexit`

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

Nebiroth updated this revision to Diff 114654. Nebiroth added a comment. Simpilified a pointer return value. https://reviews.llvm.org/D37150 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/GlobalCompilationDatabase.cpp

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

Nebiroth updated this revision to Diff 114652. Nebiroth added a comment. Return value when no file is found is now an empty string instead of file:// Minor code style changes and cleanup. Ran clang-format on ClangdServer.h https://reviews.llvm.org/D36150 Files: clangd/ClangdLSPServer.cpp

[PATCH] D37530: [MinGW] Don't link -lmsvcrt if a different msvcrt version is to be linked

rnk added a comment. In https://reviews.llvm.org/D37530#865333, @mstorsjo wrote: > Attempted implementing Reid's suggestion. > > On the mingw-w64 mailing list > (https://sourceforge.net/p/mingw-w64/mailman/message/36030072/), there were > points made that it would be better with some mechanism

[PATCH] D37530: [MinGW] Don't link -lmsvcrt if a different msvcrt version is to be linked

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D37530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/CodeGen/CodeGenModule.h:517 + /// Return true if we should emit location information for nested expressions. + bool

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

Nebiroth marked 5 inline comments as done. Nebiroth added inline comments. Comment at: clangd/ClangdLSPServer.cpp:234 + else +ResultUri = URI::fromFile(""); + ilya-biryukov wrote: > Running `unparse` on an instance created via `URI::fromFile("")` will

[PATCH] D33514: [WIP] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

vivekvpandya updated this revision to Diff 114647. vivekvpandya marked 8 inline comments as done. https://reviews.llvm.org/D33514 Files: include/llvm/Analysis/OptimizationDiagnosticInfo.h include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h include/llvm/IR/DiagnosticHandler.h

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

vivekvpandya updated this revision to Diff 114645. vivekvpandya added a comment. Update https://reviews.llvm.org/D37196 Files: lib/CodeGen/CodeGenAction.cpp Index: lib/CodeGen/CodeGenAction.cpp === ---

[PATCH] D37196: [Clang] Bug 32352 - Provide a way for OptimizationRemarkEmitter::allowExtraAnalysis to check if (specific) remarks are enabled

vivekvpandya marked an inline comment as done. vivekvpandya added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:882-883 BEConsumer = Result.get(); - + VMContext->setDiagnosticHandler(llvm::make_unique( + CI.getCodeGenOpts(), Result.get())); // Enable

[PATCH] D37703: [AMDGPU] Change addr space of clk_event_t, queue_t and reserve_id_t to global

yaxunl created this revision. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl. https://reviews.llvm.org/D37703 Files: lib/Basic/Targets/AMDGPU.h test/CodeGenOpenCL/opencl_types.cl Index: test/CodeGenOpenCL/opencl_types.cl

[PATCH] D37577: [libclang] add 'clang_getCursorTLSKind'

frutiger updated this revision to Diff 114640. frutiger added a comment. Add test cases for `__declspec(thread)` and static TLS. Clean up formatting to adhere to the project style. https://reviews.llvm.org/D37577 Files: bindings/python/clang/cindex.py

[libcxx] r312932 - mark mersenne_twister_engine<>::seed(result_type __sd) with _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK to placate UBSAN. Fixes PR#34160

Author: marshall Date: Mon Sep 11 11:10:33 2017 New Revision: 312932 URL: http://llvm.org/viewvc/llvm-project?rev=312932=rev Log: mark mersenne_twister_engine<>::seed(result_type __sd) with _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK to placate UBSAN. Fixes PR#34160 Modified:

[PATCH] D37677: [libc++] implement future synchronization using atomic_flag

bcraig added a comment. In https://reviews.llvm.org/D37677#866743, @Quuxplusone wrote: > This current patch just swaps out std::mutex for a std::mutex-alike class > that claims to be faster for uncontested accesses. Definitely safer than my > interpretation. :) If this patch actually helps,

[PATCH] D37101: [clangd] Add support for snippet completions

rwols added a comment. No, I don't have access to the repo, sorry forgot to mention this. https://reviews.llvm.org/D37101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r312580 - Fix memory leak after r312467. The ModuleMap is the owner of the global module object until it's reparented under a real module.

On Tue, Sep 5, 2017 at 2:47 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Sep 5 14:46:22 2017 > New Revision: 312580 > > URL: http://llvm.org/viewvc/llvm-project?rev=312580=rev > Log: > Fix memory leak after r312467. The ModuleMap is the owner

[PATCH] D37677: [libc++] implement future synchronization using atomic_flag

Quuxplusone added a comment. TODO.txt says "future should use for synchronization." I would have interpreted this as meaning that the line unsigned __state_; should become std::atomic __state_; and appropriate loads and stores used so that `__is_ready()` can be checked without having

[PATCH] D37700: Fix recording preamble's conditional stack in skipped PP branches.

ilya-biryukov updated this revision to Diff 114634. ilya-biryukov added a comment. Fixed description of the change. https://reviews.llvm.org/D37700 Files: lib/Lex/PPDirectives.cpp test/Index/preamble-conditionals-inverted-with-error.cpp test/Index/preamble-conditionals-inverted.cpp

[PATCH] D37700: Fix recording preamble's conditional stack in skipped PP branches.

ilya-biryukov created this revision. This fixes PR34547. `Lexer::LexEndOfFile` handles recording of ConditionalStack for preamble and reporting errors about unmatched conditionalal PP directives. However, SkipExcludedConditionalBlock contianed duplicated logic for reporting errors and clearing

[PATCH] D37577: [libclang] add 'clang_getCursorTLSKind'

frutiger added inline comments. Comment at: bindings/python/tests/cindex/test_tls_kind.py:14 +int tls_none; +thread_local tls_dynamic; +""", lang = 'cpp') frutiger wrote: > compnerd wrote: > > Can we add a test case for static TLS as well please? Also, I think

[PATCH] D37448: Fix cast assertion on MS inline assembly with vector spills (PR34021)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I was hoping for a test case that didn't require assertions, but this is enough to land the fix. Repository: rL LLVM https://reviews.llvm.org/D37448

[PATCH] D37577: [libclang] add 'clang_getCursorTLSKind'

frutiger added inline comments. Comment at: bindings/python/tests/cindex/test_tls_kind.py:14 +int tls_none; +thread_local tls_dynamic; +""", lang = 'cpp') compnerd wrote: > Can we add a test case for static TLS as well please? Also, I think that we > should

[PATCH] D37677: [libc++] implement future synchronization using atomic_flag

dennis.luxen added a comment. In https://reviews.llvm.org/D37677#866362, @bcraig wrote: > Is there a benchmark where this demonstrates some performance improvement? I > fear that the switch to condition_variable_any will swamp any performance > gains from the switch to a spin lock. > > Also,

[PATCH] D37694: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (clang)

craig.topper added a comment. Remove the builtins from BuiltinsX86.def https://reviews.llvm.org/D37694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37667: [C++14][Sema] Disallow decltype(auto) deduction for lambdas

Rakete abandoned this revision. Rakete added a comment. Agreed. Closing this. https://reviews.llvm.org/D37667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37562: [X86] Lower _mm[256|512]_[mask[z]]_avg_epu[8|16] intrinsics to native llvm IR

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

craig.topper added a comment. I think when you uploaded the changes to remove it from BuiltinsX86.def you lost your earlier changes to the header files https://reviews.llvm.org/D37668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37376: [libcxx] Fix libc++experimental build on Windows

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: lib/CMakeLists.txt:189 +macro(add_msvcrt_defs_if_needed target) + if(WIN32 AND NOT MINGW) Please use `function` rather than

[libcxx] r312923 - Add include of to , since things in there return strings. Fixes PR#34529.

Author: marshall Date: Mon Sep 11 09:05:42 2017 New Revision: 312923 URL: http://llvm.org/viewvc/llvm-project?rev=312923=rev Log: Add include of to , since things in there return strings. Fixes PR#34529. Added:

[PATCH] D37577: [libclang] add 'clang_getCursorTLSKind'

compnerd added inline comments. Comment at: bindings/python/tests/cindex/test_tls_kind.py:14 +int tls_none; +thread_local tls_dynamic; +""", lang = 'cpp') Can we add a test case for static TLS as well please? Also, I think that we should add a test case for

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

spetrovic updated this revision to Diff 114618. spetrovic added a comment. Indentations fixed. https://reviews.llvm.org/D34878 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/CC1Options.td include/clang/Driver/Options.td lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz added a comment. ping? https://reviews.llvm.org/D32478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33440: clang-format: better handle statement and namespace macros

Typz added a comment. ping? https://reviews.llvm.org/D33440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz added a comment. ping? https://reviews.llvm.org/D33589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37260: [clang-format] Fixed extern C brace wrapping

krasimir added a comment. Yes, I meant that it should at least be controlled by a flag. However, adding flags to clang-format requires careful consideration, we usually would accept options that are necessary for commonly used styles with style guides and with a community willing to support

[PATCH] D37695: [clang-format] Break non-trailing comments, try 2

krasimir updated this revision to Diff 114617. krasimir added a comment. - Add the original test cases https://reviews.llvm.org/D37695 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h

r312918 - clang-format: [JS] wrap and indent `goog.setTestOnly` calls.

Author: mprobst Date: Mon Sep 11 08:22:52 2017 New Revision: 312918 URL: http://llvm.org/viewvc/llvm-project?rev=312918=rev Log: clang-format: [JS] wrap and indent `goog.setTestOnly` calls. Summary: While `goog.setTestOnly` usually appears in the imports section of a file, it is not actually an

[PATCH] D37695: [clang-format] Break non-trailing comments, try 2

krasimir created this revision. Herald added a subscriber: klimek. This patch enables `BreakableToken` to manage the formatting of non-trailing block comments. It is a refinement of https://reviews.llvm.org/D37007. We discovered that the optimizer outsmarts us on cases where breaking the comment

[PATCH] D37694: [X86] [PATCH] [intrinsics] Lowering X86 ABS intrinsics to IR. (clang)

uriel.k created this revision. This patch, together with a matching llvm patch (https://reviews.llvm.org/D37693), implements the lowering of X86 ABS intrinsics to IR. https://reviews.llvm.org/D37694 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx2-builtins.c

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

This revision was automatically updated to reflect the committed changes. Closed by commit rL312917: [PCH] Allow VFS to be used for tests that generate PCH files (authored by cameron314). Changed prior to commit: https://reviews.llvm.org/D37474?vs=114604=114612#toc Repository: rL LLVM

r312917 - [PCH] Allow VFS to be used for tests that generate PCH files

Author: cameron314 Date: Mon Sep 11 08:03:23 2017 New Revision: 312917 URL: http://llvm.org/viewvc/llvm-project?rev=312917=rev Log: [PCH] Allow VFS to be used for tests that generate PCH files When using a virtual file-system (VFS) and a preamble file (PCH) is generated, it is generated on-disk

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

cameron314 added inline comments. Comment at: include/clang/Frontend/PrecompiledPreamble.h:100 /// PreambleBounds used to build the preamble PreambleBounds getBounds() const; ilya-biryukov wrote: > Not introduced by this change, but could you also add a

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

cameron314 updated this revision to Diff 114604. cameron314 added a comment. Final diff, will commit soon. Thanks! https://reviews.llvm.org/D37474 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/ASTUnit.cpp unittests/Frontend/CMakeLists.txt

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib updated this revision to Diff 114589. chrib added a comment. Hello Eli, You were right, using IsUnwindTablesDefault is the correct way to abstract the need for UnwindTables. I missed the relationship between the driver munwind-table and GodeGenOpts.UnwindTables use in Codegen. Here is a

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

jina.nahias updated this revision to Diff 114594. jina.nahias added a comment. delete from include/clang/Basic/BuiltinsX86.def and include/clang/Basic/BuiltinsX86_64.def https://reviews.llvm.org/D37668 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def

[PATCH] D37663: [AST] Make RecursiveASTVisitor visit CXXOperatorCallExpr in source order

johannes added inline comments. Comment at: include/clang/AST/RecursiveASTVisitor.h:334 +case OO_Arrow: +case OO_Call: +case OO_Subscript: klimek wrote: > Why do we need to swap for calls? The idea is that the opening parenthesis/bracket comes after

[PATCH] D37572: [clang-tidy] SuspiciousEnumUsageCheck bugfix

alexfh accepted this revision. alexfh added a comment. Still LG. Fine to commit. Thanks for the fix! If you find time to construct the test case that triggers both affected code paths (my test seems to only inspect one of them, IIUC), it would be nice to do as a follow up.

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

spetrovic added a comment. Thanks for the review! I will check indentations with clang format. https://reviews.llvm.org/D34878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

On Fri, Sep 8, 2017 at 9:33 PM, Roman Lebedev via Phabricator via cfe-commits wrote: > lebedev.ri added a comment. > > In https://reviews.llvm.org/D37629#865068, @lebedev.ri wrote: > >> And finish reducing the code by for-range-loop`ing over array + use >>

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

kristof.beyls accepted this revision. kristof.beyls added a comment. This revision is now accepted and ready to land. Thanks Strahinja! I thought that some indentations looked a bit strange, so I'd just still check that clang-format formats your changes the same way. Otherwise LGTM!

[PATCH] D37677: [libc++] implement future synchronization using atomic_flag

bcraig added a comment. Is there a benchmark where this demonstrates some performance improvement? I fear that the switch to condition_variable_any will swamp any performance gains from the switch to a spin lock. Also, the spin lock is being held during allocating operations (the exception

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

spetrovic updated this revision to Diff 114582. https://reviews.llvm.org/D34878 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/CC1Options.td include/clang/Driver/Options.td lib/Driver/ToolChains/Arch/ARM.cpp lib/Driver/ToolChains/Arch/ARM.h

[PATCH] D37662: [AST] Make RecursiveASTVisitor visit TemplateDecls in source order

This revision was automatically updated to reflect the committed changes. Closed by commit rL312911: [AST] Make RecursiveASTVisitor visit TemplateDecls in source order (authored by krobelus). Repository: rL LLVM https://reviews.llvm.org/D37662 Files:

[clang-tools-extra] r312912 - [clang-tidy] FunctionSizeCheck: wrap FunctionASTVisitor into anon namespace, NFC

Author: lebedevri Date: Mon Sep 11 06:12:31 2017 New Revision: 312912 URL: http://llvm.org/viewvc/llvm-project?rev=312912=rev Log: [clang-tidy] FunctionSizeCheck: wrap FunctionASTVisitor into anon namespace, NFC This check is relatively simple, and is often being used as an example. I'm aware of

r312911 - [AST] Make RecursiveASTVisitor visit TemplateDecls in source order

Author: krobelus Date: Mon Sep 11 06:12:30 2017 New Revision: 312911 URL: http://llvm.org/viewvc/llvm-project?rev=312911=rev Log: [AST] Make RecursiveASTVisitor visit TemplateDecls in source order Summary: This causes template arguments to be traversed before the templated declaration, which is

[PATCH] D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action

ioeric added a comment. Feel free to land the patch now if comments are addressed. Repository: rL LLVM https://reviews.llvm.org/D36574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36574: [refactor] add clang-refactor tool with initial testing support and local-rename action

arphaman added a comment. @klimek I've added a patch that simplifies the interface and the template code - https://reviews.llvm.org/D37681. Hopefully you'll find that the code there is cleaner. Repository: rL LLVM https://reviews.llvm.org/D36574

[PATCH] D37681: [refactor] Simplify the interface and remove some template magic

arphaman created this revision. Herald added a subscriber: mgorny. This patch tries to simplify the interface for the refactoring action rules and refactoring requirements. It merges the selection constraints and selection requirements into one class. The refactoring actions rules must now be

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

spetrovic added inline comments. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:149-150 +else + D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args); + } + return ReadTPMode::Soft; kristof.beyls wrote: > a return ReadTPMode::Invalid is missing

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

kristof.beyls added inline comments. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:137 + const Driver = TC.getDriver(); + arm::ReadTPMode ThreadPointer = ReadTPMode::Invalid; + if (Arg *A = With the new version of the code, there's no need to have a

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

spetrovic added a comment. Comments addressed. https://reviews.llvm.org/D34878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

spetrovic updated this revision to Diff 114573. https://reviews.llvm.org/D34878 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/CC1Options.td include/clang/Driver/Options.td lib/Driver/ToolChains/Arch/ARM.cpp lib/Driver/ToolChains/Arch/ARM.h

[PATCH] D37448: Fix cast assertion on MS inline assembly with vector spills (PR34021)

RKSimon updated this revision to Diff 114569. RKSimon added a comment. Added checks to test case Repository: rL LLVM https://reviews.llvm.org/D37448 Files: lib/CodeGen/CGStmt.cpp test/CodeGen/pr34021.c Index: test/CodeGen/pr34021.c

[PATCH] D37572: [clang-tidy] SuspiciousEnumUsageCheck bugfix

szepet updated this revision to Diff 114567. szepet marked 3 inline comments as done. szepet added a comment. Updates based on the comments. Thanks for the reduced test case and the fast review! Not sure if in these cases am I allowed to commit (since it was accepted) or since it was accepted

Re: r312633 - [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor

It's a good idea to merge the two. I'll work on moving the ObjC traversal change when I get the time. Thanks for the quick patches Johannes! On 9 September 2017 at 12:03, Johannes Altmanninger wrote: > Richard Smith writes: > > > I am extremely

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Overall the code looks good, thanks for the clean-ups. Only a few minor style comments and a major one about returning value when no file is matching. Please add tests

[PATCH] D37260: [clang-format] Fixed extern C brace wrapping

PriMee added a comment. ping https://reviews.llvm.org/D37260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >