Buildbot numbers for the week of 09/17/2017 - 09/23/2017

2017-09-29 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the last week of 09/17/2017 - 09/23/2017. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 09/10/2017 - 09/16/2017

2017-09-29 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 09/10/2017 - 09/16/2017. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Buildbot numbers for the week of 09/03/2017 - 09/09/2017

2017-09-29 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 09/03/2017 - 09/09/2017. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D38408: [CodeGen] Have a special function to get TBAA info for may-alias accesses

2017-09-29 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D38408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38404: [CodeGen] Do not refer to complete TBAA info where we actually deal with just TBAA access types

2017-09-29 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D38404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r314581 - [ODRHash] Add base classes to hashing CXXRecordDecl.

2017-09-29 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Fri Sep 29 19:19:17 2017 New Revision: 314581 URL: http://llvm.org/viewvc/llvm-project?rev=314581=rev Log: [ODRHash] Add base classes to hashing CXXRecordDecl. Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list=<arg1, arg2, ...> to match gcc options.

2017-09-29 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. Please also add a C++ test to check the mangling-related features. Comment at: lib/CodeGen/CodeGenFunction.cpp:419 +// Assume that __cxa_demangle is provided by libcxxabi (except for Windows). +extern "C" char *__cxa_demangle(const char *mangled_name,

r314580 - [Analyzer] Add dummy implementation to call_once to avoid linkage warnings in tests.

2017-09-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 29 18:15:35 2017 New Revision: 314580 URL: http://llvm.org/viewvc/llvm-project?rev=314580=rev Log: [Analyzer] Add dummy implementation to call_once to avoid linkage warnings in tests. Modified: cfe/trunk/test/Analysis/call_once.cpp Modified:

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

2017-09-29 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. A couple of remaining pieces that I think are missing: - Tests for instantiation of templates containing one of these lambdas. I would expect you'll find you need to change Sema/TreeTransform.h to make that work. - Updates to Itanium mangling (AST/ItaniumMangle.cpp) for

[PATCH] D37478: [analyzer] Implement pointer arithmetic on constants

2017-09-29 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin requested changes to this revision. dcoughlin added a subscriber: zaks.anna. dcoughlin added a comment. This revision now requires changes to proceed. Rafael: Thanks for the patch! @NoQ, @zaks.anna, and I spoke about this off-line yesterday. While this patch improves the modeling of

r314573 - [Analyzer] Document a gotcha: for C++ -analyze-function requires parameters in function name

2017-09-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 29 17:07:22 2017 New Revision: 314573 URL: http://llvm.org/viewvc/llvm-project?rev=314573=rev Log: [Analyzer] Document a gotcha: for C++ -analyze-function requires parameters in function name Differential Revision: https://reviews.llvm.org/D37596

r314572 - [Analyzer] Add nullability to the list of tested checkers in SATestBuild

2017-09-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 29 17:05:24 2017 New Revision: 314572 URL: http://llvm.org/viewvc/llvm-project?rev=314572=rev Log: [Analyzer] Add nullability to the list of tested checkers in SATestBuild Differential Revision: https://reviews.llvm.org/D38162 Modified:

r314571 - [Analyzer] Synthesize function body for std::call_once

2017-09-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Sep 29 17:03:22 2017 New Revision: 314571 URL: http://llvm.org/viewvc/llvm-project?rev=314571=rev Log: [Analyzer] Synthesize function body for std::call_once Differential Revision: https://reviews.llvm.org/D37840 Added:

r314570 - Add a "vexing parse" warning for ambiguity between a variable declaration and a

2017-09-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Sep 29 16:57:25 2017 New Revision: 314570 URL: http://llvm.org/viewvc/llvm-project?rev=314570=rev Log: Add a "vexing parse" warning for ambiguity between a variable declaration and a function-style cast. This fires for cases such as T(x); ... where 'x' was previously

[PATCH] D35715: Preserve typedef names in debug info for template type parameters

2017-09-29 Thread Paul Robinson via Phabricator via cfe-commits
probinson abandoned this revision. probinson added a comment. Abandoning. This change is irrelevant to the SCE debugger, and while I believe it could be made more complete and better reflect the original source (which is what the DWARF spec says names should be), I do not have time to pursue

[PATCH] D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer

2017-09-29 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. ping https://reviews.llvm.org/D36918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

2017-09-29 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. ping. Any comments on this patch or alternate approaches? https://reviews.llvm.org/D36915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38425: [clangd] Document highlights for clangd

2017-09-29 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Thanks for the patch, I'll take a closer look a bit later. But just wanted to post one very important comment right away. Comment at: clangd/ClangdUnit.h:268 +std::vector findDocumentHighlights(ParsedAST , Position Pos, +

[PATCH] D37970: [clangd] Added a command-line arg to mirror clangd input into a file.

2017-09-29 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Friendly ping. https://reviews.llvm.org/D37970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38414: [clangd] simplify ClangdLSPServer by private-inheriting callback interfaces. NFC

2017-09-29 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.h:41 private: - class LSPProtocolCallbacks; - class LSPDiagnosticsConsumer : public DiagnosticsConsumer { - public: -LSPDiagnosticsConsumer(ClangdLSPServer ); - -virtual void -

[PATCH] D38414: [clangd] simplify ClangdLSPServer by private-inheriting callback interfaces. NFC

2017-09-29 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. PS I actually remember arguing to keep those classes separate in the original review :-) https://reviews.llvm.org/D38414

[PATCH] D38430: Enable -pie and --enable-new-dtags by default on Android.

2017-09-29 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis created this revision. Also enable -no-pie on Gnu toolchain (previously available on Darwin only). Non-PIE executables won't even start on recent Android, and DT_RPATH is ignored by the loader. https://reviews.llvm.org/D38430 Files: clang/lib/Driver/SanitizerArgs.cpp

r314558 - [PS4] Tidy up some debug-tuning v. triple decision-making.

2017-09-29 Thread Paul Robinson via cfe-commits
Author: probinson Date: Fri Sep 29 14:25:07 2017 New Revision: 314558 URL: http://llvm.org/viewvc/llvm-project?rev=314558=rev Log: [PS4] Tidy up some debug-tuning v. triple decision-making. Modified: cfe/trunk/include/clang/Driver/CC1Options.td cfe/trunk/lib/Driver/ToolChains/Clang.cpp

r314557 - [Sema] Correct IUnknown to support Unknwnbase.h Header.

2017-09-29 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Fri Sep 29 14:06:00 2017 New Revision: 314557 URL: http://llvm.org/viewvc/llvm-project?rev=314557=rev Log: [Sema] Correct IUnknown to support Unknwnbase.h Header. Apparently, the MSVC SDK has a strange implementation that causes a number of implicit functions as well as

[PATCH] D38303: [Sema] Correct IUnknown to support Unknwnbase.h Header.

2017-09-29 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314557: [Sema] Correct IUnknown to support Unknwnbase.h Header. (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D38303?vs=116876=117218#toc Repository: rL LLVM

[PATCH] D38425: [clangd] Document highlights for clangd

2017-09-29 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. Just a few quick comments. Comment at: clangd/ClangdServer.cpp:295 + assert(FileContents.Draft && + "findDefinitions is called for non-added document"); + findDocumentHighlights? Comment at:

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

2017-09-29 Thread William Enright via Phabricator via cfe-commits
Nebiroth updated this revision to Diff 117217. Nebiroth added a comment. Fixed missed comments and suggstions. https://reviews.llvm.org/D37150 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/GlobalCompilationDatabase.cpp clangd/GlobalCompilationDatabase.h

[PATCH] D38425: [clangd] Document highlights for clangd

2017-09-29 Thread William Enright via Phabricator via cfe-commits
Nebiroth created this revision. Implementation of Document Highlights Request as described in LSP. https://reviews.llvm.org/D38425 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/Protocol.cpp

Re: Fix for the issue 12176

2017-09-29 Thread Oscar Forner Martinez via cfe-commits
On 28/09/17 21:28, Jonathan Roelofs wrote: +silvas On 9/28/17 2:19 PM, Oscar Forner Martinez via cfe-commits wrote: Hi, Please find attached a diff to fix the issue 12176. Link for the lazy: llvm.org/PR12176 Thanks ;) Let me know if there is anything any improvements you can think

[libclc] r314546 - Add script to check for unresolved function calls

2017-09-29 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Sep 29 12:06:48 2017 New Revision: 314546 URL: http://llvm.org/viewvc/llvm-project?rev=314546=rev Log: Add script to check for unresolved function calls v2: add shell shebang improve error checks and reporting v3: fix typo Signed-off-by: Jan Vesely

[libclc] r314543 - Restore support for llvm-3.9

2017-09-29 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Sep 29 12:06:41 2017 New Revision: 314543 URL: http://llvm.org/viewvc/llvm-project?rev=314543=rev Log: Restore support for llvm-3.9 Signed-off-by: Jan Vesely Acked-by: Aaron Watry Added:

[libclc] r314544 - travis: add build using llvm-3.9

2017-09-29 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Sep 29 12:06:45 2017 New Revision: 314544 URL: http://llvm.org/viewvc/llvm-project?rev=314544=rev Log: travis: add build using llvm-3.9 Signed-off-by: Jan Vesely Acked-by: Aaron Watry Modified: libclc/trunk/.travis.yml

[libclc] r314545 - geometric: geometric functions are only supported for vector lengths <=4

2017-09-29 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Sep 29 12:06:47 2017 New Revision: 314545 URL: http://llvm.org/viewvc/llvm-project?rev=314545=rev Log: geometric: geometric functions are only supported for vector lengths <=4 Signed-off-by: Jan Vesely Reviewed-by: Aaron Watry

[libclc] r314548 - Fix amdgcn-amdhsa on llvm-3.9

2017-09-29 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Sep 29 12:06:52 2017 New Revision: 314548 URL: http://llvm.org/viewvc/llvm-project?rev=314548=rev Log: Fix amdgcn-amdhsa on llvm-3.9 Signed-off-by: Jan Vesely Acked-by: Aaron Watry Added:

[libclc] r314547 - travis: Check built libraries on llvm-3.9

2017-09-29 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Fri Sep 29 12:06:50 2017 New Revision: 314547 URL: http://llvm.org/viewvc/llvm-project?rev=314547=rev Log: travis: Check built libraries on llvm-3.9 Signed-off-by: Jan Vesely Acked-by: Aaron Watry Modified:

[PATCH] D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces

2017-09-29 Thread Alexandru Octavian Buțiu via Phabricator via cfe-commits
predator5047 updated this revision to Diff 117193. predator5047 marked 12 inline comments as done. predator5047 added a comment. Address review comments: - Don't use auto if the type is not spelled out in initialization. - Better names for variables. - Elide braces. - Format changes.

[PATCH] D37299: [Modules] Add ability to specify module name to module file mapping in a file

2017-09-29 Thread Boris Kolpackov via Phabricator via cfe-commits
boris added a comment. Ping. https://reviews.llvm.org/D37299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37903: Fix assume-filename handling in clang-format.el

2017-09-29 Thread Philipp via Phabricator via cfe-commits
phst added inline comments. Comment at: tools/clang-format/clang-format.el:122 ;;;###autoload -(defun clang-format-region (start end style assume-file-name) - "Use clang-format to format the code between START and END according to STYLE -using ASSUME-FILE-NAME to locate a

[PATCH] D38303: [Sema] Correct IUnknown to support Unknwnbase.h Header.

2017-09-29 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/AST/DeclCXX.cpp:1473 +static bool IsDeclContextInNamespace(const DeclContext *DC) { + while (!DC->isTranslationUnit()) { Lower case

[PATCH] D38414: [clangd] simplify ClangdLSPServer by private-inheriting callback interfaces. NFC

2017-09-29 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. There doesn't seem to be any real separation between the current three objects. Feel free to reject this if you find the current style valuable, though. (Mostly I'm just looking around for cleanups to help me understand the code).

[clang-tools-extra] r314532 - Small clangd cleanups, NFC

2017-09-29 Thread Sam McCall via cfe-commits
Author: sammccall Date: Fri Sep 29 09:41:23 2017 New Revision: 314532 URL: http://llvm.org/viewvc/llvm-project?rev=314532=rev Log: Small clangd cleanups, NFC - remove old ASTUnit includes - fix typo (regiterCallbackHandlers) Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp

[PATCH] D38408: [CodeGen] Have a special function to get TBAA info for may-alias accesses

2017-09-29 Thread Ivan A. Kosarev via Phabricator via cfe-commits
kosarev created this revision. kosarev added a project: clang. This is part of https://reviews.llvm.org/D37826 reworked to be a separate patch to simplify review. Repository: rL LLVM https://reviews.llvm.org/D38408 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenModule.cpp

[PATCH] D38277: [compiler-rt][CMake] Fix configuration on PowerPC with sanitizers

2017-09-29 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: compiler-rt/trunk/cmake/base-config-ix.cmake:154 + cmake_push_check_state() + string(REPLACE "-nodefaultlibs" "" CMAKE_REQUIRED_FLAGS ${OLD_CMAKE_REQUIRED_FLAGS}) TEST_BIG_ENDIAN(HOST_IS_BIG_ENDIAN)

r314529 - fixup, post rL314493

2017-09-29 Thread Coby Tayree via cfe-commits
Author: coby Date: Fri Sep 29 09:04:16 2017 New Revision: 314529 URL: http://llvm.org/viewvc/llvm-project?rev=314529=rev Log: fixup, post rL314493 'InlineAsmIdentifierInfo' is now a struct - notify Sema.h it isn't a class anymore Modified: cfe/trunk/include/clang/Sema/Sema.h Modified:

[PATCH] D38277: [compiler-rt][CMake] Fix configuration on PowerPC with sanitizers

2017-09-29 Thread Aleksey Shlyapnikov via Phabricator via cfe-commits
alekseyshl added inline comments. Comment at: compiler-rt/trunk/cmake/base-config-ix.cmake:154 + cmake_push_check_state() + string(REPLACE "-nodefaultlibs" "" CMAKE_REQUIRED_FLAGS ${OLD_CMAKE_REQUIRED_FLAGS}) TEST_BIG_ENDIAN(HOST_IS_BIG_ENDIAN)

[PATCH] D38277: [compiler-rt][CMake] Fix configuration on PowerPC with sanitizers

2017-09-29 Thread Aleksey Shlyapnikov via Phabricator via cfe-commits
alekseyshl added a comment. http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/4004 is broken by this change Repository: rL LLVM https://reviews.llvm.org/D38277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r314526 - [test] Disable leak checking on a clang crash test on Darwin

2017-09-29 Thread Francis Ricci via cfe-commits
Author: fjricci Date: Fri Sep 29 08:46:27 2017 New Revision: 314526 URL: http://llvm.org/viewvc/llvm-project?rev=314526=rev Log: [test] Disable leak checking on a clang crash test on Darwin Suspected failure due to LSan's atexit and exit interception behavior. Reviewers: kcc, kubamracek,

r314524 - Fix Modules/{builtin-import.mm, umbrella-header-include-builtin.mm} to be able to handle non-Darwin targets

2017-09-29 Thread Filipe Cabecinhas via cfe-commits
Author: filcab Date: Fri Sep 29 08:45:34 2017 New Revision: 314524 URL: http://llvm.org/viewvc/llvm-project?rev=314524=rev Log: Fix Modules/{builtin-import.mm,umbrella-header-include-builtin.mm} to be able to handle non-Darwin targets Summary: Also makes them pass on Darwin, if the default

[PATCH] D38364: Fix Modules/builtin-import.mm to be able to handle non-Darwin targets

2017-09-29 Thread Filipe Cabecinhas via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314524: Fix Modules/{builtin-import.mm,umbrella-header-include-builtin.mm} to be able… (authored by filcab). Repository: rL LLVM https://reviews.llvm.org/D38364 Files:

[PATCH] D38404: [CodeGen] Do not refer to complete TBAA info where we actually deal with just TBAA access types

2017-09-29 Thread Ivan A. Kosarev via Phabricator via cfe-commits
kosarev created this revision. kosarev added a project: clang. This patch fixes misleading names of entities related to getting, setting and generation of TBAA access type descriptors. This is effectively an attempt to provide a review for https://reviews.llvm.org/D37826 by breaking it into

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

2017-09-29 Thread Christian Bruel via Phabricator via cfe-commits
chrib updated this revision to Diff 117139. chrib added a comment. Hello, I realized that testing CCCisCXX for IsUnwindTablesDefault was not really good and useless here, because we cannot treat C as C++ mode. In fact only the file type matters, as seen in the tests. So I'd like to amend my

[PATCH] D38402: [clang-refactor] Apply source replacements

2017-09-29 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. This patch actually brings clang-refactor to a usable state as it can now apply the refactoring changes to the source files. The `-selection` option is now also fully supported. Repository: rL LLVM https://reviews.llvm.org/D38402 Files:

[PATCH] D38277: [compiler-rt][CMake] Fix configuration on PowerPC with sanitizers

2017-09-29 Thread Jonas Hahnfeld via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314512: [CMake] Fix configuration on PowerPC with sanitizers (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D38277?vs=116977=117132#toc Repository: rL LLVM

[PATCH] D37976: [docs][refactor] add refactoring engine design documentation

2017-09-29 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. arphaman marked 2 inline comments as done. Closed by commit rL314509: [docs][refactor] Add refactoring engine design documentation (authored by arphaman). Changed prior to commit:

[PATCH] D37856: [refactor] add support for refactoring options

2017-09-29 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 117124. arphaman marked 10 inline comments as done. arphaman added a comment. Address review comments Repository: rL LLVM https://reviews.llvm.org/D37856 Files: include/clang/Tooling/Refactoring/RefactoringActionRule.h

[PATCH] D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

2017-09-29 Thread coby via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314494: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory /… (authored by coby). Changed prior to commit: https://reviews.llvm.org/D37413?vs=115564=117095#toc Repository: rL

r314494 - [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

2017-09-29 Thread Coby Tayree via cfe-commits
Author: coby Date: Fri Sep 29 00:02:49 2017 New Revision: 314494 URL: http://llvm.org/viewvc/llvm-project?rev=314494=rev Log: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions Allow the proper recognition of Enum values and global variables

[PATCH] D38381: [libunwind] Skip building x86 parts of UnwindRegisters*.S when targeting SjLj

2017-09-29 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314492: Skip building x86 parts of UnwindRegisters*.S when targeting SjLj (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D38381?vs=117047=117092#toc Repository: rL LLVM

[libunwind] r314492 - Skip building x86 parts of UnwindRegisters*.S when targeting SjLj

2017-09-29 Thread Martin Storsjo via cfe-commits
Author: mstorsjo Date: Thu Sep 28 23:09:09 2017 New Revision: 314492 URL: http://llvm.org/viewvc/llvm-project?rev=314492=rev Log: Skip building x86 parts of UnwindRegisters*.S when targeting SjLj This extends SVN r314197 from the arm parts to the whole file. Differential Revision:

[PATCH] D38380: [libunwind] Add CMake support for building for MinGW

2017-09-29 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: cmake/config-ix.cmake:38 +else () + set(MINGW_RUNTIME gcc_s gcc) +endif() compnerd wrote: > This seems really weird. `gcc_s` and `gcc` are the same library, the former > is the shared version of the