[PATCH] D35541: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER)

This revision was automatically updated to reflect the committed changes. Closed by commit rL316061: [CMake] Use #cmakedefine01 for CLANG_ENABLE_… (authored by chapuni). Repository: rL LLVM https://reviews.llvm.org/D35541 Files: cfe/trunk/include/clang/Config/config.h.cmake

r316061 - [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER)

Author: chapuni Date: Tue Oct 17 22:21:17 2017 New Revision: 316061 URL: http://llvm.org/viewvc/llvm-project?rev=316061=rev Log: [CMake] Use #cmakedefine01 for CLANG_ENABLE_(ARCMT|OBJC_REWRITER|STATIC_ANALYZER) It'd be better that they are #cmakedefine01 rather than #cmakedefine. (#if FOO

[PATCH] D39037: check-libcxx: Introduce config.test_retry_attempts for std/thread.

chapuni created this revision. I thought we could mark entire tests in std/thread as flaky. Repository: rL LLVM https://reviews.llvm.org/D39037 Files: libcxx/trunk/test/std/thread/lit.local.cfg libcxx/trunk/utils/libcxx/test/format.py Index: libcxx/trunk/utils/libcxx/test/format.py

[PATCH] D37905: [libclang, bindings]: add spelling location

compnerd accepted this revision. compnerd added a comment. @frutiger you have commit rights now right? https://reviews.llvm.org/D37905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38354: Fix test by using -target instead of cc1 arguments (c-index-test goes through the driver)

akyrtzi added a comment. FYI, I had added -target in this test in r296263 but it was still failing for some reason in some bots, that's why I then switched to triple via r296265. I'm not sure if it's going work now or not for all bots, but it does, that is definitely better.

[PATCH] D39035: Unnamed bitfields don't block constant evaluation of constexpr constructors

jordan_rose created this revision. jordan_rose added a project: clang. C++14 [dcl.constexpr]p4 states that in the body of a constexpr constructor, > every non-variant non-static data member and base class sub-object shall be > initialized However, [class.bit]p2 notes that > Unnamed bit-fields

[PATCH] D39033: [libcxx] [test] Tolerate [[nodiscard]] on STL functions in libcxx tests

BillyONeal created this revision. I applied [[nodiscard]] to lots of things in MSVC++'s STL, which trips up some tests in libcxx. This change adds (void) casts or assertions as necessary to make [[nodiscard]] happy. Repository: rL LLVM https://reviews.llvm.org/D39033 Files:

r316056 - Provide a flag group to turn on/off all "binary literals" extension warnings.

Author: rsmith Date: Tue Oct 17 19:19:24 2017 New Revision: 316056 URL: http://llvm.org/viewvc/llvm-project?rev=316056=rev Log: Provide a flag group to turn on/off all "binary literals" extension warnings. Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td

Re: r315856 - Add -f[no-]double-square-bracket-attributes as new driver options to control use of [[]] attributes in all language modes. This is the initial implementation of WG14 N2165, which is a pr

Hello Aaron, This commit broke one our builders: http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/2272 . . . FAILED: /usr/local/gcc-7.1/bin/g++-7.1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS

r316055 - [modules] When finding the owning module of an instantiated context in template

Author: rsmith Date: Tue Oct 17 18:41:38 2017 New Revision: 316055 URL: http://llvm.org/viewvc/llvm-project?rev=316055=rev Log: [modules] When finding the owning module of an instantiated context in template instantiation, follow lexical parents not semantic ones: we want to find the module where

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

This revision was automatically updated to reflect the committed changes. Closed by commit rL316053: [CMake] Build Fuchsia toolchain as -O3 (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D39017?vs=119372=119417#toc Repository: rL LLVM

r316053 - [CMake] Build Fuchsia toolchain as -O3

Author: phosek Date: Tue Oct 17 18:27:54 2017 New Revision: 316053 URL: http://llvm.org/viewvc/llvm-project?rev=316053=rev Log: [CMake] Build Fuchsia toolchain as -O3 Differential Revision: https://reviews.llvm.org/D39017 Modified: cfe/trunk/cmake/caches/Fuchsia-stage2.cmake Modified:

[PATCH] D39031: [Analyzer] Correctly handle parameters passed by reference when bodyfarming std::call_once

george.karpenkov created this revision. Herald added subscribers: szepet, kristof.beyls, xazax.hun, javed.absar, aemerson. Also explicitly do not support functors for now, since that entails figuring out which call operator corresponds to the passed parameters. Resolution: we really should not

[PATCH] D39027: [docs][refactor] Add a new tutorial that talks about how one can implement refactoring actions

arphaman created this revision. This patch adds a new tutorial to Clang's talks that walks through an example of a refactoring action and how it can be implemented in Clang. Repository: rL LLVM https://reviews.llvm.org/D39027 Files: docs/RefactoringActionTutorial.rst

Re: r313386 - [Sema] Error out early for tags defined inside an enumeration.

> On Oct 11, 2017, at 16:02, Richard Smith wrote: > > On 22 September 2017 at 18:00, Volodymyr Sapsai via cfe-commits > > wrote: > > >> On Sep 21, 2017, at 15:17, Richard Smith >

[PATCH] D39024: [clang-format] Sort whole block of using declarations while partially formatting

krasimir created this revision. Herald added a subscriber: klimek. This patch enables sorting the full block of using declarations when some line is affected. https://reviews.llvm.org/D39024 Files: lib/Format/UsingDeclarationsSorter.cpp unittests/Format/UsingDeclarationsSorterTest.cpp

r316046 - Basic: fix __{,U}INTPTR_TYPE__ on ARM

Author: compnerd Date: Tue Oct 17 17:00:50 2017 New Revision: 316046 URL: http://llvm.org/viewvc/llvm-project?rev=316046=rev Log: Basic: fix __{,U}INTPTR_TYPE__ on ARM Darwin and OpenBSD are the only platforms which use `long int` for `__INTPTR_TYPE__`. The other platforms use `int` in 32-bit,

r316043 - Resubmit "[lit] Raise the logic for enabling clang & lld substitutions to llvm."

Author: zturner Date: Tue Oct 17 16:43:36 2017 New Revision: 316043 URL: http://llvm.org/viewvc/llvm-project?rev=316043=rev Log: Resubmit "[lit] Raise the logic for enabling clang & lld substitutions to llvm." The substitution for %debuginfo_tests had been inadvertently removed. This adds it

r316042 - Basic: fix `__INTPTR_TYPE__` for Windows ARM

Author: compnerd Date: Tue Oct 17 15:49:53 2017 New Revision: 316042 URL: http://llvm.org/viewvc/llvm-project?rev=316042=rev Log: Basic: fix `__INTPTR_TYPE__` for Windows ARM The `IntPtrType` for Windows ARM should be `int` as per MSVC. Adjust the type accordingly. Modified:

[PATCH] D39015: [Analyzer] Always use non-reference types when creating expressions in BodyFarm, removes std::call_once crash

This revision was automatically updated to reflect the committed changes. Closed by commit rL316041: [Analyzer] Always use non-reference types when creating expressions in BodyFarm. (authored by george.karpenkov). Changed prior to commit: https://reviews.llvm.org/D39015?vs=119360=119392#toc

r316041 - [Analyzer] Always use non-reference types when creating expressions in BodyFarm.

Author: george.karpenkov Date: Tue Oct 17 15:28:18 2017 New Revision: 316041 URL: http://llvm.org/viewvc/llvm-project?rev=316041=rev Log: [Analyzer] Always use non-reference types when creating expressions in BodyFarm. Remove an option to use a reference type (on by default!) since a

[PATCH] D39015: [Analyzer] Always use non-reference types when creating expressions in BodyFarm, removes std::call_once crash

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me. This comment is unrelated to this particular patch, but since I know you're doing other work in the area I think it would also be good to have test cases for the two

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

klimek added a comment. Whee, thanks for driving this, much appreciated :D Comment at: include/clang/FrontendTool/Utils.h:25 + +std::unique_ptr CreateFrontendAction(CompilerInstance ); Please add a comment now that this is exported.

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

ruiu added a comment. Yes, specifically, lld does string tail merging (instead of regular string merging) when -O2 is given, so it would produce slightly smaller outputs. Repository: rL LLVM https://reviews.llvm.org/D39017 ___ cfe-commits

[PATCH] D39005: [OpenMP] Clean up variable and function names for NVPTX backend

gtbercea added a comment. Hi Artem, Justin, I see that this patch is the same as the patch Arpith wanted to post a while back i.e. https://reviews.llvm.org/D17738. Was there a consensus regarding what the right thing to do is in this case? I'd be interested to get the ball rolling in regard

r316032 - Fix PR34981, a crash-on-invalid merging dllimport to an invalid redecl.

Author: nico Date: Tue Oct 17 14:14:02 2017 New Revision: 316032 URL: http://llvm.org/viewvc/llvm-project?rev=316032=rev Log: Fix PR34981, a crash-on-invalid merging dllimport to an invalid redecl. This is basically like r288207, just the other way round. Modified:

[PATCH] D39013: [CFG] Relax Wexceptions warning on rethrow

This revision was automatically updated to reflect the committed changes. Closed by commit rL316030: [CFG] Relax Wexceptions warning on rethrow (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D39013?vs=119383=119386#toc Repository: rL LLVM

r316030 - [CFG] Relax Wexceptions warning on rethrow

Author: erichkeane Date: Tue Oct 17 13:57:24 2017 New Revision: 316030 URL: http://llvm.org/viewvc/llvm-project?rev=316030=rev Log: [CFG] Relax Wexceptions warning on rethrow As reported here: https://bugs.llvm.org/show_bug.cgi?id=34973 "catch(...)" should catch EVERYTHING, even a rethrow.

[PATCH] D39013: [CFG] Relax Wexceptions warning on rethrow

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for the fix! https://reviews.llvm.org/D39013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

thakis added inline comments. Comment at: cfe/trunk/lib/Sema/SemaDecl.cpp:5650 + NewImportAttr->getRange(), S.Context, + NewImportAttr->getSpellingListIndex())); +} else { NewImportAttr can be nullptr here, at least for invalid code. This

r316028 - This test case was missing -fsyntax-only, so I've added it. NFC to the actual test contents, just how the test is executed.

Author: aaronballman Date: Tue Oct 17 13:49:30 2017 New Revision: 316028 URL: http://llvm.org/viewvc/llvm-project?rev=316028=rev Log: This test case was missing -fsyntax-only, so I've added it. NFC to the actual test contents, just how the test is executed. Modified:

[PATCH] D39013: [CFG] Relax Wexceptions warning on rethrow

erichkeane updated this revision to Diff 119383. erichkeane edited the summary of this revision. erichkeane added a comment. Changes as requested by @aaron.ballman https://reviews.llvm.org/D39013 Files: lib/Sema/AnalysisBasedWarnings.cpp test/SemaCXX/warn-throw-out-noexcept-func.cpp

Re: r316026 - Enable support for the [[nodiscard]] attribute from WG14 N2050 when enabling double square bracket attributes in C code.

I said WG14 N2050 when I meant N2051. My fat fingers and I apologize for the confusion with the commit log. ~Aaron On Tue, Oct 17, 2017 at 4:33 PM, Aaron Ballman via cfe-commits wrote: > Author: aaronballman > Date: Tue Oct 17 13:33:35 2017 > New Revision: 316026 > >

r316026 - Enable support for the [[nodiscard]] attribute from WG14 N2050 when enabling double square bracket attributes in C code.

Author: aaronballman Date: Tue Oct 17 13:33:35 2017 New Revision: 316026 URL: http://llvm.org/viewvc/llvm-project?rev=316026=rev Log: Enable support for the [[nodiscard]] attribute from WG14 N2050 when enabling double square bracket attributes in C code. Added:

[PATCH] D39013: [CFG] Relax Wexceptions warning on rethrow

erichkeane added a comment. > Wouldn't a catch-all handler suppress the warning in that case? e.g., Yep, you're right of course. I'll revert to my first patch and update this. I'd surmised that false-positives were worse than false-negatives, but since there is a trivial workaround, I'm ok

[PATCH] D39013: [CFG] Relax Wexceptions warning on rethrow

aaron.ballman added a comment. In https://reviews.llvm.org/D39013#900046, @erichkeane wrote: > I've convinced myself that a re-throw with a catch around it should not be > diagnosed, otherwise there is no way to suppress the warning in this case. > It ends up being a false-positive in many

[PATCH] D39013: [CFG] Relax Wexceptions warning on rethrow

erichkeane updated this revision to Diff 119379. erichkeane edited the summary of this revision. erichkeane added a comment. I've convinced myself that a re-throw with a catch around it should not be diagnosed, otherwise there is no way to suppress the warning in this case. It ends up being a

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

sabel83 updated this revision to Diff 119377. sabel83 added reviewers: cfe-commits, klimek, mclow.lists, martong, xazax.hun. https://reviews.llvm.org/D5767 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/FrontendActions.h include/clang/Frontend/FrontendOptions.h

[PATCH] D38126: Make TBAA information to be part of LValueBaseInfo

kosarev updated this revision to Diff 119373. kosarev edited the summary of this revision. kosarev added a comment. Rebased on top of https://reviews.llvm.org/D39008 and ready for review. https://reviews.llvm.org/D38126 Files: CodeGen/CGAtomic.cpp CodeGen/CGClass.cpp CodeGen/CGExpr.cpp

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Since we use lld, -Wl,-O2 also helps make the binaries smaller. Repository: rL LLVM https://reviews.llvm.org/D39017 ___ cfe-commits

[PATCH] D39017: [CMake] Build Fuchsia toolchain as -O3

phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D39017 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === ---

r316022 - Expose ConsumeAnyToken interface to external clients.

Author: vvassilev Date: Tue Oct 17 12:38:57 2017 New Revision: 316022 URL: http://llvm.org/viewvc/llvm-project?rev=316022=rev Log: Expose ConsumeAnyToken interface to external clients. Modified: cfe/trunk/include/clang/Parse/Parser.h Modified: cfe/trunk/include/clang/Parse/Parser.h URL:

[PATCH] D38939: [clangd] Handle exit notification (proper shutdown)

rwols added a comment. > So I'm not totally convinced that treating an abrupt exit or EOF as an error > is worth the hassle Agreed, at least from the POV of a client clangd shuts down gracefully now. https://reviews.llvm.org/D38939 ___

[PATCH] D38939: [clangd] Handle exit notification (proper shutdown)

rwols updated this revision to Diff 119370. rwols added a comment. - Add test shutdown-with-exit.test - Add test shutdown-without-exit.test - Make protocol.test pass by inverting exit code ("# RUN: not ...") https://reviews.llvm.org/D38939 Files: clangd/ClangdLSPServer.cpp

[libcxx] r316021 - Refactor std::list node allocation logic.

Author: ericwf Date: Tue Oct 17 12:12:23 2017 New Revision: 316021 URL: http://llvm.org/viewvc/llvm-project?rev=316021=rev Log: Refactor std::list node allocation logic. The logic to allocate a node within std::list was repeated in a bunch of places. This is unneeded. This patch refactors the

Re: Patch bug 27628 (clang-tidy should exit with a failure code when there are errors)

Sometimes people just lose track; "pinging" is normal (see http://llvm.org/docs/DeveloperPolicy.html#code-reviews).  And sometimes it's helpful to CC reviewers in the area; adding Alexander Kornienko. -Eli On 10/17/2017 12:03 PM, Antoni Boucher wrote: Since the patch was redirected to the

Re: Patch bug 27628 (clang-tidy should exit with a failure code when there are errors)

Since the patch was redirected to the right mailing list and the subject was edited, I believe everything is okay, now? Is there any news? Thanks. On Thu, Sep 28, 2017 at 06:56:57PM +, Friedman, Eli wrote: When you're submitting a patch, please make sure you're sending it to the right

[PATCH] D39015: [Analyzer] Always use non-reference types when creating expressions in BodyFarm, removes std::call_once crash

george.karpenkov updated this revision to Diff 119360. https://reviews.llvm.org/D39015 Files: lib/Analysis/BodyFarm.cpp test/Analysis/call_once.cpp Index: test/Analysis/call_once.cpp === --- test/Analysis/call_once.cpp +++

[PATCH] D39015: [Analyzer] Always use non-reference types when creating expressions in BodyFarm, removes std::call_once crash

george.karpenkov created this revision. Herald added subscribers: szepet, kristof.beyls, xazax.hun, javed.absar, aemerson. Remove an option to use a reference type (on by default!) since a non-reference type is always needed for creating expressions, functions with multiple boolean parameters

[PATCH] D38354: Fix test by using -target instead of cc1 arguments (c-index-test goes through the driver)

filcab added a comment. Ping! https://reviews.llvm.org/D38354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39013: [CFG] Relax Wexceptions warning on rethrow

erichkeane added a comment. Have a question on the behavior here, see inline. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:299 if (!ThrowType) return false; if (ThrowType->isReferenceType()) The other potential fix here is to simply change this

[PATCH] D39013: [CFG] Relax Wexceptions warning on rethrow

erichkeane created this revision. As reported here: https://bugs.llvm.org/show_bug.cgi?id=34973 "catch(...)" should catch EVERYTHING, even a rethrow. This patch changes the order of the checks to ensure that the catch(...) will catch everything. https://reviews.llvm.org/D39013 Files:

[PATCH] D39005: [OpenMP] Clean up variable and function names for NVPTX backend

tra requested changes to this revision. tra added a comment. Justin is right. I completely forgot about this. :-/ Hal offered possible solution: https://reviews.llvm.org/D17738#661115 Repository: rL LLVM https://reviews.llvm.org/D39005 ___

[PATCH] D38868: [OpenCL] Restrict swizzle length check to OpenCL mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL316016: [OpenCL] Restrict swizzle length check to OpenCL mode (authored by bruno). Changed prior to commit: https://reviews.llvm.org/D38868?vs=118966=119351#toc Repository: rL LLVM

r316016 - [OpenCL] Restrict swizzle length check to OpenCL mode

Author: bruno Date: Tue Oct 17 10:54:57 2017 New Revision: 316016 URL: http://llvm.org/viewvc/llvm-project?rev=316016=rev Log: [OpenCL] Restrict swizzle length check to OpenCL mode Changes behavior introduced in r298369 to only error out on vector component invalid length access on OpenCL mode.

[PATCH] D39005: [OpenMP] Clean up variable and function names for NVPTX backend

jlebar added a comment. This has been tried twice before, see https://reviews.llvm.org/D29883 and https://reviews.llvm.org/D17738. I'm as unhappy about this as anyone, and personally I don't have any preference about how we try to solve it. But I think we shouldn't check this in without

r316015 - Replace use of SmallVector::back + pop_back with pop_back_val

Author: erichkeane Date: Tue Oct 17 10:45:21 2017 New Revision: 316015 URL: http://llvm.org/viewvc/llvm-project?rev=316015=rev Log: Replace use of SmallVector::back + pop_back with pop_back_val I ran across an instance where the value was being loaded out via back, then immediately popped.

r316013 - Sema: use new `getNS{,U}IntegerType` for NS{,U}Integer

Author: compnerd Date: Tue Oct 17 10:39:32 2017 New Revision: 316013 URL: http://llvm.org/viewvc/llvm-project?rev=316013=rev Log: Sema: use new `getNS{,U}IntegerType` for NS{,U}Integer Use the new helper methods to get the underlying type for NSUInteger, NSInteger types. This avoids spreading

Re: [libcxx] r315994 - [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

Hi Eric, This seems to have broken ARM and AArch64 buildbots: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-arm-linux/builds/850 http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-arm-linux-noexceptions/builds/931

r316011 - [OPENMP] Fix capturing of boolean variables in debug mode.

Author: abataev Date: Tue Oct 17 09:47:34 2017 New Revision: 316011 URL: http://llvm.org/viewvc/llvm-project?rev=316011=rev Log: [OPENMP] Fix capturing of boolean variables in debug mode. If the variables is boolean and we generating inner function with real types, the codegen may crash because

[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info

kosarev created this revision. kosarev added a project: clang. This patch fixes various places in clang to propagate may-alias TBAA access descriptors during construction of lvalues, thus eliminating the need for the LValueBaseInfo::MayAlias flag. This is part of

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

klimek added inline comments. Comment at: include/clang/Tooling/CommonOptionsParser.h:90 /// - /// This constructor exits program in case of error. + /// If \p ExitOnError is set (default), This constructor exits program in case + /// of error; otherwise, this sets the

Re: [libcxx] r315994 - [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

Hi Eric, This is also failing http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/39697/ Can you take a look? Thanks, On Tue, Oct 17, 2017 at 9:07 AM, Eric Fiselier via cfe-commits wrote: > These shadowing warnings should be fixed now. > > /Eric > > On

Re: [libcxx] r315994 - [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

These shadowing warnings should be fixed now. /Eric On Tue, Oct 17, 2017 at 10:03 AM, Maxim Kuvyrkov wrote: > Hi Eric, > > This seems to have broken ARM and AArch64 buildbots: > > http://lab.llvm.org:8011/builders/libcxx-libcxxabi- > libunwind-arm-linux/builds/850 >

[libcxx] r316009 - fix shadowing warnings in new tests, try 2

Author: ericwf Date: Tue Oct 17 09:06:42 2017 New Revision: 316009 URL: http://llvm.org/viewvc/llvm-project?rev=316009=rev Log: fix shadowing warnings in new tests, try 2 Modified: libcxx/trunk/test/support/emplace_constructible.h Modified: libcxx/trunk/test/support/emplace_constructible.h

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric updated this revision to Diff 119337. ioeric added a comment. - Minor cleanup in tests. https://reviews.llvm.org/D34272 Files: include/clang/Tooling/CommonOptionsParser.h include/clang/Tooling/Execution.h include/clang/Tooling/StandaloneExecution.h

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric added a comment. Thanks for the review! Comment at: include/clang/Tooling/CommonOptionsParser.h:116 + bool HasError; + std::string ErrorMessage; std::unique_ptr Compilations; arphaman wrote: > Would it be better to have an `llvm::Error' instead of

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric updated this revision to Diff 119331. ioeric marked an inline comment as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D34272 Files: include/clang/Tooling/CommonOptionsParser.h include/clang/Tooling/Execution.h

[PATCH] D38978: [OpenMP] Enable the lowering of implicitly shared variables in OpenMP GPU-offloaded target regions to the GPU shared memory

gtbercea updated this revision to Diff 119327. gtbercea added a comment. Eliminate variable and function name clean-up. That has been moved into a separate patch: https://reviews.llvm.org/D39005 Repository: rL LLVM https://reviews.llvm.org/D38978 Files:

[PATCH] D39005: [OpenMP] Clean up variable and function names for NVPTX backend

gtbercea created this revision. Herald added a subscriber: jholewinski. Clean-up variable and function names. Repository: rL LLVM https://reviews.llvm.org/D39005 Files: lib/Target/NVPTX/NVPTXAssignValidGlobalNames.cpp Index: lib/Target/NVPTX/NVPTXAssignValidGlobalNames.cpp

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric updated this revision to Diff 119325. ioeric marked 2 inline comments as done. ioeric added a comment. - Move StandaloneToolExecutor into a separate header; added ExecutionTest.cpp. https://reviews.llvm.org/D34272 Files: include/clang/Tooling/CommonOptionsParser.h

[PATCH] D38968: [OpenMP] Implement omp_is_initial_device() as builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rL316001: [OpenMP] Implement omp_is_initial_device() as builtin (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D38968?vs=119190=119320#toc Repository: rL LLVM

r316001 - [OpenMP] Implement omp_is_initial_device() as builtin

Author: hahnfeld Date: Tue Oct 17 07:28:14 2017 New Revision: 316001 URL: http://llvm.org/viewvc/llvm-project?rev=316001=rev Log: [OpenMP] Implement omp_is_initial_device() as builtin This allows to return the static value that we know at compile time. Differential Revision:

[PATCH] D38966: CodeGen: Fix invalid bitcasts for atomic builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL316000: CodeGen: Fix invalid bitcasts for atomic builtins (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D38966?vs=119182=119319#toc Repository: rL LLVM

r316000 - CodeGen: Fix invalid bitcasts for atomic builtins

Author: yaxunl Date: Tue Oct 17 07:19:29 2017 New Revision: 316000 URL: http://llvm.org/viewvc/llvm-project?rev=316000=rev Log: CodeGen: Fix invalid bitcasts for atomic builtins Currently clang assumes the temporary variables emitted during codegen of atomic builtins have address space 0, which

[PATCH] D38989: [clang-rename] Rename enum.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315999: [clang-rename] Rename enum. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D38989 Files: cfe/trunk/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp

r315999 - [clang-rename] Rename enum.

Author: hokein Date: Tue Oct 17 07:14:41 2017 New Revision: 315999 URL: http://llvm.org/viewvc/llvm-project?rev=315999=rev Log: [clang-rename] Rename enum. Summary: * Add unit tests for renaming enum. * Support unscoped enum constants in expressions. Reviewers: ioeric Reviewed By: ioeric

[PATCH] D38835: [refactor] selection: new CodeRangeASTSelection represents a set of selected consecutive statements

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: unittests/Tooling/ASTSelectionTest.cpp:688 + Source, {2, 2}, None, + [](SourceRange SelectionRange, Optional Node) { +EXPECT_TRUE(Node);

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric updated this revision to Diff 119314. ioeric added a comment. - Fix broken unit tests when they are run in threads in the same process. https://reviews.llvm.org/D34272 Files: include/clang/Tooling/CommonOptionsParser.h include/clang/Tooling/Execution.h

[libcxx] r315997 - fix shadowing warnings in new tests

Author: ericwf Date: Tue Oct 17 06:45:20 2017 New Revision: 315997 URL: http://llvm.org/viewvc/llvm-project?rev=315997=rev Log: fix shadowing warnings in new tests Modified: libcxx/trunk/test/support/emplace_constructible.h Modified: libcxx/trunk/test/support/emplace_constructible.h URL:

[PATCH] D38883: [CMake][OpenMP] Customize default offloading arch

This revision was automatically updated to reflect the committed changes. Closed by commit rL315996: [CMake][OpenMP] Customize default offloading arch (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D38883?vs=118961=119310#toc Repository: rL LLVM

r315996 - [CMake][OpenMP] Customize default offloading arch

Author: hahnfeld Date: Tue Oct 17 06:37:36 2017 New Revision: 315996 URL: http://llvm.org/viewvc/llvm-project?rev=315996=rev Log: [CMake][OpenMP] Customize default offloading arch For the shuffle instructions in reductions we need at least sm_30 but the user may want to customize the default

[PATCH] D38989: [clang-rename] Rename enum.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:212 + // Ignore the case where there is no prefix qualifer for the enum constant + // expression

[PATCH] D38989: [clang-rename] Rename enum.

hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:212 + // Ignore the case where there is no prefix qualifer for the enum constant + // expression like `a = Green`. + if (!Expr->hasQualifier()) ioeric

[PATCH] D38989: [clang-rename] Rename enum.

hokein updated this revision to Diff 119309. hokein added a comment. Use getQualifierLoc. https://reviews.llvm.org/D38989 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/CMakeLists.txt unittests/Rename/RenameEnumTest.cpp Index: unittests/Rename/RenameEnumTest.cpp

[libcxx] r315995 - Refactor _LIBCPP_<LITTLE|BIG>_ENDIAN

Author: ericwf Date: Tue Oct 17 06:16:01 2017 New Revision: 315995 URL: http://llvm.org/viewvc/llvm-project?rev=315995=rev Log: Refactor _LIBCPP__ENDIAN Previously this macro used 0/1 to indicate if it was set. This is unlike all other libc++ configuration macros which use

[libcxx] r315994 - [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

Author: ericwf Date: Tue Oct 17 06:03:17 2017 New Revision: 315994 URL: http://llvm.org/viewvc/llvm-project?rev=315994=rev Log: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back. Summary: The constructors `vector(Iter, Iter, Alloc =

[PATCH] D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

This revision was automatically updated to reflect the committed changes. Closed by commit rL315994: [libc++] Fix PR34898 - vector iterator constructors and assign method perform… (authored by EricWF). Changed prior to commit: https://reviews.llvm.org/D38757?vs=119301=119302#toc Repository:

[PATCH] D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

EricWF updated this revision to Diff 119301. EricWF added a comment. - Update whitespace. https://reviews.llvm.org/D38757 Files: include/deque include/list include/vector test/std/containers/sequences/deque/deque.cons/assign_iter_iter.pass.cpp

[PATCH] D38757: [libc++] Fix PR34898 - vector iterator constructors and assign method perform push_back instead of emplace_back.

EricWF accepted this revision. EricWF added a comment. In https://reviews.llvm.org/D38757#897536, @dlj wrote: > Hmm, looking more at this change... while it does make the behaviour > consistent for Forward and Input iterators, I think it's just making them > both do the wrong thing. > >

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a comment. Ping. https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r315989 - [CodeGen] Refine generation of TBAA info for bit-field lvalues

Author: kosarev Date: Tue Oct 17 04:20:19 2017 New Revision: 315989 URL: http://llvm.org/viewvc/llvm-project?rev=315989=rev Log: [CodeGen] Refine generation of TBAA info for bit-field lvalues The main change is that now we generate TBAA info before constructing the resulting lvalue instead of

[PATCH] D38947: [CodeGen] Refine generation of TBAA info for bit-field lvalues

This revision was automatically updated to reflect the committed changes. Closed by commit rL315989: [CodeGen] Refine generation of TBAA info for bit-field lvalues (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D38947?vs=119257=119288#toc Repository: rL LLVM

[PATCH] D38989: [clang-rename] Rename enum.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:212 + // Ignore the case where there is no prefix qualifer for the enum constant + // expression like `a = Green`. + if (!Expr->hasQualifier()) hokein

[PATCH] D38945: [CodeGen] Pass TBAA info along with lvalue base info everywhere

This revision was automatically updated to reflect the committed changes. Closed by commit rL315986: [CodeGen] Pass TBAA info along with lvalue base info everywhere (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D38945?vs=119129=119278#toc Repository: rL LLVM

r315986 - [CodeGen] Pass TBAA info along with lvalue base info everywhere

Author: kosarev Date: Tue Oct 17 03:17:43 2017 New Revision: 315986 URL: http://llvm.org/viewvc/llvm-project?rev=315986=rev Log: [CodeGen] Pass TBAA info along with lvalue base info everywhere This patch addresses the rest of the cases where we pass lvalue base info, but do not provide

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/EditorCommandRegistry.def:5 + +REFACTORING_EDITOR_COMMAND(ExtractFunction, "Extract Function") + Isn't `rename` also supported? Comment at:

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

hokein added a comment. +sammccall who is currently working on clangD, he might have ideas on the clangD/refactor integration. Repository: rL LLVM https://reviews.llvm.org/D38985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38989: [clang-rename] Rename enum.

hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:212 + // Ignore the case where there is no prefix qualifer for the enum constant + // expression like `a = Green`. + if (!Expr->hasQualifier()) ioeric

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

yvvan updated this revision to Diff 119273. yvvan added a comment. Rebased to update ScopeFlags. Rereview please https://reviews.llvm.org/D38618 Files: include/clang/Sema/Scope.h lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaCodeComplete.cpp test/Index/complete-super.cpp Index:

  1   2   >