[PATCH] D39738: [clangd] Sort completion results.

This revision was automatically updated to reflect the committed changes. Closed by commit rL317670: [clangd] Sort completion results. (authored by sammccall). Repository: rL LLVM https://reviews.llvm.org/D39738 Files: clang-tools-extra/trunk/clangd/ClangdUnit.cpp

[clang-tools-extra] r317670 - [clangd] Sort completion results.

Author: sammccall Date: Tue Nov 7 23:44:12 2017 New Revision: 317670 URL: http://llvm.org/viewvc/llvm-project?rev=317670=rev Log: [clangd] Sort completion results. Summary: This is (probably) not required by LSP, but at least one buggy client wants it. It also simplifies some tests - changed a

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

sammccall accepted this revision. sammccall added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:116 + /*Description=*/ + R"(Finds and renames qualified symbols in code with no indexer support. +It is used to move/rename a symbol to a

[PATCH] D39719: [X86][AVX512] lowering kunpack intrinsic - clang part

craig.topper added inline comments. Comment at: test/CodeGen/avx512f-builtins.c:6231 + // CHECK: bitcast <16 x i1> %{{.*}} to i16 + // CHECK: and i32 %{{.*}}, 255 + // CHECK: shl i32 %{{.*}}, 8 Does this really produce kunpackb in the backend? The type

[PATCH] D39050: Add index-while-building support to Clang

malaperle added inline comments. Comment at: lib/Index/IndexingAction.cpp:562 + + SourceManager = CI.getSourceManager(); + DiagnosticsEngine = CI.getDiagnostics(); As a first attempt, I tried to use index::createIndexDataRecordingAction in combination with

r317664 - [X86] Add masked vcvtps2ph builtins to CheckX86BuiltinFunctionCall.

Author: ctopper Date: Tue Nov 7 20:54:26 2017 New Revision: 317664 URL: http://llvm.org/viewvc/llvm-project?rev=317664=rev Log: [X86] Add masked vcvtps2ph builtins to CheckX86BuiltinFunctionCall. This ensures that only immediates that fit in 8-bits are used. This matches what we do for the

[PATCH] D39050: Add index-while-building support to Clang

malaperle added inline comments. Comment at: lib/Index/IndexUnitWriter.cpp:212 + return true; +}; + extra semi-colon (noticed this warning while compiling) https://reviews.llvm.org/D39050 ___ cfe-commits mailing

[PATCH] D39776: [libcxx] Mark test cxa_deleted_virtual.pass.cpp as failing for previous libcxx versions.

vsapsai created this revision. r313500 added a fix for undefined "___cxa_deleted_virtual" symbol. Previous libcxx versions don't have the fix and corresponding test should be failing. rdar://problem/34521053 https://reviews.llvm.org/D39776 Files:

[PATCH] D39762: [ObjC] Boxed strings should use the nullability from stringWithUTF8String's return type

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D39762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r317648 - [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Nov 7 17:03:16 2017 New Revision: 317648 URL: http://llvm.org/viewvc/llvm-project?rev=317648=rev Log: [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified:

r317644 - [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Nov 7 16:39:18 2017 New Revision: 317644 URL: http://llvm.org/viewvc/llvm-project?rev=317644=rev Log: [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/AST/CanonicalType.h

[clang-tools-extra] r317642 - Fix compile issue on MSVC.

Author: dyung Date: Tue Nov 7 16:29:42 2017 New Revision: 317642 URL: http://llvm.org/viewvc/llvm-project?rev=317642=rev Log: Fix compile issue on MSVC. Modified: clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp Modified: clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp

[PATCH] D39768: [coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in the coroutine frame

GorNishanov created this revision. Herald added a subscriber: EricWF. We don't want to store cleanup dest slot saved into the coroutine frame (as some of the cleanup code may access them after coroutine frame destroyed). This is an alternative to https://reviews.llvm.org/D37093 It is possible

[PATCH] D39611: [CodeGen] change const-ness of complex calls

hfinkel added a comment. In https://reviews.llvm.org/D39611#918275, @spatel wrote: > Patch updated: > I don't know if we have agreement on the behavior that we want yet, I just sent a note to the Austin group mailing list to see if the POSIX folks agree with my reading. I'll follow up. >

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

mgorny added a comment. Before: == FAIL: tests.cindex.test_code_completion.test_code_complete_availability -- Traceback (most recent call last):

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

mgorny added a comment. The diffs aren't very useful since I had to add a class for each test unit and so everything needed reindenting. You can take my word that changes boil down to: - adding `unittest` import, - adding class for each test unit and converting the functions into methods

[PATCH] D39682: [analyzer] Fix a crash on logical operators with vectors.

dcoughlin accepted this revision. dcoughlin added a comment. Interesting bug! The workaround looks good to me. https://reviews.llvm.org/D39682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D39332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r317616 - Update SanitizerSpecialCaseList to use renamed functions in base class.

Author: hctim Date: Tue Nov 7 13:16:37 2017 New Revision: 317616 URL: http://llvm.org/viewvc/llvm-project?rev=317616=rev Log: Update SanitizerSpecialCaseList to use renamed functions in base class. Note: This change has a cyclical dependency on D39485. Both these changes must be submitted at

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle requested changes to this revision. malaperle added inline comments. This revision now requires changes to proceed. Comment at: clangd/ClangdLSPServer.cpp:205 + + if (!(H.contents[0].codeBlockLanguage == "" && +H.contents[0].markdownString == "" &&

[PATCH] D39759: Remove x86 specific code from noplt.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL317627: Change noplt.c to work for non-x86 targets. (authored by tmsriram). Changed prior to commit: https://reviews.llvm.org/D39759?vs=121977=121987#toc Repository: rL LLVM

r317627 - Change noplt.c to work for non-x86 targets.

Author: tmsriram Date: Tue Nov 7 14:34:55 2017 New Revision: 317627 URL: http://llvm.org/viewvc/llvm-project?rev=317627=rev Log: Change noplt.c to work for non-x86 targets. Differential Revision: https://reviews.llvm.org/D39759 Modified: cfe/trunk/test/CodeGen/noplt.c Modified:

[PATCH] D39759: Remove x86 specific code from noplt.c

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Please search for `declare {{.*}}i32 @foo`, and then commit. Otherwise this could match `call i32 @foo` or something like that. https://reviews.llvm.org/D39759

[PATCH] D39711: [analyzer] ObjCGenerics: Don't warn on cast conversions involving explicit cast

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:587 if (TrackedType && + !isa(CE) && !ASTCtxt.canAssignObjCInterfaces(DestObjectPtrType, *TrackedType) && xazax.hun wrote: > george.karpenkov

[PATCH] D39759: Remove x86 specific code from noplt.c

tmsriram added a comment. More information here. This breaks non-x86 builds like PPC because: /home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/tools/clang/test/CodeGen/noplt.c:4:22: error: expected string not found in input // CHECK-NOPLT-NEXT: declare i32 @foo ^ :14:1: note: scanning

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 added a comment. I'll rebase the patch and add a test. Thanks for looking at this! Repository: rL LLVM https://reviews.llvm.org/D20124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39762: [ObjC] Boxed strings should use the nullability from stringWithUTF8String's return type

arphaman created this revision. Objective-C NSString has a class method `stringWithUTF8String` that creates a new NSString from a C string. Objective-C box expression `@(...)` can be used to create an NSString instead of invoking the `stringWithUTF8String` method directly (The compiler lowers

[PATCH] D39638: [NVPTX] Implement __nvvm_atom_add_gen_d builtin.

This revision was automatically updated to reflect the committed changes. Closed by commit rL317623: [NVPTX] Implement __nvvm_atom_add_gen_d builtin. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D39638?vs=121620=121984#toc Repository: rL LLVM

r317623 - [NVPTX] Implement __nvvm_atom_add_gen_d builtin.

Author: jlebar Date: Tue Nov 7 14:10:54 2017 New Revision: 317623 URL: http://llvm.org/viewvc/llvm-project?rev=317623=rev Log: [NVPTX] Implement __nvvm_atom_add_gen_d builtin. Summary: This just seems to have been an oversight. We already supported the f64 atomic add with an explicit scope

[PATCH] D39717: Always use prctl(PR_SET_PTRACER)

glandium updated this revision to Diff 121983. glandium added a comment. Updated wording. https://reviews.llvm.org/D39717 Files: lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc Index: lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc

[PATCH] D39759: Remove x86 specific code from noplt.c

tmsriram created this revision. https://reviews.llvm.org/D39079 breaks noplt.c for non-x86 targets. Remove x86 specific code from noplt.c https://reviews.llvm.org/D39759 Files: test/CodeGen/noplt.c Index: test/CodeGen/noplt.c

r317620 - [ObjC++] Don't warn about pessimizing move for __block variables

Author: arphaman Date: Tue Nov 7 13:40:11 2017 New Revision: 317620 URL: http://llvm.org/viewvc/llvm-project?rev=317620=rev Log: [ObjC++] Don't warn about pessimizing move for __block variables rdar://33316951 Added: cfe/trunk/test/SemaObjCXX/block-variable-move.mm Modified:

[libcxx] r317611 - Teach test suite about C++2a dialect flag.

Author: ericwf Date: Tue Nov 7 12:26:23 2017 New Revision: 317611 URL: http://llvm.org/viewvc/llvm-project?rev=317611=rev Log: Teach test suite about C++2a dialect flag. This patch teaches the test suite configuration about the -std=c++2a flag. And, since it's the newest dialect, change the

[libcxx] r317610 - Change test suite to support c++17 dialect flag instead of c++1z.

Author: ericwf Date: Tue Nov 7 12:20:58 2017 New Revision: 317610 URL: http://llvm.org/viewvc/llvm-project?rev=317610=rev Log: Change test suite to support c++17 dialect flag instead of c++1z. This patch changes the test suite to attempt and prefer -std=c++17 over -std=c++1z. It also fixes the

Re: [clang-tools-extra] r317553 - [clangd] fix MSVC build errors

Hello Sam, It looks like this commit broke the builder: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13313 . . . FAILED: tools/clang/tools/extra/unittests/clangd/CMakeFiles/ClangdTests.dir/JSONExprTests.cpp.obj Please have a look? Thanks Galina

[PATCH] D39611: [CodeGen] change const-ness of complex calls

spatel updated this revision to Diff 121949. spatel retitled this revision from "[CodeGen] make cbrt and fma constant (never set errno); document complex calls as always constant" to "[CodeGen] change const-ness of complex calls". spatel edited the summary of this revision. spatel added a

[PATCH] D39079: New clang option -fno-plt to avoid PLT for external calls

This revision was automatically updated to reflect the committed changes. Closed by commit rL317605: New clang option -fno-plt which avoids the PLT and lazy binding while making… (authored by tmsriram). Changed prior to commit: https://reviews.llvm.org/D39079?vs=119950=121947#toc Repository:

r317605 - New clang option -fno-plt which avoids the PLT and lazy binding while making external calls.

Author: tmsriram Date: Tue Nov 7 11:37:51 2017 New Revision: 317605 URL: http://llvm.org/viewvc/llvm-project?rev=317605=rev Log: New clang option -fno-plt which avoids the PLT and lazy binding while making external calls. Differential Revision: https://reviews.llvm.org/D39079 Added:

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

hokein marked an inline comment as done. hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:101 + std::string NewQualifiedName) { + return QualifiedRenameRule(std::move(OldQualifiedName), +

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

hokein updated this revision to Diff 121941. hokein added a comment. - remove USRRenameRule - rebase to master https://reviews.llvm.org/D39332 Files: include/clang/Tooling/Refactoring/Rename/RenamingAction.h lib/Tooling/Refactoring/RefactoringActions.cpp

[PATCH] D39751: [libc++] Add _LIBCPP_INLINE_VISIBILITY to __compressed_pair_elem members

arphaman created this revision. The commit r300140 changed the implementation of __compressed_pair, but didn't add _LIBCPP_INLINE_VISIBILITY to the constructors and `get` members of the __compressed_pair_elem class. This patch adds the visibility annotation. I'm not sure how to test this (and

[PATCH] D39748: [WebAssembly] Include GENERIC_TF_SOURCES

dschuff added a comment. Yes; in particular, musl's implementation of printf has some code where it promotes everything to long double, so if long double is f128, that causes several of these functions to get linked in to every binary, for no real benefit to the user. Repository: rL LLVM

[PATCH] D39748: [WebAssembly] Include GENERIC_TF_SOURCES

This revision was automatically updated to reflect the committed changes. Closed by commit rL317601: [WebAssembly] Include GENERIC_TF_SOURCES in wasm builds (authored by sbc). Repository: rL LLVM https://reviews.llvm.org/D39748 Files: compiler-rt/trunk/lib/builtins/CMakeLists.txt Index:

[PATCH] D39748: [WebAssembly] Include GENERIC_TF_SOURCES

sbc100 added a comment. My guess was that it was "long-double-is-f128" that was causing clang to generate references to these symbols, but I wasn't totally sure.. its only aarch64 and mips64 that seem to require these thus far. https://reviews.llvm.org/D39748

[PATCH] D39748: [WebAssembly] Include GENERIC_TF_SOURCES

dschuff added a comment. Yeah. Or not; I think you can still use `__float128` types in clang, so if you did that then it would use these methods too. And as long as `long double` is f64 then none of these functions would get pulled into every program that uses printf (which is the case now),

[PATCH] D39748: [WebAssembly] Include GENERIC_TF_SOURCES

sbc100 added a comment. I guess if we make that change we can revert this one? https://reviews.llvm.org/D39748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39748: [WebAssembly] Include GENERIC_TF_SOURCES

dschuff added a comment. Also btw I still think I want to back out the "long-double-is-f128" ABI from wasm. But either way it probably doesn't hurt to have these in compiler-rt. https://reviews.llvm.org/D39748 ___ cfe-commits mailing list

[PATCH] D39748: [WebAssembly] Include GENERIC_TF_SOURCES

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. BTW I'm still trying to get caught up, so if there's some review or something you have in flight that you want me to get to first, just let me know. https://reviews.llvm.org/D39748

[PATCH] D39738: [clangd] Sort completion results.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D39738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r317598 - Clang/libomptarget map interface flag renaming - NFC patch

Author: grokos Date: Tue Nov 7 10:27:04 2017 New Revision: 317598 URL: http://llvm.org/viewvc/llvm-project?rev=317598=rev Log: Clang/libomptarget map interface flag renaming - NFC patch This patch renames some of the flag names of the clang/libomptarget map interface. The old names are

r317599 - [refactor] rename field references in __builtin_offsetof

Author: arphaman Date: Tue Nov 7 10:30:23 2017 New Revision: 317599 URL: http://llvm.org/viewvc/llvm-project?rev=317599=rev Log: [refactor] rename field references in __builtin_offsetof rdar://33875453 Added: cfe/trunk/test/Refactor/LocalRename/BuiltinOffsetof.cpp Modified:

[PATCH] D39745: Clang/libomptarget map interface flag renaming - NFC patch

This revision was automatically updated to reflect the committed changes. Closed by commit rL317598: Clang/libomptarget map interface flag renaming - NFC patch (authored by grokos). Changed prior to commit: https://reviews.llvm.org/D39745?vs=121928=121931#toc Repository: rL LLVM

r317596 - [index] __builtin_offset's field reference is located at the end location

Author: arphaman Date: Tue Nov 7 10:25:36 2017 New Revision: 317596 URL: http://llvm.org/viewvc/llvm-project?rev=317596=rev Log: [index] __builtin_offset's field reference is located at the end location The starting location is the location of the '.' Modified:

[PATCH] D39730: Enabling constructor code completion

jkorous-apple added a comment. I agree and it seems to be the case but I will upgrade my ad-hoc testing code snippet to a proper test as I should have done it in the first place. I also agree that this change looks really suspicious and I was basically surprised that it works.

[PATCH] D39478: [clang-format] Handle leading comments in using declaration

sugak added a comment. @djasper: no, I do not. https://reviews.llvm.org/D39478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39745: Clang/libomptarget map interface flag renaming - NFC patch

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D39745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39347: Fix __has_unique_object_representations based on rsmith's input

erichkeane added a comment. Corrected version of the previous example: struct S { char a : 1; char b : 2; char c : 3; char d : 2; }; static_assert(sizeof(S) == 1, "size"); static_assert(__has_unique_object_representations(S), "error"); I haven't tested this patch agaainst this repro, but it

[PATCH] D39347: Fix __has_unique_object_representations based on rsmith's input

erichkeane added a comment. Also, I should probably validate bitfields. The following SHOULD?! be unique? struct S { unsigned a : 1; unsigned b : 2; unsigned c : 3; unsigned d : 2; }; static_assert(__has_unique_object_representations(S), "error"); But without 'd', it should not be (tail

r317589 - SystemZ Swift TargetInfo: swifterror support in the backend is broken

Author: arnolds Date: Tue Nov 7 08:40:51 2017 New Revision: 317589 URL: http://llvm.org/viewvc/llvm-project?rev=317589=rev Log: SystemZ Swift TargetInfo: swifterror support in the backend is broken Return false for swifterror support until the backend is fixed. Modified:

[PATCH] D39705: [clangd] Fix opening declarations located in non-preamble inclusion

This revision was automatically updated to reflect the committed changes. Closed by commit rL317585: [clangd] Fix opening declarations located in non-preamble inclusion (authored by malaperle). Repository: rL LLVM https://reviews.llvm.org/D39705 Files:

[clang-tools-extra] r317585 - [clangd] Fix opening declarations located in non-preamble inclusion

Author: malaperle Date: Tue Nov 7 08:16:45 2017 New Revision: 317585 URL: http://llvm.org/viewvc/llvm-project?rev=317585=rev Log: [clangd] Fix opening declarations located in non-preamble inclusion Summary: When an inclusion is not processed as part of the preamble, its path is not made into an

[PATCH] D38672: [X86][AVX512] lowering shuffle f/i intrinsic - clang part

jina.nahias updated this revision to Diff 121908. https://reviews.llvm.org/D38672 Files: lib/Headers/avx512fintrin.h lib/Headers/avx512vlintrin.h test/CodeGen/avx512f-builtins.c test/CodeGen/avx512vl-builtins.c Index: test/CodeGen/avx512vl-builtins.c

[PATCH] D39735: [clangd] Fix missing 'capabilities' field in initialize

malaperle abandoned this revision. malaperle added a comment. Already committed. Repository: rL LLVM https://reviews.llvm.org/D39735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r317584 - [clangd] Fix initialize capabilities response

Author: sammccall Date: Tue Nov 7 07:49:35 2017 New Revision: 317584 URL: http://llvm.org/viewvc/llvm-project?rev=317584=rev Log: [clangd] Fix initialize capabilities response Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp

[PATCH] D38672: [X86][AVX512] lowering shuffle f/i intrinsic - clang part

lsaba added inline comments. Comment at: lib/Headers/avx512fintrin.h:7207 + 3 + imm) >> 2) & 0x3) * 4), \ + 8 + imm) >> 4) & 0x3) * 4), \ + 9 + imm) >> 4) & 0x3) * 4),

[PATCH] D39719: [X86][AVX512] lowering kunpack intrinsic - clang part

jina.nahias added inline comments. Comment at: lib/Headers/avx512bwintrin.h:2045 { - return (__mmask64) __builtin_ia32_kunpckdi ((__mmask64) __A, -(__mmask64) __B); + return (__mmask64) (( __B & 0x) | ((__mmask64) __A << 32)); }

[PATCH] D39719: [X86][AVX512] lowering kunpack intrinsic - clang part

jina.nahias updated this revision to Diff 121899. https://reviews.llvm.org/D39719 Files: lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h test/CodeGen/avx512bw-builtins.c test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c

[PATCH] D39641: [CodeGen] make cbrt and fma constant (never set errno)

spatel updated this revision to Diff 121898. spatel added a comment. Patch updated - no code or functional changes from the last rev. I split the and test files up, so I can update those independently and not incur svn conflicts. https://reviews.llvm.org/D39641 Files:

[clang-tools-extra] r317581 - [clangd] MSVC - third time's the charm

Author: sammccall Date: Tue Nov 7 06:59:21 2017 New Revision: 317581 URL: http://llvm.org/viewvc/llvm-project?rev=317581=rev Log: [clangd] MSVC - third time's the charm Modified: clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp Modified:

[clang-tools-extra] r317580 - [clangd] don't crash on invalid JSON-RPC ID

Author: sammccall Date: Tue Nov 7 06:45:31 2017 New Revision: 317580 URL: http://llvm.org/viewvc/llvm-project?rev=317580=rev Log: [clangd] don't crash on invalid JSON-RPC ID Modified: clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp Modified:

[PATCH] D39675: [clang-refactor] Use ClangTool more explicitly by making refaroing actions AST frontend actions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL317577: [clang-refactor] Use ClangTool more explicitly by making refaroing actions AST… (authored by ioeric). Repository: rL LLVM https://reviews.llvm.org/D39675 Files:

r317577 - [clang-refactor] Use ClangTool more explicitly by making refaroing actions AST frontend actions.

Author: ioeric Date: Tue Nov 7 06:35:03 2017 New Revision: 317577 URL: http://llvm.org/viewvc/llvm-project?rev=317577=rev Log: [clang-refactor] Use ClangTool more explicitly by making refaroing actions AST frontend actions. Summary: This is a refactoring change. NFC Reviewers: arphaman,

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

xazax.hun added a comment. In https://reviews.llvm.org/D33722#916990, @aaron.ballman wrote: > In https://reviews.llvm.org/D33722#916540, @xazax.hun wrote: > > > Also, bugprone might be a better module to put this? > > > I don't have strong opinions on misc vs bugprone (they're both effectively

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

xazax.hun updated this revision to Diff 121886. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. - Fix doc comments that I overlooked earlier https://reviews.llvm.org/D33722 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/CopyConstructorInitCheck.cpp

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

xazax.hun updated this revision to Diff 121885. xazax.hun marked 3 inline comments as done. xazax.hun added a comment. - Fix review comments https://reviews.llvm.org/D33722 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/CopyConstructorInitCheck.cpp

[PATCH] D39675: [clang-refactor] Use ClangTool more explicitly by making refaroing actions AST frontend actions.

ioeric updated this revision to Diff 121883. ioeric added a comment. - Fix typos. https://reviews.llvm.org/D39675 Files: tools/clang-refactor/ClangRefactor.cpp Index: tools/clang-refactor/ClangRefactor.cpp === ---

[clang-tools-extra] r317575 - [clangd] another try at fixing MSVC

Author: sammccall Date: Tue Nov 7 06:14:58 2017 New Revision: 317575 URL: http://llvm.org/viewvc/llvm-project?rev=317575=rev Log: [clangd] another try at fixing MSVC Modified: clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp Modified:

[PATCH] D39707: [analyzer] assume bitwise arithmetic axioms

NoQ accepted this revision. NoQ added a comment. Yep, nice and clean~ Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:520 + Result = applyBitwiseConstraints(BV, F, T, Result, Sym); return Result; That's more and more "special case"s, i

[PATCH] D36610: [Tooling] Add option to getFullyQualifiedName using a custom PritingPolicy

mikhail.ramalho added a comment. Should we keep just the version with the custom printing policy then? https://reviews.llvm.org/D36610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39730: Enabling constructor code completion

jkorous-apple created this revision. Herald added a subscriber: eraman. It seems like constructor code completion was intentionally disabled ages ago in this commit (and refactored later): commit 33224e61bfca370850abae89bbd415a4dabe07fa Author: Douglas Gregor Date: Fri Sep

[PATCH] D39537: Rename identifiers named `__output`

arichardson added inline comments. Comment at: test/support/nasty_macros.hpp:55 +#define __output NASTY_MACRO +#define __input NASTY_MACRO EricWF wrote: > Shouldn't these not be defined when running the tests with a CHER compiler? > Otherwise the macro will

[PATCH] D38688: [clang-tidy] Misc redundant expressions checker updated for macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL317570: [clang-tidy] Misc redundant expressions checker updated for macros (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D38688?vs=121740=121875#toc Repository: rL LLVM

[clang-tools-extra] r317570 - [clang-tidy] Misc redundant expressions checker updated for macros

Author: xazax Date: Tue Nov 7 05:17:58 2017 New Revision: 317570 URL: http://llvm.org/viewvc/llvm-project?rev=317570=rev Log: [clang-tidy] Misc redundant expressions checker updated for macros Redundant Expression Checker is updated to be able to detect expressions that contain macros. Also,

[PATCH] D39719: [X86][AVX512] lowering kunpack intrinsic - clang part

RKSimon added inline comments. Comment at: lib/Headers/avx512bwintrin.h:2045 { - return (__mmask64) __builtin_ia32_kunpckdi ((__mmask64) __A, -(__mmask64) __B); + return (__mmask64) (( __B & 0x) | ((__mmask64) __A << 32)); } Is this

[PATCH] D39711: [analyzer] ObjCGenerics: Don't warn on cast conversions involving explicit cast

xazax.hun added a comment. In https://reviews.llvm.org/D39711#917433, @dcoughlin wrote: > @xazax.hun Would you be willing to take a look? Sure, I basically agree with George. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:587 if (TrackedType && +

[PATCH] D39707: [analyzer] assume bitwise arithmetic axioms

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. This looks like a great addition! Apart from some nits, LGTM. Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:487 + +// result >= constant +

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

spetrovic added a comment. ping https://reviews.llvm.org/D39053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r317565 - [analyzer] pr34779: CStringChecker: Accept non-standard headers.

Author: dergachev Date: Tue Nov 7 02:51:15 2017 New Revision: 317565 URL: http://llvm.org/viewvc/llvm-project?rev=317565=rev Log: [analyzer] pr34779: CStringChecker: Accept non-standard headers. Do not crash when trying to define and call a non-standard strcpy(unsigned char *, unsigned char *)

[PATCH] D39422: [analyzer] pr34779: CStringChecker: Don't get crashed by non-standard standard library function definitions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL317565: [analyzer] pr34779: CStringChecker: Accept non-standard headers. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D39422?vs=120834=121866#toc Repository: rL LLVM

[clang-tools-extra] r317559 - [clangd] Add ErrorCode enum class.

Author: hokein Date: Tue Nov 7 02:21:02 2017 New Revision: 317559 URL: http://llvm.org/viewvc/llvm-project?rev=317559=rev Log: [clangd] Add ErrorCode enum class. Summary: Avoid using magic number in the code everywhere. Reviewers: sammccall Reviewed By: sammccall Subscribers: ilya-biryukov,

[PATCH] D39718: [clangd] Add ErrorCodes enum class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL317559: [clangd] Add ErrorCode enum class. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D39718 Files: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp

[PATCH] D39478: [clang-format] Handle leading comments in using declaration

djasper accepted this revision. djasper added a comment. Looks good. Do you have submit access? https://reviews.llvm.org/D39478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39722: [ASTImporter] Support Import TypeTraitExpr

tk1012 created this revision. Herald added a subscriber: klimek. This fixes unsupporting of importing TypeTraitExpr in ASTImporter. TypeTraitExpr is caused by "__builtin_types_compatible_p()" that is usually used in the assertion in C code. For example, PostgreSQL uses the builtin function in

[PATCH] D39718: [clangd] Add ErrorCodes enum class.

hokein updated this revision to Diff 121858. hokein added a comment. Address review comments: - ErrorCodes => ErrorCode - Remove serverErrorStart/serverErrorEnd https://reviews.llvm.org/D39718 Files: clangd/ClangdLSPServer.cpp clangd/JSONRPCDispatcher.cpp clangd/JSONRPCDispatcher.h

[PATCH] D39682: [analyzer] Fix a crash on logical operators with vectors.

NoQ updated this revision to Diff 121856. NoQ added a comment. A better name for the test function. https://reviews.llvm.org/D39682 Files: lib/StaticAnalyzer/Core/ExprEngineC.cpp test/Analysis/vector.c Index: test/Analysis/vector.c

r317558 - [docs] Add section 'Half-Precision Floating Point'

Author: sjoerdmeijer Date: Tue Nov 7 02:09:45 2017 New Revision: 317558 URL: http://llvm.org/viewvc/llvm-project?rev=317558=rev Log: [docs] Add section 'Half-Precision Floating Point' This documents the differences/interactions between _Float16 and __fp16 and is a companion change for the

[PATCH] D39718: [clangd] Add ErrorCodes enum class.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/Protocol.h:35 +enum class ErrorCodes { + // Defined by JSON RPC. nit: could you call this ErrorCode? The plural doesn't make

[PATCH] D36610: [Tooling] Add option to getFullyQualifiedName using a custom PritingPolicy

klimek added a comment. Sorry for jumping in late, but I'm somewhat questioning whether an extra function in the API is worth the cost here: If you already have a printing policy, getting the type name will be 1 line instead of 2; having an extra function in a large API seems not worth it at a

[PATCH] D39705: [clangd] Fix opening declarations located in non-preamble inclusion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/ClangdUnit.cpp:970 +SourceMgr.getFileEntryForID(SourceMgr.getFileID(LocStart))) { + StringRef FilePath =

[PATCH] D39719: [X86][AVX512] lowering kunpack intrinsic - clang part

jina.nahias created this revision. https://reviews.llvm.org/D39719 Files: lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h test/CodeGen/avx512bw-builtins.c test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c

  1   2   >