[PATCH] D39936: [OpenCL] Add extensions cl_intel_subgroups and cl_intel_subgroups_short

AlexeySotkin created this revision. https://reviews.llvm.org/D39936 Files: include/clang/Basic/OpenCLExtensions.def lib/Headers/opencl-c.h test/SemaOpenCL/extension-version.cl Index: test/SemaOpenCL/extension-version.cl ===

[PATCH] D38737: [X86] test/testn intrinsics lowering to IR. clang side

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39768: [coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in the coroutine frame

eric_niebler accepted this revision. eric_niebler added a comment. This revision is now accepted and ready to land. Looks ok to me. https://reviews.llvm.org/D39768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r317960 - Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission

Author: jakehehrlich Date: Fri Nov 10 17:15:41 2017 New Revision: 317960 URL: http://llvm.org/viewvc/llvm-project?rev=317960=rev Log: Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission llvm-objcopy is getting to where it can be used in non-trivial ways (such as for

[PATCH] D39706: [refactor][extract] Initial implementation of variable captures

arphaman updated this revision to Diff 122565. arphaman marked 3 inline comments as done. arphaman added a comment. Address review comments Repository: rL LLVM https://reviews.llvm.org/D39706 Files: lib/Tooling/Refactoring/CMakeLists.txt

[PATCH] D39706: [refactor][extract] Initial implementation of variable captures

arphaman added inline comments. Comment at: lib/Tooling/Refactoring/Extract/CaptureVariables.h:36 + explicit CapturedExtractedEntity(const VarDecl *VD) + : Kind(CapturedVarDecl), VD(VD) {} + ioeric wrote: > arphaman wrote: > > ioeric wrote: > > > Maybe a

[PATCH] D39050: Add index-while-building support to Clang

akyrtzi added a comment. Hey Eric, In https://reviews.llvm.org/D39050#921748, @ioeric wrote: > >> - I think the implementation of the index output logic (e.g. > >> `IndexUnitWriter` and bit format file) can be abstracted away (and split > >> into separate patches) so that you can unit-test

[PATCH] D39818: [CUDA] [test-suite] Test std::min and std::max with C++11.

This revision was automatically updated to reflect the committed changes. Closed by commit rL317962: [CUDA] [test-suite] Test std::min and std::max with C++11. (authored by jlebar). Repository: rL LLVM https://reviews.llvm.org/D39818 Files: test-suite/trunk/External/CUDA/algorithm.cu

[PATCH] D39817: [CUDA] Fix std::min on device side to return the min, not the max.

This revision was automatically updated to reflect the committed changes. Closed by commit rL317961: [CUDA] Fix std::min on device side to return the min, not the max. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D39817?vs=122151=122563#toc Repository: rL LLVM

r317961 - [CUDA] Fix std::min on device side to return the min, not the max.

Author: jlebar Date: Fri Nov 10 17:25:44 2017 New Revision: 317961 URL: http://llvm.org/viewvc/llvm-project?rev=317961=rev Log: [CUDA] Fix std::min on device side to return the min, not the max. Summary: How embarrassing. This is tested in the test-suite -- fix to come there in a separate

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

mcgrathr added a comment. In principle this should be OK since we're unconditionally building the runtimes for `default`. However, this means that any dynamically-linked host builds will assume our toolchain-provided shared libraries are available on the runtime host in standard library

r317959 - Revert "[ThinLTO] Handle -fdebug-pass-manager for backend invocations via clang"

Author: tejohnson Date: Fri Nov 10 17:06:41 2017 New Revision: 317959 URL: http://llvm.org/viewvc/llvm-project?rev=317959=rev Log: Revert "[ThinLTO] Handle -fdebug-pass-manager for backend invocations via clang" This reverts commit r317951 and r317952. The new test is aborting on some bots and

r317957 - Handle lambda captures of variable length arrays in profiling and printing.

Author: rtrieu Date: Fri Nov 10 16:54:25 2017 New Revision: 317957 URL: http://llvm.org/viewvc/llvm-project?rev=317957=rev Log: Handle lambda captures of variable length arrays in profiling and printing. From http://reviews.llvm.org/D4368 these cases were thought to not be reachable and the

[PATCH] D39930: [CMake] Use libc++ and compiler-rt as default libraries in Fuchsia toolchain

phosek created this revision. Herald added subscribers: mgorny, dberris. Herald added a reviewer: EricWF. Fuchsia already defaults to libc++ and compiler-rt, but we want to use these as default runtimes even on the host platform. Repository: rL LLVM https://reviews.llvm.org/D39930 Files:

[PATCH] D39331: Add flags to control the -finstrument-functions instrumentation calls to __cyg_profile functions

hans updated this revision to Diff 122557. hans added a comment. Updating to match the LLVM-side: https://reviews.llvm.org/D39287#inline-348143 https://reviews.llvm.org/D39331 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cpp

[PATCH] D39829: add new check for property declaration

Wizard marked 2 inline comments as done. Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:27 +FixItHint generateFixItHint(const ObjCPropertyDecl *Decl) { + if (isupper(Decl->getName()[0])) { +auto NewName = Decl->getName().str();

[PATCH] D39829: add new check for property declaration

Wizard updated this revision to Diff 122552. Wizard marked 9 inline comments as done. Wizard added a comment. add custom options https://reviews.llvm.org/D39829 Files: clang-tidy/objc/CMakeLists.txt clang-tidy/objc/ObjCTidyModule.cpp clang-tidy/objc/PropertyDeclarationCheck.cpp

[PATCH] D36790: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message

arphaman added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D36790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39641: [CodeGen] make cbrt and fma constant (never set errno)

efriedma added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12853 + const llvm::Triple = Context.getTargetInfo().getTriple(); + if ((Trip.isGNUEnvironment() || Trip.isKnownWindowsMSVCEnvironment()) && + (Name->isStr("fma") || Name->isStr("fmaf") ||

r317953 - [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Fri Nov 10 16:08:50 2017 New Revision: 317953 URL: http://llvm.org/viewvc/llvm-project?rev=317953=rev Log: [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified:

r317952 - Add x86-registered-target to REQUIRES for new test

Author: tejohnson Date: Fri Nov 10 16:05:39 2017 New Revision: 317952 URL: http://llvm.org/viewvc/llvm-project?rev=317952=rev Log: Add x86-registered-target to REQUIRES for new test Should fix test added in r317951. Modified: cfe/trunk/test/CodeGen/thinlto-debug-pm.c Modified:

[PATCH] D39446: [PGO] Detect more structural changes with the stable hash

arphaman added a comment. ok, sgtm https://reviews.llvm.org/D39446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39446: [PGO] Detect more structural changes with the stable hash

vsk added inline comments. Comment at: lib/CodeGen/CodeGenPGO.cpp:244 + DEFINE_NESTABLE_TRAVERSAL(CXXTryStmt) + DEFINE_NESTABLE_TRAVERSAL(CXXCatchStmt) + arphaman wrote: > What about `ObjCAtTryStmt`? I thought about this, but: we don't place a counter on ObjC

[PATCH] D39446: [PGO] Detect more structural changes with the stable hash

arphaman added a comment. Generally it LG Comment at: lib/CodeGen/CodeGenPGO.cpp:244 + DEFINE_NESTABLE_TRAVERSAL(CXXTryStmt) + DEFINE_NESTABLE_TRAVERSAL(CXXCatchStmt) + What about `ObjCAtTryStmt`? Comment at: lib/CodeGen/CodeGenPGO.cpp:321

[PATCH] D39641: [CodeGen] make cbrt and fma constant (never set errno)

spatel updated this revision to Diff 122545. spatel added a comment. Patch updated: cbrt() is always const. fma() is always const with GNU or Win+MSVC. https://reviews.llvm.org/D39641 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp lib/Sema/SemaDecl.cpp

r317951 - [ThinLTO] Handle -fdebug-pass-manager for backend invocations via clang

Author: tejohnson Date: Fri Nov 10 15:37:39 2017 New Revision: 317951 URL: http://llvm.org/viewvc/llvm-project?rev=317951=rev Log: [ThinLTO] Handle -fdebug-pass-manager for backend invocations via clang Summary: The LTO Config field wasn't being set when invoking a ThinLTO backend via clang

[PATCH] D39923: [ThinLTO] Handle -fdebug-pass-manager for backend invocations via clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL317951: [ThinLTO] Handle -fdebug-pass-manager for backend invocations via clang (authored by tejohnson). Repository: rL LLVM https://reviews.llvm.org/D39923 Files:

[PATCH] D38425: [clangd] Document highlights for clangd

Nebiroth added a comment. This updated patch still does not handle highlighting macro references correctly. I will make another patch at a later time for this issue. In https://reviews.llvm.org/D38425#922408, @ioeric wrote: > Drive-by comment: in general, have you considered reusing the

[PATCH] D38425: [clangd] Document highlights for clangd

ioeric added a comment. Drive-by comment: in general, have you considered reusing the existing declarations and occurrences finding functionalities in clang-rename? AFAIK, it deals with templates and macros pretty well. o

r317944 - Remove declaration of EmitMCountInstrumentation(). NFC

Author: hans Date: Fri Nov 10 14:34:23 2017 New Revision: 317944 URL: http://llvm.org/viewvc/llvm-project?rev=317944=rev Log: Remove declaration of EmitMCountInstrumentation(). NFC The definition was removed in r280355. Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.h Modified:

LLVM buildmaster will be unavailable for a short time today

Hello everyone, We will be installing some network hardware in the Lab today. Most likely everything will go well, but there is a chance of network outage around 4:00 PM PST. Thanks for your patience and understanding. Thanks Galina ___ cfe-commits

[PATCH] D38425: [clangd] Document highlights for clangd

Nebiroth updated this revision to Diff 122529. Nebiroth added a comment. Decls and MacroInfos vectors are now private and passed by reference instead of copied. DeclarationLocationsFinder does not store Locations anymore, instead the vector is filled in their respective methods in

[libclc] r317940 - native_sqrt: Switch implementation to llvm intrinsic

Author: jvesely Date: Fri Nov 10 14:16:39 2017 New Revision: 317940 URL: http://llvm.org/viewvc/llvm-project?rev=317940=rev Log: native_sqrt: Switch implementation to llvm intrinsic Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Added:

[libclc] r317941 - native_exp10: Switch implementation to llvm intrinsic

Author: jvesely Date: Fri Nov 10 14:16:41 2017 New Revision: 317941 URL: http://llvm.org/viewvc/llvm-project?rev=317941=rev Log: native_exp10: Switch implementation to llvm intrinsic v2: Use native_log2 instead of wrong constant Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely

[libclc] r317937 - native_exp2: Switch implementation to llvm intrinsic

Author: jvesely Date: Fri Nov 10 14:16:31 2017 New Revision: 317937 URL: http://llvm.org/viewvc/llvm-project?rev=317937=rev Log: native_exp2: Switch implementation to llvm intrinsic Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Added:

[libclc] r317938 - native_cos: Switch implementation to llvm intrinsic

Author: jvesely Date: Fri Nov 10 14:16:33 2017 New Revision: 317938 URL: http://llvm.org/viewvc/llvm-project?rev=317938=rev Log: native_cos: Switch implementation to llvm intrinsic Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Added:

[libclc] r317939 - native_sin: Switch implementation to llvm intrinsic

Author: jvesely Date: Fri Nov 10 14:16:36 2017 New Revision: 317939 URL: http://llvm.org/viewvc/llvm-project?rev=317939=rev Log: native_sin: Switch implementation to llvm intrinsic Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Added:

[libclc] r317936 - native_exp: Switch implementation to llvm intrinsic

Author: jvesely Date: Fri Nov 10 14:16:28 2017 New Revision: 317936 URL: http://llvm.org/viewvc/llvm-project?rev=317936=rev Log: native_exp: Switch implementation to llvm intrinsic Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Added:

[libclc] r317935 - amdgpu: Add workaround for unimplemented llvm.exp intrinsic

Author: jvesely Date: Fri Nov 10 14:16:25 2017 New Revision: 317935 URL: http://llvm.org/viewvc/llvm-project?rev=317935=rev Log: amdgpu: Add workaround for unimplemented llvm.exp intrinsic Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Added:

[PATCH] D38425: [clangd] Document highlights for clangd

Nebiroth updated this revision to Diff 122528. Nebiroth added a comment. - Decls and MacroInfos vectors are now private and passed by reference instead of copied. https://reviews.llvm.org/D38425 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp

[libclc] r317934 - native_log10: Switch to generic native intrinsic inc file

Author: jvesely Date: Fri Nov 10 14:16:22 2017 New Revision: 317934 URL: http://llvm.org/viewvc/llvm-project?rev=317934=rev Log: native_log10: Switch to generic native intrinsic inc file Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Removed:

[libclc] r317933 - native_log: Switch to generic native intrinsic inc file

Author: jvesely Date: Fri Nov 10 14:16:20 2017 New Revision: 317933 URL: http://llvm.org/viewvc/llvm-project?rev=317933=rev Log: native_log: Switch to generic native intrinsic inc file Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Removed:

[libclc] r317932 - native_log2: Switch to generic native intrinsic inc file

Author: jvesely Date: Fri Nov 10 14:16:15 2017 New Revision: 317932 URL: http://llvm.org/viewvc/llvm-project?rev=317932=rev Log: native_log2: Switch to generic native intrinsic inc file v2: Add __CLC_XCONCAT instead of function name redirection Use __CLC_XCONCAT for intrinsic functions as

[PATCH] D39923: [ThinLTO] Handle -fdebug-pass-manager for backend invocations via clang

danielcdh accepted this revision. danielcdh added a comment. This revision is now accepted and ready to land. Thanks for the fix. https://reviews.llvm.org/D39923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r317931 - Fix for skipped CMake configuration on debuginfo-tests.

Author: zturner Date: Fri Nov 10 14:12:04 2017 New Revision: 317931 URL: http://llvm.org/viewvc/llvm-project?rev=317931=rev Log: Fix for skipped CMake configuration on debuginfo-tests. This should have been part of the change to debuginfo-tests, but it was left out. This should get the

[PATCH] D39923: [ThinLTO] Handle -fdebug-pass-manager for backend invocations via clang

tejohnson created this revision. Herald added subscribers: eraman, inglorion, mehdi_amini. The LTO Config field wasn't being set when invoking a ThinLTO backend via clang (i.e. for distributed builds). https://reviews.llvm.org/D39923 Files: lib/CodeGen/BackendUtil.cpp

[PATCH] D39913: [ObjC] warn about availability attributes missing from a method's declaration when they're specified for a method's definition

erik.pilkington added a comment. Any thoughts on having this for regular functions and C++ member functions? Seems just as useful there. Comment at: include/clang/Sema/Sema.h:2406 + /// This will warn on any missing clauses in the declaration. + void

[PATCH] D39438: [analyzer] Diagnose stack leaks via block captures

alexshap updated this revision to Diff 122507. alexshap added a comment. Address the comments Repository: rL LLVM https://reviews.llvm.org/D39438 Files: lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp test/Analysis/stack-capture-leak-arc.mm

r317925 - [debuginfo-tests] Make debuginfo-tests work in a standard configuration.

Author: zturner Date: Fri Nov 10 12:57:57 2017 New Revision: 317925 URL: http://llvm.org/viewvc/llvm-project?rev=317925=rev Log: [debuginfo-tests] Make debuginfo-tests work in a standard configuration. Previously, debuginfo-tests was expected to be checked out into clang/test and then the tests

[PATCH] D39918: [libunwind] Remove a FIXME about truncated section names

mstorsjo created this revision. Herald added a subscriber: aprantl. If the linker chose to store the full section name instead of truncating it, this field doesn't contain a truncated name, but an offset into the string table of the binary. The string table isn't loaded/mapped into memory

[PATCH] D39915: [clang] Remove redundant return [NFC]

mgrang created this revision. mgrang added a project: clang. Herald added a subscriber: jholewinski. https://reviews.llvm.org/D39915 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp lib/Driver/Driver.cpp lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp Index:

[PATCH] D39641: [CodeGen] make cbrt and fma constant (never set errno)

efriedma added a comment. cbrt() can't underflow; that's not how cube roots work. If 0 x. See also the definition of rootn() in IEEE 754 (which specifies no exceptions for n=3). For fma(), sure, I guess we could whitelist glibc and msvcrt, if you're worried there's some

[PATCH] D39913: [ObjC] warn about availability attributes missing from a method's declaration when they're specified for a method's definition

arphaman created this revision. Herald added a subscriber: javed.absar. This patch extends the -Wavailability warning to warn about cases where a method declaration is missing an availability attribute clause that's present in the method's definition. We also warn about missing `deprecated`

[PATCH] D39878: AMDGPU: Add -mxnack/-mno-xnack options that set +/-xnack feature

This revision was automatically updated to reflect the committed changes. Closed by commit rL317917: AMDGPU: Add -mxnack/-mno-xnack options that set +/-xnack feature (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D39878?vs=122355=122489#toc Repository: rL LLVM

r317917 - AMDGPU: Add -mxnack/-mno-xnack options that set +/-xnack feature

Author: kzhuravl Date: Fri Nov 10 11:28:25 2017 New Revision: 317917 URL: http://llvm.org/viewvc/llvm-project?rev=317917=rev Log: AMDGPU: Add -mxnack/-mno-xnack options that set +/-xnack feature Differential Revision: https://reviews.llvm.org/D39878 Modified:

[PATCH] D38801: [analyzer] In getSVal() API, disable auto-detection of void type as char type.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! In https://reviews.llvm.org/D38801#910524, @NoQ wrote: > Also the overload between `getSVal(Ex, LC)` and `getSVal(R, Ty)`, when they > do completely different things,

[PATCH] D39803: [analyzer] pr34766: Fix a crash on explicit construction of std::initializer_list.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D39803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39877: AMDGPU/NFC: Move getAMDGPUTargetFeatures to AMDGPU toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL317909: AMDGPU/NFC: Move getAMDGPUTargetFeatures to AMDGPU toolchain (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D39877?vs=122354=122487#toc Repository: rL LLVM

r317909 - AMDGPU/NFC: Move getAMDGPUTargetFeatures to AMDGPU toolchain

Author: kzhuravl Date: Fri Nov 10 11:09:57 2017 New Revision: 317909 URL: http://llvm.org/viewvc/llvm-project?rev=317909=rev Log: AMDGPU/NFC: Move getAMDGPUTargetFeatures to AMDGPU toolchain Differential Revision: https://reviews.llvm.org/D39877 Modified:

[PATCH] D39641: [CodeGen] make cbrt and fma constant (never set errno)

spatel added a comment. Based on the comments in https://reviews.llvm.org/D39611, I think we have to change this (although I'd be happy to be wrong). 1. cbrt() can underflow and could set errno to ERANGE. 2. fma() can overflow or underflow and set errno to ERANGE. We could still make an

[PATCH] D39800: [analyzer] pr34404: Fix a crash on pointers to members in nested anonymous structures.

dcoughlin accepted this revision. dcoughlin added a comment. LGTM. I suppose we could move the logic that constructs pointers to members for fields here (right now that logic is in ExprEngine::VisitUnaryOperator()'s handling of '&'). However, since the AST's DeclRefExpr for the field is marked

[PATCH] D39821: Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission

jakehehrlich added a comment. > Another option would be to restrict `CLANG_DEFAULT_OBJCOPY` to contain > `objcopy` or even to only allow `objcopy` or `llvm-objcopy`. I don't know if > that's sensible though... I think there are some other strip/objcopy like implementations out there but I

[PATCH] D39611: [CodeGen] change const-ness of complex calls

spatel updated this revision to Diff 122474. spatel added a comment. Patch updated: Except for cimag, cproj, conj, and creal, everything in is marked 'e' - the functions are not const if we might set errno. https://reviews.llvm.org/D39611 Files: include/clang/Basic/Builtins.def

[PATCH] D39821: Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission

Hahnfeld added a comment. In https://reviews.llvm.org/D39821#922026, @jakehehrlich wrote: > In https://reviews.llvm.org/D39821#921703, @Hahnfeld wrote: > > > I think the current tests will only pass iff the executable name ends with > > `objcopy` - can we make this more reliable? > > > If I

[PATCH] D39730: Enabling constructor code completion

arphaman added a comment. Also, Comment at: lib/Sema/SemaCodeComplete.cpp:980 + if (isa(R.Declaration) + && dyn_cast(CurContext) == nullptr + && dyn_cast(CurContext) == nullptr arphaman wrote: > You can use `!isa` Have you checked if this check

[PATCH] D39821: Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission

jakehehrlich added a comment. In https://reviews.llvm.org/D39821#921703, @Hahnfeld wrote: > I think the current tests will only pass iff the executable name ends with > `objcopy` - can we make this more reliable? If I read the tests (split-debug.h, split-debug.c, and split-debug.s) correctly

[PATCH] D39730: Enabling constructor code completion

arphaman added a comment. It doesn't look like this works in the body of the class (at least there's no test for it). For that you might have to inject these kind results by performing another lookup when completing inside the body of the class. Comment at:

[PATCH] D39730: Enabling constructor code completion

jkorous-apple updated this revision to Diff 122470. jkorous-apple added a comment. I am able to enable ctor completion selectively in translate unit scope and namespace scope so ctor completion does not appear in dot access context. I haven't figured out how to explicitly specify that

[PATCH] D39611: [CodeGen] change const-ness of complex calls

hfinkel added a comment. In https://reviews.llvm.org/D39611#921923, @spatel wrote: > Thanks for the clarification! > > If I'm reading this properly, we should make the same kind of change as in > https://reviews.llvm.org/D39481 ('c' -> 'e') for most of complex.h. Ie, the > standard allows

Re: r315614 - [Sema] Diagnose tautological comparison with type's min/max values

On Thu, Oct 12, 2017 at 2:33 PM, Roman Lebedev via cfe-commits wrote: > On Fri, Oct 13, 2017 at 12:12 AM, Nico Weber wrote: >> Huh, I consider clang not warning on this a feature, not a bug. Why are we >> trying to match what gcc does here? >

[PATCH] D39706: [refactor][extract] Initial implementation of variable captures

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Extract/CaptureVariables.cpp:97 + } + llvm_unreachable("invalid kind!"); +} A more informative message would be better. Comment at:

[PATCH] D39161: [bindings] remove unique_external test failure

frutiger added a comment. Thanks for the note, I'll wait. https://reviews.llvm.org/D39161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39611: [CodeGen] change const-ness of complex calls

spatel added a comment. Thanks for the clarification! If I'm reading this properly, we should make the same kind of change as in https://reviews.llvm.org/D39481 ('c' -> 'e') for most of complex.h. Ie, the standard allows errno-setting, and it's (unfortunately for optimization) even more

[PATCH] D39478: [clang-format] Handle leading comments in using declaration

djasper closed this revision. djasper added a comment. Submitted as r317901. https://reviews.llvm.org/D39478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r317901 - [clang-format] Handle leading comments in using declaration

Author: djasper Date: Fri Nov 10 09:11:18 2017 New Revision: 317901 URL: http://llvm.org/viewvc/llvm-project?rev=317901=rev Log: [clang-format] Handle leading comments in using declaration This fixes clang-format internal assertion for the following code: /* override */ using std::string;

[PATCH] D39161: [bindings] remove unique_external test failure

mgorny added a comment. I've rewritten the tests to use `unittest`, so this patch needs to be updated now. However, you may want to wait a while since @compnerd promised to look at it and he might have a way to get `uniqueExternal()` linkage. https://reviews.llvm.org/D39161

[PATCH] D39900: Refactor ContinuationIndenter's breakProtrudingToken logic into slightly moreorthogonal pieces.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Maybe we should further refactor `getRawStringStyle` into `llvm::Optional> getRawStringStyleAndDelimiter` and that would nicely take care of the duplicated

r317898 - [NFC] Pacify bbot for OpenMP 'teams distribute parallel for'

Author: cbertol Date: Fri Nov 10 08:49:09 2017 New Revision: 317898 URL: http://llvm.org/viewvc/llvm-project?rev=317898=rev Log: [NFC] Pacify bbot for OpenMP 'teams distribute parallel for' Modified: cfe/trunk/test/OpenMP/teams_distribute_parallel_for_messages.cpp Modified:

[PATCH] D39829: add new check for property declaration

benhamilton added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:41 + objcPropertyDecl( + // the property name should be in Lower Camel Case like + // 'lowerCamelCase' benhamilton wrote: > There are some

[PATCH] D39829: add new check for property declaration

benhamilton added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:41 + objcPropertyDecl( + // the property name should be in Lower Camel Case like + // 'lowerCamelCase' There are some exceptions we should special

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

mgorny added a comment. Thanks. I'll update it to incorporate the lately committed test fixes, and push it later today. Repository: rL LLVM https://reviews.llvm.org/D39763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39902: [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 317893. Repository: rL LLVM https://reviews.llvm.org/D39902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r317893 - [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'

Author: cbertol Date: Fri Nov 10 08:05:00 2017 New Revision: 317893 URL: http://llvm.org/viewvc/llvm-project?rev=317893=rev Log: [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for' https://reviews.llvm.org/D39902 Simply leverage existing implementation and verify correct

[PATCH] D39902: [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D39902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39902: [OpenMP] Parse+Sema for copyin clause of 'teams distribute parallel for'

carlo.bertolli created this revision. Simply leverage existing implementation and verify correct functioning with two regression tests. Repository: rL LLVM https://reviews.llvm.org/D39902 Files: include/clang/Basic/OpenMPKinds.def test/OpenMP/teams_distribute_parallel_for_ast_print.cpp

[PATCH] D39859: [OpenMP] diagnose assign to firstprivate const

This revision was automatically updated to reflect the committed changes. Closed by commit rL317891: [OpenMP] diagnose assign to firstprivate const, patch by Joel E. Denny (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D39859?vs=122329=122434#toc Repository: rL

r317891 - [OpenMP] diagnose assign to firstprivate const, patch by Joel E. Denny

Author: abataev Date: Fri Nov 10 07:39:50 2017 New Revision: 317891 URL: http://llvm.org/viewvc/llvm-project?rev=317891=rev Log: [OpenMP] diagnose assign to firstprivate const, patch by Joel E. Denny Summary: [OpenMP] diagnose assign to firstprivate const Clang does not diagnose assignments to

[PATCH] D39900: Refactor ContinuationIndenter's breakProtrudingToken logic into slightly moreorthogonal pieces.

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1028 + unsigned Penalty = + handleEndOfLine(Current, State, DryRun, AllowBreak); krasimir wrote: > Why `handleEndOfLine`? Is it guaranteed that here we've reached the end of >

[PATCH] D39900: Refactor ContinuationIndenter's breakProtrudingToken logic into slightly moreorthogonal pieces.

klimek updated this revision to Diff 122433. klimek marked an inline comment as done. klimek added a comment. - Add test. Updating D39900: Refactor ContinuationIndenter's breakProtrudingToken logic into slightly more

[PATCH] D39842: Allow to store precompiled preambles in memory.

klimek added inline comments. Comment at: include/clang/Frontend/PrecompiledPreamble.h:99 /// Changes options inside \p CI to use PCH from this preamble. Also remaps - /// main file to \p MainFileBuffer. + /// main file to \p MainFileBuffer and updates \p VFS to ensure

[PATCH] D39900: Refactor ContinuationIndenter's breakProtrudingToken logic into slightly moreorthogonal pieces.

krasimir added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1028 + unsigned Penalty = + handleEndOfLine(Current, State, DryRun, AllowBreak); Why `handleEndOfLine`? Is it guaranteed that here we've reached the end of the line?

[PATCH] D39859: [OpenMP] diagnose assign to firstprivate const

ABataev added a comment. In https://reviews.llvm.org/D39859#921780, @jdenny wrote: > Alexey: Thanks for accepting. I do not have commit privileges. Would you > please commit for me? Sure, no problems. https://reviews.llvm.org/D39859 ___

[PATCH] D39859: [OpenMP] diagnose assign to firstprivate const

jdenny added a comment. Alexey: Thanks for accepting. I do not have commit privileges. Would you please commit for me? https://reviews.llvm.org/D39859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39900: Refactor ContinuationIndenter's breakProtrudingToken logic into slightly moreorthogonal pieces.

klimek created this revision. This patch allowed me to experiment with various alternatives to https://reviews.llvm.org/D33589. https://reviews.llvm.org/D39900 Files: lib/Format/BreakableToken.cpp lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h

[PATCH] D39859: [OpenMP] diagnose assign to firstprivate const

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D39859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a comment. Ping. https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39050: Add index-while-building support to Clang

ioeric added a comment. >> - I think the implementation of the index output logic (e.g. >> `IndexUnitWriter` and bit format file) can be abstracted away (and split >> into separate patches) so that you can unit-test the action with a >> custom/mock unit writer; this would also make the action

[PATCH] D39763: [clang] [python] [tests] Rewrite to use standard unittest module

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I can't really check if all the tests are equivalent to the old ones, but not having to install nose is a major usability improvement. Let's ship this. We should totally fix the existing

[PATCH] D39821: Add CLANG_DEFAULT_OBJCOPY to allow Clang to use llvm-objcopy for dwarf fission

Hahnfeld added a comment. I think the current tests will only pass iff the executable name ends with `objcopy` - can we make this more reliable? Repository: rL LLVM https://reviews.llvm.org/D39821 ___ cfe-commits mailing list

  1   2   >