Re: r319297 - Toolchain: Normalize dwarf, sjlj and seh eh

Just catching up on this now. r319363 looks good to me, It makes little sense to use GNU SEH in that case. My remaining concern is mostly about why we still need the workaround for > x86 in the function getting the default (returning None instead of WinEH > for that case). But as long as this

Re: [clang-tools-extra] r319557 - [clangd] Fuzzy match scorer

Great! Unfortunately it broke old GCC, and it doesn't seem possible to satisfy both. So r319608 removes the enum altogether. On Sat, Dec 2, 2017 at 4:54 AM, Yung, Douglas wrote: > That fixed it, thanks! > > > > Douglas Yung > > > > *From:* Sam McCall

[clang-tools-extra] r319608 - [clangd] Avoid enum in bitfields, can't satisfy old GCC and new MSVC

Author: sammccall Date: Fri Dec 1 20:15:55 2017 New Revision: 319608 URL: http://llvm.org/viewvc/llvm-project?rev=319608=rev Log: [clangd] Avoid enum in bitfields, can't satisfy old GCC and new MSVC Modified: clang-tools-extra/trunk/clangd/FuzzyMatch.h Modified:

Re: [clang-tools-extra] r319557 - [clangd] Fuzzy match scorer

r319606 should fix that one, if I've understood the problem right. On Sat, Dec 2, 2017 at 3:50 AM, Yung, Douglas wrote: > Hi Sam, the FuzzyMatch tests you added in this commit seem to be failing > on the Windows bot: > >

[clang-tools-extra] r319606 - [clangd] Fix FuzzyMatch tests on windows, NFC

Author: sammccall Date: Fri Dec 1 19:35:19 2017 New Revision: 319606 URL: http://llvm.org/viewvc/llvm-project?rev=319606=rev Log: [clangd] Fix FuzzyMatch tests on windows, NFC Without specifying the signedness of the underlying type for Action, packing it in a 1-bit field may restrict its range

RE: [clang-tools-extra] r319557 - [clangd] Fuzzy match scorer

Hi Sam, the FuzzyMatch tests you added in this commit seem to be failing on the Windows bot: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13869 Can you take a look? Douglas Yung > -Original Message- > From: cfe-commits

r319605 - PR35456: Track definedness of variable template specializations separately from

Author: rsmith Date: Fri Dec 1 18:48:42 2017 New Revision: 319605 URL: http://llvm.org/viewvc/llvm-project?rev=319605=rev Log: PR35456: Track definedness of variable template specializations separately from whether they have an initializer. We cannot distinguish between a declaration of a

Re: [clang-tools-extra] r319557 - [clangd] Fuzzy match scorer

Apologies. This is a GCC bug I wasn't familiar with, and my first guess at a fix was wrong. (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58541) r319604 should fix this. On Fri, Dec 1, 2017 at 10:20 PM, Galina Kistanova wrote: > Hello Sam, > > This commit broke one of our

[clang-tools-extra] r319604 - [clangd] Try to appease gcc constexpr bug (58541)

Author: sammccall Date: Fri Dec 1 18:28:29 2017 New Revision: 319604 URL: http://llvm.org/viewvc/llvm-project?rev=319604=rev Log: [clangd] Try to appease gcc constexpr bug (58541) Modified: clang-tools-extra/trunk/clangd/FuzzyMatch.cpp Modified:

[PATCH] D40762: [CMake] Don't use comma as an alternate separator

phosek created this revision. Herald added a subscriber: mgorny. Using comma can break in cases when we're passing flags that already use comma as a separator. Fixes PR35504. Repository: rC Clang https://reviews.llvm.org/D40762 Files: CMakeLists.txt Index: CMakeLists.txt

r319601 - Move comment back to being next to the code it's a comment for.

Author: rsmith Date: Fri Dec 1 16:55:48 2017 New Revision: 319601 URL: http://llvm.org/viewvc/llvm-project?rev=319601=rev Log: Move comment back to being next to the code it's a comment for. Modified: cfe/trunk/lib/AST/Decl.cpp Modified: cfe/trunk/lib/AST/Decl.cpp URL:

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 added a comment. Brilliant, didn't know `isInPreambleFileID` existed. All my tests pass for me now with that change, thanks :-) I'll update the patch on Monday. https://reviews.llvm.org/D20124 ___ cfe-commits mailing list

[PATCH] D40625: Harmonizing attribute GNU/C++ spellings

dcoughlin added inline comments. Comment at: include/clang/Basic/Attr.td:602 def AnalyzerNoReturn : InheritableAttr { - let Spellings = [GNU<"analyzer_noreturn">]; + let Spellings = [Clang<"analyzer_noreturn">]; let Documentation = [Undocumented];

[PATCH] D40568: design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. Looks great! Repository: rC Clang https://reviews.llvm.org/D40568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r319594 - [AST] Try to fix build bot with modules broken r319589. However real fix may belong to other place.

Author: eugenezelenko Date: Fri Dec 1 15:23:28 2017 New Revision: 319594 URL: http://llvm.org/viewvc/llvm-project?rev=319594=rev Log: [AST] Try to fix build bot with modules broken r319589. However real fix may belong to other place. Modified:

[PATCH] D40044: [CodeGen] convert math libcalls/builtins to equivalent LLVM intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rC319593: [CodeGen] convert math libcalls/builtins to equivalent LLVM intrinsics (authored by spatel). Repository: rC Clang https://reviews.llvm.org/D40044 Files: lib/CodeGen/CGBuiltin.cpp

[PATCH] D40044: [CodeGen] convert math libcalls/builtins to equivalent LLVM intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL319593: [CodeGen] convert math libcalls/builtins to equivalent LLVM intrinsics (authored by spatel). Changed prior to commit: https://reviews.llvm.org/D40044?vs=122881=125230#toc Repository: rL LLVM

r319593 - [CodeGen] convert math libcalls/builtins to equivalent LLVM intrinsics

Author: spatel Date: Fri Dec 1 15:15:52 2017 New Revision: 319593 URL: http://llvm.org/viewvc/llvm-project?rev=319593=rev Log: [CodeGen] convert math libcalls/builtins to equivalent LLVM intrinsics There are 20 LLVM math intrinsics that correspond to mathlib calls according to the LangRef:

[PATCH] D40746: Correctly handle line table entries without filenames during AST serialization

hans updated this revision to Diff 125227. hans retitled this revision from "Correctly handle line directives without filenames that come first in the file" to "Correctly handle line table entries without filenames during AST serialization". hans edited the summary of this revision.

[PATCH] D38425: [clangd] Document highlights for clangd

Nebiroth updated this revision to Diff 125228. Nebiroth added a comment. Minor code cleanup unparse and parse methods for JSON are updated Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38425 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D40746: Correctly handle line directives without filenames that come first in the file

hans added a comment. In https://reviews.llvm.org/D40746#942824, @rsmith wrote: > The intent is to use a `FilenameID` of -1 to represent this situation; see > the documentation of the `LineEntry::FilenameID` member. Users of that field > are expected to deal with that value (see the handling

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

aheejin added a comment. After this patch, a couple of gcc torture tests started to fail. Could you possibly look at this? https://bugs.llvm.org/show_bug.cgi?id=35503 Repository: rL LLVM https://reviews.llvm.org/D39455 ___ cfe-commits mailing

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

hubert.reinterpretcast added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:817 DefineFloatMacros(Builder, "LDBL", (), "L"); + DefineFloatMacros(Builder, "FLT128", (), "Q"); + GCC //does// define these macros under with C++ mode when it would

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth updated this revision to Diff 125224. Nebiroth added a comment. Minor code cleanup Merge with master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h

[PATCH] D40746: Correctly handle line directives without filenames that come first in the file

rsmith added a comment. The intent is to use a `FilenameID` of -1 to represent this situation; see the documentation of the `LineEntry::FilenameID` member. Users of that field are expected to deal with that value (see the handling of that case in `SourceManager::getPresumedLoc` for example). I

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=

jdenny updated this revision to Diff 125223. jdenny added a comment. Rebased on master/trunk fetched today. https://reviews.llvm.org/D39694 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/DiagnosticOptions.h include/clang/Driver/CC1Options.td

r319589 - [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Fri Dec 1 14:04:49 2017 New Revision: 319589 URL: http://llvm.org/viewvc/llvm-project?rev=319589=rev Log: [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/AST/DeclContextInternals.h

[PATCH] D40698: [ubsan] Diagnose noreturn functions which return

vsk updated this revision to Diff 125221. vsk edited the summary of this revision. vsk added a comment. - Diagnose in the scenario Eli pointed out, by stripping the 'noreturn' attribute and emitting a check after the call. - Test updates. https://reviews.llvm.org/D40698 Files:

[PATCH] D40700: [ubsan] Diagnose noreturn functions which return (compiler-rt)

vsk updated this revision to Diff 125220. vsk added a comment. - Update to test diagnostics seen after a call to the noreturn function. https://reviews.llvm.org/D40700 Files: lib/ubsan/ubsan_handlers.cc test/ubsan/TestCases/Misc/Inputs/returns-unexpectedly.c

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth added inline comments. Comment at: clangd/Protocol.h:26 #include "llvm/ADT/Optional.h" -#include +#include "llvm/Support/YAMLParser.h" #include malaperle wrote: > Nebiroth wrote: > > malaperle wrote: > > > revert this change? > > #include is not

LLVM buildmaster will be OFF today at 3 PM Pacific for maintenance

Galina Hello everyone, LLVM buildmaster will be OFF today at 3 PM Pacific for maintenance for about half an hour. Thank you for for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

xgsa updated this revision to Diff 125216. xgsa added a comment. Minor change: update default value of SmallVector of check names. https://reviews.llvm.org/D40671 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp docs/ReleaseNotes.rst docs/clang-tidy/index.rst

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:60 + // To be an interface, all base classes must be interfaces as well. + for (const auto : Node->bases()) { +const auto *Ty = I.getType()->getAs();

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

juliehockett updated this revision to Diff 125215. juliehockett marked 7 inline comments as done. juliehockett added a comment. Updating tests https://reviews.llvm.org/D40580 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

lebedev.ri added a comment. @alexfh any thoughts on this one? Repository: rL LLVM https://reviews.llvm.org/D36892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r319585 - [OPENMP] Emit `__tgt_target_teams` for all teams directives.

Author: abataev Date: Fri Dec 1 13:31:08 2017 New Revision: 319585 URL: http://llvm.org/viewvc/llvm-project?rev=319585=rev Log: [OPENMP] Emit `__tgt_target_teams` for all teams directives. Previously we emitted `__tgt_target_teams` only for standalone teams directives. This patch allows emit

[PATCH] D40682: [driver] Set the 'simulator' environment for Darwin when -msimulator-version-min is used

arphaman updated this revision to Diff 125214. arphaman marked an inline comment as done. arphaman added a comment. Add "-simulator" environment even when `-m*simulator-version-min` isn't used using the arch/OS heuristic. Repository: rC Clang https://reviews.llvm.org/D40682 Files:

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added inline comments. Comment at: clangd/Protocol.h:26 #include "llvm/ADT/Optional.h" -#include +#include "llvm/Support/YAMLParser.h" #include Nebiroth wrote: > malaperle wrote: > > revert this change? > #include is not needed. I meant removing

r319584 - [c++17] When deducing the type of a non-type template parameter from the type

Author: rsmith Date: Fri Dec 1 13:24:36 2017 New Revision: 319584 URL: http://llvm.org/viewvc/llvm-project?rev=319584=rev Log: [c++17] When deducing the type of a non-type template parameter from the type of its argument, perform function-to-pointer and array-to-pointer decay on the parameter

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

mibintc updated this revision to Diff 125211. mibintc added a comment. I changed the patch to enable _Float128 only as keyword in mode "nocxx" - this is the same mode being used by _Bool. I changed the test from .cpp to .c; I run check-all and saw only the usual suspects fail. What do you

Re: [clang-tools-extra] r319557 - [clangd] Fuzzy match scorer

Hello Sam, This commit broke one of our bots: http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/18908 . . . FAILED: tools/clang/tools/extra/clangd/CMakeFiles/clangDaemon.dir/FuzzyMatch.cpp.o /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS

[PATCH] D35894: [clangd] Code hover for Clangd

Nebiroth marked 9 inline comments as done. Nebiroth added inline comments. Comment at: clangd/Protocol.h:26 #include "llvm/ADT/Optional.h" -#include +#include "llvm/Support/YAMLParser.h" #include malaperle wrote: > revert this change? #include is not

[PATCH] D40748: [ThinLTO] Enable importing of aliases as copy of aliasee

tejohnson created this revision. Herald added a subscriber: inglorion. Clang side changes to go with LLVM change to import aliases as a copy of their aliasee. Simply refactor out some handling that is moved to LLVM for use elsewhere. Depends on https://reviews.llvm.org/D40747. Repository: rC

[PATCH] D40746: Correctly handle line directives without filenames that come first in the file

hans created this revision. The comment in LineTableInfo::AddLineNote says "An unspecified FilenameID means use the last filename if available, or the main source file otherwise.", but the second part of that sentence was never actually implemented. This lead to asserts when writing the line

[PATCH] D40044: [CodeGen] convert math libcalls/builtins to equivalent LLVM intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D40044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40743: Make rehash(0) work with ubsan's unsigned-integer-overflow.

danalbert created this revision. Repository: rCXX libc++ https://reviews.llvm.org/D40743 Files: include/__hash_table Index: include/__hash_table === --- include/__hash_table +++ include/__hash_table @@ -2136,7 +2136,7 @@

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

xgsa updated this revision to Diff 125190. xgsa added a comment. An item to release notes was added. Also I have added a paragraph about NOLINT to the main documentation page, because I suppose it's useful information and it's related to the feature. Please, let me know if it should be added

[PATCH] D34082: [Frontend] 'Show hotness' can be used with a sampling profile

anemet added a comment. Sorted these out in https://reviews.llvm.org/rL319576, https://reviews.llvm.org/rL319577 and https://reviews.llvm.org/rL319578. https://reviews.llvm.org/D34082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r319579 - [clangd] Define constants in the right namespace. NFC

Author: sammccall Date: Fri Dec 1 12:03:19 2017 New Revision: 319579 URL: http://llvm.org/viewvc/llvm-project?rev=319579=rev Log: [clangd] Define constants in the right namespace. NFC Modified: clang-tools-extra/trunk/clangd/FuzzyMatch.cpp Modified:

r319578 - Fix the second part of the broken comment from r306079

Author: anemet Date: Fri Dec 1 11:59:45 2017 New Revision: 319578 URL: http://llvm.org/viewvc/llvm-project?rev=319578=rev Log: Fix the second part of the broken comment from r306079 The driver-based test is still not identical to the front-end line, remove the hotness threshold from there and

r319577 - Fix opt-remark with hotness testcase for sample-based PGO

Author: anemet Date: Fri Dec 1 11:59:42 2017 New Revision: 319577 URL: http://llvm.org/viewvc/llvm-project?rev=319577=rev Log: Fix opt-remark with hotness testcase for sample-based PGO 1. Require hotness on all remark lines with -verify. 3. Fix the samplePGO file to actually produce hotness on

r319576 - Partially fix comment in test broken in r306079 and r306948

Author: anemet Date: Fri Dec 1 11:59:37 2017 New Revision: 319576 URL: http://llvm.org/viewvc/llvm-project?rev=319576=rev Log: Partially fix comment in test broken in r306079 and r306948 A RUN line was referring to the previous RUN line but a new test was added in between them. Just reorder

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 125189. Rakete added a comment. Updated error message, added a FixItHint + a rebase and friendly ping :) https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp

[PATCH] D40731: Integrate CHash into CLang

rsmith added a comment. We already have mechanisms to hash the AST. I'm strongly opposed to adding another one (and requiring AST modifications to update yet more such mechanisms). Please look at the work that Richard Trieu has been doing recently to create stable-across-TUs hashes of

[PATCH] D40739: Pass through --undefined to Wasm LLD

sbc100 added a comment. By the way, thank you for all these wasm patches! Repository: rC Clang https://reviews.llvm.org/D40739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40739: Pass through --undefined to Wasm LLD

sbc100 added a comment. Oh I see. lgtm. Do we need to update any tests? I see we won't have a wasm-ld.c test yet? We should add one? Repository: rC Clang https://reviews.llvm.org/D40739 ___ cfe-commits mailing list

[PATCH] D40731: Integrate CHash into CLang

Eugene.Zelenko added a comment. Please run Clang-format and Clang-tidy modernize over newly added code. Comment at: include/clang/AST/CHashVisitor.h:1 +#ifndef __CHASH_VISITOR +#define __CHASH_VISITOR Please loon onto other headers for inclusion guards style.

[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

arphaman added a comment. In https://reviews.llvm.org/D40562#941753, @ilya-biryukov wrote: > In https://reviews.llvm.org/D40562#941570, @arphaman wrote: > > > I'm not actually 100% sure, but I would imagine that this one of the > > reasons, yes. It would be nice to improve the cache to have

[PATCH] D40739: Pass through --undefined to Wasm LLD

ncw added a comment. I didn't know it existed either, and you're right it's odd that it doesn't appear in the help text... However it duly exists and is implemented in clang/lib/Driver/ToolChains/Gnu.cpp, without any note that it's deprecated. `man gcc` documents it. Repository: rC Clang

[PATCH] D34082: [Frontend] 'Show hotness' can be used with a sampling profile

anemet added a comment. Looks like it's a test problem. When I tweak the sample profile file according to https://clang.llvm.org/docs/UsersManual.html#sample-profile-text-format, I do get hotness on the remarks. https://reviews.llvm.org/D34082

[PATCH] D40740: [compiler-rt] Remove out of date comment

This revision was automatically updated to reflect the committed changes. Closed by commit rL319570: [compiler-rt] Remove out of date comment (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D40740 Files: compiler-rt/trunk/CMakeLists.txt Index:

[PATCH] D40687: [compiler-rt] Add install-*-stripped targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL319569: [compiler-rt] Add install-*-stripped targets (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D40687 Files: compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake

[PATCH] D40740: [compiler-rt] Remove out of date comment

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D40740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40687: [compiler-rt] Add install-*-stripped targets

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D40687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40739: Pass through --undefined to Wasm LLD

sbc100 added a comment. I'm a little confused by this. I was assuming you would do "-Wl,-u,foo" or "-Xlinker".I wasn't aware -u was a valid compiler flag itself. It doesn't show up in --help. Repository: rC Clang https://reviews.llvm.org/D40739

[PATCH] D40740: [compiler-rt] Remove out of date comment

smeenai created this revision. Herald added subscribers: mgorny, dberris. Per beanz, building compiler-rt standalone is a pretty important use case, so the comment is very out of date. https://reviews.llvm.org/D40740 Files: CMakeLists.txt Index: CMakeLists.txt

[PATCH] D40687: [compiler-rt] Add install-*-stripped targets

smeenai updated this revision to Diff 125180. smeenai retitled this revision from "[compiler-rt] Switch to add_llvm_install_targets" to "[compiler-rt] Add install-*-stripped targets". smeenai edited the summary of this revision. smeenai added a comment. Add targets manually

[PATCH] D40738: Don't use Wasm function sections for more than one function

sunfish accepted this revision. sunfish added a comment. This revision is now accepted and ready to land. I think that was copied from LinuxTargetInfo before we figured out our current object file strategy. On native platforms, it's an icache optimization, because startup functions are all

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

lebedev.ri updated this revision to Diff 125178. lebedev.ri changed the repository for this revision from rL LLVM to rCTE Clang Tools Extra. lebedev.ri added a comment. Rebased. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D36836 Files: LICENSE.TXT

[PATCH] D40687: [compiler-rt] Switch to add_llvm_install_targets

beanz added a comment. Yes, that comment is very out of date. The compiler-rt standalone build is essential to many of the users. It is quite common to build and use compiler-rt without LLVM (like sanitizer support in gcc). https://reviews.llvm.org/D40687

[PATCH] D40687: [compiler-rt] Switch to add_llvm_install_targets

smeenai added a comment. Ah, that's a bummer. compiler-rt's CMakeLists has this big shiny comment up top: # This build assumes that CompilerRT is checked out into the # 'projects/compiler-rt' or 'runtimes/compiler-rt' inside of an LLVM tree. # Standalone build system for CompilerRT is not

[PATCH] D40739: Pass through --undefined to Wasm LLD

ncw updated this revision to Diff 125176. ncw added a comment. (D'oh, more trouble with arcane commands getting diffs into phabricator... sorry for the spam.) Repository: rC Clang https://reviews.llvm.org/D40739 Files: lib/Driver/ToolChains/WebAssembly.cpp Index:

[PATCH] D40739: Pass through --undefined to Wasm LLD

ncw created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google, dschuff, jfb, klimek. This is a follow-on to https://reviews.llvm.org/D40724 (Wasm entrypoint changes #1, add `--undefined` argument to LLD). Repository: rC Clang

[PATCH] D34082: [Frontend] 'Show hotness' can be used with a sampling profile

davide added a comment. In https://reviews.llvm.org/D34082#942420, @anemet wrote: > @modocache, @davide, are you guys sure this feature is working? The test > does not actually check whether hotness is included in the remarks and when I > run it manually they are missing. In

[PATCH] D40738: Don't use Wasm function sections for more than one function

ncw created this revision. Herald added subscribers: cfe-commits, aheejin, sbc100, dschuff, jfb. Fixes Bugzilla https://bugs.llvm.org/show_bug.cgi?id=35467 If a Wasm function section is created with more than one symbol, WasmObjectWriter fails with the following message: "function sections must

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:35 + StringRef Name = Node->getIdentifier()->getName(); + auto Pair = InterfaceMap.find(Name); + if (Pair == InterfaceMap.end()) Eugene.Zelenko wrote: >

[PATCH] D34082: [Frontend] 'Show hotness' can be used with a sampling profile

anemet added a subscriber: davide. anemet added a comment. @modocache, @davide, are you guys sure this feature is working? The test does not actually check whether hotness is included in the remarks and when I run it manually they are missing. In https://reviews.llvm.org/D40678, I am

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

Eugene.Zelenko added inline comments. Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:35 + StringRef Name = Node->getIdentifier()->getName(); + auto Pair = InterfaceMap.find(Name); + if (Pair == InterfaceMap.end()) aaron.ballman wrote: > Don't use

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

JonasToth created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. The original check did break the green buildbot in the sanitizer build. It took a while to redroduce and understand the issue. There occured a stackoverflow while parsing the AST. The testcase with 256

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

mibintc abandoned this revision. mibintc added a comment. Thanks for all your reviews https://reviews.llvm.org/D40673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/MultipleInheritanceCheck.cpp:35 + StringRef Name = Node->getIdentifier()->getName(); + auto Pair = InterfaceMap.find(Name); + if (Pair == InterfaceMap.end()) Don't use `auto` as the type is

[PATCH] D40687: [compiler-rt] Switch to add_llvm_install_targets

beanz added a comment. This change isn't safe. Compiler-RT is buildable without LLVM's modules as long as you disable the tests, so you can't use an AddLLVM function inside AddCompilerRT unless it is only used when tests are disabled. https://reviews.llvm.org/D40687

r319560 - [OPENMP] Do not allow variables to be first|last-privates in

Author: abataev Date: Fri Dec 1 09:40:15 2017 New Revision: 319560 URL: http://llvm.org/viewvc/llvm-project?rev=319560=rev Log: [OPENMP] Do not allow variables to be first|last-privates in distribute directives. OpenMP standard does not allow to mark the variables as firstprivate and

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

aaron.ballman added a comment. This feature should probably be mentioned in the release notes. https://reviews.llvm.org/D40671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr

a.sidorin added a comment. Hello Peter. Please set the dependencies for the patch - it cannot be applied clearly and even if I add ImportTemplateArgumentListInfo, tests still fail - looks like FunctionTemplateDecl patch should be applied first. https://reviews.llvm.org/D38845

[clang-tools-extra] r319557 - [clangd] Fuzzy match scorer

Author: sammccall Date: Fri Dec 1 09:08:02 2017 New Revision: 319557 URL: http://llvm.org/viewvc/llvm-project?rev=319557=rev Log: [clangd] Fuzzy match scorer Summary: This will be used for rescoring code completion results based on partial identifiers. Short-term use: - we want to limit the

[PATCH] D40625: Harmonizing attribute GNU/C++ spellings

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:602 def AnalyzerNoReturn : InheritableAttr { - let Spellings = [GNU<"analyzer_noreturn">]; + let Spellings = [Clang<"analyzer_noreturn">]; let Documentation = [Undocumented];

r319555 - Disallow a cleanup attribute from appertaining to a parameter (the attribute only appertains to local variables and is silently a noop on parameters). This repurposes the unused (and syntact

Author: aaronballman Date: Fri Dec 1 08:53:49 2017 New Revision: 319555 URL: http://llvm.org/viewvc/llvm-project?rev=319555=rev Log: Disallow a cleanup attribute from appertaining to a parameter (the attribute only appertains to local variables and is silently a noop on parameters). This

[PATCH] D15406: Add warning for attribute-cleanup on function parameter.

aaron.ballman closed this revision. aaron.ballman added a comment. I committed a different fix for this in r319555. https://reviews.llvm.org/D15406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39279: Stringizing raw string literals containing newline

jkorous-apple added a comment. Thank you for your patience @twoh and sorry for the delay. I have few suggestions about doxygen annotations but otherwise LGTM. Comment at: include/clang/Lex/Lexer.h:247 + /// add surrounding ""'s to the string. If Charify is true, this escapes

[PATCH] D40720: No -fsanitize=function warning when calling noexcept function through non-noexcept pointer in C++17

sberg updated this revision to Diff 125152. sberg added a comment. (Diff 125121 had accidentally contained a spurious "}". Fixed that now.) https://reviews.llvm.org/D40720 Files: clang/lib/CodeGen/CGExpr.cpp compiler-rt/lib/ubsan/ubsan_handlers.cc compiler-rt/lib/ubsan/ubsan_handlers.h

[clang-tools-extra] r319552 - [clangd] Filter completion results by fuzzy-matching identifiers.

Author: sammccall Date: Fri Dec 1 08:35:50 2017 New Revision: 319552 URL: http://llvm.org/viewvc/llvm-project?rev=319552=rev Log: [clangd] Filter completion results by fuzzy-matching identifiers. Summary: This allows us to limit the number of results we return and still allow them to be

[PATCH] D39882: [clangd] Filter completion results by fuzzy-matching identifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL319552: [clangd] Filter completion results by fuzzy-matching identifiers. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D39882?vs=125009=125155#toc Repository: rL LLVM

[PATCH] D39882: [clangd] Filter completion results by fuzzy-matching identifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE319552: [clangd] Filter completion results by fuzzy-matching identifiers. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D39882?vs=125009=125154#toc Repository: rL LLVM

[PATCH] D40660: Enable auto-linking on Windows

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. I think it would make sense for this change to also have the conditional for the static C++ library selection. Basically something like #if defined(_LIBCPP_ABI_MICROSOFT) &&

[PATCH] D40733: [clangd] GlobalCompilationDatabase interface changes

sammccall created this revision. Herald added subscribers: cfe-commits, klimek. - GlobalCompilationDatabase now returns a single command (that's all we use) - fallback flags are now part of the GlobalCompilationDatabase. There's a default implementation that they can optionally customize. - this

[PATCH] D39882: [clangd] Filter completion results by fuzzy-matching identifiers.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40625: Harmonizing attribute GNU/C++ spellings

dcoughlin added a subscriber: alexfh. dcoughlin added inline comments. Comment at: include/clang/Basic/Attr.td:602 def AnalyzerNoReturn : InheritableAttr { - let Spellings = [GNU<"analyzer_noreturn">]; + let Spellings = [Clang<"analyzer_noreturn">]; let Documentation =

[PATCH] D40731: Integrate CHash into CLang

stettberger created this revision. Herald added subscribers: cfe-commits, aprantl, mgorny. The CHashVisitor can be used to determine a unique hash for a translation unit. The hash is stable across compiler invocations and if two translation units have the same hash, the resulting object file is

[clang-tools-extra] r319460 - add new check to find NSError init invocation

Author: wizard Date: Thu Nov 30 11:05:09 2017 New Revision: 319460 URL: http://llvm.org/viewvc/llvm-project?rev=319460=rev Log: add new check to find NSError init invocation Subscribers: klimek, mgorny, cfe-commits Differential Revision: https://reviews.llvm.org/D40528 Added:

  1   2   >