xgsa added a comment.
So can this patch be submitted? Should I do something to make it happen?
https://reviews.llvm.org/D40671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JVApen added a comment.
How does this check deal with atomic members?
struct A {
std:: atomic a;
void f() const { while (a); }
};
https://reviews.llvm.org/D40937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: lichray
Date: Wed Dec 6 23:03:15 2017
New Revision: 320011
URL: http://llvm.org/viewvc/llvm-project?rev=320011=rev
Log:
Allow conditions to be decomposed with structured bindings
Summary:
This feature was discussed but not yet proposed. It allows a structured
binding to appear as a
This revision was automatically updated to reflect the committed changes.
Closed by commit rC320011: Allow conditions to be decomposed with structured
bindings (authored by lichray).
Changed prior to commit:
https://reviews.llvm.org/D39284?vs=125665=125892#toc
Repository:
rC Clang
Author: lichray
Date: Wed Dec 6 22:27:58 2017
New Revision: 320008
URL: http://llvm.org/viewvc/llvm-project?rev=320008=rev
Log:
Test commit access
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Sema/SemaType.cpp
URL:
dylanmckay updated this revision to Diff 125887.
dylanmckay added a comment.
Herald added a subscriber: cfe-commits.
- Remove the switch table stuff for a later patch
- Rebased on top of trunk
Repository:
rC Clang
https://reviews.llvm.org/D37057
Files:
lib/CodeGen/CGBlocks.cpp
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/misc/InfiniteLoopCheck.cpp:94
+
+std::unique_ptr createSequence(Stmt *FunctionBody,
+ ASTContext ) {
Missing static?
Comment at:
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D40937#947658, @szepet wrote:
> Other note: If somebody would came up with an approach which can benefit from
> the symbolic execution, these solutions could still live happily in the
> different tools eg. UseAfterMove (tidy) and
rjmccall added reviewers: rnk, majnemer.
rjmccall added a comment.
Reid, David, do you have a recommendation about the right way to support
non-MS-supported CCs here?
Repository:
rC Clang
https://reviews.llvm.org/D40929
___
cfe-commits mailing
rjmccall added inline comments.
Comment at: cfe/trunk/lib/CodeGen/CGCall.cpp:1238
+ Address Casted = CGF.Builder.CreateBitCast(Tmp, CGF.AllocaInt8PtrTy);
+ Address SrcCasted = CGF.Builder.CreateBitCast(Src, CGF.AllocaInt8PtrTy);
CGF.Builder.CreateMemCpy(Casted, SrcCasted,
vsk created this revision.
Herald added subscribers: dberris, kubamracek.
This is a test update for the clang change in https://reviews.llvm.org/D40940
https://reviews.llvm.org/D40941
Files:
test/ubsan/TestCases/Misc/bounds.cpp
Index: test/ubsan/TestCases/Misc/bounds.cpp
vsk created this revision.
Herald added a reviewer: george.burgess.iv.
Teach UBSan's bounds check to opportunistically use pass_object_size
information to check array accesses.
rdar://33272922
https://reviews.llvm.org/D40940
Files:
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM
please give at least Aleksey a chance to review as well.
https://reviews.llvm.org/D40936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ added a comment.
> I accidentally noticed that problem
The actual problem was that `RegionStore` was unable to retrieve the binding to
such `ElementRegion` (in case of this example, `5 S32b`). There may be more
problems with such regions. But at the same time i believe that the very idea
szepet added a comment.
Hi Eugen!
Good question, probably should have detailed it in the description.
This matcher based solution would not gain much benefit from the symbolic
execution provided information. (I mean, it would mean a much different type of
check on the states.)
The main
szepet updated this revision to Diff 125870.
szepet marked an inline comment as done.
szepet added a comment.
Updated the wording in the docs.
https://reviews.llvm.org/D40937
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/InfiniteLoopCheck.cpp
clang-tidy/misc/InfiniteLoopCheck.h
NoQ created this revision.
Herald added subscribers: cfe-commits, rnkovacs.
Add an assertion that `ElementRegion`'s element type is not void.
Fix two violations of this rule that shown up on four of our existing test
files.
I accidentally noticed that problem when i was looking at how
kcc created this revision.
Herald added a subscriber: cfe-commits.
- use more readable name
- document the hwasan attribute
Repository:
rC Clang
https://reviews.llvm.org/D40938
Files:
docs/HardwareAssistedAddressSanitizerDesign.rst
Index: docs/HardwareAssistedAddressSanitizerDesign.rst
Eugene.Zelenko added a comment.
Does it really belong to Clang-tidy or Clang Analyzer is better place because
of path-ensitivity?
Please rebase from trunk.
General note: CLang-tidy use //check// in terminology, not //checker//.
Comment at: docs/ReleaseNotes.rst:63
+
+ The
szepet created this revision.
Herald added subscribers: rnkovacs, baloghadamsoftware, whisperity, mgorny.
The checker aims to find loops where none of the condition variables are
updated in the body.
In this version it only works on integer types but the final aim is to make it
work for
This revision was automatically updated to reflect the committed changes.
Closed by commit rL32: CodeGen: Fix invalid bitcasts for memcpy (authored
by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D40806?vs=125417=125863#toc
Repository:
rL LLVM
Author: yaxunl
Date: Wed Dec 6 17:39:52 2017
New Revision: 32
URL: http://llvm.org/viewvc/llvm-project?rev=32=rev
Log:
CodeGen: Fix invalid bitcasts for memcpy
CreateCoercedLoad/CreateCoercedStore assumes pointer argument of
memcpy is in addr space 0, which is not correct and causes
eugenis created this revision.
Herald added subscribers: javed.absar, srhines.
Driver, frontend and LLVM codegen for HWASan.
A clone of ASan, basically.
https://reviews.llvm.org/D40936
Files:
clang/include/clang/Basic/Sanitizers.def
clang/include/clang/Driver/SanitizerArgs.h
NoQ updated this revision to Diff 125850.
NoQ added a comment.
Replaced the live expression hack with a slightly better approach. It doesn't
update the live variables analysis to take `CFGNewAllocator` into account, but
at least tests now pass.
In order to keep the return value produced by the
troughton updated this revision to Diff 125847.
troughton added a comment.
Add back a mistakenly removed default case.
Repository:
rC Clang
https://reviews.llvm.org/D40929
Files:
lib/AST/MicrosoftMangle.cpp
Index: lib/AST/MicrosoftMangle.cpp
Author: stl_msft
Date: Wed Dec 6 16:50:23 2017
New Revision: 319994
URL: http://llvm.org/viewvc/llvm-project?rev=319994=rev
Log:
[libcxx] [test] Strip trailing whitespace. NFC.
Modified:
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D38110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
smeenai added a comment.
Patch is missing context.
Comment at: lib/AST/MicrosoftMangle.cpp:2133
+ llvm::errs() << "Unsupported CC for mangling: " << CC << ".\n";
case CC_Win64:
case CC_X86_64SysV:
You still need the default label, right?
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319992: Remove old concepts parsing code (authored by
hubert.reinterpretcast).
Changed prior to commit:
https://reviews.llvm.org/D40380?vs=124032=125844#toc
Repository:
rC Clang
Author: hubert.reinterpretcast
Date: Wed Dec 6 16:34:20 2017
New Revision: 319992
URL: http://llvm.org/viewvc/llvm-project?rev=319992=rev
Log:
Remove old concepts parsing code
Summary:
This is so we can implement concepts per P0734R0. Relevant failing test
cases are disabled.
Reviewers:
troughton created this revision.
troughton added a project: clang.
Herald added a subscriber: cfe-commits.
Following discussion on the [[
https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20171204/006123.html |
swift-dev mailing list] and on a pull request for swift-clang
eandrews created this revision.
Currently clang does not emit unused static constants declared globally. Local
static constants are emitted by default. -fkeep-static-consts can be used to
emit static constants declared globally even if they are not used.
This could be useful for producing
Author: eugenezelenko
Date: Wed Dec 6 15:18:41 2017
New Revision: 319986
URL: http://llvm.org/viewvc/llvm-project?rev=319986=rev
Log:
[Lex] Fix some Clang-tidy modernize and Include What You Use warnings; other
minor fixes (NFC).
Modified:
cfe/trunk/include/clang/Lex/HeaderSearch.h
Author: smeenai
Date: Wed Dec 6 15:02:00 2017
New Revision: 319983
URL: http://llvm.org/viewvc/llvm-project?rev=319983=rev
Log:
[clang] Add PRIVATE to target_link_libraries
Another follow-up to r319840. I'd done a test configure with
LLVM_BUILD_STATIC, so I'm not sure why this didn't show up in
compnerd accepted this revision.
compnerd added a comment.
LGTM if @sdardis is good with it
https://reviews.llvm.org/D38110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D40818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCXX libc++
https://reviews.llvm.org/D40814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D40815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D40637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Nebiroth updated this revision to Diff 125815.
Nebiroth added a comment.
Reverted formatting changes to ASTUnit
Repository:
rC Clang
https://reviews.llvm.org/D39375
Files:
include/clang/Frontend/PrecompiledPreamble.h
lib/Frontend/ASTUnit.cpp
lib/Frontend/PrecompiledPreamble.cpp
Nebiroth updated this revision to Diff 125814.
Nebiroth added a comment.
Fixed re-added include
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D38639
Files:
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/Protocol.h
mattd added a comment.
ping
https://reviews.llvm.org/D40398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Nebiroth updated this revision to Diff 125813.
Nebiroth added a comment.
Herald added a subscriber: klimek.
Using PPCallbacks interface to find non-preamble includes
Created inner class to store vectors in to find locations
Refactored methods to remove some unnecessary parameters
Refactored Unit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319959: [libc++] Create install-stripped targets (authored
by smeenai).
Repository:
rL LLVM
https://reviews.llvm.org/D40680
Files:
libcxx/trunk/include/CMakeLists.txt
Author: smeenai
Date: Wed Dec 6 13:03:42 2017
New Revision: 319959
URL: http://llvm.org/viewvc/llvm-project?rev=319959=rev
Log:
[libc++] Create install-stripped targets
LLVM is gaining install-*-stripped targets to perform stripped installs,
and in order for this to be useful for
ioeric added a comment.
Hi Marc, the patch is not ready for review yet. I am still cleaning up the
prototype and will let you know when it's ready for review.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40548
___
cfe-commits
erichkeane updated this revision to Diff 125779.
erichkeane marked 3 inline comments as done.
erichkeane added a comment.
Fix all rsmith's and craig's fixes, AFAIK.
https://reviews.llvm.org/D40819
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
Author: smeenai
Date: Wed Dec 6 12:05:42 2017
New Revision: 319950
URL: http://llvm.org/viewvc/llvm-project?rev=319950=rev
Log:
[clang] Use PRIVATE in target_link_libraries
I'd missed this one in r319840 because I hadn't been configuring with an
order file before.
Modified:
erichkeane marked 14 inline comments as done.
erichkeane added a comment.
Incoming patch!
Comment at: include/clang/Basic/Attr.td:1809
bool DuplicateArchitecture = false;
+ bool operator ==(const ParsedTargetAttr ) {
+return DuplicateArchitecture ==
rsmith added a comment.
In https://reviews.llvm.org/D40567#943747, @sepavloff wrote:
> Although code generation (in LTO compilation) might be unaffected by this
> distortions, other applications of IR linking suffer from it. It does not
> allow to implement some checks, validation techniques
Author: morehouse
Date: Wed Dec 6 11:52:40 2017
New Revision: 319948
URL: http://llvm.org/viewvc/llvm-project?rev=319948=rev
Log:
[CMake] Use PRIVATE in target_link_libraries for fuzzers.
Several fuzzers were missed by r319840.
Modified:
cfe/trunk/tools/clang-format/fuzzer/CMakeLists.txt
Author: morehouse
Date: Wed Dec 6 11:52:40 2017
New Revision: 319948
URL: http://llvm.org/viewvc/llvm-project?rev=319948=rev
Log:
[CMake] Use PRIVATE in target_link_libraries for fuzzers.
Several fuzzers were missed by r319840.
Modified:
clang-tools-extra/trunk/clangd/fuzzer/CMakeLists.txt
ioeric added a comment.
In https://reviews.llvm.org/D40562#942521, @arphaman wrote:
> In https://reviews.llvm.org/D40562#941753, @ilya-biryukov wrote:
>
> > In https://reviews.llvm.org/D40562#941570, @arphaman wrote:
> >
> > > I'm not actually 100% sure, but I would imagine that this one of the
ioeric updated this revision to Diff 125777.
ioeric added a comment.
- Add a new code-completion option IncludeNamespaceLevelDecls. For now, I only
restrict this option work for qualified id completion to reduce the impact.
Repository:
rC Clang
https://reviews.llvm.org/D40562
Files:
ahatanak added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:442
Options.DebuggerTuning = CodeGenOpts.getDebuggerTuning();
+ Options.EnableStackProbe = CodeGenOpts.StackProbe;
aemerson wrote:
> ahatanak wrote:
> > Is there a reason you can't use
lichray added a comment.
Can someone commit this please? One more patch then I'll go get a commit bit.
Repository:
rC Clang
https://reviews.llvm.org/D39284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rsmith
Date: Wed Dec 6 11:23:19 2017
New Revision: 319942
URL: http://llvm.org/viewvc/llvm-project?rev=319942=rev
Log:
Delete special-case "out-of-range" handling for bools, and just use the normal
codepath plus the new "minimum / maximum value of type" diagnostic to get the
same effect.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319931: Fix PR35542: Correct adjusting of private reduction
variable (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D40911?vs=125768=125770#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319931: Fix PR35542: Correct adjusting of private reduction
variable (authored by Hahnfeld).
Repository:
rC Clang
https://reviews.llvm.org/D40911
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
Author: hahnfeld
Date: Wed Dec 6 11:15:28 2017
New Revision: 319931
URL: http://llvm.org/viewvc/llvm-project?rev=319931=rev
Log:
Fix PR35542: Correct adjusting of private reduction variable
The adjustment is calculated with CreatePtrDiff() which returns
the difference in (base) elements. This
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D40911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Hahnfeld updated this revision to Diff 125768.
Hahnfeld marked 3 inline comments as done.
Hahnfeld added a comment.
Get type from `Address`.
https://reviews.llvm.org/D40911
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/for_reduction_codegen.cpp
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1110
+PrivateAddr.getPointer(),
+SharedAddresses[N].first.getPointer()->getType());
+llvm::Value *Ptr = CGF.Builder.CreateGEP(PrivatePointer, Adjustment);
Hahnfeld added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1110
+PrivateAddr.getPointer(),
+SharedAddresses[N].first.getPointer()->getType());
+llvm::Value *Ptr = CGF.Builder.CreateGEP(PrivatePointer, Adjustment);
hokein added a comment.
In https://reviews.llvm.org/D40897#946708, @malaperle wrote:
> Hi! Have you looked into https://reviews.llvm.org/D40548 ? Maybe we need to
> coordinate the two a bit.
Hi Marc! Thanks for the input!
Yeah, Eric and I are working closely on a prototype of global code
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1110
+PrivateAddr.getPointer(),
+SharedAddresses[N].first.getPointer()->getType());
+llvm::Value *Ptr = CGF.Builder.CreateGEP(PrivatePointer, Adjustment);
Hahnfeld created this revision.
Herald added a subscriber: cfe-commits.
The adjustment is calculated with CreatePtrDiff() which returns
the difference in (base) elements. This is passed to CreateGEP()
so make sure that the GEP base has the correct pointer type:
It needs to be a pointer to the
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This made Clang start warning about unsigned vs enum compares on Windows.
$ echo 'enum E { foo }; bool f(unsigned a, E b) { return a == b; }' |
bin/clang -Wsign-compare -c -x c++ - -target i686-pc-win32
:1:52: warning: comparison of integers of different signs:
'unsigned int' and 'E'
Thanks!
On Wed, Dec 6, 2017 at 2:12 AM Sven van Haastregt via Phabricator <
revi...@reviews.llvm.org> wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rC319883: [OpenCL] Fix layering violation by
> getOpenCLTypeAddrSpace (authored by svenvh).
sepavloff updated this revision to Diff 125761.
sepavloff added a comment.
Updated patch
- old type names are generated always if --ir-type-names is not specified,
- added new value of --ir-type-names, none, to suppress type names,
- value of --ir-type-names is stored in module properties.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319909: [NVPTX,CUDA] Added llvm.nvvm.fns intrinsic and
matching __nvvm_fns builtin in… (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D40872?vs=125649=125757#toc
Repository:
rL
Author: tra
Date: Wed Dec 6 09:50:05 2017
New Revision: 319909
URL: http://llvm.org/viewvc/llvm-project?rev=319909=rev
Log:
[NVPTX,CUDA] Added llvm.nvvm.fns intrinsic and matching __nvvm_fns builtin in
clang.
Differential Revision: https://reviews.llvm.org/D40872
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319908: [CUDA] Added overloads for '[unsigned] long'
variants of shfl builtins. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D40871?vs=125648=125756#toc
Repository:
rC Clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319908: [CUDA] Added overloads for '[unsigned] long'
variants of shfl builtins. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D40871?vs=125648=125755#toc
Repository:
rL LLVM
Author: tra
Date: Wed Dec 6 09:40:35 2017
New Revision: 319908
URL: http://llvm.org/viewvc/llvm-project?rev=319908=rev
Log:
[CUDA] Added overloads for '[unsigned] long' variants of shfl builtins.
Differential Revision: https://reviews.llvm.org/D40871
Modified:
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rC Clang
https://reviews.llvm.org/D40909
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
lib/Format/Format.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319904: Stringizing raw string literals containing newline
(authored by twoh).
Changed prior to commit:
https://reviews.llvm.org/D39279?vs=125564=125745#toc
Repository:
rC Clang
Author: twoh
Date: Wed Dec 6 09:00:53 2017
New Revision: 319904
URL: http://llvm.org/viewvc/llvm-project?rev=319904=rev
Log:
Stringizing raw string literals containing newline
Summary: This patch implements 4.3 of
http://open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4220.pdf. If a raw string
spatel added a comment.
Ping * 3.
https://reviews.llvm.org/D39812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D40895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
v.g.vassilev updated this revision to Diff 125738.
v.g.vassilev added a comment.
Fix preexisting comment typo.
https://reviews.llvm.org/D40901
Files:
include/clang/AST/DeclTemplate.h
lib/AST/DeclTemplate.cpp
Index: lib/AST/DeclTemplate.cpp
sammccall added a comment.
Mostly nits - throughout there's going to be lots of judgement calls about
where to propagate context and where not.
No need to get all those "exactly right", but trying to get a feel for what
these answers are likely to be.
Most of the interesting stuff is around
malaperle added a comment.
Hi! Have you looked into https://reviews.llvm.org/D40548 ? Maybe we need to
coordinate the two a bit.
Comment at: clangd/Symbol.h:37
+// The class presents a C++ symbol, e.g. class, function.
+struct Symbol {
+ // The symbol identifier, using USR.
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D40806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added inline comments.
Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:30
+class D : public B, public C {
+ // CHECK-MESSAGES: [[@LINE-1]]:1: warning: virtual inheritance is disallowed
[fuchsia-virtual-inheritance]
+ // CHECK-NEXT: class C : public
ro created this revision.
ro added a project: Sanitizers.
Herald added subscribers: fedor.sergeev, jyknight.
This patch (on top of https://reviews.llvm.org/D35755) provides the clang side
necessary
to enable the Solaris port of the sanitizers implemented by
https://reviews.llvm.org/D40898,
v.g.vassilev created this revision.
Unify the loading of lazy template specializations across class, function
and variable templates.
Repository:
rL LLVM
https://reviews.llvm.org/D40901
Files:
include/clang/AST/DeclTemplate.h
lib/AST/DeclTemplate.cpp
Index: lib/AST/DeclTemplate.cpp
samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.
Great, LGTM, many thanks for doing this!
https://reviews.llvm.org/D40888
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
malaperle added a comment.
In https://reviews.llvm.org/D40884#946630, @ioeric wrote:
> In https://reviews.llvm.org/D40884#946506, @malaperle wrote:
>
> > You can get the preprocessor from the ASTContext, no?
>
>
> I don't think `ASTContext` contains preprocessor information.
My bad, it was the
ioeric added a comment.
In https://reviews.llvm.org/D40884#946506, @malaperle wrote:
> You can get the preprocessor from the ASTContext, no?
I don't think `ASTContext` contains preprocessor information.
Repository:
rC Clang
https://reviews.llvm.org/D40884
gerazo added a comment.
The code modifications are coming soon (after doing some extensive testing) for
the scan-build part.
Comment at: tools/scan-build-py/libscanbuild/analyze.py:223
+ctu_config = get_ctu_config(args)
+if ctu_config.collect:
+
ioeric added inline comments.
Comment at: clangd/Context.h:63
+/// used as parents for some other Contexts.
+class Context {
+public:
sammccall wrote:
> I think we should strongly consider calling the class Ctx over Context. It's
> going to appear in many
hokein created this revision.
Herald added subscribers: mgorny, klimek.
- The "Symbol" class represents a C++ symbol in the codebase, containing all
the information of a C++ symbol needed by clangd. clangd will use it in
clangd's AST/dynamic index and global/static index (code completion and
Typz added a comment.
> Ok, that's probably where our different opinions come from - I would want a
> macro to be formatted to reflect how it's implemented, because otherwise I'm
> going to be surprised when I look at the implementation, and I consider
> surprises to be something to avoid in
klimek added inline comments.
Comment at: docs/RefactoringActionTutorial.rst:7
+
+ This tutorial talks about a work-in-progress library in Clang.
+ Some of the described features might not be available yet in trunk, but
should
hokein wrote:
> I'm a bit
sammccall added a comment.
There's a couple of points where we might be a bit stuck on complexity vs X
tradeoffs (map + contextbuilder, and some of the convenience APIs).
Just want to mention: if I find these things complex, it doesn't mean I think
they're bad code, or even that you should
Author: abataev
Date: Wed Dec 6 07:04:36 2017
New Revision: 319897
URL: http://llvm.org/viewvc/llvm-project?rev=319897=rev
Log:
[OPENMP] Improve error message for mapping union members.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
AndersRonnholm abandoned this revision.
AndersRonnholm added a comment.
Fixed by https://reviews.llvm.org/rL319021. At least for c/c++ not sure if it
handles objective-c.
Repository:
rL LLVM
https://reviews.llvm.org/D36672
___
cfe-commits
aemerson added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:442
Options.DebuggerTuning = CodeGenOpts.getDebuggerTuning();
+ Options.EnableStackProbe = CodeGenOpts.StackProbe;
ahatanak wrote:
> Is there a reason you can't use function attributes
1 - 100 of 121 matches
Mail list logo
