gerazo added inline comments.
Comment at: tools/scan-build-py/libscanbuild/analyze.py:44
+CTU_FUNCTION_MAP_FILENAME = 'externalFnMap.txt'
+CTU_TEMP_FNMAP_FOLDER = 'tmpExternalFnMaps'
george.karpenkov wrote:
> gerazo wrote:
> > george.karpenkov wrote:
> > >
Author: abeserminji
Date: Mon Dec 11 03:29:17 2017
New Revision: 320351
URL: http://llvm.org/viewvc/llvm-project?rev=320351=rev
Log:
[mips] Removal of microMIPS64R6
microMIPS64R6 is removed from backend, and therefore frontend
will show an error when target is microMIPS64R6.
This is Clang part
nik added inline comments.
Comment at: include/clang/Frontend/ASTUnit.h:196
+ /// \brief Counter indicating how often the preamble was build in total.
+ unsigned PreambleCounter;
+
Any better name for this one? Otherwise I would suggest renaming
nik updated this revision to Diff 126353.
nik marked 2 inline comments as done.
nik added a comment.
Addressed Ilya's comments.
Repository:
rC Clang
https://reviews.llvm.org/D41005
Files:
include/clang/Frontend/ASTUnit.h
lib/Frontend/ASTUnit.cpp
lib/Frontend/PrecompiledPreamble.cpp
nik marked 2 inline comments as done.
nik added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:109
+ std::chrono::steady_clock::time_point getCreationTimePoint() const {
+return CreationTimePoint;
ilya-biryukov wrote:
> Having
nik added a comment.
Thanks for the review. Please submit as I don't have the permissions for this.
https://reviews.llvm.org/D40561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D40968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
seaneveson updated this revision to Diff 126350.
seaneveson added a comment.
Improve tests.
https://reviews.llvm.org/D40712
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
lib/Driver/ToolChains/Clang.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320363: [libcxx] Define istream_iterator equality comparison
operators out-of-line (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D40415?vs=124155=126349#toc
Repository:
Author: rogfer01
Date: Mon Dec 11 05:54:58 2017
New Revision: 320363
URL: http://llvm.org/viewvc/llvm-project?rev=320363=rev
Log:
[libcxx] Define istream_iterator equality comparison operators out-of-line
Currently libc++ defines operator== and operator!= as friend functions in the
definition of
aaron.ballman added a comment.
I think that it would be more appropriate to fix this in Clang rather than
libc++. For instance, we don't want libstdc++ to have to silence our same
diagnostic here.
Repository:
rCXX libc++
https://reviews.llvm.org/D41064
ilya-biryukov updated this revision to Diff 126346.
ilya-biryukov added a comment.
- Removed buildCtx(). Now Contexts can only be created using emptyCtx().derive()
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D40561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:92
+ ContextBuilder derive() const &;
+ ContextBuilder derive() const &&;
+
sammccall wrote:
> `&&`, not `const&&` :-)
>
> Maybe add a trailing `//takes ownership`
Right. Copy-paste is gonna
ilya-biryukov updated this revision to Diff 126345.
ilya-biryukov added a comment.
- Use `derive() &&` instead of `derive() const &&`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
clangd/Context.h
ilya-biryukov updated this revision to Diff 126340.
ilya-biryukov added a comment.
- Remove mention of globalLogger() from the comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:220
- // Note that std::future from this cleanup action is ignored.
- scheduleCancelRebuild(std::move(Recreated.RemovedFile));
+ // Note that std::future from this cleanup action.
+ //
dim created this revision.
When compiling and/or with -Wsystem-headers, in
C++14 or higher mode, clang produces warnings about the literal suffixes
defined in them, e.g.:
$ cat test.cpp
#include
$ clang -std=c++14 -Wsystem-headers -Wall -Wextra -c test.cpp
In file included from
ilya-biryukov updated this revision to Diff 126337.
ilya-biryukov marked 15 inline comments as done.
ilya-biryukov added a comment.
- Copy Context in forceReparse's call to scheduleCancelRebuild.
- Renamed Key<> for ID, Out and Span.
- Removed the FIXME
- Got rid of getExisting(RequestSpan)
-
sammccall added a comment.
Thanks for the changes. I don't think `TypedValueMap`/`ContextBuilder` pull
their weight, but let's get another opinion on this.
Comment at: clangd/Context.h:65
+ Context *Parent;
+ TypedValueMap Data;
+};
ilya-biryukov wrote:
>
sammccall added a comment.
Thanks for the restructuring? I want to take another pass today, but wanted to
mention some SymbolID things.
Comment at: clangd/Symbol.h:37
+// The class presents a C++ symbol, e.g. class, function.
+struct Symbol {
+ // The symbol identifier,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320351: [mips] Removal of microMIPS64R6 (authored by
abeserminji).
Changed prior to commit:
https://reviews.llvm.org/D35624?vs=126331=126332#toc
Repository:
rL LLVM
https://reviews.llvm.org/D35624
sdardis added inline comments.
Comment at: lib/Basic/Targets/Mips.cpp:209
bool MipsTargetInfo::validateTarget(DiagnosticsEngine ) const {
+ // microMIPS64R6 backend is removed
+ if ((getTriple().getArch() == llvm::Triple::mips64 ||
"was removed."
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1992
+def ext_auto_new_list_init : Extension<
+ "ISO C++ standards before C++17 does not allow new expression for
abeserminji updated this revision to Diff 126331.
abeserminji added a comment.
Comment addressed.
https://reviews.llvm.org/D35624
Files:
include/clang/Basic/DiagnosticCommonKinds.td
lib/Basic/Targets/Mips.cpp
Index: lib/Basic/Targets/Mips.cpp
ilya-biryukov updated this revision to Diff 126328.
ilya-biryukov added a comment.
Updated the patch after changes to Context
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40488
Files:
clangd/ClangdUnit.cpp
clangd/JSONRPCDispatcher.cpp
clangd/Trace.cpp
clangd/Trace.h
ilya-biryukov updated this revision to Diff 126329.
ilya-biryukov added a comment.
Updated the patch after changes to Context
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40489
Files:
clangd/Trace.cpp
clangd/Trace.h
Index: clangd/Trace.h
ilya-biryukov updated this revision to Diff 126327.
ilya-biryukov added a comment.
Udpated the patch after changes in Context
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
miyuki updated this revision to Diff 126325.
miyuki added a comment.
Added a test for thead_local.
https://reviews.llvm.org/D40705
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseTemplate.cpp
test/CXX/temp/temp.param/p2-cpp11.cpp
test/CXX/temp/temp.param/p2.cpp
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:65
+ Context *Parent;
+ TypedValueMap Data;
+};
sammccall wrote:
> ilya-biryukov wrote:
> > sammccall wrote:
> > > We add complexity here (implementation and conceptual) to allow multiple
> > >
ilya-biryukov added inline comments.
Comment at: clangd/Context.h:11
+// Context for storing and retrieving implicit data. Useful for passing
implicit
+// parameters on a per-request basis.
+//
sammccall wrote:
> This could use a bit more I think, e.g.
>
>
yvvan added a comment.
Can we still have it in 5.0?
Repository:
rL LLVM
https://reviews.llvm.org/D40746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki added a comment.
In https://reviews.llvm.org/D40415#950793, @rogfer01 wrote:
> Hi @miyuki I can commit it.
Please do so.
https://reviews.llvm.org/D40415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexey.knyshev added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/LabelInsideSwitchChecker.cpp:87
+BugReporter ) const {
+ auto LabelStmt = stmt(hasDescendant(switchStmt(
+
rogfer01 added a comment.
Hi @miyuki I can commit it.
https://reviews.llvm.org/D40415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov updated this revision to Diff 126322.
ilya-biryukov added a comment.
- Replaced emptyCtx with Context::empty
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
clangd/Context.h
clangd/TypedValueMap.h
ilya-biryukov updated this revision to Diff 126321.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Added r-value overload for derive().
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
ilya-biryukov updated this revision to Diff 126320.
ilya-biryukov added a comment.
- Rephrase the comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
clangd/Context.h
clangd/TypedValueMap.h
ilya-biryukov updated this revision to Diff 126319.
ilya-biryukov marked 4 inline comments as done.
ilya-biryukov added a comment.
- Added a comment about the Parent vs Data lifetimes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
ilya-biryukov updated this revision to Diff 126318.
ilya-biryukov added a comment.
- Update the patch to accomodate changes from tracing and Context patches.
- Updated tracing after changes to Context. We now store a clone() of Context
in Span instead of ContextData.
- Pass Context by const-ref
ilya-biryukov updated this revision to Diff 126317.
ilya-biryukov added a comment.
- Return `const Type*` instead of `Type*` in map getters.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40485
Files:
clangd/CMakeLists.txt
clangd/Context.cpp
clangd/Context.h
ilya-biryukov updated this revision to Diff 126316.
ilya-biryukov added a comment.
- Pass Context by const-ref instead of by-ref.
- Don't expose global logger, it is only used in log method now.
- Renamed logImpl to log.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
ilya-biryukov updated this revision to Diff 126315.
ilya-biryukov added a comment.
- Made ContextData a private member of Context.
- Added clone method.
- Added forgotten header guard in TypedValueMap.h
- Pass Key<> by const-ref instead of by-ref.
- Pass Context by-const-ref instead of by-ref.
-
miyuki added a comment.
Ping
https://reviews.llvm.org/D40707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki added a comment.
Ping
https://reviews.llvm.org/D40705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin added a comment.
Hello Alexey,
Thank you for the update. The code looks much cleaner now.
Comment at: lib/StaticAnalyzer/Checkers/LabelInsideSwitchChecker.cpp:115
+
+namespace clang {
+ namespace ento {
alexey.knyshev wrote:
> a.sidorin wrote:
> >
ilya-biryukov added a comment.
In https://reviews.llvm.org/D41005#949550, @cameron314 wrote:
> It's been a while since I was in this code, but I seem to recall the file
> needed to exist on disk in order to uniquely identify it (via inode). Does
> this break the up-to-date check?
When the
101 - 147 of 147 matches
Mail list logo
