[libunwind] r321469 - There is no portable format string for printing `uintptr_t` values.

Author: chandlerc Date: Tue Dec 26 21:46:53 2017 New Revision: 321469 URL: http://llvm.org/viewvc/llvm-project?rev=321469=rev Log: There is no portable format string for printing `uintptr_t` values. Instead, cast them to `void *` which has a portable format string syntax of `%p`. This fixes a

[PATCH] D41582: [x86][icelake][gfni]

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D41582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41583: [x86][icelake][vaes]

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D41583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41573: [x86][icelake][vpclmulqdq]

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D41573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41583: [x86][icelake][vaes]

coby updated this revision to Diff 128185. coby added a comment. turning aes off forbids enabling vaes Repository: rC Clang https://reviews.llvm.org/D41583 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[PATCH] D41573: [x86][icelake][vpclmulqdq]

coby updated this revision to Diff 128183. coby added a comment. turning off pclmul forbids enabling vpclmulqdq Repository: rC Clang https://reviews.llvm.org/D41573 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp

RE: [PATCH] D41583: [x86][icelake][vaes]

I see. agreed. Will upload shortly From: Craig Topper [mailto:craig.top...@gmail.com] Sent: Tuesday, December 26, 2017 19:52 To: reviews+d41583+public+5c6eea8282599...@reviews.llvm.org Cc: cfe-commits@lists.llvm.org; Tayree, Coby ; mgo...@gentoo.org Subject: Re: [PATCH]

[PATCH] D41573: [x86][icelake][vpclmulqdq]

coby added inline comments. Comment at: lib/Basic/Targets/X86.cpp:577 } else if (Name == "pclmul") { if (Enabled) setSSELevel(Features, SSE2, Enabled); craig.topper wrote: > I think we should disable vpclmulqdq when pclmul is being disabled.

RE: r321312 - [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

r321457. Happy new year! --paulr > -Original Message- > From: Kim Gräsman [mailto:kim.gras...@gmail.com] > Sent: Tuesday, December 26, 2017 1:56 AM > To: Robinson, Paul > Cc: cfe-commits > Subject: Re: r321312 - [AST] Incorrectly qualified unscoped enumeration as > template actual

r321457 - Fix comment typo in r321312.

Author: probinson Date: Tue Dec 26 10:01:19 2017 New Revision: 321457 URL: http://llvm.org/viewvc/llvm-project?rev=321457=rev Log: Fix comment typo in r321312. Post-commit review by Kim Grasman! Modified: cfe/trunk/lib/AST/Decl.cpp Modified: cfe/trunk/lib/AST/Decl.cpp URL:

[PATCH] D41573: [x86][icelake][vpclmulqdq]

craig.topper requested changes to this revision. craig.topper added inline comments. This revision now requires changes to proceed. Comment at: lib/Basic/Targets/X86.cpp:577 } else if (Name == "pclmul") { if (Enabled) setSSELevel(Features, SSE2, Enabled);

Re: [PATCH] D41583: [x86][icelake][vaes]

I meant if the command line says “-mvaes -mno-aes” we should make sure to disable vaes On Tue, Dec 26, 2017 at 9:47 AM coby via Phabricator < revi...@reviews.llvm.org> wrote: > coby added inline comments. > > > > Comment at: lib/Basic/Targets/X86.cpp:573 >

[PATCH] D41583: [x86][icelake][vaes]

coby added inline comments. Comment at: lib/Basic/Targets/X86.cpp:573 setMMXLevel(Features, AMD3DNowAthlon, Enabled); } else if (Name == "aes") { if (Enabled) craig.topper wrote: > Shouldn't -aes imply -vaes? how come? perhaps i'm missing here

[PATCH] D41583: [x86][icelake][vaes]

craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.cpp:573 setMMXLevel(Features, AMD3DNowAthlon, Enabled); } else if (Name == "aes") { if (Enabled) Shouldn't -aes imply -vaes? Repository: rC Clang

[PATCH] D41582: [x86][icelake][gfni]

craig.topper added inline comments. Comment at: test/CodeGen/gfni-builtins.c:45 + +#ifdef AVX512 +__m512i test_mm512_gf2p8affineinv_epi64_epi8(__m512i A, __m512i B) { craig.topper wrote: > Doesn't the define have underscores around it? Oh its your own define.

[PATCH] D41582: [x86][icelake][gfni]

craig.topper added inline comments. Comment at: test/CodeGen/gfni-builtins.c:45 + +#ifdef AVX512 +__m512i test_mm512_gf2p8affineinv_epi64_epi8(__m512i A, __m512i B) { Doesn't the define have underscores around it? Repository: rC Clang

[PATCH] D41557: [x86][icelake][vbmi2]

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D41557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41557: [x86][icelake][vbmi2]

coby updated this revision to Diff 128172. coby added a comment. tests Repository: rC Clang https://reviews.llvm.org/D41557 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt

[PATCH] D41557: [x86][icelake][vbmi2]

coby updated this revision to Diff 128171. coby added a comment. addressed comments Repository: rC Clang https://reviews.llvm.org/D41557 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[PATCH] D41557: [x86][icelake][vbmi2]

coby marked 2 inline comments as done. coby added inline comments. Comment at: lib/Basic/Targets/X86.cpp:589 +// Enable BWI instruction if VBMI/VBMI2 is being enabled. +if (Name.startswith("avx512vbmi") && Enabled) Features["avx512bw"] = true;

[PATCH] D41583: [x86][icelake][vaes]

coby created this revision. coby added a reviewer: craig.topper. Herald added a subscriber: mgorny. added intrinsics support for vaes instructions, matching a similar work on the backend (https://reviews.llvm.org/D40078) Repository: rC Clang https://reviews.llvm.org/D41583 Files:

[PATCH] D41582: [x86][icelake][gfni]

coby updated this revision to Diff 128168. coby added a comment. add forgotten undef[s] Repository: rC Clang https://reviews.llvm.org/D41582 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[PATCH] D41582: [x86][icelake][gfni]

coby created this revision. coby added a reviewer: craig.topper. Herald added a subscriber: mgorny. added intrinsics support for gfni instructions, matching a similar work on the backend (https://reviews.llvm.org/D40373) Repository: rC Clang https://reviews.llvm.org/D41582 Files:

Re: r321312 - [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

This broke a test case in IWYU, so I read the diff a few times more than usual... On Thu, Dec 21, 2017 at 10:47 PM, Paul Robinson via cfe-commits wrote: > >// scope of the enumeration. > - if (ED->isScoped() || ED->getIdentifier()) > + // For the