[PATCH] D42099: [libclang] Add missing CINDEX_LINKAGE

yvvan added a comment. I have mentioned there the original number (https://reviews.llvm.org/D39903) in the commit message but it's also not mentioned in the log there. Repository: rC Clang https://reviews.llvm.org/D42099 ___ cfe-commits mailing

[PATCH] D42099: [libclang] Add missing CINDEX_LINKAGE

nik added a comment. This was one was already submitted/merged by yvvan. Hmm, this review does not reflect that yet? Repository: rC Clang https://reviews.llvm.org/D42099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r322350 - [ODRHash] Don't hash friend functions.

I feel it's best to merge this change into the release branch instead of reverting the previous change. I've filed a bug to request this revision, and a few others that fix the test case, to be merged. https://bugs.llvm.org/show_bug.cgi?id=35981 On Tue, Jan 16, 2018 at 2:44 PM, NAKAMURA Takumi

r322618 - [CodeGen] Fix a crash on mangling multiversioned functions

Author: gbiv Date: Tue Jan 16 20:46:04 2018 New Revision: 322618 URL: http://llvm.org/viewvc/llvm-project?rev=322618=rev Log: [CodeGen] Fix a crash on mangling multiversioned functions `multiVersionSortPriority` expects features to have no prefix. We currently carry them around in the format

[libcxx] r322617 - libcxx: Stop using private MSVC macros in the exception implementation.

Author: pcc Date: Tue Jan 16 20:37:04 2018 New Revision: 322617 URL: http://llvm.org/viewvc/llvm-project?rev=322617=rev Log: libcxx: Stop using private MSVC macros in the exception implementation. Inline the provided "fallback" definitions (which seem to always be taken) that expand to __cdecl

Re: [analyzer] Add support for __builtin_constant_p to BuiltinFunctionChecker

+ Devin and George > On Jan 14, 2018, at 10:44 AM, Felix Kostenzer via cfe-commits > wrote: > > > Hi, > > Added evaluation of __builtin_constant_p to the dedicated StaticAnalyzer > checker > along with a regression test. > > 'make clang-test' results: > >

[PATCH] D41378: [analyzer] support a mode to only show relevant lines in HTML diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rC322612: [analyzer] support a mode to only show relevant lines in HTML diagnostics (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang

r322612 - [analyzer] support a mode to only show relevant lines in HTML diagnostics

Author: george.karpenkov Date: Tue Jan 16 18:59:11 2018 New Revision: 322612 URL: http://llvm.org/viewvc/llvm-project?rev=322612=rev Log: [analyzer] support a mode to only show relevant lines in HTML diagnostics HTML diagnostics can be an overwhelming blob of pages of code. This patch adds a

r322611 - Make DiagnosticsEngine() take DiagOpts as DiagnosticsEngine.

Author: nico Date: Tue Jan 16 18:55:27 2018 New Revision: 322611 URL: http://llvm.org/viewvc/llvm-project?rev=322611=rev Log: Make DiagnosticsEngine() take DiagOpts as DiagnosticsEngine. No behavior change, but makes it a bit clearer that DiagnosticsEngine adds a ref to DiagOpts. Modified:

[PATCH] D42154: Don't generate inline atomics for i386/i486

craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.h:472 +CPUKind Kind = getCPUKind(Opts.CPU); +if (Kind >= CK_i586 || Kind == CK_Generic) + MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; wmi wrote: > wmi wrote: > >

[PATCH] D42154: Don't generate inline atomics for i386/i486

wmi added inline comments. Comment at: lib/Basic/Targets/X86.h:472 +CPUKind Kind = getCPUKind(Opts.CPU); +if (Kind >= CK_i586 || Kind == CK_Generic) + MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; wmi wrote: > craig.topper wrote: > >

[PATCH] D42154: Don't generate inline atomics for i386/i486

wmi added a comment. In https://reviews.llvm.org/D42154#977975, @efriedma wrote: > The LLVM backend currently assumes every CPU is Pentium-compatible. If we're > going to change that in clang, we should probably fix the backend as well. With the patch, for i386/i486 targets, clang will

[PATCH] D42154: Don't generate inline atomics for i386/i486

craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.h:472 +CPUKind Kind = getCPUKind(Opts.CPU); +if (Kind >= CK_i586 || Kind == CK_Generic) + MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; craig.topper wrote: > efriedma wrote:

[PATCH] D42154: Don't generate inline atomics for i386/i486

craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.h:472 +CPUKind Kind = getCPUKind(Opts.CPU); +if (Kind >= CK_i586 || Kind == CK_Generic) + MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; efriedma wrote: > What exactly does

[PATCH] D42157: [clang-cl] Let /FA output use intel assembly.

thakis created this revision. thakis added a reviewer: hans. cl.exe's assembly output is in intel syntax, so clang-cl's should be too, PR35031. https://reviews.llvm.org/D42157 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/masm.c Index: test/Driver/masm.c

[PATCH] D42154: Don't generate inline atomics for i386/i486

efriedma added a comment. The LLVM backend currently assumes every CPU is Pentium-compatible. If we're going to change that in clang, we should probably fix the backend as well. Comment at: lib/Basic/Targets/X86.h:472 +CPUKind Kind = getCPUKind(Opts.CPU); +if (Kind

[PATCH] D42154: Don't generate inline atomics for i386/i486

wmi created this revision. wmi added reviewers: rjmccall, eli.friedman, rsmith. Herald added subscribers: cfe-commits, eraman, sanjoy. This is to fix the bug reported in https://bugs.llvm.org/show_bug.cgi?id=34347#c6 Currently, all MaxAtomicInlineWidth of x86-32 targets are set to 64. However,

[PATCH] D42092: implement C++ dr388 for the Itanium C++ ABI: proper handling of catching exceptions by reference

rnk added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3867 +// subsequent catches in the same try statement to catch such a rethrow. +// See C++ DR 388. +if (!CanBindToTemporary && MaybeTypeMatch) { Based on our conversation, this fix

[PATCH] D41788: [DeclPrinter] Fix two cases that crash clang -ast-print.

tra added a comment. @bkramer Can you take a look at the patch? https://reviews.llvm.org/D41788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42143: add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322602: add ID as a special acronym to objc property declaration check for property… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130058. juliehockett added a comment. Good point -- updating checker to allow trailing returns if the decltype specifier is used. https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

[PATCH] D42143: add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix.

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Wizard retitled this revision from "add ID as a special acronym to objc property declaration check for property names like bundleID. allow using acronyms as suffix." to "add ID as a special acronym to objc property

[PATCH] D42139: [UPSTREAM] Allow passing additional compiler/linker flags for the tests

arichardson created this revision. arichardson added a reviewer: EricWF. Herald added subscribers: cfe-commits, mgorny. These flags can be specified using the CMake variables LIBCXX_TEST_LINKER_FLAGS and LIBCXX_TEST_COMPILER_FLAGS. When building the tests for CHERI I need to pass additional flags

Re: [clang-tools-extra] r322387 - [clangd] Code completion uses Sema for NS-level things in the current file.

Hi, ClangdTests/FuzzyMatch.Matches has been failing since this commit on a sanitized clang build on MacOS. I've seen some later commits trying to fix it, but the issue is still there. Could you please take a look? Steps to reproduce in case you need them: > cmake -G Ninja

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb added a comment. After fighting with cmake for a bit, I just broke down and cross-compiled the tests by hand and then ran them under a qemu system (rather than using qemu user mode). All of the tests ran fine for me without crashing using GCC 6.3.0 for FreeBSD 12 with N32. Given the

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130044. benhamilton added a comment. - Last cleanup for tests Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130042. benhamilton added a comment. - Tidy up Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

vsapsai added a comment. I've addressed all known issues, please take another look. https://reviews.llvm.org/D41834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r322549 - Squash -Wcovered-switch-default wairning

Hello Sam, This commit broke one of our builders: http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/4517 . . . FAILED: /usr/local/gcc-7.1/bin/gcc-7.1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130041. benhamilton added a comment. - Move tests to FormatTestObjC.cpp Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton created this revision. benhamilton added reviewers: jolesiak, krasimir. Herald added subscribers: cfe-commits, klimek. This improves upon the previous Objective-C header guessing heuristic from https://reviews.llvm.org/rC320479. Now, we run the lexer on C++ header files and look for

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

vsapsai updated this revision to Diff 130038. vsapsai added a comment. - Try another approach for the fix. It has broader impact but semantically seems to be more correct. Also I think `hasScalarEvaluationKind` should use `Arg->getType()` everywhere as it matches `EmitParmDecl` behaviour.

Re: r322350 - [ODRHash] Don't hash friend functions.

If r322350 is temporary fix, I suggest r321395 may be reverted in release_60. Richard, how do you think? On Wed, Jan 17, 2018 at 4:27 AM Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > There was a different, possibly related, issue with templated methods that > I just

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

rsmith added a comment. Did you forget to upload the updated patch? This looks unchanged compared to the prior version. https://reviews.llvm.org/D36357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

aaron.ballman added a comment. In https://reviews.llvm.org/D42116#977588, @juliehockett wrote: > In https://reviews.llvm.org/D42116#977347, @aaron.ballman wrote: > > > Can you give some background on what problem the coding standard is trying > > to avoid by banning this? For instance, if

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett added a comment. In https://reviews.llvm.org/D42116#977347, @aaron.ballman wrote: > Can you give some background on what problem the coding standard is trying to > avoid by banning this? For instance, if trailing return types are bad, are > deduced return types similarly bad, or

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130027. juliehockett marked an inline comment as done. juliehockett added a comment. Updating checker to not warn for trailing returns on lambdas. https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt

[PATCH] D41921: [Parse] Forward brace locations to TypeConstructExpr

vsk updated this revision to Diff 130021. vsk marked 2 inline comments as done. vsk added a comment. - Address feedback from @aaron.ballman https://reviews.llvm.org/D41921 Files: include/clang/AST/ExprCXX.h include/clang/Sema/Initialization.h include/clang/Sema/Sema.h

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 130020. Rakete added a comment. Addressed review comments :) https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expressions.cpp

[PATCH] D41906: [libunwind][PPC64] Added vector registers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322596: [PPC64] Added vector registers. (authored by mstorsjo, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41906 Files: libunwind/trunk/include/__libunwind_config.h

[libunwind] r322596 - [PPC64] Added vector registers.

Author: mstorsjo Date: Tue Jan 16 12:54:10 2018 New Revision: 322596 URL: http://llvm.org/viewvc/llvm-project?rev=322596=rev Log: [PPC64] Added vector registers. The Registers_ppc64 class needed a couple of changes, both to accommodate the new registers as well as to handle the overlaps of VS

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

Rakete updated this revision to Diff 130014. Rakete added a comment. I put the enum in `ExpressionEvaluationContextRecord` now, and fixed the `Type` -> `Kind` issue. If it's still ok, could you please commit it @rsmith? Thanks :) https://reviews.llvm.org/D37442 Files:

Re: r322405 - Disable test for Windows to fix Windows buildbots.

Tracking bug is PR35939 r322593 adds comment to test case This test triggers an assertion in MicrosoftMangle.cpp On Mon, Jan 15, 2018 at 10:38 AM, David Blaikie wrote: > might be worth having an explanation (probably in both the commit message > and in a comment in the

r322593 - Add context to why test was disabled on Windows

Author: rtrieu Date: Tue Jan 16 11:53:06 2018 New Revision: 322593 URL: http://llvm.org/viewvc/llvm-project?rev=322593=rev Log: Add context to why test was disabled on Windows test/Modules/odr_hash-Friend.cpp triggers an assertion in MicrosoftMangle.cpp This has been reported in PR35939

[PATCH] D42110: Move target MV resolver to COMDAT

This revision was automatically updated to reflect the committed changes. Closed by commit rC322592: Move target MV resolver to COMDAT (authored by erichkeane, committed by ). Repository: rC Clang https://reviews.llvm.org/D42110 Files: lib/CodeGen/CodeGenModule.cpp

r322592 - Move target MV resolver to COMDAT

Author: erichkeane Date: Tue Jan 16 11:49:52 2018 New Revision: 322592 URL: http://llvm.org/viewvc/llvm-project?rev=322592=rev Log: Move target MV resolver to COMDAT As reported here: https://bugs.llvm.org/show_bug.cgi?id=35921 The resolver functions should be in their own COMDAT regions. This

[PATCH] D42110: Move target MV resolver to COMDAT

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Seems reasonable. https://reviews.llvm.org/D42110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r322350 - [ODRHash] Don't hash friend functions.

There was a different, possibly related, issue with templated methods that I just disabled checking for methods all together in r321396 until I can investigate further. On Mon, Jan 15, 2018 at 10:45 AM, David Blaikie wrote: > I'm surprised this problem is unique to friend

r322589 - [DOCS] Updated current status of OpenMP support, NFC.

Author: abataev Date: Tue Jan 16 11:22:49 2018 New Revision: 322589 URL: http://llvm.org/viewvc/llvm-project?rev=322589=rev Log: [DOCS] Updated current status of OpenMP support, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst Modified: cfe/trunk/docs/OpenMPSupport.rst URL:

r322587 - [OPENMP] Add support for `depend` clauses on `target teams distribute

Author: abataev Date: Tue Jan 16 11:18:24 2018 New Revision: 322587 URL: http://llvm.org/viewvc/llvm-project?rev=322587=rev Log: [OPENMP] Add support for `depend` clauses on `target teams distribute parallel for simd` directives. Added codegen for `depend` clauses on `#pragma omp target teams

r322585 - [OPENMP] Add support for `depend` on `target teams distribute parallel

Author: abataev Date: Tue Jan 16 11:02:33 2018 New Revision: 322585 URL: http://llvm.org/viewvc/llvm-project?rev=322585=rev Log: [OPENMP] Add support for `depend` on `target teams distribute parallel for` directives. Added codegen for `depend` clauses on `#pragma omp target teams distribute

[PATCH] D42120: [clang-tidy] Fixing Fuchsia overloaded operator warning message

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: test/clang-tidy/fuchsia-overloaded-operator.cpp:6 int operator+(int); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: cannot overload

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

juliehockett added a comment. The update to the message is also up for review here: D42120 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41708 ___ cfe-commits mailing list

[PATCH] D42120: [clang-tidy] Fixing Fuchsia overloaded operator warning message

juliehockett created this revision. juliehockett added a reviewer: alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Updating Fuchsia overloaded operator warning message for clarity. https://reviews.llvm.org/D42120 Files:

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

aaron.ballman added a comment. Can you give some background on what problem the coding standard is trying to avoid by banning this? For instance, if trailing return types are bad, are deduced return types similarly bad, or are those fine? Comment at:

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if a function has a trailing return. See

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

m.ostapenko updated this revision to Diff 129985. m.ostapenko added a comment. Hi Devin, now I'm very sorry for a such long delay. Now I have a bunch of time to proceed development of this patch (if scope contexts are still needed, of course). Regarding to approach you suggested (reuse

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.h:86 + /// represented by instantiated Metadata nodes. + llvm::SmallDenseMap SizeExprCache; + sdesmalen wrote: > aprantl wrote: > > I'm expecting VLA's to not be

[PATCH] D42113: [clangd] Deduplicate symbols collected in global-symbol-builder tool.

ioeric created this revision. ioeric added reviewers: bkramer, sammccall. Herald added subscribers: cfe-commits, ilya-biryukov, klimek. After https://reviews.llvm.org/D42111, the executor framework no longer deduplicate tool results. Repository: rCTE Clang Tools Extra

[PATCH] D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor.

ioeric created this revision. ioeric added a reviewer: bkramer. Herald added subscribers: cfe-commits, klimek. As result deduplication or reduction is not supported in the framework, we should leave the deplication to tools (if needed) until the framework supports it. Repository: rC Clang

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

apazos updated this revision to Diff 129981. apazos added a comment. I tested this on windows and I had to add an assembler placeholder executable, just like it was done with the linker in the RISCV multilib dir checked under Inputs. Other observations, are these known issues? - multilib dir

r322578 - [OPENMP] Add support for `depend` clauses on `target parallel for simd`

Author: abataev Date: Tue Jan 16 09:55:15 2018 New Revision: 322578 URL: http://llvm.org/viewvc/llvm-project?rev=322578=rev Log: [OPENMP] Add support for `depend` clauses on `target parallel for simd` directives. Added codegen for `depend` clauses on `#pragma omp target parallel for simd`

[PATCH] D42110: Move target MV resolver to COMDAT

erichkeane created this revision. erichkeane added reviewers: espindola, hfinkel, echristo. As reported here: https://bugs.llvm.org/show_bug.cgi?id=35921 The resolver functions should be in their own COMDAT regions. This patch sets that up. https://reviews.llvm.org/D42110 Files:

r322577 - [OPENMP] Add support for `depend` clauses on `target parallel for`

Author: abataev Date: Tue Jan 16 09:41:04 2018 New Revision: 322577 URL: http://llvm.org/viewvc/llvm-project?rev=322577=rev Log: [OPENMP] Add support for `depend` clauses on `target parallel for` directives. Added codegen for `depend` clause on `#pragma omp target parallel for` directives.

r322575 - [OPENMP] Add support for `depend` clauses on `target teams distribute

Author: abataev Date: Tue Jan 16 09:22:50 2018 New Revision: 322575 URL: http://llvm.org/viewvc/llvm-project?rev=322575=rev Log: [OPENMP] Add support for `depend` clauses on `target teams distribute simd` directives. Added codegen for `depend` clauses on `#pragma omp target teams distribute

[PATCH] D42085: Add va_start()/va_copy()/va_end to Builtins.def

thakis closed this revision. thakis added a comment. r322573, thanks! Yes, I looked at the same file and came to the same conclusion regarding a test :-) https://reviews.llvm.org/D42085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r322573 - Add va_start()/va_copy()/va_end to Builtins.def

Author: nico Date: Tue Jan 16 08:55:41 2018 New Revision: 322573 URL: http://llvm.org/viewvc/llvm-project?rev=322573=rev Log: Add va_start()/va_copy()/va_end to Builtins.def That way, clang suggests including stdarg.h when these are used in C files. https://reviews.llvm.org/D42085 Modified:

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke updated this revision to Diff 129969. tvanslyke added a comment. Implemented changes to ensure string state is valid after calling `__clear_and_shrink()`. Benchmark results are identical. https://reviews.llvm.org/D41976 Files: string Index: string

r322571 - [OPENMP] Add support for `depend` clause on `target teams distribute`.

Author: abataev Date: Tue Jan 16 08:46:46 2018 New Revision: 322571 URL: http://llvm.org/viewvc/llvm-project?rev=322571=rev Log: [OPENMP] Add support for `depend` clause on `target teams distribute`. Added codegen for `depend` clauses on `#pragma omp target teams distribute` directives. Added:

[PATCH] D41815: [clang-tidy] implement check for goto

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor formatting nit. Comment at: clang-tidy/hicpp/HICPPTidyModule.cpp:57 "hicpp-exception-baseclass"); -

Re: r321816 - [OPENMP] Add debug info for generated functions.

Hi Hans, I don't think we need to merge some of these to 6.0 branch, they are not bug fixes, just some new functionality - Best regards, Alexey Bataev 16.01.2018 9:59, Hans Wennborg пишет: > Please file a merge request bug blocking PR35804 for what you'd like > merged (unless you

r322570 - [OPENMP] Add support for `depend` clauses on `target parallel` directive.

Author: abataev Date: Tue Jan 16 08:27:49 2018 New Revision: 322570 URL: http://llvm.org/viewvc/llvm-project?rev=322570=rev Log: [OPENMP] Add support for `depend` clauses on `target parallel` directive. Added codegen for `depend` clauses on `#pragma omp target parallel` directives. Added:

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke added a comment. Sorry if I'm spamming too much. Just to be clear, I agree completely with your sentiment but I'm pretty sure that `__clear_and_shrink()` has exactly the same effects as `clear(); shrink_to_fit();`. Maybe `reserve(0);` should should be unconditionally calling

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke added a comment. Just to elaborate, in `reserve(0)` after the deallocation there's a check `if (__now_long)` which takes the else branch and only ends up calling `__set_short_size(__sz); // __sz = 0 here`. So even without this diff the only thing `reserve(0)` does after deallocating

r322569 - [OPENMP] Add support for `depend` clauses on `target teams`.

Author: abataev Date: Tue Jan 16 07:57:07 2018 New Revision: 322569 URL: http://llvm.org/viewvc/llvm-project?rev=322569=rev Log: [OPENMP] Add support for `depend` clauses on `target teams`. Added codegen for `depend` clause on `#pragma omp target teams` directives. Added:

[libcxx] r322566 - More constexpr algorithms from P0202. search/search_n

Author: marshall Date: Tue Jan 16 07:48:27 2018 New Revision: 322566 URL: http://llvm.org/viewvc/llvm-project?rev=322566=rev Log: More constexpr algorithms from P0202. search/search_n Modified: libcxx/trunk/include/algorithm libcxx/trunk/include/functional

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware updated this revision to Diff 129960. baloghadamsoftware added a comment. Rebased to current part 4. New tests added. Comments added. https://reviews.llvm.org/D32859 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/mismatched-iterator.cpp Index:

Re: Re: r322018 - [OPENMP] Current status of OpenMP support.

Merged to 6.0 in r322564. Thanks, Hans On Mon, Jan 8, 2018 at 8:21 PM, GMail wrote: > This is is the status of OpenMP support in 6.0. There is nothing new since > branching. > > - > Best regards, > Alexey Bataev > > 08.01.2018 14:09, Jonas Hahnfeld via

r322562 - [SystemZ] Support vector registers with inline asm

Author: uweigand Date: Tue Jan 16 07:39:23 2018 New Revision: 322562 URL: http://llvm.org/viewvc/llvm-project?rev=322562=rev Log: [SystemZ] Support vector registers with inline asm Allow using vector register names and the "v" constraint in inline asm to ensure compatibility with GCC.

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

elsteveogrande updated this revision to Diff 129959. elsteveogrande added a comment. Change string-copy-on-demand logic; do only if `not IsNullTerminated`. Repository: rC Clang https://reviews.llvm.org/D42043 Files: include/clang-c/CXString.h tools/c-index-test/c-index-test.c

[PATCH] D42098: [clang-format] Reorganize RawStringFormat based on language

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42106: [analyzer] Remove the useless method declararion 'BugReporter::RemoveUnneededCalls()'.

MTC created this revision. MTC added reviewers: NoQ, dcoughlin, xazax.hun. Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet. MTC retitled this revision from "[analyzer] Remove the useless method declararion 'BugReporter::RemoveUnneedCalls()'." to "[analyzer] Remove the useless

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke added a comment. I think the only thing we need is a call to __set_long_cap(0) in the body of the if() to make the string be in a valid state, but if you follow the logic for a call to reserve(0) (after having called clear()) it doesn't even end up doing that (unless I'm missing

r322559 - [OPENMP] Add support for `depend` clauses on `target simd`.

Author: abataev Date: Tue Jan 16 07:05:16 2018 New Revision: 322559 URL: http://llvm.org/viewvc/llvm-project?rev=322559=rev Log: [OPENMP] Add support for `depend` clauses on `target simd`. Added codegen for `depend` clauses on `#pragma omp target simd` directives. Added:

Re: r321816 - [OPENMP] Add debug info for generated functions.

Please file a merge request bug blocking PR35804 for what you'd like merged (unless you already have). Thanks, Hans On Mon, Jan 8, 2018 at 5:27 PM, Alexey Bataev via cfe-commits wrote: > Will add some more tests later today > - > Best regards, > Alexey

Re: r321754 - -gmodules: Emit debug info for implicit module imports via #include.

Merged to 6.0 in r322557. On Wed, Jan 3, 2018 at 8:10 PM, Adrian Prantl via cfe-commits wrote: > Author: adrian > Date: Wed Jan 3 11:10:21 2018 > New Revision: 321754 > > URL: http://llvm.org/viewvc/llvm-project?rev=321754=rev > Log: > -gmodules: Emit debug info for

[libcxx] r322556 - Change an internal table of constants for the poisson distribution from

Author: marshall Date: Tue Jan 16 06:54:36 2018 New Revision: 322556 URL: http://llvm.org/viewvc/llvm-project?rev=322556=rev Log: Change an internal table of constants for the poisson distribution from type 'result_type' to 'double'. The only thing that we ever do with these numbers is to promote

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

mclow.lists added a comment. I'm a bit leery of this patch. Not because of what it's trying to do, but rather, the introduction of a method `__clear_and_shrink` that leaves the string in an invalid state. For all the uses that you put it to, I don't think that's a problem (though I'm still

Re: r321771 - [CGBuiltin] Handle unsigned mul overflow properly (PR35750)

Merged to 6.0 in r322555. On Thu, Jan 4, 2018 at 12:11 AM, Vedant Kumar via cfe-commits wrote: > Author: vedantk > Date: Wed Jan 3 15:11:32 2018 > New Revision: 321771 > > URL: http://llvm.org/viewvc/llvm-project?rev=321771=rev > Log: > [CGBuiltin] Handle unsigned

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

hans added a comment. Alex, do you think the fix is still OK for the 6.0 branch? Let me know, and I'll merge it. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

bkramer added inline comments. Comment at: clangd/Compiler.h:39 +/// be consumed by the FrontendAction as it will have a pointer to the MainFile +/// buffer that will only be deleted if BeginSourceFile is called. std::unique_ptr prepareCompilerInstance( This

[PATCH] D42085: Add va_start()/va_copy()/va_end to Builtins.def

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Seems that some of these are tested in Sema/implicit-builtin-decl.c, but it doesn't look exhaustive and I'm not sure it's worth adding these. https://reviews.llvm.org/D42085

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen marked 3 inline comments as done. sdesmalen added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2358 +if (auto *SizeNode = getVLASizeExpressionForType(EltTy)) + Subscripts.push_back(DBuilder.getOrCreateSubrange(0, SizeNode)); +else

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen updated this revision to Diff 129943. sdesmalen added a comment. Refactoring based on @aprantl's suggestions. https://reviews.llvm.org/D41698 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.cpp

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

a.sidorin added a comment. Hello Adam. I have a nit inline. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1256 +if (Cond(Reg.second)) { + State = setIteratorPosition(State, Reg.first, Proc(Reg.second)); +} Updating ProgramState is

[PATCH] D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

a.sidorin added a comment. Hello Adam, This looks like a nice improvement. I have some remarks inline. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:382 } + } else if (!isa()) { +// The main purpose of iterators is to abstract away from different

[PATCH] D41906: [libunwind][PPC64] Added vector registers.

mstorsjo added a comment. No objections from me on this. There were a few stray cosmetic changes that perhaps could be split out, but it's not big enough that I'd object to it. So if @compnerd doesn't mind, I'll commit this. Repository: rL LLVM https://reviews.llvm.org/D41906

r322551 - [NFC] fix trivial typo in document

Author: inouehrs Date: Tue Jan 16 05:19:31 2018 New Revision: 322551 URL: http://llvm.org/viewvc/llvm-project?rev=322551=rev Log: [NFC] fix trivial typo in document "the the" -> "the" Modified: cfe/trunk/docs/ThinLTO.rst Modified: cfe/trunk/docs/ThinLTO.rst URL:

[PATCH] D41538: [analyzer] Fix some checker's output plist not containing the checker name #2

hans added a comment. In https://reviews.llvm.org/D41538#969207, @xazax.hun wrote: > In https://reviews.llvm.org/D41538#969205, @sylvestre.ledru wrote: > > > It missed the 6.0 branching. Will you try to get it on this branch? > > Thanks > > > Sure! I will try to do so:

r322549 - Squash -Wcovered-switch-default wairning

Author: sammccall Date: Tue Jan 16 04:54:28 2018 New Revision: 322549 URL: http://llvm.org/viewvc/llvm-project?rev=322549=rev Log: Squash -Wcovered-switch-default wairning Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified: cfe/trunk/tools/c-index-test/c-index-test.c URL:

  1   2   >