[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

ilya-biryukov added inline comments. Comment at: include/clang-c/Index.h:6159 + */ + CXSymbolRole role; } CXIdxEntityRefInfo; Why do we need to store both `CXIdxEntityRefKind` and `CXSymbolRole`? Can we store just `CXSymbolRole`? Is this for compatibility wi

[PATCH] D43026: [OpenMP] Support for implicit "declare target" functions - CodeGen patch

ABataev added a comment. It is impossible to understand what is going on here. We need to discuss this before even reviewing of this patch. Comment at: lib/CodeGen/CGCXXABI.h:543 + llvm::GlobalVariable *DeclPtr, bool PerformInit, +

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133233. MaskRay marked 2 inline comments as done. MaskRay added a comment. Fix word order of readability-simd-intrinsics Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readab

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

krasimir added a comment. We could adapt the single-argument version instead, turning: foo(bb + c); into: foo(bb + c); Repository: rC Clang https://reviews.llvm.org/D42787 ___

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

This revision was automatically updated to reflect the committed changes. Closed by commit rC324490: [DebugInfo] Improvements to representation of enumeration types (PR36168) (authored by chill, committed by ). Repository: rL LLVM https://reviews.llvm.org/D42736 Files: lib/CodeGen/CGDebugIn

[PATCH] D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168)

This revision was automatically updated to reflect the committed changes. Closed by commit rL324490: [DebugInfo] Improvements to representation of enumeration types (PR36168) (authored by chill, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

r324490 - [DebugInfo] Improvements to representation of enumeration types (PR36168)

Author: chill Date: Wed Feb 7 08:52:02 2018 New Revision: 324490 URL: http://llvm.org/viewvc/llvm-project?rev=324490&view=rev Log: [DebugInfo] Improvements to representation of enumeration types (PR36168) This patch: * fixes an incorrect sign-extension of unsigned values, when emitting debug

[PATCH] D43026: [OpenMP] Support for implicit "declare target" functions - CodeGen patch

grokos created this revision. grokos added a reviewer: ABataev. grokos added projects: clang, OpenMP. Herald added a subscriber: guansong. This patch implements CodeGen support for the "declare target" directive. Code is generated for variables, functions and ctors/dtors. I understand that the p

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

tejohnson added a comment. In https://reviews.llvm.org/D42995#1000155, @vitalybuka wrote: > In https://reviews.llvm.org/D42995#125, @tejohnson wrote: > > > > Empty ThinLTOIndexFile signals that we don't need this module during > > > linking. > > > > Not the only case actually. We now also pa

[PATCH] D36191: [CodeGen] Don't make availability attributes imply default visibility on macos

thakis added a comment. Err sorry, landed in https://reviews.llvm.org/rL310382. Repository: rL LLVM https://reviews.llvm.org/D36191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36191: [CodeGen] Don't make availability attributes imply default visibility on macos

thakis added a comment. Herald added a subscriber: llvm-commits. What's the status here? Repository: rL LLVM https://reviews.llvm.org/D36191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

r324469 - [clang-format] Fix ObjC message arguments formatting.

Author: jolesiak Date: Wed Feb 7 02:35:08 2018 New Revision: 324469 URL: http://llvm.org/viewvc/llvm-project?rev=324469&view=rev Log: [clang-format] Fix ObjC message arguments formatting. Summary: Fixes formatting of ObjC message arguments when inline block is a first argument. Having inline bl

[clang-tools-extra] r324407 - Support special acronyms inside property names and allow plural forms

Author: wizard Date: Tue Feb 6 13:40:38 2018 New Revision: 324407 URL: http://llvm.org/viewvc/llvm-project?rev=324407&view=rev Log: Support special acronyms inside property names and allow plural forms Reviewers: benhamilton, hokein Reviewed By: benhamilton, hokein Subscribers: klimek, cfe-com

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values

fhahn added a comment. Also with tests for each backend, this diff will get quite big. As this is opt-in, it might make sense to enable backends separately. Repository: rC Clang https://reviews.llvm.org/D42978 ___ cfe-commits mailing list cfe-co

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values

fhahn added a reviewer: rengolin. fhahn added a comment. I like the idea. However for all backends, except Arm and AArch64, we would have to maintain another list of CPU names. At least for the targets which implement `isValidCPUName`, we could add an array with valid names and use that. That'

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz updated this revision to Diff 133204. Typz added a comment. Fix indentation of inheritance list, which is actually based on `ConstructorInitializerIndentWidth`. Maybe a new option (`InheritanceListIndentWidth`) should be used instead? Repository: rC Clang https://reviews.llvm.org/D4301

[PATCH] D42640: [clangd] Prototype: collect symbol #include & insert #include in global code completion.

ioeric updated this revision to Diff 133203. ioeric added a comment. - Merge with origin/master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42640 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/CodeComple

[PATCH] D42640: [clangd] Prototype: collect symbol #include & insert #include in global code completion.

ioeric updated this revision to Diff 133202. ioeric added a comment. - Added tests for IncludeURI and CanonicalIncludes and minor cleanup. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42640 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp

[PATCH] D43017: Clean up use of C allocation functions

sepavloff created this revision. sepavloff added reviewers: akyrtzi, rnk. This change cleans up uses of malloc/calloc/realloc. In the case where the return value is not checked agains null pointer, the call to 'std::malloc' is replaced by 'llvm::malloc', which reports fatal error on allocation fai

[PATCH] D43016: Fix for #31362 - ms_abi is implemented incorrectly for larger values (>=16 bytes).

belickim created this revision. Herald added a subscriber: cfe-commits. This patch is a fix for following issue: https://bugs.llvm.org/show_bug.cgi?id=31362 The problem was caused by front end lowering C calling conventions without taking into account calling conventions enforced by __attribute_

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz created this revision. Typz added reviewers: djasper, krasimir, klimek. This option replaces the BreakBeforeInheritanceComma option with an enum, thus introducing a mode where the colon stays on the same line as constructor declaration: // When it fits on line: class A : public B, public

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

lebedev.ri added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:26 + + static const llvm::StringMap Mapping{ +// [simd.alg] You probably want to move `Mapping` out of the function. Comment at: clang-tidy/readab

[PATCH] D43009: [clangd] Do not precent-encode numbers in URI.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324475: [clangd] Do not precent-encode numbers in URI. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43009 Files: clang-

[clang-tools-extra] r324475 - [clangd] Do not precent-encode numbers in URI.

Author: ioeric Date: Wed Feb 7 04:12:06 2018 New Revision: 324475 URL: http://llvm.org/viewvc/llvm-project?rev=324475&view=rev Log: [clangd] Do not precent-encode numbers in URI. Reviewers: ilya-biryukov Subscribers: klimek, jkorous-apple, cfe-commits, sammccall Differential Revision: https://

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

miyuki added a comment. ping^3 https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. Ping... https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43013: ASan+operator new[]: Fix operator new[] cookie poisoning

filcab created this revision. filcab added reviewers: rjmccall, kcc, rsmith. The C++ Itanium ABI says: No cookie is required if the new operator being used is ::operator new[](size_t, void*). This commit adds a flag to tell clang to poison all operator new[] cookies. A previous review was poiso

[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

xazax.hun added a comment. In https://reviews.llvm.org/D5767#999143, @sabel83 wrote: > 2. What do you mean by regression tests? We have run the clang-test target > successfully on the patched code (which has the hook). Note that the hook > this pull request provides is implemented as a ProgramA

[PATCH] D43012: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

a.sidorin created this revision. a.sidorin added reviewers: xazax.hun, szepet, jingham. Herald added a subscriber: rnkovacs. Also minor refactoring in related functions was done. Repository: rC Clang https://reviews.llvm.org/D43012 Files: lib/AST/ASTImporter.cpp test/ASTMerge/var-cpp/Inp

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

yvvan added reviewers: ilya-biryukov, bkramer, arphaman. yvvan added a comment. Looks ok-ish, I haven't built it though. Also I don't have much exp with indexing part of libclang. Adding more reviewers. Repository: rC Clang https://reviews.llvm.org/D42895 _

[PATCH] D42493: [clang-format] Fix ObjC message arguments formatting.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324469: [clang-format] Fix ObjC message arguments formatting. (authored by jolesiak, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42493 Files:

[PATCH] D43009: [clangd] Do not precent-encode numbers in URI.

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jkorous-apple, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43009 Files: clangd/URI.cpp unittests/clangd/URITests.cpp Index: unittests/clangd/URITests.cpp

[PATCH] D42942: [clangd] Collect definitions when indexing.

hokein added inline comments. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67 + // XXX this is just to make running the tool fast during dev! + bool BeginInvocation(CompilerInstance &CI) override { +const auto &Inputs = CI.getInvocation()

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

vitalybuka added a comment. In https://reviews.llvm.org/D42995#1000155, @vitalybuka wrote: > In https://reviews.llvm.org/D42995#125, @tejohnson wrote: > > > > Empty ThinLTOIndexFile signals that we don't need this module during > > > linking. > > > > Not the only case actually. We now also p

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. None of the possible solutions are ideal, but I think I chose the least complex (e.g. via analyzer-config), less edgy one, and 4 is the most common value I ve found so far for PROT_EXEC. Repository: rC Clang https://reviews.llvm.org/D42645 __

Re: r324439 - AST: support SwiftCC on MS ABI

On Wed, Feb 7, 2018 at 8:01 AM, Saleem Abdulrasool via cfe-commits wrote: > On Tue, Feb 6, 2018 at 5:55 PM, Saleem Abdulrasool via cfe-commits > wrote: >> >> Author: compnerd >> Date: Tue Feb 6 17:55:08 2018 >> New Revision: 324439 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=324439&view=r

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 133164. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c I

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values

samparker added a comment. No tests? Repository: rC Clang https://reviews.llvm.org/D42978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. ping... https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

vitalybuka added a comment. In https://reviews.llvm.org/D42995#125, @tejohnson wrote: > > Empty ThinLTOIndexFile signals that we don't need this module during > > linking. > > Not the only case actually. We now also pass an empty index file when we want > to compile the bitcode down to obje

<    1   2