[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/ClangDocBinary.cpp:88 + Stream.Emit((unsigned)'C', 8); + Stream.Emit((unsigned)'S', 8); +} lebedev.ri wrote: > General comment: shouldn't the bitcode be versioned? Possibly? My understanding of the

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 134855. juliehockett marked 14 inline comments as done. juliehockett added a comment. 1. Fixing docs 2. Adding static map from bitcode block/record id to block/record name 3. Pulling magic numbers into one struct 4. Cleaning up and clarifying command

[PATCH] D43429: [clangd] Add missing library (clangLex) in a few places

malaperle abandoned this revision. malaperle added a comment. Already landed in another commit. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43430: Omit nullptr check for sufficiently simple delete-expressions

ahh updated this revision to Diff 134846. ahh added a comment. Fix indentation Repository: rC Clang https://reviews.llvm.org/D43430 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGExprCXX.cpp test/CodeGenCXX/cxx2a-destroying-delete.cpp test/CodeGenCXX/delete-two-arg.cpp

[PATCH] D43430: Omit nullptr check for sufficiently simple delete-expressions

rsmith added a comment. LGTM, but I'd also like @rjmccall's opinion. Repository: rC Clang https://reviews.llvm.org/D43430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43430: Omit nullptr check for sufficiently simple delete-expressions

rsmith added a comment. In https://reviews.llvm.org/D43430#1011269, @kimgr wrote: > I wonder if this could have negative effects for frequent deletion of > nullptrs (e.g. a sometimes-allocated member of a heavily used value type). For that to be better, I think we'd need one of two things to

r325468 - [Analyzer] Move UnexploredFirstStack into an anonymous namespace.

Author: d0k Date: Sun Feb 18 11:08:27 2018 New Revision: 325468 URL: http://llvm.org/viewvc/llvm-project?rev=325468=rev Log: [Analyzer] Move UnexploredFirstStack into an anonymous namespace. No functionality change intended. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp

[clang-tools-extra] r325467 - [tidy] Move private ast matchers into anonymous namespaces to avoid ODR conflicts.

Author: d0k Date: Sun Feb 18 11:02:35 2018 New Revision: 325467 URL: http://llvm.org/viewvc/llvm-project?rev=325467=rev Log: [tidy] Move private ast matchers into anonymous namespaces to avoid ODR conflicts. No functionality change intended. Modified:

Re: [PATCH] D43442: libunwind: when building without threads, pass this to libcxx as well

I’ll have a look this week. -jroelofs On Sun, Feb 18, 2018 at 9:27 AM Rink via Phabricator < revi...@reviews.llvm.org> wrote: > zhmu added a comment. > > I've added jroelofs to the reviewer list as we spoke about this in #llvm > quite some time ago. > > > Repository: > rUNW libunwind > >

[PATCH] D43443: libcxxabi: when building without threads, pass this to libcxx as well

zhmu created this revision. zhmu added a reviewer: jroelofs. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. I'm trying to build libcxxabi as prerequisite for libcxx. The target doesn't yet support userland threads, so I set LIBCXXABI_ENABLE_THREADS to 'OFF' in

[PATCH] D43442: libunwind: when building without threads, pass this to libcxx as well

zhmu added a comment. I've added jroelofs to the reviewer list as we spoke about this in #llvm quite some time ago. Repository: rUNW libunwind https://reviews.llvm.org/D43442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43442: libunwind: when building without threads, pass this to libcxx as well

zhmu created this revision. zhmu added a reviewer: jroelofs. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. I'm trying to build libunwind as prerequisite for libcxx/libcxxabi. The target doesn't yet support userland threads, so I set LIBUNWIND_ENABLE_THREADS to

[PATCH] D43440: clang-format: [JS] fix `of` detection.

mprobst created this revision. mprobst added a reviewer: djasper. Herald added a subscriber: klimek. `of` is only a keyword when after an identifier, but not when after an actual keyword. Before: return of (a, b, c); After: return of(a, b, c); Repository: rC Clang

Re: [PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

On Fri, Feb 16, 2018 at 6:21 PM, Dimitry Andric wrote: > On 17 Feb 2018, at 00:12, Craig Topper via Phabricator < > revi...@reviews.llvm.org> wrote: > > > > craig.topper added inline comments. > > > > > > > > Comment at: lib/Basic/Targets/X86.cpp:1049 > > > >

Re: [PATCH] D43430: Omit nullptr check for sufficiently simple delete-expressions

On Sat, Feb 17, 2018 at 1:41 AM Kim Gräsman via Phabricator < revi...@reviews.llvm.org> wrote: > kimgr added a comment. > > Peanut gallery observation: there was a discussion on the Boost list years > and years ago where someone made the case that `if (x != nullptr) delete > x;` was measurably

[PATCH] D43303: [Format] Fix for bug 35641

kadircet updated this revision to Diff 134830. kadircet added a comment. Rebased and uploaded diff to the master. Sorry for the inconvenience. Repository: rC Clang https://reviews.llvm.org/D43303 Files: lib/Format/WhitespaceManager.cpp unittests/Format/FormatTest.cpp Index:

[PATCH] D43437: [clangd] Fix link failures for Preprocessor::addCommentHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rL325458: [clangd] Fix link failures for Preprocessor::addCommentHandler (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r325458 - [clangd] Fix link failures for Preprocessor::addCommentHandler

Author: aheejin Date: Sun Feb 18 02:50:16 2018 New Revision: 325458 URL: http://llvm.org/viewvc/llvm-project?rev=325458=rev Log: [clangd] Fix link failures for Preprocessor::addCommentHandler Summary: D42640 adds calls to `Preprocessor::addCommentHandler` in

[PATCH] D43437: Fix link failures for Preprocessor::addCommentHandler

ioeric accepted this revision. ioeric added a subscriber: malaperle. ioeric added a comment. This revision is now accepted and ready to land. lg. Thanks! fyi, @malaperle also sent https://reviews.llvm.org/D43429 for the same fix but has not landed it yet ;) Repository: rCTE Clang Tools

[PATCH] D43303: [Format] Fix for bug 35641

lebedev.ri added a comment. The diff looks wrong, the `lib/Format/WhitespaceManager.cpp` change gone missing. You need to upload the diff to the `git master`/svn trunk/etc, *NOT* to the previous commit (previous diff). Repository: rC Clang https://reviews.llvm.org/D43303

[PATCH] D43303: [Format] Fix for bug 35641

kadircet added a comment. Btw, I cannot commit the change myself, don't have commit rights. Repository: rC Clang https://reviews.llvm.org/D43303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43437: Fix link failures for Preprocessor::addCommentHandler

aheejin created this revision. aheejin added a reviewer: ioeric. Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, mgorny, klimek. https://reviews.llvm.org/D42640 adds calls to `Preprocessor::addCommentHandler` in `unittests/clangd/SymbolCollectorTests.cpp` and