ioeric added a comment.
In https://reviews.llvm.org/D43500#1015208, @jdemeule wrote:
> In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote:
>
> > In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote:
> >
> > > Is there a way to make clang-apply-replacements smarter rath
gtbercea created this revision.
gtbercea added reviewers: ABataev, carlo.bertolli, caomhin.
Herald added subscribers: cfe-commits, guansong, jholewinski.
Remove this scheme for now since it will be covered by another more generic
scheme using global memory. This code will be worked into an optimi
Hahnfeld added a comment.
In https://reviews.llvm.org/D43621#1015888, @amccarth wrote:
> This must be new-ish code, since I've routinely used `-fuse-ld=lld` (without
> `.exe`) on Windows.
Well, since 12/2016: https://reviews.llvm.org/rC289668
Repository:
rC Clang
https://reviews.llvm.org/
Author: rksimon
Date: Thu Feb 22 08:12:27 2018
New Revision: 325802
URL: http://llvm.org/viewvc/llvm-project?rev=325802&view=rev
Log:
Fix "not all control paths return a value" MSVC warning. NFCI.
Modified:
clang-tools-extra/trunk/clangd/TUScheduler.cpp
Modified: clang-tools-extra/trunk/clan
ABataev added a comment.
LG
Repository:
rC Clang
https://reviews.llvm.org/D43513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amccarth added a comment.
This must be new-ish code, since I've routinely used `-fuse-ld=lld` (without
`.exe`) on Windows.
Repository:
rC Clang
https://reviews.llvm.org/D43621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
carlo.bertolli updated this revision to Diff 135429.
carlo.bertolli added a comment.
[OpenMP] Add regression test: this verifies that only one call to the runtime
for reduction is done in a combined construct with distribute, without simd,
and with at least one pragma accepting reduction as a cl
I have a small personal project where I used to use this. I tried switching
to instead, but that apparently requires -std=c++17. With that,
things build fine with my locally-built clang, but latest Xcode clang
doesn't accept that flag yet. So I tried -std=c++1z, but latest Xcode (9.2)
doesn't even
ikudrin added inline comments.
Comment at: lib/Driver/ToolChain.cpp:415
// second-guess that.
-if (llvm::sys::fs::exists(UseLinker))
+if (llvm::sys::fs::can_execute(UseLinker))
return UseLinker;
Hahnfeld wrote:
> I don't think we should do thi
Hahnfeld added inline comments.
Comment at: lib/Driver/ToolChain.cpp:415
// second-guess that.
-if (llvm::sys::fs::exists(UseLinker))
+if (llvm::sys::fs::can_execute(UseLinker))
return UseLinker;
I don't think we should do this for absolute pa
ikudrin created this revision.
ikudrin added reviewers: phosek, Hahnfeld, logan, rnk.
ikudrin added a project: clang.
Right now, we have to add an `.exe` suffix when using this switch, like
`-fuse-ld=lld.exe`.
If the suffix is omitted, `llvm::sys::fs::exists()` cannot find the file on
Windows,
w
robot marked an inline comment as done.
robot added a comment.
Have you had the time to review the second revision?
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D42644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Author: sammccall
Date: Thu Feb 22 07:33:33 2018
New Revision: 325801
URL: http://llvm.org/viewvc/llvm-project?rev=325801&view=rev
Log:
[clangd] fix test use-after-free from r325774
Modified:
clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp
Modified: clang-tools-extra/trunk/unit
Author: simark
Date: Thu Feb 22 06:00:39 2018
New Revision: 325784
URL: http://llvm.org/viewvc/llvm-project?rev=325784&view=rev
Log:
[clangd] DidChangeConfiguration Notification
Summary:
Implementation of DidChangeConfiguration notification handling in
clangd. This currently only supports chang
Author: miyuki
Date: Thu Feb 22 01:34:08 2018
New Revision: 325760
URL: http://llvm.org/viewvc/llvm-project?rev=325760&view=rev
Log:
[libcxx] Do not include the C math.h header before __config
Summary:
Certain C libraries require configuration macros defined in __config
to provide the correct fun
Author: AlexeySotkin
Date: Thu Feb 22 03:54:14 2018
New Revision: 325771
URL: http://llvm.org/viewvc/llvm-project?rev=325771&view=rev
Log:
[OpenCL] Add '-cl-uniform-work-group-size' compile option
Summary:
OpenCL 2.0 specification defines '-cl-uniform-work-group-size' option,
which requires that
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2691
+def warn_nocf_check_attribute_ignored :
+ Warning<"nocf_check attribute ignored. Use -fcf-prtection flag to enable
it">,
+ InGroup;
Diagnostics are not complete s
Out of interest, do you know why the non-experimental version doesn't have
to_string()? What are folks supposed to use instead?
On Mon, Feb 5, 2018 at 6:43 PM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Mon Feb 5 15:43:34 2018
> New Revision: 32
nruslan added a comment.
@hans, @craig.topper, @MatzeB: Can someone commit
https://reviews.llvm.org/D43108 (this) and https://reviews.llvm.org/D43107 on
my behalf? I do not think, I have commit access.
https://reviews.llvm.org/D43108
___
cfe-commi
asb added a comment.
Herald added a subscriber: shiva0217.
As @efriedma noted in https://reviews.llvm.org/D43106, it would be good to have
some test coverage for ABI lowering. I'd suggest updating
test/Driver/riscv32-abi.c with something like:
#ifdef __SIZEOF_INT128__
// CHECK-FORCEINT128-L
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325784: [clangd] DidChangeConfiguration Notification
(authored by simark, committed by ).
Herald added a subscriber: llvm-
lebedev.ri added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:149
+
+/// \brief Emits a record ID in the BLOCKINFO block.
+void ClangDocBitcodeWriter::emitRecordID(RecordId ID) {
For me, with no prior knowledge of llvm's bitstreams, it was not obvious
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL325779: [clangd] Correct setting ignoreWarnings in
CodeCompletion. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL L
Author: hokein
Date: Thu Feb 22 05:35:01 2018
New Revision: 325779
URL: http://llvm.org/viewvc/llvm-project?rev=325779&view=rev
Log:
[clangd] Correct setting ignoreWarnings in CodeCompletion.
Summary:
We should set the flag before creating ComplierInstance -- when
CopmilerInstance gets initialize
alexfh added a reviewer: ioeric.
alexfh added a comment.
In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote:
> > It seems, when they are apply directly from clang-tidy, the RefactoringTool
> > engine is smart enough to remove trailing tokens. However, when fixes are
> > exported,
hokein updated this revision to Diff 135399.
hokein added a comment.
- add a comment
- find one more incorrect usage, and fix it.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43569
Files:
clangd/CodeComplete.cpp
clangd/Headers.cpp
Index: clangd/Headers.cpp
=
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/CodeComplete.cpp:705
}
+ CI->getDiagnosticOpts().IgnoreWarnings = true;
auto Clang = prepareCompilerInstance(
ilya-biryukov wrote:
> Could we add a comment that this
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325774: [clangd] Allow embedders some control over when
diagnostics are generated. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
Author: sammccall
Date: Thu Feb 22 05:11:12 2018
New Revision: 325774
URL: http://llvm.org/viewvc/llvm-project?rev=325774&view=rev
Log:
[clangd] Allow embedders some control over when diagnostics are generated.
Summary:
Through the C++ API, we support for a given snapshot version:
- Yes: make su
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a minor nit.
Comment at: clangd/CodeComplete.cpp:705
}
+ CI->getDiagnosticOpts().IgnoreWarnings = true;
auto Clang = prepareCompilerInstance(
-
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM (just one more possibly useful nit about const)
Comment at: clangd/TUScheduler.cpp:298
+ while (shouldSkipHeadLocked())
+Requests.pop_front();
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325771: [OpenCL] Add '-cl-uniform-work-group-size'
compile option (authored by AlexeySotkin, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43570
ilya-biryukov added inline comments.
Comment at: clangd/TUScheduler.cpp:298
+ while (shouldSkipHeadLocked())
+Requests.pop_front();
+ assert(!Requests.empty() && "skipped the whole queue");
sammccall wrote:
> ilya-biryukov wrote:
> > Instead of
oren_ben_simhon marked 2 inline comments as done.
oren_ben_simhon added a comment.
I added a comment ignoring nocf_check attribute in case -fcf-protection is not
set.
Now LLVM is identical to GCC.
Comment at: test/Sema/attr-nocf_check.c:18-20
+ FuncPointerWithNoCfCheck fNoCfC
oren_ben_simhon updated this revision to Diff 135386.
oren_ben_simhon added a comment.
Implemented comments posted until 02/22 (Thanks Aaron).
Repository:
rL LLVM
https://reviews.llvm.org/D41880
Files:
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
Seems safe. Merged in r325766.
On Thu, Feb 22, 2018 at 1:15 AM, Richard Trieu wrote:
> Hi Hans,
>
> If there's still time for rc3, I'd like to get this crash fix in. This adds
> a null check to prevent a crash on invalid.
>
> Richard
>
> On Mon, Feb 5, 2018 at 6:58 PM, Richard Trieu via cfe-comm
ilya-biryukov added a comment.
In https://reviews.llvm.org/D41537#1015563, @yvvan wrote:
> Or is your idea is to return the char sequence instead to use this correction
> in some universal way?
Exactly. Editors that implement corrections would pick up any new corrections
automatically, rather
sammccall added a comment.
Not convinced about the flow control stuff - I think you might be
underestimating the complexity of the cancellation-based approach with the
extra functionality.
But if you think it would still be more readable the other way, happy to get a
third opinion.
=
sammccall updated this revision to Diff 135382.
sammccall marked an inline comment as done.
sammccall added a comment.
add param names to decls
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43518
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServ
krytarowski created this revision.
krytarowski added reviewers: joerg, rnk.
krytarowski added a project: clang.
Herald added a subscriber: llvm-commits.
GCC and PCC define _PTHREADS for -pthreads
on NetBSD.
The _PTHREADS preprocessor macro is used in
the NetBSD header in .
NetBSD uses both: _REE
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325764: [clangd] Not collect include headers for dynamic
index for now. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43550
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
Thanks for fixing all the comments! LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
Author: ioeric
Date: Thu Feb 22 02:14:05 2018
New Revision: 325764
URL: http://llvm.org/viewvc/llvm-project?rev=325764&view=rev
Log:
[clangd] Not collect include headers for dynamic index for now.
Summary:
The new behaviors introduced by this patch:
o When include collection is enabled, we always
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325760: [libcxx] Do not include the C math.h header before
__config (authored by miyuki, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43579
pacxx updated this revision to Diff 135372.
pacxx retitled this revision from "[NameMangling] Make ASTContext owning the
ManglingContext during entire compilation" to "[Indexing] Fixing
inconsistencies between FUNCDNAME and generated code by improving ASTContext's
API for MangleContext".
pacxx e
krisb updated this revision to Diff 135375.
krisb added a comment.
Herald added a subscriber: nhaehnle.
Updated one more test where attributes became mismatched.
Repository:
rC Clang
https://reviews.llvm.org/D43570
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOpti
yvvan added a comment.
Or is your idea is to return the char sequence instead to use this correction
in some universal way?
https://reviews.llvm.org/D41537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
101 - 147 of 147 matches
Mail list logo
