[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 138842. lichray added a comment. Keep patches split Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: .gitignore include/charconv include/support/itoa/ include/support/itoa/itoa.h lib/CMakeLists.txt src/support/itoa/ src/suppor

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray updated this revision to Diff 138841. lichray marked an inline comment as not done. lichray added a comment. Addressing 'Done' comments Repository: rCXX libc++ https://reviews.llvm.org/D41458 Files: .gitignore include/__errc include/charconv include/support/itoa/ include/su

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

lichray marked an inline comment as not done. lichray added inline comments. Comment at: include/support/itoa/itoa.h:29 +UINT64_C(1000), +UINT64_C(1), +UINT64_C(10), EricWF wrote: > The `UINT64_C` and `UINT32_C` macros are non-standard, so I w

[PATCH] D44604: Make stdarg.h compatible with FreeBSD

krytarowski added a comment. This does not fix the potential problem on NetBSD. We define `__VA_LIST_DECLARED` (with extra `_` on the beginning). The proper solution looks to go for: #if __STDC_HOSTED__ && __has_include_next() Repository: rC Clang https://reviews.llvm.org/D44604 _

[PATCH] D44555: clang-interpreter example cmake fix

marsupial accepted this revision. marsupial added a comment. This revision is now accepted and ready to land. Sorry 'bout that... (CMake and quoting make dull boys) Repository: rC Clang https://reviews.llvm.org/D44555 ___ cfe-commits mailing list

[PATCH] D44605: [Driver] Default to DWARF 5 for Fuchsia

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, JDevlieghere, aprantl. We use DWARF 5 on Fuchsia, make it the toolchain default. Repository: rC Clang https://reviews.llvm.org/D44605 Files: clang/lib/Driver/ToolChains/Fuchsia.h clang

[PATCH] D44604: Make stdarg.h compatible with FreeBSD

dim added a comment. I'm fine with either this approach, or with the approach in stdint.h, e.g. using `__has_include_next()`, and in that case first including the system-provided header before this one. Repository: rC Clang https://reviews.llvm.org/D44604

[PATCH] D44604: Make stdarg.h compatible with FreeBSD

arichardson created this revision. arichardson added reviewers: efriedma, dim. Herald added subscribers: cfe-commits, krytarowski, sdardis, emaste. On FreeBSD it is currently not possible to use the clang builtin headers to build the base system. The build will fail with the following error if I d

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

lichray added a comment. LGTM Comment at: test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.cpp:17 }; extern A x; // expected-error {{requires an initializer}} Please add one more test to the end of the file saying ``` static A y; ``` as a remainder

[PATCH] D40445: [C++17] Allow an empty expression in an if init statement

This revision was automatically updated to reflect the committed changes. Closed by commit rC327782: [C++17] Allow an empty expression in an if init statement (authored by lichray, committed by ). Repository: rC Clang https://reviews.llvm.org/D40445 Files: lib/Parse/ParseExprCXX.cpp test/

r327782 - [C++17] Allow an empty expression in an if init statement

Author: lichray Date: Sat Mar 17 14:42:10 2018 New Revision: 327782 URL: http://llvm.org/viewvc/llvm-project?rev=327782&view=rev Log: [C++17] Allow an empty expression in an if init statement Summary: This fixes [PR35381](https://llvm.org/pr35381) and an additional bug where clang didn't warn ab

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel updated this revision to Diff 138832. paulsemel added a comment. Applied Aaron's suggestions Added Sema tests for the typechecking Repository: rC Clang https://reviews.llvm.org/D44093 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp lib/Sema/SemaChecking.cpp

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri updated this revision to Diff 138830. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Adjusted ReleaseNotes change. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44602 Files: clang-tidy/readability/FunctionSizeCheck.cpp clang-tidy/readab

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:122 +- Added `VariableThreshold` to `readability-function-size + `_ check Will be good idea to add //option/

r327781 - Implement DR2229, which prohibits unnamed bit-fields from having qualifiers in C++.

Author: aaronballman Date: Sat Mar 17 14:08:40 2018 New Revision: 327781 URL: http://llvm.org/viewvc/llvm-project?rev=327781&view=rev Log: Implement DR2229, which prohibits unnamed bit-fields from having qualifiers in C++. Added: cfe/trunk/test/CXX/drs/dr22xx.cpp Modified: cfe/trunk/incl

[PATCH] D44534: Fix codegen for structured binding binding in conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rC327780: Fix codegen for structured binding binding in conditions (authored by lichray, committed by ). Repository: rC Clang https://reviews.llvm.org/D44534 Files: lib/CodeGen/CGStmt.cpp test/Parse

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri created this revision. lebedev.ri added reviewers: alexfh, hokein, xazax.hun, JonasToth, aaron.ballman. lebedev.ri added a project: clang-tools-extra. Herald added a subscriber: rnkovacs. Pretty straight-forward, just count all the variable declarations in the function's body, and if m

r327780 - Fix codegen for structured binding binding in conditions

Author: lichray Date: Sat Mar 17 14:01:27 2018 New Revision: 327780 URL: http://llvm.org/viewvc/llvm-project?rev=327780&view=rev Log: Fix codegen for structured binding binding in conditions Summary: The codegen for conditions assumes that a normal variable declaration is used in a condition, bu

[PATCH] D44559: [Sema] Wrong width of result of mul operation

rjmccall added a comment. In https://reviews.llvm.org/D44559#1041002, @lebedev.ri wrote: > In https://reviews.llvm.org/D44559#1041001, @rjmccall wrote: > > > In https://reviews.llvm.org/D44559#1040928, @lebedev.ri wrote: > > > > > In https://reviews.llvm.org/D44559#1040799, @rjmccall wrote: > > >

[PATCH] D44426: Fix llvm + clang build with Intel compiler

zturner added a comment. In https://reviews.llvm.org/D44426#1040938, @nhaehnle wrote: > I don't think we should add workarounds for broken compilers. I don't follow. What should we do then? If LLVM doesn't compile on a compiler which we claim is supported, then how should we proceed? https

[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

mikhail.ramalho added a comment. ping. Repository: rC Clang https://reviews.llvm.org/D42966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44559: [Sema] Wrong width of result of mul operation

lebedev.ri added a comment. In https://reviews.llvm.org/D44559#1041001, @rjmccall wrote: > In https://reviews.llvm.org/D44559#1040928, @lebedev.ri wrote: > > > In https://reviews.llvm.org/D44559#1040799, @rjmccall wrote: > > > > > I think we're correct not to warn here and that GCC/ICC are being

[PATCH] D44559: [Sema] Wrong width of result of mul operation

rjmccall added a comment. In https://reviews.llvm.org/D44559#1040928, @lebedev.ri wrote: > In https://reviews.llvm.org/D44559#1040799, @rjmccall wrote: > > > I think we're correct not to warn here and that GCC/ICC are being noisy. > > The existence of a temporary promotion to a wider type doesn

r327775 - [Driver] Fix the descriptions for -Tdata and -Ttext options

Author: asmith Date: Sat Mar 17 08:24:35 2018 New Revision: 327775 URL: http://llvm.org/viewvc/llvm-project?rev=327775&view=rev Log: [Driver] Fix the descriptions for -Tdata and -Ttext options Reviewers: llvm-commits Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D4458

[PATCH] D44581: [Driver] Fix the descriptions for -Tdata and -Ttext options

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC327775: [Driver] Fix the descriptions for -Tdata and -Ttext options (authored by asmith, committed by ). Repository: rC

r327770 - [cxx_status] Add entry for the Reflection TS.

Author: rsmith Date: Sat Mar 17 07:34:21 2018 New Revision: 327770 URL: http://llvm.org/viewvc/llvm-project?rev=327770&view=rev Log: [cxx_status] Add entry for the Reflection TS. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm

r327769 - [cxx_status] Update to match Jacksonville 2018 motions.

Author: rsmith Date: Sat Mar 17 07:28:47 2018 New Revision: 327769 URL: http://llvm.org/viewvc/llvm-project?rev=327769&view=rev Log: [cxx_status] Update to match Jacksonville 2018 motions. Also rearrange how we list DR motions: rather than listing them as part of some later standard, list them ag

[PATCH] D41808: Rename clang link from clang-X.Y to clang-X

dim added inline comments. Comment at: CMakeLists.txt:422 + "${CLANG_VERSION_MAJOR}" CACHE STRING "Version number that will be placed into the clang executable, in the form XX.YY") set(LIBCLANG_LIBRARY_VERSION Please update the descriptions too, e.g. "

[PATCH] D30863: [clang-format] make docs/tools/{dump_format_style.py, dump_ast_matchers.py} flake8 compliant

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. Looks like it doesn't interest anyone to use coding style on it. https://reviews.llvm.org/D30863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

This revision was automatically updated to reflect the committed changes. Closed by commit rL327768: Adding nocf_check attribute for cf-protection fine tuning (authored by orenb, committed by ). Changed prior to commit: https://reviews.llvm.org/D41880?vs=136235&id=138816#toc Repository: rL L

r327768 - Adding nocf_check attribute for cf-protection fine tuning

Author: orenb Date: Sat Mar 17 06:31:35 2018 New Revision: 327768 URL: http://llvm.org/viewvc/llvm-project?rev=327768&view=rev Log: Adding nocf_check attribute for cf-protection fine tuning The patch adds nocf_check target independent attribute for disabling checks that were enabled by cf-protec

[PATCH] D44426: Fix llvm + clang build with Intel compiler

nhaehnle added a comment. I don't think we should add workarounds for broken compilers. https://reviews.llvm.org/D44426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44559: [Sema] Wrong width of result of mul operation

lebedev.ri added a comment. In https://reviews.llvm.org/D44559#1040799, @rjmccall wrote: > I think we're correct not to warn here and that GCC/ICC are being noisy. The > existence of a temporary promotion to a wider type doesn't justify warning on > arithmetic between two operands that are the

[PATCH] D44580: Sema: allow comparison between blocks & block-compatible objc types

theraven added a comment. We seem to be missing tests for the assignment part of this patch. Comment at: lib/Sema/SemaExpr.cpp:7749 +// id (or strictly compatible object type) -> T^ +if (getLangOpts().ObjC1 && RHSType->isBlockCompatibleObjCPointerType(Context)) {