[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle marked an inline comment as done. malaperle added inline comments. Comment at: clangd/FindSymbols.cpp:31 + + if (supportedSymbolKinds && + std::find(supportedSymbolKinds->begin(), supportedSymbolKinds->end(), MaskRay wrote: > MaskRay wrote: > >

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

malaperle added a comment. Herald added a subscriber: MaskRay. Gentle ping! It would be nice to have this so make Clangd less "verbose". Comment at: clangd/ClangdLSPServer.cpp:412 +llvm::raw_string_ostream OS(Message); +OS << "method not found (" << Method << ")"; +

Re: r328731 - [ObjC++] Make parameter passing and function return compatible with ObjC

On 28 March 2018 at 14:13, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ahatanak > Date: Wed Mar 28 14:13:14 2018 > New Revision: 328731 > > URL: http://llvm.org/viewvc/llvm-project?rev=328731=rev > Log: > [ObjC++] Make parameter passing and function return

r328951 - [Coroutines] Schedule coro-split before asan

Author: modocache Date: Sun Apr 1 16:55:21 2018 New Revision: 328951 URL: http://llvm.org/viewvc/llvm-project?rev=328951=rev Log: [Coroutines] Schedule coro-split before asan Summary: The docs for the LLVM coroutines intrinsic `@llvm.coro.id` state that "The second argument, if not null,

[PATCH] D43927: [Coroutines] Schedule coro-split before asan

This revision was automatically updated to reflect the committed changes. Closed by commit rC328951: [Coroutines] Schedule coro-split before asan (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D43927?vs=136463=140603#toc Repository: rC Clang

[PATCH] D44552: [Coroutines] Find custom allocators in class scope

modocache marked 2 inline comments as done. modocache added a comment. Thanks for the review, @GorNishanov! I adopted your suggestions and made the commit. Repository: rC Clang https://reviews.llvm.org/D44552 ___ cfe-commits mailing list

[PATCH] D44552: [Coroutines] Find custom allocators in class scope

This revision was automatically updated to reflect the committed changes. Closed by commit rC328949: [Coroutines] Find custom allocators in class scope (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D44552?vs=138663=140600#toc Repository: rC Clang

r328949 - [Coroutines] Find custom allocators in class scope

Author: modocache Date: Sun Apr 1 15:59:22 2018 New Revision: 328949 URL: http://llvm.org/viewvc/llvm-project?rev=328949=rev Log: [Coroutines] Find custom allocators in class scope Summary: https://reviews.llvm.org/rL325291 implemented Coroutines TS N4723 section [dcl.fct.def.coroutine]/7, but

[PATCH] D45153: test

shuaiwang created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45153 Files: clang-tidy/utils/ASTUtils.cpp clang-tidy/utils/ASTUtils.h Index: clang-tidy/utils/ASTUtils.h

[PATCH] D45120: [coroutines] Add __builtin_coro_noop => llvm.coro.noop

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Great, thanks! https://reviews.llvm.org/D45120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

mstorsjo created this revision. mstorsjo added reviewers: martell, compnerd, rnk, mati865, ismail, yaron.keren. This avoids looking for a mingw gcc to use as sysroot, preferring the clang installation itself over a similar gcc found in the path. The option name, `--ignore-gcc`, might not be

[PATCH] D45149: MallocChecker, adding specific BSD calls

NoQ added a comment. Nice, thanks. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:662-676 if (Family == AF_Malloc && CheckAlloc) { if (FunI == II_malloc || FunI == II_realloc || FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||

r328942 - Fix a major swiftcall ABI bug with trivial C++ class types.

Author: rjmccall Date: Sun Apr 1 14:04:30 2018 New Revision: 328942 URL: http://llvm.org/viewvc/llvm-project?rev=328942=rev Log: Fix a major swiftcall ABI bug with trivial C++ class types. The problem with the previous logic was that there might not be any explicit copy/move constructor

[PATCH] D45149: MallocChecker, adding specific BSD calls

devnexen created this revision. devnexen added reviewers: NoQ, jdenny. Herald added a subscriber: cfe-commits. - reallocarray/recallocarray - freezero Repository: rC Clang https://reviews.llvm.org/D45149 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/bsd-malloc.c

[PATCH] D45147: [clang] Implement Intercal compatibility feature

lebedev.ri added a comment. testcase Please add docs, release notes entry, and most importantly, tests! Repository: rC Clang https://reviews.llvm.org/D45147 ___ cfe-commits mailing list

[PATCH] D45147: [clang] Implement Intercal compatibility feature

lpereira created this revision. Herald added a subscriber: cfe-commits. This commit is part of a grand series of changes that aims to reduce the amount of evil in the world. The "goto" statement is one of such evils that must be fought; however, due to both compatibility reasons, and lack of

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 140579. zinovy.nis added a comment. - Minor cosmetic fix: use lexical representation instead of semanic for printing callee string. It helps to print class names hidden behind 'typedef' and 'using': using A1 = A; typedef A A2; class C2 :

[PATCH] D44906: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rL328932: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility… (authored by zinovy.nis, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: