jkorous closed this revision.
jkorous added a comment.
I forgot to mention review in commit message.
git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@330608
91177308-0d34-0410-b5e6-96231b3b80d8
https://reviews.llvm.org/D45763
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330609: [clangd][tests] Fix delimiter handling (authored by
jkorous, committed by ).
Herald added subscribers: llvm-commits, klimek.
Changed prior to commit:
https://reviews.llvm.org/D45764?vs=142918&id
Author: jkorous
Date: Mon Apr 23 08:58:42 2018
New Revision: 330609
URL: http://llvm.org/viewvc/llvm-project?rev=330609&view=rev
Log:
[clangd][tests] Fix delimiter handling
Empty line shouldn't be considered a delimiter
Differential Revision: https://reviews.llvm.org/D45764
Added:
clang-too
Author: jkorous
Date: Mon Apr 23 08:55:07 2018
New Revision: 330608
URL: http://llvm.org/viewvc/llvm-project?rev=330608&view=rev
Log:
[clangd][tests] Fix handling of EOF in delimited input
Request in delimited input ended by EOF shouldn't be an error state.
Comments at the end of test file should
asb added a comment.
In https://reviews.llvm.org/D45284#1074282, @apazos wrote:
> Hi Alex, it seems the table expects these extensions in a canonical order
> too: all x extensions, followed by all s extensions, and then all sx
> extensions.
>
> I can make the change, no problem. I have also cod
avt77 added a comment.
In https://reviews.llvm.org/D45619#1075437, @bjope wrote:
> I can't see that it has been reverted.
> But I guess that the table maybe is sorted based on time spent in each pass?
> So that is why it might be sorted differently on different buildbots (or when
> using pipe
a.sidorin closed this revision.
a.sidorin added a comment.
Closed with https://reviews.llvm.org/rC330605. Forgot to mention the
Differential Revision, sorry.
Repository:
rC Clang
https://reviews.llvm.org/D45417
___
cfe-commits mailing list
cfe-c
Author: a.sidorin
Date: Mon Apr 23 08:41:44 2018
New Revision: 330605
URL: http://llvm.org/viewvc/llvm-project?rev=330605&view=rev
Log:
[analyzer] Don't crash on printing ConcreteInt of size >64 bits
Printing of ConcreteInts with size >64 bits resulted in assertion failure
in get[Z|S]ExtValue() b
Author: nico
Date: Mon Apr 23 08:41:08 2018
New Revision: 330604
URL: http://llvm.org/viewvc/llvm-project?rev=330604&view=rev
Log:
Fix case of LLVM library names.
Modified:
cfe/trunk/tools/clang-import-test/CMakeLists.txt
Modified: cfe/trunk/tools/clang-import-test/CMakeLists.txt
URL:
http:
yvvan updated this revision to Diff 143572.
yvvan added a comment.
Use vector instead of optional as Ilya suggested
https://reviews.llvm.org/D41537
Files:
include/clang-c/Index.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/CodeCompleteConsumer.h
include/clang/Sema/Code
Author: d0k
Date: Mon Apr 23 08:27:42 2018
New Revision: 330602
URL: http://llvm.org/viewvc/llvm-project?rev=330602&view=rev
Log:
[clangd] Fix Context::derive to actually call the right method.
C++ is weird.
Modified:
clang-tools-extra/trunk/clangd/Context.h
Modified: clang-tools-extra/trun
Author: nico
Date: Mon Apr 23 08:26:15 2018
New Revision: 330601
URL: http://llvm.org/viewvc/llvm-project?rev=330601&view=rev
Log:
Remove unused code (made unused by r161073, and later more so by r248043).
Modified:
cfe/trunk/tools/diagtool/CMakeLists.txt
Modified: cfe/trunk/tools/diagtool/C
dexonsmith added a comment.
In https://reviews.llvm.org/D30882#1075407, @ddunbar wrote:
> In https://reviews.llvm.org/D30882#1074822, @dexonsmith wrote:
>
> > I don't think this is quite right. I know at least `make`-based
> > incremental builds wouldn't deal well with this.
>
>
> This is actua
bjope added a comment.
I can't see that it has been reverted.
But I guess that the table maybe is sorted based on time spent in each pass? So
that is why it might be sorted differently on different buildbots (or when
using pipe etc).
So I think a quick fix is to add -DAG to the checks that can
yvvan updated this revision to Diff 143566.
yvvan added a comment.
Use wrapped FixItHint to keep corrections.
Can be quite easily changed from Optional to some container if required.
https://reviews.llvm.org/D41537
Files:
include/clang-c/Index.h
include/clang/Basic/DiagnosticSemaKinds.td
avt77 added a comment.
In https://reviews.llvm.org/D45619#1075385, @bjope wrote:
> Anyway, if the order isn't deteministic, then a solution could be to use
> CHECK-DAG instead of CHECK for the checks that may be reordered. For example:
Thank you very much! I'll try to fix it in this way.
Rep
avt77 added a comment.
In https://reviews.llvm.org/D45619#1075260, @thakis wrote:
> In any case, when you see a test failing on bots and the fix isn't obvious,
> revert first to get the bots back green.
I reverted it immediatly.
Repository:
rL LLVM
https://reviews.llvm.org/D45619
_
Author: d0k
Date: Mon Apr 23 07:58:18 2018
New Revision: 330599
URL: http://llvm.org/viewvc/llvm-project?rev=330599&view=rev
Log:
[clangd] Prune some dead declarations. No functionality change.
Modified:
clang-tools-extra/trunk/clangd/Diagnostics.h
clang-tools-extra/trunk/clangd/Trace.h
thakis created this revision.
thakis added a reviewer: JDevlieghere.
Herald added a subscriber: mgorny.
It used to symlink `dsymutil` to `llvm-dsymutil`, but after r327790 llvm's
dsymutil binary is now called dsymutil without prefix.
r327792 then reversed the direction of the symlink if
LLVM_IN
ddunbar added a comment.
In https://reviews.llvm.org/D30882#1074822, @dexonsmith wrote:
> I don't think this is quite right. I know at least `make`-based incremental
> builds wouldn't deal well with this.
This is actually not a novel problem w.r.t. this patch. The exact same
situation comes
miyuki created this revision.
miyuki added a reviewer: eli.friedman.
Herald added subscribers: chrib, kristof.beyls, eraman, rengolin.
Herald added a reviewer: javed.absar.
The getConstraintRegister method is used by semantic checking of
inline assembly statements in order to diagnose conflicts be
Author: henrywong
Date: Mon Apr 23 07:41:17 2018
New Revision: 330596
URL: http://llvm.org/viewvc/llvm-project?rev=330596&view=rev
Log:
[analyzer] Move `TaintBugVisitor` from `GenericTaintChecker.cpp` to
`BugReporterVisitors.h`.
Summary: `TaintBugVisitor` is a universal visitor, and many checker
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330596: [analyzer] Move `TaintBugVisitor` from
`GenericTaintChecker.cpp` to… (authored by henrywong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45682?vs=142621&id=143561#toc
Rep
bjope added a comment.
In https://reviews.llvm.org/D45619#1075089, @avt77 wrote:
> It's terrible but my new test was failed again as result of commit of this
> patch!
>
> ///b/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/clang/test/Frontend/ftime-report-template-decl.cpp:155:11:
> error: e
mstorsjo created this revision.
mstorsjo added reviewers: sepavloff, hfinkel, hans, rnk.
If -no-canonical-prefixes isn't used, the clang executable name used is the one
of the actual executable, not the name of the symlink that the user invoked.
In these cases, the target prefix was overridden
mstorsjo updated this revision to Diff 143558.
mstorsjo retitled this revision from "[WIP] [GCC] Match a GCC version with a
patch suffix without a third version component" to "[GCC] Match a GCC version
with a patch suffix without a third version component".
mstorsjo edited the summary of this rev
Author: d0k
Date: Mon Apr 23 07:30:21 2018
New Revision: 330595
URL: http://llvm.org/viewvc/llvm-project?rev=330595&view=rev
Log:
[index] Fix methods that take a shared_ptr to just take a reference.
There is no ownership here, passing a shared_ptr just adds confusion. No
functionality change inte
Author: d0k
Date: Mon Apr 23 07:30:21 2018
New Revision: 330595
URL: http://llvm.org/viewvc/llvm-project?rev=330595&view=rev
Log:
[index] Fix methods that take a shared_ptr to just take a reference.
There is no ownership here, passing a shared_ptr just adds confusion. No
functionality change inte
sammccall added a comment.
Thanks for the changes! I still find the logic quite confusing. Happy to chat
offline if useful.
Comment at: clangd/XRefs.cpp:137
+
+IdentifiedSymbol getSymbolAtPosition(ParsedAST &AST, SourceLocation Pos) {
+ auto DeclMacrosFinder = std::make_share
In any case, when you see a test failing on bots and the fix isn't obvious,
revert first to get the bots back green.
On Mon, Apr 23, 2018 at 8:54 AM, Andrew V. Tischenko via Phabricator via
cfe-commits wrote:
> avt77 reopened this revision.
> avt77 added a comment.
> This revision is now accepte
a.sidorin marked 2 inline comments as done.
a.sidorin added a comment.
Thank you Gabor!
Comment at: unittests/AST/ASTImporterTest.cpp:356
+ ImportAction(StringRef FromFilename, StringRef ToFilename,
+ const std::string &DeclName)
+ : FromFilename(FromFilenam
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330589: [analyzer] CStringChecker.cpp - Code refactoring on
bug report. (authored by henrywong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44557?vs=138682&id=143545#toc
Reposito
Author: henrywong
Date: Mon Apr 23 06:36:51 2018
New Revision: 330589
URL: http://llvm.org/viewvc/llvm-project?rev=330589&view=rev
Log:
[analyzer] CStringChecker.cpp - Code refactoring on bug report.
Reviewers: NoQ, george.karpenkov, xazax.hun
Reviewed By: george.karpenkov
Differential Revis
krytarowski added subscribers: joerg, krytarowski.
krytarowski added a comment.
Does it work for you for 32-bit? @joerg opposed adoption of 32-bit version as
it seemed to be unimplemented..
Repository:
rL LLVM
https://reviews.llvm.org/D41240
___
avt77 reopened this revision.
avt77 added a comment.
This revision is now accepted and ready to land.
It's terrible but my new test was failed again as result of commit of this
patch!
///b/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/clang/test/Frontend/ftime-report-template-decl.cpp:155:11
Author: klimek
Date: Mon Apr 23 04:47:59 2018
New Revision: 330580
URL: http://llvm.org/viewvc/llvm-project?rev=330580&view=rev
Log:
Fix tests after changes to clang-format in r330573.
We do now both:
- stop reformatting a sequence after a closing brace in more cases, in
order to not misindent
aaron.ballman added a comment.
In https://reviews.llvm.org/D45944#1075055, @lebedev.ri wrote:
> Please always upload all patches with full context (`-U9`)
I'm not keen on uploading patches with that much context. For instance, it
disables syntax highlighting in Phab for many of our files.
aaron.ballman updated this revision to Diff 143526.
aaron.ballman added a comment.
Updated with more context.
https://reviews.llvm.org/D45944
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/builtins.c
Index: test/Sema/builtins.c
aaron.ballman added inline comments.
Comment at: clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:226
+DiagnosticBuilder &Diag) {
+ if (getLangOpts().CPlusPlus11) {
+StringRef NewFuncName = (Name[0] != 'w') ? "strncpy_s" : "wcsncpy_s";
Charusso wrote
lebedev.ri added a comment.
Please always upload all patches with full context (`-U9`)
https://reviews.llvm.org/D45944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330579: [OpenCL] Reject virtual functions for OpenCL C++
(authored by svenvh, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45873?vs=143330&id=143524#toc
Repository:
rC Clang
ht
Author: svenvh
Date: Mon Apr 23 04:23:47 2018
New Revision: 330579
URL: http://llvm.org/viewvc/llvm-project?rev=330579&view=rev
Log:
[OpenCL] Reject virtual functions for OpenCL C++
Differential Revision: https://reviews.llvm.org/D45873
Added:
cfe/trunk/test/Parser/opencl-cxx-virtual.cl
Modi
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, modulo a tiny commenting nit.
Comment at: lib/Lex/Lexer.cpp:1667
+ // Note that code completion token is not added as a separate character
+ //
Author: ro
Date: Mon Apr 23 02:28:08 2018
New Revision: 330572
URL: http://llvm.org/viewvc/llvm-project?rev=330572&view=rev
Log:
[Solaris] __float128 is supported on Solaris/x86
When rebasing https://reviews.llvm.org/D40898 with GCC 5.4 on Solaris 11.4, I
ran
into a few instances of
In file inc
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, dblaikie.
The following code is currently accepted without a diagnostic when it should be
prohibited:
void f(const int *ptr) {
__sync_fetch_and_add(ptr, 1);
}
NB: the above code is diagnosed by GCC and ICC. Howe
Author: miyuki
Date: Mon Apr 23 03:08:46 2018
New Revision: 330575
URL: http://llvm.org/viewvc/llvm-project?rev=330575&view=rev
Log:
[CodeGen] Reland r330442: Add an option to suppress output of llvm.ident
The test case in the original patch was overly contrained and
failed on PPC targets.
Added
Author: krasimir
Date: Mon Apr 23 03:02:59 2018
New Revision: 330574
URL: http://llvm.org/viewvc/llvm-project?rev=330574&view=rev
Log:
[clang-format] Fix clang-tidy readability problems, NFCI
Modified:
cfe/trunk/lib/Format/BreakableToken.h
cfe/trunk/lib/Format/NamespaceEndCommentsFixer.cp
Author: klimek
Date: Mon Apr 23 02:34:26 2018
New Revision: 330573
URL: http://llvm.org/viewvc/llvm-project?rev=330573&view=rev
Log:
Format closing braces when reformatting the line containing the opening brace.
This required a couple of yaks to be shaved:
1. MatchingOpeningBlockLineIndex was mis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330573: Format closing braces when reformatting the line
containing the opening brace. (authored by klimek, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330572: [Solaris] __float128 is supported on Solaris/x86
(authored by ro, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41240?vs=127348&id=1
Author: avt77
Date: Mon Apr 23 02:22:30 2018
New Revision: 330571
URL: http://llvm.org/viewvc/llvm-project?rev=330571&view=rev
Log:
Use special new Clang flag 'FrontendTimesIsEnabled' instead of
'llvm::TimePassesIsEnabled' inside -ftime-report feature.
Differential Revision: https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330571: Use special new Clang flag
'FrontendTimesIsEnabled' instead of 'llvm… (authored by avt77,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
hokein added a comment.
I have updated the patch according to offline discussion -- for each symbol, we
will return both decl and def locations (if available, def first) as they seems
to be most sensible to users. We always prefer location from AST over Index
when conflicts.
hokein updated this revision to Diff 143508.
hokein marked 7 inline comments as done.
hokein added a comment.
Refine the patch and address all review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45717
Files:
clangd/ClangdServer.cpp
clangd/XRefs.cpp
clangd/XRef
whisperity added a comment.
@george.karpenkov @NoQ `bugprone.` as a category sounds nice. It also nicely
corresponds to the Clang-Tidy `bugprone-` category. It would not be nice to
further fragment the "top levels" of checker categories.
I can say with confidence that CodeChecker does not break
Author: krasimir
Date: Mon Apr 23 01:50:36 2018
New Revision: 330569
URL: http://llvm.org/viewvc/llvm-project?rev=330569&view=rev
Log:
Revert "[clang-format] Improve Incomplete detection for (text) protos"
This reverts commit r330016.
The incomplete detection has too many false positives, picking
t.p.northover closed this revision.
t.p.northover added a comment.
Ah, I see you approved it before, presumably with the suggested changes. I've
committed as r330566.
Repository:
rC Clang
https://reviews.llvm.org/D45319
___
cfe-commits mailing l
Author: tnorthover
Date: Mon Apr 23 01:16:24 2018
New Revision: 330566
URL: http://llvm.org/viewvc/llvm-project?rev=330566&view=rev
Log:
[Atomics] warn about atomic accesses using libcalls
If an atomic variable is misaligned (and that suspicion is why Clang emits
libcalls at all) the runtime supp
t.p.northover updated this revision to Diff 143506.
t.p.northover added a comment.
Moved diagnostic emission next to where the decision is made.
Repository:
rC Clang
https://reviews.llvm.org/D45319
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/CodeGen/CGAtomic.cpp
c
devnexen added a comment.
If anybody can land for me, I would appreciate. Thanks regardless :-)
Repository:
rC Clang
https://reviews.llvm.org/D45177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added a comment.
In https://reviews.llvm.org/D45835#1073883, @efriedma wrote:
> > If any of those options we care about wind up being changed, there's a good
> > chance we may need to change something on our end anyway, so breaking us is
> > actually useful.
>
> I'm not sure I fol
101 - 162 of 162 matches
Mail list logo
