[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

delena updated this revision to Diff 146462. delena added a comment. Added a line about *load-store* semantics of these two intrinsics. Removed the common description of memory modeling. Repository: rC Clang https://reviews.llvm.org/D46386 Files: LanguageExtensions.rst Index:

[PATCH] D46791: Make -gsplit-dwarf generally available

trixirt created this revision. trixirt added reviewers: echristo, jakehehrlich, emaste. Herald added subscribers: cfe-commits, JDevlieghere, krytarowski, aprantl, mgorny. Herald added a reviewer: alexshap. Change CLANG_DEFAULT_OBJCOPY from objcopy to llvm-objcopy Remove is-linux checks Add dwarf

r332164 - Add requirement of x86 target for test.

Author: dyung Date: Fri May 11 17:39:17 2018 New Revision: 332164 URL: http://llvm.org/viewvc/llvm-project?rev=332164=rev Log: Add requirement of x86 target for test. Modified: cfe/trunk/test/Driver/clang-abi-compat.cpp Modified: cfe/trunk/test/Driver/clang-abi-compat.cpp URL:

[PATCH] D46767: Force the PS4 clang ABI version to 6, and add a warning if this is attempted to be overridden

rsmith added a comment. Everything old is new again. This was discussed when `-fclang-abi-compat` was introduced; see https://reviews.llvm.org/D36501 for the argument why this patch is the wrong way of modeling an ABI. Forcing the `ClangABICompat` language option as a way of "tricking" Clang

[PATCH] D46767: Force the PS4 clang ABI version to 6, and add a warning if this is attempted to be overridden

This revision was automatically updated to reflect the committed changes. Closed by commit rC332160: Force the PS4 clang ABI version to 6. (authored by dyung, committed by ). Repository: rC Clang https://reviews.llvm.org/D46767 Files: include/clang/Basic/DiagnosticDriverKinds.td

r332160 - Force the PS4 clang ABI version to 6.

Author: dyung Date: Fri May 11 17:06:59 2018 New Revision: 332160 URL: http://llvm.org/viewvc/llvm-project?rev=332160=rev Log: Force the PS4 clang ABI version to 6. The PS4 requires clang ABI version 6 for compatibility reasons. This change forces this and if the user specifies a different

[libcxx] r332159 - [libcxx] [test] Update msvc_stdlib_force_include.hpp.

Author: stl_msft Date: Fri May 11 16:57:32 2018 New Revision: 332159 URL: http://llvm.org/viewvc/llvm-project?rev=332159=rev Log: [libcxx] [test] Update msvc_stdlib_force_include.hpp. Modified: libcxx/trunk/test/support/msvc_stdlib_force_include.hpp Modified:

[PATCH] D46767: Force the PS4 clang ABI version to 6, and add a warning if this is attempted to be overridden

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D46767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42933: [Sema] Avoid -Wformat warning for NSInteger/NSUInteger 'int' values with %zu/%zi long specifiers

smeenai added a comment. Emailed cfe-dev: http://lists.llvm.org/pipermail/cfe-dev/2018-May/057934.html Repository: rC Clang https://reviews.llvm.org/D42933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny added a comment. In https://reviews.llvm.org/D45463#1096629, @rsmith wrote: > In https://reviews.llvm.org/D45463#1096499, @jdenny wrote: > > > A few comments ago , I mentioned > > that IncludeTagDefinition's documentation and name is drifting

[clang-tools-extra] r332152 - [clang-tidy] Fixing fuchsia-restrict-includes-headers test

Author: juliehockett Date: Fri May 11 15:58:45 2018 New Revision: 332152 URL: http://llvm.org/viewvc/llvm-project?rev=332152=rev Log: [clang-tidy] Fixing fuchsia-restrict-includes-headers test Removing filepaths so windows tests pass. Modified:

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

rsmith added a comment. In https://reviews.llvm.org/D45463#1096499, @jdenny wrote: > A few comments ago , I mentioned > that IncludeTagDefinition's documentation and name is drifting farther from > its functionality. Should we do something about that?

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

fedor.sergeev accepted this revision. fedor.sergeev added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D41241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r332143 - [clang-tidy] Cleaning up test output (fuchsia-restrict-system-includes)

Author: juliehockett Date: Fri May 11 14:28:34 2018 New Revision: 332143 URL: http://llvm.org/viewvc/llvm-project?rev=332143=rev Log: [clang-tidy] Cleaning up test output (fuchsia-restrict-system-includes) This should fix the break in the fuchsia-restrict-system-includes-headers test. Modified:

[clang-tools-extra] r332141 - Reland "[clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module"

Author: juliehockett Date: Fri May 11 14:08:59 2018 New Revision: 332141 URL: http://llvm.org/viewvc/llvm-project?rev=332141=rev Log: Reland "[clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module" This relands r332125 with a fixed test. Added:

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny added a comment. In https://reviews.llvm.org/D45463#1096406, @rsmith wrote: > LGTM, thanks! Thanks. I'll remove the fixme as you asked. A few comments ago , I mentioned that IncludeTagDefinition's documentation and name is drifting farther

[PATCH] D46768: [Driver] Only use -lc++ on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL332138: [Driver] Only use -lc++ on Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D46768?vs=146396=146408#toc

r332138 - [Driver] Only use -lc++ on Fuchsia

Author: phosek Date: Fri May 11 13:42:31 2018 New Revision: 332138 URL: http://llvm.org/viewvc/llvm-project?rev=332138=rev Log: [Driver] Only use -lc++ on Fuchsia The fact that libc++ depends on libc++abi and libunwind is an internal detail that's captured by the libc++.so linker script.

r332136 - [analyzer] Ignore the nullability quantifiers for autoreleasewritechecker

Author: george.karpenkov Date: Fri May 11 13:39:19 2018 New Revision: 332136 URL: http://llvm.org/viewvc/llvm-project?rev=332136=rev Log: [analyzer] Ignore the nullability quantifiers for autoreleasewritechecker Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/ObjCAutoreleaseWriteChecker.cpp

r332135 - [analyzer] Fix the filename for the exploration_order test.

Author: george.karpenkov Date: Fri May 11 13:38:39 2018 New Revision: 332135 URL: http://llvm.org/viewvc/llvm-project?rev=332135=rev Log: [analyzer] Fix the filename for the exploration_order test. Ensures that the test is being run. Added:

[PATCH] D46740: [Clang Tablegen][RFC] Allow Early Textual Substitutions in `Diagnostic` messages.

rsmith added a comment. Thank you, I've been wanting this for ages but never got around to it :) (I'd been thinking about doing this by adding custom enum -> text mappings, but I think your approach is at least somewhat more general.) Comment at:

[clang-tools-extra] r332131 - Revert "[clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module"

Author: juliehockett Date: Fri May 11 13:03:22 2018 New Revision: 332131 URL: http://llvm.org/viewvc/llvm-project?rev=332131=rev Log: Revert "[clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module" This reverts commit r332125 for a failing test. Removed:

[PATCH] D46768: [Driver] Only use -lc++ on Fuchsia

phosek updated this revision to Diff 146396. Repository: rC Clang https://reviews.llvm.org/D46768 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/fuchsia.cpp Index: clang/test/Driver/fuchsia.cpp === ---

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: include/clang/AST/Type.h:4903-4910 + /// + /// FIXME: The TagDecl returned is not always exactly faithful to the + /// original source because,

[PATCH] D46768: [Driver] Only use -lc++ on Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added a subscriber: cfe-commits. The fact that libc++ depends on libc++abi and libunwind is an internal detail that's captured by the libc++.so linker script. Repository: rC Clang

r332130 - [libclang] Stop assuming that the internal C++ ABI ExceptionSpecificationType enumeration is the same as CXCursor_ExceptionSpecificationKind.

Author: rsmith Date: Fri May 11 12:46:31 2018 New Revision: 332130 URL: http://llvm.org/viewvc/llvm-project?rev=332130=rev Log: [libclang] Stop assuming that the internal C++ ABI ExceptionSpecificationType enumeration is the same as CXCursor_ExceptionSpecificationKind. Modified:

r332129 - [OPENMP, NVPTX] Do not use SPMD mode for target simd and target teams

Author: abataev Date: Fri May 11 12:45:14 2018 New Revision: 332129 URL: http://llvm.org/viewvc/llvm-project?rev=332129=rev Log: [OPENMP, NVPTX] Do not use SPMD mode for target simd and target teams distribute simd directives. Directives `target simd` and `target teams distribute simd` must be

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added inline comments. Comment at: clangd/CodeComplete.cpp:932 Req.Query = Filter->pattern(); +Req.DeclContexts = {Decl::Kind::Namespace, Decl::Kind::TranslationUnit, +Decl::Kind::LinkageSpec, Decl::Kind::Enum}; I want

[PATCH] D46496: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

ioeric updated this revision to Diff 146393. ioeric added a comment. - Rebase on https://reviews.llvm.org/D46758 Repository: rC Clang https://reviews.llvm.org/D46496 Files: include/clang/Format/Format.h include/clang/Tooling/Core/HeaderIncludes.h lib/Format/Format.cpp

[PATCH] D44954: [clangd] [RFC] Add more symbols to the index

malaperle updated this revision to Diff 146391. malaperle added a comment. Herald added a subscriber: jkorous. Rework to include member vars/functions and scoped enumerators. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44954 Files: clangd/CodeComplete.cpp

[PATCH] D46767: Force the PS4 clang ABI version to 6, and add a warning if this is attempted to be overridden

dyung created this revision. dyung added a reviewer: probinson. For compatibility reasons, the PS4 clang ABI must use version 6, so we force the compiler to use this version if the PS4 target triple is specified. We also emit a new warning now if a clang abi version was specified which is not 6

[PATCH] D46758: [clang-format] Move #include related style to libToolingCore

ioeric updated this revision to Diff 146390. ioeric marked an inline comment as done. ioeric added a comment. Herald added a subscriber: mgorny. - also moved yaml traits. Repository: rC Clang https://reviews.llvm.org/D46758 Files: include/clang/Format/Format.h

[PATCH] D46496: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

ioeric updated this revision to Diff 146385. ioeric added a comment. - Revert commit on wrong branch. Repository: rC Clang https://reviews.llvm.org/D46496 Files: include/clang/Format/Format.h include/clang/Tooling/Core/HeaderIncludes.h include/clang/Tooling/Core/IncludeStyle.h

[PATCH] D46496: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

ioeric updated this revision to Diff 146384. ioeric added a comment. - Also moved yaml traits. Repository: rC Clang https://reviews.llvm.org/D46496 Files: include/clang/Format/Format.h include/clang/Tooling/Core/HeaderIncludes.h include/clang/Tooling/Core/IncludeStyle.h

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

This revision was automatically updated to reflect the committed changes. Closed by commit rL332125: [clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[clang-tools-extra] r332125 - [clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module

Author: juliehockett Date: Fri May 11 12:23:15 2018 New Revision: 332125 URL: http://llvm.org/viewvc/llvm-project?rev=332125=rev Log: [clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module Adding a check to restrict system includes to a whitelist. Given a list of includes that are

[PATCH] D46475: [HIP] Set proper triple and offload kind for the toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL332123: [HIP] Set proper triple and offload kind for the toolchain (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r332123 - [HIP] Set proper triple and offload kind for the toolchain

Author: yaxunl Date: Fri May 11 12:21:39 2018 New Revision: 332123 URL: http://llvm.org/viewvc/llvm-project?rev=332123=rev Log: [HIP] Set proper triple and offload kind for the toolchain Also introduce --hip-link option to indicate HIP for linking. Differential Revision:

[PATCH] D46487: [HIP] Diagnose unsupported host triple

This revision was automatically updated to reflect the committed changes. Closed by commit rL332122: [HIP] Diagnose unsupported host triple (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r332122 - [HIP] Diagnose unsupported host triple

Author: yaxunl Date: Fri May 11 12:14:34 2018 New Revision: 332122 URL: http://llvm.org/viewvc/llvm-project?rev=332122=rev Log: [HIP] Diagnose unsupported host triple Differential Revision: https://reviews.llvm.org/D46487 Modified: cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td

r332121 - [HIP] Let clang-offload-bundler support HIP

Author: yaxunl Date: Fri May 11 12:02:18 2018 New Revision: 332121 URL: http://llvm.org/viewvc/llvm-project?rev=332121=rev Log: [HIP] Let clang-offload-bundler support HIP When bundle/unbundle intermediate files for HIP, there may be multiple sub archs, therefore BoundArch needs to be included

[PATCH] D46473: [HIP] Let clang-offload-bundler support HIP

This revision was automatically updated to reflect the committed changes. Closed by commit rC332121: [HIP] Let clang-offload-bundler support HIP (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D46473 Files: lib/Driver/Driver.cpp

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

rsmith added a comment. Thanks, I think this can be simplified a bit but this looks like the right fix. Comment at: lib/Sema/SemaDecl.cpp:12609-12610 return false; +// We can't simply call Type::isUndeducedType here, because it returns +// false on C++14's auto

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/RestrictSystemIncludesCheck.h:35 + void storeOptions(ClangTidyOptions::OptionMap ) override; + bool contains(StringRef FileName) { +return AllowedIncludesGlobList.contains(FileName);

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/RestrictSystemIncludesCheck.h:35 + void storeOptions(ClangTidyOptions::OptionMap ) override; + bool contains(StringRef FileName) { +return AllowedIncludesGlobList.contains(FileName);

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

aaron.ballman added a comment. Expounding on my concerns a bit -- I'm worried about all the other places calling `isUndeducedType()` and whether they're also at risk and thus a better fix is to change `isUndeducedType()` to pay attention to the language mode. Comment at:

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

rwols added a comment. Can we get this merged soon? I'm experiencing a lot of false positive diagnostics with this library at work. Repository: rC Clang https://reviews.llvm.org/D44480 ___ cfe-commits

[PATCH] D45835: Add new driver mode for dumping compiler options

lebedev.ri added inline comments. Comment at: lib/Frontend/FrontendActions.cpp:779 + { +std::string Str; +#define FEATURE(Name, Predicate) \ This is likely to do an allocation for each feature. Maybe consider

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for adding the glob feature, I think that will be very powerful in practice. Aside from a minor nit, this LGTM! Comment at:

[PATCH] D45835: Add new driver mode for dumping compiler options

aaron.ballman added a comment. Ping. https://reviews.llvm.org/D45835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46651: [OpenCL] Support placement new/delete in Sema

svenvh added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:2030 + } +} rjmccall wrote: > I think a better interpretation of this rule would be to just error on > attempts to use the standard non-placement operator new/delete instead of >

[PATCH] D46740: [Clang Tablegen][RFC] Allow Early Textual Substitutions in `Diagnostic` messages.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This seems like a good idea to me. I wonder if it would be better to take advantage of this to shrink the string tables by preserving the substitution structure until runtime, but that

r332108 - [X86] Fix the file header name on fmaintrin.h

Author: ctopper Date: Fri May 11 10:37:40 2018 New Revision: 332108 URL: http://llvm.org/viewvc/llvm-project?rev=332108=rev Log: [X86] Fix the file header name on fmaintrin.h Modified: cfe/trunk/lib/Headers/fmaintrin.h Modified: cfe/trunk/lib/Headers/fmaintrin.h URL:

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling updated this revision to Diff 146355. rkirsling added a comment. Updated patch to resolve conflict and include full diff context. Repository: rC Clang https://reviews.llvm.org/D46024 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny added inline comments. Comment at: lib/AST/DeclPrinter.cpp:218 for (auto *A : Attrs) { + if (A->isInherited()) +continue; I implemented inherited attribute suppression in this function with the expectation that the test suite would

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny updated this revision to Diff 146351. jdenny marked 10 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. Made the suggested changes. Thanks. https://reviews.llvm.org/D45463 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h

[PATCH] D46685: [CodeGen] Disable structor optimizations at -O0

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rC Clang https://reviews.llvm.org/D46685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett updated this revision to Diff 146349. juliehockett added a comment. Updating parameter list to be a glob-style list. https://reviews.llvm.org/D43778 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp

r332105 - [Hexagon] Implement checking arguments of builtin calls

Author: kparzysz Date: Fri May 11 09:41:51 2018 New Revision: 332105 URL: http://llvm.org/viewvc/llvm-project?rev=332105=rev Log: [Hexagon] Implement checking arguments of builtin calls Added: cfe/trunk/test/CodeGen/hexagon-check-builtins.c Modified: cfe/trunk/include/clang/Sema/Sema.h

[PATCH] D46758: [clang-format] Move #include related style to libToolingCore

ilya-biryukov added inline comments. Comment at: lib/Format/Format.cpp:461 + +template <> struct MappingTraits { + static void mapping(IO , IncludeStyle::IncludeCategory ) { Should we move this to `tooling::Core` too? If we need to specialize `MappingTraits`,

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ilya-biryukov added a comment. > Here :) > > http://www.sidefx.com/docs/hdk/_s_o_p___bone_capture_lines_8proto_8h_source.html Didn't take along to find an example. Thanks for digging this up. That looks like a good enough reason to not apply proto-specific filtering based solely on the

[PATCH] D46496: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

ioeric added a comment. The moving of IncludeStyle has been split into a separate patch https://reviews.llvm.org/D46758. Comment at: include/clang/Format/Format.h:1818 /// from \p Code if it exists. +/// See documentation for `tooling::HeaderIncludes` for the behavior.

[PATCH] D46496: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

ioeric updated this revision to Diff 146339. ioeric marked 3 inline comments as done. ioeric added a comment. - Rebase on https://reviews.llvm.org/D46758 - Addressed comments. Repository: rC Clang https://reviews.llvm.org/D46496 Files: include/clang/Format/Format.h

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ioeric added a comment. Thanks for sharing the example Marc! It's a bit surprising to see files that are not protobuf-generated named proto.h. I'm not a big fan of parsing file comment in proto. It seems a bit cumbersome and we might not be able (or too expensive) to do so for completion

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ioeric updated this revision to Diff 146338. ioeric marked 3 inline comments as done. ioeric added a comment. - Addressed a few comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46751 Files: clangd/index/SymbolCollector.cpp unittests/clangd/SymbolCollectorTests.cpp

[PATCH] D46758: [clang-format] Move #include related style to libToolingCore

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, klimek. This will be shared by include insertion/deletion library. Repository: rC Clang https://reviews.llvm.org/D46758 Files: include/clang/Format/Format.h

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

jkorous planned changes to this revision. jkorous added a comment. Sorry, my bad. I tried to get rid of dependency on Foundation.h and didn't check the test is relevant for the fix after that. #import @interface foo - (void) method NS_AVAILABLE_MAC(10_12); @end int main() {

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

erik.pilkington added a comment. That test passes for me without this patch applied, why is UsesUnderscores actually getting set in the radar? Repository: rC Clang https://reviews.llvm.org/D46747 ___ cfe-commits mailing list

[PATCH] D46602: [clang-tidy] Store checks profiling info as YAML files

lebedev.ri added a comment. In https://reviews.llvm.org/D46602#1095960, @alexfh wrote: > In https://reviews.llvm.org/D46602#1092902, @lebedev.ri wrote: > > > In https://reviews.llvm.org/D46602#1092890, @alexfh wrote: > > > > > Roman, it looks to me that a simpler storage scheme would be

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

malaperle added a comment. In https://reviews.llvm.org/D46751#1095923, @ilya-biryukov wrote: > In https://reviews.llvm.org/D46751#1095894, @malaperle wrote: > > > Can there be an option for this? This seems very library specific and could > > break other code bases. Ideally, there would be a

[PATCH] D46757: [clang-format] Break inside submessages containing a submessage and something else

krasimir created this revision. Herald added subscribers: cfe-commits, klimek. TODO Repository: rC Clang https://reviews.llvm.org/D46757 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D46000: [AST] Added a helper to extract a user-friendly text of a comment.

ilya-biryukov added inline comments. Comment at: include/clang/AST/RawCommentList.h:138 + /// the overload with ASTContext in the rest of the code. + std::string getFormattedText(const SourceManager , + DiagnosticsEngine ) const;

[PATCH] D46000: [AST] Added a helper to extract a user-friendly text of a comment.

ilya-biryukov updated this revision to Diff 146326. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Simplify test code with SourceManagerForFile. Repository: rC Clang https://reviews.llvm.org/D46000 Files: include/clang/AST/CommentLexer.h

[PATCH] D46602: [clang-tidy] Store checks profiling info as YAML files

alexfh added a comment. In https://reviews.llvm.org/D46602#1092902, @lebedev.ri wrote: > In https://reviews.llvm.org/D46602#1092890, @alexfh wrote: > > > Roman, it looks to me that a simpler storage scheme would be sufficient. > > For example, MMDDhhmmss-InputFileName.cpp.csv. > > Main

[PATCH] D33844: [clang-tidy] terminating continue check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D33844#1095862, @koldaniel wrote: > In https://reviews.llvm.org/D33844#1086565, @alexfh wrote: > > > > > > Which comments do you think are still relevant? Weird.

[PATCH] D46683: [X86] Assume alignment of movdir64b dst argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL332091: [X86] Assume alignment of movdir64b dst argument (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46683 Files:

r332091 - [X86] Assume alignment of movdir64b dst argument

Author: gbuella Date: Fri May 11 07:22:04 2018 New Revision: 332091 URL: http://llvm.org/viewvc/llvm-project?rev=332091=rev Log: [X86] Assume alignment of movdir64b dst argument Reviewers: craig.topper Reviewed By: craig.topper Differential Revision: https://reviews.llvm.org/D46683 Modified:

[PATCH] D46684: [Frontend] Don't skip function body when the return type is dependent on the template parameter.

ilya-biryukov added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12645 +if (FD->isConstexpr() || FD->getReturnType()->isUndeducedType() || +FD->getReturnType()->isInstantiationDependentType()) return false; rsmith wrote: > This is a lot

[PATCH] D46676: [clangd] Remove LSP command-based #include insertion.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LG when all the dependencies are done Comment at: unittests/clangd/ClangdTests.cpp:941 -TEST_F(ClangdVFSTest, InsertIncludes) { - MockFSProvider FS;

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ilya-biryukov added a subscriber: sammccall. ilya-biryukov added a comment. So, the first line of the file generated by proto compiler seems to be something like this: // Generated by the protocol buffer compiler. DO NOT EDIT! If we check the symbol comes from a file with this comment,

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ilya-biryukov added a comment. In https://reviews.llvm.org/D46751#1095894, @malaperle wrote: > Can there be an option for this? This seems very library specific and could > break other code bases. Ideally, there would be a generic mechanism for this > kind of filtering, i.e. specify a pattern

[PATCH] D46676: [clangd] Remove LSP command-based #include insertion.

ioeric marked an inline comment as done. ioeric added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:941 -TEST_F(ClangdVFSTest, InsertIncludes) { - MockFSProvider FS; ilya-biryukov wrote: > Do we test the same thing somewhere else (e.g. code

[PATCH] D46676: [clangd] Remove LSP command-based #include insertion.

ilya-biryukov added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:941 -TEST_F(ClangdVFSTest, InsertIncludes) { - MockFSProvider FS; Do we test the same thing somewhere else (e.g. code completion) in one of the dependent changes? Maybe it's

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

malaperle added a comment. Can there be an option for this? This seems very library specific and could break other code bases. Ideally, there would be a generic mechanism for this kind of filtering, i.e. specify a pattern of excluded files or symbol names. But I understand this would be

[PATCH] D46496: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

ilya-biryukov added a comment. This change is big enough to be somewhat hard to grasp. Maybe we could split it into two, to make it easier for review? I.e. - Extraction of IncludeStyle into a separate subclass. - Moving stuff around without other refactorings. Comment at:

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ilya-biryukov added inline comments. Comment at: clangd/index/SymbolCollector.cpp:95 + auto FileName = SM.getFilename(findNameLoc(ND)); + if (FileName.endswith(".proto.h") || FileName.endswith(".pb.h")) { +auto Name = ND->getName(); NIT: reduce nesting by

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

koldaniel added a comment. Do you have any other comments? Could this checker be delivered into `security`? https://reviews.llvm.org/D35068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33844: [clang-tidy] terminating continue check

koldaniel added a comment. In https://reviews.llvm.org/D33844#1086565, @alexfh wrote: > Which comments do you think are still relevant? https://reviews.llvm.org/D33844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46751: [clangd] Filter out private proto symbols in SymbolCollector.

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jkorous, MaskRay, klimek. This uses heuristics to identify private proto symbols. For example, top-level symbols whose name contains "_" are considered private. These symbols are not

[PATCH] D46685: [CodeGen] Disable structor optimizations at -O0

labath updated this revision to Diff 146309. labath added a comment. Yes we can do that. Only the RAUW optimization is nasty, I've checked that the debugger is able to use the alias with no problem. Updated the patch the reflect that. Repository: rC Clang https://reviews.llvm.org/D46685

[PATCH] D46670: [clangd] Move helpers that convert Replacements to TextEdits to SourceCode.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL332089: [clangd] Move helpers that convert Replacements to TextEdits to SourceCode.h (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r332089 - [clangd] Move helpers that convert Replacements to TextEdits to SourceCode.h

Author: ioeric Date: Fri May 11 05:12:08 2018 New Revision: 332089 URL: http://llvm.org/viewvc/llvm-project?rev=332089=rev Log: [clangd] Move helpers that convert Replacements to TextEdits to SourceCode.h Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: klimek, MaskRay,

[PATCH] D46670: [clangd] Move helpers that convert Replacements to TextEdits to SourceCode.h

ioeric added inline comments. Comment at: clangd/SourceCode.h:62 +std::vector +replacementsToEdits(StringRef Code, +const std::vector ); ilya-biryukov wrote: > Do we really need to expose separate functions for > `vector` and

[PATCH] D46670: [clangd] Move helpers that convert Replacements to TextEdits to SourceCode.h

ioeric updated this revision to Diff 146303. ioeric marked 2 inline comments as done. ioeric added a comment. - Got rid of a helper for std::vector Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46670 Files: clangd/ClangdLSPServer.cpp clangd/SourceCode.cpp

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

jkorous created this revision. jkorous added reviewers: arphaman, erik.pilkington, vsapsai. jkorous added a project: clang. Herald added a subscriber: cfe-commits. E. g. use "10.11" instead of "10_11". This is just a consistency fix - the dotted format is already used everywhere else.

[PATCH] D46676: [clangd] Remove LSP command-based #include insertion.

ioeric added a comment. In https://reviews.llvm.org/D46676#1095713, @ilya-biryukov wrote: > This LG, but we should first roll out the `additionalEdits` change. > Aren't the dependencies reversed in the dependency stack, i.e. this change > should be the last one? You are right ;) I got the

[PATCH] D46742: [X86] Use __builtin_convertvector to replace some of the avx512 truncate builtins.

GBuella added a comment. In https://reviews.llvm.org/D46742#1095658, @tkrupa wrote: > There are four other similar intrinsics which convert to 128/256-bit vectors: > > __m128i _mm256_cvtepi32_epi8 (__m256i a) > __m128i _mm256_cvtepi64_epi16 (__m256i a) > __m128i _mm256_cvtepi64_epi8 (__m256i

[PATCH] D46742: [X86] Use __builtin_convertvector to replace some of the avx512 truncate builtins.

tkrupa added a comment. Nevermind - these four are not strictly truncating. Sorry for the confusion. Repository: rC Clang https://reviews.llvm.org/D46742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46670: [clangd] Move helpers that convert Replacements to TextEdits to SourceCode.h

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, just a few non-blocking NITs with questions. Comment at: clangd/SourceCode.cpp:180 + // Turn the replacements into the format specified by the Language

[PATCH] D46676: [clangd] Remove LSP command-based #include insertion.

ilya-biryukov added a comment. This LG, but we should first roll out the `additionalEdits` change. Aren't the dependencies reversed in the dependency stack, i.e. this change should be the last one? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46676

  1   2   >