[PATCH] D46942: Add vfs::FileSystem::getRealPath

ioeric added inline comments. Comment at: lib/Basic/FileManager.cpp:537 -#ifdef LLVM_ON_UNIX - char CanonicalNameBuf[PATH_MAX]; - if (realpath(Dir->getName().str().c_str(), CanonicalNameBuf)) + SmallString CanonicalNameBuf; + if (!FS->getRealPath(Dir->getName(),

[PATCH] D46942: Add vfs::FileSystem::getRealPath

ioeric updated this revision to Diff 147278. ioeric marked an inline comment as done. ioeric added a comment. - s/PATH_MAX/4096/ Repository: rC Clang https://reviews.llvm.org/D46942 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/FileManager.cpp

[PATCH] D44954: [clangd] Add "member" symbols to the index

ilya-biryukov added a comment. A few questions regarding class members. To pinpoint some interesting cases and agree on how we want those to behave in the long run. How do we handle template specializations? What will the qualified names of those instantiations be? I.e. how do I query for

[PATCH] D46958: [ASTImporter] Fix missing implict CXXRecordDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL332588: [ASTImporter] Fix missing implict CXXRecordDecl (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46958 Files:

[PATCH] D46942: Add vfs::FileSystem::getRealPath

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good. Please watch the windows buildbots carefully after landing this. Comment at: lib/Basic/FileManager.cpp:537 -#ifdef LLVM_ON_UNIX - char

[PATCH] D46891: [StaticAnalyzer] Added a getLValue method to ProgramState for bases

Szelethus added a comment. Thanks for the review! If you like the new overload, can you please commit this for me? https://reviews.llvm.org/D46891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43667: [clang-doc] Implement a YAML generator

ioeric added inline comments. Comment at: clang-doc/Representation.h:238 + // Non-const accessors for YAML output. + std::vector () { return NamespaceInfos; } There are two alternatives to avoid this: 1) Pull the info storage into a separate struct e.g.

[PATCH] D47007: [Sanitizer] CStringChecker fix for strlcpy when no bytes are copied to the dest buffer

devnexen created this revision. devnexen added reviewers: NoQ, george.karpenkov. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Again strlc* does not return a pointer so the zero size case does not fit. Repository: rC Clang

Re: r332458 - [AST] Added a helper to extract a user-friendly text of a comment.

Terribly sorry for the breakage and many thanks for fixing this! On Thu, May 17, 2018 at 9:04 AM Clement Courbet wrote: > I should have fixed it in r332576. > > On Wed, May 16, 2018 at 11:49 PM, Galina Kistanova via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >>

r332587 - [libclang] Allow skipping function bodies in preamble only

Author: yvvan Date: Thu May 17 02:24:37 2018 New Revision: 332587 URL: http://llvm.org/viewvc/llvm-project?rev=332587=rev Log: [libclang] Allow skipping function bodies in preamble only Second attempt. Fix line endings and warning. As an addition to CXTranslationUnit_SkipFunctionBodies, provide

[PATCH] D46958: [ASTImporter] Fix missing implict CXXRecordDecl

martong added a comment. In https://reviews.llvm.org/D46958#1101570, @a.sidorin wrote: > So, we fail to add injected name to a CXXRecordDecl that has a described > class template? Yes, we failed to import the implicit `CXXRecordDecl`. Here is how it looked before the fix: From:

r332586 - [Frontend] Avoid running plugins during code completion parse

Author: yvvan Date: Thu May 17 02:21:07 2018 New Revision: 332586 URL: http://llvm.org/viewvc/llvm-project?rev=332586=rev Log: [Frontend] Avoid running plugins during code completion parse Second attempt. Proper line endings. The parsing that is done for code completion is a special case that

r332585 - Revert https://reviews.llvm.org/D46050 and https://reviews.llvm.org/D45815

Author: yvvan Date: Thu May 17 02:15:22 2018 New Revision: 332585 URL: http://llvm.org/viewvc/llvm-project?rev=332585=rev Log: Revert https://reviews.llvm.org/D46050 and https://reviews.llvm.org/D45815 Windows line endings. Requires proper resubmission. Removed:

[PATCH] D46835: [ASTImporter] Do not try to remove invisible Decls from DeclContext

martong updated this revision to Diff 147274. martong added a comment. Addressing review comments. Repository: rC Clang https://reviews.llvm.org/D46835 Files: lib/AST/DeclBase.cpp unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImporterTest.cpp

[PATCH] D46940: [ASTImporter] make sure that ACtx::getParents still works

r.stahl updated this revision to Diff 147268. r.stahl marked 2 inline comments as done. r.stahl added a comment. addressed review comments https://reviews.llvm.org/D46940 Files: include/clang/AST/ASTContext.h lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index:

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

ilya-biryukov added a comment. Sorry, a few more things and we're good to go. Comment at: include/clang/Driver/CC1Options.td:449 +def code_completion_include_fixits : Flag<["-"], "code-completion-include-fixits">, + HelpText<"Include code completion results which require

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. Hi Aleksei, I am OK with this, I just have a little concern about friend declarations. Since https://reviews.llvm.org/D32947 ( [ASTImporter] FriendDecl importing improvements ) records' structural equivalency depends on the order of their friend declarations. Anyway,

[PATCH] D46879: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver

This revision was automatically updated to reflect the committed changes. Closed by commit rL332582: [clang-format] Fix putting ObjC message arguments in one line for multiline… (authored by jolesiak, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D46879: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver

This revision was automatically updated to reflect the committed changes. Closed by commit rC332582: [clang-format] Fix putting ObjC message arguments in one line for multiline… (authored by jolesiak, committed by ). Changed prior to commit: https://reviews.llvm.org/D46879?vs=146818=147265#toc

r332582 - [clang-format] Fix putting ObjC message arguments in one line for multiline receiver

Author: jolesiak Date: Thu May 17 01:35:15 2018 New Revision: 332582 URL: http://llvm.org/viewvc/llvm-project?rev=332582=rev Log: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver Summary: Currently BreakBeforeParameter is set to true everytime message

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

yvvan added a comment. Tests run fine but the solution feels like a workaround. Nevertheless if we are sure that extending the subscript/call operator range does not work properly or breaks too many other things than it's probably fine to have this workaround. https://reviews.llvm.org/D40481

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1560-1566 // If the size is known to be zero, we're done. if (StateZeroSize && !StateNonZeroSize) { StateZeroSize = StateZeroSize->BindExpr(CE, LCtx, DstVal);

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

This revision was automatically updated to reflect the committed changes. Closed by commit rC332578: [libclang] Allow skipping function bodies in preamble only (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D45815?vs=145648=147253#toc Repository: rC

r332578 - [libclang] Allow skipping function bodies in preamble only

Author: yvvan Date: Thu May 17 00:31:29 2018 New Revision: 332578 URL: http://llvm.org/viewvc/llvm-project?rev=332578=rev Log: [libclang] Allow skipping function bodies in preamble only As an addition to CXTranslationUnit_SkipFunctionBodies, provide the new option

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

phosek added inline comments. Comment at: lib/Index/USRGeneration.cpp:691 +case BuiltinType::ULongAccum: + llvm_unreachable("No USR name mangling for fixed point types."); case BuiltinType::Float16: We need some solution for fixed point

Re: r332458 - [AST] Added a helper to extract a user-friendly text of a comment.

I should have fixed it in r332576. On Wed, May 16, 2018 at 11:49 PM, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Also few other builders are affected: > > http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test >

r332576 - Fix rL332458: [AST] Added a helper to extract a user-friendly text of a comment.

Author: courbet Date: Wed May 16 23:46:15 2018 New Revision: 332576 URL: http://llvm.org/viewvc/llvm-project?rev=332576=rev Log: Fix rL332458: [AST] Added a helper to extract a user-friendly text of a comment. Older gcc versions do not support raw string literals within macros. Modified:

[PATCH] D46998: [XRay][clang+compiler-rt] Make XRay depend on a C++ standard lib

dberris created this revision. dberris added reviewers: dblaikie, echristo. This is related to http://llvm.org/PR32274. When building with XRay, always depend on a C++ standard library. We're doing this to automate the linking of the C++ ABI functionality that the modes use by default. In

[PATCH] D46929: Fix a mangling failure on clang-cl C++17

tzik added a comment. In https://reviews.llvm.org/D46929#1101780, @rnk wrote: > I searched around, and I noticed that `VTableContext::getMethodVTableIndex` > has the same implied contract that the caller must always provide a canonical > declaration or things will break. It looks like it has

<    1   2