r333062 - [X86] In the floating point max reduction intrinsics, negate infinity before feeding it to set1.

Author: ctopper Date: Tue May 22 22:51:52 2018 New Revision: 333062 URL: http://llvm.org/viewvc/llvm-project?rev=333062=rev Log: [X86] In the floating point max reduction intrinsics, negate infinity before feeding it to set1. Previously we negated the whole vector after splatting infinity. But

[PATCH] D47247: Fix unaligned memory access when reading INPUT_FILE_OFFSETS data

teemperor created this revision. teemperor added reviewers: rsmith, v.g.vassilev. The blob data is unaligned, so we also should read it as such. Should fix the random failures with the sanitizer builds. Repository: rC Clang https://reviews.llvm.org/D47247 Files:

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

ahatanak added a comment. In https://reviews.llvm.org/D45015#1105314, @rsmith wrote: > Hmm, perhaps our strategy for handling aligned allocation on Darwin should be > revisited. We shouldn't be defining `__cpp_aligned_allocation` if we believe > it doesn't work -- that will break code that

[PATCH] D47067: Update NRVO logic to support early return

tzik added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12760 // to deduce an implicit return type. - if (FD->getReturnType()->isRecordType() && - (!getLangOpts().CPlusPlus || !FD->isDependentContext())) + if (!FD->getReturnType()->isScalarType())

[PATCH] D47007: [analyzer] CStringChecker fix for strlcpy when no bytes are copied to the dest buffer

This revision was automatically updated to reflect the committed changes. Closed by commit rC333060: [analyzer] CStringChecker fix for strlcpy when no bytes are copied to the dest… (authored by devnexen, committed by ). Repository: rC Clang https://reviews.llvm.org/D47007 Files:

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

rjmccall added a comment. There are at least three good reasons to make sure this can enabled/disabled by a flag: - We have to anticipate that introducing new keywords will cause some compatibility problems. New language standards that introduce new keywords can be disabled using `-std=`.

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

jfb added a comment. This is on by default for any version of C? AFAICK `_Accum` isn't on the C17 draft that I have, I'd expect to have to specify a command-line flag pertaining to TR 18037 to get this. At a minimum I'd be OK having it with the GNU variant of C, but not the `__ANSI_C__` one.

[PATCH] D47103: Implement strip.invariant.group

rjmccall added a comment. The changes to Clang generally seem reasonable, but I think you should split them into a separate commit from the commit that adds the intrinsic itself. Comment at: clang/lib/CodeGen/CGExpr.cpp:3858 +} + } + Please add a comment

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

rjmccall added a reviewer: akyrtzi. rjmccall added a comment. CC: Argyrios for the USR question. Repository: rC Clang https://reviews.llvm.org/D46084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47108: [CodeGenCXX] Add -fforce-emit-vtables

rjmccall added a comment. I thought we already had places in Sema that marked inline virtual methods as used, instantiated templates, etc. for devirtualization purposes when optimization was enabled. Did we rip that out? The problem we've had over and over with devirtualization is that we

[libcxx] r333058 - Mark more bits of P0433 as complete.

Author: marshall Date: Tue May 22 20:22:59 2018 New Revision: 333058 URL: http://llvm.org/viewvc/llvm-project?rev=333058=rev Log: Mark more bits of P0433 as complete. Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

rsmith added subscribers: echristo, dblaikie, rjmccall. rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticCommonKinds.td:172 +def err_fixed_point_only_allowed_in_c : Error< + "Fixed point types are only allowed in C">; Diagnostics should

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 148148. leonardchan added a comment. pulled changes from source tree Repository: rC Clang https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def

[PATCH] D45898: [SemaCXX] Mark destructor as referenced

ahatanak added a comment. In https://reviews.llvm.org/D45898#1104025, @rsmith wrote: > As it happens, the C++ committee fixed the language wording hole here very > recently. The new rule can be found here: http://wg21.link/p0968r0#2227 > In summary: we should to consider the destructor for all

[libcxx] r333050 - Implement deduction guides for basic_regex

Author: marshall Date: Tue May 22 18:57:02 2018 New Revision: 333050 URL: http://llvm.org/viewvc/llvm-project?rev=333050=rev Log: Implement deduction guides for basic_regex Added: libcxx/trunk/test/std/re/re.regex/re.regex.construct/deduct.fail.cpp

[PATCH] D47175: [DOXYGEN] Formatting changes for better intrinsics documentation rendering

dyung added a comment. LGTM Repository: rC Clang https://reviews.llvm.org/D47175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r333046 - [AST][ObjC] Print implicit property expression that only has a setter without crashing

Author: arphaman Date: Tue May 22 17:52:20 2018 New Revision: 333046 URL: http://llvm.org/viewvc/llvm-project?rev=333046=rev Log: [AST][ObjC] Print implicit property expression that only has a setter without crashing rdar://40447209 Modified: cfe/trunk/include/clang/Basic/IdentifierTable.h

[PATCH] D47166: use zeroinitializer for (trailing zero portion of) large array initializers more reliably

This revision was automatically updated to reflect the committed changes. Closed by commit rC333044: Use zeroinitializer for (trailing zero portion of) large array initializers (authored by rsmith, committed by ). Repository: rC Clang https://reviews.llvm.org/D47166 Files:

r333044 - Use zeroinitializer for (trailing zero portion of) large array initializers

Author: rsmith Date: Tue May 22 17:09:29 2018 New Revision: 333044 URL: http://llvm.org/viewvc/llvm-project?rev=333044=rev Log: Use zeroinitializer for (trailing zero portion of) large array initializers more reliably. Clang has two different ways it emits array constants (from InitListExprs and

[PATCH] D47233: [CodeGen] Emit MSVC RTTI for Obj-C EH types

smeenai updated this revision to Diff 148133. smeenai added a comment. Colocate CHECK lines with declarations Repository: rC Clang https://reviews.llvm.org/D47233 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGObjCMac.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenObjC/dllstorage.m

[PATCH] D47154: Try to make builtin address space declarations not useless

tra added a comment. CUDA does not expose explicit AS on clang size. All pointers are treated as generic and we infer specific address space only in LLVM. `__nvvm_atom_*_[sg]_*` builtins should probably be removed as they are indeed useless without pointers with explicit AS and NVCC itself does

[PATCH] D47138: [Sparc] Use the leon arch for Leon3's when using an external assembler

joerg added a comment. This still needs a test case? https://reviews.llvm.org/D47138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47070: [CUDA] Upgrade linked bitcode to enable inlining

tra added a comment. In https://reviews.llvm.org/D47070#1106018, @echristo wrote: > > As a short-term fix we can disable feature-to-function attribute > > propagation for NVPTX until we fix it. > > > > @echristo -- any other suggestions? > > This is some of what I was talking about when I was

[PATCH] D47202: [CodeGen] use nsw negation for abs

This revision was automatically updated to reflect the committed changes. Closed by commit rC333038: [CodeGen] use nsw negation for builtin abs (authored by spatel, committed by ). Repository: rC Clang https://reviews.llvm.org/D47202 Files: lib/CodeGen/CGBuiltin.cpp

[PATCH] D47202: [CodeGen] use nsw negation for abs

This revision was automatically updated to reflect the committed changes. Closed by commit rL333038: [CodeGen] use nsw negation for builtin abs (authored by spatel, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r333038 - [CodeGen] use nsw negation for builtin abs

Author: spatel Date: Tue May 22 16:02:13 2018 New Revision: 333038 URL: http://llvm.org/viewvc/llvm-project?rev=333038=rev Log: [CodeGen] use nsw negation for builtin abs The clang builtins have the same semantics as the stdlib functions. The stdlib functions are defined in section 7.20.6.1 of

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 148121. Repository: rC Clang https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/Specifiers.h

[PATCH] D47233: [CodeGen] Emit MSVC RTTI for Obj-C EH types

smeenai created this revision. smeenai added reviewers: DHowett-MSFT, compnerd, majnemer, rjmccall, rnk. We're implementing funclet-compatible code generation for Obj-C exceptions when using the MSVC ABI. The idea is that the Obj-C runtime will wrap Obj-C exceptions inside C++ exceptions, which

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 148117. leonardchan marked an inline comment as done. Repository: rC Clang https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def

[PATCH] D46986: [Fixed Point Arithmetic] Validation Test for Fixed Point Binary Operations and Saturated Addition

leonardchan updated this revision to Diff 148116. leonardchan added a comment. - formatting - Running `lli` threw a segfault in the test, though this was probably because it was using whatever hist jit was available to optimize the code instead of just interpreting it. Forcing it just interpret

[PATCH] D47182: [X86] Move all Intel defined intrinsic includes into immintrin.h

craig.topper updated this revision to Diff 148115. craig.topper added a comment. Leave the message still saying x86intrin.h. Change the error checks to look for either x86intrin.h or immintrin.h to have been included. Really only the immintrin.h check is necessary since that's the header that

[PATCH] D47174: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

craig.topper added a comment. Implemented @DavidKreitzer's suggestion in r333033 Repository: rL LLVM https://reviews.llvm.org/D47174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r333033 - [X86] As mentioned in post-commit feedback in D47174, move the 128 bit f16c intrinsics into f16cintrin.h and remove __emmintrin_f16c.h

Author: ctopper Date: Tue May 22 15:19:19 2018 New Revision: 333033 URL: http://llvm.org/viewvc/llvm-project?rev=333033=rev Log: [X86] As mentioned in post-commit feedback in D47174, move the 128 bit f16c intrinsics into f16cintrin.h and remove __emmintrin_f16c.h These were included in

[PATCH] D47138: [Sparc] Use the leon arch for Leon3's when using an external assembler

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D47138#1107637, @dcederman wrote: > I did not find a good way to access the SparcCPUInfo struct from here. No > other arch under Toolchains seems to access

[PATCH] D47229: Make atomic non-member functions as nonnull

jfb created this revision. jfb added a reviewer: arphaman. Herald added subscribers: cfe-commits, aheejin. As a companion to libc++ patch https://reviews.llvm.org/D47225, mark builtin atomic non-member functions which accept pointers as nonnull. The atomic non-member functions accept pointers

[PATCH] D47182: [X86] Move all Intel defined intrinsic includes into immintrin.h

DavidKreitzer added a comment. I agree with the changes in x86intrin.h and immintrin.h. For the others, I question whether we ought to recommend inclusion of x86intrin.h or immintrin.h. The distinction as I understand it is that immintrin.h is used for Intel-specific intrinsics while

r333027 - [X86] Remove mask argument from some builtins that are handled completely in CGBuiltin.cpp. Just wrap a select builtin around them in the header file instead.

Author: ctopper Date: Tue May 22 13:48:24 2018 New Revision: 333027 URL: http://llvm.org/viewvc/llvm-project?rev=333027=rev Log: [X86] Remove mask argument from some builtins that are handled completely in CGBuiltin.cpp. Just wrap a select builtin around them in the header file instead.

r333026 - [X86] Another attempt at fixing the intrinsic module map for rr333014.

Author: ctopper Date: Tue May 22 13:48:20 2018 New Revision: 333026 URL: http://llvm.org/viewvc/llvm-project?rev=333026=rev Log: [X86] Another attempt at fixing the intrinsic module map for rr333014. Modified: cfe/trunk/lib/Headers/module.modulemap Modified:

[PATCH] D47174: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

DavidKreitzer added a comment. A bit of history: In icc, the f16<=>f32 conversion intrinsics are a bit of an anomaly in that they can be implemented using either native code or emulation code based on the target architecture switch. See https://godbolt.org/g/bQy7xY (thanks, Craig, for the

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. ping https://reviews.llvm.org/D43341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added a comment. In https://reviews.llvm.org/D44954#1104497, @malaperle wrote: > >>> What scopes will non-scoped enum members have? > >> > >> Hmm. I think all of them, since you can refer them like that in code too. > >> Case #1 doesn't work but that was the case before this patch so

[PATCH] D47225: Add nonnull; use it for atomics

jfb created this revision. jfb added reviewers: arphaman, EricWF. Herald added subscribers: cfe-commits, christof, aheejin. The atomic non-member functions accept pointers to std::atomic / std::atomic_flag as well as to the non-atomic value. These are all dereferenced unconditionally when

[PATCH] D47223: [clangd] Handle enumerators in named, unscoped enums similarly to scoped enums

malaperle created this revision. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov, klimek. For enumerators in unscoped enums that have names, even if they are not scoped, we add the enum name to the scope so that users can find the enumerators when fully qualifying

[PATCH] D47067: Update NRVO logic to support early return

Quuxplusone added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12760 // to deduce an implicit return type. - if (FD->getReturnType()->isRecordType() && - (!getLangOpts().CPlusPlus || !FD->isDependentContext())) + if

r333023 - [X86] Add two missing #endif directives to immintrin.h that should have been in r333014.

Author: ctopper Date: Tue May 22 13:33:04 2018 New Revision: 333023 URL: http://llvm.org/viewvc/llvm-project?rev=333023=rev Log: [X86] Add two missing #endif directives to immintrin.h that should have been in r333014. Modified: cfe/trunk/lib/Headers/immintrin.h Modified:

[PATCH] D47135: [analyzer][WIP] A checker for dangling string pointers in C++

NoQ added a comment. We'll have to track `string_view` ourselves, not relying on `MallocChecker`. So we only need an `AF_` for the pointer case. `DanglingInternalBufferChecker` and `AF_InternalBuffer` sound great to me. Repository: rC Clang https://reviews.llvm.org/D47135

r333020 - [X86] Add __emmintrin_f16c.h to module map and CMakeLists.

Author: ctopper Date: Tue May 22 13:19:05 2018 New Revision: 333020 URL: http://llvm.org/viewvc/llvm-project?rev=333020=rev Log: [X86] Add __emmintrin_f16c.h to module map and CMakeLists. I missed this in r333014 Modified: cfe/trunk/lib/Headers/CMakeLists.txt

[PATCH] D47135: [analyzer][WIP] A checker for dangling string pointers in C++

rnkovacs added a comment. Thanks for your comments! It would be nice if we could reach a consensus on the naming issue before I update the patch. I was wondering, as we plan to support stuff like `std::vector::data()`, which is not a string, and `std::string_view`, which is not strictly a

[PATCH] D41458: [libc++][C++17] Elementary string conversions for integral types

Quuxplusone added inline comments. Comment at: include/charconv:89 +_LIBCPP_BEGIN_NAMESPACE_STD + +enum class _LIBCPP_ENUM_VIS chars_format lichray wrote: > mclow.lists wrote: > > lichray wrote: > > > EricWF wrote: > > > > We need to hide these names when

[PATCH] D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type

zinovy.nis added inline comments. Comment at: clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:198 E = E->ignoreParenBaseCasts(); + if (const auto *EC = dyn_cast(E)) +E = EC->getSubExpr(); zinovy.nis wrote: > malcolm.parsons

[PATCH] D47166: use zeroinitializer for (trailing zero portion of) large array initializers more reliably

rjmccall accepted this revision. rjmccall added a comment. LGTM, thanks! Repository: rC Clang https://reviews.llvm.org/D47166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47166: use zeroinitializer for (trailing zero portion of) large array initializers more reliably

rsmith added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:675 + // We have mixed types. Use a packed struct. + std::vector Types; + Types.reserve(Elements.size()); rjmccall wrote: > Why std::vector? Only because this was extracted from the old

[PATCH] D47166: use zeroinitializer for (trailing zero portion of) large array initializers more reliably

rsmith updated this revision to Diff 148079. rsmith marked 4 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D47166 Files: lib/CodeGen/CGExprConstant.cpp lib/Sema/SemaInit.cpp test/CodeGen/init.c test/CodeGenCXX/cxx11-initializer-aggregate.cpp

[PATCH] D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type

zinovy.nis added inline comments. Comment at: clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:198 E = E->ignoreParenBaseCasts(); + if (const auto *EC = dyn_cast(E)) +E = EC->getSubExpr(); malcolm.parsons wrote: >

[PATCH] D47174: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL333014: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin. (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r333014 - [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

Author: ctopper Date: Tue May 22 11:54:19 2018 New Revision: 333014 URL: http://llvm.org/viewvc/llvm-project?rev=333014=rev Log: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h Intel documents the 128-bit

Re: r332885 - CodeGen, Driver: Start using direct split dwarf emission in clang.

Sorry about that, I was keeping an eye on the bots but I must have missed that one. I've relanded with a fix in r333013. Peter On Tue, May 22, 2018 at 4:25 AM, Amara Emerson wrote: > On 21 May 2018, at 21:31, Peter Collingbourne via cfe-commits < >

r333013 - Reland r332885, "CodeGen, Driver: Start using direct split dwarf emission in clang."

Author: pcc Date: Tue May 22 11:52:37 2018 New Revision: 333013 URL: http://llvm.org/viewvc/llvm-project?rev=333013=rev Log: Reland r332885, "CodeGen, Driver: Start using direct split dwarf emission in clang." As well as two follow-on commits r332906, r332911 with a fix for test

[libcxx] r333011 - [libcxx] [test] Mark the test as unsupported by apple-clang-8.1.

Author: vsapsai Date: Tue May 22 11:46:16 2018 New Revision: 333011 URL: http://llvm.org/viewvc/llvm-project?rev=333011=rev Log: [libcxx] [test] Mark the test as unsupported by apple-clang-8.1. Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

[PATCH] D47174: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

RKSimon added a comment. In https://reviews.llvm.org/D47174#1108329, @craig.topper wrote: > It is odd, but they really are split in the icc include files. So they got > split a while back in clang to match the Intel Intrinsic Guide documentation. OK - if that means we're matching latest

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

timshen updated this revision to Diff 148062. timshen added a comment. Herald added a subscriber: bixia. Chatted with Marshall a bit, we thought that it's bad for toolchain portability to support a C++17 library in C++11, especially with modifications w.r.t std::plus<>. Remove the backport of

[PATCH] D47174: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

craig.topper added a comment. It is odd, but they really are split in the icc include files. So they got split a while back in clang to match the Intel Intrinsic Guide documentation. Repository: rC Clang https://reviews.llvm.org/D47174 ___

[PATCH] D47174: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

RKSimon added a comment. Aren't all the instructions from the same CPUID bit? It seems odd to split them across multiple files. Repository: rC Clang https://reviews.llvm.org/D47174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47166: use zeroinitializer for (trailing zero portion of) large array initializers more reliably

rjmccall added a comment. I like this approach a lot. Comment at: lib/CodeGen/CGExprConstant.cpp:675 + // We have mixed types. Use a packed struct. + std::vector Types; + Types.reserve(Elements.size()); Why std::vector? Repository: rC Clang

[PATCH] D47174: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D47174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type

malcolm.parsons added inline comments. Comment at: clang-tools-extra/trunk/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:198 E = E->ignoreParenBaseCasts(); + if (const auto *EC = dyn_cast(E)) +E = EC->getSubExpr(); `E->IgnoreImplicit()` can be

[PATCH] D47202: [CodeGen] use nsw negation for abs

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. This seems right to me. GCC believes believes that __bultin_abs always returns a positive number. https://reviews.llvm.org/D47202

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

mgrang added inline comments. Comment at: include/clang/Frontend/Utils.h:369 + llvm::CreateInfoOutputFile(); + std::sort(FrontendTimes.begin(), FrontendTimes.end(), SortName); + using FTPIterator = typename std::vector::iterator; Please use

[PATCH] D46476: [HIP] Add action builder for HIP

yaxunl updated this revision to Diff 148051. yaxunl marked 4 inline comments as done. yaxunl added a comment. Revised by Artem's comments. https://reviews.llvm.org/D46476 Files: lib/Driver/Driver.cpp test/Driver/cuda-phases.cu Index: test/Driver/cuda-phases.cu

[PATCH] D47166: use zeroinitializer for (trailing zero portion of) large array initializers more reliably

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. Now I understand your idea about moving the logic to `tryEmitPrivateForMemory`. Indeed it is more general and consistent solution. Thank you. Comment at:

[PATCH] D46476: [HIP] Add action builder for HIP

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: lib/Driver/Driver.cpp:2221 +CudaDeviceActions.clear(); +for (unsigned I = 0, E = GpuArchList.size(); I != E; ++I) { + CudaDeviceActions.push_back(UA); tra

[PATCH] D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type

This revision was automatically updated to reflect the committed changes. Closed by commit rL333003: [clang-tidy] SimplifyBoolenExpr doesnt add parens if unary negotiation is of… (authored by zinovy.nis, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[clang-tools-extra] r333003 - [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type

Author: zinovy.nis Date: Tue May 22 10:24:28 2018 New Revision: 333003 URL: http://llvm.org/viewvc/llvm-project?rev=333003=rev Log: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type bool foo(A ) { if (S != (A)S) return false; return

[PATCH] D47154: Try to make builtin address space declarations not useless

Anastasia added inline comments. Comment at: include/clang/Basic/BuiltinsAMDGPU.def:49 + +// FIXME: Need to disallow constant address space. BUILTIN(__builtin_amdgcn_div_scale, "dddbb*", "n") Do you plan to provide the support for it later? Or if else perhaps

[PATCH] D47182: [X86] Move all Intel defined intrinsic includes into immintrin.h

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D47182#1107900, @craig.topper wrote: > Eventually this was determined to not be very scalable to remember which > header file contained what intrinsics and you have to

[PATCH] D47161: update

probinson added a comment. I take it this was accidental? If there are weaknesses in our documentation for how to use Phabricator, please let us know. I know it is not always straightforward (I had a number of issues when I tried to start using it). Repository: rC Clang

[PATCH] D47195: [clang-format] Fix putting ObjC message arguments in one line for multiline receiver

krasimir added inline comments. Comment at: unittests/Format/FormatTestObjC.cpp:815 + + // No line break before closing receiver's scope. + verifyFormat("[[obj a:42] a:42\n" jolesiak wrote: > krasimir wrote: > > jolesiak wrote: > > > krasimir wrote: > > > >

[PATCH] D46664: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

adr26 updated this revision to Diff 148044. adr26 added a comment. Update to change MSInheritanceAttr to always be attached to the latest non-injected class name decl, as suggested by Reid. https://reviews.llvm.org/D46664 Files: include/clang/AST/DeclCXX.h lib/AST/MicrosoftMangle.cpp

[PATCH] D47195: [clang-format] Fix ObjC message arguments handling

benhamilton added a comment. Can you update the diff description to reflect that it includes the original change? Repository: rC Clang https://reviews.llvm.org/D47195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47195: [clang-format] Fix ObjC message arguments handling

jolesiak updated this revision to Diff 148038. jolesiak added a comment. Rebase. Repository: rC Clang https://reviews.llvm.org/D47195 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

vsk added inline comments. Comment at: test/CodeGen/debug-info-preserve-scope.c:10 + +// CHECK: alloca i32 {{.*}} !dbg ![[dbgLocForStore:[0-9]+]] +// CHECK: store i32 {{.*}} !dbg ![[dbgLocForStore:[0-9]+]] In these two check lines, you're capturing the variable

[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

gramanas updated this revision to Diff 148034. gramanas added a comment. Move ApplyDebugLocation before CreateMemTemp Repository: rC Clang https://reviews.llvm.org/D47097 Files: lib/CodeGen/CGDecl.cpp test/CodeGen/debug-info-preserve-scope.c Index:

[PATCH] D47205: Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver"

This revision was automatically updated to reflect the committed changes. Closed by commit rC332998: Revert [clang-format] Fix putting ObjC message arguments in one line for… (authored by jolesiak, committed by ). Changed prior to commit: https://reviews.llvm.org/D47205?vs=148030=148032#toc

r332998 - Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver"

Author: jolesiak Date: Tue May 22 09:44:42 2018 New Revision: 332998 URL: http://llvm.org/viewvc/llvm-project?rev=332998=rev Log: Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver" Summary: Reverts D46879 Reviewers: benhamilton Reviewed By:

[PATCH] D47195: [clang-format] Fix ObjC message arguments handling

jolesiak added inline comments. Comment at: unittests/Format/FormatTestObjC.cpp:815 + + // No line break before closing receiver's scope. + verifyFormat("[[obj a:42] a:42\n" krasimir wrote: > jolesiak wrote: > > krasimir wrote: > > > What's the receiver's

[PATCH] D47205: Revert "[clang-format] Fix putting ObjC message arguments in one line for multiline receiver"

jolesiak created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rC Clang https://reviews.llvm.org/D47205 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

[PATCH] D47058: [ASTImporter] Fix ClassTemplateSpecialization in wrong DC

a.sidorin added a comment. Hi Gabor, Could you add a test for TSK_Undeclared as well? Repository: rC Clang https://reviews.llvm.org/D47058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47202: [CodeGen] use nsw negation for abs

spatel added a comment. In https://reviews.llvm.org/D47202#1108016, @lebedev.ri wrote: > That is what happens for "hand-rolled" `abs`, https://godbolt.org/g/6dbgXD > I *think* this makes sense, since **IIRC** LLVM only supports > twos-complement platforms. > But all these attributes are

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan marked 2 inline comments as done. leonardchan added inline comments. Comment at: lib/Index/USRGeneration.cpp:731 + + if (c == '~') { +switch (BT->getKind()) { jakehehrlich wrote: > You can make the 'c' a Twine instead. That will let you

[PATCH] D47057: [ASTImporter] Fix missing implict CXXRecordDecl in ClassTemplateSpecializationDecl

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: lib/AST/ASTImporter.cpp:1962 TagDecl *Definition = D->getDefinition(); - if (Definition && Definition != D) { + if (!D->isImplicit()

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 148025. Repository: rC Clang https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/Specifiers.h

[PATCH] D47202: [CodeGen] use nsw negation for abs

lebedev.ri added a comment. That is what happens for "hand-rolled" `abs`, https://godbolt.org/g/6dbgXD I *think* this makes sense, since **IIRC** LLVM only supports twos-complement platforms. But all these attributes are currently beyond me, so i won't click the accept button :)

[PATCH] D46950: [ASTImporter] Fix duplicate class template definitions problem

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang https://reviews.llvm.org/D46950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r332996 - Change the names of two private methods: allocate -> __vallocate and deallocate -> __vdeallocate. NFC. This change triggered by https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61806, w

Author: marshall Date: Tue May 22 09:20:28 2018 New Revision: 332996 URL: http://llvm.org/viewvc/llvm-project?rev=332996=rev Log: Change the names of two private methods: allocate -> __vallocate and deallocate -> __vdeallocate. NFC. This change triggered by

[PATCH] D47099: Call CreateTempAllocaWithoutCast for ActiveFlag

yaxunl added a comment. I revert it since it caused regression on arm and some other arch's. Script: -- /home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/stage1/bin/clang -cc1 -internal-isystem

r332991 - Revert r332982 Call CreateTempMemWithoutCast for ActiveFlag

Author: yaxunl Date: Tue May 22 09:13:07 2018 New Revision: 332991 URL: http://llvm.org/viewvc/llvm-project?rev=332991=rev Log: Revert r332982 Call CreateTempMemWithoutCast for ActiveFlag Due to regression on arm. Modified: cfe/trunk/lib/CodeGen/CGCall.cpp

[PATCH] D47200: [Sema] Add tests for weak functions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D47200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47065: [clangd] Enable parsing of non-doxygen comments in global-symbol-builder

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47161: update

gramanas abandoned this revision. gramanas added a comment. Duplicate of https://reviews.llvm.org/D47097 Repository: rC Clang https://reviews.llvm.org/D47161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47195: [clang-format] Fix ObjC message arguments handling

krasimir added inline comments. Comment at: unittests/Format/FormatTestObjC.cpp:815 + + // No line break before closing receiver's scope. + verifyFormat("[[obj a:42] a:42\n" jolesiak wrote: > krasimir wrote: > > What's the receiver's scope in this comment

  1   2   >