[PATCH] D47358: : Implement {un, }synchronized_pool_resource.

Quuxplusone created this revision. Quuxplusone added a reviewer: EricWF. Herald added a subscriber: cfe-commits. Split out from https://reviews.llvm.org/D47090. This patch is based on top of (depends on) https://reviews.llvm.org/D47111, but I'm posting it now for review. Repository: rCXX

[PATCH] D47111: : Implement monotonic_buffer_resource.

Quuxplusone updated this revision to Diff 148542. Quuxplusone retitled this revision from "Implement monotonic_buffer_resource in " to ": Implement monotonic_buffer_resource.". Quuxplusone added 1 blocking reviewer(s): EricWF. Quuxplusone added a comment. Fix one visibility macro. Repository:

[PATCH] D47354: [CodeGen][Darwin] Set the calling-convention of a thread-local variable initialization function to fix calling-convention mismatch

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D47354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

Quuxplusone updated this revision to Diff 148540. Quuxplusone added a comment. Oops. If we do get an underaligned result, let's not leak it! Repository: rCXX libc++ https://reviews.llvm.org/D47344 Files: src/experimental/memory_resource.cpp Index: src/experimental/memory_resource.cpp

[libcxx] r333252 - Add one more test for optional

Author: marshall Date: Thu May 24 19:22:54 2018 New Revision: 333252 URL: http://llvm.org/viewvc/llvm-project?rev=333252=rev Log: Add one more test for optional Modified: libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/deduct.pass.cpp Modified:

[PATCH] D47357: [Driver] Rename DefaultTargetTriple to TargetTriple

phosek created this revision. phosek added reviewers: hans, rnk, echristo. Herald added a subscriber: cfe-commits. While this value is initialized with the DefaultTargetTriple, it can be later overriden using the -target flag so TargetTriple is a more accurate name. This change also provides an

[libcxx] r333251 - Add deduction guides for optional

Author: marshall Date: Thu May 24 19:08:49 2018 New Revision: 333251 URL: http://llvm.org/viewvc/llvm-project?rev=333251=rev Log: Add deduction guides for optional Added: libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/deduct.fail.cpp

[PATCH] D44888: [RISCV] Add -mrelax/-mno-relax flags to enable/disable RISCV linker relaxation

shiva0217 added a comment. In https://reviews.llvm.org/D44888#1109361, @asb wrote: > This is looking good to me, just needs an update to address this > request for a test in > riscv-features.c that demonstrates the default +relax/-relax setting.

[PATCH] D47355: [CMake] Allow specifying extra dependencies of bootstrap stage

phosek added inline comments. Comment at: clang/CMakeLists.txt:586 + if(CLANG_BOOTSTRAP_EXTRA_COMPONENTS) +add_dependencies(clang-bootstrap-deps ${CLANG_BOOTSTRAP_EXTRA_COMPONENTS}) I don't know if `COMPONENTS` is the best term, this could also possibly

[PATCH] D47356: [CMake] Use libc++ and compiler-rt for bootstrap Fuchsia Clang

phosek created this revision. phosek added reviewers: beanz, jakehehrlich, mcgrathr. Herald added subscribers: cfe-commits, mgorny, dberris. Herald added a reviewer: EricWF. We want to build the second stage compiler with libc++ and compiler-rt, also include builtins and runtimes into extra

[PATCH] D47355: [CMake] Allow specifying extra dependencies of bootstrap stage

phosek created this revision. phosek added a reviewer: beanz. Herald added subscribers: cfe-commits, mgorny. This allows adding additional bootstrap dependencies to the bootstrap compiler that may be needed by later stages. Repository: rC Clang https://reviews.llvm.org/D47355 Files:

[PATCH] D47354: [CodeGen][Darwin] Set the calling-convention of a thread-local variable initialization function to fix calling-convention mismatch

ahatanak created this revision. ahatanak added reviewers: rjmccall, t.p.northover. There is a bug in IRGen where the calling convention of initialization functions for thread-local static members of c++ template classes isn't set. This caused InstCombine to remove a call to an initialization

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

xbolva00 updated this revision to Diff 148523. xbolva00 added a comment. Add correct NORETURN attribute https://reviews.llvm.org/D47340 Files: utils/TableGen/ClangDiagnosticsEmitter.cpp Index: utils/TableGen/ClangDiagnosticsEmitter.cpp

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

rtrieu added a comment. Instead of adding a break, you should add a noreturn attribute to the PrintFatalError function. LLVM has the macro LLVM_ATTRIBUTE_NORETURN to do this. You can confirm that PrintFatalError is a noreturn function by seeing that it unconditionally calls

[PATCH] D47225: Add nonnull; use it for atomics

jfb added a comment. Ping! clang side landed in https://reviews.llvm.org/rL333246 Repository: rCXX libc++ https://reviews.llvm.org/D47225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47229: Make atomic non-member functions as nonnull

This revision was automatically updated to reflect the committed changes. Closed by commit rL333246: Make atomic non-member functions as nonnull (authored by jfb, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47229 Files:

r333246 - Make atomic non-member functions as nonnull

Author: jfb Date: Thu May 24 17:07:09 2018 New Revision: 333246 URL: http://llvm.org/viewvc/llvm-project?rev=333246=rev Log: Make atomic non-member functions as nonnull Summary: As a companion to libc++ patch https://reviews.llvm.org/D47225, mark builtin atomic non-member functions which accept

Advice for a Newcoming Subscriber

Dear All LLVM list members, Hello to all of you. As I am a brand new subscriber, it is easy to get lost in the plethora of open source projects I may get started in! For now, I am mostly interested in optimizing Clang's performance. I just have three questions: 1. What have been the toughest,

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan added inline comments. Comment at: include/clang/Basic/TargetInfo.h:382 +// enough bits to fit the minumum. +if (getIntWidth() < MinSignedAccumDataBits) + return getLongWidth(); ebevhan wrote: > I'm not sure I agree with this

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 148506. leonardchan added a comment. Re-added individual getters/members for _Accum types Repository: rC Clang https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def

[PATCH] D47351: [analyzer] Re-enable C++17-specific variable and member variable construction contexts.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, baloghadamsoftware. The recent refactoring allows us to easily support C++17 "copy-elided" constructor syntax for variables and

[PATCH] D47229: Make atomic non-member functions as nonnull

jfb added inline comments. Comment at: lib/Sema/SemaChecking.cpp:3497 +else if (Form == Copy || Form == Xchg) { + if (!IsC11 && !IsN) +// The value pointer is always dereferenced, a nullptr is undefined. rsmith wrote: > arphaman

[PATCH] D47229: Make atomic non-member functions as nonnull

jfb updated this revision to Diff 148504. jfb marked an inline comment as done. jfb added a comment. - Address nit. - Change suggested by Richard Repository: rC Clang https://reviews.llvm.org/D47229 Files: lib/Sema/SemaChecking.cpp test/Sema/atomic-ops.c Index: test/Sema/atomic-ops.c

[PATCH] D47350: [analyzer] Track class member initializer constructors path-sensitively within their construction context.

NoQ updated this revision to Diff 148502. NoQ added a comment. Add a forgotten FIXME to the test. https://reviews.llvm.org/D47350 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngine.cpp lib/StaticAnalyzer/Core/ExprEngineCXX.cpp

[PATCH] D47350: [analyzer] Track class member initializer constructors path-sensitively within their construction context.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, baloghadamsoftware. Same as https://reviews.llvm.org/D47305 but for `CXXCtorInitializer`-based constructors, based on the discussion in

[PATCH] D47341: [Sema] Disable creating new delayed typos while correcting existing.

rsmith added a comment. Rather than disabling typo correction in `TransformTypos`, it would be preferable to attempt to immediately correct them. (That should allow the `variableX.getX()` case to still work.) https://reviews.llvm.org/D47341 ___

[PATCH] D47341: [Sema] Disable creating new delayed typos while correcting existing.

arphaman added inline comments. Comment at: clang/test/SemaCXX/typo-correction-delayed.cpp:146 + // expected-error@+1 {{use of undeclared identifier 'variableX'}} int x = variableX.getX(); } Loosing typo correction for 'getX' is fine, however, I think we

[PATCH] D44568: Fix emission of phony dependency targets when adding extra deps

vsapsai added inline comments. Comment at: lib/Frontend/DependencyFile.cpp:182-185 for (const auto : Opts.ExtraDeps) { AddFilename(ExtraDep); + ++InputFileIndex; } This is incorrect if there are duplicates in `Opts.ExtraDeps`. Also please

[PATCH] D47229: Make atomic non-member functions as nonnull

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Either the previous version of this patch or a version with a `bool` factored out seem OK to me. Comment at: lib/Sema/SemaChecking.cpp:3497 +else if (Form == Copy

r333234 - Improve diagonstic for braced-init-list as operand to ?: expression.

Author: rsmith Date: Thu May 24 15:02:52 2018 New Revision: 333234 URL: http://llvm.org/viewvc/llvm-project?rev=333234=rev Log: Improve diagonstic for braced-init-list as operand to ?: expression. Modified: cfe/trunk/lib/Parse/ParseExpr.cpp

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

ebevhan added inline comments. Comment at: include/clang/Basic/TargetInfo.h:382 +// enough bits to fit the minumum. +if (getIntWidth() < MinSignedAccumDataBits) + return getLongWidth(); I'm not sure I agree with this interpretation. It's simply not

r333233 - Switch a couple of users of LangOpts::GNUMode to the more appropriate LangOpts::GNUKeywords.

Author: rsmith Date: Thu May 24 14:51:52 2018 New Revision: 333233 URL: http://llvm.org/viewvc/llvm-project?rev=333233=rev Log: Switch a couple of users of LangOpts::GNUMode to the more appropriate LangOpts::GNUKeywords. Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan added a comment. In https://reviews.llvm.org/D46084#374, @jfb wrote: > Can you also add a test for `_Bool _Accum`. > > Also, `-enable-fixed-point -x c++` failing. . Done. Also the failing c++ case is under `test/Frontend/fixed_point_errors.cpp` Repository: rC Clang

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 148481. leonardchan marked 2 inline comments as done. leonardchan added a comment. - Added test case for `_Bool _Accum` - Getters for the `_Accum` bit widths return values for their corresponding integral types (ie. `sizeof(short _Accum) ==

[PATCH] D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()"

Quuxplusone created this revision. Quuxplusone added a reviewer: EricWF. Herald added subscribers: cfe-commits, JDevlieghere. https://github.com/cplusplus/draft/commit/6216651aada9bc2f9cefe90edbde4ea9e32251ab `new_delete_resource().allocate(n, a)` has basically three permissible results: -

[PATCH] D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin

jfb marked an inline comment as done. jfb added inline comments. Comment at: test/SemaObjC/format-size-spec-nsinteger.m:18 + NSUInteger j = 0; + NSLog(@"max NSInteger = %zi", i); // CHECK: values of type 'NSInteger' should not be used as format arguments; add an explicit

[PATCH] D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin

jfb updated this revision to Diff 148467. jfb marked an inline comment as done. jfb added a comment. - Merge format-size-spec-nsinteger Repository: rC Clang https://reviews.llvm.org/D47290 Files: include/clang/Analysis/Analyses/FormatString.h include/clang/Basic/DiagnosticSemaKinds.td

r333220 - Improve diagnostics for config mismatches with -fmodule-file.

Author: rsmith Date: Thu May 24 13:03:51 2018 New Revision: 333220 URL: http://llvm.org/viewvc/llvm-project?rev=333220=rev Log: Improve diagnostics for config mismatches with -fmodule-file. Unless the user uses -Wno-module-file-config-mismatch (or -Wno-error=...), allow the AST reader to produce

[PATCH] D47142: [x86] invpcid intrinsic

craig.topper added a comment. LGTM, if you fix the ordering in cpuid.h. https://reviews.llvm.org/D47142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47301: Warning for framework include violation from Headers to PrivateHeaders

vsapsai added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:34-35 def AutoImport : DiagGroup<"auto-import">; def FrameworkHdrQuotedInclude : DiagGroup<"quoted-include-in-framework-header">; +def FrameworkIncludePrivateFromPublic :

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling added a comment. @klimek In our IRC discussion yesterday, I know you expressed disapproval of WebKit's choice, but given its reality, am I correct in concluding that this can be landed? Repository: rC Clang https://reviews.llvm.org/D46024

[PATCH] D47067: Update NRVO logic to support early return

rsmith added a comment. Some minor nits. I would also like to see a test for the unoptimized (-O0) IR generated by Clang for the case where there are two NRVO variables in the same function. Otherwise, this looks good to go! Comment at: lib/Sema/Scope.cpp:122-123 +void

[PATCH] D47229: Make atomic non-member functions as nonnull

jfb added a comment. Addressed nit. Repository: rC Clang https://reviews.llvm.org/D47229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47229: Make atomic non-member functions as nonnull

jfb updated this revision to Diff 148458. jfb marked an inline comment as done. jfb added a comment. - Address nit. Repository: rC Clang https://reviews.llvm.org/D47229 Files: lib/Sema/SemaChecking.cpp test/Sema/atomic-ops.c Index: test/Sema/atomic-ops.c

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

Quuxplusone added a comment. > Sounds good to me. I don't have commit privs so could you land it for me? @EricWF ping! Repository: rCXX libc++ https://reviews.llvm.org/D47109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46052: GNUstep Objective-C ABI version 2

xbolva00 added inline comments. Comment at: lib/CodeGen/CGObjCGNU.cpp:512 /// used to return an untyped selector (with the types field set to NULL). - llvm::Value *GetSelector(CodeGenFunction , Selector Sel, + virtual llvm::Value *GetSelector(CodeGenFunction , Selector Sel,

[PATCH] D47341: [Sema] Disable creating new delayed typos while correcting existing.

vsapsai created this revision. vsapsai added reviewers: arphaman, majnemer. NumTypos guard value ~0U doesn't prevent from creating new delayed typos. When you create new delayed typos during typo correction, value ~0U wraps around to 0. This state is inconsistent and depending on total number of

[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

xbolva00 created this revision. Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov. ClangDiagnosticsEmitter.cpp:1047:57: warning: this statement may fall through [-Wimplicit-fallthrough=] Builder.PrintFatalError("Unknown modifier type: " + Modifier);

[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

vsk added a comment. In https://reviews.llvm.org/D47097#248, @aprantl wrote: > In https://reviews.llvm.org/D47097#223, @gramanas wrote: > > > In https://reviews.llvm.org/D47097#149, @probinson wrote: > > > > > Can we step back a second and better explain what the problem is? With >

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

jfb added a comment. Can you also add a test for `_Bool _Accum`. Also, `-enable-fixed-point -x c++` failing. Comment at: lib/AST/ExprConstant.cpp:7361 +case BuiltinType::ULongAccum: + // GCC does not cover FIXED_POINT_TYPE in it's switch stmt and defaults to +

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 148452. Repository: rC Clang https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/Basic/DiagnosticCommonKinds.td include/clang/Basic/LangOptions.def

[PATCH] D46950: [ASTImporter] Fix duplicate class template definitions problem

a.sidorin added a comment. Hm. Should we test `-fms-compatibility` in addition to `-fdelayed-template-parsing`? Repository: rC Clang https://reviews.llvm.org/D46950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan marked 6 inline comments as done. leonardchan added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2684 // Types added here must also be added to EmitFundamentalRTTIDescriptors. switch (Ty->getKind()) { rsmith wrote: > Note this

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 148445. leonardchan added a comment. - Reverted changes involving name mangling since we will only support c++ for now. Will concurrently raise an issue on https://github.com/itanium-cxx-abi/cxx-abi/ to get characters for name mangling. - Added a flag

[PATCH] D47260: Testcase for dwarf 5 crash/assert when calculating a checksum for an expansion

probinson added a comment. I see that the per-file info does track the presence of `# [line] N` but it's not immediately obvious how to query "has any file seen one" which is really what I'd want to know. The file information has various levels of indirection... Repository: rC Clang

[PATCH] D47058: [ASTImporter] Fix ClassTemplateSpecialization in wrong DC

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. Ok, I got it, thank you! Repository: rC Clang https://reviews.llvm.org/D47058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r333211 - [X86] Fix a bad cast in _mm512_mask_abs_epi32 and _mm512_maskz_abs_epi32.

Author: ctopper Date: Thu May 24 10:32:49 2018 New Revision: 333211 URL: http://llvm.org/viewvc/llvm-project?rev=333211=rev Log: [X86] Fix a bad cast in _mm512_mask_abs_epi32 and _mm512_maskz_abs_epi32. Modified: cfe/trunk/lib/Headers/avx512fintrin.h Modified:

[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

aprantl added a comment. In https://reviews.llvm.org/D47097#223, @gramanas wrote: > In https://reviews.llvm.org/D47097#149, @probinson wrote: > > > Can we step back a second and better explain what the problem is? With > > current Clang the debug info for this function looks okay to me.

[PATCH] D47267: [UnrollAndJam] Add unroll_and_jam pragma handling

Meinersbur added a comment. Yes, this is what I had in mind. Thank you. I am preparing an RFC on what I am trying to do. This should clarify our goals and to what extend `#pragma clang loop` conflicts with it. https://reviews.llvm.org/D47267 ___

[PATCH] D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin

ahatanak added inline comments. Comment at: test/SemaObjC/format-size-spec-nsinteger.m:18 + NSUInteger j = 0; + NSLog(@"max NSInteger = %zi", i); // CHECK: values of type 'NSInteger' should not be used as format arguments; add an explicit cast to 'long' instead +

[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

gramanas added a comment. In https://reviews.llvm.org/D47097#149, @probinson wrote: > Can we step back a second and better explain what the problem is? With > current Clang the debug info for this function looks okay to me. > The store that is "missing" a debug location is homing the

[PATCH] D47273: [bash-completion] Fix tab separation on macOS

benlangmuir closed this revision. benlangmuir added a comment. r333202 https://reviews.llvm.org/D47273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r333202 - [bash-completion] Fix tab separation on macOS

Author: benlangmuir Date: Thu May 24 09:25:40 2018 New Revision: 333202 URL: http://llvm.org/viewvc/llvm-project?rev=333202=rev Log: [bash-completion] Fix tab separation on macOS We have a regex that needs to match a tab character in the command output, but on macOS sed doesn't support '\t',

[PATCH] D47331: [clangd] Remove accessors for top-level decls from preamble

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, sammccall. Herald added subscribers: jkorous, MaskRay, mehdi_amini, klimek. They cause lots of deserialization and are not actually used. The ParsedAST accessor that previously returned those was renamed from

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, simple and will admit refinements later. Just test nits and a trivial organizational thing. Comment at: clangd/Quality.cpp:22 +namespace { +bool

[clang-tools-extra] r333197 - [clangd] Add clangDriver dependency after r333188

Author: ioeric Date: Thu May 24 08:54:32 2018 New Revision: 333197 URL: http://llvm.org/viewvc/llvm-project?rev=333197=rev Log: [clangd] Add clangDriver dependency after r333188 Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

[PATCH] D47187: [clangd] Skip .inc headers when canonicalizing header #include.

malaperle added subscribers: ioeric, sammccall, malaperle. malaperle added a comment. I think this might have broken the "shared lib" build? Could you double check that you don't need to add "clangDriver" ? ../tools/clang/tools/extra/clangd/index/CanonicalIncludes.cpp:61: error: undefined

[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE333196: [clangd] Build index on preamble changes instead of the AST changes (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D47272?vs=148421=148424#toc

[clang-tools-extra] r333196 - [clangd] Build index on preamble changes instead of the AST changes

Author: ibiryukov Date: Thu May 24 08:50:15 2018 New Revision: 333196 URL: http://llvm.org/viewvc/llvm-project?rev=333196=rev Log: [clangd] Build index on preamble changes instead of the AST changes Summary: This is more efficient and avoids data races when reading files that come from the

[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg. Thanks for adding the test! Comment at: clangd/index/FileIndex.cpp:37 + std::vector TopLevelDecls( + AST.getTranslationUnitDecl()->decls().begin(), +

[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

probinson added a comment. Can we step back a second and better explain what the problem is? With current Clang the debug info for this function looks okay to me. The store that is "missing" a debug location is homing the formal parameter to its local stack location; this is part of prolog

[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes

ilya-biryukov updated this revision to Diff 148421. ilya-biryukov added a comment. - Added a test for preamble rebuilds. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47272 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/TUScheduler.cpp

[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes

ilya-biryukov added a comment. Added the test. Comment at: clangd/index/FileIndex.cpp:37 + std::vector TopLevelDecls( + AST.getTranslationUnitDecl()->decls().begin(), + AST.getTranslationUnitDecl()->decls().end()); ioeric wrote: > ilya-biryukov

[PATCH] D47067: Update NRVO logic to support early return

tzik added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12760 // to deduce an implicit return type. - if (FD->getReturnType()->isRecordType() && - (!getLangOpts().CPlusPlus || !FD->isDependentContext())) + if (!FD->getReturnType()->isScalarType())

[PATCH] D47067: Update NRVO logic to support early return

tzik updated this revision to Diff 148417. tzik added a comment. Add AST test. computeNRVO unconditionally. Repository: rC Clang https://reviews.llvm.org/D47067 Files: include/clang/AST/Decl.h include/clang/Sema/Scope.h lib/Sema/Scope.cpp lib/Sema/SemaDecl.cpp

r333179 - [analyzer] Move RangeSet related declarations into the RangedConstraintManager header.

Author: mramalho Date: Thu May 24 05:16:35 2018 New Revision: 333179 URL: http://llvm.org/viewvc/llvm-project?rev=333179=rev Log: [analyzer] Move RangeSet related declarations into the RangedConstraintManager header. Summary: I could also move `RangedConstraintManager.h` under `include/` if you

[PATCH] D47063: [clangd] Keep only a limited number of idle ASTs in memory

sammccall added a comment. Thanks, this looks a lot better! There do seem to be a lot of little classes that exist exactly one-per-TU (ASTWorker, ASTBuilder, CachedAST, to a lesser extent ParsedAST) and I'm not sure the balance of responsibilities is quite right. Some comments below.

[PATCH] D47274: [clangd] Serve comments for headers decls from dynamic index only

This revision was automatically updated to reflect the committed changes. Closed by commit rL333189: [clangd] Serve comments for headers decls from dynamic index only (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r333189 - [clangd] Serve comments for headers decls from dynamic index only

Author: ibiryukov Date: Thu May 24 07:49:23 2018 New Revision: 333189 URL: http://llvm.org/viewvc/llvm-project?rev=333189=rev Log: [clangd] Serve comments for headers decls from dynamic index only Summary: To fix a crash in code completion that occurrs when reading doc comments from files that

[PATCH] D47097: [DebugInfo] Preserve scope in auto generated StoreInst

gramanas updated this revision to Diff 148414. gramanas added a comment. Adress review comments. Limit changes to the storeInst Repository: rC Clang https://reviews.llvm.org/D47097 Files: lib/CodeGen/CGDecl.cpp test/CodeGen/debug-info-preserve-scope.c Index:

[PATCH] D47274: [clangd] Serve comments for headers decls from dynamic index only

ilya-biryukov added inline comments. Comment at: clangd/CodeCompletionStrings.h:46 const CodeCompleteConsumer::OverloadCandidate , - unsigned ArgIndex); + unsigned ArgIndex, bool NoCommentsFromHeaders = true);

[PATCH] D47274: [clangd] Serve comments for headers decls from dynamic index only

ilya-biryukov updated this revision to Diff 148413. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Invert flag, remove the default. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47274 Files: clangd/CodeComplete.cpp

[clang-tools-extra] r333188 - [clangd] Skip .inc headers when canonicalizing header #include.

Author: ioeric Date: Thu May 24 07:40:24 2018 New Revision: 333188 URL: http://llvm.org/viewvc/llvm-project?rev=333188=rev Log: [clangd] Skip .inc headers when canonicalizing header #include. Summary: This assumes that .inc files are supposed to be included via headers that include them.

[PATCH] D47187: [clangd] Skip .inc headers when canonicalizing header #include.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333188: [clangd] Skip .inc headers when canonicalizing header #include. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes

ioeric added inline comments. Comment at: clangd/index/FileIndex.cpp:37 + std::vector TopLevelDecls( + AST.getTranslationUnitDecl()->decls().begin(), + AST.getTranslationUnitDecl()->decls().end()); ilya-biryukov wrote: > ioeric wrote: > > Would this

Re: [PATCH] D46964: Implement class deduction guides for `std::array`

Hi Marshall, ARM and AArch64 libcxx buildbots are broken since that commits, logs are available at: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv7-linux/builds/107/steps/test.libcxx/logs/FAIL%3A%20libc%2B%2B%3A%3Adeduct.pass.cpp Thanks Yvan On 18 May 2018 at 23:05,

[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes

ilya-biryukov added a comment. In https://reviews.llvm.org/D47272#1110958, @ioeric wrote: > Would it be possible to add some integration tests for file index plus > preamble? Sure, will do Comment at: clangd/index/FileIndex.cpp:37 + std::vector TopLevelDecls( +

r333186 - Disable an in-memory vfs file path test on windows.

Author: ioeric Date: Thu May 24 06:52:48 2018 New Revision: 333186 URL: http://llvm.org/viewvc/llvm-project?rev=333186=rev Log: Disable an in-memory vfs file path test on windows. The test uses unix paths and doesn't make sense to run on windows. Fix bot failure caused by r333172:

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

ilya-biryukov added a comment. I have only a few nits left, otherwise looks good. Thanks for making this change! Really excited for it to get in finally! Comment at: include/clang/Driver/CC1Options.td:449 +def code_completion_with_fixits : Flag<["-"],

[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes

ioeric added a comment. Would it be possible to add some integration tests for file index plus preamble? Comment at: clangd/index/FileIndex.cpp:37 + std::vector TopLevelDecls( + AST.getTranslationUnitDecl()->decls().begin(), +

[PATCH] D47274: [clangd] Serve comments for headers decls from dynamic index only

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/CodeCompletionStrings.h:46 const CodeCompleteConsumer::OverloadCandidate , - unsigned ArgIndex); +

[PATCH] D47267: [UnrollAndJam] Add unroll_and_jam pragma handling

dmgreen updated this revision to Diff 148393. dmgreen added a comment. This splits out the pragma clang loop unroll_and_jam handling into https://reviews.llvm.org/D47320, for if/when we need it. Which I believe is what you wanted, correct me if I'm wrong. https://reviews.llvm.org/D47267

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

avt77 updated this revision to Diff 148395. avt77 added a comment. The sources were re-based to fit in LLVM_DEBUG rename. One more counter was added. Debug logging was improved again. https://reviews.llvm.org/D47196 Files: include/clang/Frontend/Utils.h lib/CodeGen/BackendUtil.cpp

[PATCH] D47320: [UnrollAndJam] Add pragma clang loop unroll_and_jam handling.

dmgreen created this revision. Herald added a subscriber: zzheng. Split out from https://reviews.llvm.org/D47267 when we need it. https://reviews.llvm.org/D47320 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParsePragma.cpp lib/Sema/SemaStmtAttr.cpp

[PATCH] D47223: [clangd] Handle enumerators in named, unscoped enums similarly to scoped enums

ilya-biryukov added a comment. > But I feel it's a bit odd that completion and workspace symbols would be > inconsistent. It does not seem that odd to me. Completion is something that should follow the language rules more closely, i.e. we don't want to deviate from sema completions too much.

[PATCH] D45920: [analyzer] Move RangeSet related declarations into the RangedConstraintManager header.

This revision was automatically updated to reflect the committed changes. Closed by commit rC333179: [analyzer] Move RangeSet related declarations into the RangedConstraintManager… (authored by mramalho, committed by ). Repository: rC Clang https://reviews.llvm.org/D45920 Files:

r333157 - [Sparc] Use the leon arch for Leon3's when using an external assembler

Author: dcederman Date: Wed May 23 23:16:02 2018 New Revision: 333157 URL: http://llvm.org/viewvc/llvm-project?rev=333157=rev Log: [Sparc] Use the leon arch for Leon3's when using an external assembler Summary: This allows the use of the casa instruction available in most Leon3's. Reviewers:

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

ilya-biryukov updated this revision to Diff 148381. ilya-biryukov added a comment. - Simplify the change by boosting any Decls that have a redecl in the current file Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46943 Files: clangd/Quality.cpp clangd/Quality.h

Re: r333082 - Fix duplicate class template definitions problem

Thanks a lot! Gabor On Thu, May 24, 2018 at 12:54 PM Hans Wennborg wrote: > On Wed, May 23, 2018 at 3:53 PM, Gabor Marton via cfe-commits > wrote: > > Author: martong > > Date: Wed May 23 06:53:36 2018 > > New Revision: 333082 > > > > URL:

[clang-tools-extra] r333174 - [clangd] Fix code completion in MACROs with stringification.

Author: ioeric Date: Thu May 24 04:20:19 2018 New Revision: 333174 URL: http://llvm.org/viewvc/llvm-project?rev=333174=rev Log: [clangd] Fix code completion in MACROs with stringification. Summary: Currently, we only handle the first callback from sema code completion and ignore results from

  1   2   >