craig.topper added inline comments.
Comment at: cfe/trunk/lib/Headers/avx512fintrin.h:9855
+ __v8di __t6 = (__v8di)_mm512_##op(__t4, __t5); \
+ return __t6[0];
RKSimon wrote:
> Would it be dumb to allow VLX capable CPUs to use 128/256 variants of the
>
tejohnson updated this revision to Diff 148740.
tejohnson added a comment.
Update tests so they won't get bot failures (don't try to match path, module
hash).
Ping - this can go in now that https://reviews.llvm.org/D46699 is in.
Repository:
rC Clang
https://reviews.llvm.org/D46700
Files:
xbolva00 added inline comments.
Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:1261
+
+ for (ConstraintRangeTy::iterator I = CR.begin(), E = CR.end(); I != E; ++I) {
+SymbolRef Sym = I.getKey();
for (auto I : CR)?
ddcc added a comment.
FYI the fix for the 1-bit APSInt issue is in
https://reviews.llvm.org/D35450#change-ifYnQ3IlVso
https://reviews.llvm.org/D45517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
RKSimon added inline comments.
Comment at: cfe/trunk/lib/Headers/avx512fintrin.h:9855
+ __v8di __t6 = (__v8di)_mm512_##op(__t4, __t5); \
+ return __t6[0];
Would it be dumb to allow VLX capable CPUs to use 128/256 variants of the
VPMAXUQ etc ? Or is it
xbolva00 added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:33
+public:
+ DanglingInternalBufferChecker() : CStrFn("c_str") {}
+
string.data() support?
https://reviews.llvm.org/D47135
Ka-Ka added a comment.
In https://reviews.llvm.org/D45686#1113426, @lebedev.ri wrote:
> In https://reviews.llvm.org/D45686#1113425, @Ka-Ka wrote:
>
> > In https://reviews.llvm.org/D45686#1113414, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D45686#1109295, @dstenb wrote:
> > >
> >
lebedev.ri added a comment.
In https://reviews.llvm.org/D45686#1113425, @Ka-Ka wrote:
> In https://reviews.llvm.org/D45686#1113414, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D45686#1109295, @dstenb wrote:
> >
> > > Ping.
> > >
> > > We have added a lit reproducer for this now in
Ka-Ka added a comment.
In https://reviews.llvm.org/D45686#1113414, @aaron.ballman wrote:
> In https://reviews.llvm.org/D45686#1109295, @dstenb wrote:
>
> > Ping.
> >
> > We have added a lit reproducer for this now in clang-tools-extra:
> > https://reviews.llvm.org/D47251.
>
>
> The above should
> On May 26, 2018, at 12:36 PM, Marshall Clow wrote:
>
>
>
> On Fri, May 25, 2018 at 4:43 PM, JF Bastien via cfe-commits
> > wrote:
> Author: jfb
> Date: Fri May 25 16:43:53 2018
> New Revision: 25
>
Author: jfb
Date: Sat May 26 12:44:45 2018
New Revision: 51
URL: http://llvm.org/viewvc/llvm-project?rev=51=rev
Log:
Revert "Add nonnull; use it for atomics"
That's r25, as well as follow-up "Fix GCC handling of ATOMIC_VAR_INIT"
r27.
Marshall asked to revert:
Let's have a
Author: xbolva00
Date: Sat May 26 02:24:00 2018
New Revision: 40
URL: http://llvm.org/viewvc/llvm-project?rev=40=rev
Log:
[ClangDiagnostics] Silence warning about fallthrough after PrintFatalError
Summary:
ClangDiagnosticsEmitter.cpp:1047:57: warning: this statement may fall through
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1113412, @jfb wrote:
> In https://reviews.llvm.org/D47290#1113365, @aaron.ballman wrote:
>
> > This is relaxing `-Wformat` and making users instead write
> > `-Wformat-pedantic` to get the strong guarantees, which is the opposite
On Fri, May 25, 2018 at 4:43 PM, JF Bastien via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jfb
> Date: Fri May 25 16:43:53 2018
> New Revision: 25
>
> URL: http://llvm.org/viewvc/llvm-project?rev=25=rev
> Log:
> Add nonnull; use it for atomics
>
>
JF - please revert this
jfb added a comment.
Addressed comments.
Repository:
rC Clang
https://reviews.llvm.org/D47290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jfb updated this revision to Diff 148737.
jfb marked 2 inline comments as done.
jfb added a comment.
- Fix variable capitalization.
Repository:
rC Clang
https://reviews.llvm.org/D47290
Files:
include/clang/Analysis/Analyses/FormatString.h
include/clang/Basic/DiagnosticSemaKinds.td
aaron.ballman added a comment.
In https://reviews.llvm.org/D45686#1109295, @dstenb wrote:
> Ping.
>
> We have added a lit reproducer for this now in clang-tools-extra:
> https://reviews.llvm.org/D47251.
The above should be rolled into this patch as the test case verifying the
behavioral
jfb marked an inline comment as done.
jfb added a comment.
In https://reviews.llvm.org/D47290#1113365, @aaron.ballman wrote:
> This is relaxing `-Wformat` and making users instead write
> `-Wformat-pedantic` to get the strong guarantees, which is the opposite of
> what I thought the consensus
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov, baloghadamsoftware.
Herald added subscribers: a.sidorin, dkrupp, szepet, whisperity.
After cleaning up program state maps in `checkDeadSymbols()`, a transition
should be added to generate the new state.
rnkovacs added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1661
+ case AF_CXXNewArray:
+ case AF_InternalBuffer: {
if (IsALeakCheck) {
Is tying this new family to NewDeleteChecker reasonable? I did it because it
was
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LG!
Repository:
rC Clang
https://reviews.llvm.org/D47416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ctopper
Date: Sat May 26 11:55:26 2018
New Revision: 48
URL: http://llvm.org/viewvc/llvm-project?rev=48=rev
Log:
[X86] Remove mask from avx512ifma builtins. Use a select instruction instead.
This reduces from 12 builtins to 6 since we no longer need a mask and maskz
version.
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D47135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added a comment.
In https://reviews.llvm.org/D47157#1107210, @bruno wrote:
> > See also PR22165.
>
> Nice, seems related to this indeed. Are you aware of any development along
> those lines in clang-tidy? We would like this to be part of clang and be used
> as part of the normal
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov.
Herald added subscribers: a.sidorin, dkrupp, szepet, baloghadamsoftware,
whisperity.
Symbols are cleaned up from the program state map when they go out of scope.
(This will need to be done individually
rnkovacs updated this revision to Diff 148732.
rnkovacs added a comment.
Address (most) comments.
https://reviews.llvm.org/D47135
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/AllocationState.h
lib/StaticAnalyzer/Checkers/CMakeLists.txt
aaron.ballman added a comment.
This is relaxing `-Wformat` and making users instead write `-Wformat-pedantic`
to get the strong guarantees, which is the opposite of what I thought the
consensus was. Have I misunderstood something?
Comment at:
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:65
+ if (Call.isCalled(CStrFn)) {
+SymbolRef RawPtr = Call.getReturnValue().getAsSymbol();
+State = State->set(TypedR, RawPtr);
xazax.hun wrote:
>
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:73
+if (State->contains(TypedR)) {
+ const SymbolRef *StrBufferPtr = State->get(TypedR);
+ const Expr *Origin = Call.getOriginExpr();
aaron.ballman added a comment.
@rsmith -- do the object file formats listed look correct to you?
Comment at: include/clang/Basic/Attr.td:322
+def TargetSupportsAlias : TargetSpec {
+ let ObjectFormats = ["COFF", "ELF", "Wasm"];
+}
Did you verify that Wasm
xazax.hun added a comment.
Looks good so far, some comments inline.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:58
+
+ auto *TypeDecl = TypedR->getValueType().getTypePtr()->getAsCXXRecordDecl();
+ if (TypeDecl->getName() != "basic_string")
rnkovacs updated this revision to Diff 148727.
rnkovacs retitled this revision from "[analyzer][WIP] A checker for dangling
string pointers in C++" to "[analyzer] A checker for dangling internal buffer
pointers in C++".
rnkovacs edited the summary of this revision.
rnkovacs added a comment.
-
CarlosAlbertoEnciso marked 2 inline comments as done.
CarlosAlbertoEnciso added a comment.
@lebedev.ri,
Thanks very much for your review. I will address those issues and update the
patch.
https://reviews.llvm.org/D44826
___
cfe-commits mailing
xbolva00 added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction , Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction , Selector Sel,
theraven added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction , Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction , Selector Sel,
xbolva00 added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction , Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction , Selector Sel,
theraven added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:512
/// used to return an untyped selector (with the types field set to NULL).
- llvm::Value *GetSelector(CodeGenFunction , Selector Sel,
+ virtual llvm::Value *GetSelector(CodeGenFunction , Selector Sel,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL40: [ClangDiagnostics] Silence warning about fallthrough
after PrintFatalError (authored by xbolva00, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC40: [ClangDiagnostics] Silence warning about fallthrough
after PrintFatalError (authored by xbolva00, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D47340
Files:
stephanemoore updated this revision to Diff 148705.
Repository:
rC Clang
https://reviews.llvm.org/D47393
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
===
---
Ka-Ka added a reviewer: JDevlieghere.
Ka-Ka added a comment.
Added Jonas Devlieghere as reviewer as he was involved in the review of
https://reviews.llvm.org/rL327851 (which seems to be the reason for this patch).
https://reviews.llvm.org/D45686
41 matches
Mail list logo