[PATCH] D47070: [CUDA] Upgrade linked bitcode to enable inlining

Hahnfeld added a comment. In https://reviews.llvm.org/D47070#1108803, @tra wrote: > Here's my understanding of what happens: > We've started adding target-features and target-cpu to everything clang > generates. > We also need to link with libdevice (or IR generated by clang which which > h

[PATCH] D46845: [libcxx][c++17] P0083R5: Splicing Maps and Sets

EricWF added inline comments. Comment at: libcxx/include/__hash_table:2261 +_NodeHandle +__hash_table<_Tp, _Hash, _Equal, _Alloc>::__node_handle_extract_unique( +key_type const& __key) If I'm not mistaken, `__node_handle_extract_unique` and `__node_handle_ex

[PATCH] D47201: [CUDA] Implement nv_weak attribute for functions

Hahnfeld added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D47201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

Hahnfeld added a comment. In https://reviews.llvm.org/D47394#1118393, @gtbercea wrote: > The error is related to lack of device linking, just like you explained two > paragraphs down. This is the error I get: > > main.o: In function `__cuda_module_ctor': > main.cu:(.text+0x674): undefined re

[PATCH] D47557: Filesystem tests: un-confuse write time

This revision was automatically updated to reflect the committed changes. Closed by commit rL333723: Filesystem tests: un-confuse write time (authored by jfb, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47557 Files: libcxx/trunk/te

[libcxx] r333723 - Filesystem tests: un-confuse write time

Author: jfb Date: Thu May 31 21:59:48 2018 New Revision: 333723 URL: http://llvm.org/viewvc/llvm-project?rev=333723&view=rev Log: Filesystem tests: un-confuse write time Summary: The filesystem test was confused about access versus write / modification time. The spec says: file_time_type last

[PATCH] D47557: Filesystem tests: un-confuse write time

jfb updated this revision to Diff 149398. jfb added a comment. - Add back directory test Repository: rCXX libc++ https://reviews.llvm.org/D47557 Files: test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp Index: test/std/experimental/filesystem/fs

[PATCH] D47618: __c11_atomic_load's _Atomic can be const

jfb added a comment. Note that I don't touch the OpenCL __constant stuff, because the separate address space means this can be actually read-only, which means you can't cmpxchg for very wide reads. Repository: rC Clang https://reviews.llvm.org/D47618 _

[PATCH] D47618: __c11_atomic_load's _Atomic can be const

jfb created this revision. jfb added a reviewer: rsmith. Herald added a subscriber: cfe-commits. C++11 onwards specs the non-member functions atomic_load and atomic_load_explicit as taking the atomic by const (potentially volatile) pointer. C11, in its infinite wisdom, decided to drop the const,

[PATCH] D47617: [Analyzer] Fix Z3 crash (PR37646)

vlad.tsyrklevich created this revision. vlad.tsyrklevich added reviewers: george.karpenkov, NoQ, ddcc. Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun. Fix another Z3ConstraintManager crash, use fixAPSInt() to extend a boolean APSInt. Repository: rC Clang https://reviews.l

[PATCH] D47586: Update NRVO logic to support early return (Attempt 2)

tzik added a reviewer: rsmith. tzik added a comment. rsmith: PTAL. This is the previous attempt plus a fix and a test. The diff is SemaTemplateInstantiateDecl.cpp part that propagate disabled NRVO state to the instantiated local variable. On the previous attempt

[PATCH] D46024: [clang-format] Add SpaceBeforeCpp11BracedList option.

rkirsling updated this revision to Diff 149395. rkirsling added a comment. Resolved another rebase conflict to keep this patch mergeable. Repository: rC Clang https://reviews.llvm.org/D46024 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Format.cpp l

[PATCH] D47578: Do not enforce absolute path argv0 in windows

takuto.ikuta marked an inline comment as done. takuto.ikuta added a comment. In https://reviews.llvm.org/D47578#1117874, @rnk wrote: > I think this would be easy to unit test in > llvm/unittests/Support/CommandLine.cpp. We'd just check that the filename is > "SupportTests.exe" on Windows and th

[PATCH] D47578: Do not enforce absolute path argv0 in windows

takuto.ikuta updated this revision to Diff 149394. takuto.ikuta added a comment. Add test and split function https://reviews.llvm.org/D47578 Files: llvm/lib/Support/Windows/Process.inc llvm/unittests/Support/CommandLineTest.cpp Index: llvm/unittests/Support/CommandLineTest.cpp

[PATCH] D47614: [WebAssembly] Hide new Wasm EH behind its feature flag

sbc100 added inline comments. Comment at: lib/CodeGen/CGException.cpp:322 const EHPersonality &CXX = - getCXXPersonality(getTarget().getTriple(), LangOpts); + getCXXPersonality(getTarget().getTriple(), LangOpts, getTarget()); if (&ObjCXX == &CXX)

[PATCH] D47607: [libcxx] Almost fix some UB in and

EricWF added inline comments. Comment at: libcxx/include/unordered_map:586 union __hash_value_type { typedef _Key key_type; `union` -> `class` Repository: rCXX libc++ https://reviews.llvm.org/D47607 _

[PATCH] D47607: [libcxx] Almost fix some UB in and

EricWF added a comment. Overall this change seems reasonable to me. Thanks for working on this. Initially I was concerned we would hit issues optimizing const objects, but I should have read your description first! Thanks for ensuring Clang doesn't optimize on this. One other concern I have is

r333719 - [analyzer] NFC: Track all constructed objects in a single state trait.

Author: dergachev Date: Thu May 31 18:59:48 2018 New Revision: 333719 URL: http://llvm.org/viewvc/llvm-project?rev=333719&view=rev Log: [analyzer] NFC: Track all constructed objects in a single state trait. ExprEngine already maintains three internal program state traits to track path-sensitive i

[PATCH] D47303: [analyzer] NFC: Merge object construction related state traits into one.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333719: [analyzer] NFC: Track all constructed objects in a single state trait. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D47616: [CFG] [analyzer] Explain copy elision through construction contexts.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, baloghadamsoftware. Copy elision occurs when 1. a temporary object (with its corresponding temporary object construction context) is constr

r333718 - [Modules] Warning for module declarations lacking 'framework' qualifier

Author: bruno Date: Thu May 31 18:26:18 2018 New Revision: 333718 URL: http://llvm.org/viewvc/llvm-project?rev=333718&view=rev Log: [Modules] Warning for module declarations lacking 'framework' qualifier When a module declaration for a framework lacks the 'framework' qualifier, the listed headers

[PATCH] D47607: [libcxx] Almost fix some UB in and

rsmith added inline comments. Comment at: libcxx/include/map:617 template union __value_type { This doesn't need to be a union any more; change to class? Comment at: libcxx/include/map:633 +#if _LIBCPP_STD_VER > 14 +return _VSTD::la

[PATCH] D47613: Mark __c11_atomic_load as const

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCXX libc++ https://reviews.llvm.org/D47613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D45517: [analyzer] False positive refutation with Z3

mikhail.ramalho added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:183 + virtual void reset() {} + virtual bool isModelFeasible() { return true; } + virtual void addRangeConstraints(ConstraintRangeTy) {} geo

[PATCH] D47557: Filesystem tests: un-confuse write time

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after addressing inline comments. Comment at: test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:257 +TEST_CHECK(LastWriteT

[PATCH] D47564: [Parse] Use CapturedStmt for @finally on MSVC

rjmccall added a comment. In https://reviews.llvm.org/D47564#1118423, @smeenai wrote: > In https://reviews.llvm.org/D47564#1118381, @rjmccall wrote: > > > That's an interesting idea. I don't see any particular reason not to do it > > this way if you're willing to accept that it's never going to

[PATCH] D47564: [Parse] Use CapturedStmt for @finally on MSVC

smeenai added a comment. In https://reviews.llvm.org/D47564#1118381, @rjmccall wrote: > That's an interesting idea. I don't see any particular reason not to do it > this way if you're willing to accept that it's never going to support the > full control-flow possibilities of @finally. You wil

[PATCH] D47614: [WebAssembly] Hide new Wasm EH behind its feature flag

This revision was automatically updated to reflect the committed changes. Closed by commit rC333716: [WebAssembly] Hide new Wasm EH behind its feature flag (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D47614?vs=149386&id=149387#toc Repository: rC Cl

r333716 - [WebAssembly] Hide new Wasm EH behind its feature flag

Author: aheejin Date: Thu May 31 18:01:37 2018 New Revision: 333716 URL: http://llvm.org/viewvc/llvm-project?rev=333716&view=rev Log: [WebAssembly] Hide new Wasm EH behind its feature flag Summary: clang's current wasm EH implementation is a non-MVP feature in progress. We had a `-mexception-hand

[PATCH] D47614: [WebAssembly] Hide new Wasm EH behind its feature flag

aheejin updated this revision to Diff 149386. aheejin added a comment. - Add a missing conditional statement. I'll still assume this as accepted Repository: rC Clang https://reviews.llvm.org/D47614 Files: lib/CodeGen/CGException.cpp lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/wasm-eh

[PATCH] D45517: [analyzer] False positive refutation with Z3

george.karpenkov added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:183 + virtual void reset() {} + virtual bool isModelFeasible() { return true; } + virtual void addRangeConstraints(ConstraintRangeTy) {} mi

[PATCH] D47614: [WebAssembly] Hide new Wasm EH behind its feature flag

aheejin created this revision. aheejin added reviewers: dschuff, majnemer. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. clang's current wasm EH implementation is a non-MVP feature in progress. We had a `-mexception-handling` wasm feature but were not using it. This pat

r333715 - [Coverage] End deferred regions before labels, fixes PR35867

Author: vedantk Date: Thu May 31 17:37:13 2018 New Revision: 333715 URL: http://llvm.org/viewvc/llvm-project?rev=333715&view=rev Log: [Coverage] End deferred regions before labels, fixes PR35867 A deferred region should end before the start of a label, and should not extend to the start of the la

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added a comment. The error is related to lack of device linking, just like you explained two paragraphs down. This is the error I get: main.o: In function `__cuda_module_ctor': main.cu:(.text+0x674): undefined reference to `__cudaRegisterLinkedBinary__nv_c5b75865' You nailed the p

[PATCH] D46485: Add python tool to dump and construct header maps

bruno added a comment. Ping. Without this patch, we would have to add binary header maps for tests in https://reviews.llvm.org/D47157 and https://reviews.llvm.org/D47301, which I would like to avoid. https://reviews.llvm.org/D46485 ___ cfe-commit

r333712 - [WebAssembly] Update to the new names for the memory builtin functions.

Author: djg Date: Thu May 31 17:05:51 2018 New Revision: 333712 URL: http://llvm.org/viewvc/llvm-project?rev=333712&view=rev Log: [WebAssembly] Update to the new names for the memory builtin functions. The WebAssembly committee has decided on the names `memory.size` and `memory.grow` for the memo

[PATCH] D45517: [analyzer] False positive refutation with Z3

mikhail.ramalho added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:183 + virtual void reset() {} + virtual bool isModelFeasible() { return true; } + virtual void addRangeConstraints(ConstraintRangeTy) {} geo

[PATCH] D47564: [Parse] Use CapturedStmt for @finally on MSVC

rjmccall added a comment. That's an interesting idea. I don't see any particular reason not to do it this way if you're willing to accept that it's never going to support the full control-flow possibilities of @finally. You will need to add JumpDiagnostics logic to prevent branches out of the

[PATCH] D47613: Mark __c11_atomic_load as const

jfb created this revision. jfb added reviewers: EricWF, mclow.lists. Herald added subscribers: cfe-commits, christof. C++11 onwards specs the non-member functions atomic_load and atomic_load_explicit as taking the atomic by const (potentially volatile) pointer. C11, in its infinite wisdom, decid

[PATCH] D45517: [analyzer] False positive refutation with Z3

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:925 + void reset() override { Solver.reset(); } + mikhail.ramalho wrote: > george.karpenkov wrote: > > We don't need `reset` anymore. > We don't need it but the

[PATCH] D47557: Filesystem tests: un-confuse write time

jfb updated this revision to Diff 149377. jfb added a comment. - Remove access time checks, simplify existing check, after talking to EricWF on IRC. Repository: rCXX libc++ https://reviews.llvm.org/D47557 Files: test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_writ

[PATCH] D45517: [analyzer] False positive refutation with Z3

mikhail.ramalho added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2391 +if (!RefutationMgr->isModelFeasible()) + BR.markInvalid("Infeasible constraints", N->getLocationContext()); + } george.karpenkov wrote: > That would

[PATCH] D43667: [clang-doc] Implement a YAML generator

juliehockett updated this revision to Diff 149373. https://reviews.llvm.org/D43667 Files: clang-doc/CMakeLists.txt clang-doc/Generators.cpp clang-doc/Generators.h clang-doc/Representation.h clang-doc/YAMLGenerator.cpp clang-doc/tool/ClangDocMain.cpp test/clang-doc/yaml-comments.cpp

[PATCH] D45517: [analyzer] False positive refutation with Z3

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:928 + bool isModelFeasible() override { +return Solver.check() != Z3_L_FALSE; + } george.karpenkov wrote: > The semantics of this method is incorrect. It sho

[PATCH] D45517: [analyzer] False positive refutation with Z3

george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. Thanks, this is going in the right direction! Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:182 + virtual

[PATCH] D46112: Allow _Atomic to be specified on incomplete types

efriedma added a comment. If you don't want to spend too much time on C++, fine; could you add a short Objective-C test instead to make sure the trivially-copyable checks are working? What are the changes to Sema::RequireCompleteTypeImpl supposed to do? Comment at: test/Sema/

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/tool/ClangDocMain.cpp:181 +doc::writeInfo(I.get(), Buffer); + if (DumpResultToFile("bc", Group.getKey() + ".bc", Buffer)) +return 1; ioeric wrote: > juliehockett wrote: > > ioeric wrot

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 149371. juliehockett marked 13 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWrit

r333704 - [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager

Author: ddcc Date: Thu May 31 15:23:07 2018 New Revision: 333704 URL: http://llvm.org/viewvc/llvm-project?rev=333704&view=rev Log: [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager Summary: Clang does not have a corresponding QualType for a 1-bit APSInt, so use the BoolTy and ext

[PATCH] D47603: [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager

This revision was automatically updated to reflect the committed changes. Closed by commit rL333704: [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager (authored by ddcc, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47603

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

tra added a comment. In https://reviews.llvm.org/D47394#1118223, @gtbercea wrote: > I tried this example > (https://devblogs.nvidia.com/separate-compilation-linking-cuda-device-code/). > It worked with NVCC but not with clang++. I can produce the main.o particle.o > and v.o objects as relocata

[PATCH] D47603: [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Thanks! Repository: rC Clang https://reviews.llvm.org/D47603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

r333703 - [WebAssembly] Use Windows EH instructions for Wasm EH

Author: aheejin Date: Thu May 31 15:18:13 2018 New Revision: 333703 URL: http://llvm.org/viewvc/llvm-project?rev=333703&view=rev Log: [WebAssembly] Use Windows EH instructions for Wasm EH Summary: Because wasm control flow needs to be structured, using WinEH instructions to support wasm EH brings

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

This revision was automatically updated to reflect the committed changes. Closed by commit rL333703: [WebAssembly] Use Windows EH instructions for Wasm EH (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44931 Files:

[PATCH] D47607: [libcxx] Almost fix some UB in and

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, EricWF, mclow.lists. Herald added subscribers: christof, kosarev. and define `__value_type` as a union between pair and pair so that various operations can move into/from these pairs [1]. This is a pretty blatant s

[PATCH] D47301: Warning for framework include violation from Headers to PrivateHeaders

bruno marked an inline comment as done. bruno added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:34-35 def AutoImport : DiagGroup<"auto-import">; def FrameworkHdrQuotedInclude : DiagGroup<"quoted-include-in-framework-header">; +def FrameworkIncludePriva

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

gtbercea added a comment. > Assuming we do proceed with back-to-CUDA approach, one thing I'd consider > would be using clang's -fcuda-include-gpubinary option which CUDA uses to > include GPU code into the host object. You may be able to use it to avoid > compiling and partially linking .fatbin

[PATCH] D47301: Warning for framework include violation from Headers to PrivateHeaders

bruno updated this revision to Diff 149361. bruno added a comment. Update patch after changes to https://reviews.llvm.org/D47157. Also address some of Volodymyr feedback. https://reviews.llvm.org/D47301 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticLexKinds.t

[PATCH] D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents

leonardchan updated this revision to Diff 149360. leonardchan marked 7 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D46911 Files: include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds

[PATCH] D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents

leonardchan added inline comments. Comment at: lib/Sema/DeclSpec.cpp:1123 +if (!(TypeSpecType == TST_accum || TypeSpecType == TST_fract)) { + S.Diag(TSSatLoc, diag::err_invalid_saturation_spec) + << getSpecifierName((TST)TypeSpecType, Policy); e

[PATCH] D47157: Warning for framework headers using double quote includes

bruno added inline comments. Comment at: test/Modules/double-quotes.m:24-25 + +// The same warnings show up when modules is on but -verify doesn't get it +// because they only show up under the module A building context. +// RUN: FileCheck --input-file=%t/stderr %s --

[PATCH] D47157: Warning for framework headers using double quote includes

bruno updated this revision to Diff 149359. bruno edited the summary of this revision. bruno added a comment. Update after Duncan's review: remove header name from the warning message (since it's already in the fixit) https://reviews.llvm.org/D47157 Files: include/clang/Basic/DiagnosticGroup

[PATCH] D47603: [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager

ddcc updated this revision to Diff 149356. ddcc added a comment. Add test, address comments Repository: rC Clang https://reviews.llvm.org/D47603 Files: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp test/Analysis/apsint.c Index: test/Analysis/apsint.c ==

[PATCH] D47603: [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager

ddcc added a comment. In https://reviews.llvm.org/D47603#1118138, @vlad.tsyrklevich wrote: > In https://reviews.llvm.org/D47603#1118106, @george.karpenkov wrote: > > > Would it be possible to add tests? I know we have very few unit tests, but > > I assume you could actually use an integration te

[PATCH] D47564: [Parse] Use CapturedStmt for @finally on MSVC

smeenai updated this revision to Diff 149351. smeenai edited the summary of this revision. smeenai added a comment. @rnk comment Repository: rC Clang https://reviews.llvm.org/D47564 Files: include/clang/AST/Stmt.h include/clang/Basic/CapturedStmt.h include/clang/Sema/ScopeInfo.h lib/

[PATCH] D47603: [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager

vlad.tsyrklevich added a comment. In https://reviews.llvm.org/D47603#1118106, @george.karpenkov wrote: > Would it be possible to add tests? I know we have very few unit tests, but I > assume you could actually use an integration test to exercise this path? I tested this change and it fixes PR3

[PATCH] D47564: [Parse] Use CapturedStmt for @finally on MSVC

rnk added a comment. Using CapturedStmt to do frontend outlining was the direction I suggested. I want to hear what @rsmith and @rjmccall think, though. Comment at: lib/Parse/ParseObjc.cpp:2588 + bool ShouldCapture = Actions.getASTContext() +

[PATCH] D47350: [analyzer] Track class member initializer constructors path-sensitively within their construction context.

george.karpenkov added a comment. 👍 https://reviews.llvm.org/D47350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47603: [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager

george.karpenkov requested changes to this revision. george.karpenkov added a comment. This revision now requires changes to proceed. Thanks! Looks good with minor changes. Would it be possible to add tests? I know we have very few unit tests, but I assume you could actually use an integration t

Re: [PATCH] D47597: IRGen: Write .dwo files when -split-dwarf-file is used together with -fthinlto-index.

On Thu, May 31, 2018 at 12:00 PM Peter Collingbourne wrote: > > > On Thu, May 31, 2018 at 11:54 AM, David Blaikie > wrote: > >> >> >> On Thu, May 31, 2018 at 11:20 AM Peter Collingbourne via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> pcc created this revision. >>> pcc added reviewe

[PATCH] D47603: [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager

ddcc created this revision. ddcc added reviewers: george.karpenkov, NoQ. Herald added subscribers: a.sidorin, szepet, xazax.hun. Clang does not have a corresponding QualType for a 1-bit APSInt, so use the BoolTy and extend the APSInt. Split from https://reviews.llvm.org/D35450. Repository: rC

[PATCH] D47157: Warning for framework headers using double quote includes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D47157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D47157: Warning for framework headers using double quote includes

dexonsmith added inline comments. Comment at: test/Modules/double-quotes.m:27-29 +// CHECK: double-quoted include "A0.h" in framework header, expected angle-bracketed include instead +// CHECK: double-quoted include "B.h" in framework header, expected angle-bracketed include

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

efriedma added reviewers: aemerson, rjmccall. efriedma added a comment. I'm not sure Apple will want to mess with their ABI like this... adding some reviewers. Otherwise LGTM. Comment at: lib/CodeGen/TargetInfo.cpp:5790 // than ABI alignment. - uint64_t ABIAlign = 4; - u

[PATCH] D47393: [clang-format] Disable AlwaysBreakBeforeMultilineStrings in Google style for Objective-C 📜

stephanemoore updated this revision to Diff 149338. stephanemoore added a comment. Removed the last format from the tests. That particular scenario was failing and it might need additional changes to pass. I also think that particular scenario is not critical to the change and can be considered

[PATCH] D47350: [analyzer] Track class member initializer constructors path-sensitively within their construction context.

NoQ updated this revision to Diff 149337. NoQ added a comment. Hmm, actually composition looks very pretty if you use the magic word "impl". https://reviews.llvm.org/D47350 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngine.cpp lib/Stati

[PATCH] D46664: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

adr26 added a comment. That's a nice change to avoid duplication in `ClassTemplateSpecializationDecl::getMostRecentDecl()`. Thanks for your help getting this out the door! Repository: rC Clang https://reviews.llvm.org/D46664 ___ cfe-commits mai

[PATCH] D47445: [ASTImporter] Corrected diagnostic client handling in tests.

akyrtzi added a comment. Thanks for the explanation. Please do add documentation comments for the new method so people using ASTUnit in their own code have an idea when and why they would need to call this. Something like "if you intend to emit additional diagnostics after the ASTUnit is create

Re: [PATCH] D47597: IRGen: Write .dwo files when -split-dwarf-file is used together with -fthinlto-index.

On Thu, May 31, 2018 at 11:54 AM, David Blaikie wrote: > > > On Thu, May 31, 2018 at 11:20 AM Peter Collingbourne via Phabricator < > revi...@reviews.llvm.org> wrote: > >> pcc created this revision. >> pcc added reviewers: tejohnson, dblaikie. >> Herald added subscribers: JDevlieghere, hiraditya,

[PATCH] D47600: [UBSan] DO NOT COMMIT: precise UBSan checks experiment

alekseyshl created this revision. clang part of the two part patch (LLVM + clang) LLVM part: https://reviews.llvm.org/D47599 Refer to https://reviews.llvm.org/D47599 for the detailed description. Repository: rC Clang https://reviews.llvm.org/D47600 Files: include/clang/Driver/Options.td

Re: [PATCH] D47597: IRGen: Write .dwo files when -split-dwarf-file is used together with -fthinlto-index.

On Thu, May 31, 2018 at 11:20 AM Peter Collingbourne via Phabricator < revi...@reviews.llvm.org> wrote: > pcc created this revision. > pcc added reviewers: tejohnson, dblaikie. > Herald added subscribers: JDevlieghere, hiraditya, eraman, inglorion, > mehdi_amini. > > https://reviews.llvm.org/D4759

[PATCH] D45517: [analyzer] False positive refutation with Z3

rnkovacs added a comment. In https://reviews.llvm.org/D45517#1117898, @mikhail.ramalho wrote: > Just want to comment here and give thanks again for the first version of > the refutation code. It's being really helpful to develop the approach this > code as a base; things would definitely be slo

[PATCH] D46664: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

rnk added a comment. Thanks for the patch, I committed it as r333680 with a minor modification. https://reviews.llvm.org/D46664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46664: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

This revision was automatically updated to reflect the committed changes. Closed by commit rC333680: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel() (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D46664?vs=149300&id=149329#toc Rep

r333680 - Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

Author: rnk Date: Thu May 31 11:42:29 2018 New Revision: 333680 URL: http://llvm.org/viewvc/llvm-project?rev=333680&view=rev Log: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel() Ensure latest MPT decl has a MSInheritanceAttr when instantiating templates, to avoid null M

[PATCH] D47157: Warning for framework headers using double quote includes

aaron.ballman added inline comments. Comment at: test/Modules/double-quotes.m:27-29 +// CHECK: double-quoted include "A0.h" in framework header, expected angle-bracketed include instead +// CHECK: double-quoted include "B.h" in framework header, expected angle-bracketed includ

[PATCH] D47499: [analyzer] Annotate program state update methods with LLVM_NODISCARD.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333679: [analyzer] Annotate ProgramState update methods with LLVM_NODISCARD. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

r333679 - [analyzer] Annotate ProgramState update methods with LLVM_NODISCARD.

Author: dergachev Date: Thu May 31 11:30:41 2018 New Revision: 333679 URL: http://llvm.org/viewvc/llvm-project?rev=333679&view=rev Log: [analyzer] Annotate ProgramState update methods with LLVM_NODISCARD. Because our program states are immutable, methods like "add<>", "set<>", "bind" create a cop

[PATCH] D47157: Warning for framework headers using double quote includes

dexonsmith added inline comments. Comment at: test/Modules/double-quotes.m:24-25 + +// The same warnings show up when modules is on but -verify doesn't get it +// because they only show up under the module A building context. +// RUN: FileCheck --input-file=%t/stderr %s -

[PATCH] D47597: IRGen: Write .dwo files when -split-dwarf-file is used together with -fthinlto-index.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333677: IRGen: Write .dwo files when -split-dwarf-file is used together with -fthinlto… (authored by pcc, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

r333677 - IRGen: Write .dwo files when -split-dwarf-file is used together with -fthinlto-index.

Author: pcc Date: Thu May 31 11:25:59 2018 New Revision: 333677 URL: http://llvm.org/viewvc/llvm-project?rev=333677&view=rev Log: IRGen: Write .dwo files when -split-dwarf-file is used together with -fthinlto-index. Differential Revision: https://reviews.llvm.org/D47597 Added: cfe/trunk/tes

[PATCH] D47597: IRGen: Write .dwo files when -split-dwarf-file is used together with -fthinlto-index.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM thanks! https://reviews.llvm.org/D47597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D47578: Do not enforce absolute path argv0 in windows

ruiu added inline comments. Comment at: llvm/lib/Support/Windows/Process.inc:226 + +static std::error_code GetLongArgv0Path(const wchar_t *Argv0, +SmallVectorImpl &Args, It looks like this function is a bit too complicated.

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

rsmith added inline comments. Comment at: lib/Basic/TargetInfo.cpp:45 + AccumWidth = AccumAlign = 32; + LongAccumWidth = LongAccumAlign = 64; SuitableAlign = 64; leonardchan wrote: > leonardchan wrote: > > ebevhan wrote: > > > leonardchan wrote: > > > > rsmi

[PATCH] D47597: IRGen: Write .dwo files when -split-dwarf-file is used together with -fthinlto-index.

pcc created this revision. pcc added reviewers: tejohnson, dblaikie. Herald added subscribers: JDevlieghere, hiraditya, eraman, inglorion, mehdi_amini. https://reviews.llvm.org/D47597 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinlto-split-dwarf.c llvm/include/llvm/LTO/Co

[PATCH] D45517: [analyzer] False positive refutation with Z3

mikhail.ramalho added subscribers: dcoughlin, george.karpenkov, NoQ. mikhail.ramalho added a comment. Hi, > Just a bit of context and to have some expectation management regarding > this patch. The main purpose of this implementation was to back a thesis. > It was made under a very serious time

[PATCH] D45517: [analyzer] False positive refutation with Z3

mikhail.ramalho updated this revision to Diff 149317. mikhail.ramalho marked 6 inline comments as not done. mikhail.ramalho added a comment. - Simplified refutation process: it now collects all the constraints in a given path and, only when it reaches the root node, the refutation manager is crea

[PATCH] D47157: Warning for framework headers using double quote includes

bruno updated this revision to Diff 149313. bruno added a comment. Updated the patch after Duncan and Aaron reviews. I actually went a bit more aggressive with the fixits, since I realized the conditions for the warning are already strict enough and we should take the chance to be more clear. Fo

[PATCH] D47557: Filesystem tests: un-confuse write time

EricWF added a comment. So the reason there are `atime` tests at all is due to the implementation details of `__last_write_time` here. Essentially we have to do extra work trying to maintain the access time. I'm OK with this patches rename. `first` and `second` were certainly not clear. That b

[clang-tools-extra] r333673 - PrintEscapedString -> printEscapedString

Author: jdevlieghere Date: Thu May 31 10:36:31 2018 New Revision: 333673 URL: http://llvm.org/viewvc/llvm-project?rev=333673&view=rev Log: PrintEscapedString -> printEscapedString Update PrintEscapedString after renaming it in ADT. Modified: clang-tools-extra/trunk/clangd/Protocol.cpp Modif

  1   2   >