[PATCH] D47979: [X86] Lowering Mask Scalar add/sub/mul/div intrinsics to native IR (Clang part)

craig.topper added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:9926 +Value *Div = Builder.CreateFDiv(A, B); +llvm::VectorType *MaskTy = llvm::VectorType::get(Builder.getInt1Ty(), + cast(Mask->getType())->getBitWidth());

[PATCH] D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments

rjmccall added a reviewer: t.p.northover. rjmccall added a comment. Okay, as a code change this seems more reasonable to me. I haven't really thought through the ABI-compatibility issues, though. CC'ing Tim. https://reviews.llvm.org/D46013 ___

[PATCH] D47627: [ASTContext] Make getAddrSpaceQualType replace address spaces.

rjmccall added a comment. In https://reviews.llvm.org/D47627#1121970, @ebevhan wrote: > There's actually a bit more to it than in these two patches. The complete > diff to this function in our downstream Clang looks like this: > >QualType >ASTContext::getAddrSpaceQualType(QualType T,

[PATCH] D46651: [OpenCL] Support new/delete in Sema

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:13010 + if (SemaRef.getLangOpts().OpenCLCPlusPlus) { +if (auto *PtrTy = ResultType.getTypePtr()->getAs()) { + ResultType = RemoveAddressSpaceFromPtr(SemaRef, PtrTy); `getTypePtr()` is

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

rjmccall added inline comments. Comment at: lib/Sema/SemaObjCProperty.cpp:2554 + PropertyTy->isObjCRetainableType() && + !PropertyTy->isObjCClassType()) { +Diag(Loc, diag::warn_objc_property_assign_on_object); Please use

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Charusso updated this revision to Diff 150645. Charusso added a comment. Fix some comment. https://reviews.llvm.org/D45050 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Charusso updated this revision to Diff 150644. Charusso added a comment. Clang format. https://reviews.llvm.org/D45050 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Charusso added a comment. @lebedev.ri there is all the false positive results from the last publicated result-dump: F6334659: curl-lib-curl_path-c.html second result: F6334660: ffmpeg-libavformat-sdp.c.html all result:

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen

Charusso updated this revision to Diff 150643. Charusso marked 4 inline comments as done. Charusso added a comment. `memchr()` revision: it is problematic if the second argument is `'\0'`, there is no other case. Added a new type of matcher, to match function calls. More static functions and

[PATCH] D47988: [CodeGen] Emit MSVC funclet IR for Obj-C exceptions

smeenai added a comment. @rnk remember how I was asking you about inlining into catchpads on IRC a few days back? It was in relation to this change. If I have a file `finally1.m`: void f(void); void g() { @try { f(); } @finally { f(); } } and compile it with:

[PATCH] D47988: [CodeGen] Emit MSVC funclet IR for Obj-C exceptions

smeenai created this revision. smeenai added reviewers: DHowett-MSFT, compnerd, majnemer, rjmccall, rnk. We're implementing funclet-compatible code generation for Obj-C exceptions when using the MSVC ABI. The idea is that the Obj-C runtime will wrap Obj-C exceptions inside C++ exceptions, which

[PATCH] D47987: Provide only one declaration of __throw_runtime_error

dim created this revision. dim added reviewers: hiraditya, mclow.lists, EricWF. Herald added subscribers: christof, krytarowski, emaste. In https://reviews.llvm.org/rL279903, @hiraditya added a second declaration of `__throw_runtime_error` to `include/__locale`. The original declaration was in

[PATCH] D47416: [analyzer] Clean up the program state map of DanglingInternalBufferChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL334352: [analyzer] Clean up the program state map of DanglingInternalBufferChecker. (authored by rkovacs, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D47416: [analyzer] Clean up the program state map of DanglingInternalBufferChecker

NoQ accepted this revision. NoQ added a comment. Great, thanks! https://reviews.llvm.org/D47416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47416: [analyzer] Clean up the program state map of DanglingInternalBufferChecker

rnkovacs updated this revision to Diff 150637. rnkovacs marked 3 inline comments as done. rnkovacs added a comment. Addressed comments. https://reviews.llvm.org/D47416 Files: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp Index:

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

EricWF updated this revision to Diff 150635. EricWF added a comment. Remove `-nostdinc++` check as requested. https://reviews.llvm.org/D45015 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Driver/ToolChains/Darwin.cpp

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

EricWF added a comment. In https://reviews.llvm.org/D45015#1127046, @vsapsai wrote: > In https://reviews.llvm.org/D45015#1121762, @EricWF wrote: > > > In https://reviews.llvm.org/D45015#1121581, @ahatanak wrote: > > > > > Could you elaborate on what kind of changes you are planning to make in >

[PATCH] D47416: [analyzer] Clean up the program state map of DanglingInternalBufferChecker

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:92-94 + if (!SymReaper.hasDeadSymbols()) +return; + This optimization is in fact incorrect due to an old bug that i didn't yet get to fixing: D18860. The

r334348 - [analyzer] Add dangling internal buffer check.

Author: rkovacs Date: Sat Jun 9 06:03:49 2018 New Revision: 334348 URL: http://llvm.org/viewvc/llvm-project?rev=334348=rev Log: [analyzer] Add dangling internal buffer check. This check will mark raw pointers to C++ standard library container internal buffers 'released' when the objects

[PATCH] D47416: [analyzer] Clean up the program state map of DanglingInternalBufferChecker

rnkovacs updated this revision to Diff 150625. rnkovacs marked an inline comment as done. rnkovacs edited the summary of this revision. rnkovacs added a comment. Herald added a subscriber: mikhail.ramalho. Fixed naming and added an extra pass for regions left behind by incomplete destructors.

[PATCH] D47693: [X86] Use target independent masked expandload and compressstore intrinsics to implement expandload/compressstore builtins.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. We're going to need more codegen tests on the llvm side - test coverage (fast-isel and intrinsics) isn't great. But LGTM on the clang side. Repository: rC Clang

[PATCH] D47135: [analyzer] A checker for dangling internal buffer pointers in C++

This revision was automatically updated to reflect the committed changes. Closed by commit rL334348: [analyzer] Add dangling internal buffer check. (authored by rkovacs, committed by ). Herald added subscribers: llvm-commits, mikhail.ramalho. Changed prior to commit:

[PATCH] D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin

aaron.ballman added a comment. In https://reviews.llvm.org/D47290#1127190, @jfb wrote: > In https://reviews.llvm.org/D47290#1126443, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D47290#1125028, @aaron.ballman wrote: > > > > > Okay, that's fair, but the vendor-specific type for my

[PATCH] D47979: [X86] Lowering Mask Scalar add/sub/mul/div intrinsics to native IR (Clang part)

tkrupa created this revision. tkrupa added reviewers: craig.topper, RKSimon, spatel, sroland. Herald added a subscriber: cfe-commits. I did the div differently because it got split to three basic blocks with a branch condition (due to div being an expensive operation) and couldn't be combined

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

MTC added a comment. LGTM, @NoQ May have further feedback. Thanks! Repository: rC Clang https://reviews.llvm.org/D47044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin

jfb added a comment. In https://reviews.llvm.org/D47290#1126443, @aaron.ballman wrote: > In https://reviews.llvm.org/D47290#1125028, @aaron.ballman wrote: > > > Okay, that's fair, but the vendor-specific type for my Windows example is > > spelled `DWORD`. I'm really worried that this special