This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334471: Fix that AlignedAllocation.h doesnt compile
because of VersionTuple (authored by teemperor, committed by ).
Author: teemperor
Date: Mon Jun 11 20:43:21 2018
New Revision: 334471
URL: http://llvm.org/viewvc/llvm-project?rev=334471=rev
Log:
Fix that AlignedAllocation.h doesn't compile because of VersionTuple
Summary:
rL334399 put VersionTuple in the llvm namespace, but this header still assumes
it's
Author: phosek
Date: Mon Jun 11 20:31:03 2018
New Revision: 334470
URL: http://llvm.org/viewvc/llvm-project?rev=334470=rev
Log:
[CMake] Add a missing target dependency on C++ ABI headers
This resolves the breakage introduced in r334468 which results in
build error when using CMake Makefile
teemperor created this revision.
https://reviews.llvm.org/rL334399 put VersionTuple in the llvm namespace, but
this header still assumes it's in the clang namespace.
This leads to compilation failures with enabled modules when building Clang.
Repository:
rC Clang
Author: phosek
Date: Mon Jun 11 20:10:02 2018
New Revision: 334468
URL: http://llvm.org/viewvc/llvm-project?rev=334468=rev
Log:
Reland "Use custom command and target to install libc++ headers"
Using file(COPY FILE...) has several downsides. Since the file command
is only executed at
Author: marshall
Date: Mon Jun 11 19:45:30 2018
New Revision: 334467
URL: http://llvm.org/viewvc/llvm-project?rev=334467=rev
Log:
Update the to-do list with motions from Rapperswil.
Modified:
libcxx/trunk/www/cxx2a_status.html
Modified: libcxx/trunk/www/cxx2a_status.html
URL:
Higuoxing added a comment.
In https://reviews.llvm.org/D47687#1128757, @dexonsmith wrote:
>
> Yes, I think understand the patch; but I think it's the wrong direction. I
> think we should just make the existing `-Wlogical-op-parentheses` smart
> enough to show actionable warnings in macros
Hi Reid,
Actually, it seems all four tests you changed are failing on one Windows bot
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12464.
Can you please take a look and fix the tests?
Douglas Yung
> -Original Message-
> From: cfe-commits
MTC added a comment.
In https://reviews.llvm.org/D48027#1128301, @xazax.hun wrote:
> Having C++ support would be awesome!
> Thanks for working on this!
>
> While I do agree matching is not trivial with qualified names, this problem
> is already solved with AST matchers.
>
> I wonder if using
rjmccall added a comment.
In https://reviews.llvm.org/D47233#1129110, @smeenai wrote:
> Wrapping an Objective-C exception inside a C++ exception means dynamically
> constructing a C++ exception object and traversing the class hierarchy of the
> thrown Obj-C object to populate the catchable
Hi Reid,
I don't know if you noticed, but one of the tests you changed with this commit
is failing on the PS4 Windows bot. Can you take a look?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/17695/
FAIL: Clang :: Driver/crash-report-modules.m (7229 of
ormris added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
NoQ wrote:
> NoQ wrote:
> > george.karpenkov wrote:
> > > ormris wrote:
> > > >
yaxunl updated this revision to Diff 150872.
yaxunl marked 2 inline comments as done.
yaxunl retitled this revision from "[CUDA][HIP] Allow CUDA `__global__`
functions to have amdgpu kernel attributes" to "[CUDA][HIP] Allow CUDA
__global__ functions to have amdgpu kernel attributes".
yaxunl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334457: [CUDA][HIP] Set kernel calling convention before
arrange function (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: yaxunl
Date: Mon Jun 11 17:16:33 2018
New Revision: 334457
URL: http://llvm.org/viewvc/llvm-project?rev=334457=rev
Log:
[CUDA][HIP] Set kernel calling convention before arrange function
Currently clang set kernel calling convention for CUDA/HIP after
arranging function, which causes
smeenai added a comment.
Wrapping an Objective-C exception inside a C++ exception means dynamically
constructing a C++ exception object and traversing the class hierarchy of the
thrown Obj-C object to populate the catchable types array of the C++ exception.
Microsoft's C++ runtime will perform
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
NoQ wrote:
> george.karpenkov wrote:
> > ormris wrote:
> > > george.karpenkov wrote:
> > >
NoQ added a comment.
Thanks, this looks very reasonable!
I agree that the syntax pointed out by @george.karpenkov is much cleaner.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/LoopWidening.h:30
ProgramStateRef getWidenedLoopState(ProgramStateRef PrevState,
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334448: - Add AV as new default acronym. - Add
support for I and A in… (authored by Wizard, committed
by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
Author: wizard
Date: Mon Jun 11 15:44:06 2018
New Revision: 334448
URL: http://llvm.org/viewvc/llvm-project?rev=334448=rev
Log:
- Add "AV" as new default acronym. - Add support for "I" and "A" in
lowerCamelCase pattern
Summary: Now we can support property names like "hasADog" correctly.
rjmccall added a comment.
The non-fragile Objective-C path — i.e. interoperation with C++ exceptions
instead of using `setjmp`/`longjmp` in an utterly-incompatible style — is
absolutely the right direction going forward.
How does "wrapping an Objective-C exception inside a C++ exception" work?
Author: phosek
Date: Mon Jun 11 15:06:44 2018
New Revision: 334445
URL: http://llvm.org/viewvc/llvm-project?rev=334445=rev
Log:
[CMake] Use libc++ and compiler-rt for bootstrap Fuchsia Clang
We want to build the second stage compiler with libc++ and compiler-rt,
also include builtins and
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334445: [CMake] Use libc++ and compiler-rt for bootstrap
Fuchsia Clang (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47356?vs=150841=150859#toc
Repository:
rjmccall added a comment.
Thanks, comment change looks good. LGTM.
https://reviews.llvm.org/D48040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma added a reviewer: rsmith.
efriedma added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:228
+ S.getASTContext(), Ty, /*consume*/ false);
+ Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+ TheCall->setArg(2, Arg.get());
rsmith added a comment.
We need to figure out what should happen in the OpenCL case, but the rest seems
fine.
Comment at: lib/Sema/SemaChecking.cpp:3360
}
-if (AtomTy.isConstQualified() ||
+if ((Form != Load && Form != LoadCopy && AtomTy.isConstQualified()) ||
efriedma added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:10071
+ // is _MM_FROUND_CUR_DIRECTION
+ if (cast(Ops[4])->getZExtValue() != 4)
+UsesNonDefaultRounding = true;
Given we're ignoring floating-point exceptions, we should also
vsapsai added a comment.
With this change and the mentioned libc++ change the tests with old libc++
dylib are passing (didn't test all possible configurations though). Would like
to get more feedback from other reviewers on this matter.
https://reviews.llvm.org/D45015
erichkeane created this revision.
erichkeane added a reviewer: eli.friedman.
Enable these builtins to be called across a lambda
boundary, as brought up by Eli here: https://reviews.llvm.org/D48040
Repository:
rC Clang
https://reviews.llvm.org/D48053
Files:
lib/Sema/SemaChecking.cpp
erichkeane added a comment.
Alright, done here: https://reviews.llvm.org/D48053
This one'll require some rebasing on that change, but I'm not sure how to do it
in SVN. Therefore, I'll just rebase this one when it comes to commit it.
-Erich
https://reviews.llvm.org/D48040
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
This makes much more sense. Thanks @joerg
https://reviews.llvm.org/D38680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
phosek updated this revision to Diff 150841.
Repository:
rC Clang
https://reviews.llvm.org/D47356
Files:
clang/cmake/caches/Fuchsia.cmake
Index: clang/cmake/caches/Fuchsia.cmake
===
--- clang/cmake/caches/Fuchsia.cmake
+++
phosek updated this revision to Diff 150838.
phosek marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D47355
Files:
clang/CMakeLists.txt
Index: clang/CMakeLists.txt
===
--- clang/CMakeLists.txt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334437: [CMake] Allow specifying extra dependencies of
bootstrap stage (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: phosek
Date: Mon Jun 11 13:59:31 2018
New Revision: 334437
URL: http://llvm.org/viewvc/llvm-project?rev=334437=rev
Log:
[CMake] Allow specifying extra dependencies of bootstrap stage
This allows adding additional bootstrap dependencies to the bootstrap
compiler that may be needed by
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
I prefer `DEPS` to `COMPONENTS` because I've tried to explicitly use the term
components to mean targets that have paired build and install targets.
Otherwise looks good.
Repository:
rC
erichkeane added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:210
+Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+TheCall->setArg(I, Arg.get());
}
efriedma wrote:
> erichkeane wrote:
> > efriedma wrote:
> > > Can you
efriedma added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:210
+Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+TheCall->setArg(I, Arg.get());
}
erichkeane wrote:
> efriedma wrote:
> > Can you split this change into a
george.burgess.iv closed this revision.
george.burgess.iv added a comment.
Herald added a subscriber: JDevlieghere.
(Committed as noted by echristo; just trying to clean my queue a bit. :) )
https://reviews.llvm.org/D30760
___
cfe-commits mailing
rnk added a comment.
In https://reviews.llvm.org/D47672#1128308, @hans wrote:
> It sounds like adding proper support for HLE prefixes is a largeish project.
>
> ctopper, rnk: Do you think it would be worth adding inline asm versions (with
> the xacquire/release prefixes) of these intrinsics in
NoQ added a comment.
In https://reviews.llvm.org/D47671#1127486, @xazax.hun wrote:
> Just for the record, there is a common example where relying on copy elision
> might bite and google do not recommend relying on it for correctness:
> https://abseil.io/tips/120
>
> The main purpose of sharing
lei updated this revision to Diff 150821.
https://reviews.llvm.org/D48044
Files:
include/clang/AST/Type.h
lib/CodeGen/TargetInfo.cpp
test/CodeGen/ppc64le-f128Aggregates.c
Index: test/CodeGen/ppc64le-f128Aggregates.c
===
---
gtbercea marked 3 inline comments as done.
gtbercea added inline comments.
Comment at: include/clang/Driver/Compilation.h:312
+ /// \param skipBundler - bool value set once by the driver.
+ void setSkipOffloadBundler(bool skipBundler);
+
sfantao wrote:
> Why
Author: vsapsai
Date: Mon Jun 11 12:42:27 2018
New Revision: 334431
URL: http://llvm.org/viewvc/llvm-project?rev=334431=rev
Log:
Mark the test using to require c++experimental.
When built against the old libc++ version the test was causing linker error
Undefined symbols for architecture
dexonsmith added a comment.
In https://reviews.llvm.org/D47687#1127120, @Higuoxing wrote:
> In https://reviews.llvm.org/D47687#1126607, @dexonsmith wrote:
>
> > In https://reviews.llvm.org/D47687#1126074, @lebedev.ri wrote:
> >
> > > In https://reviews.llvm.org/D47687#1126032, @Higuoxing wrote:
tobiasvk added a comment.
In https://reviews.llvm.org/D34156#1125489, @vlad.tsyrklevich wrote:
> Hi Tobias, I tracked down the failure self-hosting LLVM with LTO with this
> revision to https://bugs.llvm.org/show_bug.cgi?id=37684#c2 and have a fix
> under review in
erichkeane added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:210
+Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+TheCall->setArg(I, Arg.get());
}
efriedma wrote:
> Can you split this change into a separate patch?
efriedma added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:210
+Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
+TheCall->setArg(I, Arg.get());
}
Can you split this change into a separate patch? Testcase:
```
int a() {
erichkeane updated this revision to Diff 150808.
erichkeane marked an inline comment as done.
https://reviews.llvm.org/D48040
Files:
lib/AST/ExprConstant.cpp
lib/Sema/SemaChecking.cpp
test/SemaCXX/builtins-overflow.cpp
Index: lib/AST/ExprConstant.cpp
lei created this revision.
lei added reviewers: hfinkel, kbarton, nemanjai, power-llvm-team.
Update clang to treat fp128 as a valid base type for homogeneous aggregate
passing and returning.
https://reviews.llvm.org/D48044
Files:
include/clang/AST/Type.h
lib/CodeGen/TargetInfo.cpp
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Ok.
https://reviews.llvm.org/D47733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rjmccall added inline comments.
Comment at: lib/AST/ExprConstant.cpp:8260
+ // It won't GROW, since that isn't possible, so use this to allow
+ // TruncOrSelf.
+ APSInt Temp = Result.extOrTrunc(Info.Ctx.getTypeSize(ResultType));
The comment should
rjmccall accepted this revision.
rjmccall added a comment.
LGTM.
Comment at: lib/Sema/SemaExprCXX.cpp:2030
+ }
+}
svenvh wrote:
> rjmccall wrote:
> > Anastasia wrote:
> > > svenvh wrote:
> > > > rjmccall wrote:
> > > > > I think a better
rjmccall added a comment.
In https://reviews.llvm.org/D47627#1127716, @ebevhan wrote:
> > Well, the documentation mismatch is worth fixing even if the code isn't.
> > But I think at best your use-case calls for weakening the assertion to be
> > that any existing address space isn't
erichkeane created this revision.
erichkeane added reviewers: eli.friedman, rjmccall.
As requested here:https://bugs.llvm.org/show_bug.cgi?id=37633
permit the __builtin_*_overflow builtins in constexpr functions.
Repository:
rC Clang
https://reviews.llvm.org/D48040
Files:
Wizard created this revision.
Herald added a subscriber: cfe-commits.
Wizard edited the summary of this revision.
Wizard added reviewers: benhamilton, hokein.
Now we can support property names like "hasADog" correctly.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48039
tzik added a comment.
rsmith: ping. Any chance you could review this?
Repository:
rC Clang
https://reviews.llvm.org/D47586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar created this revision.
jlebar added a reviewer: rsmith.
Herald added subscribers: llvm-commits, sanjoy.
Tests for https://reviews.llvm.org/D48036 / PR37753.
Repository:
rT test-suite
https://reviews.llvm.org/D48037
Files:
External/CUDA/algorithm.cu
Index:
jlebar created this revision.
jlebar added a reviewer: rsmith.
Herald added a subscriber: sanjoy.
Fixes PR37753: min/max can't be called from __host__ __device__
functions in C++14 mode.
Testcase in a separate test-suite commit.
https://reviews.llvm.org/D48036
Files:
svenvh added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:2030
+ }
+}
rjmccall wrote:
> Anastasia wrote:
> > svenvh wrote:
> > > rjmccall wrote:
> > > > I think a better interpretation of this rule would be to just error on
> > > > attempts
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
ormris wrote:
> george.karpenkov wrote:
> > IMO using the iterator directly
svenvh updated this revision to Diff 150788.
svenvh added a comment.
Dropped 2 redundant uses of `getTypePtr()`; minor formatting changes.
https://reviews.llvm.org/D46651
Files:
lib/Sema/SemaDeclCXX.cpp
lib/Sema/SemaExprCXX.cpp
lib/Sema/SemaType.cpp
test/SemaOpenCLCXX/newdelete.cl
malaperle added a comment.
In https://reviews.llvm.org/D47950#1128487, @sammccall wrote:
> In https://reviews.llvm.org/D47950#1128370, @malaperle wrote:
>
> > Very nice! I tried "std" and got much less (unimportant) results. I see
> > something a bit weird with "getStandardResourceDir" but it
ormris added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
george.karpenkov wrote:
> IMO using the iterator directly (e.g. like it was done in
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334421: [clang-fuzzer] Modified protobuf and converter to
add new signature, remove… (authored by morehouse, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D47964
Files:
Author: ctopper
Date: Mon Jun 11 10:06:01 2018
New Revision: 334422
URL: http://llvm.org/viewvc/llvm-project?rev=334422=rev
Log:
[X86] Fix operand order in the shuffle created for blend builtins.
This was broken when the builtin was added in r334249.
Modified:
Author: morehouse
Date: Mon Jun 11 10:05:45 2018
New Revision: 334421
URL: http://llvm.org/viewvc/llvm-project?rev=334421=rev
Log:
[clang-fuzzer] Modified protobuf and converter to add new signature, remove
conditionals.
Changed the function signature and removed conditionals from loop body.
sammccall added a comment.
In https://reviews.llvm.org/D47950#1128370, @malaperle wrote:
> Very nice! I tried "std" and got much less (unimportant) results. I see
> something a bit weird with "getStandardResourceDir" but it might be VSCode.
> Here, I guess it's the "d" in Dir that matches but
krasimir added a comment.
In https://reviews.llvm.org/D48034#1128475, @sammccall wrote:
> All else equal, I'd expect this to be a hard rule, at least in google-style.
>
> "foo\n { a: b }" --> "foo {\n a: b\n}" only makes the first line longer, by
> 2 chars. So if 78 < indent + len("foo") <=
sammccall added a comment.
All else equal, I'd expect this to be a hard rule, at least in google-style.
"foo\n { a: b }" --> "foo {\n a: b\n}" only makes the first line longer, by 2
chars. So if 78 < indent + len("foo") <= 80 we're breaking the line limit, but
that seems vanishingly rare.
emmettneyman updated this revision to Diff 150783.
emmettneyman added a comment.
- removed include statement meant for testing
Repository:
rC Clang
https://reviews.llvm.org/D47964
Files:
tools/clang-fuzzer/cxx_loop_proto.proto
tools/clang-fuzzer/proto-to-cxx/loop_proto_to_cxx.cpp
emmettneyman added a comment.
@kcc suggested removing conditionals for now and adding them back later.
include statement was for testing; I'll remove it and resubmit.
Repository:
rC Clang
https://reviews.llvm.org/D47964
___
cfe-commits mailing
Author: rnk
Date: Mon Jun 11 09:50:07 2018
New Revision: 334418
URL: http://llvm.org/viewvc/llvm-project?rev=334418=rev
Log:
Enable crash recovery tests on Windows, globs work in the lit internal shell now
Modified:
cfe/trunk/test/Driver/crash-report-header.h
krasimir created this revision.
Herald added a subscriber: cfe-commits.
Currently clang-format allows this for text protos:
submessage:
{ key: 'aa' }
when it is under the column limit and when putting it all on one line exceeds
the column limit.
Author: rnk
Date: Mon Jun 11 09:49:43 2018
New Revision: 334417
URL: http://llvm.org/viewvc/llvm-project?rev=334417=rev
Log:
[MS] Use mangled names and comdats for string merging with ASan
This should reduce the binary size penalty of ASan on Windows. After
r334313, ASan will add red zones to
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89
+new Callback(LCtx, MRMgr, ITraits));
+ Finder.matchAST(ASTCtx);
+
IMO using the iterator directly (e.g. like it was done in
morehouse added inline comments.
Comment at: tools/clang-fuzzer/cxx_loop_proto.proto:67
-AssignmentStatement assignment = 1;
-IfElse ifelse = 2;
- }
Do you really want to get rid of if-else?
Comment at:
Author: ctopper
Date: Mon Jun 11 09:34:10 2018
New Revision: 334416
URL: http://llvm.org/viewvc/llvm-project?rev=334416=rev
Log:
[X86] Properly account for the immediate being multiplied by 8 in the immediate
range checking for BI__builtin_ia32_psrldqi128 and friends.
The limit was set to 1023
Author: rkovacs
Date: Sat Jun 9 14:08:27 2018
New Revision: 334352
URL: http://llvm.org/viewvc/llvm-project?rev=334352=rev
Log:
[analyzer] Clean up the program state map of DanglingInternalBufferChecker.
Symbols are cleaned up from the program state map when they go out of scope.
Memory regions
alexfh added a comment.
Herald added a subscriber: mikhail.ramalho.
This commit seems to have introduced
https://bugs.llvm.org/show_bug.cgi?id=37769. Could you take a look?
Repository:
rL LLVM
https://reviews.llvm.org/D45706
___
cfe-commits
ormris marked 2 inline comments as done.
ormris added a comment.
Thanks for the review @MTC! I'll wait for @NoQ's feedback.
Repository:
rC Clang
https://reviews.llvm.org/D47044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334415: clang-format: [JS] strict prop init annotation.
(authored by mprobst, committed by ).
Herald added a subscriber:
Author: mprobst
Date: Mon Jun 11 09:20:13 2018
New Revision: 334415
URL: http://llvm.org/viewvc/llvm-project?rev=334415=rev
Log:
clang-format: [JS] strict prop init annotation.
Summary:
TypeScript uses the `!` token for strict property initialization
assertions, as in:
class X {
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334414: [Driver] Add aliases for -Qn/-Qy (authored by
miyuki, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48021?vs=150732=150772#toc
Repository:
rC Clang
Author: miyuki
Date: Mon Jun 11 09:10:06 2018
New Revision: 334414
URL: http://llvm.org/viewvc/llvm-project?rev=334414=rev
Log:
[Driver] Add aliases for -Qn/-Qy
This patch adds aliases for -Qn (-fno-ident) and -Qy (-fident) which
look less cryptic than -Qn/-Qy. The aliases are compatible with
malaperle added a comment.
Very nice! I tried "std" and got much less (unimportant) results. I see
something a bit weird with "getStandardResourceDir" but it might be VSCode.
Here, I guess it's the "d" in Dir that matches but what's odd is that VS Code
will highlight the first "d", i.e. in
mprobst updated this revision to Diff 150770.
mprobst added a comment.
fix typo in test
Repository:
rC Clang
https://reviews.llvm.org/D48030
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
mprobst created this revision.
mprobst added a reviewer: krasimir.
TypeScript uses the `!` token for strict property initialization
assertions, as in:
class X {
strictPropAsserted!: string;
}
Previously, clang-format would wrap between the `!` and the `:` for
overly long lines. This
GBuella added a comment.
Ping @efriedma
https://reviews.llvm.org/D45616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GBuella updated this revision to Diff 150767.
GBuella added a comment.
I altered the code, to ignore the the signaling behaviour, as suggested.
Also, it handles more vector cmp builtins now.
https://reviews.llvm.org/D45616
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx-builtins.c
hans added a comment.
It sounds like adding proper support for HLE prefixes is a largeish project.
ctopper, rnk: Do you think it would be worth adding inline asm versions (with
the xacquire/release prefixes) of these intrinsics in the meantime? It would
inhibit optimizations but be better than
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D46845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added a comment.
Having C++ support would be awesome!
Thanks for working on this!
While I do agree matching is not trivial with qualified names, this problem is
already solved with AST matchers.
I wonder if using matchers or reusing the `HasNameMatcher` class would make
this easier.
MTC updated this revision to Diff 150758.
MTC added a comment.
Remove useless header files for testing.
Repository:
rC Clang
https://reviews.llvm.org/D48027
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h
lib/StaticAnalyzer/Core/CallEvent.cpp
Index:
MTC added a comment.
The implementation is not complicated, the difficulty is that there is no good
way to get the qualified name without template arguments. For
'std::basic_string::c_str()', its qualified name may be
`std::__1::basic_string,
std::__1::allocator >::c_str`, it is almost
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334408: clang-format: Introduce BreakInheritanceList option
(authored by Typz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43015?vs=150755=150756#toc
Repository:
rC Clang
Author: typz
Date: Mon Jun 11 07:41:26 2018
New Revision: 334408
URL: http://llvm.org/viewvc/llvm-project?rev=334408=rev
Log:
clang-format: Introduce BreakInheritanceList option
Summary:
This option replaces the BreakBeforeInheritanceComma option with an
enum, thus introducing a mode where the
Typz updated this revision to Diff 150755.
Typz added a comment.
rebase
Repository:
rC Clang
https://reviews.llvm.org/D43015
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
MTC created this revision.
MTC added reviewers: xazax.hun, NoQ, george.karpenkov.
Herald added subscribers: mikhail.ramalho, a.sidorin, rnkovacs, szepet.
`CallDecription` can only handle function for the time being. If we want to
match c++ method, we can only use method name to match and can't
russellmcc added a comment.
Bump! Thanks again for your feedback.
https://reviews.llvm.org/D40988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 127 matches
Mail list logo
