[PATCH] D49285: [clang-tidy] readability-inconsistent-declaration-parameter-name: accept approximate name matches.

sammccall added a comment. (First foray into clang-tidy, not sure what I'm doing...) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49285: [clang-tidy] readability-inconsistent-declaration-parameter-name: accept approximate name matches.

sammccall updated this revision to Diff 155340. sammccall added a comment. Make strictness (old behavior) available as an option. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49285 Files: clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp

[PATCH] D49285: [clang-tidy] readability-inconsistent-declaration-parameter-name: accept approximate name matches.

sammccall created this revision. Herald added subscribers: cfe-commits, xazax.hun. The goal is to reduce false positives when the difference is intentional, like: foo(StringRef name); foo(StringRef name_ref) { string name = cleanup(name_ref); ... } Or semantically unimportant, like:

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 155336. Rakete edited the summary of this revision. Rakete added a comment. Addressed review comments. Repository: rC Clang https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1307 + (Style.BraceWrapping.BeforeLambdaBody && Current.Next != nullptr && +Current.Next->is(TT_LambdaLSquare))); State.Stack.back().IsInsideObjCArrayLiteral = I think

[PATCH] D49268: [clang-doc] Create a script to generate tests

lebedev.ri added a comment. Nice! Some comments. Sorry about lack of the review, this kinda fell off my radar. Did you meant to commit `clang-tools-extra/clang-doc/test_cases/` ? I can't tell whether it is a temporary directory or not. Comment at:

[PATCH] D49010: YAML output for index-while-building

yvvan updated this revision to Diff 155331. https://reviews.llvm.org/D49010 Files: include/clang/Index/IndexRecordReader.h include/clang/Index/IndexRecordWriter.h include/indexstore/IndexStoreCXX.h include/indexstore/indexstore.h lib/Index/ClangIndexRecordWriter.cpp

[PATCH] D49227: Override a bit fields layout from an external source

aleksandr.urakov updated this revision to Diff 155324. aleksandr.urakov added a comment. Thank you! Yes, I have added a test case for that. If it's OK, can you commit this for me, please? I have no commit access. https://reviews.llvm.org/D49227 Files: lib/AST/RecordLayoutBuilder.cpp

<    1   2