[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

avt77 updated this revision to Diff 158221. avt77 added a comment. Herald added a subscriber: eraman. Accordingly to efriedma suggestion I removed start/stopFrontendTimer where it's possible and inserted FrontendTimeRAII in several new places. As result the patch becomes bigger and bigger. And a

[PATCH] D47267: [UnrollAndJam] Add unroll_and_jam pragma handling

dmgreen updated this revision to Diff 158219. dmgreen added a comment. Rebase. Michael, you happy with this part? The pragma clang loop part is off in https://reviews.llvm.org/D47320. Let me know if/when I should do something with that. https://reviews.llvm.org/D47267 Files: include/clang/

[PATCH] D49918: [clang-tidy] Sequence declaration in while statement before the condition

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG modulo outstanding comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49918 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan added a comment. I already mentioned in the review inherited by this one that this way covers also loaded plugins with different consumers. So let's assume that driver loads clang-tidy and some other plugins and runs over each file in the project. It makes sense not to include clang-tidy d

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

This revision was automatically updated to reflect the committed changes. Closed by commit rL338361: [clangd] Report diagnostics even if WantDiags::No AST was reused (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[clang-tools-extra] r338361 - [clangd] Report diagnostics even if WantDiags::No AST was reused

Author: ibiryukov Date: Tue Jul 31 04:47:52 2018 New Revision: 338361 URL: http://llvm.org/viewvc/llvm-project?rev=338361&view=rev Log: [clangd] Report diagnostics even if WantDiags::No AST was reused Summary: After r338256, clangd stopped reporting diagnostics if WantDiags::No request is followe

Re: r338239 - [mips64][clang] Provide the signext attribute for i32 return values

I missed to include the changes to tests affected by that commit. I've included them in r338246. Regards, Stefan From: Friedman, Eli Sent: 30 July 2018 21:22:45 To: Stefan Maksimovic; cfe-commits@lists.llvm.org Subject: Re: r338239 - [mips64][clang] Provide th

r338353 - Improve support of PDB as an external layout source

Author: aleksandr.urakov Date: Tue Jul 31 01:27:06 2018 New Revision: 338353 URL: http://llvm.org/viewvc/llvm-project?rev=338353&view=rev Log: Improve support of PDB as an external layout source Summary: This patch improves support of PDB as an external layout source in the next cases: - Multipl

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov updated this revision to Diff 158217. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Check for PrevDiagsWereReported Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50045 Files: clangd/TUScheduler.cpp unittests/clangd/TUSchedul

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:381 + DiagsWereReported = PrevDiagsWereReported; + if (DiagsWereReported) { +// Take a shortcut and don't report the diagnostics, since they s

[PATCH] D49114: [clang-tidy] Add a check for "magic numbers"

0x8000- added a comment. The state of this patch: - user interface is as agreed-upon, giving end-users the capability to filter out floats and ints as it makes sense for their code base - code is clean - documentation is up to date - default ignore lists are sensible There is one outstandin

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clangd/TUScheduler.cpp:381 + DiagsWereReported = PrevDiagsWereReported; + if (DiagsWereReported) { +// Take a shortcut and don't report the

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:379 + +if (DiagsWereReported) { // Take a shortcut and don't build the AST if neither the inputs nor the ilya-biryukov wrote: > ioer

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov updated this revision to Diff 158216. ilya-biryukov added a comment. - Moved early return into the CanReuseAST branch Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50045 Files: clangd/TUScheduler.cpp unittests/clangd/TUSchedulerTests.cpp Index: unittests/cla

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

ilya-biryukov added inline comments. Comment at: include/clang/Driver/Options.td:1745 HelpText<"remap file source paths in debug info">; +def fsuppress_non_errors_from_included_files : Flag<["-"], "fsuppress-non-errors-from-included-files">, + Group, Flags<[CC1Option]>; --

[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

Hahnfeld added a comment. I fixed `linux-header-search.cpp` by adding `-stdlib=libstdc++` in r338360 because I was seeing the same failure and that's what agreed to do in these cases. If you can verify that it fixes your problems, I think it's safe to add `-rtlib=libgcc` to the other test. Re

r338360 - Fix linux-header-search.cpp with CLANG_DEFAULT_CXX_STDLIB

Author: hahnfeld Date: Tue Jul 31 04:36:14 2018 New Revision: 338360 URL: http://llvm.org/viewvc/llvm-project?rev=338360&view=rev Log: Fix linux-header-search.cpp with CLANG_DEFAULT_CXX_STDLIB This configuration was broken after r338294 because Clang might be configured to always use libc++. Mod

[PATCH] D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain

sfantao added a comment. Hi Doru, Thanks for updating the patch. I've a few comments below. Comment at: include/clang/Driver/Compilation.h:312 + /// \param skipBundler - bool value set once by the driver. + void setSkipOffloadBundler(bool skipBundler); + gtb

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

lassi.niemisto added a comment. My project team would also highly appreciate if this got implemented. Currently working around the issue by post-formatting the clang-formatted files with uncrustify and filtering it so that it only touches lines starting with #. Repository: rL LLVM https://r

[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan updated this revision to Diff 158211. yvvan added a comment. Restore missing tests https://reviews.llvm.org/D49794 Files: include/clang-c/Index.h include/clang/Basic/Diagnostic.h include/clang/Basic/DiagnosticOptions.def include/clang/Driver/Options.td lib/Basic/DiagnosticIDs.cp

[PATCH] D50050: [AST] CastExpr: BasePathSize is not large enough.

lebedev.ri created this revision. lebedev.ri added reviewers: rjmccall, rsmith, erichkeane. https://reviews.llvm.org/rC337815 / https://reviews.llvm.org/D49508 had to cannibalize one bit of `CastExprBitfields::BasePathSize` in order to squeeze `PartOfExplicitCast` boolean. That reduced the maxim

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:379 + +if (DiagsWereReported) { // Take a shortcut and don't build the AST if neither the inputs nor the ioeric wrote: > The implicit condition here is that we can reuse AST and di

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov updated this revision to Diff 158201. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Added a comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50045 Files: clangd/TUScheduler.cpp unittests/clangd/TUSchedulerTests.cpp Ind

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ioeric added a comment. Overall LG, just a suggestion to make the code a bit easier to follow. Comment at: clangd/TUScheduler.cpp:379 + +if (DiagsWereReported) { // Take a shortcut and don't build the AST if neither the inputs nor the The implicit co

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

I actually tried to pass the correct derived scope to CodeCompletionDeclConsumer on construction, it was not a lot of code and I think this should fix the problem you're describing. I'll send a patch. On Tue, Jul 31, 2018 at 11:33 AM Eric Liu wrote: > Thanks a lot for looking into this! > > You

[PATCH] D50047: [compiler-rt] [test] Use approximate comparison on float types

erceg95 created this revision. erceg95 added reviewers: compnerd, scanon, mgorny. Herald added a subscriber: dberris. We are resubmitting this patch (https://reviews.llvm.org/D28862) as it still causes this test of fail on Ubuntu 18.04 , Ubuntu GLIBC 2.27-3ubuntu1. https://reviews.llvm.org/D500

[PATCH] D50045: [clangd] Report diagnostics even if WantDiags::No AST was reused

ilya-biryukov created this revision. ilya-biryukov added a reviewer: ioeric. Herald added subscribers: jfb, arphaman, jkorous, MaskRay, javed.absar. After r338256, clangd stopped reporting diagnostics if WantDiags::No request is followed by a WantDiags::Yes request but the AST can be reused. Rep

[PATCH] D49991: [clangd] Do not build AST if no diagnostics were requested

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

Thanks a lot for looking into this! You are right, the change in SemaAccess seemed to have done the job to fix the protected member bug in specific. I think I made the change in SemaCodeComplete before SemaAccess and didn't realized the previous one was unnecessary to fix the tests. I think the ac

[PATCH] D50043: [RISCV] RISC-V using -fuse-init-array by default

kito-cheng created this revision. kito-cheng added reviewers: asb, apazos. Herald added subscribers: cfe-commits, rkruppe, rogfer01, shiva0217, fedor.sergeev. RISC-V target using -fuse-init-array even for bare-mental target. Repository: rC Clang https://reviews.llvm.org/D50043 Files: lib/

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

ilya-biryukov added a comment. In https://reviews.llvm.org/D49833#1181651, @malaperle wrote: > Was there any objection to this patch? It would have been nice to have this > before the branching. Sorry for the delay, somehow missed this update in my inbox. In https://reviews.llvm.org/D49833#11

[PATCH] D49871: Improve support of PDB as an external layout source

This revision was automatically updated to reflect the committed changes. Closed by commit rL338353: Improve support of PDB as an external layout source (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D498

[PATCH] D49758: [clangd] allow clients to pass in compilationDatabaseChanges in the 'workspace/didChangeConfiguration' request

ilya-biryukov added a comment. Just a few nits left. Comment at: clangd/ClangdLSPServer.cpp:422 +std::move(Entry.second.workingDirectory), +llvm::sys::path::filename(File), +std::move(Entry.second.compilati

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

kito-cheng added a comment. Herald added subscribers: rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, jrtc27. ping, Alex, could you commit that? Repository: rC Clang https://reviews.llvm.org/D46822 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D49899: Force test/Driver/fuchsia.c(pp) to use lld

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

phosek added a comment. This has been breaking our bots since it has landed (both Linux and macOS ones), here's a log: https://logs.chromium.org/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8939527016533487696%2F%2B%2Fsteps%2Fclang%2F0%2Fsteps%2Fcheck-clang%2F0%2Fstdout In our Clan

<    1   2   3