Merged to 7.0 in r338674.
On Wed, Aug 1, 2018 at 7:51 PM, Hans Wennborg via cfe-commits
wrote:
> Author: hans
> Date: Wed Aug 1 10:51:23 2018
> New Revision: 338602
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338602&view=rev
> Log:
> Revert r338455 "[constexpr] Support for constant evaluati
kimgr added a comment.
Potential typo in the tests
Comment at: test/SemaCXX/attr-lifetimebound.cpp:24
+
+ // Do not diagnose non-void return types; they can still be lifetime-bound.
+ long long ptrintcast(int ¶m [[clang::lifetimebound]]) {
Should this say 'no
rjmccall added inline comments.
Comment at: lib/Sema/SemaCast.cpp:1050
+ SrcType->getAs()->getPointeeType().getAddressSpace() !=
+
DestType->getAs()->getPointeeType().getAddressSpace();
+}
yaxunl wrote:
> rjmccall wrote:
> > I know the code w
Rakete added inline comments.
Comment at: compiler-explorer-llvm-commit.sh:1
+# This is the commit of LLVM that we're currently based on.
+git reset --hard 1fa19f68007cd126a04448093c171f40e556087e
What's this file? A mistake?
Comment at: in
yaxunl added inline comments.
Comment at: lib/Sema/SemaCast.cpp:1050
+ SrcType->getAs()->getPointeeType().getAddressSpace() !=
+
DestType->getAs()->getPointeeType().getAddressSpace();
+}
rjmccall wrote:
> I know the code was like this before,
rjmccall added a comment.
My point is that IR pointer type information can't be "incorrect", because
there is no semantic meaning for pointer types in LLVM IR. That has never been
a part of the semantics of LLVM IR. Even if it were possible to change that —
and I don't think it is, not withou
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1638
+switch (E.Kind) {
+case BlockCaptureEntityKind::CXXRecord: {
+ Name += "c";
I forget whether this case has already filtered out trivial copy-constructors,
but if not, you sho
rnkovacs updated this revision to Diff 158681.
rnkovacs marked an inline comment as done.
rnkovacs added a comment.
Add helper function to be used in both callbacks.
https://reviews.llvm.org/D49361
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/inner-pointer.cpp
test/A
rnkovacs updated this revision to Diff 158680.
rnkovacs added a comment.
In https://reviews.llvm.org/D49811#1175726, @NoQ wrote:
> I guess you could write a test with `debug.AnalysisOrder` (by making its
> `checkEndFunction` callback (that you'll have to define) print different
> things dependi
NoQ added inline comments.
Comment at:
cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:431
+return ExprEngine::getObjectUnderConstruction(
+getState(), {getOriginExpr(), Index},
getCalleeStackFrame()).hasValue();
+ }
Whoops, t
Author: marshall
Date: Wed Aug 1 19:11:06 2018
New Revision: 338668
URL: http://llvm.org/viewvc/llvm-project?rev=338668&view=rev
Log:
Implement P1023: constexpr comparison operators for std::array
Modified:
libcxx/trunk/include/array
libcxx/trunk/test/std/containers/sequences/array/compa
Author: george.karpenkov
Date: Wed Aug 1 19:02:40 2018
New Revision: 338667
URL: http://llvm.org/viewvc/llvm-project?rev=338667&view=rev
Log:
[analyzer] Extend NoStoreFuncVisitor to follow fields.
rdar://39701823
Differential Revision: https://reviews.llvm.org/D49901
Modified:
cfe/trunk/li
Author: marshall
Date: Wed Aug 1 18:56:02 2018
New Revision: 338666
URL: http://llvm.org/viewvc/llvm-project?rev=338666&view=rev
Log:
Implement P0887: The identity metafunction
Added:
libcxx/trunk/test/std/utilities/meta/meta.trans/meta.trans.other/type_identity.pass.cpp
Modified:
libcx
Author: ahatanak
Date: Wed Aug 1 18:52:17 2018
New Revision: 338664
URL: http://llvm.org/viewvc/llvm-project?rev=338664&view=rev
Log:
Pass triple to RUN line to fix failing bots.
This is a follow-up to r338656.
Modified:
cfe/trunk/test/PCH/no-escaping-block-tail-calls.cpp
Modified: cfe/tru
bviyer updated this revision to Diff 158676.
bviyer added a comment.
Added FileCheck as requested by John McCall
Made comments start with "//" instead of /*
Removed expected-no-diagnostics from the test case (as requested by Erik)
Repository:
rC Clang
https://reviews.llvm.org/D49952
Files:
craig.topper created this revision.
craig.topper added reviewers: bkramer, efriedma, spatel.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.
gcc defines an intrinsic called __builtin_clrsb which counts the number of
extra sign bits on a number. This is equivalent t
hfinkel accepted this revision.
hfinkel added a comment.
Assuming that @aaron.ballman is still okay with this, I think that we should
move forward. @erichkeane, I suspect that fixing the ordering problems, which
were often arbitrary before and are still so, is a larger change that we'd want
to
akyrtzi accepted this revision.
akyrtzi added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D50160
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D48808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
NoQ added a comment.
I suspect that with https://reviews.llvm.org/rC338135 your operator
this-argument re-assignment mechanism is no longer necessary. Due to the
combination of support for materializing temporaries that i added previously
and the change in the AST that turns the operator this-a
NoQ updated this revision to Diff 158668.
NoQ added a comment.
Ok, so with https://reviews.llvm.org/rC338135 operator this-argument
constructors do indeed work exactly like temporaries. This patch is not
necessary anymore. I'd still prefer to add tests and i've added a
path-sensitive test as we
dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/Basic/BuiltinsWebAssembly.def:38
+// Atomic wait and wake.
+BUILTIN(__builtin_wasm_atomic_wait_i32, "Uii*iLLi", "n")
+BUILTIN(__builtin_wasm_a
Author: ahatanak
Date: Wed Aug 1 16:51:53 2018
New Revision: 338656
URL: http://llvm.org/viewvc/llvm-project?rev=338656&view=rev
Log:
Serialize DoesNotEscape.
I forgot to commit this in r326530.
Added:
cfe/trunk/test/PCH/no-escaping-block-tail-calls.cpp
cfe/trunk/test/PCH/no-escaping-bl
andrew.w.kaylor added a comment.
The LLVM linker also seems to have a bunch of problems with resolving pointer
types in structures. I'm looking into a couple of those now.
I am aware of the opaque pointer effort, though as you say it seems to be
stalled. I agree that there aren't a lot of thin
vsapsai marked an inline comment as done.
vsapsai added inline comments.
Comment at: clang/tools/c-index-test/core_main.cpp:210
+ void *P = (void*) (intptr_t) indextest_core_main;
+ std::string Executable = llvm::sys::fs::getMainExecutable(ProgName, P);
SmallVector ArgsWithP
vsapsai updated this revision to Diff 158658.
vsapsai added a comment.
- Address review comment: move getMainExecutable to indextest_core_main.
https://reviews.llvm.org/D50160
Files:
clang/tools/c-index-test/core_main.cpp
Index: clang/tools/c-index-test/core_main.cpp
===
(And it was fixed in r338648)
On Wed, Aug 1, 2018 at 3:24 PM David Jones wrote:
> FYI, this breaks clang:
>
> .../llvm/tools/clang/lib/AST/DeclObjC.cpp:793:7: error: static_assert
> expression is not an integral constant expression
> static_cast(ObjCMethodDeclBits.ObjCMethodFamilyBitWidth)
akyrtzi added inline comments.
Comment at: clang/tools/c-index-test/core_main.cpp:210
+ void *P = (void*) (intptr_t) indextest_core_main;
+ std::string Executable = llvm::sys::fs::getMainExecutable(ProgName, P);
SmallVector ArgsWithProgName;
Could you move t
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338648: [AST] Remove the static_assert check in
ObjCMethodDecl::ObjCMethodDecl (authored by vlad.tsyrklevich, committed by
Author: vlad.tsyrklevich
Date: Wed Aug 1 15:41:03 2018
New Revision: 338648
URL: http://llvm.org/viewvc/llvm-project?rev=338648&view=rev
Log:
[AST] Remove the static_assert check in ObjCMethodDecl::ObjCMethodDecl
Summary:
This check was introduced by r338641
but this broke some builds. For now r
tra added a comment.
We normally do not need to deviate from the host options all that often. I
would argue that keeping options identical is a reasonable default for most
options.
For some options the driver may be able to derive a sensible value based on the
host options. E.g. some options ca
bricci created this revision.
bricci added a project: clang.
Herald added a subscriber: cfe-commits.
This check was introduced by r338641
but this broke some builds. For now remove it.
Repository:
rC Clang
https://reviews.llvm.org/D50163
Files:
lib/AST/DeclObjC.cpp
Index: lib/AST/DeclObj
FYI, this breaks clang:
.../llvm/tools/clang/lib/AST/DeclObjC.cpp:793:7: error: static_assert
expression is not an integral constant expression
static_cast(ObjCMethodDeclBits.ObjCMethodFamilyBitWidth) ==
^
.../llvm/too
Author: rnk
Date: Wed Aug 1 15:10:03 2018
New Revision: 338643
URL: http://llvm.org/viewvc/llvm-project?rev=338643&view=rev
Log:
Fix -Wcovered-switch-default uncovered after r338630
Modified:
cfe/trunk/lib/AST/DeclBase.cpp
Modified: cfe/trunk/lib/AST/DeclBase.cpp
URL:
http://llvm.org/viewv
rjmccall added inline comments.
Comment at: test/CodeGenCXX/empty-struct-init-list.cpp:11
+} c;
+c d{ };
Please make this a `FileCheck` test that tests the actual compiler output.
https://reviews.llvm.org/D49952
__
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
One minor request; feel free to just do that when you commit.
Comment at: lib/Sema/SemaCast.cpp:1050
+ SrcType->getAs()->getPointeeType().getAddressSpace() !=
+
chandlerc added inline comments.
Comment at: docs/DeveloperPolicy.rst:395-408
+Commits with No Functional Change
+-
+
+It may be permissible to commit changes without prior review when the changes
+have no semantic impact on the code if the changes
vsapsai created this revision.
vsapsai added reviewers: nathawes, akyrtzi, bob.wilson.
Herald added a subscriber: dexonsmith.
Driver builds resource directory path based on provided executable path.
Instead of string "clang" use actual executable path.
rdar://problem/42699514
https://reviews.ll
DHowett-MSFT accepted this revision.
DHowett-MSFT added a comment.
This revision is now accepted and ready to land.
This looks good to me, but I don't have a strong understanding of "outlining."
Comment at: lib/CodeGen/CGBlocks.cpp:1262
+ if (IsWindows) {
+auto *Init = llv
echristo added a comment.
In https://reviews.llvm.org/D49148#1184957, @tra wrote:
> I wonder, what's the right thing to do to silence the warnings. For instance,
> we compile everything with -Werror and the warnings result in build breaks.
>
> Easy way out is to pass `-Wno-unsupported-target-opt
tra added a comment.
I wonder, what's the right thing to do to silence the warnings. For instance,
we compile everything with -Werror and the warnings result in build breaks.
Easy way out is to pass `-Wno-unsupported-target-opt`. It works, but it does
not really solve anything. It also may mas
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338641: [AST][4/4] Move the bit-fields from ObjCMethodDecl
and ObjCContainerDecl into… (authored by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
Author: erichkeane
Date: Wed Aug 1 14:31:08 2018
New Revision: 338641
URL: http://llvm.org/viewvc/llvm-project?rev=338641&view=rev
Log:
[AST][4/4] Move the bit-fields from ObjCMethodDecl and ObjCContainerDecl into
DeclContext
This patch follows https://reviews.llvm.org/D49729,
https://reviews.l
hubert.reinterpretcast added inline comments.
Comment at: docs/DeveloperPolicy.rst:395-408
+Commits with No Functional Change
+-
+
+It may be permissible to commit changes without prior review when the changes
+have no semantic impact on the code i
ahatanak added inline comments.
Comment at: test/CodeGenCXX/block-byref-cxx-objc.cpp:36
+// CHECK: call void @_Block_object_dispose(
+
+int testB() {
ahatanak wrote:
> Should the second call to @_Block_object_dispose be an invoke if the
> destructor can throw? T
ahatanak updated this revision to Diff 158640.
ahatanak marked an inline comment as done.
ahatanak added a comment.
Use llvm::sort.
Repository:
rC Clang
https://reviews.llvm.org/D50152
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGNonTrivialStruct.cpp
lib/CodeGen/CodeGenFunction.cpp
Meinersbur updated this revision to Diff 158639.
Meinersbur marked an inline comment as done.
Meinersbur added a comment.
- Remove TODOs about the attribute order
Repository:
rC Clang
https://reviews.llvm.org/D48100
Files:
include/clang/Sema/ParsedAttr.h
lib/AST/ItaniumMangle.cpp
lib/P
Meinersbur marked an inline comment as done.
Meinersbur added inline comments.
Comment at: test/Sema/attr-ownership.c:22
void f15(int, int)
- __attribute__((ownership_returns(foo, 1))) // expected-note {{declared with
index 1 here}}
- __attribute__((ownership_returns(foo, 2)
r338640
On Wed, Aug 1, 2018 at 8:38 PM, Roman Lebedev wrote:
> On Wed, Aug 1, 2018 at 8:36 PM, Richard Smith wrote:
>> On Tue, 31 Jul 2018, 23:06 Roman Lebedev via cfe-commits,
>> wrote:
>>>
>>> Author: lebedevri
>>> Date: Tue Jul 31 23:06:16 2018
>>> New Revision: 338489
>>>
>>> URL: http://ll
Author: lebedevri
Date: Wed Aug 1 14:20:58 2018
New Revision: 338640
URL: http://llvm.org/viewvc/llvm-project?rev=338640&view=rev
Log:
[NFC][CodeGenCXX] Use -emit-llvm-only instead of -emit-llvm and ignoring it.
As pointed out by Richard Smith in post-review of r338489.
Modified:
cfe/trunk/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338639: [AST][3/4] Move the bit-fields from BlockDecl,
LinkageSpecDecl and… (authored by erichkeane, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49733
Files:
include/clang/AST/Dec
Author: erichkeane
Date: Wed Aug 1 14:16:54 2018
New Revision: 338639
URL: http://llvm.org/viewvc/llvm-project?rev=338639&view=rev
Log:
[AST][3/4] Move the bit-fields from BlockDecl, LinkageSpecDecl and
OMPDeclareReductionDecl into DeclContext
This patch follows https://reviews.llvm.org/D49729
hfinkel added inline comments.
Comment at: docs/CodingStandards.rst:512
+Do not commit changes that include trailing whitespace. Some common editors
will
+automatically remove trailing whitespace when saving a file which causes
This statement is confusing (mos
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338636: [AST][2/4] Move the bit-fields from FunctionDecl and
CXXConstructorDecl into… (authored by erichkeane, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49732
Files:
include/cla
Author: erichkeane
Date: Wed Aug 1 14:02:40 2018
New Revision: 338636
URL: http://llvm.org/viewvc/llvm-project?rev=338636&view=rev
Log:
[AST][2/4] Move the bit-fields from FunctionDecl and CXXConstructorDecl into
DeclContext
This patch follows https://reviews.llvm.org/D49729
and is followed by
simark updated this revision to Diff 158625.
simark added a comment.
Add -Wno-nonportable-include-path to test/PCH/case-insensitive-include.c
Repository:
rC Clang
https://reviews.llvm.org/D48903
Files:
lib/Basic/FileManager.cpp
lib/Basic/VirtualFileSystem.cpp
test/PCH/case-insensitive-
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338630: [AST][1/4] Move the bit-fields from TagDecl,
EnumDecl and RecordDecl into… (authored by erichkeane, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49729?vs=158498&id=158624#t
Author: erichkeane
Date: Wed Aug 1 13:48:16 2018
New Revision: 338630
URL: http://llvm.org/viewvc/llvm-project?rev=338630&view=rev
Log:
[AST][1/4] Move the bit-fields from TagDecl, EnumDecl and RecordDecl into
DeclContext
DeclContext has a little less than 8 bytes free due to the alignment
requ
aaron.ballman added inline comments.
Comment at: docs/DeveloperPolicy.rst:395-408
+Commits with No Functional Change
+-
+
+It may be permissible to commit changes without prior review when the changes
+have no semantic impact on the code if the cha
Author: mgorny
Date: Wed Aug 1 13:38:22 2018
New Revision: 338627
URL: http://llvm.org/viewvc/llvm-project?rev=338627&view=rev
Log:
[test] Fix %hmaptool path for standalone builds
Fix %hmaptool path to refer to clang_tools_dir instead of
llvm_tools_dir, in order to fix standalone builds. The to
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338627: [test] Fix %hmaptool path for standalone builds
(authored by mgorny, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50156
Files:
test/lit.cfg.py
Index: test/lit.cfg.py
scott.linder updated this revision to Diff 158618.
scott.linder added a comment.
Update test
https://reviews.llvm.org/D50104
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/cl20-device-side-enqueue.cl
test/CodeGenOpenCL/enqueue-kernel-non-entry-block.cl
Index: test/CodeGenOpenCL/enqu
Quuxplusone updated this revision to Diff 158615.
Quuxplusone added a comment.
clang-format.
Repository:
rC Clang
https://reviews.llvm.org/D50119
Files:
compiler-explorer-llvm-commit.sh
docs/LanguageExtensions.rst
include/clang/AST/DeclCXX.h
include/clang/Basic/Attr.td
include/clan
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg, thanks
Repository:
rC Clang
https://reviews.llvm.org/D50156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
erichkeane added inline comments.
Comment at: test/Sema/attr-ownership.c:22
void f15(int, int)
- __attribute__((ownership_returns(foo, 1))) // expected-note {{declared with
index 1 here}}
- __attribute__((ownership_returns(foo, 2))); // expected-error
{{'ownership_returns'
Quuxplusone added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2942
+ "not %select{move-constructible|destructible}2"
+ >;
+
> Might be useful to add a note explaining why the type isn't trivially
> relocatable instead of the general
Quuxplusone updated this revision to Diff 158613.
Quuxplusone added a comment.
Address feedback from @Rakete. Fix wrong ordering of 'class|struct|...' in
the diagnostic. Add `union` test cases. Correctly drop the attribute whenever
it is diagnosed as inapplicable.
Repository:
rC Clang
h
mgorny created this revision.
mgorny added reviewers: bkramer, bruno.
Fix %hmaptool path to refer to clang_tools_dir instead of
llvm_tools_dir, in order to fix standalone builds. The tool is built
as part of clang, so it won't be found in installed LLVM tools.
Repository:
rC Clang
https://re
Meinersbur added a comment.
I am unsure how to proceed. Commit since already accepted? Wait for
reconfirmation? Open new differential?
Repository:
rC Clang
https://reviews.llvm.org/D48100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
Meinersbur reopened this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: jrtc27.
Reopen after revert (and to be able to update the diff)
Repository:
rC Clang
https://reviews.llvm.org/D48100
__
Meinersbur updated this revision to Diff 158610.
Meinersbur added a comment.
Rebase after de-listifying in r336945
Repository:
rC Clang
https://reviews.llvm.org/D48100
Files:
include/clang/Sema/ParsedAttr.h
lib/AST/ItaniumMangle.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseObjc.cpp
rjmccall added a comment.
LLVM is sometimes confused by bitcasts of function pointers, but that's just a
weird exception to the basic rule that pointer element types aren't supposed to
actually matter in LLVM IR. There's a (stalled, unfortunately) effort to
remove pointer element types from IR
On 1 August 2018 at 11:21, Simon Marchi wrote:
> On 2018-08-01 01:30 PM, Alex L wrote:
> > Is there a particular reason why this commit didn't have a corresponding
> test included?
> > Cheers,
> > Alex
>
> Back when we made the corresponding change in "onChangeConfiguration",
> there was no
> str
bobsayshilol added a comment.
Thanks! I don't have write access to svn so I can't commit the patch myself,
but assuming that I've read the docs correctly if anyone is able to take it I'd
be grateful.
Repository:
rCXX libc++
https://reviews.llvm.org/D50101
arphaman created this revision.
arphaman added reviewers: ilya-biryukov, ioeric, hokein, jkorous.
Herald added subscribers: dexonsmith, MaskRay.
This patch adds support for diagnostic message capitalization to Clangd. This
is enabled when '-capitialize-diagnostic-text' is provided to Clangd.
R
eric_niebler added a comment.
> It seems to me like the warning is valid, even though we use precompiled
> headers.
Agreed.
Repository:
rC Clang
https://reviews.llvm.org/D48903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
mgrang added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1593
+ // Sort the captures by offset.
+ std::sort(ManagedCaptures.begin(), ManagedCaptures.end());
}
Please use llvm::sort instead of std::sort. See
https://llvm.org/docs/CodingStandards.html
ahatanak added inline comments.
Comment at: test/CodeGenCXX/block-byref-cxx-objc.cpp:36
+// CHECK: call void @_Block_object_dispose(
+
+int testB() {
Should the second call to @_Block_object_dispose be an invoke if the destructor
can throw? The FIXME in CodeGenF
ahatanak created this revision.
ahatanak added reviewers: rjmccall, arphaman.
Herald added subscribers: dexonsmith, mgrang.
Currently, clang generates different copy or dispose helper functions for each
block literal on the stack if the block has the possibility of being copied to
the heap. This
george.karpenkov added a comment.
@Szelethus Hi, do you plan to finish this patch soon-ish? I would like to
evaluate it on a few codebases, but the pointer chasing is currently way too
fragile / generates too many FPs.
Repository:
rC Clang
https://reviews.llvm.org/D49438
andrew.w.kaylor added a comment.
I've talked to Olga about this, and I think we have a way to handle the problem
she was working on without this change.
However, I think this change is worth considering anyway. The test case shows
an example where clang is clearly not producing the output it i
Thanks for the review. I’ll update when I’m back from vacation
Arnaud
> On Jul 30, 2018, at 6:09 AM, Jacek Olesiak via Phabricator
> wrote:
>
> jolesiak added a comment.
>
> In https://reviews.llvm.org/D49580#1179924, @djasper wrote:
>
>> Ok, so IIUC, understanding that @end effective ends a
On 2018-08-01 01:30 PM, Alex L wrote:
> Is there a particular reason why this commit didn't have a corresponding test
> included?
> Cheers,
> Alex
Back when we made the corresponding change in "onChangeConfiguration", there
was no
straightforward way to make a lit test for it:
https://reviews.ll
On 2018-08-01 01:30 PM, Alex L wrote:
> Is there a particular reason why this commit didn't have a corresponding test
> included?
> Cheers,
> Alex
Back when we made the corresponding change in "onChangeConfiguration", there
was no
straightforward way to make a lit test for it:
https://reviews.l
acoomans added a comment.
Doesn’t clang-format support project-based //.clang-format// or
//_clang-format//? How do they play with this diff?
Repository:
rC Clang
https://reviews.llvm.org/D50147
___
cfe-commits mailing list
cfe-commits@lists.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338603: [Android] Increase default new alignment for Android
(authored by pirama, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50112?vs=158402&id=158574#toc
Repository:
rC Clang
Author: pirama
Date: Wed Aug 1 10:55:34 2018
New Revision: 338603
URL: http://llvm.org/viewvc/llvm-project?rev=338603&view=rev
Log:
[Android] Increase default new alignment for Android
Summary:
Android's memory allocators also guarantee 8-byte alignment for 32-bit
architectures and 16-byte align
simark added a subscriber: eric_niebler.
simark added a comment.
@eric_niebler, question for you:
This patch causes clang to emit a `-Wnonportable-include-path` warning where it
did not before. It affects the following test on Windows:
https://github.com/llvm-mirror/clang/blob/master/test/PCH/c
We hit this in Chromium too, see crbug.com/869824
I've reverted in r338602
On Wed, Aug 1, 2018 at 5:26 PM, Benjamin Kramer via cfe-commits
wrote:
> It's pretty easy to make this crash
>
> $ cat memcpy.c
> void foo() {
> int a[1], b;
> memcpy((char*)a, (const char*)&b, (unsigned long)4);
> }
Author: hans
Date: Wed Aug 1 10:51:23 2018
New Revision: 338602
URL: http://llvm.org/viewvc/llvm-project?rev=338602&view=rev
Log:
Revert r338455 "[constexpr] Support for constant evaluation of __builtin_memcpy
and __builtin_memmove (in non-type-punning cases)."
It caused asserts during Chromium
erichkeane accepted this revision.
erichkeane added a comment.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D49729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bricci added a comment.
@erichkeane do you have any additional comments regarding this set of patches ?
I retested them on top of trunk and did not find any problem.
Repository:
rC Clang
https://reviews.llvm.org/D49729
___
cfe-commits mailing lis
Author: arphaman
Date: Wed Aug 1 10:39:29 2018
New Revision: 338597
URL: http://llvm.org/viewvc/llvm-project?rev=338597&view=rev
Log:
[clangd] allow clients to control the compilation database by passing in
compilationDatabaseChanges in the 'workspace/didChangeConfiguration' request
This commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338597: [clangd] allow clients to control the compilation
database by passing in (authored by arphaman, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
On Wed, Aug 1, 2018 at 8:36 PM, Richard Smith wrote:
> On Tue, 31 Jul 2018, 23:06 Roman Lebedev via cfe-commits,
> wrote:
>>
>> Author: lebedevri
>> Date: Tue Jul 31 23:06:16 2018
>> New Revision: 338489
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=338489&view=rev
>> Log:
>> [AST] CastExpr:
On Tue, 31 Jul 2018, 23:06 Roman Lebedev via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> Author: lebedevri
> Date: Tue Jul 31 23:06:16 2018
> New Revision: 338489
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338489&view=rev
> Log:
> [AST] CastExpr: BasePathSize is not large enough.
>
>
Is there a particular reason why this commit didn't have a corresponding
test included?
Cheers,
Alex
On 1 August 2018 at 04:28, Simon Marchi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: simark
> Date: Wed Aug 1 04:28:49 2018
> New Revision: 338518
>
> URL: http://llvm.org/viewv
joerg added a comment.
There are two different considerations here:
(1) Create less target code
(2) Create less IR
If this code can significantly reduce the amount of IR, it can be useful in
general. That's why the existing memset logic is helpful.
Repository:
rL LLVM
https://reviews.llvm.o
svenvh added a comment.
You'll probably also need to update
`test/CodeGenOpenCL/cl20-device-side-enqueue.cl`; please verify with make/ninja
`check-clang`.
https://reviews.llvm.org/D50104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Rakete added a comment.
- There's a bug in your implementation:
struct X {
X &operator=(X &&);
};
static_assert(__is_trivially_relocatable(X)); // oops, fires!
`X` has a move constructor and a destructor, so it is trivially relocatable.
- Please run your code through clang-format.
1 - 100 of 195 matches
Mail list logo
