[PATCH] D46892: [X86] Lowering adds/addus/subs/subus intrinsics to native IR (Clang part)

2018-08-07 Thread Tomasz Krupa via Phabricator via cfe-commits
tkrupa updated this revision to Diff 159461. tkrupa added a comment. Removed signed intrinsics lowering due to the pattern being too complicated - instead some minor optimizations were introduced on LLVM side. Repository: rC Clang https://reviews.llvm.org/D46892 Files:

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

2018-08-07 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added a comment. I think the solution to a lot of diagnostic and behavior issues with address spaces is to remove predication on OpenCL. It's a bit odd to have a language feature that is enabled out of the box regardless of langoptions (address spaces) but won't actually work properly

[PATCH] D49223: [AST] Check described template at structural equivalence check.

2018-08-07 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 159458. balazske marked an inline comment as done. balazske added a comment. - Renamed methods, simplified code, comments updated. Repository: rC Clang https://reviews.llvm.org/D49223 Files: include/clang/AST/ASTStructuralEquivalence.h

Re: r338627 - [test] Fix %hmaptool path for standalone builds

2018-08-07 Thread Hans Wennborg via cfe-commits
Merged to 7.0 in r339102. On Wed, Aug 1, 2018 at 10:38 PM, Michal Gorny via cfe-commits wrote: > Author: mgorny > Date: Wed Aug 1 13:38:22 2018 > New Revision: 338627 > > URL: http://llvm.org/viewvc/llvm-project?rev=338627=rev > Log: > [test] Fix %hmaptool path for standalone builds > > Fix

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

2018-08-07 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. What do you other reviewers say? I'm not familiar with this code, but this seems reasonable to me. Repository: rCXXA libc++abi https://reviews.llvm.org/D50170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50349: Port getStartLoc -> getBeginLoc

2018-08-07 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In https://reviews.llvm.org/D50349#1190029, @rsmith wrote: > +Hans (release manager for LLVM 7) > > Hans, this patch series will affect the API of common Clang classes, > resulting in patches to Clang SVN needing some (mechanical) modifications to > be applied to the

<    1   2   3