ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:144
+size_t FileIndex::estimateMemoryUsage() const {
+ return FSymbols.estimateMemoryUsage();
+}
This can be a bit tricky. Generally, the size of a `FileIndex` is the size of
kbobyrev updated this revision to Diff 164368.
kbobyrev retitled this revision from "[clangd] NFC: Move Dex to clangd/index"
to "[clangd] NFC: Rename DexIndex to Dex".
kbobyrev edited the summary of this revision.
https://reviews.llvm.org/D51774
Files:
clang-tools-extra/clangd/CMakeLists.txt
kbobyrev updated this revision to Diff 164367.
kbobyrev added a comment.
`%s/DexIndex/Dex`
https://reviews.llvm.org/D51774
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/Dex.cpp
clang-tools-extra/clangd/index/Dex.h
clang-tools-extra/clangd/index/Iterator.c
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, sammccall, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny.
kbobyrev updated this revision to Diff 164367.
kbobyrev added a comment.
`%s/DexIndex/Dex
takuto.ikuta marked 2 inline comments as done.
takuto.ikuta added a comment.
In https://reviews.llvm.org/D51340#1222013, @hans wrote:
> Did both your builds use PCH? It'd be interesting to see the difference
> without PCH too; the effect should be even larger.
Added stats of without PCH build.
101 - 105 of 105 matches
Mail list logo