[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

2018-09-07 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:144 +size_t FileIndex::estimateMemoryUsage() const { + return FSymbols.estimateMemoryUsage(); +} This can be a bit tricky. Generally, the size of a `FileIndex` is the size of

[PATCH] D51774: [clangd] NFC: Rename DexIndex to Dex

2018-09-07 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 164368. kbobyrev retitled this revision from "[clangd] NFC: Move Dex to clangd/index" to "[clangd] NFC: Rename DexIndex to Dex". kbobyrev edited the summary of this revision. https://reviews.llvm.org/D51774 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D51774: [clangd] NFC: Move Dex to clangd/index

2018-09-07 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 164367. kbobyrev added a comment. `%s/DexIndex/Dex` https://reviews.llvm.org/D51774 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/Dex.cpp clang-tools-extra/clangd/index/Dex.h clang-tools-extra/clangd/index/Iterator.c

[PATCH] D51774: [clangd] NFC: Move Dex to clangd/index

2018-09-07 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny. kbobyrev updated this revision to Diff 164367. kbobyrev added a comment. `%s/DexIndex/Dex

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

2018-09-07 Thread Takuto Ikuta via Phabricator via cfe-commits
takuto.ikuta marked 2 inline comments as done. takuto.ikuta added a comment. In https://reviews.llvm.org/D51340#1222013, @hans wrote: > Did both your builds use PCH? It'd be interesting to see the difference > without PCH too; the effect should be even larger. Added stats of without PCH build.

<    1   2