[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

rogfer01 added a comment. Thanks for reopening this @kristina. I suggest passing `--sysroot=` to make sure we see the expected behaviour when the sysroot is actually empty. Note that this would not really test the scenario where `DEFAULT_SYSROOT` is empty **and** no `--sysroot` appears in the

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

sammccall added a comment. Why this change? (If you're changing it, `Optional` is probably clearer) https://reviews.llvm.org/D51860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

sammccall added a comment. In https://reviews.llvm.org/D51747#1228919, @ilya-biryukov wrote: > > Most of the value of adding an option is: if someone complains, we can tell > > them to go away :-) One possible corollary is: we shouldn't add the option > > until someone complains. I'm not 100% s

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan marked 7 inline comments as done. leonardchan added a comment. @rsmith So I chose to go with the type sugar route since we would prefer to have multiple attributes in one attribute list. This type just contains the underlying type and the macro identifier originally held by the `Att

[PATCH] D51866: [analyzer][UninitializedObjectChecker][WIP] New flag to ignore guarded uninitialized fields

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet, whisperity. This patch is an implementation of the ideas discussed on the mailing list

[PATCH] D51865: [clang-tidy] Added a test -export-fixes with relative paths.

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, steveire. Herald added a subscriber: xazax.hun. A test for https://reviews.llvm.org/D51864. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51865 Files: test/clang-tidy/export-relpath.cpp Index: test

[PATCH] D51807: Remove all uses of DIFlagBlockByrefStruct from Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL341842: Remove all uses of DIFlagBlockByrefStruct (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51807?vs=164475&id=1646

r341842 - Remove all uses of DIFlagBlockByrefStruct

Author: adrian Date: Mon Sep 10 09:14:28 2018 New Revision: 341842 URL: http://llvm.org/viewvc/llvm-project?rev=341842&view=rev Log: Remove all uses of DIFlagBlockByrefStruct This patch removes the last reason why DIFlagBlockByrefStruct from Clang by directly implementing the drilling into the me

[PATCH] D51864: [Tooling] Restore working dir in ClangTool.

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, steveire. And add an option to disable this behavior. The option is only used in AllTUsExecutor to avoid races when running concurrently on multiple threads. This fixes PR38869 introduced by r340937. Repository: rC Cl

Re: [PATCH] D51806: [clang-cl] Enable -march

On Mon, Sep 10, 2018 at 10:33 AM Hans Wennborg via Phabricator via cfe-commits wrote: > hans added a comment. > > In https://reviews.llvm.org/D51806#1228893, @aganea wrote: > > > @hans Just an after thought: maybe we should prevent usage of `-march=` > and `/arch:` at the same time. What do you t

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

kristina reopened this revision. kristina added a comment. This revision is now accepted and ready to land. Seems to be causing a test failure for someone (per comment in https://reviews.llvm.org/rL341655), reopened it for now. Repository: rC Clang https://reviews.llvm.org/D50246

[PATCH] D51084: Implement -Watomic-implicit-seq-cst

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/Sema/SemaChecking.cpp:10974 + if (E->IgnoreParenImpCasts()->getType()->isAtomicType()) +return; CheckImplicitConversion(S, E->IgnoreParenImp

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/Index.cpp:186 + O.map("ProximityPaths", Request.ProximityPaths); + if (OK) +Request.MaxCandidateCount = MaxCandidateCount; I think we should not set `Request.MaxCandidateCount` if

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. https://reviews.llvm.org/D51860 Files: clang-tools-extra/clangd/index/Index.cpp clang-tools-

[PATCH] D51544: [OpenCL] Split opencl-c.h header

Anastasia added a comment. In https://reviews.llvm.org/D51544#1227336, @asavonic wrote: > In https://reviews.llvm.org/D51544#1227313, @Anastasia wrote: > > > Currently the main header still contains everything, so the size of the PCH > > won't change. > > > The idea is that we don't pre-compile

[PATCH] D51832: [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. This is fine, but please update the comments (and docs?) to make it clear that we no longer enforce camelCase but allow aRBiTraRYcAsE now. Comment at: clang-tidy/o

[PATCH] D51847: Print correctly dependency paths on Windows

zturner added a subscriber: xbolva00. zturner added a comment. What prints this? How do you exercise this codepath? https://reviews.llvm.org/D51847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

ilya-biryukov added a comment. > Most of the value of adding an option is: if someone complains, we can tell > them to go away :-) One possible corollary is: we shouldn't add the option > until someone complains. I'm not 100% sure about that, though - not totally > opposed to an option here. A

Re: [PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

On Mon, 10 Sep 2018 at 16:36, Kirill Bobyrev via Phabricator wrote: > > kbobyrev added a comment. > > In https://reviews.llvm.org/D51852#1228883, @yroux wrote: > > > Hi Kirill, > > > > This commit broke ARMV8 buildbots, logs are available here: > > > > http://lab.llvm.org:8011/builders/clang-cma

[PATCH] D51488: [Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?

JDevlieghere added inline comments. Comment at: Sema/SemaExpr.cpp:5338 Context.DependentTy, VK_RValue, RParenLoc); } else { jkorous wrote: > JDevlieghere wrote: > > While you're at it you might as well remove the else branch here. > Sorry, I

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

kbobyrev added a comment. In https://reviews.llvm.org/D51852#1228883, @yroux wrote: > Hi Kirill, > > This commit broke ARMV8 buildbots, logs are available here: > > http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6493/steps/build%20stage%201/logs/stdio > > Thanks > Yvan Hi! A

[PATCH] D51806: [clang-cl] Enable -march

hans added a comment. In https://reviews.llvm.org/D51806#1228893, @aganea wrote: > @hans Just an after thought: maybe we should prevent usage of `-march=` and > `/arch:` at the same time. What do you think? I can add another patch for > that purpose. Hmm, yes, at least we should warn or do so

r341833 - Prevent cpu-specific/cpu-dispatch from giong on a lambda.

Author: erichkeane Date: Mon Sep 10 07:31:56 2018 New Revision: 341833 URL: http://llvm.org/viewvc/llvm-project?rev=341833&view=rev Log: Prevent cpu-specific/cpu-dispatch from giong on a lambda. It is non-sensical to use cpu-specific/cpu-dispatch multiversioning on a lambda, so prevent it when tr

[clang-tools-extra] r341832 - [clangd] Unbreak buildbots after r341802

Author: omtcyfz Date: Mon Sep 10 07:31:38 2018 New Revision: 341832 URL: http://llvm.org/viewvc/llvm-project?rev=341832&view=rev Log: [clangd] Unbreak buildbots after r341802 Solution: use std::move when returning result from toJSON(...). Modified: clang-tools-extra/trunk/clangd/index/Index.

[PATCH] D51039: [clangd] Add unittests for D51038

This revision was automatically updated to reflect the committed changes. Closed by commit rL341830: [clangd] Add unittests for D51038 (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51039?vs=163968&id=164668#toc

[PATCH] D51806: [clang-cl] Enable -march

aganea added a comment. @hans Just an after thought: maybe we should prevent usage of `-march=` and `/arch:` at the same time. What do you think? I can add another patch for that purpose. Repository: rC Clang https://reviews.llvm.org/D51806 ___

[clang-tools-extra] r341830 - [clangd] Add unittests for D51038

Author: kadircet Date: Mon Sep 10 07:22:42 2018 New Revision: 341830 URL: http://llvm.org/viewvc/llvm-project?rev=341830&view=rev Log: [clangd] Add unittests for D51038 Reviewers: ilya-biryukov, ioeric, hokein Reviewed By: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, cfe-commits Diff

[PATCH] D51806: [clang-cl] Enable -march

aganea added a comment. Thank you! Repository: rC Clang https://reviews.llvm.org/D51806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51806: [clang-cl] Enable -march

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D51806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

lebedev.ri added inline comments. Comment at: clang-tidy/utils/ExprMutationAnalyzer.h:38 + const Stmt *findDeclMutation(ArrayRef Matches); + const Stmt *findDeclMutation(const Decl *Dec); + lebedev.ri wrote: > lebedev.ri wrote: > > @shuaiwang, @JonasToth hi. >

Re: [PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

Hi Kirill, This commit broke ARMV8 buildbots, logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6493/steps/build%20stage%201/logs/stdio Thanks Yvan On Mon, 10 Sep 2018 at 13:52, Kirill Bobyrev via Phabricator via llvm-commits wrote: > > This revision was a

[PATCH] D51806: [clang-cl] Enable -march

aganea updated this revision to Diff 164666. aganea added a comment. Updated diff with coverage test as requested. Repository: rC Clang https://reviews.llvm.org/D51806 Files: include/clang/Driver/Options.td test/Driver/cl-options.c Index: test/Driver/cl-options.c ==

[PATCH] D51039: [clangd] Add unittests for D51038

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

sammccall added inline comments. Comment at: clangd/ClangdServer.cpp:535 // Inject the resource dir. // FIXME: Don't overwrite it if it's already there. C->CommandLine.push_back("-resource-dir=" + ResourceDir); can you add a comment that these flags work

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

sammccall added a comment. In https://reviews.llvm.org/D51747#1227921, @ioeric wrote: > In https://reviews.llvm.org/D51747#1227089, @ilya-biryukov wrote: > > > > ! In https://reviews.llvm.org/D51747#1227719, @kadircet wrote: > > > > > >> ! In https://reviews.llvm.org/D51747#1227089, @ilya-biryuk

[PATCH] D51488: [Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?

jkorous added a comment. Sorry for the delay - I was busy with other things for past two weeks. Comment at: Sema/SemaExpr.cpp:5338 Context.DependentTy, VK_RValue, RParenLoc); } else { JDevlieghere wrote: > While you're at it you might as w

[PATCH] D51806: [clang-cl] Enable -march

hans added a comment. Okay, that sounds good to me. Please also add a test for this in test/Driver/cl-options.c in the "Accept "core" clang options" section. Repository: rC Clang https://reviews.llvm.org/D51806 ___ cfe-commits mailing list cfe-

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

This revision was automatically updated to reflect the committed changes. Closed by commit rL341824: [clang] Make sure codecompletion is called for calls even when inside a token. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://review

r341824 - [clang] Make sure codecompletion is called for calls even when inside a token.

Author: kadircet Date: Mon Sep 10 06:46:28 2018 New Revision: 341824 URL: http://llvm.org/viewvc/llvm-project?rev=341824&view=rev Log: [clang] Make sure codecompletion is called for calls even when inside a token. Summary: Currently CodeCompleteCall only gets called after a comma or parantheses.

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

ilya-biryukov added a comment. > I also agree with you regarding options. A pattern I've observed (in some > infamous large codebase ;) is that warnings for deprecated symbols are > disabled in the compile command as they can introduce too much noise during > build, although it would make sense

[PATCH] D51807: Remove all uses of DIFlagBlockByrefStruct from Clang

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Adrian, LGTM! https://reviews.llvm.org/D51807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D51857: HIP: Remove reference to irif

arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added a subscriber: wdng. This is no longer separately installed. https://reviews.llvm.org/D51857 Files: lib/Driver/ToolChains/HIP.cpp test/Driver/hip-device-libs.hip Index: test/Driver/hip-device-libs.hip =

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

kadircet updated this revision to Diff 164661. kadircet marked an inline comment as done. kadircet added a comment. - One last completer Repository: rC Clang https://reviews.llvm.org/D51038 Files: include/clang/Parse/Parser.h lib/Parse/ParseDecl.cpp lib/Parse/ParseExpr.cpp lib/Parse/

[PATCH] D51806: [clang-cl] Enable -march

aganea added a comment. @hans I want to target precisely a given CPU when using `clang-cl`. The options in the `m_x86_Features_Group` are too granular. It is easier to just add `-march=skylake` on the cmd-line. Is there any other way? Repository: rC Clang https://reviews.llvm.org/D51806

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks! LGTM Comment at: lib/Parse/ParseExprCXX.cpp:1687 if (Tok.isNot(tok::r_paren)) { - if (ParseExpressionList(Exprs, CommaLocs, [&] { -

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5244 + false)) +CmdArgs.push_back("-fvisibility-inlines-hidden"); + takuto.ikuta wrote: > hans wrote: > > Huh, does this actually affect whether functions get dlle

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

kadircet updated this revision to Diff 164659. kadircet added a comment. - Inline completers. Repository: rC Clang https://reviews.llvm.org/D51038 Files: include/clang/Parse/Parser.h lib/Parse/ParseDecl.cpp lib/Parse/ParseExpr.cpp lib/Parse/ParseExprCXX.cpp lib/Parse/ParseOpenMP.cp

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

ilya-biryukov added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:2827 if (Tok.isNot(tok::r_paren)) { + ParsedType TypeRep = + Actions.ActOnTypeName(getCurScope(), DeclaratorInfo).get(); ilya-biryukov wrote: > ActOnTypeName is called

[PATCH] D51855: [constexpr] Fix ICE when memcpy() is given a pointer to an incomplete array

petpav01 created this revision. petpav01 added a reviewer: rsmith. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, kristof.beyls. Trying to compile the following example results in a clang crash: $ cat char.c void *memcpy(void *, const void *, unsigned int); ext

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

ilya-biryukov added inline comments. Comment at: lib/Sema/CodeCompleteConsumer.cpp:622 +case CodeCompletionString::CK_Optional: + break; ilya-biryukov wrote: > This change is really sneaky and unrelated to the rest of the patch. It > should definitely

[libunwind] r341818 - Creating release candidate rc3 from release_700 branch

Author: hans Date: Mon Sep 10 05:18:15 2018 New Revision: 341818 URL: http://llvm.org/viewvc/llvm-project?rev=341818&view=rev Log: Creating release candidate rc3 from release_700 branch Added: libunwind/tags/RELEASE_700/rc3/ (props changed) - copied from r341817, libunwind/branches/re

[libcxx] r341811 - Creating release candidate rc3 from release_700 branch

Author: hans Date: Mon Sep 10 05:17:20 2018 New Revision: 341811 URL: http://llvm.org/viewvc/llvm-project?rev=341811&view=rev Log: Creating release candidate rc3 from release_700 branch Added: libcxx/tags/RELEASE_700/rc3/ (props changed) - copied from r341810, libcxx/branches/release_

[libcxxabi] r341812 - Creating release candidate rc3 from release_700 branch

Author: hans Date: Mon Sep 10 05:17:27 2018 New Revision: 341812 URL: http://llvm.org/viewvc/llvm-project?rev=341812&view=rev Log: Creating release candidate rc3 from release_700 branch Added: libcxxabi/tags/RELEASE_700/rc3/ (props changed) - copied from r341811, libcxxabi/branches/re

[PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

lebedev.ri added inline comments. Comment at: clang-tidy/utils/ExprMutationAnalyzer.h:38 + const Stmt *findDeclMutation(ArrayRef Matches); + const Stmt *findDeclMutation(const Decl *Dec); + lebedev.ri wrote: > @shuaiwang, @JonasToth hi. > Is it very intentional

[PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

lebedev.ri added inline comments. Herald added a subscriber: Szelethus. Comment at: clang-tidy/utils/ExprMutationAnalyzer.h:38 + const Stmt *findDeclMutation(ArrayRef Matches); + const Stmt *findDeclMutation(const Decl *Dec); + @shuaiwang, @JonasToth hi. Is it

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

This revision was automatically updated to reflect the committed changes. Closed by commit rL341802: [clangd] Implement FuzzyFindRequest JSON (de)serialization (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51852

[clang-tools-extra] r341802 - [clangd] Implement FuzzyFindRequest JSON (de)serialization

Author: omtcyfz Date: Mon Sep 10 04:51:05 2018 New Revision: 341802 URL: http://llvm.org/viewvc/llvm-project?rev=341802&view=rev Log: [clangd] Implement FuzzyFindRequest JSON (de)serialization JSON (de)serialization of `FuzzyFindRequest` might be useful for both D51090 and D51628. Also, this allo

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

This revision was automatically updated to reflect the committed changes. Closed by commit rL341800: [clangd] Add symbol slab size to index memory consumption estimates (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[clang-tools-extra] r341800 - [clangd] Add symbol slab size to index memory consumption estimates

Author: omtcyfz Date: Mon Sep 10 04:46:07 2018 New Revision: 341800 URL: http://llvm.org/viewvc/llvm-project?rev=341800&view=rev Log: [clangd] Add symbol slab size to index memory consumption estimates Currently, `SymbolIndex::estimateMemoryUsage()` returns the "overhead" estimate, i.e. the estim

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kbobyrev marked an inline comment as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:512 llvm::function_ref) const override; + void lookup(const LookupRequest &, ioeric wrote: > nit: I'd avoid irreleva

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kbobyrev updated this revision to Diff 164653. kbobyrev marked 2 inline comments as done. https://reviews.llvm.org/D51539 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-extra/clangd/index/MemIndex.cpp clang-tools-extra/clangd/index/MemIndex.h clang-tools-extra/clangd/inde

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

JonasToth added a comment. Unicode works both with python3 and python2 (but seemed to work before too). Otherwise LG Comment at: clang-tidy/tool/run-clang-tidy.py:169 failed_files.append(name) - -if is_py2: The patch does not apply clean to master b

[PATCH] D51853: Merge two attribute diagnostics into one

asavonic created this revision. asavonic added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Merged the recently added `err_attribute_argument_negative` diagnostic with existing `err_attribute_requires_positive_integer` diagnostic: the former allows only strictly positive inte

[PATCH] D50619: [clang-tidy] Handle unresolved expressions in ExprMutationAnalyzer

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. Ups, sorry i overlooked. I applied your changes to the current version of the const check, and everything seems fine. The false negative is gone. Repository: rCTE Clang Tools Extra

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

ilya-biryukov added inline comments. Comment at: lib/Parse/ParseExpr.cpp:1663 if (Tok.isNot(tok::r_paren)) { - if (ParseExpressionList(ArgExprs, CommaLocs, [&] { -QualType PreferredType = Actions.ProduceCallSignatureHelp( -get

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

kadircet updated this revision to Diff 164649. kadircet marked 2 inline comments as done. kadircet added a comment. - Resolve discussions. Repository: rC Clang https://reviews.llvm.org/D51038 Files: include/clang/Parse/Parser.h lib/Parse/ParseDecl.cpp lib/Parse/ParseExpr.cpp lib/Pars

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

ioeric added a comment. In https://reviews.llvm.org/D51297#1228441, @kbobyrev wrote: > In https://reviews.llvm.org/D51297#1225546, @ilya-biryukov wrote: > > > I would stamp this from my side, but concerns whether we should recommend > > YCM's LSP-based completer instead are probably still there.

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

ilya-biryukov added a comment. ilya-biryukov added inline comments. Comment at: lib/Sema/CodeCompleteConsumer.cpp:622 +case CodeCompletionString::CK_Optional: + break; This change is really sneaky and unrelated to the rest of the patch. It should defi

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

kbobyrev updated this revision to Diff 164648. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Revert unrelated formatting changes, simplify the comment. https://reviews.llvm.org/D51852 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/index/Inde

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Index.h:512 llvm::function_ref) const override; + void lookup(const LookupRequest &, nit:

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kbobyrev updated this revision to Diff 164644. kbobyrev added a comment. Remove accidental formatting changes. https://reviews.llvm.org/D51539 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-extra/clangd/index/MemIndex.cpp clang-tools-extra/clangd/index/MemIndex.h clang-

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kbobyrev updated this revision to Diff 164643. kbobyrev added a comment. Sync with HEAD. https://reviews.llvm.org/D51539 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/clangd/index/Index.h clang-tools-extra/clangd/index/Mem

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

ilya-biryukov added inline comments. Comment at: include/clang/Parse/Parser.h:217 + /// Gets set to true after calling ProduceSignaturehelp, it is for a + /// workaround to make sure ProduceSignatureHelp is only called at the deepest s/ProduceSignaturehelp/P

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1384 Req.ProximityPaths.push_back(FileName); -vlog("Code complete: fuzzyFind(\"{0}\", scopes=[{1}])",

[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

kbobyrev created this revision. kbobyrev added reviewers: ilya-biryukov, ioeric, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. JSON (de)serialization of `FuzzyFindRequest` might be useful for both https://reviews.llvm.org/D

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

kadircet added a comment. In https://reviews.llvm.org/D51038#1228618, @ilya-biryukov wrote: > > Currently the problem is, there are again some tests out there that rely on > > CodeCompeleteOrdinaryName to be called even when getting overloads at an > > unknown > > parameter type > > CodeComple

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

kadircet updated this revision to Diff 164639. kadircet marked an inline comment as done. kadircet added a comment. - Change "inside parameter" checking and fix completion string printing for optional parameters. - Update tests. Repository: rC Clang https://reviews.llvm.org/D51038 Files:

[PATCH] D51674: [clangd] Fix async index loading (from r341376).

This revision was automatically updated to reflect the committed changes. Closed by commit rL341797: [clangd] Fix async index loading (from r341376). (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51674?vs=1640

[clang-tools-extra] r341797 - [clangd] Fix async index loading (from r341376).

Author: sammccall Date: Mon Sep 10 03:00:47 2018 New Revision: 341797 URL: http://llvm.org/viewvc/llvm-project?rev=341797&view=rev Log: [clangd] Fix async index loading (from r341376). Summary: This wasn't actually async (due to std::future destructor blocking). If it were, we would have clean sh

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

sammccall added a comment. A tool like this will be a useful addition! I think the big high-level questions are: - UI: a REPL seems like a good model, but we need a more user-friendly way to read commands - Testing: need a plan for either a) testing the commands or b) keeping the commands simp

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5244 + false)) +CmdArgs.push_back("-fvisibility-inlines-hidden"); + hans wrote: > Huh, does this actually affect whether functions get dllexported or not?

r341795 - [Analyzer] Commit fix for rL341790/rC341790

Author: baloghadamsoftware Date: Mon Sep 10 02:19:54 2018 New Revision: 341795 URL: http://llvm.org/viewvc/llvm-project?rev=341795&view=rev Log: [Analyzer] Commit fix for rL341790/rC341790 Test file was accidentally not added for rL341790/rC341790 and subsequant patches. Added: cfe/trunk/t

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/dexplorer/Dexplorer.cpp:39 + +// FIXME(kbobyrev): Make this an actual REPL: probably use LLVM Command Line +// library for parsing flags and arguments. kbobyrev wrote: > ilya-biryukov wrote

[PATCH] D32904: [Analyzer] Iterator Checker - Part 8: Support for assign, clear, insert, emplace and erase operations

This revision was automatically updated to reflect the committed changes. Closed by commit rL341794: [Analyzer] Iterator Checker - Part 8: Support for assign, clear, insert… (authored by baloghadamsoftware, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:

r341794 - [Analyzer] Iterator Checker - Part 8: Support for assign, clear, insert, emplace and erase operations

Author: baloghadamsoftware Date: Mon Sep 10 02:07:47 2018 New Revision: 341794 URL: http://llvm.org/viewvc/llvm-project?rev=341794&view=rev Log: [Analyzer] Iterator Checker - Part 8: Support for assign, clear, insert, emplace and erase operations This patch adds support for the following operati

[PATCH] D32902: [Analyzer] Iterator Checker - Part 7: Support for push and pop operations

This revision was automatically updated to reflect the committed changes. baloghadamsoftware marked an inline comment as done. Closed by commit rL341793: [Analyzer] Iterator Checker - Part 7: Support for push and pop operations (authored by baloghadamsoftware, committed by ). Herald added a subscr

r341793 - [Analyzer] Iterator Checker - Part 7: Support for push and pop operations

Author: baloghadamsoftware Date: Mon Sep 10 02:06:31 2018 New Revision: 341793 URL: http://llvm.org/viewvc/llvm-project?rev=341793&view=rev Log: [Analyzer] Iterator Checker - Part 7: Support for push and pop operations This patch adds support for the following operations in the iterator checkers:

[PATCH] D32860: [Analyzer] Iterator Checker - Part 6: Mismatched iterator checker for constructors and comparisons

This revision was automatically updated to reflect the committed changes. Closed by commit rC341792: [Analyzer] Iterator Checker - Part 6: Mismatched iterator checker for… (authored by baloghadamsoftware, committed by ). Changed prior to commit: https://reviews.llvm.org/D32860?vs=163736&id=1646

r341792 - [Analyzer] Iterator Checker - Part 6: Mismatched iterator checker for constructors and comparisons

Author: baloghadamsoftware Date: Mon Sep 10 02:05:31 2018 New Revision: 341792 URL: http://llvm.org/viewvc/llvm-project?rev=341792&view=rev Log: [Analyzer] Iterator Checker - Part 6: Mismatched iterator checker for constructors and comparisons Extension of the mismatched iterator checker for con

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

This revision was automatically updated to reflect the committed changes. Closed by commit rC341791: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers (authored by baloghadamsoftware, committed by ). Changed prior to commit: https://reviews.llvm.org/D32859?vs=163725&id=164632#

r341791 - [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

Author: baloghadamsoftware Date: Mon Sep 10 02:04:27 2018 New Revision: 341791 URL: http://llvm.org/viewvc/llvm-project?rev=341791&view=rev Log: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers If a container is moved by its move assignment operator, according to the standard

[PATCH] D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

This revision was automatically updated to reflect the committed changes. baloghadamsoftware marked an inline comment as done. Closed by commit rC341790: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function… (authored by baloghadamsoftware, committed by ). Changed prior

r341790 - [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

Author: baloghadamsoftware Date: Mon Sep 10 02:03:22 2018 New Revision: 341790 URL: http://llvm.org/viewvc/llvm-project?rev=341790&view=rev Log: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters New check added to the checker which checks whether iterator

[libcxx] r341789 - ReleaseNotes: update links to use https

Author: hans Date: Mon Sep 10 01:57:12 2018 New Revision: 341789 URL: http://llvm.org/viewvc/llvm-project?rev=341789&view=rev Log: ReleaseNotes: update links to use https Modified: libcxx/trunk/docs/ReleaseNotes.rst Modified: libcxx/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/ll

[clang-tools-extra] r341787 - ReleaseNotes: update links to use https

Author: hans Date: Mon Sep 10 01:52:04 2018 New Revision: 341787 URL: http://llvm.org/viewvc/llvm-project?rev=341787&view=rev Log: ReleaseNotes: update links to use https Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL: htt

r341786 - ReleaseNotes: update links to use https

Author: hans Date: Mon Sep 10 01:51:25 2018 New Revision: 341786 URL: http://llvm.org/viewvc/llvm-project?rev=341786&view=rev Log: ReleaseNotes: update links to use https Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-pro

[PATCH] D51774: [clangd] NFC: Rename DexIndex to Dex

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341784: [clangd] NFC: Rename DexIndex to Dex (authored by omtcyfz, committed by ). Herald added a subscriber: mgrang. Changed prior to commit: https://reviews.llvm.org/D51774?vs=164629&id=164630#toc

[clang-tools-extra] r341784 - [clangd] NFC: Rename DexIndex to Dex

Author: omtcyfz Date: Mon Sep 10 01:23:53 2018 New Revision: 341784 URL: http://llvm.org/viewvc/llvm-project?rev=341784&view=rev Log: [clangd] NFC: Rename DexIndex to Dex Also, cleanup some redundant includes. Reviewed By: sammccall Differential Revision: https://reviews.llvm.org/D51774 Added:

[PATCH] D51774: [clangd] NFC: Rename DexIndex to Dex

kbobyrev updated this revision to Diff 164629. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51774 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/SymbolYAML.cpp clang-tools-extra/clangd/index/dex/Dex.cpp clang-tools-extra/clangd/index/

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

ilya-biryukov added a comment. > Currently the problem is, there are again some tests out there that rely on > CodeCompeleteOrdinaryName to be called even when getting overloads at an > unknown > parameter type CodeCompleteExpression works just fine there. Unknown parameter type should not bl

<    1   2   3   >