[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

shuaiwang created this revision. shuaiwang added reviewers: JonasToth, aaron.ballman. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin, szepet, xazax.hun. Herald added a reviewer: george.karpenkov. We handle pointee mutation for native pointers & pointer-like types

[PATCH] D51910: [Modules] Add platform feature to requires clause

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Basic/Module.cpp:81 + // 2, Environment + // 3. Platform-Environment + if (Platform == Feature || Target.getTriple().getOSName() == Feature ||

[PATCH] D52218: Warn on self-initializations

rtrieu created this revision. Improve some diagnostics around self-initialization. The uninitialized checker does not warn on self-initialization, but does warn later if the variable is used. GCC also has a -Winit-self which will enable a -Wuninitialized warning for self-initialized.

[PATCH] D51910: [Modules] Add platform feature to requires clause

bruno updated this revision to Diff 165861. bruno added a comment. Update patch after review. https://reviews.llvm.org/D51910 Files: docs/Modules.rst lib/Basic/Module.cpp test/Modules/target-platform-features.m Index: test/Modules/target-platform-features.m

[PATCH] D52189: [analyzer] Fix a crash regression on casting opaque symbolic pointers from unrelated base classes to derived classes.

NoQ updated this revision to Diff 165854. NoQ added a comment. Add a defensive check that prevents more crashes if the source type is not a class at all. https://reviews.llvm.org/D52189 Files: lib/StaticAnalyzer/Core/Store.cpp test/Analysis/casts.cpp Index: test/Analysis/casts.cpp

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley, lukasza. Herald added a subscriber: cfe-commits. This imitates the code for MemberExpr. I hope it is right, for I have absolutely no understanding of ObjC++. Fixes 38896. Repository: rC Clang

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

tra added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:388 ) { + assert(D && D->getIdentifier() && !D->getName().empty() && !D->isImplicit() && + "Decl must be an explicit identifier with a name.");

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

tra marked an inline comment as done. tra added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:551-552 if (Decl->isMain() || !Decl->isUserProvided() || -Decl->isUsualDeallocationFunction() || -

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

tra updated this revision to Diff 165841. tra added a comment. - Check that D is non-null https://reviews.llvm.org/D52179 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp Index: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

zturner added a reviewer: rsmith. zturner added a comment. What about the timings of clang-cl without /MP? Repository: rC Clang https://reviews.llvm.org/D52193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM too. https://reviews.llvm.org/D30882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

vsapsai added a comment. @dexonsmith, does my change address your concerns? https://reviews.llvm.org/D30882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51910: [Modules] Add platform feature to requires clause

bruno added inline comments. Comment at: docs/Modules.rst:476-477 + +*platform-environment* + A platform-environment variant (e.g. ``linux-gnueabi``, ``windows-msvc``) is available. rsmith wrote: > What is the reason to allow these to be combined into a

[PATCH] D52141: Thread safety analysis: Run more tests with capability attributes [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rC342418: Thread safety analysis: Run more tests with capability attributes [NFC] (authored by aaronpuchert, committed by ). Changed prior to commit: https://reviews.llvm.org/D52141?vs=165662=165835#toc

r342418 - Thread safety analysis: Run more tests with capability attributes [NFC]

Author: aaronpuchert Date: Mon Sep 17 14:37:22 2018 New Revision: 342418 URL: http://llvm.org/viewvc/llvm-project?rev=342418=rev Log: Thread safety analysis: Run more tests with capability attributes [NFC] Summary: We run the tests for -Wthread-safety-{negative,verbose} with the new attributes

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea created this revision. aganea added reviewers: rnk, hans, zturner. Herald added a reviewer: JDevlieghere. Herald added a subscriber: cfe-commits. This is very preliminary change which adds support for (`clang-cl`) `/MP` (Build with multiple processes). Doc for `/MP` is here

[PATCH] D52141: Thread safety analysis: Run more tests with capability attributes [NFC]

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Makes sense to me. Thanks for the review! Repository: rC Clang https://reviews.llvm.org/D52141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r342417 - [clang-tidy] Fix tests for performance-for-range-copy

Author: shuaiwang Date: Mon Sep 17 14:28:08 2018 New Revision: 342417 URL: http://llvm.org/viewvc/llvm-project?rev=342417=rev Log: [clang-tidy] Fix tests for performance-for-range-copy Test failed as D52120 made ExprMutationAnalyzer smarter, fixed by: - Add move-ctor for `Mutable` to make it

[PATCH] D51866: [analyzer][UninitializedObjectChecker][WIP] New flag to ignore guarded uninitialized fields

Szelethus added a comment. I played around with it, and this seemed a bit cleaner. Since I would only match against the definition of the record (and the definition of its methods), the matcher would need to look like this: `stmt(hasDescendant(blahBlah(...)))`, and I'd only be able to retrieve

[PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

srhines created this revision. srhines added a reviewer: dblaikie. Herald added a subscriber: cfe-commits. As part of r342165, I rewrote the logic to check whether -fno-omit-frame-pointer was passed after a -fomit-frame-pointer argument. This CL switches that logic to use the consolidated

[PATCH] D51866: [analyzer][UninitializedObjectChecker][WIP] New flag to ignore guarded uninitialized fields

george.karpenkov added a comment. Thanks! The usual question: would it be easier to implement using AST matchers? Repository: rC Clang https://reviews.llvm.org/D51866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52183: [analyzer] ExplodedGraph printing fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rC342413: [analyzer] ExplodedGraph printing fixes (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D51886: [analyzer][UninitializedObjectChecker] Using the new const methods of ImmutableList

NoQ accepted this revision. NoQ added a comment. Hmm, how did i miss it? Repository: rC Clang https://reviews.llvm.org/D51886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r342413 - [analyzer] ExplodedGraph printing fixes

Author: george.karpenkov Date: Mon Sep 17 13:46:53 2018 New Revision: 342413 URL: http://llvm.org/viewvc/llvm-project?rev=342413=rev Log: [analyzer] ExplodedGraph printing fixes Fixes a number of issues: - Global variables are not used for communication - Trait should be defined on a graph,

[PATCH] D51866: [analyzer][UninitializedObjectChecker][WIP] New flag to ignore guarded uninitialized fields

Szelethus added a comment. @george.karpenkov @xazax.hun, is this how you imagined checking whether an access is guarded? Repository: rC Clang https://reviews.llvm.org/D51866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51886: [analyzer][UninitializedObjectChecker] Using the new const methods of ImmutableList

Szelethus added a comment. Ping :) Repository: rC Clang https://reviews.llvm.org/D51886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52189: [analyzer] Fix a crash regression on casting opaque symbolic pointers from unrelated base classes to derived classes.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, baloghadamsoftware. Commit https://reviews.llvm.org/D51191 causes a crash when a pointer to a completely

[PATCH] D52189: [analyzer] Fix a crash regression on casting opaque symbolic pointers from unrelated base classes to derived classes.

NoQ updated this revision to Diff 165821. NoQ added a comment. Add a bit more discussion into the comments. https://reviews.llvm.org/D52189 Files: lib/StaticAnalyzer/Core/Store.cpp test/Analysis/casts.cpp Index: test/Analysis/casts.cpp

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:388 ) { + assert(D->getIdentifier() && !D->getName().empty() && !D->isImplicit() && + "Decl must be an explicit identifier with a name.");

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

george.karpenkov accepted this revision. george.karpenkov added inline comments. This revision is now accepted and ready to land. Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:273 + + for (auto I : State->get()) { +SymbolRef Sym = I.first;

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

NoQ added a comment. Mm, i mean, that reason as good as well. https://reviews.llvm.org/D52133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

NoQ marked an inline comment as done. NoQ added a comment. In https://reviews.llvm.org/D52133#1237312, @george.karpenkov wrote: > @NoQ Actually I agree with @baloghadamsoftware that it makes sense to have a > separate test, as this functionality should be tested regardless of >

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

george.karpenkov added a comment. @NoQ Actually I agree with @baloghadamsoftware that it makes sense to have a separate test, as this functionality should be tested regardless of svalbuilder-rearrange-comparisons existence. https://reviews.llvm.org/D52133

[PATCH] D52120: [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342409: [analyzer] Treat std::{move,forward} as casts in ExprMutationAnalyzer. (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D52120: [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

This revision was automatically updated to reflect the committed changes. Closed by commit rC342409: [analyzer] Treat std::{move,forward} as casts in ExprMutationAnalyzer. (authored by shuaiwang, committed by ). Changed prior to commit: https://reviews.llvm.org/D52120?vs=165801=165813#toc

r342409 - [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

Author: shuaiwang Date: Mon Sep 17 13:10:56 2018 New Revision: 342409 URL: http://llvm.org/viewvc/llvm-project?rev=342409=rev Log: [analyzer] Treat std::{move,forward} as casts in ExprMutationAnalyzer. Summary: This is a follow up of D52008 and should make the analyzer being able to handle

[clang-tools-extra] r342408 - Fix build failure caused by D52157

Author: shuaiwang Date: Mon Sep 17 13:10:33 2018 New Revision: 342408 URL: http://llvm.org/viewvc/llvm-project?rev=342408=rev Log: Fix build failure caused by D52157 Modified: clang-tools-extra/trunk/unittests/clang-query/QueryEngineTest.cpp Modified:

Re: r342214 - remove 11 years old videos from the homepage. if you have a suggestion, please drop me an email

If you're going to remove these, might as well remove the html files they link to? On the other hand, might be worth keeping these around/linked to, but for posterity/archival purposes, rather than as sources of legitimately useful information for people trying to use LLVM today. On Fri, Sep 14,

Re: r342165 - Support -fno-omit-frame-pointer with -pg.

Seems like it might be problematic to have this separate implementation of checking whether frame pointers are enabled compared to the canonical one (the one actually used to enable/disable frame pointers) in the static "shouldUseFramePointer" Function? (eg: apparently on some targets

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

tra added a comment. In https://reviews.llvm.org/D52179#1237194, @JonasToth wrote: > Is the condition for this assertion checked beforehand or could this create > runtime failures? It's checked by the (only) caller of the function on line 791: if (const auto *Decl =

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

NoQ marked an inline comment as done. NoQ added a comment. > Should not it we have its own test in `expr-inspection.c`? This isn't usually necessary when we're testing all code paths anyway, but i guess it's worth it to test our sanity-check warnings. Comment at:

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

NoQ updated this revision to Diff 165810. NoQ added a comment. Address comments. Add more sanity checks and test them. https://reviews.llvm.org/D52133 Files: docs/analyzer/DebugChecks.rst lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp test/Analysis/expr-inspection.cpp

[PATCH] D52187: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52187 Files: test/clang-tidy/bugprone-unused-return-value-custom.cpp

[PATCH] D52186: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52186 Files: test/clang-tidy/bugprone-forwarding-reference-overload.cpp Index:

[PATCH] D52185: [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52185 Files: test/clang-tidy/bugprone-forward-declaration-namespace.cpp Index:

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

JonasToth added a comment. Is the condition for this assertion checked beforehand or could this create runtime failures? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52120: [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

shuaiwang updated this revision to Diff 165801. shuaiwang marked an inline comment as done. shuaiwang added a comment. Added test case with copy-ctor & assignment operator taking value as param. Repository: rC Clang https://reviews.llvm.org/D52120 Files:

[PATCH] D52157: [ASTMatchers] Let isArrow also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL342407: [ASTMatchers] Let isArrow also support UnresolvedMemberExpr… (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D52157: [ASTMatchers] Let isArrow also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr

shuaiwang updated this revision to Diff 165799. shuaiwang marked an inline comment as done. shuaiwang added a comment. Addressed review comment. Repository: rC Clang https://reviews.llvm.org/D52157 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h

r342407 - [ASTMatchers] Let isArrow also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr

Author: shuaiwang Date: Mon Sep 17 11:48:43 2018 New Revision: 342407 URL: http://llvm.org/viewvc/llvm-project?rev=342407=rev Log: [ASTMatchers] Let isArrow also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision:

Re: r342053 - [CodeGen] Align rtti and vtable data

Thanks for looking Jordan! On Mon, Sep 17, 2018, 11:16 AM Jordan Rupprecht wrote: > > Interesting, what kind of failures? > > > > If they are causing you problems, of course feel free to revert. > > > > Dave > > Turns out they are all real issues which running the test under asan > mode flags

[PATCH] D52118: [Loopinfo] Remove one latch case in getLoopID. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342406: [Loopinfo] Remove one latch-case in getLoopID. NFC. (authored by Meinersbur, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52118: [Loopinfo] Remove one latch case in getLoopID. NFC.

Meinersbur added a comment. In https://reviews.llvm.org/D52118#1235897, @jdoerfert wrote: > > save an iteration over the loop's basic blocks (which is what getLoopLatch > > does) > > I'm not sure this is true. getLoopLatch() in LoopInfoImpl.h > only traverses the children of the header in the

[PATCH] D51657: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON.

cdavis5x added a comment. Ping. Repository: rUNW libunwind https://reviews.llvm.org/D51657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51808: [CUDA] Ignore uncallable functions when we check for usual deallocators.

tra updated this revision to Diff 165794. tra added a comment. Addressed Richard's comments. Moved clang-tidy changes into separate review https://reviews.llvm.org/D52179. https://reviews.llvm.org/D51808 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Sema/Sema.h

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

tra created this revision. tra added reviewers: alexfh, rsmith. Herald added subscribers: bixia, xazax.hun, jlebar, sanjoy. findStyleKind is only called if D is an explicit identifier with a name, so the checks for operators will never return true. The explicit assert() enforces this invariant.

Re: r342053 - [CodeGen] Align rtti and vtable data

> Interesting, what kind of failures? > > If they are causing you problems, of course feel free to revert. > > Dave Turns out they are all real issues which running the test under asan mode flags as global-buffer-overflow. I'm guessing the over-alignment was hiding the bug as reads there would be

[PATCH] D52158: [clang-tidy] Remove duplicated logic in UnnecessaryValueParamCheck and use FunctionParmMutationAnalyzer instead.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342403: [clang-tidy] Remove duplicated logic in UnnecessaryValueParamCheck and use… (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[clang-tools-extra] r342403 - [clang-tidy] Remove duplicated logic in UnnecessaryValueParamCheck and use FunctionParmMutationAnalyzer instead.

Author: shuaiwang Date: Mon Sep 17 10:59:51 2018 New Revision: 342403 URL: http://llvm.org/viewvc/llvm-project?rev=342403=rev Log: [clang-tidy] Remove duplicated logic in UnnecessaryValueParamCheck and use FunctionParmMutationAnalyzer instead. Reviewers: alexfh, JonasToth, george.karpenkov

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris updated this revision to Diff 165789. ormris added a comment. - Removed unneeded comment - Renamed variable Repository: rC Clang https://reviews.llvm.org/D52058 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-template-member.cpp Index:

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

sammccall updated this revision to Diff 165787. sammccall marked an inline comment as done. sammccall added a comment. Handle completion after a backslash in MSVC-compat mode. Repository: rC Clang https://reviews.llvm.org/D52076 Files: include/clang-c/Index.h

Re: r342053 - [CodeGen] Align rtti and vtable data

Hello Interesting, what kind of failures? If they are causing you problems, of course feel free to revert. Dave From: Eric Christopher Sent: 17 September 2018 18:07:47 To: David Green Cc: cfe-commits@lists.llvm.org Subject: Re: r342053 - [CodeGen] Align rtti and vtable data Hi David, I'm

Re: r342053 - [CodeGen] Align rtti and vtable data

Hi David, I'm seeing test failures after this patch. I'm trying to get a test case reduced, but can we revert until we figure it out? Thanks! -eric On Wed, Sep 12, 2018 at 7:10 AM David Green via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dmgreen > Date: Wed Sep 12 07:09:06

[PATCH] D52178: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. This patch uses CHECK-NOTES for the tests. Its part of an effort to test *ALL* generated diagnostics in clang-tidy, as emitted notes were previously

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySotkin added inline comments. Comment at: include/clang/Basic/OpenCLExtensionTypes.def:27 + +INTEL_SGAVC_TYPE(mce_payload_t, McePayload) +INTEL_SGAVC_TYPE(ime_payload_t, ImePayload) Anastasia wrote: > AlexeySachkov wrote: > > Anastasia wrote: > > > From

[PATCH] D49549: Change 'clang-test' to 'check-clang' on the hacking webpage

JDevlieghere added a comment. Hey Arnaud, let me know if you want me to commit this for you. Repository: rC Clang https://reviews.llvm.org/D49549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51432: [AArch64] Unwinding support for return address signing

LukeCheeseman updated this revision to Diff 165775. LukeCheeseman added a comment. return an error code when trying to sign return addresses and cross unwinding https://reviews.llvm.org/D51432 Files: include/libunwind.h src/DwarfInstructions.hpp src/DwarfParser.hpp src/Registers.hpp

[PATCH] D51223: Update tests for new YAMLIO polymorphic traits

nhaehnle added a subscriber: tpr. nhaehnle added a comment. Adding @tpr as a subscriber due to the (admittedly maybe a bit indirect) MsgPack connection. Repository: rC Clang https://reviews.llvm.org/D51223 ___ cfe-commits mailing list

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

ilya-biryukov added inline comments. Comment at: lib/Lex/Lexer.cpp:2086 + StringRef PartialPath(PathStart, CompletionPoint - PathStart); + auto Slash = PartialPath.rfind('/'); + StringRef Dir = This will probably break for backslash includes. We should

[PATCH] D51432: [AArch64] Unwinding support for return address signing

LukeCheeseman added inline comments. Comment at: src/Registers.hpp:1835 + if (((regNum >= 0) && (regNum < 32)) || regNum == UNW_ARM64_RA_SIGN_STATE) return _registers.__x[regNum]; + olista01 wrote: > When regNum == UNW_ARM64_RA_SIGN_STATE, the index into

[PATCH] D52141: Thread safety analysis: Run more tests with capability attributes [NFC]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, with a minor formatting nit. Comment at: test/SemaCXX/thread-safety-annotations.h:29 +#define PT_GUARDED_VAR

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

ldionne updated this revision to Diff 165768. ldionne added a comment. Add example of how to use the attribute, per Aaron's comment. Repository: rC Clang https://reviews.llvm.org/D51789 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D52173: Python bindings TypeError in reparse method

bdcht created this revision. bdcht added a reviewer: clang. bdcht added a project: clang. Herald added a subscriber: cfe-commits. In method 'reparse' of the python bindings (cindex.py), a TypeError is raised when 'unsaved_files_array' is set from name/value arguments when using Python3. (This is

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2990 +on static and non-static member functions of class templates, static data +members of class templates and member classes of class templates. + }]; An example that

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

ldionne updated this revision to Diff 165766. ldionne added a comment. Reformat warning message and run clang-format on changed lines. Repository: rC Clang https://reviews.llvm.org/D51789 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

ldionne added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4683-4686 + "Member '%0' marked with 'exclude_from_explicit_instantiation' attribute is " + "not defined but an explicit template instantiation declaration exists. " + "Reliance on

[PATCH] D52157: [ASTMatchers] Let isArrow also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, with a request for the documentation. Comment at: include/clang/ASTMatchers/ASTMatchers.h:4698-4702 /// class Y { /// void x() { this->x(); x();

[PATCH] D51867: [Diagnostics] Add error handling to FormatDiagnostic()

jkorous added a comment. Hi Volodymyr, do you think you might take another look? Repository: rC Clang https://reviews.llvm.org/D51867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ioeric added inline comments. Comment at: include/clang/Index/IndexingAction.h:44 bool IndexImplicitInstantiation = false; + bool IndexMacrosInPreprocessor = false; }; ilya-biryukov wrote: > Maybe add a comment or change a name to indicate that this

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ioeric updated this revision to Diff 165761. ioeric marked 4 inline comments as done. ioeric added a comment. - addressed review comments. Repository: rC Clang https://reviews.llvm.org/D52098 Files: include/clang/Index/IndexingAction.h lib/Index/IndexingAction.cpp

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

sammccall added a comment. After experimenting, editor support for replacing non-identifier text before the cursor is... spotty at best. So switched to just replacing the last path component. (This makes me a bit sad because the completions now have closing quotes but not opening ones, which

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

sammccall updated this revision to Diff 165759. sammccall added a comment. Address comments. Only complete last segment for better compatibility. Repository: rC Clang https://reviews.llvm.org/D52076 Files: include/clang-c/Index.h include/clang/Lex/CodeCompletionHandler.h

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rL342393: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth updated this revision to Diff 165756. JonasToth added a comment. get up to date to master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exception-baseclass.cpp Index:

[clang-tools-extra] r342393 - [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

Author: jonastoth Date: Mon Sep 17 06:55:10 2018 New Revision: 342393 URL: http://llvm.org/viewvc/llvm-project?rev=342393=rev Log: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly Summary: PR37913 documents wrong behaviour for a templated exception factory function. The

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. @ilya-biryukov, gentle ping. I'd like to patch this for 7.0.0 in Gentoo. Do you think my patch would be good enough, or do you expect to submit something else soonish? https://reviews.llvm.org/D50171 ___ cfe-commits

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191 +void templated_thrower() { throw T{}(); } +// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 165752. JonasToth marked an inline comment as done. JonasToth added a comment. - use static functions instead anonymous namespace Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/readability/CMakeLists.txt

Re: [clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

Yes I have already make the fix commit. It was an error in the tests. https://github.com/llvm-mirror/clang-tools-extra/commit/77ed1cd838a249d6134de9a6bdbe17ef46ecf946 Now on my Mac it compile

Re: [clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

Ah, now I see your fix in r342389. Thanks! On Mon, Sep 17, 2018 at 3:15 PM Alexander Kornienko wrote: > (If there's no clear idea of how to fix this, reverting until the fix is > found is usually the best strategy.) > > On Mon, Sep 17, 2018 at 3:14 PM Alexander Kornienko > wrote: > >> It looks

Re: [clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

(If there's no clear idea of how to fix this, reverting until the fix is found is usually the best strategy.) On Mon, Sep 17, 2018 at 3:14 PM Alexander Kornienko wrote: > It looks like this commit breaks buildbots (e.g. > http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6711). >

Re: [clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

It looks like this commit breaks buildbots (e.g. http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6711). Could you take a look? On Mon, Sep 17, 2018 at 2:33 PM Idriss Riouak via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: idrissrio > Date: Mon Sep 17 05:29:29 2018

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth marked 5 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:71 + auto Diag = + diag(WholeDecl->getBeginLoc(), "make only one declaration per statement"); + kbobyrev wrote: > Maybe

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 165749. JonasToth marked an inline comment as done. JonasToth added a comment. - improve diagnostic to include number of declared variables Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files:

[clang-tools-extra] r342389 - Fix

Author: idrissrio Date: Mon Sep 17 05:58:19 2018 New Revision: 342389 URL: http://llvm.org/viewvc/llvm-project?rev=342389=rev Log: Fix Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-redundant-void-arg.cpp Modified:

[clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

Author: idrissrio Date: Mon Sep 17 05:29:29 2018 New Revision: 342388 URL: http://llvm.org/viewvc/llvm-project?rev=342388=rev Log: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void Summary: Hello, i would like to suggest a fix for one of the

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342388: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about… (authored by IdrissRio, committed by ). Changed prior to commit:

[PATCH] D52083: [clangd] Store OR iterator children in heap

ilya-biryukov added a comment. > Seems like this optimization is not worth (yet?). As soon as we get more > proximity paths (and hence more OR iterator children) that might make sense. WDYT about storing **all** the elements with the minimal doc-id outside the heap? I.e. we can pop **all**

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth marked 7 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:51 + +return TypeAndName + " = " + Initializer + ";"; + } kbobyrev wrote: > JonasToth wrote: > > kbobyrev wrote: > > > This

[PATCH] D51597: [ASTImporter] Fix import of VarDecl init

This revision was automatically updated to reflect the committed changes. Closed by commit rL342384: [ASTImporter] Fix import of VarDecl init (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51597 Files:

  1   2   >