[PATCH] D51214: [clangd] Add option to enable/disable function argument snippets.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52079: [Sema] Do not load macros from preamble when LoadExternal is false.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D52079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52233: [dexp] Allow users to dump JSON representations of fuzzy find requests

ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:131 } +if (ShowJSONRequest) + llvm::outs() << llvm::formatv("Request:\n{0}\n\n", toJSON(Request)); Any reason not to print this always?

[PATCH] D52250: [clangd] expose MergedIndex class

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52047: [clangd] Add a "benchmark" for tracking memory

ioeric added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:69 +// This is not a *real* benchmark: it shows size of built MemIndex (in bytes). +// Same for the next "benchmark". The hack might not be obvious for other

[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

kadircet added inline comments. Comment at: clangd/tool/ClangdMain.cpp:197 +static llvm::cl::opt IncludeFixIts( +"include-fixits", ilya-biryukov wrote: > sammccall wrote: > > ilya-biryukov wrote: > > > sammccall wrote: > > > > kadircet wrote: > > > > >

[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

kadircet updated this revision to Diff 166076. kadircet marked 14 inline comments as done. kadircet added a comment. - Delete include fixit option. - Rebase Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51214 Files: clangd/tool/ClangdMain.cpp Index:

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

hans added a comment. Thanks for adding the Ninja numbers. It confirms that Ninja is significantly faster than MSBuild + /MP. Since that's the case, maybe we should be poking MS about making MSBuild faster instead of adding /MP support to Clang? Or making it easier to use Ninja in VS

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

joel added a comment. I built Linux using this patch applied to trunk and it worked for me. Thanks! Repository: rC Clang https://reviews.llvm.org/D52248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51855: [constexpr] Fix ICE when memcpy() is given a pointer to an incomplete array

petpav01 updated this revision to Diff 166073. petpav01 added a comment. Thanks for having a look at this patch. Updated version addresses the review comments. https://reviews.llvm.org/D51855 Files: include/clang/Basic/DiagnosticASTKinds.td lib/AST/ExprConstant.cpp

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

JonasToth added inline comments. Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:481 + const auto AsArg = + anyOf(callExpr(hasAnyArgument(equalsNode(Exp))), +cxxConstructExpr(hasAnyArgument(equalsNode(Exp))), shuaiwang wrote: > JonasToth

<    1   2