r345470 - Reapply Pass the nopie flag to the linker when linking with -pg.

2018-10-27 Thread Brad Smith via cfe-commits
Author: brad Date: Sat Oct 27 20:30:18 2018 New Revision: 345470 URL: http://llvm.org/viewvc/llvm-project?rev=345470&view=rev Log: Reapply Pass the nopie flag to the linker when linking with -pg. Modified: cfe/trunk/lib/Driver/ToolChains/OpenBSD.cpp cfe/trunk/test/Driver/openbsd.c Modifi

[PATCH] D53704: [ASTImporter] Import overrides before importing the rest of the chain

2018-10-27 Thread Aleksei Sidorin via Phabricator via cfe-commits
a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hello Gabor, The change looks harmless so I think it can be accepted even without tests. Did you encountered the issue while analyzing some real code? Repository: rC Clang https://r

[PATCH] D53607: [AST] Only store the needed data in IfStmt.

2018-10-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC345464: [AST] Only store the needed data in IfStmt (authored by brunoricci, committed by ). Repository: rC Clang https://reviews.llvm.org/D53607 Files: include/clang/AST/Stmt.h lib/AST/ASTDumper.c

r345464 - [AST] Only store the needed data in IfStmt

2018-10-27 Thread Bruno Ricci via cfe-commits
Author: brunoricci Date: Sat Oct 27 14:12:20 2018 New Revision: 345464 URL: http://llvm.org/viewvc/llvm-project?rev=345464&view=rev Log: [AST] Only store the needed data in IfStmt Only store the needed data in IfStmt. This cuts the size of IfStmt by up to 3 pointers + 1 SourceLocation. The order

[PATCH] D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type

2018-10-27 Thread Ben via Phabricator via cfe-commits
bobsayshilol added a comment. Ping. https://reviews.llvm.org/D53263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53605: [AST] Refactor PredefinedExpr

2018-10-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL345460: [AST] Refactor PredefinedExpr (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53605?vs=171326&id=171406#toc

r345460 - [AST] Refactor PredefinedExpr

2018-10-27 Thread Bruno Ricci via cfe-commits
Author: brunoricci Date: Sat Oct 27 12:21:19 2018 New Revision: 345460 URL: http://llvm.org/viewvc/llvm-project?rev=345460&view=rev Log: [AST] Refactor PredefinedExpr Make the following changes to PredefinedExpr: 1. Move PredefinedExpr below StringLiteral so that it can use its definition. 2. Re

[clang-tools-extra] r345460 - [AST] Refactor PredefinedExpr

2018-10-27 Thread Bruno Ricci via cfe-commits
Author: brunoricci Date: Sat Oct 27 12:21:19 2018 New Revision: 345460 URL: http://llvm.org/viewvc/llvm-project?rev=345460&view=rev Log: [AST] Refactor PredefinedExpr Make the following changes to PredefinedExpr: 1. Move PredefinedExpr below StringLiteral so that it can use its definition. 2. Re

[PATCH] D53604: [AST] Widen the bit-fields of Stmt to 8 bytes

2018-10-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL345459: [AST] Widen the bit-fields of Stmt to 8 bytes. (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53604?vs=17073

r345459 - [AST] Widen the bit-fields of Stmt to 8 bytes.

2018-10-27 Thread Bruno Ricci via cfe-commits
Author: brunoricci Date: Sat Oct 27 11:43:27 2018 New Revision: 345459 URL: http://llvm.org/viewvc/llvm-project?rev=345459&view=rev Log: [AST] Widen the bit-fields of Stmt to 8 bytes. Although some classes are using the tail padding of Stmt, most of them are not. In particular the expression clas

[PATCH] D53781: [ASTMatchers] add a matcher for static locals

2018-10-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to commit on your behalf? Repository: rC Clang https://reviews.llvm.org/D53781 ___ cfe-commits mailin

r345446 - Revert r345170 [along with its llvm counterpart r345169] as it makes Halide builds timeout.

2018-10-27 Thread Alina Sbirlea via cfe-commits
Author: asbirlea Date: Fri Oct 26 21:51:09 2018 New Revision: 345446 URL: http://llvm.org/viewvc/llvm-project?rev=345446&view=rev Log: Revert r345170 [along with its llvm counterpart r345169] as it makes Halide builds timeout. Modified: cfe/trunk/lib/Driver/ToolChains/Hexagon.cpp cfe/tru

[PATCH] D53771: [clang-tidy] Avoid C arrays check

2018-10-27 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. Will be good idea to add aliases at least for existing modules. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

2018-10-27 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added inline comments. Comment at: test/Analysis/Inputs/expected-plists/cxx-for-range.cpp.plist:837 + message + Variable 'fail' is true + Double negating is not in standard English, so this behaviour is documented here. Co

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

2018-10-27 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added inline comments. Comment at: test/Analysis/MisusedMovedObject.cpp:187 A a; -if (i == 1) { // expected-note {{Taking false branch}} expected-note {{Taking false branch}} +if (i == 1) { // expected-note {{Assuming 'i' is not equal to 1}} expected-note

[PATCH] D53771: [clang-tidy] Avoid C arrays check

2018-10-27 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 171393. lebedev.ri marked 9 inline comments as done. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. - Moved into `modernize` - Detect based on `TypeLoc`, which means we now catch *everything*, including `using`-declarations. No