rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1260
llvm::ConstantInt::get(CGF.IntPtrTy, SrcSize),
false);
return CGF.Builder.CreateLoad(Tmp);
The main reason why `llvm.memcpy` is an overloaded intrinsic is so that you can
co
Author: epilk
Date: Sun Oct 28 20:24:16 2018
New Revision: 345487
URL: http://llvm.org/viewvc/llvm-project?rev=345487&view=rev
Log:
Revert "Support for groups of attributes in #pragma clang attribute"
This reverts commit r345486.
Looks like it causes some old versions of GCC to crash, I'll see i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345486: Support for groups of attributes in #pragma clang
attribute (authored by epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53621?
erik.pilkington marked an inline comment as done.
erik.pilkington added inline comments.
Comment at: clang/docs/LanguageExtensions.rst:2666
- #pragma clang attribute push(__attribute__((annotate("custom"))), apply_to =
function)
+ #pragma clang attribute push (__attribute__(
Author: epilk
Date: Sun Oct 28 19:29:21 2018
New Revision: 345486
URL: http://llvm.org/viewvc/llvm-project?rev=345486&view=rev
Log:
Support for groups of attributes in #pragma clang attribute
This commit enables pushing an empty #pragma clang attribute push, then adding
multiple attributes to it,
ZaMaZaN4iK updated this revision to Diff 171443.
https://reviews.llvm.org/D33672
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp
test/Analysis/enum-cast-out-of-range.cpp
www/ana
Szelethus added a comment.
Please reupload with full context.
(https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface)
https://reviews.llvm.org/D33672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
ZaMaZaN4iK updated this revision to Diff 171438.
ZaMaZaN4iK added a comment.
1. Changed std::transform to llvm::transform
2. Described the check in .html file
3. Fixed RUN command for the test file
https://reviews.llvm.org/D33672
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/
ZaMaZaN4iK commandeered this revision.
ZaMaZaN4iK added a reviewer: gamesh411.
ZaMaZaN4iK added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:19
+// of casting an integer value that is out of range
+//===-
Author: compnerd
Date: Sun Oct 28 11:05:20 2018
New Revision: 345479
URL: http://llvm.org/viewvc/llvm-project?rev=345479&view=rev
Log:
AST: extend MS decoration handling for extended vectors
We correctly handled extended vectors of non-floating point types.
However, we have the Intel style builti
Hi Alex,
On Fri, Oct 19, 2018 at 1:11 AM Alex Lorenz via Phabricator via
cfe-commits wrote:
>
> > Have you checked the tool //Include What You Use//? I'm curious in what way
> > the mishappenings of that tool present themselves in yours. There were some
> > challenges not overcome in a good way
Author: brunoricci
Date: Sun Oct 28 07:14:06 2018
New Revision: 345477
URL: http://llvm.org/viewvc/llvm-project?rev=345477&view=rev
Log:
[AST] Fix an use-of-uninitialized bug introduced in CaseStmt
SwitchCaseBits.CaseStmtIsGNURange needs to be initialized first.
Modified:
cfe/trunk/include/
lebedev.ri added inline comments.
Comment at: docs/clang-tidy/checks/cppcoreguidelines-avoid-c-arrays.rst:6
+cppcoreguidelines-avoid-c-arrays
+=
+
Eugene.Zelenko wrote:
> Please make same length as header.
W
lebedev.ri updated this revision to Diff 171425.
lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.
Docs fixes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53771
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCore
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/cppcoreguidelines-avoid-c-arrays.rst:6
+cppcoreguidelines-avoid-c-arrays
+=
+
Please make same length as header.
Co
lebedev.ri updated this revision to Diff 171423.
lebedev.ri added a comment.
Herald added subscribers: kbarton, nemanjai.
In https://reviews.llvm.org/D53771#1278177, @Eugene.Zelenko wrote:
> Will be good idea to add aliases at least for existing modules.
Added CPPCG, HICPP aliases.
Repository
Szelethus added a comment.
One more thing.
From what I've seen, new checkers are in an overwhelming majority (again, from
what **I've** seen) made by beginners, so I'd propose to include comments in
checkers that are at least in part understandable by a beginner. I don't mean
to make make 60%
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345472: [AST] Don't store data for GNU range case
statement if not needed (authored by brunoricci, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53609
Files:
include/clang/AST/Stmt.
Author: brunoricci
Date: Sun Oct 28 05:30:53 2018
New Revision: 345472
URL: http://llvm.org/viewvc/llvm-project?rev=345472&view=rev
Log:
[AST] Don't store data for GNU range case statement if not needed
Don't store the data for case statements of the form LHS ... RHS if not
needed. This cuts the
Rakete updated this revision to Diff 171421.
Rakete added a comment.
Rebase and friendly ping :)
Repository:
rC Clang
https://reviews.llvm.org/D36357
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseExprCXX.cpp
test/FixIt/fixit-cxx0x.cpp
test/Parser/cxx0x-lam
void marked 6 inline comments as done.
void added inline comments.
Comment at: lib/AST/StmtProfile.cpp:1001
+ VisitExpr(S);
+ VisitExpr(S->getSubExpr());
+}
rsmith wrote:
> This is unnecessary: this visitor visits the children of the node for you.
If I don't ha
void updated this revision to Diff 171417.
void marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D53475
Files:
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/StmtDataCollectors.td
include/c
22 matches
Mail list logo
