phosek created this revision.
phosek added a reviewer: jakehehrlich.
Herald added a subscriber: cfe-commits.
Even though these deps weren't needed, this makes Fuchsia driver
better match other drivers, and it may be necessary when trying to
use different C libraries on Fuchsia.
Repository:
rC
phosek added a comment.
In https://reviews.llvm.org/D54724#1303809, @dim wrote:
> I think this is the wrong direction, placing "common" code in
> `addCXXStdlibLinkDeps`, which then has all kinds of ugly ifs and switches for
> different OSes? Let different OSes handle this in their own way,
dim added a comment.
I think this is the wrong direction, placing "common" code in
`addCXXStdlibLinkDeps`, which then has all kinds of ugly ifs and switches for
different OSes? Let different OSes handle this in their own way, maybe.
Until now I have not encountered an issue where I needed to
lichray updated this revision to Diff 174722.
lichray added a comment.
Update cxx2a status.
Repository:
rCXX libc++
https://reviews.llvm.org/D51268
Files:
include/istream
lichray added a comment.
In https://reviews.llvm.org/D51268#1303217, @ldionne wrote:
> Please also update https://libcxx.llvm.org/cxx2a_status.html.
Done.
Comment at: include/istream:601
+streamsize __n = __is.width();
+if (__n <= 0)
+__n =
Author: ormris
Date: Mon Nov 19 19:30:28 2018
New Revision: 347284
URL: http://llvm.org/viewvc/llvm-project?rev=347284=rev
Log:
Ensure FileManagerTest expects "\\" as path separator on Windows platforms
Modified:
cfe/trunk/unittests/Basic/FileManagerTest.cpp
Modified:
Hello Sam,
This commit broke build test step for on couple of our builders today:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/21573
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/14095
. . .
Failing Tests (1):
Hello everyone,
Below are some buildbot numbers for the last week of 11/11/2018 -
11/17/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
Hello everyone,
Below are some buildbot numbers for the last week of 11/4/2018 - 11/10/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
rjmccall added a comment.
In https://reviews.llvm.org/D50119#1303662, @Quuxplusone wrote:
> In https://reviews.llvm.org/D50119#1303577, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D50119#1303423, @Quuxplusone wrote:
> >
> > > In the `unordered_set [[maybe_trivially_relocatable]]` patch, I
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347282: Driver: SCS is compatible with every other
sanitizer. (authored by pcc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54735?vs=174709=174714#toc
Repository:
rC Clang
Author: pcc
Date: Mon Nov 19 17:01:49 2018
New Revision: 347282
URL: http://llvm.org/viewvc/llvm-project?rev=347282=rev
Log:
Driver: SCS is compatible with every other sanitizer.
Because SCS relies on system-provided runtime support, we can use it
together with any other sanitizer simply by
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D54735
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pcc created this revision.
pcc added a reviewer: eugenis.
Herald added a subscriber: llvm-commits.
Because SCS relies on system-provided runtime support, we can use it
together with any other sanitizer simply by linking the runtime for
the other sanitizer.
Repository:
rL LLVM
Quuxplusone added a comment.
In https://reviews.llvm.org/D50119#1303577, @rjmccall wrote:
> In https://reviews.llvm.org/D50119#1303423, @Quuxplusone wrote:
>
> > In the `unordered_set [[maybe_trivially_relocatable]]` patch, I must wrap
> > the attribute in a macro
> >
On 11/17/2018 08:28 PM, Richard Smith wrote:
> Procedurally, we shouldn't be making other changes at the same time as a
> backport, but I'd sure like to see "stdlibc++" replaced with the correct
> "libstdc++" (on trunk and branch).
>
When this gets fixes in trunk, let me know I can merge it to
nickdesaulniers added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1285
case Expr::ConstantExprClass:
case Stmt::ExprWithCleanupsClass:
nickdesaulniers wrote:
> `LLVM_FALLTHROUGH;` ?
nvm, only needed when there's code THEN
nickdesaulniers added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1285
case Expr::ConstantExprClass:
case Stmt::ExprWithCleanupsClass:
`LLVM_FALLTHROUGH;` ?
Repository:
rC Clang
https://reviews.llvm.org/D54355
void added a comment.
Should be okay now. PTAL. :-)
Repository:
rC Clang
https://reviews.llvm.org/D54355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
In https://reviews.llvm.org/D50119#1303423, @Quuxplusone wrote:
> In the `unordered_set [[maybe_trivially_relocatable]]` patch, I must wrap the
> attribute in a macro `_LIBCPP_MAYBE_TRIVIALLY_RELOCATABLE_UNLESS_DEBUG`.
> Without this caveat, I would have ended up with
void updated this revision to Diff 174692.
void added a comment.
Remove ODR violation.
Repository:
rC Clang
https://reviews.llvm.org/D54355
Files:
include/clang/AST/Expr.h
lib/AST/ASTImporter.cpp
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/CodeGen/CGBuiltin.cpp
rjmccall added a comment.
Implementation LGTM.
Comment at: include/clang/Basic/AttrDocs.td:1753
+This means it is more efficient to call such functions from code that performs
+extensive floating-point and vector calculations, because fewer live SIMD
+registers need to be
ArnaudBienner added a comment.
Thanks for the review! :)
Could someone please land the patch for me? I don't have commit access.
Repository:
rC Clang
https://reviews.llvm.org/D53807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
m4tx added a comment.
After thinking about the possible use cases (and the difficulty of implementing
heuristics for them) as well as fiddling with Clang Static Analyzer it seems
that this patch can be discarded as the Analyzer already handles `delete this`
pretty well. I've posted an update
rsmith added a comment.
Looks good other than the ODR violation issue.
Comment at: include/clang/AST/Expr.h:37-39
+namespace {
+struct EvalInfo;
+}
It's not appropriate to declare internal-linkage types in headers. This will
create ODR violations, and appears
phosek created this revision.
Herald added subscribers: cfe-commits, jfb, srhines, emaste.
Existing drivers already include -lm as C++ library dependency, but
that alone is not sufficient when statically linking the C++ library.
To handle that case, we introduce a new method addCXXStdlibLinkDeps
tmroeder added a comment.
In https://reviews.llvm.org/D54657#1303320, @joerg wrote:
> I'm sorry, but it still sounds to me like you want to address badly written
> build rules by making the driver more complicated. I don't see that is a
> reasonable goal forward.
My goal is to build a
Quuxplusone added a comment.
In https://reviews.llvm.org/D50119#1302134, @Quuxplusone wrote:
> Now that `[[clang::maybe_trivially_relocatable]]` is implemented, we can see
> if it does actually simplify the libc++ patch. I will try to get to that
> tonight.
Here is `deque` implemented with
tmroeder updated this revision to Diff 174676.
tmroeder added a comment.
Change CompilationDatabase to not output entries that use -E.
These entries cannot be used by the tooling, so they can be skipped. This
removes the other code and adds tests to make sure that neither -E or -###
entries
cameron.mcinally added a comment.
In https://reviews.llvm.org/D53157#1302724, @uweigand wrote:
> A couple of comments on the previous discussion:
>
> 1. Instead of defining a new command line option, I'd prefer to use the
> existing options -frounding-math and -ftrapping-math to set the default
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347262: [Coverage] Fix PR39258: support coverage regions
that start deeper than they end (authored by vedantk, committed by ).
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347261: [Sema] Fix PR38987: keep end location of a direct
initializer list (authored by vedantk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53231?vs=169526=174667#toc
Author: vedantk
Date: Mon Nov 19 12:10:21 2018
New Revision: 347261
URL: http://llvm.org/viewvc/llvm-project?rev=347261=rev
Log:
[Sema] Fix PR38987: keep end location of a direct initializer list
If PerformConstructorInitialization of a direct initializer list constructor is
called while
Author: vedantk
Date: Mon Nov 19 12:10:22 2018
New Revision: 347262
URL: http://llvm.org/viewvc/llvm-project?rev=347262=rev
Log:
[Coverage] Fix PR39258: support coverage regions that start deeper than they end
popRegions used to assume that the start location of a region can't be
nested deeper
joerg added a comment.
I'm sorry, but it still sounds to me like you want to address badly written
build rules by making the driver more complicated. I don't see that is a
reasonable goal forward.
Repository:
rC Clang
https://reviews.llvm.org/D54657
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347258: [clang][CodeGen] Implicit Conversion Sanitizer:
discover the world of… (authored by lebedevri, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
riccibruno planned changes to this revision.
riccibruno added a comment.
In https://reviews.llvm.org/D54676#1303176, @rjmccall wrote:
> You can have more arguments than parameters because of varargs. Even putting
> that aside, no, I think we generally shouldn't go backwards on these limits.
ldionne added a comment.
Please also update https://libcxx.llvm.org/cxx2a_status.html.
Repository:
rCXX libc++
https://reviews.llvm.org/D51268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.
Comment at: include/istream:601
+streamsize __n = __is.width();
+if (__n <= 0)
+__n = numeric_limits::max() / sizeof(_CharT) - 1;
andrew.w.kaylor added a comment.
In https://reviews.llvm.org/D53157#1302724, @uweigand wrote:
> A couple of comments on the previous discussion:
>
> 1. Instead of defining a new command line option, I'd prefer to use the
> existing options -frounding-math and -ftrapping-math to set the default
lebedev.ri added a comment.
In https://reviews.llvm.org/D53949#1303154, @rjmccall wrote:
> Heh, okay.
Okay, great, thank you for the review!
Repository:
rC Clang
https://reviews.llvm.org/D53949
___
cfe-commits mailing list
rjmccall added a comment.
You can have more arguments than parameters because of varargs. Even putting
that aside, no, I think we generally shouldn't go backwards on these limits.
Anyway, packing right up to the limits imposed by `NumExprBits` probably isn't
a great idea.
Repository:
rC
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Heh, okay.
Repository:
rC Clang
https://reviews.llvm.org/D53949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: probinson
Date: Mon Nov 19 10:29:28 2018
New Revision: 347239
URL: http://llvm.org/viewvc/llvm-project?rev=347239=rev
Log:
[DebugInfo] DISubprogram flags get their own flags word. NFC.
This will hold flags specific to subprograms. In the future
we could potentially free up scarce bits in
leonardchan updated this revision to Diff 174640.
leonardchan marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D53738
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/Type.h
clang/include/clang/Basic/FixedPoint.h
leonardchan added inline comments.
Comment at: clang/test/Frontend/fixed_point_add.c:269
+ // UNSIGNED-NEXT: [[SUM:%[0-9]+]] = call i15 @llvm.uadd.sat.i15(i15
[[USA_TRUNC]], i15 [[USA_SAT_TRUNC]])
+ // UNSIGNED-NEXT: [[SUM_EXT:%[a-z0-9]+]] = zext i15 [[SUM]] to i16
+ //
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347235: [clangd] Store source file hash in IndexFile{In,Out}
(authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: kadircet
Date: Mon Nov 19 10:06:33 2018
New Revision: 347236
URL: http://llvm.org/viewvc/llvm-project?rev=347236=rev
Log:
Use digest size instead of hardcoding it.
Modified:
clang-tools-extra/trunk/clangd/index/Serialization.cpp
Modified:
Author: kadircet
Date: Mon Nov 19 10:06:29 2018
New Revision: 347235
URL: http://llvm.org/viewvc/llvm-project?rev=347235=rev
Log:
[clangd] Store source file hash in IndexFile{In,Out}
Summary:
Puts the digest of the source file that generated the index into
serialized index and stores them back
Author: kadircet
Date: Mon Nov 19 10:06:36 2018
New Revision: 347237
URL: http://llvm.org/viewvc/llvm-project?rev=347237=rev
Log:
Address comments.
Modified:
clang-tools-extra/trunk/clangd/index/Serialization.cpp
clang-tools-extra/trunk/clangd/index/Serialization.h
Modified:
kadircet updated this revision to Diff 174635.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54693
Files:
clangd/index/Background.cpp
clangd/index/Serialization.cpp
sammccall added inline comments.
Comment at: clangd/Function.h:147
+private:
+ static_assert(std::is_same::type, T>::value,
+"use a plain type: event values are always passed by const&");
ilya-biryukov wrote:
> NIT: Maybe move this static_assert
sammccall updated this revision to Diff 174633.
sammccall marked 2 inline comments as done.
sammccall added a comment.
Herald added a subscriber: mgorny.
Address comments, add test for Event machinery.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54475
Files:
erichkeane added a comment.
Submitter: Any update on the status? It seems that Richard's feedback should
be trivial enough, so I was wondering if you need this taken up?
https://reviews.llvm.org/D36527
___
cfe-commits mailing list
martong added a subscriber: a_sidorin.
martong added a comment.
> I think these changes make sense at a high level but I am not sure about the
> refactoring strategy. I am especially concerned we may end up in place where
> all the effected users of the API don't get updated and we are stuck
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/Serialization.cpp:368
+Reader Hash(Chunks.lookup("hash"));
+llvm::StringRef Digest = Hash.consume(20);
+
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG, mark as NFC
Repository:
rC Clang
https://reviews.llvm.org/D54708
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pjeeva01 created this revision.
pjeeva01 added reviewers: ABataev, kkwli0, RaviNarayanaswamy, mikerice,
Hahnfeld, hfinkel, gtbercea.
pjeeva01 added projects: OpenMP, clang.
Herald added subscribers: cfe-commits, guansong.
This patch refactor the code for parsing omp declare target directive and
martong added a comment.
> Did you ever resolve the issue of libcxx tests not running
> https://reviews.llvm.org/D53697
Oh, by the way this change is completely independent from that other patch.
Repository:
rC Clang
https://reviews.llvm.org/D53702
martong added a comment.
> Did you ever resolve the issue of libcxx tests not running
> https://reviews.llvm.org/D53697
Hi @shafik ,
Sorry for the late reaction, I was on a two weeks long vacation recently.
My priority is to make those libcxx tests pass, I did not forget. :)
Repository:
rC
On 11/17/2018 06:48 PM, Shoaib Meenai wrote:
> Could we merge this into 7.0.1? It's a trivial typo fix, and the error
> message could otherwise be confusing to users (someone brought this up in IRC
> a few hours ago).
>
Sure, I've opened a tracking bug and will make sure it gets merged:
lebedev.ri updated this revision to Diff 174624.
lebedev.ri marked 12 inline comments as done.
lebedev.ri added a comment.
Address @aaron.ballman review notes.
Repository:
rC Clang
https://reviews.llvm.org/D52695
Files:
docs/ReleaseNotes.rst
include/clang/Basic/DiagnosticGroups.td
lebedev.ri added inline comments.
Comment at: test/Parser/extra-semi-resulting-in-nullstmt.cpp:81
+ }
+}
aaron.ballman wrote:
> There are four additional tests I'd like to see: 1) a semicolon at global
> scope, 2) a semicolon after a namespace declaration
tmroeder added a comment.
In https://reviews.llvm.org/D54657#1302086, @joerg wrote:
> I don't understand the point here. Why would you want to include
> pre-processing-only commands in the compilation database?
Sorry for not being clear enough.
I don't want to include entries with -E.
hokein created this revision.
hokein added a reviewer: aaron.ballman.
Herald added a subscriber: xazax.hun.
Currently the smart_ptr check (modernize-make-unique) generates the
fixes that cannot compile for cases like below -- because brace list can
not be deduced in `make_unique`.
class Bar {
sammccall added inline comments.
Comment at: clangd/ClangdUnit.cpp:159
+
+ PP.getPPCallbacks()->InclusionDirective(
+ HashTok.getLocation(), IncludeTok, WrittenFilename, Angled,
ilya-biryukov wrote:
> This should be `Delegate->` instead of
sammccall updated this revision to Diff 174621.
sammccall marked 4 inline comments as done.
sammccall added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54694
Files:
clangd/ClangdUnit.cpp
clangd/Diagnostics.cpp
clangd/Headers.cpp
EricWF added a comment.
My two cents:
I needed something like this when trying to automatically detect if libc++
supported things like sized deallocation, so I would like to see this change go
through.
(My understanding was that libc++ added a `__libcpp_version` file for just this
reason, but
Author: zturner
Date: Mon Nov 19 07:12:34 2018
New Revision: 347216
URL: http://llvm.org/viewvc/llvm-project?rev=347216=rev
Log:
Fix some issues with LLDB's lit configuration files.
Recently I tried to port LLDB's lit configuration files over to use a
on the surface, but broke some cases that
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347216: Fix some issues with LLDBs lit configuration
files. (authored by zturner, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
Author: plyster
Date: Mon Nov 19 07:09:33 2018
New Revision: 347214
URL: http://llvm.org/viewvc/llvm-project?rev=347214=rev
Log:
[OpenMP] Check target architecture supports unified shared memory for requires
directive. Differential Review: https://reviews.llvm.org/D54493
Added:
kadircet updated this revision to Diff 174608.
kadircet marked an inline comment as done.
kadircet added a comment.
- Use digest size instead of hardcoding it.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54693
Files:
clangd/index/Background.cpp
riccibruno added a comment.
In https://reviews.llvm.org/D54676#1302510, @rjmccall wrote:
> I don't think we should be reducing the number of call arguments we can
> support, sorry, even if 16K is a fairly absurd number that would probably
> trip stack overflow protections if you actually
jkorous added a comment.
Hi Kadir, I have one small nit otherwise LGTM.
Comment at: clangd/index/Serialization.cpp:368
+Reader Hash(Chunks.lookup("hash"));
+llvm::StringRef Digest = Hash.consume(20);
+Result.Digest.emplace();
Nit: Maybe we could
aaron.ballman added a comment.
Sorry about the delayed review on this -- I had intended to provide comments
earlier, but somehow this fell off my radar.
Comment at: docs/ReleaseNotes.rst:53
+- ``-Wextra-semi-stmt`` is a new diagnostic, which is, much like
+
whisperity added a comment.
Let's register the ID...
Superseded by https://reviews.llvm.org/D54429.
https://reviews.llvm.org/D53069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
Ping. Is even the `-Wempty-init-stmt` is not interesting?
Repository:
rC Clang
https://reviews.llvm.org/D52695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
lebedev.ri added a comment.
In https://reviews.llvm.org/D53949#1296232, @rjmccall wrote:
> Seems reasonable to me.
I'm very happy that it seems reasonable.
I'm waiting for either review comments, or formal approval :)
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D53949
This revision was automatically updated to reflect the committed changes.
Closed by commit rC347205: [FileManager] getFile(open=true) after
getFile(open=false) should open the file. (authored by sammccall, committed by
).
Changed prior to commit:
Author: sammccall
Date: Mon Nov 19 05:37:46 2018
New Revision: 347205
URL: http://llvm.org/viewvc/llvm-project?rev=347205=rev
Log:
[FileManager] getFile(open=true) after getFile(open=false) should open the file.
Summary:
Old behavior is to just return the cached entry regardless of opened-ness.
aaron.ballman added inline comments.
Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:624
+ "hasAnyDeclaration",
+ "hasAnyName",
+ "hasAnyParameter",
steveire wrote:
> aaron.ballman wrote:
> > steveire wrote:
> > > sbenza wrote:
> > > > I'm not
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:129
+class ReplayPreamble : public PPCallbacks {
+ const IncludeStructure
+ PPCallbacks *Delegate;
Maybe move fields and the private function to the end of the class?
We definitely don't
Author: stulova
Date: Mon Nov 19 04:43:39 2018
New Revision: 347196
URL: http://llvm.org/viewvc/llvm-project?rev=347196=rev
Log:
Fixed uninitialized variable issue.
This commit should fix failing bots.
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
Modified: cfe/trunk/lib/Sema/SemaType.cpp
Author: michaelplatings
Date: Mon Nov 19 04:16:05 2018
New Revision: 347194
URL: http://llvm.org/viewvc/llvm-project?rev=347194=rev
Log:
Test commit - delete trailing space.
Modified:
cfe/trunk/examples/clang-interpreter/Test.cxx
Modified: cfe/trunk/examples/clang-interpreter/Test.cxx
URL:
Hi Benjamin,
Thanks for reporting the issues, I think this should fix it:
diff --git a/lib/Sema/SemaType.cpp b/lib/Sema/SemaType.cpp
index 1fe553000b..9ff631401f 100644
--- a/lib/Sema/SemaType.cpp
+++ b/lib/Sema/SemaType.cpp
@@ -7201,7 +7201,7 @@ static void
uweigand added a comment.
A couple of comments on the previous discussion:
1. Instead of defining a new command line option, I'd prefer to use the
existing options -frounding-math and -ftrapping-math to set the default
behavior of math operations w.r.t. rounding modes and exception status.
jkorous added reviewers: rjmccall, doug.gregor.
jkorous added subscribers: rjmccall, doug.gregor.
jkorous added a comment.
Adding @rjmccall and @doug.gregor who might have some insight.
Honestly, I don't know how IWYU works and my familiarity with Sema is limited
so bear with me.
From what I
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM
Repository:
rC Clang
https://reviews.llvm.org/D54691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
clang gives me this:
llvm/tools/clang/lib/Sema/SemaType.cpp:7230:11: error: variable 'ImpAddr'
is used uninitialized whenever 'if' condition is true
[-Werror,-Wsometimes-uninitialized]
if (D.getContext() == DeclaratorContext::TemplateArgContext) {
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347189: [OpenCL] Fix address space deduction in template
args. (authored by stulova, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: stulova
Date: Mon Nov 19 03:00:14 2018
New Revision: 347189
URL: http://llvm.org/viewvc/llvm-project?rev=347189=rev
Log:
[OpenCL] Fix address space deduction in template args.
Don't deduce address spaces for non-pointer-like types
in template args.
Fixes PR38603!
Differential Revision:
sammccall updated this revision to Diff 174577.
sammccall added a comment.
Address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D54691
Files:
include/clang/Basic/FileManager.h
lib/Basic/FileManager.cpp
unittests/Basic/FileManagerTest.cpp
Index:
sammccall marked 3 inline comments as done.
sammccall added a comment.
In https://reviews.llvm.org/D54691#1302622, @ilya-biryukov wrote:
> Overall LG. The only concerning bit is that the initialization of the `UFE`
> is now scattered across the function body.
> Grouping `File` and
sdesmalen added a subscriber: keith.walker.arm.
sdesmalen added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1101
case CC_AAPCS:
+ case CC_AArch64VectorCall:
return llvm::dwarf::DW_CC_LLVM_AAPCS;
rjmccall wrote:
> rnk wrote:
> > sdesmalen
sdesmalen updated this revision to Diff 174574.
sdesmalen marked an inline comment as done.
sdesmalen added a comment.
Thanks all for the suggestions and comments! I've updated the patch with a
better description of the attribute's behaviour (thanks @rjmccall for the
starting point!) and added
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
This is needed to correctly handle checks that use IncludeInserter,
which is very common.
I couldn't find a totally safe example of a
ilya-biryukov added a comment.
Overall LG. The only concerning bit is that the initialization of the `UFE` is
now scattered across the function body.
Grouping `File` and `DeferredOpen` into a struct or adding a comment that those
are initialized separately from the rest of the fields might make
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Puts the digest of the source file that generated the index into
serialized index and stores them back on load, if exists.
Repository:
steveire added inline comments.
Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:624
+ "hasAnyDeclaration",
+ "hasAnyName",
+ "hasAnyParameter",
aaron.ballman wrote:
> steveire wrote:
> > sbenza wrote:
> > > I'm not sure what goes in this list.
>
1 - 100 of 104 matches
Mail list logo
