[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, martong, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Repository: rC Clang https://reviews.llvm.org/D55049 Files: lib/AST/ExternalASTMerger.cpp

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske updated this revision to Diff 175822. balazske added a comment. Removing previous wrong update. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53757/new/ https://reviews.llvm.org/D53757 Files: lib/AST/ASTImporter.cpp Index: lib/AST/ASTImporter.cpp

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

balazske updated this revision to Diff 175821. balazske added a comment. - Changed every use of ASTImporter::Import to Import_New Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53757/new/ https://reviews.llvm.org/D53757 Files: lib/AST/ASTImporter.cpp

[PATCH] D53708: [ASTImporter] Add importer specific lookup

a_sidorin added a comment. Hi Gabor, Here are some new comments. Comment at: lib/AST/ASTImporter.cpp:7658 +ASTImporter::FoundDeclsTy +ASTImporter::FindDeclsInToCtx(DeclContext *DC, DeclarationName Name) { + // We search in the redecl context because of transparent contexts.

[PATCH] D55039: [sema] Warn of mangling change if function parameters are noexcept.

Rakete added a comment. You're missing the case of the function return type of a parameter. void f(void (*g())() noexcept); // no warning with trunk nor with your patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55039/new/ https://reviews.llvm.org/D55039

[PATCH] D55048: [ThinLTO] Allow importing of multiple symbols with same GUID

tejohnson created this revision. tejohnson added a reviewer: evgeny777. Herald added subscribers: dexonsmith, steven_wu, eraman, inglorion, mehdi_amini. The is the clang side of the fix in D55047 , to handle the case where two different modules have local

[PATCH] D55044: [cfe-dev] clang-tidy check for Abseil make_unique

lebedev.ri added a comment. Thanks for working on this. Semi-duplicate of D50852 Please see discussion there. It should not be an abseil-specific check, the prefix (`std`,`abseil`), and the function (`make_unique`) should be a config option, and it should

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

a_sidorin added a comment. Hi Adrian, I've already done check-all (this includes LLDB) with this patch. As you can see in this thread, I didn't manage to reproduce some issues on Linux. Luckily, one test still failed on Linux so I could find the problem. However , it will be good to ensure

[PATCH] D54986: Make CodeGen choose when to emit vtables.

lebedev.ri added a comment. Will `-fforce-emit-vtables` still work? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54986/new/ https://reviews.llvm.org/D54986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54872: [clangd] Add ability to not use -resource-dir at all

malaperle added a comment. Reading D54630 , I think that's what might be happening. Here's how to reproduce the problem though: - Clangd compiled from source with Visual Studio 2017 (i.e. not from win installer) - LLVM win installer from http://llvm.org/builds/

[PATCH] D55044: [cfe-dev] clang-tidy check for Abseil make_unique

axzhang created this revision. axzhang added reviewers: klimek, EricWF. axzhang added a project: clang-tools-extra. Herald added a subscriber: mgorny. Add a new check for https://abseil.io/tips/126, to detect uses of constructing a std::unique_ptr with a call to new, and recommend substituting

[PATCH] D54905: [AddressSanitizer] Add flag to disable linking with CXX runtime

evgeny777 added a comment. Unfortunately, this is not an option. I have very custom heap implementation (in fact multiple heap types sharing contiguous memory block), so ASAN heap can't be a drop-in replacement. I'm using manual poisoning and it works pretty well, but have to disable C++

[PATCH] D54379: Add Hurd toolchain support to Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC347833: Add Hurd target to Clang driver (2/2) (authored by kristina, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54379/new/

r347833 - Add Hurd target to Clang driver (2/2)

Author: kristina Date: Wed Nov 28 19:49:14 2018 New Revision: 347833 URL: http://llvm.org/viewvc/llvm-project?rev=347833=rev Log: Add Hurd target to Clang driver (2/2) This adds Hurd toolchain support to Clang's driver in addition to handling translating the triple from Hurd-compatible form to

[PATCH] D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules

modocache added subscribers: manmanren, bruno, modocache. modocache added reviewers: manmanren, bruno. modocache added a comment. Herald added a subscriber: arphaman. Friendly ping! Could someone recommend a reviewer for this? Or is there something wrong with the patch? Looking at the blame I

[PATCH] D54781: [clangd] Add 'Switch header/source' command in clangd-vscode

malaperle added a comment. In D54781#1311038 , @hokein wrote: > Just made a new release v0.0.7, please try to use it (it works on my machine). Works great! Thanks a lot! Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina accepted this revision. kristina added a comment. This revision is now accepted and ready to land. Yes everything passes now, my bad for not noticing. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54379/new/ https://reviews.llvm.org/D54379

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina accepted this revision as: kristina. kristina added a comment. Actually nevermind, I'll just create them myself, seems like a strange bug. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54379/new/ https://reviews.llvm.org/D54379

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added a comment. Hm, yes you're right, the files aren't in the diff that Phab gives me, this is annoying. I wonder if it's stripping them from the diff for some reason, can you upload the raw diff? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D54379: Add Hurd toolchain support to Clang

sthibaul added a comment. I don't have this issue with make check-all in clang/. Just to make sure: are the .keep files of the patch getting created? Otherwise the i386-gnu/ directories will not get created and then it's not surprising that clang doesn't add them to the research paths.

[clang-tools-extra] r347825 - [Documentation] Try to fix build failure in cppcoreguidelines-narrowing-conversions documentation

Author: eugenezelenko Date: Wed Nov 28 18:13:25 2018 New Revision: 347825 URL: http://llvm.org/viewvc/llvm-project?rev=347825=rev Log: [Documentation] Try to fix build failure in cppcoreguidelines-narrowing-conversions documentation Modified:

[PATCH] D55039: [sema] Warn of mangling change if function parameters are noexcept.

mattd created this revision. mattd added reviewers: erik.pilkington, rsmith. The flag: `-Wc++17-compat-mangling` was not emitting a warning diagnostic in all cases, specifically if a function has parameters that happen to have function pointers that have noexecept parameters. For example:

[PATCH] D55037: [-gmodules] Honor -fdebug-prefix-map in the debug info inside PCMs.

aprantl created this revision. aprantl added reviewers: bruno, rsmith. This patch passes -fdebug-prefix-map (a feature for renaming source paths in the debug info) through to the per-module codegen options and adds the debug prefix map to the module hash. rdar://problem/46045865

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rsmith updated this revision to Diff 175791. rsmith added a comment. - Do not emit unused discardable vtables. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54986/new/ https://reviews.llvm.org/D54986 Files: lib/AST/ASTContext.cpp

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/index.rst:304 +CLion_ 2017.2 and later `integrates clang-tidy`_ as an extension to the built-in code analyzer. +Inspections and applicable quick-fixes are performed on the fly, and checks can be configured in

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added a comment. Your tests don't pass: Testing Time: 21.51s Failing Tests (1): Clang :: Driver/hurd.c Expected Passes: 470 Expected Failures : 3 Unsupported Tests : 71 Unexpected Failures: 1 Seems to be

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

davide added a comment. In D53818#1312133 , @martong wrote: > > I reverted this change because it breaks a bunch of lldb tests (on MacOS, > > and probably on other platforms too). To be clear, part of the reason I'm > > reacting strongly here is that

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

ruiu added a comment. Yeah, I believe this patch is fine to submit, but since Peter is in a different timezone, I wanted give him a chance to review this one. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55029/new/ https://reviews.llvm.org/D55029

[PATCH] D53280: [analyzer] Emit an error for invalid -analyzer-config inputs

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:2348 + // Enable compatilibily mode to avoid analyzer-config related errors. + CmdArgs.push_back("-analyzer-config-compatibility-mode=true"); +

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

srhines added a comment. In D55029#1312167 , @ruiu wrote: > I wouldn't rush to submit this now, given that this issue is not new at all. > Maybe we can just wait for Peter's response? Sure, that's fine too. I misunderstood the "tangent" part of your

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

ruiu added a comment. I wouldn't rush to submit this now, given that this issue is not new at all. Maybe we can just wait for Peter's response? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55029/new/ https://reviews.llvm.org/D55029

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

xbolva00 updated this revision to Diff 175777. xbolva00 added a comment. - Updated. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52835/new/ https://reviews.llvm.org/D52835 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks Zhizhou! I'm curious about Peter's answer to the 64KiB default as well, but I think we should move forward with getting this patch submitted. Repository: rC Clang CHANGES SINCE

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

martong added a comment. > I reverted this change because it breaks a bunch of lldb tests (on MacOS, and > probably on other platforms too). To be clear, part of the reason I'm > reacting strongly here is that this is not the first patch this has come up > on. I'm worried about the broader

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

ruiu added a comment. +peter.smith Somewhat tangent to this patch, but is 64KiB a reasonable default for `-z max-page-size`? I believe that max-page-size is set to 64KiB so that OS/CPU whose minimum page size is 64KiB can load an executable linked with lld, but is there any real target OS/CPU

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

zhizhouy created this revision. zhizhouy added reviewers: srhines, danalbert, ruiu, chh. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. This patch passes an option '-z max-page-size=4096' to lld through clang driver. This is for Android on Aarch64 target. The lld default

[PATCH] D55021: Mark __builtin_shufflevector as using custom type checking

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55021/new/ https://reviews.llvm.org/D55021 ___ cfe-commits mailing list

[clang-tools-extra] r347815 - Ensure that test clang-tidy/export-relpath.cpp works with Windows path separators.

Author: ormris Date: Wed Nov 28 14:16:18 2018 New Revision: 347815 URL: http://llvm.org/viewvc/llvm-project?rev=347815=rev Log: Ensure that test clang-tidy/export-relpath.cpp works with Windows path separators. Modified: clang-tools-extra/trunk/test/clang-tidy/export-relpath.cpp Modified:

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar added a comment. In D55006#1312012 , @JonasToth wrote: > The issues seems to be resolved for me as well, i will post this patch to the > mailing list and ask the other guy if his build is fine, too. Thanks, Jonas! CHANGES SINCE LAST ACTION

r347812 - Allow cpu-dispatch forward declarations.

Author: erichkeane Date: Wed Nov 28 13:54:04 2018 New Revision: 347812 URL: http://llvm.org/viewvc/llvm-project?rev=347812=rev Log: Allow cpu-dispatch forward declarations. As a followup to r347805, allow forward declarations of cpu-dispatch and cpu-specific for the same reasons. Change-Id:

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.cpp:61 + + if (SimpleArg) { diag(MatchedCall->getBeginLoc(), hwright wrote: > JonasToth wrote: > > hwright wrote: > > > JonasToth wrote: > > > > The diagnostic is not

[PATCH] D53693: [ASTImporter] Typedef import brings in the complete type

martong marked an inline comment as done. martong added inline comments. Comment at: cfe/trunk/unittests/AST/ASTImporterTest.cpp:3780 + typedefNameDecl(hasName("U"))); + ASSERT_TRUE(ToD->getUnderlyingType()->isIncompleteType()); + shafik wrote: > As far as

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

JonasToth added a comment. The issues seems to be resolved for me as well, i will post this patch to the mailing list and ask the other guy if his build is fine, too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006

r347810 - Ensure sanitizer check function calls have a !dbg location

Author: adrian Date: Wed Nov 28 13:44:06 2018 New Revision: 347810 URL: http://llvm.org/viewvc/llvm-project?rev=347810=rev Log: Ensure sanitizer check function calls have a !dbg location Function calls without a !dbg location inside a function that has a DISubprogram make it impossible to

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright marked 4 inline comments as done. hwright added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.h:23 // http://clang.llvm.org/extra/clang-tidy/checks/abseil-duration-division.html class DurationDivisionCheck : public ClangTidyCheck {

[PATCH] D55023: OpenCL: Improve vector printf warnings

arsenm created this revision. arsenm added a reviewer: Anastasia. Herald added subscribers: yaxunl, wdng. The vector modifier is considered separate, so don't treat it as a conversion specifier. This is still not warning on some cases, like using a type that isn't a valid vector element.

[PATCH] D55022: OpenCL: Extend argument promotion rules to vector types

arsenm created this revision. arsenm added a reviewer: Anastasia. Herald added subscribers: yaxunl, wdng. The spec is ambiguous on whether vector types are allowed to be implicitly converted. The only legal context I think this can be used for OpenCL is printf, where it seems necessary.

[PATCH] D55021: Mark __builtin_shufflevector as using custom type checking

arsenm created this revision. arsenm added a reviewer: Anastasia. Herald added a subscriber: wdng. The custom handling seems to all be implemented already. This avoids regressions in a future patch when float vectors are ordinarily promoted to double vectors in variadic calls.

r347807 - [DebugInfo] NFC Clang test changes for: IR/Bitcode changes for DISubprogram flags.

Author: probinson Date: Wed Nov 28 13:18:07 2018 New Revision: 347807 URL: http://llvm.org/viewvc/llvm-project?rev=347807=rev Log: [DebugInfo] NFC Clang test changes for: IR/Bitcode changes for DISubprogram flags. Differential Revision: https://reviews.llvm.org/D54756 Modified:

[PATCH] D54756: [DebugInfo] NFC Clang test changes for DISubprogram flags

This revision was automatically updated to reflect the committed changes. Closed by commit rL347807: [DebugInfo] NFC Clang test changes for: IR/Bitcode changes for DISubprogram… (authored by probinson, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r347805 - Correct 'target' default behavior on redecl, allow forward declaration.

Author: erichkeane Date: Wed Nov 28 12:58:43 2018 New Revision: 347805 URL: http://llvm.org/viewvc/llvm-project?rev=347805=rev Log: Correct 'target' default behavior on redecl, allow forward declaration. Declarations without the attribute were disallowed because it would be ambiguous which

r347804 - [Coverage] Specify the Itanium ABI triple for a C++ test

Author: vedantk Date: Wed Nov 28 12:51:09 2018 New Revision: 347804 URL: http://llvm.org/viewvc/llvm-project?rev=347804=rev Log: [Coverage] Specify the Itanium ABI triple for a C++ test Modified: cfe/trunk/test/CoverageMapping/default-method.cpp Modified:

r347803 - [Coverage] Do not visit artificial stmts in defaulted methods (PR39822)

Author: vedantk Date: Wed Nov 28 12:48:07 2018 New Revision: 347803 URL: http://llvm.org/viewvc/llvm-project?rev=347803=rev Log: [Coverage] Do not visit artificial stmts in defaulted methods (PR39822) There is no reason to emit coverage mappings for artificial statements contained within

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationDivisionCheck.h:23 // http://clang.llvm.org/extra/clang-tidy/checks/abseil-duration-division.html class DurationDivisionCheck : public ClangTidyCheck { hwright wrote: > JonasToth wrote: >

[PATCH] D55016: Correctly support -shared-libgcc.

saugustine created this revision. saugustine added a reviewer: echristo. Herald added subscribers: cfe-commits, srhines. Correctly support -shared-libgcc. Repository: rC Clang https://reviews.llvm.org/D55016 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/linux-ld.c Index:

[PATCH] D54905: [AddressSanitizer] Add flag to disable linking with CXX runtime

kcc added a comment. I am reluctant to add any new flags if there is any possibility to avoid doing so. Is there any other solution for your problem? E.g. you can disable the override of new/delete when building with asan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54905/new/

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

Quuxplusone added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3064 +// If this is a qualified name, expand the template arguments in nested +// qualifiers. +DR->getQualifier()->print(OS, PrintPolicy, true); I don't understand this code

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:69 + // We know our map contains all the Scale values, so we can skip the + // nonexistence check. + auto InverseIter = InverseMap.find(Scale); JonasToth wrote: >

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright updated this revision to Diff 175735. hwright marked 13 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54737/new/ https://reviews.llvm.org/D54737 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

shafik added a comment. As pointed out in this comment in another review https://reviews.llvm.org/D44100#1311687 We need to make sure we are running the lldb test suite before committing and watching the bots to make sure the commit does not break them. The change is not purely a refactor

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

aaron.ballman added a comment. In D53751#1311037 , @martong wrote: > > I didn't actually see this comment get addressed other than to say it won't > > be a problem in practice, which I'm not certain I agree with. Was there a > > reason why this got

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

shafik added a comment. Apologies, I meant to make the comment in the child PR Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54898/new/ https://reviews.llvm.org/D54898 ___ cfe-commits mailing list

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

davide added a comment. I reverted this change because it breaks a bunch of lldb tests (on MacOS, and probably on other platforms too). To be clear, part of the reason I'm reacting strongly here is that this is not the first patch this has come up on. I'm worried about the broader trend of

r347794 - Revert "[ASTImporter] Changed use of Import to Import_New in ASTImporter."

Author: davide Date: Wed Nov 28 11:15:23 2018 New Revision: 347794 URL: http://llvm.org/viewvc/llvm-project?rev=347794=rev Log: Revert "[ASTImporter] Changed use of Import to Import_New in ASTImporter." This broke the lldb bots. Modified: cfe/trunk/include/clang/AST/ASTImporter.h

[PATCH] D54756: [DebugInfo] NFC Clang test changes for DISubprogram flags

probinson added a comment. In D54756#1311679 , @aprantl wrote: > Everybody with out-of-tree tests will be excited ;-) Yeah... fortunately we still accept the old syntax on input, so it's only people with checks on DISubprogram *output* that will need

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

davide added a comment. This doesn't break anything, and I'm fairly confident Raphael (@teemperor) ran the tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54898/new/ https://reviews.llvm.org/D54898 ___

r347793 - [OPENMP]Fix emission of the target regions in virtual functions.

Author: abataev Date: Wed Nov 28 11:00:07 2018 New Revision: 347793 URL: http://llvm.org/viewvc/llvm-project?rev=347793=rev Log: [OPENMP]Fix emission of the target regions in virtual functions. Fixed emission of the target regions found in the virtual functions. Previously we may end up with the

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

shafik added a comment. As pointed out in this comment in another review https://reviews.llvm.org/D44100#1311687 We need to make sure we are running the lldb test suite before committing and watching the bots to make sure the commit does not break them. Thank you Repository: rC Clang

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

Szelethus requested review of this revision. Szelethus added a comment. This revision is now accepted and ready to land. Changes are no longer planned for the reasons explained in my earlier comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51866/new/

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added a comment. LG from my side, only the style nits left. other reviewers are invited to take a look too :) Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:22 + +// Given the name of an inverse Duration function (e.g., `ToDoubleSeconds`), +// return its

[clang-tools-extra] r347792 - Revert "[clang-tools-extra] r347753 - [clangd] Build and test IndexBenchmark in check-clangd"

Author: ormris Date: Wed Nov 28 10:48:32 2018 New Revision: 347792 URL: http://llvm.org/viewvc/llvm-project?rev=347792=rev Log: Revert "[clang-tools-extra] r347753 - [clangd] Build and test IndexBenchmark in check-clangd" This revision was causing failures on the buildbots, and our internal CI.

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

shafik added a comment. In D53751#1311037 , @martong wrote: > > I didn't actually see this comment get addressed other than to say it won't > > be a problem in practice, which I'm not certain I agree with. Was there a > > reason why this got commit

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

aprantl added a comment. In D44100#1302478 , @a_sidorin wrote: > I don't mean only review. As I guess, you guys have MacOS machines so you can > check if the problem is still present in the updated version. FYI, typically problems with ASTImporter in

[PATCH] D52986: [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:884 + // even if we lex a tok::comma and ParanthesesDepth == 1. + const IdentifierInfo *__VA_ARGS__II = PP.getIdentifierInfo("__VA_ARGS__"); +

[PATCH] D54756: [DebugInfo] NFC Clang test changes for DISubprogram flags

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Everybody with out-of-tree tests will be excited ;-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54756/new/ https://reviews.llvm.org/D54756

r347791 - [NFC] Move MultIversioning::Type into Decl so that it can be used in

Author: erichkeane Date: Wed Nov 28 10:34:14 2018 New Revision: 347791 URL: http://llvm.org/viewvc/llvm-project?rev=347791=rev Log: [NFC] Move MultIversioning::Type into Decl so that it can be used in CodeGen Change-Id: I32b14edca3501277e0e65672eafe3eea38c6f9ae Modified:

[PATCH] D53693: [ASTImporter] Typedef import brings in the complete type

shafik added a comment. Apologies for my late comments. Comment at: cfe/trunk/unittests/AST/ASTImporterTest.cpp:3780 + typedefNameDecl(hasName("U"))); + ASSERT_TRUE(ToD->getUnderlyingType()->isIncompleteType()); + As far as I can tell `S` is complete in

[PATCH] D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast

sidorovd updated this revision to Diff 175722. sidorovd marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54947/new/ https://reviews.llvm.org/D54947 Files: lib/CodeGen/CGCall.cpp test/CodeGenOpenCL/addr-space-struct-arg.cl Index:

[PATCH] D52986: [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:884 + // even if we lex a tok::comma and ParanthesesDepth == 1. + const IdentifierInfo *__VA_ARGS__II = PP.getIdentifierInfo("__VA_ARGS__"); +

[PATCH] D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast

sidorovd added a comment. @yaxunl, since I'm partially reverting your change https://reviews.llvm.org/D34367 can you give a feedback on this? Comment at: lib/CodeGen/CGCall.cpp:3972 + // we don't want to perform address space cast for it, since that + //

[PATCH] D52986: [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__

Szelethus updated this revision to Diff 175718. Szelethus added a comment. Herald added a subscriber: gamesh411. - Fixed a crash where no arguments (**not** empty arguments) were supplied to `__VA_ARGS__`. - Rebased to master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52986/new/

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

yvvan added a comment. @ilya-biryukov To clarify a little bit - i did not write my own simple app but used libclang in qt creator to reproduce the lock and track the issue. This time I hope to go further, collect flags used by clang and make a simple example. CHANGES SINCE LAST ACTION

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright marked 2 inline comments as done. hwright added a comment. Anything else for me here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54737/new/ https://reviews.llvm.org/D54737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

ilya-biryukov added inline comments. Comment at: clangd/index/IndexAction.cpp:12 +llvm::Optional URIFromFileEntry(const FileEntry *File) { + if (!File) NIT: maybe call it `toURI`? Comment at: clangd/index/IndexAction.cpp:23 +// Collects the

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175710. courbet marked 2 inline comments as done. courbet added a comment. expand types in all qualifiers, not only type traits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet marked 2 inline comments as done. courbet added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3061 +#define TYPE_TRAIT_N(Spelling, Name, Key) RecordName == (#Spelling + 2) || +#include "clang/Basic/TokenKinds.def" +#undef TYPE_TRAIT_1

r347777 - [analyzer] Cleanup constructors in the Z3 backend

Author: mramalho Date: Wed Nov 28 09:22:49 2018 New Revision: 34 URL: http://llvm.org/viewvc/llvm-project?rev=34=rev Log: [analyzer] Cleanup constructors in the Z3 backend Summary: Left only the constructors that are actually required, and marked the move constructors as deleted. They

[PATCH] D54974: [analyzer] Cleanup constructors in the Z3 backend

This revision was automatically updated to reflect the committed changes. Closed by commit rC34: [analyzer] Cleanup constructors in the Z3 backend (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

ilya-biryukov added a comment. In D54995#1311427 , @zturner wrote: > My first thought would be that it depends on the flags to CreateFile moreso > (and perhaps entirely) rather than the flags to MapViewOfFile or > CreateFileMapping. Specifically, the

[PATCH] D54756: [DebugInfo] NFC Clang test changes for DISubprogram flags

probinson added a comment. Ping. @aprantl approved the dependent patch D54755 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54756/new/ https://reviews.llvm.org/D54756 ___

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

Szelethus added a comment. In D54757#1311468 , @donat.nagy wrote: > **Macros:** > > The current implementation of the check only looks at the preprocessed code, > therefore it detects the situations where the duplication is created by > macros. I added

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

donat.nagy updated this revision to Diff 175701. donat.nagy added a comment. Correct a typo (ELSE instead of else) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54757/new/ https://reviews.llvm.org/D54757 Files:

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54858/new/ https://reviews.llvm.org/D54858 ___ cfe-commits mailing list

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

rjmccall added inline comments. Comment at: lib/AST/DeclCXX.cpp:2187 ClassTy = C.getQualifiedType(ClassTy, Qualifiers::fromCVRUMask(getTypeQualifiers())); + I feel like the right design now is for `getTypeQualifiers()` to

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

donat.nagy marked 3 inline comments as done. donat.nagy added a comment. **AstDiff:** I looked at the AstDiff library, but I think that it is overkill for my goals. The main feat of the AstDiff library is analyzing and presenting the differences between two AST subtrees, while this checker

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:5276 +// Return type cann't be qualified with an address space. +if (ResultType.getAddressSpace() != LangAS::Default) { bader wrote: >

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rjmccall added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:3991-3992 + if (auto *MD = dyn_cast(D)) { +// FIXME: There's no reason to do this if the key function is inline. +// Formally, the ABI requires it, but the difference is not observable. +if

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

Anastasia updated this revision to Diff 175699. Anastasia marked an inline comment as done. Anastasia added a comment. Removed commented code in the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54858/new/ https://reviews.llvm.org/D54858 Files: lib/Sema/SemaDecl.cpp

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

Anastasia updated this revision to Diff 175698. Anastasia added a comment. Corrected a typo in comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54858/new/ https://reviews.llvm.org/D54858 Files: lib/Sema/SemaDecl.cpp lib/Sema/SemaType.cpp lib/Sema/TreeTransform.h

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

donat.nagy updated this revision to Diff 175697. donat.nagy marked 5 inline comments as done. donat.nagy added a comment. Minor simplifications, add tests for macro handling Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54757/new/

  1   2   >