[PATCH] D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`

Quuxplusone added a comment. @rsmith ping! It's been a week since the last ping... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54565/new/ https://reviews.llvm.org/D54565 ___ cfe-commits mailing list

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

This revision was automatically updated to reflect the committed changes. Closed by commit rL349890: [Sema] Produce diagnostics when C++17 aligned allocation/deallocation (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r349890 - [Sema] Produce diagnostics when C++17 aligned allocation/deallocation

Author: ahatanak Date: Thu Dec 20 23:05:36 2018 New Revision: 349890 URL: http://llvm.org/viewvc/llvm-project?rev=349890=rev Log: [Sema] Produce diagnostics when C++17 aligned allocation/deallocation functions that are unavailable on Darwin are explicitly called or called from deleting

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

ahatanak added a comment. In D55662#1337141 , @rjmccall wrote: > In D55662#1336835 , @ahatanak wrote: > > > In D55662#1335773 , @rjmccall > > wrote: > > > > > Okay. You

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

stephanemoore added a comment. In D55640#1329390 , @theraven wrote: > I wonder if we want to have an option to elide ObjC type info for all non-POD > C++ types. Nothing that you do with the type encoding is likely to be > correct (for example, you can

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 

stephanemoore updated this revision to Diff 179239. stephanemoore marked 6 inline comments as done. stephanemoore added a comment. Changes: • Assert on `EncodedDecl`. • Mention default value in objc-type-encoding-size check notes. Outstanding action items: • Evaluate using `hasDeclContext`

[PATCH] D55984: [gn build] Embed __TEXT __info_plist section into clang binary on macOS

thakis created this revision. thakis added a reviewer: phosek. Verified by comparing the output of `otool -P bin/clang` between the GN and the CMake build. https://reviews.llvm.org/D55984 Files: llvm/utils/gn/secondary/clang/tools/driver/BUILD.gn Index:

[PATCH] D55982: [OPENMP] Add support for explicit mapping of classes using 'this' pointer

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. patricklyster added projects: clang, OpenMP. Herald added subscribers: cfe-commits, guansong. Add support for explicit mapping of `this` pointer in

[PATCH] D55981: [gn build] Add build files for clang, clang-offload-bundler, and clang/lib/Headers

thakis created this revision. thakis added a reviewer: phosek. Herald added a subscriber: jfb. thakis added a parent revision: D55980: [gn build] Add build file for clang/lib/FrontendTool. With this, the GN build can build clang! https://reviews.llvm.org/D55981 Files:

[PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

thakis added a comment. Herald added a subscriber: guansong. Sorry about the years-later question, but what's the motivation for shelling out to an external command here? In general, LLVM tries to use a library-based approach, and LLVM went e.g. through great lengths do use an integrated

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Thanks, @mgorny! Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55891/new/ https://reviews.llvm.org/D55891

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

thakis added a comment. In D55978#1338651 , @george.karpenkov wrote: > Looks reasonable, what about linking with Z3? Or is your goal just to get a > minimally working functionality? Sorry, forgot to reply to this. I don't use this, so I feel someone

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

thakis added a comment. Thanks for taking a look! In D55978#1338654 , @george.karpenkov wrote: > > I might want to default to clang_enable_static_analyzer=false when I add > > the clang/lib/FrontendTool build file. > > I don't think that quite makes

[PATCH] D55980: [gn build] Add build file for clang/lib/FrontendTool

thakis created this revision. thakis added a reviewer: phosek. https://reviews.llvm.org/D55980 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/clang/lib/FrontendTool/BUILD.gn Index: llvm/utils/gn/secondary/clang/lib/FrontendTool/BUILD.gn

[PATCH] D55979: [gn build] Add build file for clang/lib/ARCMigrate

thakis created this revision. thakis added a reviewer: phosek. thakis added a parent revision: D55978: [gn build] Add build files for clang/lib/{ASTMatchers,CrossTU}, clang/lib/StaticAnalyzer/{Checkers,Core,Frontend}. https://reviews.llvm.org/D55979 Files: llvm/utils/gn/secondary/BUILD.gn

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

NoQ updated this revision to Diff 179230. NoQ added a comment. I'll test this more thoroughly. In case it's still wrong, here's a safer fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55875/new/ https://reviews.llvm.org/D55875 Files: lib/StaticAnalyzer/Core/Store.cpp

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

NoQ updated this revision to Diff 179228. NoQ added a comment. Add a few more tests, just in case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55875/new/ https://reviews.llvm.org/D55875 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

george.karpenkov added a comment. > I might want to default to clang_enable_static_analyzer=false when I add the > clang/lib/FrontendTool build file. I don't think that quite makes sense, since by default clang does have the analyzer built in. CHANGES SINCE LAST ACTION

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

george.karpenkov added a comment. Looks reasonable, what about linking with Z3? Or is your goal just to get a minimally working functionality? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55978/new/ https://reviews.llvm.org/D55978 ___

r349876 - [analyzer] Perform escaping in RetainCountChecker on type mismatch even for inlined functions

Author: george.karpenkov Date: Thu Dec 20 18:16:36 2018 New Revision: 349876 URL: http://llvm.org/viewvc/llvm-project?rev=349876=rev Log: [analyzer] Perform escaping in RetainCountChecker on type mismatch even for inlined functions The fix done in D55465 did not previously apply when the

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

thakis created this revision. thakis added a reviewer: phosek. Herald added subscribers: dkrupp, donat.nagy, jfb, Szelethus, arphaman, a.sidorin, baloghadamsoftware. Herald added a reviewer: george.karpenkov. The intent is to add the build file for clang/lib/StaticAnalyzer/Frontend; everything

[PATCH] D55976: [analyzer] Perform escaping in RetainCountChecker on type mismatch even for inlined functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC349876: [analyzer] Perform escaping in RetainCountChecker on type mismatch even for… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r349875 - [analyzer] Fix a bug in RetainCountDiagnostics while printing a note on mismatched summary in inlined functions

Author: george.karpenkov Date: Thu Dec 20 18:16:23 2018 New Revision: 349875 URL: http://llvm.org/viewvc/llvm-project?rev=349875=rev Log: [analyzer] Fix a bug in RetainCountDiagnostics while printing a note on mismatched summary in inlined functions Previously, we were not printing a note at

[PATCH] D55875: [analyzer] pr38668: RegionStore: Do not attempt to cast loaded values of non-scalar types.

NoQ updated this revision to Diff 179218. NoQ added a comment. Attempt to define the notion of "type of `SVal`". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55875/new/ https://reviews.llvm.org/D55875 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h

r349872 - [mingw] Don't mangle thiscall like fastcall etc

Author: rnk Date: Thu Dec 20 17:40:29 2018 New Revision: 349872 URL: http://llvm.org/viewvc/llvm-project?rev=349872=rev Log: [mingw] Don't mangle thiscall like fastcall etc GCC does not mangle it when it is not explicit in the source. The mangler as currently written cannot differentiate

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF updated this revision to Diff 179211. EricWF added a comment. Herald added a reviewer: shafik. Merge with upstream. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37035/new/ https://reviews.llvm.org/D37035 Files: docs/LanguageExtensions.rst include/clang/AST/ASTContext.h

r349866 - [driver] [analyzer] Fix --analyze -Xanalyzer after r349863.

Author: dergachev Date: Thu Dec 20 17:11:21 2018 New Revision: 349866 URL: http://llvm.org/viewvc/llvm-project?rev=349866=rev Log: [driver] [analyzer] Fix --analyze -Xanalyzer after r349863. If an -analyzer-config is passed through -Xanalyzer, it is not found while looking for -Xclang.

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

vsapsai accepted this revision. vsapsai added a comment. The change itself looks correct. Cannot really tell if you need to make changes in other places. For that I rely on Richard's opinion. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47757/new/

[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

qcolombet added a comment. Should we emit an error if we request x86_64h with an arch older than haswell? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55775/new/ https://reviews.llvm.org/D55775 ___ cfe-commits

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

NoQ added a comment. George committed this as rC349863 . Before that happened, we kinda figured out how it works: `-analyzer-config` is not a flag, it's an argument of the `-Xclang` flag, so we should look for `-Xclang` and see what value does the argument

r349863 - Revert "Revert "[driver] [analyzer] Fix a backward compatibility issue after r348038.""

Author: george.karpenkov Date: Thu Dec 20 16:26:19 2018 New Revision: 349863 URL: http://llvm.org/viewvc/llvm-project?rev=349863=rev Log: Revert "Revert "[driver] [analyzer] Fix a backward compatibility issue after r348038."" This reverts commit 144927939587b790c0536f4ff08245043fc8d733. Fixes

[PATCH] D55907: [analyzer] RetainCount: Bluntly suppress the CFRetain detection heuristic on a couple of CM functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC349862: [analyzer] RetainCount: Suppress retain detection heuristic on some CM methods. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

r349862 - [analyzer] RetainCount: Suppress retain detection heuristic on some CM methods.

Author: dergachev Date: Thu Dec 20 16:18:58 2018 New Revision: 349862 URL: http://llvm.org/viewvc/llvm-project?rev=349862=rev Log: [analyzer] RetainCount: Suppress retain detection heuristic on some CM methods. If it ends with "Retain" like CFRetain and returns a CFTypeRef like CFRetain, then it

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington updated this revision to Diff 179196. erik.pilkington marked 5 inline comments as done. erik.pilkington added a comment. Add some more Sema tests as per Aaron's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55865/new/ https://reviews.llvm.org/D55865 Files:

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington added inline comments. Comment at: clang/test/SemaObjC/externally-retained.m:14 + + EXT_RET int (^d)() = ^{return 0;}; + EXT_RET ObjCTy *e = 0; aaron.ballman wrote: > Should this be useful for function pointer parameters as well? e.g., > ``` >

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

ahatanak updated this revision to Diff 179195. ahatanak marked 2 inline comments as done. ahatanak added a comment. Check whether the declaration passed to Sema::CanUseDecl is an aligned allocation/deallocation function that is unavailable. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

NoQ updated this revision to Diff 179193. NoQ added a comment. Remove debug prints >.< CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55823/new/ https://reviews.llvm.org/D55823 Files: lib/Driver/ToolChains/Clang.cpp test/Analysis/invalid-a-na-ly-zer-con-fig-value.c

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

NoQ updated this revision to Diff 179191. NoQ added a comment. Though yeah, thanks, we might be crashing for that reason as well in the future! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55823/new/ https://reviews.llvm.org/D55823 Files: lib/Driver/ToolChains/Clang.cpp

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

NoQ added a comment. In D55823#1338337 , @arphaman wrote: > I think `Args.getArgString` might return `nullptr` so that's why you could > crash. Nope, we crash on index lookup. It seems that `Args.size()` is larger than the small vector that we're

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht created this revision. rupprecht added reviewers: djasper, krasimir. Herald added a subscriber: cfe-commits. clang-formatting wants to add spaces around items in square braces, e.g. [1, 2] -> [ 1, 2 ]. Based on a quick check [1], it seems like most cases are using the [1, 2] format,

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

arphaman added a comment. I think `Args.getArgString` might return `nullptr` so that's why you could crash. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55823/new/ https://reviews.llvm.org/D55823 ___ cfe-commits

r349853 - [CodeGen] Fix a test from r349848 by replacing `objc_` with `llvm.objc.`

Author: vsapsai Date: Thu Dec 20 15:26:29 2018 New Revision: 349853 URL: http://llvm.org/viewvc/llvm-project?rev=349853=rev Log: [CodeGen] Fix a test from r349848 by replacing `objc_` with `llvm.objc.` Modified: cfe/trunk/test/CodeGenObjCXX/inheriting-constructor-cleanup.mm Modified:

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

rjmccall added a comment. In D55869#1338003 , @theraven wrote: > This should be fine for the GNUstep runtime (the GCC runtime doesn't support > ARC at all). My main concern is that it will break already-released versions > of the runtime built with a

[PATCH] D55907: [analyzer] RetainCount: Bluntly suppress the CFRetain detection heuristic on a couple of CM functions.

george.karpenkov added a comment. In general, I'm against hardcoding, and I think we should use the annotations indicating that the function does retain. (or use a naming convention, and use an annotation to indicate that the function does not retain). However, if this is prohibitive for some

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai added a comment. Thanks for the review, John. Committed the change and will watch the buildbots on non-Darwin platform. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55543/new/ https://reviews.llvm.org/D55543

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6162 +} + } + Anastasia wrote: > rjmccall wrote: > > Anastasia wrote: > > > rjmccall wrote: > > > > This is enforcing a restriction that users write `const __private`, > > > >

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

This revision was automatically updated to reflect the committed changes. Closed by commit rC349848: [CodeGen] Fix assertion on emitting cleanup for object with inlined inherited… (authored by vsapsai, committed by ). Changed prior to commit:

r349848 - [CodeGen] Fix assertion on emitting cleanup for object with inlined inherited constructor and non-trivial destructor.

Author: vsapsai Date: Thu Dec 20 14:43:26 2018 New Revision: 349848 URL: http://llvm.org/viewvc/llvm-project?rev=349848=rev Log: [CodeGen] Fix assertion on emitting cleanup for object with inlined inherited constructor and non-trivial destructor. Fixes assertion > Assertion failed: (isa(Val) &&

[PATCH] D55628: Add support for "labels" on push/pop directives in #pragma clang attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rC349845: Add support for namespaces on #pragma clang attribute (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D55628?vs=178952=179160#toc Repository: rC Clang

r349845 - Add support for namespaces on #pragma clang attribute

Author: epilk Date: Thu Dec 20 14:32:04 2018 New Revision: 349845 URL: http://llvm.org/viewvc/llvm-project?rev=349845=rev Log: Add support for namespaces on #pragma clang attribute Namespaces are introduced by adding an "identifier." before a push/pop directive. Pop directives with namespaces

r349843 - Revert "[driver] [analyzer] Fix a backward compatibility issue after r348038."

Author: dergachev Date: Thu Dec 20 14:29:49 2018 New Revision: 349843 URL: http://llvm.org/viewvc/llvm-project?rev=349843=rev Log: Revert "[driver] [analyzer] Fix a backward compatibility issue after r348038." This reverts commits r349824, r349828, r349835. More buildbot failures were noticed.

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6117 + // to ensure that the variable is 'const' so that we can error on + // modification, which can otherwise overrelease. + VD->setType(Ty.withConst()); erik.pilkington wrote:

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

NoQ added a comment. Hmm, this http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/14563/steps/test-stage2-compiler/logs/stdio also looks like ours. I guess i'll revert cause i've no idea what causes that. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D36790: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC349841: [ObjC] Messages to self in class methods that return instancetype should (authored by arphaman, committed by ).

[PATCH] D36790: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message

arphaman marked an inline comment as done. arphaman added a comment. Herald added subscribers: dexonsmith, jkorous. Fixed comment, will commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36790/new/ https://reviews.llvm.org/D36790 ___

[PATCH] D55907: [analyzer] RetainCount: Bluntly suppress the CFRetain detection heuristic on a couple of CM functions.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This seems reasonable to me, but please have George take a look too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55907/new/ https://reviews.llvm.org/D55907

r349841 - [ObjC] Messages to 'self' in class methods that return 'instancetype' should

Author: arphaman Date: Thu Dec 20 14:11:11 2018 New Revision: 349841 URL: http://llvm.org/viewvc/llvm-project?rev=349841=rev Log: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message Prior to this commit,

[PATCH] D55949: Correctly handle function pointers returning a type marked nodiscard

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lib/AST/Expr.cpp:2281-2286 + // If there is no FunctionDecl for the call, check the return type of the + // callee to see if it

r349840 - cmake: Remove uses of add_llvm_loadable_module macro

Author: tstellar Date: Thu Dec 20 14:04:36 2018 New Revision: 349840 URL: http://llvm.org/viewvc/llvm-project?rev=349840=rev Log: cmake: Remove uses of add_llvm_loadable_module macro This was removed from llvm in r349839. Modified: cfe/trunk/examples/AnnotateFunctions/CMakeLists.txt

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

NoQ added a comment. Np! We really appreciate your work! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55823/new/ https://reviews.llvm.org/D55823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

rsmith added inline comments. Comment at: lib/Sema/SemaStmt.cpp:2846 diag::warn_empty_range_based_for_body); + DiagnoseUnusedExprResult(B); rsmith wrote: > While this looks correct per the current approach to this function, we really

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

rsmith added inline comments. Comment at: lib/Sema/SemaStmt.cpp:2846 diag::warn_empty_range_based_for_body); + DiagnoseUnusedExprResult(B); While this looks correct per the current approach to this function, we really shouldn't be

[PATCH] D55931: [gn build] Add build file for clang/lib/CodeGen and llvm/lib/ProfileData/Coverage

This revision was automatically updated to reflect the committed changes. Closed by commit rL349834: [gn build] Add build file for clang/lib/CodeGen and… (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D55931?vs=179075=179153#toc Repository: rL LLVM

r349835 - [driver] [analyzer] Fix redundant test output.

Author: dergachev Date: Thu Dec 20 13:56:49 2018 New Revision: 349835 URL: http://llvm.org/viewvc/llvm-project?rev=349835=rev Log: [driver] [analyzer] Fix redundant test output. The -c flag causes a .o file to appear every time we run a test. Remove it. Differential Revision:

[PATCH] D55930: [gn build] Add build files for clang/lib/{Frontend, Frontend/Rewrite, Serialization}

This revision was automatically updated to reflect the committed changes. Closed by commit rL349833: [gn build] Add build files for clang/lib/{Frontend,Frontend/Rewrite… (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55927: [gn build] Add build file for clang/lib/Driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL349832: [gn build] Add build file for clang/lib/Driver (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55925: [gn build] Add build file for clang/lib/Parse

This revision was automatically updated to reflect the committed changes. Closed by commit rL349831: [gn build] Add build file for clang/lib/Parse (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55924: [gn build] Add build files for clang-format and lib/{Format, Rewrite, Tooling/Core, Tooling/Inclusions}

This revision was automatically updated to reflect the committed changes. Closed by commit rL349830: [gn build] Add build files for clang-format and lib/{Format,Rewrite… (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, Quuxplusone, erik.pilkington. If the range-based for loop function body is not a compound statement, we would fail to diagnose discarded results from the statement. This only impacted range-based for loops because other

r349828 - [driver] [analyzer] Fix buildbots after r349824.

Author: dergachev Date: Thu Dec 20 13:45:33 2018 New Revision: 349828 URL: http://llvm.org/viewvc/llvm-project?rev=349828=rev Log: [driver] [analyzer] Fix buildbots after r349824. Buildbots can't find the linker, which we don't really need in our tests. Differential Revision:

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin updated this revision to Diff 179145. alexey.lapshin added a comment. update documentation section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55710/new/ https://reviews.llvm.org/D55710 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D55930: [gn build] Add build files for clang/lib/{Frontend, Frontend/Rewrite, Serialization}

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55930/new/ https://reviews.llvm.org/D55930 ___ cfe-commits mailing list

[PATCH] D55931: [gn build] Add build file for clang/lib/CodeGen and llvm/lib/ProfileData/Coverage

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55931/new/ https://reviews.llvm.org/D55931 ___ cfe-commits mailing list

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

rjmccall added inline comments. Comment at: include/clang/Sema/DeclSpec.h:1304 +/// DeclSpec for the function with the qualifier related info. +DeclSpec *TypeDeclSpec; + Can we give this a better name? I know we use "type qualifiers" for this concept

r349825 - Declares __cpu_model as dso local

Author: hhb Date: Thu Dec 20 13:33:59 2018 New Revision: 349825 URL: http://llvm.org/viewvc/llvm-project?rev=349825=rev Log: Declares __cpu_model as dso local __builtin_cpu_supports and __builtin_cpu_is use information in __cpu_model to decide cpu features. Before this change, __cpu_model was

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

This revision was automatically updated to reflect the committed changes. Closed by commit rL349824: [driver] [analyzer] Fix a backward compatibility issue after r348038. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r349824 - [driver] [analyzer] Fix a backward compatibility issue after r348038.

Author: dergachev Date: Thu Dec 20 13:26:40 2018 New Revision: 349824 URL: http://llvm.org/viewvc/llvm-project?rev=349824=rev Log: [driver] [analyzer] Fix a backward compatibility issue after r348038. Since r348038 we emit an error every time an -analyzer-config option is not found. The driver,

[PATCH] D52117: Generate llvm.loop.parallel_accesses instead of llvm.mem.parallel_loop_access metadata.

This revision was automatically updated to reflect the committed changes. Closed by commit rC349823: [CodeGen] Generate llvm.loop.parallel_accesses instead of llvm.mem. (authored by Meinersbur, committed by ). Changed prior to commit: https://reviews.llvm.org/D52117?vs=178944=179141#toc

r349823 - [CodeGen] Generate llvm.loop.parallel_accesses instead of llvm.mem.parallel_loop_access metadata.

Author: meinersbur Date: Thu Dec 20 13:24:54 2018 New Revision: 349823 URL: http://llvm.org/viewvc/llvm-project?rev=349823=rev Log: [CodeGen] Generate llvm.loop.parallel_accesses instead of llvm.mem.parallel_loop_access metadata. Instead of generating llvm.mem.parallel_loop_access metadata,

[PATCH] D55953: Android is not GNU, so don't claim that it is.

danalbert created this revision. danalbert added reviewers: pirama, srhines. Repository: rC Clang https://reviews.llvm.org/D55953 Files: lib/Basic/Targets/OSTargets.h test/Preprocessor/init.c Index: test/Preprocessor/init.c

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaExpr.cpp:54 /// emitting diagnostics. bool Sema::CanUseDecl(NamedDecl *D, bool TreatUnavailableAsInvalid) { // See if this is an auto-typed

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

m4tx updated this revision to Diff 179138. m4tx marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/DuplicatedAccessSpecifiersCheck.cpp

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

m4tx marked 4 inline comments as done. m4tx added a comment. In D55793#1335274 , @lebedev.ri wrote: > In D55793#1335249 , @m4tx wrote: > > > In D55793#1333661 , @lebedev.ri

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

Szelethus accepted this revision. Szelethus added a comment. Thanks! Sorry about being a little slow with this, I'm sadly busier than I expected, but I'll definitely think about a nicer solution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55823/new/ https://reviews.llvm.org/D55823

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3492 +def warn_ignored_objc_externally_retained : Warning< + "'objc_externally_retained' can only be applied to strong retainable " + "object pointer types with automatic

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington updated this revision to Diff 179137. erik.pilkington marked 8 inline comments as done. erik.pilkington added a comment. Address some review comments. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55865/new/ https://reviews.llvm.org/D55865 Files:

r349820 - Make the "too many braces in scalar initialization" extension cause

Author: rsmith Date: Thu Dec 20 12:58:53 2018 New Revision: 349820 URL: http://llvm.org/viewvc/llvm-project?rev=349820=rev Log: Make the "too many braces in scalar initialization" extension cause SFINAE failures. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

NoQ updated this revision to Diff 179135. NoQ added a comment. Re-remove the first argument append. Add a test in which file name doesn't match our search. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55823/new/ https://reviews.llvm.org/D55823 Files:

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

Szelethus marked an inline comment as done. Szelethus added a comment. Sure! I'm on my phone, and will be for a little while, can you commit on my behalf? Comment at: lib/Driver/ToolChains/Clang.cpp:3700 + // through them. + for (size_t Index = 0; Index < Args.size();

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

NoQ added a comment. @Szelethus: Ok if we commit this real quick and then see if there's a better solution? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55823/new/ https://reviews.llvm.org/D55823 ___ cfe-commits mailing list

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

george.karpenkov added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3700 + // through them. + for (size_t Index = 0; Index < Args.size(); ++Index) { +if (StringRef(Args.getArgString(Index)).contains("-analyzer-config")) { NoQ wrote: > Needs

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6162 +} + } + rjmccall wrote: > Anastasia wrote: > > rjmccall wrote: > > > This is enforcing a restriction that users write `const

[PATCH] D55949: Correctly handle function pointers returning a type marked nodiscard

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, Quuxplusone, erik.pilkington. When a function returns a type and that type was declared `[[nodiscard]]`, we diagnose any unused results from that call as though the function were marked nodiscard. The same behavior

r349816 - Fix the example checker plugin after r349812.

Author: aaronballman Date: Thu Dec 20 12:35:01 2018 New Revision: 349816 URL: http://llvm.org/viewvc/llvm-project?rev=349816=rev Log: Fix the example checker plugin after r349812. Modified: cfe/trunk/examples/analyzer-plugin/MainCallChecker.cpp Modified:

r349815 - Fix build failures from r349812 due to a missing argument.

Author: aaronballman Date: Thu Dec 20 12:32:59 2018 New Revision: 349815 URL: http://llvm.org/viewvc/llvm-project?rev=349815=rev Log: Fix build failures from r349812 due to a missing argument. Modified: cfe/trunk/unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp Modified:

[PATCH] D51641: [VFS] Cache the current working directory for the real FS.

labath added subscribers: JDevlieghere, labath. labath added a comment. Might I ask what was the motivation for this change? Performance optimalization? I am asking this because this makes the RealFileSystem return bogus values for the CWD if it changes through means other than the

[PATCH] D55869: Convert some ObjC retain/release msgSends to runtime calls

theraven added a comment. This should be fine for the GNUstep runtime (the GCC runtime doesn't support ARC at all). My main concern is that it will break already-released versions of the runtime built with a newer version of clang. I can easily enable a new flag in the next release, but

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: jfb. Rather than duplicating data fields, use DeclSpec directly to store qualifiers for the functions/methods. This change is discussed in the following comment:

[PATCH] D55927: [gn build] Add build file for clang/lib/Driver

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55927/new/ https://reviews.llvm.org/D55927 ___ cfe-commits mailing list

[PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've commit in r349812. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55792/new/ https://reviews.llvm.org/D55792 ___ cfe-commits mailing list

  1   2   >