chandlerc added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:592-595
+ if (Arg *A = Args.getLastArg(options::OPT_fno_omit_frame_pointer,
+ options::OPT_fomit_frame_pointer))
+return
tabloid.adroit marked 3 inline comments as done.
tabloid.adroit added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1739
FuncAttrs.addAttribute("no-frame-pointer-elim", "true");
- FuncAttrs.addAttribute("no-frame-pointer-elim-non-leaf");
}
phosek added inline comments.
Comment at: llvm/utils/gn/secondary/llvm/triples.gni:10
+} else {
+ assert(false, "missing host_cpu " + host_cpu)
}
I don't think `host_cpu` would ever be missing since it's detected by GN
(unless it's a new architecture that GN
chandlerc requested changes to this revision.
chandlerc added reviewers: hans, rnk.
chandlerc added a comment.
This revision now requires changes to proceed.
The number of negations and such in the CC1 interface here and the attributes
makes all of these tests super confusing. Wonder if we
thakis marked an inline comment as done.
thakis added inline comments.
Comment at: llvm/utils/gn/secondary/clang/test/BUILD.gn:23
+
+ "LIT_SITE_CFG_IN_HEADER=## Autogenerated from ${sources[0]}, do not
edit",
+ "CLANG_BINARY_DIR=" +
As you can see,
thakis created this revision.
thakis added a reviewer: phosek.
With this, check-clang runs and passes all of clang's lit tests. It doesn't run
any of its unit tests yet.
Like with check-lld, running just ninja -C out/gn will build all prerequisites
needed to run tests, but it won't run the
hwright added a comment.
@lebedev.ri Where do the appropriate tests live? (I couldn't find an obvious
subdirectory in `test/`)
Where are the instructions for regenerating the documentation?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56090/new/
lebedev.ri added a comment.
1. Tests
2. The docs file will need to be regenerated
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56090/new/
https://reviews.llvm.org/D56090
___
cfe-commits mailing list
hwright created this revision.
hwright added a reviewer: aaron.ballman.
hwright added a project: clang.
Herald added a subscriber: cfe-commits.
Much like `hasArg` for various call expressions, this allows `LibTooling` users
to match against a member of an initializer list.
This is currently
Author: rnk
Date: Wed Dec 26 13:04:08 2018
New Revision: 350072
URL: http://llvm.org/viewvc/llvm-project?rev=350072=rev
Log:
[clang-cl] Treat inputs as C++ with /E, like MSVC
midl invokes the compiler on .idl files with /E. Before this change, we
would treat unrecognized inputs as object files.
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:5337
ExprResult ActOnFinishFullExpr(Expr *Expr, SourceLocation CC,
- bool DiscardedValue = false,
+ bool WarnOnDiscardedValue = false,
Author: rnk
Date: Wed Dec 26 12:07:52 2018
New Revision: 350071
URL: http://llvm.org/viewvc/llvm-project?rev=350071=rev
Log:
[MS] Mangle return adjusting thunks with the public access specifier
MSVC does this, so we should too.
Fixes PR40138
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL350068: Ignore ConstantExpr in IgnoreParens (authored by
rnk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D55853?vs=178960=179515#toc
Author: rnk
Date: Wed Dec 26 09:44:40 2018
New Revision: 350068
URL: http://llvm.org/viewvc/llvm-project?rev=350068=rev
Log:
Ignore ConstantExpr in IgnoreParens
Summary:
This moves it up from IgnoreParenImpCasts to IgnoreParens, so that more
helpers ignore it. For most clients, this ensures that
rnk marked 4 inline comments as done.
rnk added inline comments.
Comment at: clang/lib/AST/Expr.cpp:2550
}
+if (ConstantExpr *CE = dyn_cast(E)) {
+ E = CE->getSubExpr();
rsmith wrote:
> Does this pass the tests if you use `FullExpr` here instead? I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL350067: Pass a concrete triple for two OpenMP tests that
depend on TLS (authored by nico, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: nico
Date: Wed Dec 26 08:06:26 2018
New Revision: 350067
URL: http://llvm.org/viewvc/llvm-project?rev=350067=rev
Log:
Pass a concrete triple for two OpenMP tests that depend on TLS
Not all %itanium_abi_triple values support TLS. Makes
OpenMP/declare_reduction_codegen.cpp,
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56086/new/
https://reviews.llvm.org/D56086
___
cfe-commits mailing list
thakis created this revision.
thakis added reviewers: ABataev, sfantao.
Herald added a subscriber: guansong.
Not all %itanium_abi_triple values support TLS. Makes
OpenMP/declare_reduction_codegen.cpp, OpenMP/parallel_copyin_codegen.cpp for
%itanium_abi_triples without TLS support.
Fixes
19 matches
Mail list logo
