[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

rjmccall added inline comments. Comment at: clang/docs/AutomaticReferenceCounting.rst:1748 +``objc_externally_retained`` can apply to local variables, or to parameters via +a function definitions. + I think "can apply to parameters and local variables" is

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:4539 + if (InitCategory.isPRValue() || InitCategory.isXValue()) +T1Quals.removeAddressSpace(); + rjmccall wrote: > I can understand why a pr-value wouldn't have an address space, but an >

[PATCH] D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size

modocache created this revision. modocache added reviewers: GorNishanov, lewissbaker, tks2103. Herald added subscribers: cfe-commits, kristina, EricWF. This commit implements a proposed addendum to the C++ Coroutines TS that would allow users to query, at compile time, the maximum potential size

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader created this revision. Kader added a project: clang. Herald added a subscriber: cfe-commits. While building openJDK11u, it seems that some of the code in the native core libraries make liberal use of integer to pointer comparisons. We currently have no flag to disabled this warning. This

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added a comment. In D56109#1344521 , @vitalybuka wrote: > LGTM Thanks! Any feedback regarding the raised comments in https://reviews.llvm.org/D56109#1341967 and https://reviews.llvm.org/D56109#1342059 ? CHANGES SINCE LAST ACTION

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

vitalybuka added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber updated this revision to Diff 179986. bernhardmgruber added a comment. rebased from release_70 onto master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files: clang-tidy/modernize/CMakeLists.txt

Re: r350282 - [libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs

Oops, I committed wrong column number in the test due to reindentation. Fixed in r350283. ~ Alex On Wed, 2 Jan 2019 at 17:16, Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Wed Jan 2 17:13:33 2019 > New Revision: 350282 > > URL:

r350283 - Fix incorrect column numbers in test from r350282.

Author: arphaman Date: Wed Jan 2 17:30:50 2019 New Revision: 350283 URL: http://llvm.org/viewvc/llvm-project?rev=350283=rev Log: Fix incorrect column numbers in test from r350282. After the test was reformatted using clang-format the numbers became invalid. Modified:

r350282 - [libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs

Author: arphaman Date: Wed Jan 2 17:13:33 2019 New Revision: 350282 URL: http://llvm.org/viewvc/llvm-project?rev=350282=rev Log: [libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs This change ensures that the libclang CXCursor represents the CoroutineBody and the

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. I assume that we need to reimplement this in the context of lld: NetBSD::NetBSD(const Driver , const llvm::Triple , const ArgList ) : Generic_ELF(D, Triple, Args) { if (!Args.hasArg(options::OPT_nostdlib)) { // When targeting a 32-bit platform, try

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3787 +variable goes out of scope. Parameters and variables annotated with this +attribute are implicitly ``const``. + rjmccall wrote: > You should add a paragraph

[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

erik.pilkington updated this revision to Diff 179964. erik.pilkington marked 10 inline comments as done. erik.pilkington added a comment. Address review comments. Also, make the attribute apply to parameters via the function declaration instead to parameters directly. i.e.:

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:35 +- New :doc:`modernize-use-trailing-return + ` check. Please rebase from trunk and use alphabetical order for new checks list. CHANGES SINCE LAST ACTION

[PATCH] D56067: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit

This revision was automatically updated to reflect the committed changes. Closed by commit rL350278: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r350278 - Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit

Author: nico Date: Wed Jan 2 16:17:02 2019 New Revision: 350278 URL: http://llvm.org/viewvc/llvm-project?rev=350278=rev Log: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit For some reason, the cmake build on my macbook has LLVM_HOST_TRIPLE:STRING=i386-apple-darwin16.7.0

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber marked 2 inline comments as done. bernhardmgruber added inline comments. Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:2 +// RUN: %check_clang_tidy %s modernize-use-trailing-return %t -- -- --std=c++14 + +namespace std {

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber updated this revision to Diff 179961. bernhardmgruber added a comment. added more test cases, allowing check to run on out-of-line definitions and updated docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files:

[clang-tools-extra] r350273 - [Documentation] Alphabetical order in Clang-tidy checks changes list.

Author: eugenezelenko Date: Wed Jan 2 15:35:57 2019 New Revision: 350273 URL: http://llvm.org/viewvc/llvm-project?rev=350273=rev Log: [Documentation] Alphabetical order in Clang-tidy checks changes list. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

steveire updated this revision to Diff 179953. steveire added a comment. Case Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54408/new/ https://reviews.llvm.org/D54408 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1344317 , @joerg wrote: > In D56215#1344279 , @krytarowski > wrote: > > > In D56215#1344183 , @joerg wrote: > > > > > This doesn't

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

joerg added a comment. In D56215#1344279 , @krytarowski wrote: > In D56215#1344183 , @joerg wrote: > > > This doesn't seem a reasonable approach at all: > > > > (1) It breaks cross-linking. > > (2) It is not

[PATCH] D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends

arphaman created this revision. arphaman added reviewers: benhamilton, krasimir, djasper. Herald added subscribers: dexonsmith, jkorous. The commit r322690 introduced support for ObjC detection in header files. Unfortunately some C headers that use designated initializers are now incorrectly

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1344233 , @ruiu wrote: > lld's driver is intentionally designed to be agnostic of the host that the > linker is running for the reasons described at the beginning of Driver.cpp: >

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber marked 10 inline comments as done. bernhardmgruber added a comment. I fixed most of the stylistic issues. Regarding the missing test cases, I will add those and do the necessary code changes. Thank you very much for pointing them out to me! Comment at:

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber updated this revision to Diff 179945. bernhardmgruber marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D56160 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

[PATCH] D56225: [HIP] Use nul instead of /dev/null when running on windows

yaxunl created this revision. yaxunl added a reviewer: tra. When clang is running on windows, /dev/null is not available. Use nul as empty input file instead. https://reviews.llvm.org/D56225 Files: lib/Driver/ToolChains/HIP.cpp Index: lib/Driver/ToolChains/HIP.cpp

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

ruiu added a comment. lld's driver is intentionally designed to be agnostic of the host that the linker is running for the reasons described at the beginning of Driver.cpp: https://github.com/llvm-project/lld/blob/master/ELF/Driver.cpp#L13 I think I like that approach. If you need to do this,

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny marked 2 inline comments as done. jdenny added a comment. In D56113#1342879 , @ABataev wrote: > But you will need another serie of patches for `reduction` and `linear` > clauses to update their error messages. Those already had their own checks

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin updated this revision to Diff 179933. alexey.lapshin added a comment. Thank you. I updated doc, splitted Parser test, added Sema tests. Please check it once more. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55710/new/ https://reviews.llvm.org/D55710 Files:

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

joerg added a comment. This doesn't seem a reasonable approach at all: (1) It breaks cross-linking. (2) It is not correct for any target architecture, e.g. /usr/local/lib certainly doesn't belong on this list and /lib doesn't either. (3) The correct list depends not only on the target

[PATCH] D56067: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56067/new/ https://reviews.llvm.org/D56067 ___ cfe-commits mailing list

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, ruiu, grimar, espindola. mgorny added a project: lld. Herald added subscribers: llvm-commits, MaskRay, arichardson, emaste. The NetBSD clang driver relies on NetBSD ld knowing the default search paths and never passes those

[PATCH] D55949: Correctly handle function pointers returning a type marked nodiscard

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. Still LG, sorry for the delay! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55949/new/ https://reviews.llvm.org/D55949

[PATCH] D55949: Correctly handle function pointers returning a type marked nodiscard

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55949/new/ https://reviews.llvm.org/D55949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: include/clang/Sema/Sema.h:5337 ExprResult ActOnFinishFullExpr(Expr *Expr, SourceLocation CC, - bool DiscardedValue = false, +

[PATCH] D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop

aaron.ballman updated this revision to Diff 179920. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review feedback. The vast majority of the changes are from the removal of a default argument to `ActOnFullExpr()`. CHANGES SINCE LAST ACTION

r350252 - [OpenMP] Added support for explicit mapping of classes using 'this' pointer. Differential revision: https://reviews.llvm.org/D55982

Author: plyster Date: Wed Jan 2 11:28:48 2019 New Revision: 350252 URL: http://llvm.org/viewvc/llvm-project?rev=350252=rev Log: [OpenMP] Added support for explicit mapping of classes using 'this' pointer. Differential revision: https://reviews.llvm.org/D55982 Modified:

[PATCH] D56198: [Basic] Extend DiagnosticEngine to store and format Qualifiers

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56198/new/ https://reviews.llvm.org/D56198 ___ cfe-commits mailing list

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

rjmccall added inline comments. Comment at: lib/Sema/DeclSpec.cpp:220 + + I.Fun.QualAttrFactory = nullptr; + Anastasia wrote: > rjmccall wrote: > > Spacing? > I am keeping the old formatting from the lines 195-204. But obviously it > doesn't match

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGCall.cpp:78 +RecTy = Context.getAddrSpaceQualType( +RecTy, MD->getTypeQualifiers().getAddressSpace()); return

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia updated this revision to Diff 179899. Anastasia added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56066/new/ https://reviews.llvm.org/D56066 Files: include/clang/Sema/Sema.h lib/CodeGen/CGCall.cpp lib/Sema/SemaDecl.cpp

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/DeclSpec.cpp:220 + + I.Fun.QualAttrFactory = nullptr; + rjmccall wrote: > Spacing? I am keeping the old formatting from the lines 195-204. But obviously

[PATCH] D56198: [Basic] Extend DiagnosticEngine to store and format Qualifiers

Anastasia updated this revision to Diff 179887. Anastasia added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56198/new/ https://reviews.llvm.org/D56198 Files: include/clang/AST/Type.h include/clang/Basic/Diagnostic.h

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

rjmccall added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2368 } }; + DeclSpecCheck(DeclSpec::TQ_const, "const", DS.getConstSpecLoc()); Anastasia wrote: > rjmccall wrote: > > Please remove this dead semicolon since you're

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

Anastasia updated this revision to Diff 179877. Anastasia marked an inline comment as done. Anastasia added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55948/new/ https://reviews.llvm.org/D55948 Files: include/clang/Sema/DeclSpec.h

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:2368 } }; + DeclSpecCheck(DeclSpec::TQ_const, "const", DS.getConstSpecLoc()); rjmccall wrote: > Please remove this dead

[PATCH] D56158: [sanitizer_common] Implement funopen*() interceptors for NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rL350233: [sanitizer_common] Implement funopen*() interceptors for NetBSD (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

This revision was automatically updated to reflect the committed changes. Closed by commit rL350232: [sanitizer_common] Implement popen, popenve, pclose interceptors (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D56153: [sanitizer_common] Add test for popen()

This revision was automatically updated to reflect the committed changes. Closed by commit rL350230: [sanitizer_common] Add test for popen() (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D56153?vs=179712=179870#toc

[PATCH] D56154: [sanitizer_common] Add tests for NetBSD funopen*()

This revision was automatically updated to reflect the committed changes. Closed by commit rL350231: [sanitizer_common] Add tests for NetBSD funopen*() functions (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D56150: [sanitizer_common] Fix devname_r() return type on !NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rL350228: [sanitizer_common] Fix devname_r() return type on !NetBSD (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D56152: [sanitizer_common] Add tests for more *putc and *getc variants

This revision was automatically updated to reflect the committed changes. Closed by commit rL350229: [sanitizer_common] Add tests for more *putc and *getc variants (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D56149: [sanitizer_common] Rewrite more Posix tests to use asserts

This revision was automatically updated to reflect the committed changes. Closed by commit rL350227: [sanitizer_common] Rewrite more Posix tests to use asserts (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL350225: [sanitizer_common] Add tests for more stdio.h functions (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D56067: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit

thakis added a comment. arphaman: 2019 ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56067/new/ https://reviews.llvm.org/D56067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r350224 - Only convert objc messages to alloc to objc_alloc if the receiver is a class.

Author: pete Date: Wed Jan 2 09:25:30 2019 New Revision: 350224 URL: http://llvm.org/viewvc/llvm-project?rev=350224=rev Log: Only convert objc messages to alloc to objc_alloc if the receiver is a class. r348687 converted [Foo alloc] to objc_alloc(Foo). However the objc runtime method only

[PATCH] D56198: [Basic] Extend DiagnosticEngine to store and format Qualifiers

rjmccall added inline comments. Comment at: include/clang/AST/Type.h:6705 +/// Insertion operator for diagnostics. This allows sending Qualifiers' into a +/// diagnostic with <<. +inline const DiagnosticBuilder <<(const DiagnosticBuilder , Unpaired apostrophe,

[PATCH] D55994: [clangd] Check preceding char when completion triggers on ':' or '>'

jkorous added a comment. This looks like a work around LSP imperfection indeed. Are you going to push for change in LSP? Something like `CompletionOptions/triggerCharacters` -> `CompletionOptions/triggerStrings`? export interface CompletionOptions { /** * The server provides

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

rjmccall added a comment. ...although it might be reasonable to extract the method implementations on `DefaultABIInfo` as helper functions so that the code can be reused without requiring a particular inheritance hierarchy. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55932: [Sema] Simplfy static_assert diagnostic code.

aaron.ballman added inline comments. Comment at: test/SemaCXX/static-assert.cpp:130 static_assert(std::is_same()), int>::value, "message"); -// expected-error@-1{{static_assert failed due to requirement 'std::is_same, int>::value' "message"}} +//

[PATCH] D56188: Adopt SwiftABIInfo for WebAssembly.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56188/new/ https://reviews.llvm.org/D56188 ___

[PATCH] D55932: [Sema] Simplfy static_assert diagnostic code.

courbet added inline comments. Comment at: test/SemaCXX/static-assert.cpp:130 static_assert(std::is_same()), int>::value, "message"); -// expected-error@-1{{static_assert failed due to requirement 'std::is_same, int>::value' "message"}} +// expected-error@-1{{static_assert

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

aaron.ballman added inline comments. Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:2 +// RUN: %check_clang_tidy %s modernize-use-trailing-return %t -- -- --std=c++14 + +namespace std { lebedev.ri wrote: > Missing test coverage: > * macros > * is

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2582 specified for the subsequent loop. The directive allows vectorization, -interleaving, and unrolling to be enabled or disabled. Vector width as well -as interleave and unrolling count can be

[PATCH] D55994: [clangd] Check preceding char when completion triggers on ':' or '>'

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clangd/ClangdLSPServer.cpp:811 + if (Trigger == ">") +return (*Code)[*Offset - 2] != '-'; // trigger only on '->'. + if (Trigger == ":")

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

jkorous added a comment. In D55363#1337376 , @hokein wrote: > In D55363#1336315 , @ilya-biryukov > wrote: > > > Maybe consider sending an update after some period of time, e.g. `0.5s`? (I > > expect this

[PATCH] D55932: [Sema] Simplfy static_assert diagnostic code.

aaron.ballman added inline comments. Comment at: test/SemaCXX/static-assert.cpp:130 static_assert(std::is_same()), int>::value, "message"); -// expected-error@-1{{static_assert failed due to requirement 'std::is_same, int>::value' "message"}} +//

[PATCH] D55994: [clangd] Check preceding char when completion triggers on ':' or '>'

ilya-biryukov updated this revision to Diff 179844. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Address comments - Added a test Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55994/new/

[PATCH] D55994: [clangd] Check preceding char when completion triggers on ':' or '>'

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:811 + if (Trigger == ">") +return (*Code)[*Offset - 2] != '-'; // trigger only on '->'. + if (Trigger == ":") hokein wrote: > Checking `Offset` is not always right for rare cases

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

Nicola added a comment. Since this review is just for a prototype, I'll leave some feedback after having played with it for a bit. It seems to be quite trivial to add new builtins and fix existing ones (conversion builtins sat/rounding modes). One builtin that might have a small issue is the

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin updated this revision to Diff 179843. alexey.lapshin added a comment. Thank you. addressed all grammar things. please check it once more. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55710/new/ https://reviews.llvm.org/D55710 Files: include/clang/Basic/Attr.td

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin marked an inline comment as done. alexey.lapshin added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2582 specified for the subsequent loop. The directive allows vectorization, -interleaving, and unrolling to be enabled or disabled. Vector width as

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lib/esan/esan_interceptors.cpp:90 } while (false) +#define COMMON_INTERCEPTOR_PIPE_OPEN(ctx, file) \ + do {

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny updated this revision to Diff 179842. mgorny added a comment. Updated to use `COMMON_INTERCEPTOR_FILE_OPEN` with `nullptr` argument. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56157/new/ https://reviews.llvm.org/D56157 Files:

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny marked 4 inline comments as done. mgorny added a comment. The tests were submitted earlier as D56153 . I'll implement the remaining suggestions. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56157/new/

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

dvyukov added inline comments. Comment at: lib/tsan/rtl/tsan_interceptors.cc:2259 +#define COMMON_INTERCEPTOR_PIPE_OPEN(ctx, file) \ + if (file) { \ krytarowski wrote: > dvyukov wrote: > > An alternative would be to pass NULL

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaOverload.cpp:2828 // FIXME: OpenCL: Need to consider address spaces unsigned FromQuals = FromFunction->getTypeQuals().getCVRUQualifiers(); rjmccall

[PATCH] D56198: [Basic] Extend DiagnosticEngine to store and format Qualifiers

Anastasia created this revision. Anastasia added a reviewer: rjmccall. This is a follow up patch from the following review comment: https://reviews.llvm.org/D55850?id=178767#inline-495051 https://reviews.llvm.org/D56198 Files: include/clang/AST/Type.h include/clang/Basic/Diagnostic.h

[PATCH] D55374: [clangd] Show FileStatus in vscode-clangd.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350210: [clangd] Show FileStatus in vscode-clangd. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[clang-tools-extra] r350210 - [clangd] Show FileStatus in vscode-clangd.

Author: hokein Date: Wed Jan 2 03:25:37 2019 New Revision: 350210 URL: http://llvm.org/viewvc/llvm-project?rev=350210=rev Log: [clangd] Show FileStatus in vscode-clangd. Summary: The file status will be shown in the status bar. Depends on D55363. Reviewers: ilya-biryukov Subscribers: ioeric,

[PATCH] D55994: [clangd] Check preceding char when completion triggers on ':' or '>'

hokein added a comment. The code looks mostly good to me. Comment at: clangd/ClangdLSPServer.cpp:789 +bool ClangdLSPServer::isSporadicCompletion( +const CompletionParams ) const { The method name is a bit confusing to me, I didn't get its meaning at the

[PATCH] D55932: [Sema] Simplfy static_assert diagnostic code.

courbet marked an inline comment as done. courbet added inline comments. Comment at: test/SemaCXX/static-assert.cpp:130 static_assert(std::is_same()), int>::value, "message"); -// expected-error@-1{{static_assert failed due to requirement 'std::is_same, int>::value'