r350487 - Have MSVC Visualizer for DeducedTemplateSpecializationType show both the original template and deduced specialization

Author: mps Date: Sat Jan 5 20:58:48 2019 New Revision: 350487 URL: http://llvm.org/viewvc/llvm-project?rev=350487=rev Log: Have MSVC Visualizer for DeducedTemplateSpecializationType show both the original template and deduced specialization Now appears in the Autos window something like -

[PATCH] D56359: [CMake][Fuchsia] Enable build ID, relaxations for first stage

This revision was automatically updated to reflect the committed changes. Closed by commit rL350486: [CMake][Fuchsia] Enable build ID, relaxations for first stage (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r350486 - [CMake][Fuchsia] Enable build ID, relaxations for first stage

Author: phosek Date: Sat Jan 5 20:14:51 2019 New Revision: 350486 URL: http://llvm.org/viewvc/llvm-project?rev=350486=rev Log: [CMake][Fuchsia] Enable build ID, relaxations for first stage We want these to be used for the second stage compiler as well. Differential Revision:

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

nridge added a comment. Might we want to keep some of this information for `workspace/symbol`? I mean, surely not "documentation", but perhaps "signature" and "return type"? For example, when cquery responds to `workspace/symbol`, it puts into `SymbolInformation.name` a "detailed name"

[PATCH] D56359: [CMake][Fuchsia] Enable build ID, relaxations for first stage

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56359/new/ https://reviews.llvm.org/D56359 ___

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

EricWF marked an inline comment as done. EricWF added a comment. Ping! I would like to land this before the next release. @rsmith, what sorts of additional tests are needed? Comment at: include/clang/Basic/Builtins.def:759 +// Random C++ builtins.

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF added a comment. Ping! I would like to land this before the next release. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37035/new/ https://reviews.llvm.org/D37035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood added a comment. I managed to do some limited testing on the original source file from the bug report in lldb and verified that the correct fix was applied there. I also tried a few other files and verified no false positives. CHANGES SINCE LAST ACTION

[PATCH] D56359: [CMake][Fuchsia] Enable build ID, relaxations for first stage

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. We want these to be used for the second stage compiler as well. Repository: rC Clang https://reviews.llvm.org/D56359 Files: clang/cmake/caches/Fuchsia.cmake Index:

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood added a comment. Uh... I'm developing on Windows, which doesn't have a solution for generating compile_commands.json, so I can't easily test this on the entire clang codebase. I will test on a source file based on the original bug report. CHANGES SINCE LAST ACTION

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood updated this revision to Diff 180385. LegalizeAdulthood added a comment. No really, update from review comments `:)` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 Files: clang-tidy/readability/SimplifyBooleanExprCheck.cpp

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood updated this revision to Diff 180384. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 Files:

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:719 +bool Negated, const SwitchCase *SwitchCase) { + assert(SwitchCase != nullptr); + riccibruno

r350484 - Revert "[CMake][Fuchsia] Enable experimental new pass manager by default"

Author: phosek Date: Sat Jan 5 15:45:31 2019 New Revision: 350484 URL: http://llvm.org/viewvc/llvm-project?rev=350484=rev Log: Revert "[CMake][Fuchsia] Enable experimental new pass manager by default" This reverts commit r350461 as it causes many of the Clang tests to fail. Modified:

r350482 - Fix MSVC Visualization for TemplateTypeParmType and TemplateTypeParmDecl

Author: mps Date: Sat Jan 5 15:15:30 2019 New Revision: 350482 URL: http://llvm.org/viewvc/llvm-project?rev=350482=rev Log: Fix MSVC Visualization for TemplateTypeParmType and TemplateTypeParmDecl Modified: cfe/trunk/utils/ClangVisualizers/clang.natvis Modified:

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. In D56323#1347450 , @JonasToth wrote: > Did you check if the changes actually fix the problematic behaviour? Did you > run it over any project and did the

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood updated this revision to Diff 180380. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 Files:

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

riccibruno added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:719 +bool Negated, const SwitchCase *SwitchCase) { + assert(SwitchCase != nullptr); + LegalizeAdulthood wrote: > aaron.ballman wrote: > > Add a message to the

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

LegalizeAdulthood marked 10 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:386 - bool BoolValue = Bool->getValue(); + const bool BoolValue = Bool->getValue(); JonasToth

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. Did you check if the changes actually fix the problematic behaviour? Did you run it over any project and did the code-transformation break the code, false positives, ...? Otherwise

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

JonasToth added inline comments. Comment at: test/clang-tidy/readability-simplify-bool-expr-members.cpp:160 + // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: {{.*}} in ternary expression result + // CHECK-FIXES: {{^ m_b2 = i <= 20;$}} + LegalizeAdulthood wrote:

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood updated this revision to Diff 180379. LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/ https://reviews.llvm.org/D56323 Files:

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood marked 5 inline comments as done. LegalizeAdulthood added inline comments. Comment at: test/clang-tidy/readability-simplify-bool-expr-members.cpp:4 +struct X { + explicit operator bool(); +}; JonasToth wrote: > LegalizeAdulthood wrote: > >

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); lebedev.ri

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

lebedev.ri added inline comments. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); riccibruno wrote: > It cannot overflow now, but someone

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

riccibruno marked 2 inline comments as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:3029 +assert((CastExprBits.BasePathSize == BasePathSize) && + "BasePathSize overflow!"); assert(CastConsistency()); It cannot

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

riccibruno created this revision. riccibruno added a reviewer: lebedev.ri. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Background: The number of trailing `CXXBaseSpecifiers` in `CastExpr` was moved from `CastExprBitfields` to a trailing object in r338489 (D50050

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. I've grepped FreeBSD, OpenBSD and pkgsrc. OpenBSD ports = Total 2 packages there have issues with LLD. $ grep -r USE_LLD . ./devel/libcoap/Makefile:USE_LLD= No ./sysutils/firmware/vmm/Makefile:USE_LLD= No FreeBSD ports =

r350476 - CodeGen: fix autolink emission on ELF

Author: compnerd Date: Sat Jan 5 11:27:12 2019 New Revision: 350476 URL: http://llvm.org/viewvc/llvm-project?rev=350476=rev Log: CodeGen: fix autolink emission on ELF The autolinking extension for ELF uses a slightly different format for encoding the autolink information compared to COFF and

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

aaron.ballman added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:511 + StringRef Id) { + // binding to the returnStmt matched is pointless because we can't guarantee + // anything about

r350472 - CodeGen: switch iteration to range based for loop (NFC)

Author: compnerd Date: Sat Jan 5 10:39:32 2019 New Revision: 350472 URL: http://llvm.org/viewvc/llvm-project?rev=350472=rev Log: CodeGen: switch iteration to range based for loop (NFC) Change a loop to range based instead while working on cleaning up some modules autolinking issues on Linux.

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

JonasToth added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:464 bool Value, StringRef Id) { - auto SimpleThen = binaryOperator( - hasOperatorName("="), -

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

JonasToth added a comment. In D56343#1347352 , @LegalizeAdulthood wrote: > I really want to get these reviewed quickly. Otherwise, I will run out of > available time to complete them and get them submitted. I will give my best to be available this

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure raw_ostream steveire wrote: >

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure raw_ostream aaron.ballman wrote: >

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood marked 4 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:464 bool Value, StringRef Id) { - auto SimpleThen = binaryOperator( -

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

LegalizeAdulthood added a comment. I really want to get these reviewed quickly. Otherwise, I will run out of available time to complete them and get them submitted. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood added a comment. I really want to get these reviewed quickly. Otherwise, I will run out of available time to complete them and get them submitted. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56343/new/

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

Quuxplusone added inline comments. Comment at: libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:196 test_ctor_under_alloc(); + test_ctor_with_different_value_type(); } vsapsai wrote: > Quuxplusone wrote: > > I suggest

r350470 - Improve MSVC type visualizations

Author: mps Date: Sat Jan 5 09:01:34 2019 New Revision: 350470 URL: http://llvm.org/viewvc/llvm-project?rev=350470=rev Log: Improve MSVC type visualizations Display TypeBits in a single line. Fix bit rot in template visualizations Rudimentary support for deduced types Modified:

Re: r350404 - Refactor the way we handle diagnosing unused expression results.

On Fri, Jan 4, 2019 at 8:41 PM Richard Smith wrote: > > On Fri, 4 Jan 2019 at 17:33, Nico Weber via cfe-commits > wrote: >> >> Nice, this is finding bugs: >> https://bugs.chromium.org/p/chromium/issues/detail?id=919262 >> >> However, I noticed that for that case, the same warning is printed

[PATCH] D56090: Add a matcher for members of an initializer list expression

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thanks, both! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56090/new/ https://reviews.llvm.org/D56090 ___

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

JonasToth accepted this revision. JonasToth added a comment. LGTM. If you have the time please rerun this latest (final?) version over LLVM or any other bigger project and check if there are any issues left and ensure the code still compiles after code-transformation. CHANGES SINCE LAST

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

JonasToth added inline comments. Comment at: test/clang-tidy/check_clang_tidy.py:112 +process_output = e.output.decode() +print('%s failed:\n%s' % (' '.join(args), process_output)) +if raise_error: Its better to use `.format()` instead of `%` syntax

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

JonasToth added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:386 - bool BoolValue = Bool->getValue(); + const bool BoolValue = Bool->getValue(); `const` on values is uncommon in clang-tidy code. Please keep that

[PATCH] D56354: Replace asserts with if() in SourceLocation accessors

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Nowhere else in the AST classes assert on these kinds of accessors. This way, we can call the accessors and check the validity of the result instead of externally duplicating the

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

JonasToth added a comment. Thanks for the patch. Is this revision dependent on D56303 (or other way around)? Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:464 bool Value,

[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

tabloid.adroit added a comment. https://reviews.llvm.org/D56351 https://reviews.llvm.org/D56353 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55915/new/ https://reviews.llvm.org/D55915 ___ cfe-commits mailing list

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit created this revision. tabloid.adroit added reviewers: chandlerc, rnk, t.p.northover. Herald added a subscriber: cfe-commits. set cc1 '-mframe-pointer=' according to driver options m(no-)omit-leaf-frame-pointer and f(no-)omit-frame-pointer This makes -fomit-frame-pointer imply

[PATCH] D56341: [python] Make the collections import future-proof

This revision was automatically updated to reflect the committed changes. Closed by commit rC350467: [python] Make the collections import future-proof (authored by serge_sans_paille, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56341/new/

r350467 - [python] Make the collections import future-proof

Author: serge_sans_paille Date: Sat Jan 5 04:07:36 2019 New Revision: 350467 URL: http://llvm.org/viewvc/llvm-project?rev=350467=rev Log: [python] Make the collections import future-proof On Python 3.7 the old code raises a warning: DeprecationWarning: Using or importing the ABCs from

[clang-tools-extra] r350466 - [Documentation] fix order of checks in checks/list.rst

Author: jonastoth Date: Sat Jan 5 03:40:05 2019 New Revision: 350466 URL: http://llvm.org/viewvc/llvm-project?rev=350466=rev Log: [Documentation] fix order of checks in checks/list.rst Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified:

[PATCH] D56341: [python] Make the collections import future-proof

jstasiak added a comment. Thanks. If you could commit this on my behalf I'd appreciate it (I don't have commit access). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56341/new/ https://reviews.llvm.org/D56341 ___

[PATCH] D56341: [python] Make the collections import future-proof

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56341/new/ https://reviews.llvm.org/D56341

[PATCH] D56350: [CMake][Fuchsia] Enable experimental new pass manager by default

This revision was automatically updated to reflect the committed changes. Closed by commit rC350461: [CMake][Fuchsia] Enable experimental new pass manager by default (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D56350?vs=180357=180360#toc Repository:

[PATCH] D56349: [CMake][Fuchsia] Enable x86 relaxation by default

This revision was automatically updated to reflect the committed changes. Closed by commit rC350460: [CMake][Fuchsia] Enable x86 relaxation by default (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D56349?vs=180356=180359#toc Repository: rC Clang

[PATCH] D56348: [CMake][Fuchsia] Enable --build-id linker flag by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL350459: [CMake][Fuchsia] Enable --build-id linker flag by default (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r350460 - [CMake][Fuchsia] Enable x86 relaxation by default

Author: phosek Date: Fri Jan 4 23:57:46 2019 New Revision: 350460 URL: http://llvm.org/viewvc/llvm-project?rev=350460=rev Log: [CMake][Fuchsia] Enable x86 relaxation by default This enables x86 relaxation by default. This depends on a linker new enough to support the new reloc types but since

r350461 - [CMake][Fuchsia] Enable experimental new pass manager by default

Author: phosek Date: Fri Jan 4 23:57:53 2019 New Revision: 350461 URL: http://llvm.org/viewvc/llvm-project?rev=350461=rev Log: [CMake][Fuchsia] Enable experimental new pass manager by default This change enableds experimental new pass manager. Differential Revision:

r350459 - [CMake][Fuchsia] Enable --build-id linker flag by default

Author: phosek Date: Fri Jan 4 23:57:38 2019 New Revision: 350459 URL: http://llvm.org/viewvc/llvm-project?rev=350459=rev Log: [CMake][Fuchsia] Enable --build-id linker flag by default This enables passing --build-id to linker by default. Differential Revision: https://reviews.llvm.org/D56348