[PATCH] D56824: [analyzer] MoveChecker: add ".assign" to the list of common reinitializing methods.

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. I think it is straightforward. Thank you for noticing this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56824/new/

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

erik.pilkington updated this revision to Diff 182214. erik.pilkington added a comment. Sure, that makes sense. The new patch makes the global constant again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56802/new/ https://reviews.llvm.org/D56802 Files:

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit marked 2 inline comments as done. tabloid.adroit added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:576-579 + Arg *FP = Args.getLastArg(options::OPT_fno_omit_frame_pointer, +options::OPT_fomit_frame_pointer); + Arg

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit updated this revision to Diff 182213. tabloid.adroit marked an inline comment as done. tabloid.adroit added a comment. Thanks for the review! - address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/

[PATCH] D56821: [CodeGen] Always use string computed in Sema for PredefinedExpr

rjmccall added a comment. I agree that this is the right thing to do. If we want to make those improvements, they're doable within Sema. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56821/new/ https://reviews.llvm.org/D56821

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

rjmccall added a comment. Emitting the global as `const` is probably still a good idea; if the global actually gets mapped as a constant, we'll end up making a dynamic assertion that we got the offset right. It's possible that the section will inhibit that, though. CHANGES SINCE LAST ACTION

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56816/new/ https://reviews.llvm.org/D56816

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On 16 Jan 2019, at 20:03, Richard Smith wrote: > On Wed, 16 Jan 2019 at 16:20, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On 16 Jan 2019, at 18:32, Richard Smith wrote: >> >>> On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits < >>> cfe-commits@lists.llvm.org>

[PATCH] D56825: [CMake][Fuchsia] Disable modules for the second stage build

This revision was automatically updated to reflect the committed changes. Closed by commit rL351415: [CMake][Fuchsia] Disable modules for the second stage build (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r351415 - [CMake][Fuchsia] Disable modules for the second stage build

Author: phosek Date: Wed Jan 16 20:12:30 2019 New Revision: 351415 URL: http://llvm.org/viewvc/llvm-project?rev=351415=rev Log: [CMake][Fuchsia] Disable modules for the second stage build This made the toolchain build 50% slower. Differential Revision: https://reviews.llvm.org/D56825 Modified:

[PATCH] D56825: [CMake][Fuchsia] Disable modules for the second stage build

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56825/new/ https://reviews.llvm.org/D56825 ___

[PATCH] D56825: [CMake][Fuchsia] Disable modules for the second stage build

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. This made the toolchain build 50% slower. Repository: rC Clang https://reviews.llvm.org/D56825 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index:

[PATCH] D56824: [analyzer] MoveChecker: add ".assign" to the list of common reinitializing methods.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Eg., `std::vector::assign(std::initializer_list)`. I wonder

[PATCH] D56823: [analyzer] Do not try to body-farm bodies for Objective-C properties with custom accessors.

NoQ created this revision. NoQ added reviewers: dcoughlin, george.karpenkov. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, kristof.beyls, xazax.hun, javed.absar. If a property is defined with a custom getter, we

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

EricWF added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "using class template argument deduction for %0 that has no user-defined deduction guides" >, + InGroup,

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

EricWF updated this revision to Diff 182206. EricWF marked 3 inline comments as done. EricWF added a comment. address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56731/new/ https://reviews.llvm.org/D56731 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D56821: [CodeGen] Always use string computed in Sema for PredefinedExpr

efriedma created this revision. efriedma added reviewers: rjmccall, rsmith. We can't use any other string, anyway, because its type wouldn't match the type of the PredefinedExpr. With this change, we don't compute a "nice" name for the __func__ global when it's used in the initializer for a

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly added a comment. Conditioning off of C++17 (or part C++11 and part C++17) seems reasonable, although we may want consistency with libc++ (discussion on https://reviews.llvm.org/D55840). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55741/new/

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

dexonsmith added a comment. In D56816#1360824 , @smeenai wrote: > My understanding is that rL349841 > accidentally started producing some spurious warnings/errors, rL350768 > fixed

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

smeenai added a comment. My understanding is that rL349841 accidentally started producing some spurious warnings/errors, rL350768 fixed some instances, and this change fixes more instances. Given that the first two changes

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On Wed, 16 Jan 2019 at 16:20, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 16 Jan 2019, at 18:32, Richard Smith wrote: > > > On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits < > > cfe-commits@lists.llvm.org> wrote: > > > >> On 16 Jan 2019, at 9:13, Aaron Ballman

[PATCH] D54604: Automatic variable initialization

pcc added inline comments. Comment at: cfe/trunk/include/clang/Driver/Options.td:1657 + " | pattern">, Values<"uninitialized,pattern">; +def enable_trivial_var_init_zero : Joined<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">, +

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

arphaman updated this revision to Diff 182191. arphaman added a comment. Follow Erik's suggestion and don't check for definition/declaration in parent class. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56816/new/ https://reviews.llvm.org/D56816 Files:

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

> On Jan 16, 2019, at 4:20 PM, John McCall via cfe-commits > wrote: > > > > On 16 Jan 2019, at 18:32, Richard Smith wrote: > >> On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> On 16 Jan 2019, at 9:13, Aaron Ballman wrote: >>>

[PATCH] D54604: Automatic variable initialization

jfb marked an inline comment as done. jfb added inline comments. Comment at: cfe/trunk/include/clang/Driver/Options.td:1657 + " | pattern">, Values<"uninitialized,pattern">; +def enable_trivial_var_init_zero : Joined<["-"],

r351408 - [X86] Add custom emission for the avx512 scatter builtins to convert from scalar integer to vXi1 for the mask arguments to the intrinsics.

Author: ctopper Date: Wed Jan 16 16:34:19 2019 New Revision: 351408 URL: http://llvm.org/viewvc/llvm-project?rev=351408=rev Log: [X86] Add custom emission for the avx512 scatter builtins to convert from scalar integer to vXi1 for the mask arguments to the intrinsics. Modified:

[PATCH] D56766: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction.

vsapsai added a comment. Thanks for the review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56766/new/ https://reviews.llvm.org/D56766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56766: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351402: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction. (authored by vsapsai, committed by ). Changed prior to commit:

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

erik.pilkington added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:7374-7378 + (MD->isDefined() || + (MD->getClassInterface() && +MD->getClassInterface()->getSuperClass() && +

r351402 - [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction.

Author: vsapsai Date: Wed Jan 16 16:20:43 2019 New Revision: 351402 URL: http://llvm.org/viewvc/llvm-project?rev=351402=rev Log: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction. Fixes `-emit-header-module` when GenerateHeaderModuleAction is wrapped by another

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On 16 Jan 2019, at 18:32, Richard Smith wrote: > On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On 16 Jan 2019, at 9:13, Aaron Ballman wrote: >> >>> On Wed, Jan 16, 2019 at 1:57 AM Akira Hatanaka >>> wrote: Yes, the behavior of

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

erik.pilkington updated this revision to Diff 182182. erik.pilkington added a comment. Address review comments: move the check to a function, and call it when emitting the ivar offset instead of when we emit the global. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56802/new/

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

jwakely added a comment. The simplest solution would be to change libstdc++'s `` to: #if __cplusplus >= 201703L && __cpp_impl_destroying_delete #define __cpp_lib_destroying_delete 201806L Or we could be fancier and do: #if __cplusplus >= 201103L && __cpp_impl_destroying_delete

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "using class template

[PATCH] D54604: Automatic variable initialization

pcc added inline comments. Comment at: cfe/trunk/include/clang/Driver/Options.td:1657 + " | pattern">, Values<"uninitialized,pattern">; +def enable_trivial_var_init_zero : Joined<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">, +

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 16 Jan 2019, at 9:13, Aaron Ballman wrote: > > > On Wed, Jan 16, 2019 at 1:57 AM Akira Hatanaka > > wrote: > >> > >> Yes, the behavior of the compiler doesn’t match what’s explained > >> in the

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

steveire added a comment. It seems that you update docs for existing matchers without changing those matchers. You could put all of that in one patch. Then, you seem to add some tests for existing matches. You could put that in the second patch. Then your third patch would add the new matcher

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

rsmith added a comment. @jwakely, we should come to a common understanding of the right behavior here :) (and then probably report back to SG-10). Clang unconditionally makes sized delete work if you have a suitable library type, and expects the library to decide whether it wants to provide

[PATCH] D56759: [analyzer] Another RetainCountChecker cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit rC351394: [analyzer] Another RetainCountChecker cleanup (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r351394 - [analyzer] Another RetainCountChecker cleanup

Author: george.karpenkov Date: Wed Jan 16 15:21:38 2019 New Revision: 351394 URL: http://llvm.org/viewvc/llvm-project?rev=351394=rev Log: [analyzer] Another RetainCountChecker cleanup This is not NFC strictly speaking, since it unifies CleanupAttr handling, so that out parameters now also

r351393 - [analyzer] [NFC] Yet another minor cleanup of RetainCountChecker

Author: george.karpenkov Date: Wed Jan 16 15:21:15 2019 New Revision: 351393 URL: http://llvm.org/viewvc/llvm-project?rev=351393=rev Log: [analyzer] [NFC] Yet another minor cleanup of RetainCountChecker Differential Revision: https://reviews.llvm.org/D56744 Modified:

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

arphaman created this revision. arphaman added a reviewer: erik.pilkington. Herald added subscribers: cfe-commits, dexonsmith, jkorous. This patch extends r350768 and allows the use of methods marked as `unavailable` that are declared in a parent class/category from within the `@implementation`

[PATCH] D56006: [AST] Fix a -Wimplicit-fallthrough warning in ScanfFormatString.cpp

riccibruno abandoned this revision. riccibruno added a comment. Nice, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56006/new/ https://reviews.llvm.org/D56006 ___ cfe-commits mailing list

r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

Author: ctopper Date: Wed Jan 16 14:56:25 2019 New Revision: 351391 URL: http://llvm.org/viewvc/llvm-project?rev=351391=rev Log: Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms" V8 has been fixed now. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

sberg added a comment. One problem I found with the macro `__cpp_impl_destroying_delete` not being conditional on language version is the following: Recent GCC trunk (since https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=76b94d4ba654e9af1882865933343d11f5c3b18b "Implement P0722R3, destroying

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

dexonsmith added a comment. In D56802#1360316 , @rjmccall wrote: > We've tossed around the idea of doing things like this before, but I was > hoping that it wouldn't have to be specific to `NSObject` and that we'd e.g. > have an attribute that

[PATCH] D56530: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar (clang side)

This revision was automatically updated to reflect the committed changes. Closed by commit rC351390: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1… (authored by ctopper, committed by ). Changed prior to commit:

r351390 - [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar

Author: ctopper Date: Wed Jan 16 14:34:33 2019 New Revision: 351390 URL: http://llvm.org/viewvc/llvm-project?rev=351390=rev Log: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar We need to custom handle these so we can turn the scalar

[PATCH] D56766: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. That LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56766/new/ https://reviews.llvm.org/D56766 ___ cfe-commits mailing list

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht planned changes to this revision. rupprecht added a comment. I'll refactor `getLLVMStyle()` to `getLLVMStyle(FormatStyle::LanguageKind Language)` to support this change first. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/

Re: r350768 - [ObjC] Allow the use of implemented unavailable methods from within

Hi, We are planning to fix this issue by not checking if the method is defined. I will post a patch this week. Cheers, Alex On Fri, 11 Jan 2019 at 10:26, Alex L wrote: > Thanks, we might have similar cases in our code base as well. We'll see if > we can fix that too. > > On Fri, 11 Jan 2019

[PATCH] D56811: [Mem2Reg] Enable promotion for bitcastable load/store values

sdmitriev added a comment. This patch is a clang's part of this review https://reviews.llvm.org/D56810 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56811/new/ https://reviews.llvm.org/D56811 ___ cfe-commits mailing

[PATCH] D56811: [Mem2Reg] Enable promotion for bitcastable load/store values

lebedev.ri added a comment. The diff does not seem to match the subject. (also, probably should go do llvm-commits) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56811/new/ https://reviews.llvm.org/D56811 ___

[PATCH] D56811: [Mem2Reg] Enable promotion for bitcastable load/store values

sdmitriev created this revision. sdmitriev added a reviewer: andrew.w.kaylor. Herald added subscribers: cfe-commits, javed.absar. This patch enables Mem2Reg to handle loads/stores from/to bitcasted alloca values as long as the loaded/stored value is bitcastable to the allocated type (see example

r351383 - Fix libc++ mac driver test to pass on Windows

Author: rnk Date: Wed Jan 16 14:05:34 2019 New Revision: 351383 URL: http://llvm.org/viewvc/llvm-project?rev=351383=rev Log: Fix libc++ mac driver test to pass on Windows There is a substitution for 'clang-check' to absolutize it, so the '$(which clang-check)' is unnecessary. Modified:

r351382 - PR40329: [adl] Fix determination of associated classes when searching a

Author: rsmith Date: Wed Jan 16 14:01:39 2019 New Revision: 351382 URL: http://llvm.org/viewvc/llvm-project?rev=351382=rev Log: PR40329: [adl] Fix determination of associated classes when searching a member enum and then its enclosing class. There are situations where ADL will collect a class

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

NoQ added a comment. In D56632#1359576 , @xazax.hun wrote: > If you find out the reason why we need `markElementIndicesLive`, documenting > that would also be useful. But it is also independent of this change. > Maybe something like we could learn new

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added a comment. In D56424#1360318 , @MyDeveloperDay wrote: > In D56424#1359227 , @karepker wrote: > > > In D56424#1357484 , > > @MyDeveloperDay wrote: > > > > >

[PATCH] D56530: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar (clang side)

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56530/new/ https://reviews.llvm.org/D56530 ___ cfe-commits mailing list

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added a comment. In D56424#1359227 , @karepker wrote: > In D56424#1357484 , @MyDeveloperDay > wrote: > > > In D56424#1357481 , @lebedev.ri > > wrote: > > >

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

rjmccall added a comment. Also, we should just go ahead and skip using the offset variable when emitting the ivar access in the frontend. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56802/new/ https://reviews.llvm.org/D56802

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

rjmccall added a comment. We've tossed around the idea of doing things like this before, but I was hoping that it wouldn't have to be specific to `NSObject` and that we'd e.g. have an attribute that guarantees that the `@interface` declares all the ivars for a class. Are we still thinking

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: ddunbar. It has been introduced in 2011 for gcc compat: https://github.com/llvm-mirror/clang/commit/95a907fc0f2f717dca38a379c1d2353bfea06d4f it is probably time to remove it to remove the confusion. Repository: rC Clang

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, pete, ahatanak. Herald added subscribers: dexonsmith, jkorous. This patch was originally written by Pete Cooper. This is possible because the size of NSObject is effectively ABI, and will not change in the future.

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6170 + } +} + } Does this not need to diagnose redundant qualifiers? Why is this path required in addition to the path in SemaType, anyway? Comment at:

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 182121. dankm added a comment. Move trailing path separator stripping back to Clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 Files:

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

gtbercea added a comment. Could we add the changes in D56790 to this diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 ___ cfe-commits mailing list

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL351371: [Fixed Point Arithmetic] Fixed Point Subtraction (authored by leonardchan, committed by ). Herald added a

r351371 - [Fixed Point Arithmetic] Fixed Point Subtraction

Author: leonardchan Date: Wed Jan 16 11:53:50 2019 New Revision: 351371 URL: http://llvm.org/viewvc/llvm-project?rev=351371=rev Log: [Fixed Point Arithmetic] Fixed Point Subtraction This patch covers subtraction between fixed point types and other fixed point types or integers, using the

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

mgrang abandoned this revision. mgrang added a comment. I have added a default lowering for llvm.eh.recoverfp in D53540 . So this patch is no longer needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53541/new/ https://reviews.llvm.org/D53541

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

rjmccall added a comment. I don't pay attention to "ready to land" because I assume that you're verifying that your patch actually works as promised in practice, at least as far as the tests are concerned (and presumably my review catches deeper issues). If there are substantial changes that

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3451 + case BO_Comma: +llvm_unreachable("Found unimplemented fixed point binary operation"); } rjmccall wrote: > Please create a separate case for the non-arithmetic

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

leonardchan updated this revision to Diff 182108. leonardchan marked 2 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55844/new/ https://reviews.llvm.org/D55844 Files: clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space conversions

rjmccall added a comment. Thanks, LGTM. Well, actually, could you improve the test case to verify that the right overload is called? This should be easy because C++ type-checking is bottom-up: just make the functions return something distinguishable, e.g. `struct`s that declare different

[PATCH] D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue

This revision was automatically updated to reflect the committed changes. Closed by commit rC351368: [Fixed Point Arithmetic] Add APFixedPoint to APValue (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D56746?vs=181918=182103#toc Repository: rC

r351368 - [Fixed Point Arithmetic] Add APFixedPoint to APValue

Author: leonardchan Date: Wed Jan 16 10:53:05 2019 New Revision: 351368 URL: http://llvm.org/viewvc/llvm-project?rev=351368=rev Log: [Fixed Point Arithmetic] Add APFixedPoint to APValue This adds APFixedPoint to the union of values that can be represented with an APValue. Differential

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182102. ilya-biryukov added a comment. - Fix a typo in the id of the SwapIfBranches Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clangd/CMakeLists.txt

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

> > Unfortunately this trips up a variety of buildbots: > Platform REQUIRES added in r351360, please do revert & fix if this test is supposed to work elsewhere. Looks like the test fail just made it into the release-8.0.0 branch by a few commits. I think we'll need Jeremy's fix r351360 or/and

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

ymandel marked 2 inline comments as done. ymandel added a comment. In D56786#1359920 , @lebedev.ri wrote: > In D56786#1359903 , @ymandel wrote: > > > In D56786#1359879 ,

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

This revision was automatically updated to reflect the committed changes. Closed by commit rL351364: [Fixed Point Arithmetic] Fixed Point Addition (authored by leonardchan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r351364 - [Fixed Point Arithmetic] Fixed Point Addition

Author: leonardchan Date: Wed Jan 16 10:13:59 2019 New Revision: 351364 URL: http://llvm.org/viewvc/llvm-project?rev=351364=rev Log: [Fixed Point Arithmetic] Fixed Point Addition This patch covers addition between fixed point types and other fixed point types or integers, using the conversion

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In D53738#1359135 , @rjmccall wrote: > I think that's the right direction, yeah. > > I thought I told you it was fine to commit this patch under that assumption > awhile ago. Did I just never click "accept"? Whoops. I

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 182092. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h

Re: r344241 - [tests] Include Python binding tests in CMake rules

(Follow-up: Michał landed a fix in r351304. Thanks!) On Tue, Jan 15, 2019 at 1:21 PM Nico Weber wrote: > As long as check-all passes with LLVM_ENABLE_PIC=OFF I'm happy :-) (Note > it's .dylib on macOS and .dll on Windows, and by default > setting LLVM_ENABLE_PIC=OFF causes a static library to

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

shafik added a comment. Thank you, this looks good but perhaps some refactoring would help improve the change. Comment at: lib/AST/ASTImporter.cpp:3243 + + if (R) { +CXXDestructorDecl *ToDtor = cast(*R); a_sidorin wrote: > It's better to move this code

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space conversions

Anastasia updated this revision to Diff 182084. Anastasia added a comment. - Changed the condition to use all qualifiers except for ObjC ownership ones. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56735/new/ https://reviews.llvm.org/D56735 Files: lib/Sema/SemaOverload.cpp

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov added inline comments. Comment at: clangd/SourceCode.h:64 +/// Turns a token range into a half-open range and checks its correctness. +/// The resulting range will have only valid source location on both sides, both jkorous wrote: > It seems to

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

Platform REQUIRES added in r351360, please do revert & fix if this test is supposed to work elsewhere. -- Thanks, Jeremy ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov updated this revision to Diff 182082. ilya-biryukov added a comment. - Update after changes to parent revision Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56612/new/ https://reviews.llvm.org/D56612 Files: clangd/AST.cpp

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182080. ilya-biryukov added a comment. - Update after changes to parent revision Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clangd/CMakeLists.txt

r351360 - Add a REQUIRES: darwin line for a mac test.

Author: jmorse Date: Wed Jan 16 09:41:29 2019 New Revision: 351360 URL: http://llvm.org/viewvc/llvm-project?rev=351360=rev Log: Add a REQUIRES: darwin line for a mac test. This test, apparently for macs, fails on Windows as lit can't emulate the shell subprocess $(which...) correctly. Some other

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov updated this revision to Diff 182079. ilya-biryukov added a comment. - Update after changes to parent revision Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 Files: clangd/CMakeLists.txt

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov updated this revision to Diff 182078. ilya-biryukov added a comment. Herald added a subscriber: mgrang. - Rename ActionProvider to Tweak - Update an interface of Tweak - ActionInputs -> Tweak::Selection - Remove CodeAction.h, use tweak registry instead Repository: rCTE Clang

[PATCH] D56792: Rename getTypeQualifiers to getMethodQualifiers

rjmccall accepted this revision. rjmccall added a reviewer: rsmith. rjmccall added a comment. LGTM, but I'd like Richard to also sign off on the name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56792/new/ https://reviews.llvm.org/D56792

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

We do rather need this working for our downstream merging to continue, and to clear up the buildbots -- without objection I'll drop the "REQUIRES: system-darwin" line in there. Depending on what's actually supposed to be tested that might be sufficient, but please do follow up. -- Thanks, Jeremy

[PATCH] D56790: [OpenMP] Update release notes with OpenMP related changes

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, but you need to commit it into release 8.0 Comment at: docs/ReleaseNotes.rst:261 + +- Flag for user to limit collapsed loop counter width when safe to do so. +

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. I think the diagnostic should come during instantiation when you find an evaluated use of a host function within a device function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56411/new/ https://reviews.llvm.org/D56411

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space conversions

rjmccall added a comment. In D56735#1359590 , @Anastasia wrote: > In D56735#1358222 , @rjmccall wrote: > > > Is there a reason not to just do `T1.getQualifiers() == T2.getQualifiers()`? > > > I tried this but it

[PATCH] D56792: Rename getTypeQualifiers to getMethodQualifiers

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added subscribers: arphaman, eraman. Use more descriptive name for the method qualifiers getter. This change was suggested in https://reviews.llvm.org/D56066?id=179477#inline-496961 https://reviews.llvm.org/D56792

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

steveire added a comment. It is always valuable to split changes which are independent. Usually you can extract NFC changes first and then look at what remains to split it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56786/new/ https://reviews.llvm.org/D56786

  1   2   >