r351634 - Convert two more files that were using Windows line endings and remove

Author: chandlerc Date: Fri Jan 18 22:36:08 2019 New Revision: 351634 URL: http://llvm.org/viewvc/llvm-project?rev=351634=rev Log: Convert two more files that were using Windows line endings and remove a stray single '\r' from one file. These are the last line ending issues I can find in the

[clang-tools-extra] r351634 - Convert two more files that were using Windows line endings and remove

Author: chandlerc Date: Fri Jan 18 22:36:08 2019 New Revision: 351634 URL: http://llvm.org/viewvc/llvm-project?rev=351634=rev Log: Convert two more files that were using Windows line endings and remove a stray single '\r' from one file. These are the last line ending issues I can find in the

r351633 - Remove random windows line endings that snuck into the middle of this

Author: chandlerc Date: Fri Jan 18 22:36:00 2019 New Revision: 351633 URL: http://llvm.org/viewvc/llvm-project?rev=351633=rev Log: Remove random windows line endings that snuck into the middle of this code. Modified: cfe/trunk/lib/Lex/PPDirectives.cpp Modified:

[clang-tools-extra] r351632 - Update some code used in our visual studio plugins to use linux file

Author: chandlerc Date: Fri Jan 18 22:29:07 2019 New Revision: 351632 URL: http://llvm.org/viewvc/llvm-project?rev=351632=rev Log: Update some code used in our visual studio plugins to use linux file endings. We already used them in some cases, and this makes things consistent. This will also

r351632 - Update some code used in our visual studio plugins to use linux file

Author: chandlerc Date: Fri Jan 18 22:29:07 2019 New Revision: 351632 URL: http://llvm.org/viewvc/llvm-project?rev=351632=rev Log: Update some code used in our visual studio plugins to use linux file endings. We already used them in some cases, and this makes things consistent. This will also

[libclc] r351631 - Install new LLVM license structure and new developer policy.

Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects in

r351631 - Install new LLVM license structure and new developer policy.

Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects in

[libunwind] r351631 - Install new LLVM license structure and new developer policy.

Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects in

[clang-tools-extra] r351631 - Install new LLVM license structure and new developer policy.

Author: chandlerc Date: Fri Jan 18 22:14:24 2019 New Revision: 351631 URL: http://llvm.org/viewvc/llvm-project?rev=351631=rev Log: Install new LLVM license structure and new developer policy. This installs the new developer policy and moves all of the license files across all LLVM projects in

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

This revision was automatically updated to reflect the committed changes. Closed by commit rL351629: Emit !callback metadata and introduce the callback attribute (authored by jdoerfert, committed by ). Changed prior to commit: https://reviews.llvm.org/D55483?vs=181631=182665#toc Repository:

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore updated this revision to Diff 182660. stephanemoore marked 2 inline comments as done. stephanemoore added a comment. Use :option: prefix for options in release notes. Add missing space in check reference in release notes. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:248 +- The `Acronyms` and `IncludeDefaultAcronyms` options for the + :doc:`objc-property-declaration` Please rebase from trunk and use :option: prefix for options..

[PATCH] D56946: [Documentation] Use HTTPS whenever possible in Clang

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: sylvestre.ledru, hans. Eugene.Zelenko added a project: clang. Repository: rC Clang https://reviews.llvm.org/D56946 Files: llvm-svn.src/tools/clang/docs/AutomaticReferenceCounting.rst

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly added a comment. In D55741#1361040 , @jwakely wrote: > I'd be happy to restrict this to > C++17 only (which is automatically the > case when using G++ because there's no `-fdestroying-delete` to enable it, > you only get it with `-std=c++2a`,

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore created this revision. stephanemoore added reviewers: benhamilton, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. The `Acronyms` and `IncludeDefaultAcronyms` options were deprecated in https://reviews.llvm.org/D51832. These options can be removed. Tested by

[PATCH] D56829: Move decl context dumping to TextNodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! At some point, we may want to revisit how we dump `TranslationUnitDecl` to make it a bit less inscrutable (I have no idea what those "invalid sloc" strings are telling me). At that point, we may want to turn `` into

[PATCH] D45978: dllexport const variables must have external linkage.

rnk added a comment. I still feel like there has to be a more uniform way to handle this. Basically anything with __declspec(dllexport) on it is effectively upgraded to external linkage. Comment at: lib/Sema/SemaDeclAttr.cpp:6491 + if (auto *VD = dyn_cast(D)) { +if

[PATCH] D56899: [analyzer] pr37688: Fix a crash on trying to evaluate a deleted destructor of a union.

This revision was automatically updated to reflect the committed changes. Closed by commit rL351610: [analyzer] pr37688: Fix a crash upon evaluating a deleted destructor of a union. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r351610 - [analyzer] pr37688: Fix a crash upon evaluating a deleted destructor of a union.

Author: dergachev Date: Fri Jan 18 15:05:07 2019 New Revision: 351610 URL: http://llvm.org/viewvc/llvm-project?rev=351610=rev Log: [analyzer] pr37688: Fix a crash upon evaluating a deleted destructor of a union. Add a defensive check against an invalid destructor in the CFG. Unions with fields

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

a_sidorin added a comment. Hi Shafik, Please find my answers inline. Comment at: lib/AST/ASTImporter.cpp:3243 + + if (R) { +CXXDestructorDecl *ToDtor = cast(*R); shafik wrote: > a_sidorin wrote: > > It's better to move this code to VisitFunctionDecl to

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56892/new/ https://reviews.llvm.org/D56892

[PATCH] D56823: [analyzer] Do not try to body-farm bodies for Objective-C properties with custom accessors.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351609: [analyzer] Do not try to body-farm Objective-C properties with custom accessors. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION

r351609 - [analyzer] Do not try to body-farm Objective-C properties with custom accessors.

Author: dergachev Date: Fri Jan 18 14:52:13 2019 New Revision: 351609 URL: http://llvm.org/viewvc/llvm-project?rev=351609=rev Log: [analyzer] Do not try to body-farm Objective-C properties with custom accessors. If a property is defined with a custom getter, we should not behave as if the getter

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

arphaman added a comment. In D56892#1363089 , @aaron.ballman wrote: > I think the documentation for the attribute should be updated to explain this > new behavior, otherwise this will be a very inexplicable feature to users. Done > One question I

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

arphaman updated this revision to Diff 182608. arphaman marked 3 inline comments as done. arphaman added a comment. - Add documentation and expand a comment as suggested by Aaron. - Address Erik's comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56892/new/

[PATCH] D56899: [analyzer] pr37688: Fix a crash on trying to evaluate a deleted destructor of a union.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. The code is fine, but I obviously would prefer a proper fix in a CFG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56899/new/

[PATCH] D56829: Move decl context dumping to TextNodeDumper

steveire updated this revision to Diff 182607. steveire marked an inline comment as done. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56829/new/ https://reviews.llvm.org/D56829 Files: lib/AST/ASTDumper.cpp

[PATCH] D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

sdardis added inline comments. Comment at: cfe/trunk/include/clang/Driver/Options.td:2423 + Group, + HelpText<"Try turning PIC calls (j{al}r{c} $25) into direct calls " + "(MIPS only)">, Flags<[HelpHidden]>; I think this help text could be a little better.

r351605 - [ASTDump] NFC: Move variable into if() statement

Author: steveire Date: Fri Jan 18 14:15:09 2019 New Revision: 351605 URL: http://llvm.org/viewvc/llvm-project?rev=351605=rev Log: [ASTDump] NFC: Move variable into if() statement Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

r351603 - [ASTDump] NFC: Remove non-needed braces

Author: steveire Date: Fri Jan 18 14:14:59 2019 New Revision: 351603 URL: http://llvm.org/viewvc/llvm-project?rev=351603=rev Log: [ASTDump] NFC: Remove non-needed braces Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

r351606 - [ASTDump] Add test for current AST dump behavior

Author: steveire Date: Fri Jan 18 14:15:13 2019 New Revision: 351606 URL: http://llvm.org/viewvc/llvm-project?rev=351606=rev Log: [ASTDump] Add test for current AST dump behavior Added: cfe/trunk/test/AST/ast-dump-undeserialized.cpp Added: cfe/trunk/test/AST/ast-dump-undeserialized.cpp URL:

r351604 - [ASTDump] NFC: Remove redundant condition

Author: steveire Date: Fri Jan 18 14:15:05 2019 New Revision: 351604 URL: http://llvm.org/viewvc/llvm-project?rev=351604=rev Log: [ASTDump] NFC: Remove redundant condition These conditions are duplicated from the dumpDeclContext function called within the if(). This is presumably an attempt to

[PATCH] D56936: Fix handling of overriden methods during ASTImport

shafik added a comment. @martong the only issue is that I am seeing a regression on `Analysis/ctu-main.cpp` when I run `check-clang`. I am going to look into it but if you have any insights that would be helpful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56936/new/

[PATCH] D56936: Fix handling of overriden methods during ASTImport

shafik created this revision. shafik added reviewers: martong, teemperor, balazske, aaron.ballman. Herald added a subscriber: rnkovacs. When importing classes we may add a CXXMethodDecl more than once to a CXXRecordDecl. This patch will fix the cases we currently know about and handle both the

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

This revision was automatically updated to reflect the committed changes. Closed by commit rL351601: [ASTDump] Mark null params with a tag rather than a child node (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r351601 - [ASTDump] Mark null params with a tag rather than a child node

Author: steveire Date: Fri Jan 18 14:00:16 2019 New Revision: 351601 URL: http://llvm.org/viewvc/llvm-project?rev=351601=rev Log: [ASTDump] Mark null params with a tag rather than a child node Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision:

[PATCH] D56752: [ASTDump] Mark BlockDecls which capture this with a tag

This revision was automatically updated to reflect the committed changes. Closed by commit rL351600: [ASTDump] Mark BlockDecls which capture this with a tag (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r351600 - [ASTDump] Mark BlockDecls which capture this with a tag

Author: steveire Date: Fri Jan 18 13:55:24 2019 New Revision: 351600 URL: http://llvm.org/viewvc/llvm-project?rev=351600=rev Log: [ASTDump] Mark BlockDecls which capture this with a tag Summary: Removal of the child node makes it easier to separate traversal from output generation. Reviewers:

[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

erik.pilkington added a comment. This seems pretty reasonable to me. I agree that a more general mechanism to override #pca (/implicit) attributes would be pretty useful, but I guess there is no need to jump the gun on that. Comment at: include/clang/Sema/Sema.h:2471 +

[PATCH] D56751: [ASTDump] Mark variadic declarations with a tag instead of child node

This revision was automatically updated to reflect the committed changes. Closed by commit rC351597: [ASTDump] Mark variadic declarations with a tag instead of child node (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56751?vs=181904=182598#toc

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

steveire added a comment. Thanks, do you need someone to commit this for you? Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:492 + auto MatchesX = cxxMemberCallExpr(on(hasType(cxxRecordDecl(hasName("X"); + EXPECT_TRUE(notMatches(Snippet1,

r351597 - [ASTDump] Mark variadic declarations with a tag instead of child node

Author: steveire Date: Fri Jan 18 13:38:30 2019 New Revision: 351597 URL: http://llvm.org/viewvc/llvm-project?rev=351597=rev Log: [ASTDump] Mark variadic declarations with a tag instead of child node Summary: This makes it easier to separate traversal of the AST from output generation.

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Thanks for the feedback! Does this mean that this won't be accepted? In my opinion, without these extra options, `AllowAllParametersOfDeclarationOnNextLine` is a very strange option. I don't think I'm the only one who feels this way, based on the stack overflow

[PATCH] D56933: [Tooling][RFC] Introduce Stencil library to simplify source code generation in refactorings.

ymandel created this revision. Herald added subscribers: cfe-commits, jfb. REQUEST FOR COMMENT: this is not intended (yet) as a proper revision. It complements the design document for Transformer: https://docs.google.com/document/d/1ppw0RhjwsrbBcHYhI85pe6ISDbA6r5d00ot3N8cQWeQ/edit?usp=sharing

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. Thanks for the feedback! This actually isn't a new formatting option, rather it's fixing a bug where clang-format would change lines outside of the line range asked for by the user. This was preventing us from using clang-format in an automated setting. CHANGES

[PATCH] D56879: [Sema] Suppress a warning about a forward-declared fixed enum in C mode

This revision was automatically updated to reflect the committed changes. Closed by commit rC351595: [Sema] Suppress a warning about a forward-declared fixed enum in C mode (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56879?vs=182548=182597#toc

[PATCH] D56932: [Driver] [NetBSD] Pass default library search paths to linker

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, ruiu, chandlerc, rsmith. Pass library search paths to linker as -L options, similarly to how other toolchain drivers do it. This fixes compatibility with vanilla LLD. Bug report:

r351595 - [Sema] Suppress a warning about a forward-declared fixed enum in C mode

Author: epilk Date: Fri Jan 18 13:33:23 2019 New Revision: 351595 URL: http://llvm.org/viewvc/llvm-project?rev=351595=rev Log: [Sema] Suppress a warning about a forward-declared fixed enum in C mode As of r343360, we support fixed-enums in C. This lead to some warnings in project headers where a

[PATCH] D56823: [analyzer] Do not try to body-farm bodies for Objective-C properties with custom accessors.

NoQ added a comment. Nope, it doesn't seem to skew results at all. I hope my testing machinery is actually working :/ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56823/new/ https://reviews.llvm.org/D56823 ___

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rC351593: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation (authored by leonardchan, committed by ). Changed prior to commit:

r351593 - [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

Author: leonardchan Date: Fri Jan 18 13:04:25 2019 New Revision: 351593 URL: http://llvm.org/viewvc/llvm-project?rev=351593=rev Log: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation This patch includes logic for constant expression evaluation of fixed point

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

Eugene.Zelenko updated this revision to Diff 182590. Eugene.Zelenko added a comment. Don't use HTTPS for www.codingstandard.com Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56926/new/ https://reviews.llvm.org/D56926 Files:

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

JonasToth added a comment. In D56926#1363648 , @MyDeveloperDay wrote: > the closest I can see is > > https://www.perforce.com/resources/qac/high-integrity-cpp-coding-standard#statements > > which take you to section 6 of the standard, but I see no id or

r351588 - Fix MSVC "not all control paths return a value" warning. NFCI.

Author: rksimon Date: Fri Jan 18 12:40:35 2019 New Revision: 351588 URL: http://llvm.org/viewvc/llvm-project?rev=351588=rev Log: Fix MSVC "not all control paths return a value" warning. NFCI. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp

[PATCH] D56905: [libunwind] [SjLj] Don't use __declspec(thread) in MinGW mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL351587: [SjLj] Dont use __declspec(thread) in MinGW mode (authored by mstorsjo, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit:

[libunwind] r351587 - [SjLj] Don't use __declspec(thread) in MinGW mode

Author: mstorsjo Date: Fri Jan 18 12:31:12 2019 New Revision: 351587 URL: http://llvm.org/viewvc/llvm-project?rev=351587=rev Log: [SjLj] Don't use __declspec(thread) in MinGW mode GCC and Clang in MinGW mode don't support __declspec(thread), which after expanding macros ends up as

[PATCH] D56928: Support attribute used in member funcs of class templates

rafauler updated this revision to Diff 182581. rafauler added a comment. Removing facebook tags Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56928/new/ https://reviews.llvm.org/D56928 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp

[PATCH] D56928: Support attribute used in member funcs of class templates

rafauler created this revision. rafauler added reviewers: rsmith, ldionne. As PR17480 describes, clang does not support the used attribute for member functions of class templates. This means that if the member function is not used, its definition is never instantiated. This patch changes clang to

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

MyDeveloperDay added a comment. the closest I can see is https://www.perforce.com/resources/qac/high-integrity-cpp-coding-standard#statements which take you to section 6 of the standard, but I see no id or name tags to get you to 6.3.1 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

MyDeveloperDay added inline comments. Comment at: llvm-svn.src/tools/clang/tools/extra/docs/clang-tidy/checks/cppcoreguidelines-avoid-goto.rst:11 from the CppCoreGuidelines and -`6.3.1 from High Integrity C++

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. very good idea. This reminds me, that i wanted to fix the hicpp links, as they restructured their website. thanks ;) Changes LGTM! Repository: rCTE Clang Tools Extra CHANGES SINCE

[PATCH] D56927: Disable PIC/PIE for MSP430 target

dmikushin created this revision. dmikushin added a reviewer: asl. Herald added a subscriber: cfe-commits. Relocatable code generation is meaningless on MSP430, as the platform is too small to use shared libraries. Repository: rC Clang https://reviews.llvm.org/D56927 Files:

[PATCH] D56905: [libunwind] [SjLj] Don't use __declspec(thread) in MinGW mode

mclow.lists accepted this revision. mclow.lists added a comment. Sigh. At least we've got a macro wrapping this; we only have to pore over this once. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56905/new/ https://reviews.llvm.org/D56905

[PATCH] D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman, JonasToth, MyDeveloperDay, juliehockett, lebedev.ri. Eugene.Zelenko added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, kbarton, nemanjai. Repository: rCTE Clang Tools

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

This revision was automatically updated to reflect the committed changes. Closed by commit rL351580: [OPENMP][DOCS] Release notes/OpenMP support updates, NFC. (authored by kli, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r351580 - [OPENMP][DOCS] Release notes/OpenMP support updates, NFC.

Author: kli Date: Fri Jan 18 11:57:37 2019 New Revision: 351580 URL: http://llvm.org/viewvc/llvm-project?rev=351580=rev Log: [OPENMP][DOCS] Release notes/OpenMP support updates, NFC. Differential Revision: https://reviews.llvm.org/D56733 Modified: cfe/trunk/docs/OpenMPSupport.rst

[PATCH] D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

This revision was automatically updated to reflect the committed changes. Closed by commit rL351579: [mips] Add -mrelax-pic-calls, -mno-relax-pic-calls (authored by vstefanovic, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56925: Do not use frame pointer by default for MSP430

dmikushin created this revision. Herald added a subscriber: cfe-commits. dmikushin added a reviewer: asl. > 3.3.9 Frame Pointer > MSP430 does not use a frame pointer. This effectively limits a single call > frame to 0x7fff bytes, which is the minimum SP offset supported by any > instruction

r351579 - [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

Author: vstefanovic Date: Fri Jan 18 11:54:51 2019 New Revision: 351579 URL: http://llvm.org/viewvc/llvm-project?rev=351579=rev Log: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls' These two options enable/disable emission of R_{MICRO}MIPS_JALR fixups along with PIC calls. The linker may

r351576 - [NFC] Fix wParentheses warning in ASTContext getFixedPointSemantics

Author: erichkeane Date: Fri Jan 18 11:31:54 2019 New Revision: 351576 URL: http://llvm.org/viewvc/llvm-project?rev=351576=rev Log: [NFC] Fix wParentheses warning in ASTContext getFixedPointSemantics Change-Id: I862f00a548236872fe24f7da8eb2bf7917e123ff Modified:

[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print

dgoldman created this revision. Herald added a subscriber: cfe-commits. Since class extensions do not have a name, (class extension) is used instead. Repository: rC Clang https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp Index: lib/AST/Decl.cpp

r351575 - Revert "Fix failing MSan bots"

Author: george.karpenkov Date: Fri Jan 18 11:24:55 2019 New Revision: 351575 URL: http://llvm.org/viewvc/llvm-project?rev=351575=rev Log: Revert "Fix failing MSan bots" This reverts commit 2cedaaef383d8d6142046074ffebc2bb5a914778. Revert with a fix. Added:

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55850/new/ https://reviews.llvm.org/D55850 ___ cfe-commits mailing list

Re: r351514 - [analyzer] Introduce proper diagnostic for freeing unowned object

OK thanks - I’ll fix it. > On Jan 18, 2019, at 12:47 AM, Vlad Tsyrklevich wrote: > > Hi, I've reverted r351508-351514 as they were causing MSan failures on the > sanitizer bots. It looks like isLeak is not initialized by one of the > RefCountReport constructors and it is not immediately

[PATCH] D56879: [Sema] Suppress a warning about a forward-declared fixed enum in C mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Sema/fixed-enum.c:4 // RUN: %clang_cc1 -Weverything -xobjective-c -DOBJC -verify %s // RUN: %clang_cc1 -Weverything -std=c11 -xc

[PATCH] D56905: [libunwind] [SjLj] Don't use __declspec(thread) in MinGW mode

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56905/new/ https://reviews.llvm.org/D56905 ___ cfe-commits

[PATCH] D56868: Add -fapply-global-visibility-to-externs for -cc1

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, I appreciate you bearing with me on this. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56868/new/ https://reviews.llvm.org/D56868

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

dgoldman updated this revision to Diff 182562. dgoldman marked an inline comment as done. dgoldman added a comment. - FIXME and dyn_cast Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56916/new/ https://reviews.llvm.org/D56916 Files:

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/CodeGen/builtins-arm64.c:2 // RUN: %clang_cc1 -triple arm64-unknown-linux -disable-O0-optnone -emit-llvm -o - %s | opt -S -mem2reg | FileCheck %s

r351573 - [clang] Change to range-based invocation of llvm::sort

Author: mgrang Date: Fri Jan 18 10:45:26 2019 New Revision: 351573 URL: http://llvm.org/viewvc/llvm-project?rev=351573=rev Log: [clang] Change to range-based invocation of llvm::sort Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp URL:

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

gtbercea accepted this revision. gtbercea added a comment. This revision is now accepted and ready to land. Thanks for the update! LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 ___ cfe-commits

[PATCH] D56871: [AMDGPU] Require at least protected visibility for certain symbols

scott.linder updated this revision to Diff 182561. scott.linder added a comment. Update option name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56871/new/ https://reviews.llvm.org/D56871 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/TargetInfo.cpp

[PATCH] D56868: Add -fapply-global-visibility-to-externs for -cc1

scott.linder updated this revision to Diff 182559. scott.linder retitled this revision from "Add -fextern-visibility for -cc1" to "Add -fapply-global-visibility-to-externs for -cc1". scott.linder added a comment. No worries, I agree that we don't gain much with a shorter flag here; explicit

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

JonasToth added a comment. In D56610#1363461 , @ilya-biryukov wrote: > In D56610#1363408 , @JonasToth wrote: > > > Is this for something like `add const`? > > If yes, there is clang-tidy effort on that, see > >

[PATCH] D56841: [clangd] Filter out plugin related flags and move all commandline manipulations into OverlayCDB.

ilya-biryukov added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 +void AdjustArguments(tooling::CompileCommand , + const std::string ) { + // Strip plugin related command line arguments. Clangd does kadircet wrote: >

[PATCH] D56916: Fix crash due to ObjCPropertyDecl

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks for fixing this. Quick LGTM to fix a crash, albeit a fews NITs. Comment at: clangd/index/SymbolCollector.cpp:372 + // ObjCPropertyDecl may have an

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 updated this revision to Diff 182556. kkwli0 marked an inline comment as done. kkwli0 added a comment. Addressed reviewer's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 Files: docs/OpenMPSupport.rst docs/ReleaseNotes.rst

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: docs/OpenMPSupport.rst:62 + +- Simplified code generation for distribute and parallel in SPMD mode. + gtbercea wrote: > Simplified SPMD code generation for `distribute parallel

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov added a comment. In D56610#1363408 , @JonasToth wrote: > Is this for something like `add const`? > If yes, there is clang-tidy effort on that, see > https://reviews.llvm.org/D54943 and https://reviews.llvm.org/D54395 for a > similar

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182555. ilya-biryukov added a comment. - Add tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-extra/clangd/SourceCode.h

Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

Confirmed that opencv builds now, thanks :) On Fri, Jan 18, 2019 at 10:05 AM Jordan Rupprecht wrote: > Thanks! I'll rebuild clang from trunk and give it another try. > Yes, for the second two, I think it should be a more straightforward fix a > la

[PATCH] D56918: [clang-tidy] add reproducer for PR39949 into test-suite

This revision was automatically updated to reflect the committed changes. Closed by commit rL351569: [clang-tidy] add reproducer for PR39949 into test-suite (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

Thanks! I'll rebuild clang from trunk and give it another try. Yes, for the second two, I think it should be a more straightforward fix a la https://chromium-review.googlesource.com/c/v8/v8/+/1414858 On Fri, Jan 18, 2019 at 9:58 AM Topper, Craig wrote: > I just committed a change to go back to

[clang-tools-extra] r351569 - [clang-tidy] add reproducer for PR39949 into test-suite

Author: jonastoth Date: Fri Jan 18 10:03:11 2019 New Revision: 351569 URL: http://llvm.org/viewvc/llvm-project?rev=351569=rev Log: [clang-tidy] add reproducer for PR39949 into test-suite Summary: The underlying issue is fixed in https://reviews.llvm.org/D56444 and this test ensures the issue

[PATCH] D56918: [clang-tidy] add reproducer for PR39949 into test-suite

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the extra test coverage! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56918/new/

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55868/new/ https://reviews.llvm.org/D55868 ___

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

aaron.ballman added a comment. In D54141#1289980 , @hokein wrote: > >> If you're suggesting proceeding with this regex based solution, I > > > > don't think that's a good idea. Why commit a hack which people will object > > to ever removing? Just see if

[PATCH] D56868: Add -fextern-visibility for -cc1

rjmccall added a comment. I'm sorry to keep jerking you around, but let's spell out the flag a bit more: `-fapply-global-visibility-to-externs`. No reason not to be totally clear here. Thank you for updating the fields and descriptions, those all look good now. CHANGES SINCE LAST ACTION

RE: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

I just committed a change to go back to only definining _XCR_XFEATURE_ENABLED_MASK when clang is in MSVC compatibility mode. I don’t think I meant to define it outside of that since it doesn’t appear gcc does. For the other two files, I assume you’re getting a collision of names similar to

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

JonasToth added a comment. Is this for something like `add const`? If yes, there is clang-tidy effort on that, see https://reviews.llvm.org/D54943 and https://reviews.llvm.org/D54395 for a similar effort. Would be best to share the code instead of reinventing it :) CHANGES SINCE LAST ACTION

  1   2   >