phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich, juliehockett.
Herald added subscribers: cfe-commits, mgorny.
-DNDEBUG is no longer needed now that we don't enable assertions, modules
should improve build times for the second stage.
Repository:
rC Clang
https://r
aaronpuchert created this revision.
aaronpuchert added reviewers: aaron.ballman, delesley.
Herald added a subscriber: cfe-commits.
We use the existing diag::note_locked_here to tell the user where we saw
the first locking.
Repository:
rC Clang
https://reviews.llvm.org/D56967
Files:
include
craig.topper added a comment.
It uses current rounding mode for inexact conversions. cvtsi642ss should do the
same. As does (u)dq2ps and (u)qq2pd. I think we use sitofp/uitofp for some
lengths of those already.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56965
RKSimon added a comment.
Just to confirm, this isn't driven by RC in any way? cvtsi642ps isn't so I
don't expect it to be, but just to be sure..
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56965/new/
https://reviews.llvm.org/D56965
_
lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.
Some nits.
Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:21
AST_MATCHER(CXXRecordDecl, hasMethods) {
+ for (const auto &Method
JonasToth added inline comments.
Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:22
AST_MATCHER(CXXRecordDecl, hasMethods) {
- return std::distance(Node.method_begin(), Node.method_end()) != 0;
+ for (const auto &Method : Node.methods()) {
+if (Meth
Author: jdoerfert
Date: Sat Jan 19 12:46:10 2019
New Revision: 351665
URL: http://llvm.org/viewvc/llvm-project?rev=351665&view=rev
Log:
[FIX] Generalize the expected results for callback clang tests
Modified:
cfe/trunk/test/CodeGen/callback_annotated.c
cfe/trunk/test/CodeGen/callback_pthr
craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel.
Herald added a subscriber: kristina.
Repository:
rC Clang
https://reviews.llvm.org/D56965
Files:
include/clang/Basic/BuiltinsX86.def
lib/Headers/avx512vldqintrin.h
test/CodeGen/avx512vldq-builtins.c
Index
grimar added a comment.
Can it be tested with a test case?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56927/new/
https://reviews.llvm.org/D56927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
grimar added a comment.
Testcase?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56925/new/
https://reviews.llvm.org/D56925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
riccibruno added inline comments.
Comment at: include/clang/AST/Expr.h:5020
Stmt **SubExprs;
unsigned NumAssocs, ResultIndex;
SourceLocation GenericLoc, DefaultLoc, RParenLoc;
I know that this is not part of this patch, but these arrays are begging
to be
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D56961
Files:
include/clang/AST/TextNodeDumper.h
lib/AST/ASTDumper.cpp
lib/AST/TextNodeDumper.cpp
Index: lib/AST/TextNodeDumpe
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
As a type, this can be visited upon. This is similar in spirit to the
BlockDecl::Capture type.
Repository:
rC Clang
https://reviews.llvm.org/D56959
Files:
include/clang/AST/Ex
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D56960
Files:
include/clang/AST/TextNodeDumper.h
lib/AST/ASTDumper.cpp
lib/AST/TextNodeDumper.cpp
Index: lib/AST/TextNodeDumpe
Author: chandlerc
Date: Sat Jan 19 03:48:15 2019
New Revision: 351651
URL: http://llvm.org/viewvc/llvm-project?rev=351651&view=rev
Log:
Update the license mentioned in this documentation.
Modified:
cfe/trunk/tools/scan-build-py/README.md
Modified: cfe/trunk/tools/scan-build-py/README.md
URL:
Author: chandlerc
Date: Sat Jan 19 02:56:40 2019
New Revision: 351648
URL: http://llvm.org/viewvc/llvm-project?rev=351648&view=rev
Log:
Update more file headers across all of the LLVM projects in the monorepo
to reflect the new license. These used slightly different spellings that
defeated my regu
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
LGTM
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56926/new/
https://reviews.llvm.org/D56926
___
cfe-commits mailing list
cfe-comm
Author: jdoerfert
Date: Sat Jan 19 01:40:08 2019
New Revision: 351642
URL: http://llvm.org/viewvc/llvm-project?rev=351642&view=rev
Log:
[NFC] Generalize expected output for callback test
Modified:
cfe/trunk/test/CodeGen/callback_pthread_create.c
Modified: cfe/trunk/test/CodeGen/callback_pthr
Author: jdoerfert
Date: Sat Jan 19 01:40:10 2019
New Revision: 351643
URL: http://llvm.org/viewvc/llvm-project?rev=351643&view=rev
Log:
[FIX] Restrict callback pthreads_create test to linux only
Modified:
cfe/trunk/test/CodeGen/callback_pthread_create.c
Modified: cfe/trunk/test/CodeGen/callb
Author: jdoerfert
Date: Fri Jan 18 21:36:54 2019
New Revision: 351629
URL: http://llvm.org/viewvc/llvm-project?rev=351629&view=rev
Log:
Emit !callback metadata and introduce the callback attribute
With commit r351627, LLVM gained the ability to apply (existing) IPO
optimizations on indirectio
Author: steveire
Date: Sat Jan 19 01:57:59 2019
New Revision: 351647
URL: http://llvm.org/viewvc/llvm-project?rev=351647&view=rev
Log:
[ASTDump] NFC: Convert iterative loops to cxx_range_for
This is coming up a lot in reviews. Better just to change them all at
once.
Modified:
cfe/trunk/lib/A
Author: steveire
Date: Sat Jan 19 01:57:51 2019
New Revision: 351646
URL: http://llvm.org/viewvc/llvm-project?rev=351646&view=rev
Log:
[ASTDump] NFC: Use `const auto` in cxx_range_for loops
This is coming up a lot in reviews. Better just to do them all at once.
Modified:
cfe/trunk/lib/AST/AS
Author: chandlerc
Date: Sat Jan 19 01:24:38 2019
New Revision: 351640
URL: http://llvm.org/viewvc/llvm-project?rev=351640&view=rev
Log:
Update the license header in this man-page file.
It contains an `$Id$` expansion and so can only be updated from a true
Subversion client.
See the details of th
This revision was automatically updated to reflect the committed changes.
Closed by commit rC351637: Move decl context dumping to TextNodeDumper
(authored by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D56829?vs=182607&id=182669#toc
Repository:
rC Clang
CHANG
Author: steveire
Date: Sat Jan 19 01:05:55 2019
New Revision: 351637
URL: http://llvm.org/viewvc/llvm-project?rev=351637&view=rev
Log:
Move decl context dumping to TextNodeDumper
Summary: Only an obscure case is moved.
Reviewers: aaron.ballman
Subscribers: cfe-commits
Differential Revision: ht
Author: chandlerc
Date: Sat Jan 19 00:50:56 2019
New Revision: 351636
URL: http://llvm.org/viewvc/llvm-project?rev=351636&view=rev
Log:
Update the file headers across all of the LLVM projects in the monorepo
to reflect the new license.
We understand that people may be surprised that we're moving
26 matches
Mail list logo