[PATCH] D56998: [X86] Custom codegen 512 integer to fp conversion intrinsics.

craig.topper created this revision. craig.topper added a reviewer: RKSimon. Herald added a subscriber: cfe-commits. The 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics all have the possibility of taking an explicit rounding mode argument. If the rounding mode is CUR_DIRECTION

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Justin, I am currently testing the latest patches, yet so far it looks very good. Thanks. I rechecked GCC, and it seems that it forces 64-bit long double for SPE regardless of the target. Could you please force that in LLVM as well? While imperfect, I currently changed

[PATCH] D56992: Mark lambda-to-function-pointer conversion as noexcept

loskutov created this revision. loskutov added reviewers: llvm-commits, aaron.ballman, doug.gregor. Herald added a subscriber: cfe-commits. Starting from C++17, [expr.prim.lambda.closure]p9 requires that "The [lambda to function pointer] conversion function [...] has a non-throwing exception

r351710 - [Driver] Don't pass default value to getCompilerRTArgString

Author: phosek Date: Sun Jan 20 17:34:09 2019 New Revision: 351710 URL: http://llvm.org/viewvc/llvm-project?rev=351710=rev Log: [Driver] Don't pass default value to getCompilerRTArgString Using static library is already a default. Differential Revision: https://reviews.llvm.org/D56043

[PATCH] D56043: [Driver] Don't pass default value to getCompilerRTArgString

This revision was automatically updated to reflect the committed changes. Closed by commit rL351710: [Driver] Dont pass default value to getCompilerRTArgString (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm created this revision. xiangzhangllvm added reviewers: craig.topper, smaslov, LuoYuanke. xiangzhangllvm added a project: clang. Herald added subscribers: cfe-commits, eraman. The constraint "0" in the following asm did not consider the its relationship with "=y" when try to

[PATCH] D56972: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules

This revision was automatically updated to reflect the committed changes. Closed by commit rL351709: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r351709 - [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules

Author: phosek Date: Sun Jan 20 17:06:50 2019 New Revision: 351709 URL: http://llvm.org/viewvc/llvm-project?rev=351709=rev Log: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules -DNDEBUG is no longer needed now that we don't enable assertions, modules should improve build times for the second

[PATCH] D56972: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56972/new/ https://reviews.llvm.org/D56972 ___

[PATCH] D55429: [analyzer] Add CheckerManager::getChecker, make sure that a registry function registers no more than 1 checker

Szelethus updated this revision to Diff 182727. Szelethus added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55429/new/ https://reviews.llvm.org/D55429 Files: include/clang/StaticAnalyzer/Core/CheckerManager.h lib/StaticAnalyzer/Checkers/CStringChecker.cpp

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

Szelethus updated this revision to Diff 182726. Szelethus added a comment. - Rebase - Resolve the issue mentioned above by not enabling checkers that has any of their dependencies explicitly disabled - Introduce `osx.RetainCountBase` to "solve" the issue mentioned in D55400#1364683

[PATCH] D56989: [analyzer][NFC] Fully initialize CheckerRegistry in by the end of construction

Szelethus updated this revision to Diff 182724. Szelethus added a comment. Remove `mutable` specifiers from all fields of `CheckerRegistry`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56989/new/ https://reviews.llvm.org/D56989 Files:

[PATCH] D56989: [analyzer][NFC] Fully initialize CheckerRegistry in by the end of construction

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, mgrang, szepet, whisperity. Szelethus retitled this revision from

[PATCH] D56988: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, baloghadamsoftware, xazax.hun, rnkovacs. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Title says it all. Repository: rC Clang

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

Szelethus updated this revision to Diff 182721. Szelethus added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55424/new/ https://reviews.llvm.org/D55424 Files: include/clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h

r351708 - [X86] Add missing test cases for some int/fp->fp conversion intrinsics with rounding mode. Use non-default rounding mode on some tests.

Author: ctopper Date: Sun Jan 20 15:49:50 2019 New Revision: 351708 URL: http://llvm.org/viewvc/llvm-project?rev=351708=rev Log: [X86] Add missing test cases for some int/fp->fp conversion intrinsics with rounding mode. Use non-default rounding mode on some tests. For some reason we were

r351706 - Tentative fix for r351701 and gcc 6.2 build on ubuntu

Author: serge_sans_paille Date: Sun Jan 20 15:43:37 2019 New Revision: 351706 URL: http://llvm.org/viewvc/llvm-project?rev=351706=rev Log: Tentative fix for r351701 and gcc 6.2 build on ubuntu Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/SemaChecking.cpp URL:

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

Szelethus added a comment. In D55424#1326397 , @NoQ wrote: > Should we also pass `CheckerManager` into `shouldRegister...`? Or is it > entirely useless? I wouldn't say useless, but I'm struggling to come up with an example where registering would

[PATCH] D55400: [analyzer] Move out tracking retain count for OSObjects into a separate checker

Szelethus added a comment. I'm working on rebasing my dependency branches on top of trunk, and I'm somewhat stuck on this patch, could you lend a hand please? So, I'm seeing in essence 3 checkers: the class `RetainCountChecker`, that does the modeling, and two checkers that are exposed to the

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

teemperor updated this revision to Diff 182718. teemperor added a comment. - Moved code into the VisitFunctionDecl function. I don't mind if we clean up that function in a later commit. Thanks for the feedback! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9825 +if (Result.isSigned() && !DstSigned) { + Overflow = Result < 0 || Result.ugt(DstMax); +} else if (Result.isUnsigned() && DstSigned) { ebevhan wrote: > The `Result <

Re: [PATCH] D56829: Move decl context dumping to TextNodeDumper

On 20/01/2019 16:57, Stella Stamenova via Phabricator via cfe-commits wrote: stella.stamenova added a comment. It looks like this change broke a number of the LLDB tests: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/781 Could you look into this or revert the change, so that the

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan updated this revision to Diff 182717. leonardchan marked 6 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 Files: clang/include/clang/AST/OperationKinds.def

[PATCH] D56985: [libunwind] Remove an unused variable

mstorsjo created this revision. mstorsjo added reviewers: mclow.lists, EricWF, ldionne. Herald added a subscriber: libcxx-commits. Repository: rUNW libunwind https://reviews.llvm.org/D56985 Files: src/Unwind-seh.cpp Index: src/Unwind-seh.cpp

[PATCH] D56984: [libunwind] Silence warnings about unused parameters

mstorsjo created this revision. mstorsjo added reviewers: mclow.lists, EricWF, ldionne. Herald added a subscriber: libcxx-commits. Repository: rUNW libunwind https://reviews.llvm.org/D56984 Files: src/AddressSpace.hpp src/Unwind-seh.cpp src/UnwindCursor.hpp Index: src/UnwindCursor.hpp

[PATCH] D56982: [libunwind] Fix warnings about printf format strings

mstorsjo created this revision. mstorsjo added reviewers: mclow.lists, EricWF, ldionne. Herald added a subscriber: libcxx-commits. Either adjust the format string to use a more exact type, or add casts (for cases when printing pointers to structs/objects with a `%p` format specifier).

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I have no objections. George, this was your idea, does it look good to you? Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:577-578 + +

[PATCH] D56981: [libunwind] Enable LLVM_ENABLE_WARNINGS when building standalone out of tree

mstorsjo created this revision. mstorsjo added reviewers: mclow.lists, EricWF, ldionne. Herald added subscribers: libcxx-commits, mgorny. When built within the llvm runtimes directory, the runtimes CMakeLists.txt adds the same. This would have helped catch the issue behind D56905

r351701 - Replace llvm::isPodLike<...> by llvm::is_trivially_copyable<...>

Author: serge_sans_paille Date: Sun Jan 20 13:19:56 2019 New Revision: 351701 URL: http://llvm.org/viewvc/llvm-project?rev=351701=rev Log: Replace llvm::isPodLike<...> by llvm::is_trivially_copyable<...> As noted in https://bugs.llvm.org/show_bug.cgi?id=36651, the specialization for isPodLike>

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

Szelethus added a comment. Ping^3. @NoQ @george.karpenkov Could you please take a look? @xazax.hun Any other objections? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51866/new/ https://reviews.llvm.org/D51866 ___ cfe-commits mailing list

[PATCH] D56965: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

This revision was automatically updated to reflect the committed changes. Closed by commit rL351694: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

r351694 - [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

Author: ctopper Date: Sun Jan 20 11:04:56 2019 New Revision: 351694 URL: http://llvm.org/viewvc/llvm-project?rev=351694=rev Log: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select. Reviewers: RKSimon, spatel Reviewed By: RKSimon Subscribers:

[PATCH] D56829: Move decl context dumping to TextNodeDumper

stella.stamenova added a comment. It looks like this change broke a number of the LLDB tests: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/781 Could you look into this or revert the change, so that the bot can go back to green? Repository: rC Clang CHANGES SINCE LAST ACTION

r351687 - [X86] Replace VPCOM/VPCOMU with generic integer comparisons (clang)

Author: rksimon Date: Sun Jan 20 08:40:33 2019 New Revision: 351687 URL: http://llvm.org/viewvc/llvm-project?rev=351687=rev Log: [X86] Replace VPCOM/VPCOMU with generic integer comparisons (clang) These intrinsics can always be replaced with generic integer comparisons without any regression in

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

vmiklos added a comment. Sorry, forgot to use the magic line at the end of the commit message to auto-close this review. Done in r351686, anyhow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56966/new/ https://reviews.llvm.org/D56966 ___

[clang-tools-extra] r351686 - [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

Author: vmiklos Date: Sun Jan 20 06:28:27 2019 New Revision: 351686 URL: http://llvm.org/viewvc/llvm-project?rev=351686=rev Log: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods Otherwise we don't warn on a struct containing a single public int, but we warn on

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

lebedev.ri added inline comments. Comment at: docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9 -Finds classes that contain non-static data members in addition to non-static -member functions and diagnose all data members declared with a non-``public``

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

riccibruno added inline comments. Comment at: docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9 -Finds classes that contain non-static data members in addition to non-static -member functions and diagnose all data members declared with a non-``public``

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

lebedev.ri added inline comments. Comment at: docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9 -Finds classes that contain non-static data members in addition to non-static -member functions and diagnose all data members declared with a non-``public``

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG other than two nits, thank you! Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:25 AST_MATCHER(CXXRecordDecl, hasNonStaticMethod) { +

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

riccibruno added inline comments. Comment at: docs/clang-tidy/checks/misc-non-private-member-variables-in-classes.rst:9 -Finds classes that contain non-static data members in addition to non-static -member functions and diagnose all data members declared with a non-``public``

[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

mgorny created this revision. mgorny added reviewers: krytarowski, sammccall, hokein, ilya-biryukov, rnk. Pass -ccc-install-dir explicitly as the compilation database code does not pass argv[0] to getMainExecutable(), while some systems require it to return the correct path. Since the relevant

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

vmiklos updated this revision to Diff 182702. vmiklos marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56966/new/ https://reviews.llvm.org/D56966 Files: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp

[PATCH] D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods

vmiklos marked 8 inline comments as done. vmiklos added a comment. I also noticed I forgot to clang-format the testcase, done now. Comment at: clang-tidy/misc/NonPrivateMemberVariablesInClassesCheck.cpp:21 AST_MATCHER(CXXRecordDecl, hasMethods) { + for (const auto :

[PATCH] D56965: [X86] Remove the cvtuqq2ps256/cvtqq2ps256 mask builtins. Replace with uitofp/sitofp and select.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. OK - LGTM, thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56965/new/ https://reviews.llvm.org/D56965

[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

Rakete added a comment. Yeah, seems like we don't instantiate `pair` at all in that specific case. LGTM but you might want to wait for someone else to confirm. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56974/new/ https://reviews.llvm.org/D56974

[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

ddiproietto created this revision. ddiproietto added a reviewer: clang. ddiproietto added a project: clang. Herald added a subscriber: cfe-commits. Trying to use structure binding with a structure that doesn't implement std::tuple_size, should unpack the data members. When the struct is a