[PATCH] D52973: Add type_info predefined decl

mwasplund abandoned this revision. mwasplund added a comment. I completely forgot this was open. I have been making incremental improvements to modules ts and this has gotten pulled into that change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52973/new/

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

NoQ accepted this revision. NoQ added a comment. *gets hyped for the upcoming patchlanding party* In D54438#1329425 , @Szelethus wrote: > Hmmm, I left plenty of room for improvement in the tblgen generation, we > could generate compile-time errors on

r352267 - [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics.

Author: ctopper Date: Fri Jan 25 18:42:01 2019 New Revision: 352267 URL: http://llvm.org/viewvc/llvm-project?rev=352267=rev Log: [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics. Summary: The 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics

[PATCH] D56998: [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL352267: [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: clang/include/clang/Lex/DirectoryLookup.h:175 + /// \param [out] IsFrameworkFound For a framework directory set to true if + /// specified '.framework' directory is found. + ///

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

vsapsai updated this revision to Diff 183678. vsapsai added a comment. - Tweak doxygen comment to express IsFrameworkFound in terms of IsFrameworkFound returned by DirectoryLookup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56561/new/ https://reviews.llvm.org/D56561 Files:

[PATCH] D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Cool! I guess we still need to think how exactly do we want to resolve conflicts between dependencies. Comment at: include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:152

[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

yln abandoned this revision. yln added a comment. Created new revision for this change: https://reviews.llvm.org/D57278 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56624/new/ https://reviews.llvm.org/D56624 ___

[PATCH] D56988: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup, totally. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56988/new/ https://reviews.llvm.org/D56988 ___

[PATCH] D57230: [analyzer] Toning down invalidation a bit

NoQ added a comment. Thanks! A surprise, to be sure :) I'll try to test this on my set of projects as well :) > Most of the extra results are not false positive due to the less invalidation > but other reasons, so we could focus on those problems instead of them being > hidden. Could you

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

vsapsai updated this revision to Diff 183668. vsapsai added a comment. Rebase on top of https://reviews.llvm.org/D57270 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57075/new/ https://reviews.llvm.org/D57075 Files: clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D57270: [ObjC] Fix non-canonical types preventing type arguments substitution.

vsapsai created this revision. vsapsai added reviewers: ahatanak, erik.pilkington. Herald added subscribers: dexonsmith, jkorous. `QualType::substObjCTypeArgs` doesn't go past non-canonical types and as the result misses some of the substitutions like `ObjCTypeParamType`. Update

[PATCH] D57268: [dllimport] Don't use RAV to check inlinability

hans added a comment. Yes, it's a little bit unfortunate that the code needs to get more complicated due to this. The RecursiveStmtVisitor idea that you mention sounds like it might be a good idea (but if it turns out not to be, I'm not entirely opposed to this patch either). CHANGES SINCE

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk updated this revision to Diff 183661. vsk added a comment. - Fix a think-o in a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/CC1Options.td

[PATCH] D57268: [dllimport] Don't use RAV to check inlinability

rnk created this revision. rnk added a reviewer: hans. I don't like this change, because I had to copy a fair amount of logic from RAV into the dllimport visitor. However, the build time and size results were still impressive, so I wanted to upload this and get a second opinion. Here's the data:

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno updated this revision to Diff 183658. riccibruno added a comment. Update the comment in the iterator as per Aaron's comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57106/new/ https://reviews.llvm.org/D57106 Files: include/clang/AST/Expr.h

[PATCH] D56928: Support attribute used in member funcs of class templates

rafauler updated this revision to Diff 183657. rafauler added a comment. No problem, thanks for your suggestions! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56928/new/ https://reviews.llvm.org/D56928 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Now that the implementation of all of the `Expr::Ignore*` is in `Expr.cpp` we can try to remove some duplication. Do this by separating the

Re: r352079 - [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

Sorry to bring more bad news, but merging this seems to have regressed a clangd test on the branch (I didn't notice at the time, because I ran the wrong set of tests, d'oh). I've searched my inbox but couldn't find any recent commits touching the test. Do you have any idea what might be

[PATCH] D57266: [AST] Update the comments of the various Expr::Ignore* + Related cleanups

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. The description of what the various `Expr::Ignore*` do has drifted from the actual implementation. Inspection reveals that

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk created this revision. vsk added reviewers: chandlerc, t.p.northover, tejohnson, hiraditya. Herald added a subscriber: mehdi_amini. In order for the hot/cold splitting pass to graduate out of experimental status, users need some way to safely enable it. The current method of passing `-mllvm

[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.

vsapsai planned changes to this revision. vsapsai added inline comments. Comment at: clang/lib/AST/Type.cpp:1295 + + QualType VisitObjCObjectType(const ObjCObjectType *objType) { +if (!objType->isKindOfType()) vsapsai wrote: > erik.pilkington wrote: > >

[PATCH] D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: docs/ReleaseNotes.rst:248 +- The `Acronyms` and `IncludeDefaultAcronyms` options for the + :doc:`objc-property-declaration` stephanemoore wrote: > Eugene.Zelenko

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore marked 2 inline comments as done. stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:96-97 // Match function declarations that are not in system headers and are not // main. Finder->addMatcher(

[PATCH] D56928: Support attribute used in member funcs of class templates

Meinersbur added a comment. Thanks for looking into my almost 6 year old bug! Comment at: test/CodeGenCXX/attr-used-member-function-implicit-instantiation.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -O0 -o - %s \ +// RUN: | FileCheck %s

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore updated this revision to Diff 183646. stephanemoore added a comment. Updated the comment describing the matching behavior. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57207/new/ https://reviews.llvm.org/D57207 Files:

[PATCH] D57258: Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF

This revision was automatically updated to reflect the committed changes. Closed by commit rC352253: Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF (authored by nico, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57258/new/

r352253 - Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF

Author: nico Date: Fri Jan 25 15:37:57 2019 New Revision: 352253 URL: http://llvm.org/viewvc/llvm-project?rev=352253=rev Log: Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF libclang can be built in shared or static mode. On Windows, with LLVM_ENABLE_PIC=OFF, it was built in neither

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

shafik added inline comments. Comment at: lib/AST/ASTImporter.cpp:2954 +return Found->hasExternalFormalLinkage(); + else if (Importer.GetFromTU(Found) == From->getTranslationUnitDecl()) { +if (From->isInAnonymousNamespace()) We don't really need an

r352252 - Fixed frontend clang tests in windows read-only container

Author: stella.stamenova Date: Fri Jan 25 15:03:12 2019 New Revision: 352252 URL: http://llvm.org/viewvc/llvm-project?rev=352252=rev Log: Fixed frontend clang tests in windows read-only container Summary: When mounting LLVM source into a windows container in read-only mode, certain tests fail.

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan updated this revision to Diff 183629. leonardchan marked 4 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57219/new/ https://reviews.llvm.org/D57219 Files: clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:141 + (RHSType->isFixedPointType() && + LHSType->isFixedPointOrIntegerType()); +} ebevhan wrote: > Can't it just be `LHSType->isFixedPointType() ||

[PATCH] D50563: Fixed frontend clang tests in windows read-only container

This revision was automatically updated to reflect the committed changes. Closed by commit rC352252: Fixed frontend clang tests in windows read-only container (authored by stella.stamenova, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50563/new/

[PATCH] D32635: [libcxx] regex: fix backreferences in forward assertions

Qix- added a comment. Ping @EricWF - few years but this is still an issue, rendering ECMAscript regex backreferences almost entirely broken in libcxx :/ Would be great to get a champion for it. OP has indicated on Github that they'd be happy to rebase. CHANGES SINCE LAST ACTION

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:437 + // DEFAULT-NEXT: [[RES:%[a-z0-9]+]] = trunc i39 [[SATMIN]] to i16 + // DEFAULT-NEXT: store i16 [[RES]], i16* %sat_sa, align 2 +

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno marked 3 inline comments as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5084 + /// storage of Stmt * and TypeSourceInfo * in GenericSelectionExpr. + template class AssociationIteratorTy { +friend class GenericSelectionExpr;

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh updated this revision to Diff 183615. lildmh added a comment. Address review comments and rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56326/new/ https://reviews.llvm.org/D56326 Files: include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh marked 18 inline comments as done. lildmh added a comment. Hi Alexey, Thanks a lot for the review! Tried to address all of your comments in the new diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56326/new/ https://reviews.llvm.org/D56326

[libunwind] r352245 - [libunwind] Use placement new to avoid dependency C++ library

Author: phosek Date: Fri Jan 25 13:39:46 2019 New Revision: 352245 URL: http://llvm.org/viewvc/llvm-project?rev=352245=rev Log: [libunwind] Use placement new to avoid dependency C++ library The rest of libunwind already uses placement new, these are the only places where non-placement new is

[PATCH] D57258: Attempt to fix build on Windows with LLVM_ENABLE_PIC=OFF

thakis created this revision. thakis added a reviewer: rnk. Herald added a subscriber: mgorny. libclang can be built in shared or static mode. On Windows, with LLVM_ENABLE_PIC=OFF, it was built in neither mode, leading to clients of libclang (c-index-test, c-arcmt-test) failing to link with it

[PATCH] D57064: [Sema] Improve a -Warray-bounds diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rL352239: [Sema] Improve a -Warray-bounds diagnostic (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r352239 - [Sema] Improve a -Warray-bounds diagnostic

Author: epilk Date: Fri Jan 25 12:52:45 2019 New Revision: 352239 URL: http://llvm.org/viewvc/llvm-project?rev=352239=rev Log: [Sema] Improve a -Warray-bounds diagnostic Fix a bug where we would compare array sizes with incompatible element types, and look through explicit casts.

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

aaron.ballman added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:96-97 // Match function declarations that are not in system headers and are not // main. Finder->addMatcher( This comment is drifting more and more out of sync

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, + clang::ast_matchers::internal::Matcher,

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added a comment. In D56424#1370908 , @hokein wrote: > In D56424#1370461 , @karepker wrote: > > > Rebasing against master. > > > > Not sure if re-arc diffing this is necessary, but I hope it doesn't hurt. >

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

ABataev added inline comments. Comment at: include/clang/AST/DeclBase.h:181 +/// This declaration is an OpenMP user defined mapper. +IDNS_OMPMapper = 0x2000 }; Add comma after `0x2000` to exclude this line from the next pactches

[PATCH] D57228: [clangd] Make USRs for macros to be position independent

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. Thanks for fixing this Kadir! LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57228/new/ https://reviews.llvm.org/D57228

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri marked an inline comment as done and an inline comment as not done. lebedev.ri added inline comments. Comment at: lib/AST/ASTTypeTraits.cpp:114 +#define OPENMP_CLAUSE(Name, Class) \ +case OMPC_##Name: return

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, +

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

ymandel updated this revision to Diff 183591. ymandel added a comment. Contrast to thisPointerType with explicit examples. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56851/new/ https://reviews.llvm.org/D56851 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

lebedev.ri added a comment. @JonasToth @erichkeane thank you for taking care of this. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57249/new/ https://reviews.llvm.org/D57249 ___ cfe-commits mailing list

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, + clang::ast_matchers::internal::Matcher,

r352232 - [CodeGen] Implement isTriviallyRecursive with StmtVisitor instead of RecursiveASTVisitor

Author: rnk Date: Fri Jan 25 11:18:40 2019 New Revision: 352232 URL: http://llvm.org/viewvc/llvm-project?rev=352232=rev Log: [CodeGen] Implement isTriviallyRecursive with StmtVisitor instead of RecursiveASTVisitor This code doesn't need to traverse types, lambdas, template arguments, etc to

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

hwright updated this revision to Diff 183583. hwright marked an inline comment as done. hwright added a comment. Add another test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57185/new/ https://reviews.llvm.org/D57185 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, +

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

ymandel updated this revision to Diff 183582. ymandel added a comment. Remove unneeded qualifiers and clarify constrast with `thisPointerType`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56851/new/ https://reviews.llvm.org/D56851 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

This revision was automatically updated to reflect the committed changes. Closed by commit rL352231: [clang-tidy] fix unit tests for dropped _Float16 support in X86 (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[clang-tools-extra] r352231 - [clang-tidy] fix unit tests for dropped _Float16 support in X86

Author: jonastoth Date: Fri Jan 25 11:05:12 2019 New Revision: 352231 URL: http://llvm.org/viewvc/llvm-project?rev=352231=rev Log: [clang-tidy] fix unit tests for dropped _Float16 support in X86 Summary: Because _Float16 was disabled for X86 targets the unit-tests started failing. Extract the

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

JonasToth updated this revision to Diff 183580. JonasToth marked an inline comment as done. JonasToth added a comment. - last nit, remove the disabled in hexadecimal Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57249/new/

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

JonasToth updated this revision to Diff 183579. JonasToth added a comment. - Revert "add REQUIRES: for the readability unit-tests where necessary" as its not necessary because only the frontend is run Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

JonasToth updated this revision to Diff 183578. JonasToth added a comment. - add REQUIRES: for the readability unit-tests where necessary Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57249/new/ https://reviews.llvm.org/D57249 Files:

[PATCH] D56851: [ASTMatchers] Adds `CXXMemberCallExpr` matcher `invokedAtType`.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3300 +/// matches `x.m()` and `p->m()`. +AST_MATCHER_P_OVERLOAD(clang::CXXMemberCallExpr, invokedAtType, +

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

lebedev.ri added inline comments. Comment at: test/clang-tidy/readability-uppercase-literal-suffix-float16.cpp:2 +// RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -target aarch64-linux-gnu -I %S + +#include "readability-uppercase-literal-suffix.h"

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM, thanks for doing this! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57249/new/ https://reviews.llvm.org/D57249

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, erichkeane, lebedev.ri. Herald added subscribers: cfe-commits, kristof.beyls, xazax.hun, javed.absar. Because _Float16 was disabled for X86 targets the unit-tests started failing. Extract the pieces for _Float16 and run

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5084 + /// storage of Stmt * and TypeSourceInfo * in GenericSelectionExpr. + template class AssociationIteratorTy { +friend class GenericSelectionExpr; riccibruno wrote: > dblaikie

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh updated this revision to Diff 183570. lildmh added a comment. Change the type of mapper clause storage from OMPClause ** to MutableArrayRef, and rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56326/new/ https://reviews.llvm.org/D56326 Files:

r352229 - Remove F16 literal support based on Float16 support.

Author: erichkeane Date: Fri Jan 25 10:36:20 2019 New Revision: 352229 URL: http://llvm.org/viewvc/llvm-project?rev=352229=rev Log: Remove F16 literal support based on Float16 support. Float16 support was disabled recently on many platforms, however that commit still allowed literals of Float16

[PATCH] D56998: [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56998/new/ https://reviews.llvm.org/D56998 ___ cfe-commits

[PATCH] D57209: Revert "[AArch64] Use LL for 64-bit intrinsic arguments"

rnk added a comment. In D57209#1370789 , @mstorsjo wrote: > In D57209#1370608 , @rnk wrote: > > > and I don't think anyone has set up a continuous Windows ARM64 build with > > ToT clang anywhere in the world yet.

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

george.karpenkov added a comment. > Also, isn't lib/Analysis a strange place for this? lib/Analysis is used by > the compiler proper (CodeGen, Sema, …), while RetainSummaryManager is only > used by tooling-like things (static analyzer, arcmigrate). Not only, it has utilities used by the static

[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

george.karpenkov added a comment. > Can you elaborate a bit in what sense this decouples ARCMT from the analyzer? ARCMT now does not need to link against the analyzer > Can CLANG_ENABLE_STATIC_ANALYZER now be set independently of > CLANG_ENABLE_ARCMT? Yes Repository: rC Clang CHANGES

Re: r351740 - [AArch64] Use LL for 64-bit intrinsic arguments

I see this was reverted later, but please keep me posted on the resolution as I think we might want to merge this to the 8.0 release branch as well. Thanks, Hans On Mon, Jan 21, 2019 at 3:01 AM Sam Parker via cfe-commits wrote: > > Author: sam_parker > Date: Mon Jan 21 03:01:05 2019 > New

Re: r352079 - [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

Merged to 8.0 in r352225. On Thu, Jan 24, 2019 at 10:55 AM Sam McCall via cfe-commits wrote: > > Author: sammccall > Date: Thu Jan 24 10:55:24 2019 > New Revision: 352079 > > URL: http://llvm.org/viewvc/llvm-project?rev=352079=rev > Log: > [FileManager] Revert r347205 to avoid PCH

Re: r352219 - Allow 'static' storage specifier on an out-of-line member function template

This review is invalid, since the lists weren't subscribed. On Fri, Jan 25, 2019 at 8:01 PM Erich Keane via cfe-commits wrote: > > Author: erichkeane > Date: Fri Jan 25 09:01:42 2019 > New Revision: 352219 > > URL: http://llvm.org/viewvc/llvm-project?rev=352219=rev > Log: > Allow 'static'

[clang-tools-extra] r352224 - Temporairly disable readability-uppercase-literal-suffix tests that depend on _Float16, to get bots back to green

Author: lebedevri Date: Fri Jan 25 10:05:43 2019 New Revision: 352224 URL: http://llvm.org/viewvc/llvm-project?rev=352224=rev Log: Temporairly disable readability-uppercase-literal-suffix tests that depend on _Float16, to get bots back to green Modified:

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added a comment. "it" is the grammatically correct word. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57188/new/ https://reviews.llvm.org/D57188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56998: [X86] Custom codegen 512-bit cvt(u)qq2tops, cvt(u)qqtopd, and cvt(u)dqtops intrinsics.

craig.topper added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56998/new/ https://reviews.llvm.org/D56998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56581: [ASTImporter] Set the described template if not set

shafik added a subscriber: aprantl. shafik added a comment. I don't believe it is directly related to modules but that it just triggers the issue because it may be bringing in more. You can find a description here https://clang.llvm.org/docs/CommandGuide/clang.html#cmdoption-g and @aprantl

r352222 - Fix incorrect indent from r352221

Author: erichkeane Date: Fri Jan 25 09:39:57 2019 New Revision: 35 URL: http://llvm.org/viewvc/llvm-project?rev=35=rev Log: Fix incorrect indent from r352221 Change-Id: I0a7b1443eb6912ef7bea1a4cf2f696fc01726557 Modified: cfe/trunk/docs/LanguageExtensions.rst Modified:

[PATCH] D52839: Inform AST's UnaryOperator of FENV_ACCESS

kpn added a comment. In D52839#1263794 , @rsmith wrote: > > 2. Track the FP environment somewhere more transient, probably on the `Scope` > object. When parsing an operator, store the environment on the expression, > and when performing a

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

scanon added a subscriber: ab. scanon added a comment. > do we want to support _Float16 anywhere else? ARM is the only in-tree target with a defined ABI that I'm aware of. > Do we need to lock down an ABI here for i386/x86_64 in advance of those gears > turning in the outer world? We

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL352221: Disable _Float16 for non ARM/SPIR Targets (authored by erichkeane, committed by ). Herald added a subscriber:

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added inline comments. Comment at: docs/LanguageExtensions.rst:484 +- SPIR +``_Float16`` will be supported on more targets as they define ABIs for them. + rjmccall wrote: > "them" should be "it" here. Sorry, apparently Phabricator was sitting on a

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

rjmccall added inline comments. Comment at: include/clang/Serialization/ASTBitCodes.h:1637 + /// A FixedPointLiteral record. + EXPR_FIXEDPOINT_LITERAL, + ebevhan wrote: > I'm unsure if this is the right location for a new code. This will bump down >

r352221 - Disable _Float16 for non ARM/SPIR Targets

Author: erichkeane Date: Fri Jan 25 09:27:57 2019 New Revision: 352221 URL: http://llvm.org/viewvc/llvm-project?rev=352221=rev Log: Disable _Float16 for non ARM/SPIR Targets As Discussed here: http://lists.llvm.org/pipermail/llvm-dev/2019-January/129543.html There are problems exposing the

[PATCH] D57220: Test fix for isViableInline remark message

anemet accepted this revision. anemet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57220/new/ https://reviews.llvm.org/D57220 ___ cfe-commits

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added a subscriber: scanon. rjmccall added a comment. This LGTM with one minor revision; feel free to commit with that. For follow-up commit consideration: @scanon, do we want to support `_Float16` anywhere else? Do we need to lock down an ABI here for i386/x86_64 in advance of those

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

balazske added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:2523 + Decl *ToTU = ToAST->getASTContext().getTranslationUnitDecl(); + cast(ToTU)->dumpDeclContext(); + ASSERT_EQ(DeclCounter().match(ToTU, functionDecl(hasName("f"))), Is this

r352219 - Allow 'static' storage specifier on an out-of-line member function template

Author: erichkeane Date: Fri Jan 25 09:01:42 2019 New Revision: 352219 URL: http://llvm.org/viewvc/llvm-project?rev=352219=rev Log: Allow 'static' storage specifier on an out-of-line member function template declaration in MSVCCompat mode Microsoft compiler permits the use of 'static' storage

[PATCH] D56267: [clangd] Interfaces for writing code actions

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Protocol.cpp:425 +const llvm::StringLiteral ExecuteCommandParams::CLANGD_APPLY_TWEAK = +"clangd.applyCodeAction"; +

[PATCH] D57242: [RISCV] Specify MaxAtomicInlineWidth for RISC-V

lewis-revill created this revision. lewis-revill added a reviewer: asb. Herald added subscribers: cfe-commits, jocewei, PkmX, jfb, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. This

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5103 +using reference = AssociationTy; +using pointer = AssociationTy; +AssociationIteratorTy() = default; aaron.ballman wrote: > riccibruno wrote: > > dblaikie wrote: > > >

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

riccibruno updated this revision to Diff 183552. riccibruno marked 10 inline comments as done. riccibruno added a comment. Moved back to an input iterator. Addressed Aaron's remaining comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57106/new/

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

JonasToth added inline comments. Comment at: test/clang-tidy/abseil-duration-addition.cpp:84 +#undef PLUS_FIVE +} hwright wrote: > JonasToth wrote: > > a view template test-cases would be good to have. > I'm not sure I know that terminology; do you have an

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

hwright marked 2 inline comments as done. hwright added inline comments. Comment at: test/clang-tidy/abseil-duration-addition.cpp:84 +#undef PLUS_FIVE +} JonasToth wrote: > a view template test-cases would be good to have. I'm not sure I know that terminology;

[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Just a bunch of nits, up to you to work out how/whether to address. One substantive issue around classes defined outside headers - will chat offline. Comment at:

[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

lebedev.ri marked 2 inline comments as not done. lebedev.ri added inline comments. Comment at: docs/clang-tidy/checks/openmp-use-default-none.rst:12 +being implicitly determined, and thus forces developer to be explicit about the +desired data scoping for each variable. +

[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationAdditionCheck.cpp:22 +void DurationAdditionCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + binaryOperator(hasOperatorName("+"), hwright wrote: > JonasToth wrote:

[PATCH] D56925: Do not use frame pointer by default for MSP430

krisb added inline comments. Comment at: test/CodeGen/msp430-fp-elim.c:16 +{ + asm volatile ("calla r4"); +} This test as it is will fail after integrated assembler will be turned on by default (see https://reviews.llvm.org/D56787). Since `calla`

  1   2   >