[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57435: [clang-tidy] created wrap-unique check

lebedev.ri added a comment. `.DS_Store` files clearly should not be there. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 ___ cfe-commits mailing list

r352605 - [ModuleDependencyCollector] Use llvm::sys::fs::real_path (NFC)

Author: jdevlieghere Date: Tue Jan 29 22:26:26 2019 New Revision: 352605 URL: http://llvm.org/viewvc/llvm-project?rev=352605=rev Log: [ModuleDependencyCollector] Use llvm::sys::fs::real_path (NFC) Use the real_path implementation from llvm::sys::fs::real_path instead of having a custom

[PATCH] D57411: [ModuleDependencyCollector] Use llvm::sys::fs::real_path

This revision was automatically updated to reflect the committed changes. Closed by commit rC352605: [ModuleDependencyCollector] Use llvm::sys::fs::real_path (NFC) (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D57411?vs=184155=184250#toc

[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

ahatanak added a comment. LGTM with one minor nit. Comment at: clang/test/CodeGenObjC/builtin-constant-p.m:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -emit-llvm -O3 -o - %s | FileCheck %s + Since this is just testing front-end's IRGen, can you pass

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: test/SemaObjCXX/arc-0x.mm:164 +union { + union { // expected-note 2 {{'S1' is implicitly deleted because variant field '' has a non-trivial}} expected-note 4 {{'S1' is implicitly

[PATCH] D57438: [Sema][ObjC] Allow declaring ObjC pointer members in C++ unions under ARC

ahatanak created this revision. ahatanak added reviewers: rsmith, rjmccall, doug.gregor. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. ObjC pointer members are currently not allowed in unions in either C or C++ mode. This patch lifts the restriction in C++ mode.

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56318/new/ https://reviews.llvm.org/D56318 ___ cfe-commits mailing list

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl updated this revision to Diff 184245. yaxunl added a comment. Use const argument. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56318/new/ https://reviews.llvm.org/D56318 Files: include/clang/Basic/TargetInfo.h lib/Basic/TargetInfo.cpp lib/Basic/Targets/AMDGPU.cpp

[PATCH] D57411: [ModuleDependencyCollector] Use llvm::sys::fs::real_path

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for working on this! LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57411/new/ https://reviews.llvm.org/D57411

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall added a comment. One minor change and then LGTM. Comment at: include/clang/Basic/TargetInfo.h:1352 + /// Copy type and layout related info. + void copyAuxTarget(TargetInfo *Aux); virtual uint64_t getPointerWidthV(unsigned AddrSpace) const { This

[PATCH] D57435: [clang-tidy] created wrap-unique check

Dosi-Dough created this revision. Dosi-Dough added reviewers: EricWF, JonasToth. Dosi-Dough added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. based on abseil tip of the week 126 https://abseil.io/tips/126 Created a check which looks for instances of a factory

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl updated this revision to Diff 184238. yaxunl added a comment. Revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56318/new/ https://reviews.llvm.org/D56318 Files: include/clang/Basic/TargetInfo.h lib/Basic/TargetInfo.cpp lib/Basic/Targets/AMDGPU.cpp

r352595 - Cleanup: replace uses of CallSite with CallBase.

Author: jyknight Date: Tue Jan 29 18:54:28 2019 New Revision: 352595 URL: http://llvm.org/viewvc/llvm-project?rev=352595=rev Log: Cleanup: replace uses of CallSite with CallBase. Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp cfe/trunk/lib/CodeGen/CGBuiltin.cpp

r352593 - Simplify and modernize this code a little.

Author: rsmith Date: Tue Jan 29 18:23:34 2019 New Revision: 352593 URL: http://llvm.org/viewvc/llvm-project?rev=352593=rev Log: Simplify and modernize this code a little. No functionality change intended. Modified: cfe/trunk/lib/Basic/FileManager.cpp Modified:

[PATCH] D57433: [analyzer] [RetainCountChecker] Bugfix for tracking top-level parameters of Objective-C methods

This revision was automatically updated to reflect the committed changes. Closed by commit rC352588: [analyzer] [RetainCountChecker] Bugfix for tracking top-level parameters of… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D57432: [CMake][Fuchsia] Re-enable iOS runtimes for Fuchsia standard

This revision was automatically updated to reflect the committed changes. Closed by commit rC352586: [CMake][Fuchsia] Re-enable iOS runtimes for Fuchsia standard (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D57432?vs=184218=184222#toc Repository: rC

r352586 - [CMake][Fuchsia] Re-enable iOS runtimes for Fuchsia standard

Author: phosek Date: Tue Jan 29 18:06:06 2019 New Revision: 352586 URL: http://llvm.org/viewvc/llvm-project?rev=352586=rev Log: [CMake][Fuchsia] Re-enable iOS runtimes for Fuchsia standard Turned out this is used by Flutter which uses Fuchsia Clang toolchain. Differential Revision:

[PATCH] D57431: [CMake][Fuchsia] Enable hermetic static libunwind for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rC352584: [CMake][Fuchsia] Enable hermetic static libunwind for Fuchsia (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D57431?vs=184216=184220#toc Repository:

r352584 - [CMake][Fuchsia] Enable hermetic static libunwind for Fuchsia

Author: phosek Date: Tue Jan 29 18:02:25 2019 New Revision: 352584 URL: http://llvm.org/viewvc/llvm-project?rev=352584=rev Log: [CMake][Fuchsia] Enable hermetic static libunwind for Fuchsia In addition to libc++abi and libc++, we also want to use hermetic static libunwind on Fuchsia.

[PATCH] D57432: [CMake][Fuchsia] Re-enable iOS runtimes for Fuchsia standard

phosek created this revision. phosek added a reviewer: jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Turned out this is used by Flutter which uses Fuchsia Clang toolchain. Repository: rC Clang https://reviews.llvm.org/D57432 Files: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D57431: [CMake][Fuchsia] Enable hermetic static libunwind for Fuchsia

phosek created this revision. phosek added a reviewer: jakehehrlich. Herald added subscribers: cfe-commits, mgorny. jakehehrlich accepted this revision. This revision is now accepted and ready to land. In addition to libc++abi and libc++, we also want to use hermetic static libunwind on Fuchsia.

[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

vsapsai added a comment. In D57427#1376493 , @void wrote: > LGTM, but may want to wait for other reviewers. Thanks for the prompt review, Bill. I'll wait for other reviewers to confirm the change makes sense for Objective-C. CHANGES SINCE LAST ACTION

[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

void accepted this revision. void added a comment. This revision is now accepted and ready to land. LGTM, but may want to wait for other reviewers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57427/new/ https://reviews.llvm.org/D57427

[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

vsapsai created this revision. vsapsai added reviewers: rjmccall, ahatanak, void. Herald added subscribers: dexonsmith, jkorous. When we are calling `__builtin_constant_p` with ObjC objects of different classes, we hit the assertion > Assertion failed: (isa(Val) && "cast() argument of

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

thakis added a comment. arphaman: ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57345/new/ https://reviews.llvm.org/D57345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r352574 - Fix thread safety tests after r352549

Author: aaronpuchert Date: Tue Jan 29 16:18:24 2019 New Revision: 352574 URL: http://llvm.org/viewvc/llvm-project?rev=352574=rev Log: Fix thread safety tests after r352549 Modified: cfe/trunk/test/PCH/thread-safety-attrs.cpp cfe/trunk/test/Sema/warn-thread-safety-analysis.c Modified:

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

This revision was automatically updated to reflect the committed changes. Closed by commit rC352572: [analyzer] NFC: GenericTaintChecker: Revise rule specification mechanisms. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D55734?vs=179436=184201#toc

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

NoQ added a comment. Hmm, the diff is a mixture of D54918 and this patch. I'll apply it by reverting D54918 locally and then applying this diff, but please let us know if you accidentally uploaded a wrong diff! CHANGES SINCE

r352572 - [analyzer] NFC: GenericTaintChecker: Revise rule specification mechanisms.

Author: dergachev Date: Tue Jan 29 16:06:43 2019 New Revision: 352572 URL: http://llvm.org/viewvc/llvm-project?rev=352572=rev Log: [analyzer] NFC: GenericTaintChecker: Revise rule specification mechanisms. Provide a more powerful and at the same time more readable way of specifying taint

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

eugenis added a comment. LGTM assuming the plan is to add !nosanitize where !noreturn has been, at the original call site, in the follow-up change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57278/new/ https://reviews.llvm.org/D57278

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire abandoned this revision. steveire added a comment. An alternative was written and committed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56959/new/ https://reviews.llvm.org/D56959 ___ cfe-commits mailing

[PATCH] D57419: [ASTDump] Move Decl node dumping to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, jfb. Repository: rC Clang https://reviews.llvm.org/D57419 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index:

[PATCH] D56961: NFC: Move GenericSelectionExpr dump to NodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC352558: NFC: Move GenericSelectionExpr dump to NodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56961?vs=182674=184187#toc Repository: rC Clang

[libunwind] r352559 - [libunwind] Support building hermetic static library

Author: phosek Date: Tue Jan 29 15:01:08 2019 New Revision: 352559 URL: http://llvm.org/viewvc/llvm-project?rev=352559=rev Log: [libunwind] Support building hermetic static library This is useful when the static libunwind library is being linked into shared libraries that may be used in with

r352558 - NFC: Move GenericSelectionExpr dump to NodeDumper

Author: steveire Date: Tue Jan 29 14:58:28 2019 New Revision: 352558 URL: http://llvm.org/viewvc/llvm-project?rev=352558=rev Log: NFC: Move GenericSelectionExpr dump to NodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56961

[libunwind] r352553 - Drop the dependency on , add placement new inline

Author: phosek Date: Tue Jan 29 14:26:18 2019 New Revision: 352553 URL: http://llvm.org/viewvc/llvm-project?rev=352553=rev Log: Drop the dependency on , add placement new inline We haven't eliminated C++ library dependency altogether in D57251, UnwindCursor.hpp had an unused dependency on which

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

yln added a comment. @eugenis @delcypher Looks good to you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57278/new/ https://reviews.llvm.org/D57278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor

This revision was automatically updated to reflect the committed changes. Closed by commit rC352552: NFC: Implement GenericSelectionExpr::Association dump with Visitor (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56960?vs=182673=184178#toc

r352552 - NFC: Implement GenericSelectionExpr::Association dump with Visitor

Author: steveire Date: Tue Jan 29 14:22:55 2019 New Revision: 352552 URL: http://llvm.org/viewvc/llvm-project?rev=352552=rev Log: NFC: Implement GenericSelectionExpr::Association dump with Visitor Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision:

[PATCH] D57330: Adjust documentation for git migration.

smeenai added a comment. In D57330#1376069 , @mehdi_amini wrote: > > You can avoid the git status pollution by adding the build directory to > > .git/info/exclude. > > Good to know! Should we include this in the doc? I can put that change up fore

r352549 - Thread safety analysis: Improve diagnostics for double locking

Author: aaronpuchert Date: Tue Jan 29 14:11:42 2019 New Revision: 352549 URL: http://llvm.org/viewvc/llvm-project?rev=352549=rev Log: Thread safety analysis: Improve diagnostics for double locking Summary: We use the existing diag::note_locked_here to tell the user where we saw the first

[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

This revision was automatically updated to reflect the committed changes. Closed by commit rL352549: Thread safety analysis: Improve diagnostics for double locking (authored by aaronpuchert, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56760: Add a new builtin: __builtin_dynamic_object_size

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In D56760#1368279 , @erik.pilkington wrote: > FWIW I'd prefer the __builtin_object_size spelling too, but it doesn't seem > like the GCC folks are

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

vsk accepted this revision. vsk added a comment. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57278/new/ https://reviews.llvm.org/D57278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

yln updated this revision to Diff 184168. yln added a comment. Directly insert calls to `__asan_handle_no_return` Clang-CodeGen now directly insert calls to `__asan_handle_no_return` when a call to a noreturn function is encountered and both UBsan unreachable and ASan are enabled. This allows

Re: r352539 - Revert "OpenCL: Extend argument promotion rules to vector types"

Merged to 8.0 in r352547. On Tue, Jan 29, 2019 at 3:49 PM Matt Arsenault via cfe-commits wrote: > > Author: arsenm > Date: Tue Jan 29 12:49:47 2019 > New Revision: 352539 > > URL: http://llvm.org/viewvc/llvm-project?rev=352539=rev > Log: > Revert "OpenCL: Extend argument promotion rules to

[PATCH] D57330: Adjust documentation for git migration.

mehdi_amini added a comment. > You can avoid the git status pollution by adding the build directory to > .git/info/exclude. Good to know! Should we include this in the doc? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57330/new/

r352544 - OpenCL: Try to fix bot test failure

Author: arsenm Date: Tue Jan 29 13:14:56 2019 New Revision: 352544 URL: http://llvm.org/viewvc/llvm-project?rev=352544=rev Log: OpenCL: Try to fix bot test failure Modified: cfe/trunk/test/SemaOpenCL/format-strings-fixit.cl Modified: cfe/trunk/test/SemaOpenCL/format-strings-fixit.cl URL:

r352543 - [OPENMP]Fix PR40513: lastprivate taskloop counter.

Author: abataev Date: Tue Jan 29 13:12:28 2019 New Revision: 352543 URL: http://llvm.org/viewvc/llvm-project?rev=352543=rev Log: [OPENMP]Fix PR40513: lastprivate taskloop counter. We don't need to use the predetermined data-sharing attributes for the loop counters if the user explicitly

r352542 - [cc1as] Test that -g of empty .s file does something sensible.

Author: probinson Date: Tue Jan 29 12:57:50 2019 New Revision: 352542 URL: http://llvm.org/viewvc/llvm-project?rev=352542=rev Log: [cc1as] Test that -g of empty .s file does something sensible. Depends on LLVM r352541. Added: cfe/trunk/test/Misc/cc1as-asm-debug.s Added:

[PATCH] D57390: OpenCL: Use length modifier for warning on vector printf arguments

arsenm closed this revision. arsenm added a comment. r352540 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57390/new/ https://reviews.llvm.org/D57390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57405: Revert "OpenCL: Extend argument promotion rules to vector types"

arsenm closed this revision. arsenm added a comment. r352539 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57405/new/ https://reviews.llvm.org/D57405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r352540 - OpenCL: Use length modifier for warning on vector printf arguments

Author: arsenm Date: Tue Jan 29 12:49:54 2019 New Revision: 352540 URL: http://llvm.org/viewvc/llvm-project?rev=352540=rev Log: OpenCL: Use length modifier for warning on vector printf arguments Re-enable format string warnings on printf. The warnings are still incomplete. Apparently it is

r352539 - Revert "OpenCL: Extend argument promotion rules to vector types"

Author: arsenm Date: Tue Jan 29 12:49:47 2019 New Revision: 352539 URL: http://llvm.org/viewvc/llvm-project?rev=352539=rev Log: Revert "OpenCL: Extend argument promotion rules to vector types" This reverts r348083. This was based on a misreading of the spec for printf specifiers. Also revert

[PATCH] D57404: build: remove use of llvm-config

mgorny added a comment. I don't think that's going to work on top of unconfigured sources. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57404/new/ https://reviews.llvm.org/D57404 ___ cfe-commits mailing list

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

lebedev.ri added a comment. In D44823#1375654 , @mclow.lists wrote: > In D44823#1375590 , @mclow.lists > wrote: > > > I just tried this (on Compiler Explorer) using LLVM 7, and the code for my > > original test

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

MyDeveloperDay added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-double-conversion.rst:20 + + + // Original - Conversion to integer and back again hwright wrote: > Eugene.Zelenko wrote: > > Unnecessary empty line. > This is consistent

[PATCH] D57404: build: remove use of llvm-config

compnerd added a comment. @mgorny, no, you should specify `-DLLVM_DIR=/path/to/where/the/config/lives` instead. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57404/new/ https://reviews.llvm.org/D57404 ___

[PATCH] D57411: [ModuleDependencyCollector] Use llvm::sys::fs::real_path

JDevlieghere created this revision. JDevlieghere added a reviewer: bruno. Use the real_path from llvm::sys::fs::real_path instead of having a custom implementation. Repository: rC Clang https://reviews.llvm.org/D57411 Files: clang/lib/Frontend/ModuleDependencyCollector.cpp Index:

[PATCH] D57405: Revert "OpenCL: Extend argument promotion rules to vector types"

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57405/new/ https://reviews.llvm.org/D57405 ___ cfe-commits mailing list

[PATCH] D57390: OpenCL: Use length modifier for warning on vector printf arguments

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57390/new/ https://reviews.llvm.org/D57390 ___ cfe-commits mailing list

Re: r350970 - [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

r352537 should fix it. Steven > On Jan 29, 2019, at 11:36 AM, Matt Arsenault wrote: > > > >> On Jan 11, 2019, at 4:16 PM, Steven Wu via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> >> Author: steven_wu >> Date: Fri Jan 11 13:16:04 2019 >> New Revision: 350970 >> >> URL:

r352537 - Fix the tests from r350970

Author: steven_wu Date: Tue Jan 29 12:13:02 2019 New Revision: 352537 URL: http://llvm.org/viewvc/llvm-project?rev=352537=rev Log: Fix the tests from r350970 Relax the tests from r350970 to allow non-standard path for ld. Modified: cfe/trunk/test/Driver/darwin-ld-lto.c Modified:

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

eugenis added a comment. Sounds good. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57278/new/ https://reviews.llvm.org/D57278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57380: [clang-tools-extra] add missing .clang-format and .clang-tidy for use with git monorepo

MyDeveloperDay abandoned this revision. MyDeveloperDay added a comment. Abandoning as its been superseded by... https://github.com/llvm/llvm-project/commit/149be18dbc4d54328fe33b5ac21dcbbca2b07aa6 Which puts these files at the base of llvm-project Repository: rCTE Clang Tools Extra CHANGES

[PATCH] D57390: OpenCL: Use length modifier for warning on vector printf arguments

arsenm updated this revision to Diff 184147. arsenm marked 2 inline comments as done. arsenm retitled this revision from "OpenCL: Don't promote vector args to printf" to "OpenCL: Use length modifier for warning on vector printf arguments". arsenm edited the summary of this revision. arsenm added

[PATCH] D57330: Adjust documentation for git migration.

smeenai added a comment. In D57330#1375913 , @mehdi_amini wrote: > In D57330#1375096 , @labath wrote: > > > This is not an full out-of-source build, since the build folder is still a > > subfolder of the repo root

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

hwright added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-double-conversion.rst:28 + +Note: Converting to an integer and back to an `absl::Duration` might be a +truncating operation if the value is not aligned to the scale of conversion.

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

hwright updated this revision to Diff 184146. hwright marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57353/new/ https://reviews.llvm.org/D57353 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D57330: Adjust documentation for git migration.

mehdi_amini added a comment. In D57330#1375096 , @labath wrote: > This is not an full out-of-source build, since the build folder is still a > subfolder of the repo root My definition of what qualify an "out-of-source" build is that the build process

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

shafik added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:468 + template DeclT *Import(DeclT *From, Language Lang) { +return cast_or_null(Import(cast(From), Lang)); Is this being used in this PR? Repository: rC Clang CHANGES SINCE

[PATCH] D57278: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

yln added a comment. In D57278#1374852 , @vsk wrote: > Is it necessary to remove visitation of 'noreturn' call sites from ASan? I'd > expect that to break non-C frontends which emit noreturn calls (rust/swift?). Good point! I didn't think about other

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-double-conversion.rst:28 + +Note: Converting to an integer and back to an `absl::Duration` might be a +truncating operation if the value is not aligned to the scale of conversion.

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

hwright added inline comments. Comment at: docs/clang-tidy/checks/abseil-duration-double-conversion.rst:20 + + + // Original - Conversion to integer and back again Eugene.Zelenko wrote: > Unnecessary empty line. This is consistent with other documentation in

[PATCH] D57353: [clang-tidy] Add the abseil-duration-double-conversion check

hwright updated this revision to Diff 184143. hwright marked 5 inline comments as done. hwright added a comment. Address reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57353/new/ https://reviews.llvm.org/D57353 Files: clang-tidy/abseil/AbseilTidyModule.cpp

Re: r350970 - [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

> On Jan 11, 2019, at 4:16 PM, Steven Wu via cfe-commits > wrote: > > Author: steven_wu > Date: Fri Jan 11 13:16:04 2019 > New Revision: 350970 > > URL: http://llvm.org/viewvc/llvm-project?rev=350970=rev > Log: > [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO > >

[PATCH] D53199: Fix the behavior of clang's -w flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rL352535: Fix the behavior of clangs -w flag. (authored by jyknight, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53199?vs=183966=184142#toc

r352535 - Fix the behavior of clang's -w flag.

Author: jyknight Date: Tue Jan 29 11:33:48 2019 New Revision: 352535 URL: http://llvm.org/viewvc/llvm-project?rev=352535=rev Log: Fix the behavior of clang's -w flag. It is intended to disable _all_ warnings, even those upgraded to errors via `-Werror=warningname` or `#pragma clang diagnostic

r352533 - [analyzer] [RetainSummaryManager] [NFC] Split one function into two, as it's really doing two things

Author: george.karpenkov Date: Tue Jan 29 11:29:45 2019 New Revision: 352533 URL: http://llvm.org/viewvc/llvm-project?rev=352533=rev Log: [analyzer] [RetainSummaryManager] [NFC] Split one function into two, as it's really doing two things Differential Revision: https://reviews.llvm.org/D57201

[PATCH] D57201: [analyzer] [RetainSummaryManager] [NFC] Split one function into two, as it's really doing two things

This revision was automatically updated to reflect the committed changes. Closed by commit rC352533: [analyzer] [RetainSummaryManager] [NFC] Split one function into two, as its… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D57344: Extend AnyCall to handle callable declarations without the call expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rC352531: Extend AnyCall to handle callable declarations without the call expressions (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D57346: [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager

This revision was automatically updated to reflect the committed changes. Closed by commit rC352532: [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r352532 - [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager

Author: george.karpenkov Date: Tue Jan 29 11:29:33 2019 New Revision: 352532 URL: http://llvm.org/viewvc/llvm-project?rev=352532=rev Log: [analyzer] [ARCMT] [NFC] Unify entry point into RetainSummaryManager Just use one single entry point, since we have AnyCall utility now. Differential

r352531 - Extend AnyCall to handle callable declarations without the call expressions

Author: george.karpenkov Date: Tue Jan 29 11:29:19 2019 New Revision: 352531 URL: http://llvm.org/viewvc/llvm-project?rev=352531=rev Log: Extend AnyCall to handle callable declarations without the call expressions That weakens inner invariants, but allows the class to be more generic, allowing

[PATCH] D57211: [analyzer] [RetainCountChecker] Support 'taggedRetain' and 'taggedRelease'

This revision was automatically updated to reflect the committed changes. Closed by commit rC352530: [analyzer] [RetainCountChecker] Support taggedRetain and taggedRelease (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r352530 - [analyzer] [RetainCountChecker] Support 'taggedRetain' and 'taggedRelease'

Author: george.karpenkov Date: Tue Jan 29 11:29:07 2019 New Revision: 352530 URL: http://llvm.org/viewvc/llvm-project?rev=352530=rev Log: [analyzer] [RetainCountChecker] Support 'taggedRetain' and 'taggedRelease' Differential Revision: https://reviews.llvm.org/D57211 Modified:

[PATCH] D57405: Revert "OpenCL: Extend argument promotion rules to vector types"

arsenm created this revision. arsenm added reviewers: rjmccall, Anastasia. Herald added subscribers: yaxunl, wdng. This reverts r348083. This was based on a misreading of the spec for printf specifiers. Also revert r343653, as without a subsequent patch, a correctly specified format for

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

george.karpenkov added a comment. After this landed, options for RetainCountChecker stopped working - e.g. I can't use `osx.cocoa.RetainCount:blah=X`. Do you know why is this the case / how to fix it? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54438/new/

[PATCH] D57404: build: remove use of llvm-config

mgorny added a comment. Will overriding `LLVM_BUILD_MAIN_SRC_DIR` work? Gentoo relies on being able to provide sources in another directory since all builds are done in isolated temporary directories. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57404/new/

Re: r352524 - Rollback unwindlib patch.

Hi Sterling, For a rollback, it's useful to list in the commit message why the change is being rolled back. Thanks! On Tue, 29 Jan 2019, 10:27 Sterling Augustine via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Author: saugustine > Date: Tue Jan 29 10:27:51 2019 > New Revision: 352524 >

[PATCH] D57404: build: remove use of llvm-config

compnerd created this revision. compnerd added reviewers: chandlerc, rnk. Herald added a subscriber: mgorny. Update the CMake build to use the LLVM CMake Config package rather than invoking `llvm-config` to find the parameters. Users can specify `-DLLVM_DIR=` to CMake to indicate where the

r352526 - [OPENMP]Make the loop with unsigned counter countable.

Author: abataev Date: Tue Jan 29 10:51:58 2019 New Revision: 352526 URL: http://llvm.org/viewvc/llvm-project?rev=352526=rev Log: [OPENMP]Make the loop with unsigned counter countable. According to the report, better to keep the original strict compare operation as the loop condition with

r352524 - Rollback unwindlib patch.

Author: saugustine Date: Tue Jan 29 10:27:51 2019 New Revision: 352524 URL: http://llvm.org/viewvc/llvm-project?rev=352524=rev Log: Rollback unwindlib patch. Removed: cfe/trunk/test/Driver/compiler-rt-unwind.c Modified: cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D18914: [clang-tidy] new readability-redundant-inline

sbenza added a comment. In D18914#396149 , @mgehre wrote: > ... > I personally think that 1) should be used, because late one could move the > function definition to a source file (removing the inline) without having to > touch > the class declaration.

[PATCH] D56927: Disable PIC/PIE for MSP430 target

dmikushin updated this revision to Diff 184118. dmikushin added a comment. Unbreaking patch by providing an appropriate toolchain requirement Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56927/new/ https://reviews.llvm.org/D56927 Files:

[PATCH] D57390: OpenCL: Don't promote vector args to printf

rjmccall added inline comments. Comment at: include/clang/AST/FormatString.h:70 AsShort, // 'h' +AsInt,// 'hl' (OpenCL float/int vector element) AsLong, // 'l' I think giving this a weird name like `AsShortLong` might help make

[PATCH] D56925: Do not use frame pointer by default for MSP430

dmikushin updated this revision to Diff 184116. dmikushin edited the summary of this revision. dmikushin added a comment. Unbreaking clang driver patch. Not using calla asm instruction, as recomended. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56925/new/

[PATCH] D33841: [clang-tidy] redundant keyword check

koldaniel updated this revision to Diff 184111. koldaniel added a comment. As it was mentioned earlier, I think it would be a better way forward to handle the check of redundant inlines in the scope of the other checker: https://reviews.llvm.org/D18914 CHANGES SINCE LAST ACTION

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

mclow.lists added a comment. In D44823#1375590 , @mclow.lists wrote: > I just tried this (on Compiler Explorer) using LLVM 7, and the code for my > original test in https://bugs.llvm.org/show_bug.cgi?id=35637 is now optimal. Pilot error - it's still

  1   2   >